Remove residual blank line at start of MakefileThis is a residual of the $FreeBSD$ removal.MFC After: 3 days (though I'll just run the command on the branches)Sponsored by: Netflix
Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/
META MODE: Update dependencies with 'the-lot' and add missing directories.This is not properly respecting WITHOUT or ARCH dependencies in target/.Doing so requires a massive effort to rework targe
META MODE: Update dependencies with 'the-lot' and add missing directories.This is not properly respecting WITHOUT or ARCH dependencies in target/.Doing so requires a massive effort to rework targets/ to do so. Abetter approach will be to either include the SUBDIR Makefiles directlyand map to DIRDEPS or just dynamically lookup the SUBDIR. These losethe benefit of having a userland/lib, userland/libexec, etc, though andresults in a massive package. The current implementation of targets/ isvery unmaintainable.Currently rescue/rescue and sys/modules are still not connected.Sponsored by: EMC / Isilon Storage Division
show more ...
META MODE: These need object directories to handle staging.Sponsored by: EMC / Isilon Storage Division
Eliminate sub-shells where possible for performance.MFC after: 7 days
Revert SVN r278464 -- fingers were in perforce mode (prematurecommit of future stuffs not yet ready).
Replace the only instance of sed(1) in bsdconfig(8) with awk(1).MFC after: 3 days
Follow-up to r255036; remove beforeinstall directives from bsdconfig(8)Makefile's, fixing concurrent installworld (`make -j17 installworld').Thanks to: delphij, emasteReviewed by: delphijMFC aft
Follow-up to r255036; remove beforeinstall directives from bsdconfig(8)Makefile's, fixing concurrent installworld (`make -j17 installworld').Thanks to: delphij, emasteReviewed by: delphijMFC after: 3 daysX-MFC-to: stable/10, stable/9
Remove useless NULL string '' in compound strings. Look very closely.
Performance and debugging enhancements:+ Remove UNAME_P=$(...) from startup/misc -- already supplied by common.subr+ Use f_getvar instead of $(eval echo \$$var) -- f_getvar is sub-shell free+ Add
Performance and debugging enhancements:+ Remove UNAME_P=$(...) from startup/misc -- already supplied by common.subr+ Use f_getvar instead of $(eval echo \$$var) -- f_getvar is sub-shell free+ Add `-e' and `-k var' options to f_eval_catch -- increasing use-cases+ Use f_eval_catch to display errors on failure -- reducing duplicated code+ Use f_eval_catch when we need output from a command -- improving debugging+ Optimize f_isinter of strings.subr for performance -- now sub-shell free+ Improve error checking on pidfiles -- using f_eval_catch and f_isinteger+ Use $var_to_set arg of f_ifconfig_{inet,netmask} -- eliminate sub-shells+ Use f_sprintf instead of $(printf ...) -- consolidate sub-shells+ Use $var_to_set arg of f_route_get_default -- eliminate sub-shells+ Add f_count to replace $(set -- ...;echo $#) -- eliminate sub-shells+ Add f_count_ifs to replace $(IFS=x;set -- ...;echo $#) -- no sub-shells+ Replace var="$var${var:+ }..." in loops with var="$var ..." with a follow- up var="${var# }" to trim leading whitespace -- optimize loops+ Use $var_to_set arg of f_resolv_conf_nameservers -- eliminate sub-shells+ Comments for the f_eval_catch function+ Remove a duplicate `local ... desc ...' in f_device_get_all of device.subr+ Use $var_to_set arg of f_device_capacity -- eliminate sub-shells+ Whitespace fixes in f_dialog_init of dialog.subr+ Optimize f_inet_atoi of media/tcpip.subr for performance -- sub-shell free+ In several cases, send stderr to /dev/null -- clean up runtime execution+ Change f_err of common.subr to go to program stderr not terminal stderr, allowing redirection of output from functions that use f_err+ Disable debugging when using f_getvar to get variable argument to f_startup_rcconf_map_expand of startup/rcconf.subr+ Use f_replace_all instead of $(echo ... | tr | sed) -- performance+ Add a $var_to_set option to f_index_{file,menusel_{command,keyword}} of common.subr -- centralize sub-shells
Fix typos in the BSD License.
Be consistent with other usr.sbin programs w/respect to the copyrightwording ("All rights reserved."); I had the casing wrong on many instances.
Change a humongous if-statement at the end of f_install_zoneinfo_file() intoan early return, allowing a huge chunk of code to be indented one-level less
When I first wrote the timezone module, it was in sysutils/tzdialog and itpre-dates bsdconfig. Update the code to take advantage of f_dialog_msgbox().
Improve portion of the dialog(1) API in dialog.subr responsible forcalculating widget sizes. Instead of forking a sub-shell to calculate theoptimum size for a widget, use a byRef style call-out to
Improve portion of the dialog(1) API in dialog.subr responsible forcalculating widget sizes. Instead of forking a sub-shell to calculate theoptimum size for a widget, use a byRef style call-out to set variables inthe parent namespace. For example, instead of: size=$( f_dialog_buttonbox_size title btitle msg ) $DIALOG --title title --backtitle btitle --msgbox msg $sizeThe new API replaces the above with the following: f_dialog_buttonbox_size height width title btitle msg $DIALOG --title title --backtitle btitle --msgbox msg $height $widthThis reduces the number of forks, improves performance, and makes the codemore readable by revealing the argument-order for widget sizing. It alsomakes performing minor adjustments to the calculated values easier asyou no longer have to split-out the response (which required knowledge ofordering so was counter-intuitive).
Add more debugging to help with diagnosis of program-flow when needed.
Whitespace.Approved by: adrian (co-mentor) (implicit)
jilles accurately advises that, in the context of shell redirection, the `:'builtin is processed specially and thus the `: > file' syntax for examplewill cause premature termination of the current
jilles accurately advises that, in the context of shell redirection, the `:'builtin is processed specially and thus the `: > file' syntax for examplewill cause premature termination of the current shell on redirection-error.The `true' builtin on the other-hand is not included in this specialprocessing (for compatibility reasons to satisfy legacy scripts programmedfor systems where `true' is not a builtin).Change bare `: > file' syntax into `true > file' syntax to prevent prematureshell termination in the event of redirection-error.NOTE: Instances of `: > file' that appear within a sub-shell have been leftunmodified as these will not cause premature termination of the main script.Reviewed by: jilles, adrian (co-mentor)Approved by: adrian (co-mentor)
Reverse SVN r240770 -- jilles@ made a suggestion that allowed us to redesignour embedded rescue environment to support /dev/null making r240770 obsolete.Reviewed by: jilles, adrian (co-mentor)App
Reverse SVN r240770 -- jilles@ made a suggestion that allowed us to redesignour embedded rescue environment to support /dev/null making r240770 obsolete.Reviewed by: jilles, adrian (co-mentor)Approved by: jilles, adrian (co-mentor)
Replace redirections to /dev/null with "close file-descriptor" syntax (>&-).Reviewed by: adrian (co-mentor)Approved by: adrian (co-mentor)
Move major includes into /usr/share/bsdconfig for easy external access.Reviewed by: adrian (co-mentor)Approved by: adrian (co-mentor)