tests: don't run atf_* in a subshellShell limitation is that a classic function call via $() is a subshelland atf-sh(3) commands won't work as epxected there. Subsequently,atf_skip inside a func
tests: don't run atf_* in a subshellShell limitation is that a classic function call via $() is a subshelland atf-sh(3) commands won't work as epxected there. Subsequently,atf_skip inside a function won't skip a test. The test will fail later.A working approach is to pass desired variable name as argument toa function and don't run subshell.Reviewed by: ngieDifferential Revision: https://reviews.freebsd.org/D42646Fixes: ea82362219ee715cfbb195b2114e73fdc8599fa5
show more ...
Remove $FreeBSD$: one-line sh patternRemove /^\s*#[#!]?\s*\$FreeBSD\$.*$\n/
Make test scripts under tests/... non-executableExecutable bits should be set at install time instead of in the repo.Setting executable bits on files triggers false positives with Phabricator.MF
Make test scripts under tests/... non-executableExecutable bits should be set at install time instead of in the repo.Setting executable bits on files triggers false positives with Phabricator.MFC after: 2 months
Change fs image name so it will not be regenerated (wehave both big and little-endian images in tree).Also we don't known the endianness of the platform theimage was generated on.Sponsored by: D
Change fs image name so it will not be regenerated (wehave both big and little-endian images in tree).Also we don't known the endianness of the platform theimage was generated on.Sponsored by: DARPA, AFRLSponsored by: HEIF5
Add big-endian uzip file system and choose right file systemto proceed tests with.Reviewed by: jmmv, ngieSponsored by: DARPA, AFRLSponsored by: HEIF5Differential Revision: https://reviews.freeb
Add big-endian uzip file system and choose right file systemto proceed tests with.Reviewed by: jmmv, ngieSponsored by: DARPA, AFRLSponsored by: HEIF5Differential Revision: https://reviews.freebsd.org/D8073
Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedafter r298107Summary of changes:- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that na
Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedafter r298107Summary of changes:- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that namespacing is kept with FILES appropriately, and that this shouldn't need to be repeated if the namespace changes -- only the definition of PACKAGE needs to be changed- Allow PACKAGE to be overridden by callers instead of forcing it to always be `tests`. In the event we get to the point where things can be split up enough in the base system, it would make more sense to group the tests with the blocks they're a part of, e.g. byacc with byacc-tests, etc- Remove PACKAGE definitions where possible, i.e. where FILES wasn't used previously.- Remove unnecessary TESTSPACKAGE definitions; this has been elided into bsd.tests.mk- Remove unnecessary BINDIRs used previously with ${PACKAGE}FILES; ${PACKAGE}FILESDIR is now automatically defined in bsd.test.mk.- Fix installation of files under data/ subdirectories in lib/libc/tests/hash and lib/libc/tests/net/getaddrinfo- Remove unnecessary .include <bsd.own.mk>s (some opportunistic cleanup)Document the proposed changes in share/examples/tests/tests/... via examplesso it's clear that ${PACKAGES}FILES is the suggested way forward in terms ofreplacing FILES. share/mk/bsd.README didn't seem like the appropriate methodof communicating that info.MFC after: never probablyX-MFC with: r298107PR: 209114Relnotes: yesTested with: buildworld, installworld, checkworld; buildworld, packageworldSponsored by: EMC / Isilon Storage Division
MFHSponsored by: The FreeBSD Foundation
DIRDEPS_BUILD: Connect MK_TESTS.Sponsored by: EMC / Isilon Storage Division
Final pass through to fix 'tests' packaging.Sponsored by: The FreeBSD Foundation
More 'tests' packaging fixes.Sponsored by: The FreeBSD Foundation
Integratetools/regression/geom_{concat,eli,gate,mirror,nop,raid3,shsec,stripe,uzip}in to the FreeBSD test suite astests/sys/geom/class/{concat,eli,gate,mirror,nop,raid3,shsec,stripe,uzip}The too
Integratetools/regression/geom_{concat,eli,gate,mirror,nop,raid3,shsec,stripe,uzip}in to the FreeBSD test suite astests/sys/geom/class/{concat,eli,gate,mirror,nop,raid3,shsec,stripe,uzip}The tools/regression/geom and tools/regression/geom_part testcases are beingleft alone because both test sets are both currently broken.The majority of this work was done on ^/user/ngie/more-tests2 . The differencesare as follows:- tests/sys/geom/class/Makefile.inc is not present; it was inlined into the class's Makefiles for explicitness.- The testcases officially require root via kyua- The geom_gate(4) tests don't use the pidfile changes proposed in https://reviews.freebsd.org/D4836 .MFC after: 1 monthSponsored by: EMC / Isilon Storage Division