Fixup some incorrect information and some comments. These changeswere cherry picked up the upstream OpenBSD repository. At some point wewill look at doing another import, but the diffs are substant
Fixup some incorrect information and some comments. These changeswere cherry picked up the upstream OpenBSD repository. At some point wewill look at doing another import, but the diffs are substantial and willrequire some careful testing.Differential Revision: https://reviews.freebsd.org/D25021MFC after: 2 weeksSubmitted by: gbeReviewed by: myself, bcr
show more ...
In r316006 the getstrfromtype_locked() function was modified to returnan empty string, instead of NULL, if an entry is missing in the audit_controlfile. Because of that change the getachost() funct
In r316006 the getstrfromtype_locked() function was modified to returnan empty string, instead of NULL, if an entry is missing in the audit_controlfile. Because of that change the getachost() function started to returnsuccess even if the host name was not defined in the audit_control.This in turn led to auditd_hostlen always being set (for an empty host it wasset to 0). If auditd_hostlen was not equal to -1 we were trying to appendthe host name to trail file name. All this led to situation where when hostname is not defined in audit_control, auditd will create trail files witha leading '.', which breaks auditdistd as it doesn't work with longer audittrail file names.Fix this by appending host name to the trail file name only if the host nameis not empty.
auditd(8): Log a better error when no hostname is set in audit_controlCherry-pick from https://github.com/openbsm/openbsm/commit/01ba03bReviewed by: cemObtained from: OpenBSMMFC after: 2 weeks
auditd(8): Log a better error when no hostname is set in audit_controlCherry-pick from https://github.com/openbsm/openbsm/commit/01ba03bReviewed by: cemObtained from: OpenBSMMFC after: 2 weeksPull Request: https://github.com/openbsm/openbsm/pull/38
Merge OpenBSM 1.2-alpha5 from vendor branch to FreeBSD -CURRENT:- Add a new "qsize" parameter in audit_control and the getacqsize(3) API to query it, allowing to set the kernel's maximum audit qu
Merge OpenBSM 1.2-alpha5 from vendor branch to FreeBSD -CURRENT:- Add a new "qsize" parameter in audit_control and the getacqsize(3) API to query it, allowing to set the kernel's maximum audit queue length.- Add support to push a mapping between audit event names and event numbers into the kernel (where supported) using new A_GETEVENT and A_SETEVENT auditon(2) operations.- Add audit event identifiers for a number of new (and not-so-new) FreeBSD system calls including those for asynchronous I/O, thread management, SCTP, jails, multi-FIB support, and misc. POSIX interfaces such as posix_fallocate(2) and posix_fadvise(2).- On operating systems supporting Capsicum, auditreduce(1) and praudit(1) now run sandboxed.- Empty "flags" and "naflags" fields are now permitted in audit_control(5).Many thanks to Christian Brueffer for producing the OpenBSM release andimporting/tagging it in the vendor branch. This release will allow improvedauditing of a range of new FreeBSD functionality, as well as non-traditionalevents (e.g., fine-grained I/O auditing) not required by the Orange Book orCommon Criteria.Obtained from: TrustedBSD ProjectSponsored by: DARPA, AFRLMFC after: 3 weeks
Merge OpenBSM 1.2 alpha 4.MFC after: 2 weeksRelnotes: yes
Merge OpenBSM 1.2-alpha2 from vendor branch to FreeBSD 10-CURRENT; theprimary new feature is auditdistd.Obtained from: TrustedBSD ProjectSponsored by: The FreeBSD Foundation (auditdistd)
Merge a local fix to OpenBSM's libauditd to avoid a directory descriptorleak when iterating over possible audit trail directories. This fix willbe merged upstream in an identical form, but hasn't
Merge a local fix to OpenBSM's libauditd to avoid a directory descriptorleak when iterating over possible audit trail directories. This fix willbe merged upstream in an identical form, but hasn't yet appeared in anOpenBSM release.Submitted by: guidoObtained from: TrustedBSD ProjectMFC after: 3 days
Import OpenBSM 1.1p1 from vendor branch to 8-CURRENT, populatingcontrib/openbsm and a subset also imported into sys/security/audit.This patch release addresses several minor issues:- Fixes to AUT
Import OpenBSM 1.1p1 from vendor branch to 8-CURRENT, populatingcontrib/openbsm and a subset also imported into sys/security/audit.This patch release addresses several minor issues:- Fixes to AUT_SOCKUNIX token parsing.- IPv6 support for au_to_me(3).- Improved robustness in the parsing of audit_control, especially long flags/naflags strings and whitespace in all fields.- Add missing conversion of a number of FreeBSD/Mac OS X errnos to/from BSM error number space.MFC after: 3 weeksObtained from: TrustedBSD ProjectSponsored by: Apple, Inc.Approved by: re (kib)
Merge OpenBSM 1.1 from OpenBSM vendor branch to head.OpenBSM history for imported revision below for reference.MFC after: 2 weeksSponsored by: Apple, Inc.Obtained from: TrustedBSD Proje
Merge OpenBSM 1.1 from OpenBSM vendor branch to head.OpenBSM history for imported revision below for reference.MFC after: 2 weeksSponsored by: Apple, Inc.Obtained from: TrustedBSD ProjectOpenBSM 1.1- Change auditon(2) parameters and data structures to be 32/64-bit architecture independent. Add more information to man page about auditon(2) parameters.- Add wrapper functions for auditon(2) to use legacy commands when the new commands are not supported.- Add default for 'expire-after' in audit_control to expire trail files when the audit directory is more than 10 megabytes ('10M').- Interface to convert between local and BSM fcntl(2) command values has been added: au_bsm_to_fcntl_cmd(3) and au_fcntl_cmd_to_bsm(3), along with definitions of constants in audit_fcntl.h.- A bug, introduced in OpenBSM 1.1 alpha 4, in which AUT_RETURN32 tokens generated by audit_submit(3) were improperly encoded has been fixed.- Fix example in audit_submit(3) man page. Also, make it clear that we want the audit ID as the argument.- A new audit event class 'aa', for post-login authentication and authorization events, has been added.
Merge OpenBSM 1.1 beta 1 from OpenBSM vendor branch to head, bothcontrib/openbsm (svn merge) and src/sys/{bsm,security/audit} (manualmerge).OpenBSM history for imported revision below for referen
Merge OpenBSM 1.1 beta 1 from OpenBSM vendor branch to head, bothcontrib/openbsm (svn merge) and src/sys/{bsm,security/audit} (manualmerge).OpenBSM history for imported revision below for reference.MFC after: 1 monthSponsored by: Apple, Inc.Obtained from: TrustedBSD ProjectOpenBSM 1.1 beta 1- The filesz parameter in audit_control(5) now accepts suffixes: 'B' for Bytes, 'K' for Kilobytes, 'M' for Megabytes, and 'G' for Gigabytes. For legacy support no suffix defaults to bytes.- Audit trail log expiration support added. It is configured in audit_control(5) with the expire-after parameter. If there is no expire-after parameter in audit_control(5), the default, then the audit trail files are not expired and removed. See audit_control(5) for more information.- Change defaults in audit_control: warn at 5% rather than 20% free for audit partitions, rotate automatically at 2mb, and set the default policy to cnt,argv rather than cnt so that execve(2) arguments are captured if AUE_EXECVE events are audited. These may provide more usable defaults for many users.- Use au_domain_to_bsm(3) and au_socket_type_to_bsm(3) to convert au_to_socket_ex(3) arguments to BSM format.- Fix error encoding AUT_IPC_PERM tokens.
Merge OpenBSM alpha 5 from OpenBSM vendor branch to head, bothcontrib/openbsm (svn merge) and src/sys/{bsm,security/audit} (manualmerge). Hook up bsm_domain.c and bsm_socket_type.c to the libbsmb
Merge OpenBSM alpha 5 from OpenBSM vendor branch to head, bothcontrib/openbsm (svn merge) and src/sys/{bsm,security/audit} (manualmerge). Hook up bsm_domain.c and bsm_socket_type.c to the libbsmbuild along with man pages, add audit_bsm_domain.c andaudit_bsm_socket_type.c to the kernel environment.OpenBSM history for imported revisions below for reference.MFC after: 1 monthSponsored by: Apple Inc.Obtained from: TrustedBSD ProjectOpenBSM 1.1 alpha 5- Stub libauditd(3) man page added.- All BSM error number constants with BSM_ERRNO_.- Interfaces to convert between local and BSM socket types and protocol families have been added: au_bsm_to_domain(3), au_bsm_to_socket_type(3), au_domain_to_bsm(3), and au_socket_type_to_bsm(3), along with definitions of constants in audit_domain.h and audit_socket_type.h. This improves interoperability by converting local constant spaces, which vary by OS, to and from Solaris constants (where available) or OpenBSM constants for protocol domains not present in Solaris (a fair number). These routines should be used when generating and interpreting extended socket tokens.- Fix build warnings with full gcc warnings enabled on most supported platforms.- Don't compile error strings into bsm_errno.c when building it in the kernel environment.- When started by launchd, use the label com.apple.auditd rather than org.trustedbsd.auditd.
Merge OpenBSM alpha 4 from OpenBSM vendor branch to head, bothcontrib/openbsm (svn merge) and src/sys/{bsm,security/audit} (manualmerge). Add libauditd build parts and add to auditd's linkage;for
Merge OpenBSM alpha 4 from OpenBSM vendor branch to head, bothcontrib/openbsm (svn merge) and src/sys/{bsm,security/audit} (manualmerge). Add libauditd build parts and add to auditd's linkage;force libbsm to build before libauditd.OpenBSM history for imported revisions below for reference.MFC after: 1 monthSponsored by: Apple Inc.Obtained from: TrustedBSD ProjectOpenBSM 1.1 alpha 4- With the addition of BSM error number mapping, we also need to map the local error number passed to audit_submit(3) to a BSM error number, rather than have the caller perform that conversion.- Reallocate user audit events to avoid collisions with Solaris; adopt a more formal allocation scheme, and add some events allocated in Solaris that will be of immediate use on other platforms.- Add an event for Calife.- Add au_strerror(3), which allows generating strings for BSM errors directly, rather than requiring applications to map to the local error space, which might not be able to entirely represent the BSM error number space.- Major auditd rewrite for launchd(8) support. Add libauditd library that is shared between launchd and auditd.- Add AUDIT_TRIGGER_INITIALIZE trigger (sent via 'audit -i') for (re)starting auditing under launchd(8) on Mac OS X.- Add 'current' symlink to active audit trail.- Add crash recovery of previous audit trail file when detected on audit startup that it has not been properly terminated.- Add the event AUE_audit_recovery to indicated when an audit trail file has been recovered from not being properly terminated. This event is stored in the new audit trail file and includes the path of recovered audit trail file.- Mac OS X and FreeBSD dependent code in auditd.c is separated into auditd_darwin.c and auditd_fbsd.c files.- Add an event for the posix_spawn(2) and fsgetpath(2) Mac OS X system calls.- For Mac OS X, we use ASL(3) instead of syslog(3) for logging.- Add support for NOTICE level logging.OpenBSM 1.1 alpha 3- Add two new functions, au_bsm_to_errno() and au_errno_to_bsm(), to map between BSM error numbers (largely the Solaris definitions) and local errno(2) values for 32-bit and 64-bit return tokens. This is required as operating systems don't agree on some of the values of more recent error numbers.- Fix a bug how au_to_exec_args(3) and au_to_exec_env(3) calculates the total size for the token. This buge.- Deprecated Darwin constants, such as TRAILER_PAD_MAGIC, removed.