tftpd: Simplify packet drop macro

The first argument is always the function name, for which we can simply
use __func__. This leaves only the optional return value, so we can use
a single variadic m

tftpd: Simplify packet drop macro

The first argument is always the function name, for which we can simply
use __func__. This leaves only the optional return value, so we can use
a single variadic macro instead of two nearly-identical copies.

MFC after: 1 week
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D57076

show more ...

tftpd: Add missing bounds checks

In send_[rw]rq(), we were using strlcpy() to avoid overflowing our
packet buffer, then failing to check the result and blithely advancing
our pointer by the full len

tftpd: Add missing bounds checks

In send_[rw]rq(), we were using strlcpy() to avoid overflowing our
packet buffer, then failing to check the result and blithely advancing
our pointer by the full length.

Luckily, this code is only ever used by tftp(1), not tftpd(8).

MFC after: 1 week
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D57075

show more ...