media: ge2d: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error h
media: ge2d: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is (mostly) ignoredand this typically results in resource leaks. To improve here there is aquest to make the remove callback return void. In the first step of thisquest all drivers are converted to .remove_new() which already returnsvoid.Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
show more ...
media: platform: fix some double free in meson-ge2d and mtk-jpeg and s5p-mfcvideo_unregister_device will release device internally. There is no need tocall video_device_release after video_unregis
media: platform: fix some double free in meson-ge2d and mtk-jpeg and s5p-mfcvideo_unregister_device will release device internally. There is no need tocall video_device_release after video_unregister_device.Signed-off-by: Hangyu Hua <hbh25y@gmail.com>Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
media: Kconfig: cleanup VIDEO_DEV dependenciesmedia Kconfig has two entries associated to V4L API:VIDEO_DEV and VIDEO_V4L2.On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.V
media: Kconfig: cleanup VIDEO_DEV dependenciesmedia Kconfig has two entries associated to V4L API:VIDEO_DEV and VIDEO_V4L2.On Kernel 2.6.x, there were two V4L APIs, each one with its own flag.VIDEO_DEV were meant to: 1) enable Video4Linux and make its Kconfig options to appear; 2) it makes the Kernel build the V4L core.while VIDEO_V4L2 where used to distinguish between drivers thatimplement the newer API and drivers that implemented the former one.With time, such meaning changed, specially after the removal ofall V4L version 1 drivers.At the current implementation, VIDEO_DEV only does (1): it enablesthe media options related to V4L, that now has: menu "Video4Linux options" visible if VIDEO_DEV source "drivers/media/v4l2-core/Kconfig" endmenubut it doesn't affect anymore the V4L core drivers.The rationale is that the V4L2 core has a "soft" dependencyat the I2C bus, and now requires to select a number of otherKconfig options: config VIDEO_V4L2 tristate depends on (I2C || I2C=n) && VIDEO_DEV select RATIONAL select VIDEOBUF2_V4L2 if VIDEOBUF2_CORE default (I2C || I2C=n) && VIDEO_DEVIn the past, merging them would be tricky, but it seems that it is nowpossible to merge those symbols, in order to simplify V4L dependencies.Let's keep VIDEO_DEV, as this one is used on some make *defconfigconfigurations.Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> # for meson-vdec & meson-ge2dAcked-by: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>Acked-by: Łukasz Stelmach <l.stelmach@samsung.com>Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
media: platform: rename meson/ge2d/ to amlogic/meson-ge2d/As the end goal is to have platform drivers split by vendor,rename meson/ge2d/ to amlogic/meson-ge2d/.Acked-by: Neil Armstrong <narmstro
media: platform: rename meson/ge2d/ to amlogic/meson-ge2d/As the end goal is to have platform drivers split by vendor,rename meson/ge2d/ to amlogic/meson-ge2d/.Acked-by: Neil Armstrong <narmstrong@baylibre.com>Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>