3545deff | 08-May-2024 |
Kees Cook <kees@kernel.org> |
binfmt_elf: Honor PT_LOAD alignment for static PIE
The p_align values in PT_LOAD were ignored for static PIE executables (i.e. ET_DYN without PT_INTERP). This is because there is no way to request a
binfmt_elf: Honor PT_LOAD alignment for static PIE
The p_align values in PT_LOAD were ignored for static PIE executables (i.e. ET_DYN without PT_INTERP). This is because there is no way to request a non-fixed mmap region with a specific alignment. ET_DYN with PT_INTERP uses a separate base address (ELF_ET_DYN_BASE) and binfmt_elf performs the ASLR itself, which means it can also apply alignment. For the mmap region, the address selection happens deep within the vm_mmap() implementation (when the requested address is 0).
The earlier attempt to implement this:
commit 9630f0d60fec ("fs/binfmt_elf: use PT_LOAD p_align values for static PIE") commit 925346c129da ("fs/binfmt_elf: fix PT_LOAD p_align values for loaders")
did not take into account the different base address origins, and were eventually reverted:
aeb7923733d1 ("revert "fs/binfmt_elf: use PT_LOAD p_align values for static PIE"")
In order to get the correct alignment from an mmap base, binfmt_elf must perform a 0-address load first, then tear down the mapping and perform alignment on the resulting address. Since this is slightly more overhead, only do this when it is needed (i.e. the alignment is not the default ELF alignment). This does, however, have the benefit of being able to use MAP_FIXED_NOREPLACE, to avoid potential collisions.
With this fixed, enable the static PIE self tests again.
Reported-by: H.J. Lu <hjl.tools@gmail.com> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=215275 Link: https://lore.kernel.org/r/20240508173149.677910-3-keescook@chromium.org Signed-off-by: Kees Cook <kees@kernel.org>
show more ...
|
472874cf | 15-Mar-2024 |
Kees Cook <keescook@chromium.org> |
selftests/exec: Convert remaining /bin/sh to /bin/bash
As was intended with commit 17107429947b ("selftests/exec: Perform script checks with /bin/bash"), convert the other instance of /bin/sh to /bi
selftests/exec: Convert remaining /bin/sh to /bin/bash
As was intended with commit 17107429947b ("selftests/exec: Perform script checks with /bin/bash"), convert the other instance of /bin/sh to /bin/bash. It appears that at least Debian Bookworm's /bin/sh (dash) does not conform to POSIX's "return 127 when script not found" requirement.
Fixes: 17107429947b ("selftests/exec: Perform script checks with /bin/bash") Reported-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Closes: https://lore.kernel.org/lkml/02c8bf8e-1934-44ab-a886-e065b37366a7@collabora.com/ Signed-off-by: Kees Cook <keescook@chromium.org>
show more ...
|
0ef58ccb | 13-Mar-2024 |
Kees Cook <keescook@chromium.org> |
selftests/exec: execveat: Improve debug reporting
Children processes were reporting their status, duplicating the parent's. Remove that, and add some additional details about the test execution.
Re
selftests/exec: execveat: Improve debug reporting
Children processes were reporting their status, duplicating the parent's. Remove that, and add some additional details about the test execution.
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Link: https://lore.kernel.org/r/20240313185606.work.073-kees@kernel.org Signed-off-by: Kees Cook <keescook@chromium.org>
show more ...
|
1d0e51b2 | 04-Mar-2024 |
Muhammad Usama Anjum <usama.anjum@collabora.com> |
selftests/exec: recursion-depth: conform test to TAP format output
Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output mess
selftests/exec: recursion-depth: conform test to TAP format output
Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. While at it, do minor cleanups like move the declarations of the variables on top of the function.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Link: https://lore.kernel.org/r/20240304155928.1818928-3-usama.anjum@collabora.com Signed-off-by: Kees Cook <keescook@chromium.org>
show more ...
|
c4095067 | 04-Mar-2024 |
Muhammad Usama Anjum <usama.anjum@collabora.com> |
selftests/exec: load_address: conform test to TAP format output
Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output message
selftests/exec: load_address: conform test to TAP format output
Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Link: https://lore.kernel.org/r/20240304155928.1818928-2-usama.anjum@collabora.com Signed-off-by: Kees Cook <keescook@chromium.org>
show more ...
|
99f5819b | 04-Mar-2024 |
Muhammad Usama Anjum <usama.anjum@collabora.com> |
selftests/exec: binfmt_script: Add the overall result line according to TAP
The following line is missing from the test's execution. Add it to make it fully TAP conformant: # Totals: pass:27 fail:
selftests/exec: binfmt_script: Add the overall result line according to TAP
The following line is missing from the test's execution. Add it to make it fully TAP conformant: # Totals: pass:27 fail:0 xfail:0 xpass:0 skip:0 error:0
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com> Reviewed-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20240304155928.1818928-1-usama.anjum@collabora.com Signed-off-by: Kees Cook <keescook@chromium.org>
show more ...
|