DIRDEPS_BUILD: Update dependencies.Sponsored by: Dell EMC Isilon
Check the exit code from fsck_ffs instead of relying on MODIFIED being in the output^/head@r323923 changed when MODIFIED is printed at exit. It's better to follow thedocumented way of determining
Check the exit code from fsck_ffs instead of relying on MODIFIED being in the output^/head@r323923 changed when MODIFIED is printed at exit. It's better to follow thedocumented way of determining whether or not a filesystem is clean per fsck_ffs, i.e.,ensure that the exit code is either 0 or 7.The pass/fail determination is brittle prior to this commit, and ^/head@r323923 madethe issue apparent -- thus this needs to be fixed independent of ^/head@r323923.PR: 222780MFC after: 1 weekMFC with: r323923Reported by: Jenkins
show more ...
Add supporting changes for `Add limited sandbox capability to "make check"`Non-tests/... changes:- Add HAS_TESTS= to Makefiles with libraries and programs to enable iteration and propagate the a
Add supporting changes for `Add limited sandbox capability to "make check"`Non-tests/... changes:- Add HAS_TESTS= to Makefiles with libraries and programs to enable iteration and propagate the appropriate environment down to *.test.mk.tests/... changes:- Add appropriate support Makefile.inc's to set HAS_TESTS in a minimal manner, since tests/... is a special subdirectory tree compared to the others.MFC after: 2 monthsMFC with: r322511Reviewed by: arch (silence), testing (silence)Differential Revision: D12014
Make test scripts under tests/... non-executableExecutable bits should be set at install time instead of in the repo.Setting executable bits on files triggers false positives with Phabricator.MF
Make test scripts under tests/... non-executableExecutable bits should be set at install time instead of in the repo.Setting executable bits on files triggers false positives with Phabricator.MFC after: 2 months
Use MK_CHECK_USE_SANDBOX in tests/..., to deal with the fact thattests/... is a special snowflake directory and using HAS_TESTS wouldresult in a nasty layering violation between bsd.tests.mk andbs
Use MK_CHECK_USE_SANDBOX in tests/..., to deal with the fact thattests/... is a special snowflake directory and using HAS_TESTS wouldresult in a nasty layering violation between bsd.tests.mk andbsd.prog.mk.Add reachover Makefile.inc's which get the default value fromMakefile.inc0 (inspired by gnu/usr.bin/binutils/Makefile.inc0).
Remove superfluous `exit 0` added in r321702atf_skip triggers equivalent functionality, which means the `exit 0`is unreachable code.PR: 220164MFC after: 1 monthMFC with: r321702
Load geom_gate(4) if necessary before running tests; skip if it can't be loadedThe test code prior to r311893 loaded geom_gate at test start if necessary andskipped the tests if it couldn't be loa
Load geom_gate(4) if necessary before running tests; skip if it can't be loadedThe test code prior to r311893 loaded geom_gate at test start if necessary andskipped the tests if it couldn't be loaded.The ATF-ifcation of this test done in r311893 unfortunately dropped thisfunctionality.This change restores the geom_gate module load and skips the test(s) if unavailablein an ATF-like way.MFC after: 1 monthPR: 220164Reported by: gjb
Add regression tests for r317712 and r306743.MFC after: 2 weeksSponsored by: Dell EMC Isilon
Fix buildworld broken in r315230 when /sys doesn't point into a rightsource tree. Usage of SYSDIR is apparently wrong here.Discussed with: allanjude
Move .../sys/geom/eli/pbkdf2... to .../sys/geom/class/eli/...This change moves the tests added in r313962 to an existing directorystructure used by the geli TAP tests. It also, renames the test fr
Move .../sys/geom/eli/pbkdf2... to .../sys/geom/class/eli/...This change moves the tests added in r313962 to an existing directorystructure used by the geli TAP tests. It also, renames the test frompbkdf2 to pbkdf2_test .The changes to ObsoleteFiles.inc are being committed separately as theyaren't needed for the MFC to ^/stable/11, etc, if the MFC for the testsis done all in one commit.MFC after: 2 weeksX-MFC with: r313962, r313972-r313973Reviewed by: allanjudeSponsored by: Dell EMC IsilonDifferential Revision: D9985
Replace for/retry loops with "wait_for_ggate_device" calls and checkresults of commandsAs noted in r313008, the underlying issue was that geom_gate devicecreation wasn't created at ggatel command
Replace for/retry loops with "wait_for_ggate_device" calls and checkresults of commandsAs noted in r313008, the underlying issue was that geom_gate devicecreation wasn't created at ggatel command completion, but some shorttime after. ggatec(8) employs similar logic when creating geom_gate(4)devices.Switch from retry loops (after the ggatec/dd write calls) towait_for_ggate_device function calls after calling ggatec(8) insteadto detect the presence of the /dev/ggate* device, as this function issufficient for determining whether or not the character device is readyfor testingWhile here, use atf_check consistently with all dd calls to ensure thatdata output is as expected.MFC after: 1 weekReviewed by: asomersDifferential Revision: D9409Sponsored by: Dell EMC Isilon
Wait for /dev/ggate* to appear after calling `ggatel create` in :ggatel_{file,md}The test assumed that `ggatel create` created a device on completion, but that'sincorrect. This squashes the race b
Wait for /dev/ggate* to appear after calling `ggatel create` in :ggatel_{file,md}The test assumed that `ggatel create` created a device on completion, but that'sincorrect. This squashes the race by waiting for the device to appear, as`ggatel create` daemonizes before issuing an ioctl to geom_gate(4) if not calledwith `-v`.Discussed with: asomersMFC after: 1 weekPR: 204616Sponsored by: Dell EMC Isilon
ATFify the geom gate tests.This ensures their cleanup routines will be run even if they should timeout.tests/sys/geom/class/gate/ggate_test.shtests/sys/geom/class/gate/Makefile Add an ATF test
ATFify the geom gate tests.This ensures their cleanup routines will be run even if they should timeout.tests/sys/geom/class/gate/ggate_test.shtests/sys/geom/class/gate/Makefile Add an ATF test with three testcases, one for each TAP test. Use ATF-style cleanup functions, and convert sleeps to polling loops.ObsoleteFiles.inctests/sys/geom/class/gate/conf.shtests/sys/geom/class/gate/1_test.shtests/sys/geom/class/gate/2_test.shtests/sys/geom/class/gate/3_test.sh Delete TAP test filesReviewed by: ngieMFC after: 4 weeksSponsored by: Spectra Logic CorpDifferential Revision: https://reviews.freebsd.org/D8891
ATFify the gnop testsAlso, add test cases for the -p, -P, and -s options to gnop createReviewed by: ngieMFC after: 4 weeksDifferential Revision: https://reviews.freebsd.org/D8892
Reduce the runtime of the GELI testsThere is no reduction in test coverage. On my system runtime is reducedfrom 38m32s to 6m24s.tests/sys/geom/class/eli/conf.shtests/sys/geom/class/eli/init_a_
Reduce the runtime of the GELI testsThere is no reduction in test coverage. On my system runtime is reducedfrom 38m32s to 6m24s.tests/sys/geom/class/eli/conf.shtests/sys/geom/class/eli/init_a_test.shtests/sys/geom/class/eli/init_test.shtests/sys/geom/class/eli/integrity_copy_test.shtests/sys/geom/class/eli/integrity_data_test.shtests/sys/geom/class/eli/integrity_hmac_test.shtests/sys/geom/class/eli/onetime_a_test.shtests/sys/geom/class/eli/onetime_test.sh Move the looping code into common functions in conf.sh, and remove alias ciphers from the list.tests/sys/geom/class/eli/init_a_test.shtests/sys/geom/class/eli/init_test.shtests/sys/geom/class/eli/integrity_copy_test.shtests/sys/geom/class/eli/integrity_data_test.shtests/sys/geom/class/eli/integrity_hmac_test.shtests/sys/geom/class/eli/onetime_a_test.sh Move a few commands that don't need to be in the inner loop out.tests/sys/geom/class/eli/init_test.shtests/sys/geom/class/eli/onetime_a_test.sh Reduce the sector counttests/sys/geom/class/eli/Makefiletests/sys/geom/class/eli/init_alias_test.sh Add a test for initializing a GELI device using one of the cipher aliases, and check that the alias is correctly interpreted.MFC after: 4 weeksSponsored by: Spectra Logic CorpDifferential Revision: https://reviews.freebsd.org/D8814
Change fs image name so it will not be regenerated (wehave both big and little-endian images in tree).Also we don't known the endianness of the platform theimage was generated on.Sponsored by: D
Change fs image name so it will not be regenerated (wehave both big and little-endian images in tree).Also we don't known the endianness of the platform theimage was generated on.Sponsored by: DARPA, AFRLSponsored by: HEIF5
Add big-endian uzip file system and choose right file systemto proceed tests with.Reviewed by: jmmv, ngieSponsored by: DARPA, AFRLSponsored by: HEIF5Differential Revision: https://reviews.freeb
Add big-endian uzip file system and choose right file systemto proceed tests with.Reviewed by: jmmv, ngieSponsored by: DARPA, AFRLSponsored by: HEIF5Differential Revision: https://reviews.freebsd.org/D8073
Increase timeouts for geli tests. It takes 2-3x more time to proceed thetests on MIPS64EB in QEMU.Sponsored by: DARPA, AFRLSponsored by: HEIF5
Use bsdlabel as we don't have hardlink disklabel -> bsdlabelon some platforms.Reviewed by: ngieSponsored by: DARPA, AFRLSponsored by: HEIF5Differential Revision: https://reviews.freebsd.org/D79
Use bsdlabel as we don't have hardlink disklabel -> bsdlabelon some platforms.Reviewed by: ngieSponsored by: DARPA, AFRLSponsored by: HEIF5Differential Revision: https://reviews.freebsd.org/D7968
Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedafter r298107Summary of changes:- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that na
Merge ^/user/ngie/release-pkg-fix-tests to unbreak how test files are installedafter r298107Summary of changes:- Replace all instances of FILES/TESTS with ${PACKAGE}FILES. This ensures that namespacing is kept with FILES appropriately, and that this shouldn't need to be repeated if the namespace changes -- only the definition of PACKAGE needs to be changed- Allow PACKAGE to be overridden by callers instead of forcing it to always be `tests`. In the event we get to the point where things can be split up enough in the base system, it would make more sense to group the tests with the blocks they're a part of, e.g. byacc with byacc-tests, etc- Remove PACKAGE definitions where possible, i.e. where FILES wasn't used previously.- Remove unnecessary TESTSPACKAGE definitions; this has been elided into bsd.tests.mk- Remove unnecessary BINDIRs used previously with ${PACKAGE}FILES; ${PACKAGE}FILESDIR is now automatically defined in bsd.test.mk.- Fix installation of files under data/ subdirectories in lib/libc/tests/hash and lib/libc/tests/net/getaddrinfo- Remove unnecessary .include <bsd.own.mk>s (some opportunistic cleanup)Document the proposed changes in share/examples/tests/tests/... via examplesso it's clear that ${PACKAGES}FILES is the suggested way forward in terms ofreplacing FILES. share/mk/bsd.README didn't seem like the appropriate methodof communicating that info.MFC after: never probablyX-MFC with: r298107PR: 209114Relnotes: yesTested with: buildworld, installworld, checkworld; buildworld, packageworldSponsored by: EMC / Isilon Storage Division
MFHSponsored by: The FreeBSD Foundation
Use a SKIP testplan instead of bailing out if/when the tester isn'troot, or the geom class can't be loaded cleanly [*]This makes sure that scenarios that are easy to hit aren't countedas false po
Use a SKIP testplan instead of bailing out if/when the tester isn'troot, or the geom class can't be loaded cleanly [*]This makes sure that scenarios that are easy to hit aren't countedas false positives with kyua testMFC after: 1 weekPR: 208101Sponsored by: EMC / Isilon Storage Division
DIRDEPS_BUILD: Connect MK_TESTS.Sponsored by: EMC / Isilon Storage Division
12345