4b653e82 | 10-May-2024 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
usb: fotg210: Add missing kernel doc description
kernel-doc validator is not happy:
warning: Function parameter or struct member 'fotg' not described in 'fotg210_vbus'
Add missing description.
usb: fotg210: Add missing kernel doc description
kernel-doc validator is not happy:
warning: Function parameter or struct member 'fotg' not described in 'fotg210_vbus'
Add missing description.
Fixes: 3e679bde529e ("usb: fotg210-udc: Implement VBUS session") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20240510152641.2421298-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
6b4040f4 | 02-Feb-2023 |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
USB: fotg210: fix memory leak with using debugfs_lookup()
When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, j
USB: fotg210: fix memory leak with using debugfs_lookup()
When calling debugfs_lookup() the result must have dput() called on it, otherwise the memory will leak over time. To make things simpler, just call debugfs_lookup_and_remove() instead which handles all of the logic at once.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20230202153235.2412790-5-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
c05ad0fb | 20-Jan-2023 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
usb: fotg210: use devm_platform_get_and_ioremap_resource()
Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly w
usb: fotg210: use devm_platform_get_and_ioremap_resource()
Convert platform_get_resource(), devm_ioremap_resource() to a single call to devm_platform_get_and_ioremap_resource(), as this is exactly what this function does.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20230120154437.22025-5-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
6df3d3aa | 20-Jan-2023 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
usb: fotg210: Switch to use dev_err_probe()
Switch to use dev_err_probe() to simplify the error paths and unify message template.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
usb: fotg210: Switch to use dev_err_probe()
Switch to use dev_err_probe() to simplify the error paths and unify message template.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20230120154437.22025-4-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
6a426eb4 | 20-Jan-2023 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
usb: fotg210-udc: remove redundant error logging
A call to platform_get_irq() already prints an error on failure within its own implementation. So printing another error based on its return value in
usb: fotg210-udc: remove redundant error logging
A call to platform_get_irq() already prints an error on failure within its own implementation. So printing another error based on its return value in the caller is redundant and should be removed. The clean up also makes if condition block braces unnecessary. Remove that as well.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20230120154437.22025-3-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
7159deb7 | 20-Jan-2023 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
usb: fotg210-hcd: Don't shadow error codes in store()
kstrtox() along with regmap API can return different error codes based on circumstances.
Don't shadow them when returning to the caller.
Signe
usb: fotg210-hcd: Don't shadow error codes in store()
kstrtox() along with regmap API can return different error codes based on circumstances.
Don't shadow them when returning to the caller.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20230120154437.22025-2-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
861fa1c3 | 20-Jan-2023 |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
usb: fotg210-hcd: use sysfs_emit() to instead of scnprintf()
Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting t
usb: fotg210-hcd: use sysfs_emit() to instead of scnprintf()
Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20230120154437.22025-1-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
c5d4297f | 23-Jan-2023 |
Fabian Vogt <fabian@ritter-vogt.de> |
fotg210-udc: Improve device initialization
Reset the device explicitly to get into a known state and also set the chip enable bit. Additionally, mask interrupts which aren't handled.
Signed-off-by:
fotg210-udc: Improve device initialization
Reset the device explicitly to get into a known state and also set the chip enable bit. Additionally, mask interrupts which aren't handled.
Signed-off-by: Fabian Vogt <fabian@ritter-vogt.de> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20230123073508.2350402-4-linus.walleij@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
76d62981 | 23-Jan-2023 |
Fabian Vogt <fabian@ritter-vogt.de> |
fotg210-udc: Introduce and use a fotg210_ack_int function
This is in preparation of support for devices where interrupts are acked differently.
Signed-off-by: Fabian Vogt <fabian@ritter-vogt.de> Si
fotg210-udc: Introduce and use a fotg210_ack_int function
This is in preparation of support for devices where interrupts are acked differently.
Signed-off-by: Fabian Vogt <fabian@ritter-vogt.de> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20230123073508.2350402-3-linus.walleij@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
3e679bde | 18-Jan-2023 |
Linus Walleij <linus.walleij@linaro.org> |
usb: fotg210-udc: Implement VBUS session
Implement VBUS session handling for FOTG210. This is mainly used by the UDC driver which needs to call down to the FOTG210 core and enable/disable VBUS, as t
usb: fotg210-udc: Implement VBUS session
Implement VBUS session handling for FOTG210. This is mainly used by the UDC driver which needs to call down to the FOTG210 core and enable/disable VBUS, as this needs to be handled outside of the HCD and UDC drivers, by platform specific glue code.
The Gemini has a special bit in a system register to turn VBUS on and off so we implement this in the FOTG210 core.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20230103-gemini-fotg210-usb-v2-7-100388af9810@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
816f518d | 18-Jan-2023 |
Linus Walleij <linus.walleij@linaro.org> |
usb: fotg210-udc: Assign of_node and speed on start
Follow the example set by other drivers to assign of_node and speed to the driver when binding, also print bound info akin to other UDC drivers.
usb: fotg210-udc: Assign of_node and speed on start
Follow the example set by other drivers to assign of_node and speed to the driver when binding, also print bound info akin to other UDC drivers.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20230103-gemini-fotg210-usb-v2-6-100388af9810@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
bb5fe856 | 18-Jan-2023 |
Linus Walleij <linus.walleij@linaro.org> |
usb: fotg210: Check role register in core
Read the role register and check that we are in host/peripheral mode and issue warnings if we're not in the right role when probing respective driver.
Sign
usb: fotg210: Check role register in core
Read the role register and check that we are in host/peripheral mode and issue warnings if we're not in the right role when probing respective driver.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20230103-gemini-fotg210-usb-v2-5-100388af9810@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
faaca436 | 18-Jan-2023 |
Linus Walleij <linus.walleij@linaro.org> |
usb: fotg210: Move clock handling to core
Grab the optional silicon block clock, prepare and enable it in the core before proceeding to prepare the host or peripheral driver. This saves duplicate co
usb: fotg210: Move clock handling to core
Grab the optional silicon block clock, prepare and enable it in the core before proceeding to prepare the host or peripheral driver. This saves duplicate code and also uses the simple devm_clk_get_optional_enabled() to do everything we really want to do.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20230103-gemini-fotg210-usb-v2-4-100388af9810@linaro.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|