media: platform: drop vb2_ops_wait_prepare/finishSince commit 88785982a19d ("media: vb2: use lock if wait_prepare/finishare NULL") it is no longer needed to set the wait_prepare/finishvb2_ops cal
media: platform: drop vb2_ops_wait_prepare/finishSince commit 88785982a19d ("media: vb2: use lock if wait_prepare/finishare NULL") it is no longer needed to set the wait_prepare/finishvb2_ops callbacks as long as the lock field in vb2_queue is set.Since the vb2_ops_wait_prepare/finish callbacks already rely on that field,we can safely drop these callbacks.This simplifies the code and this is a step towards the goal of deletingthese callbacks.Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> # for meson-ge2dAcked-by: Andrzej Pietrasiewicz <andrzejtp2010@gmail.com>
show more ...
media: Switch back to struct platform_driver::remove()After commit 0edb555a65d1 ("platform: Make platform_driver::remove()return void") .remove() is (again) the right callback to implement forpla
media: Switch back to struct platform_driver::remove()After commit 0edb555a65d1 ("platform: Make platform_driver::remove()return void") .remove() is (again) the right callback to implement forplatform drivers.Convert all platform drivers below drivers/media to use .remove(), withthe eventual goal to drop struct platform_driver::remove_new(). As.remove() and .remove_new() have the same prototypes, conversion is doneby just changing the structure member name in the driver initializer.Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
media: nuvoton: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do erro
media: nuvoton: Convert to platform remove callback returning voidThe .remove() callback for a platform driver returns an int which makesmany driver authors wrongly assume it's possible to do error handling byreturning an error code. However the value returned is ignored (apartfrom emitting a warning) and this typically results in resource leaks.To improve here there is a quest to make the remove callback returnvoid. In the first step of this quest all drivers are converted to.remove_new(), which already returns void. Eventually after all driversare converted, .remove_new() will be renamed to .remove().Trivially convert this driver from always returning zero in the removecallback to the void returning variant.Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
media: videobuf2: core: Rename min_buffers_needed field in vb2_queueRename min_buffers_needed into min_queued_buffers and updatethe documentation about it.Signed-off-by: Benjamin Gaignard <benja
media: videobuf2: core: Rename min_buffers_needed field in vb2_queueRename min_buffers_needed into min_queued_buffers and updatethe documentation about it.Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>[hverkuil: Drop the change where min_queued_buffers + 1 buffers would be][hverkuil: allocated. Now this patch only renames this field instead of making][hverkuil: a functional change as well.][hverkuil: Renamed 3 remaining min_buffers_needed occurrences.]
media: nuvoton: npcm-video: Fix sleeping in atomic contextChange to use mutex instead of spinlock for buffer list lock to fixsleeping in atomic context warnings reported by the Smatch tool.Fixes
media: nuvoton: npcm-video: Fix sleeping in atomic contextChange to use mutex instead of spinlock for buffer list lock to fixsleeping in atomic context warnings reported by the Smatch tool.Fixes: 70721089985c ("media: nuvoton: Add driver for NPCM video capture and encoding engine")Reported-by: Dan Carpenter <dan.carpenter@linaro.org>Signed-off-by: Marvin Lin <milkfafa@gmail.com>Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
media: nuvoton: Stop direct calls to queue num_buffers fieldUse vb2_get_num_buffers() to avoid using queue num_buffers field directly.This allows us to change how the number of buffers is computed
media: nuvoton: Stop direct calls to queue num_buffers fieldUse vb2_get_num_buffers() to avoid using queue num_buffers field directly.This allows us to change how the number of buffers is computed in thefuture.Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>CC: Joseph Liu <kwliu@nuvoton.com>CC: Marvin Lin <kflin@nuvoton.com>Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
media: nuvoton: VIDEO_NPCM_VCD_ECE should depend on ARCH_NPCMThe Nuvoton NPCM Video Capture/Differentiation Engine (VCD) and EncodingCompression Engine (ECE) are only present on Nuvoton NPCM SoCs.
media: nuvoton: VIDEO_NPCM_VCD_ECE should depend on ARCH_NPCMThe Nuvoton NPCM Video Capture/Differentiation Engine (VCD) and EncodingCompression Engine (ECE) are only present on Nuvoton NPCM SoCs. Henceadd a dependency on ARCH_NPCM, to prevent asking the user about thesedrivers when configuring a kernel without Nuvoton NPCM Architecturesupport.Fixes: 46c15a4ff1f4 ("media: nuvoton: Add driver for NPCM video capture and encoding engine")Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
media: nuvoton: npcm-video: Fix IS_ERR() vs NULL bugThe of_parse_phandle() function returns NULL on error. It never returnserror pointers. Update the check accordingly.Fixes: 70721089985c ("me
media: nuvoton: npcm-video: Fix IS_ERR() vs NULL bugThe of_parse_phandle() function returns NULL on error. It never returnserror pointers. Update the check accordingly.Fixes: 70721089985c ("media: nuvoton: Add driver for NPCM video capture and encoding engine")Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
media: nuvoton: Add driver for NPCM video capture and encoding engineAdd driver for Video Capture/Differentiation Engine (VCD) and EncodingCompression Engine (ECE) present on Nuvoton NPCM SoCs. As
media: nuvoton: Add driver for NPCM video capture and encoding engineAdd driver for Video Capture/Differentiation Engine (VCD) and EncodingCompression Engine (ECE) present on Nuvoton NPCM SoCs. As described inthe datasheet NPCM750D_DS_Rev_1.0, the VCD can capture frames fromdigital video input and compare two frames in memory, and then the ECEcan compress the frame data into HEXTILE format. This driver implementsV4L2 interfaces and provides user controls to support KVM feature, alsotested with VNC Viewer ver.6.22.826 and openbmc/obmc-ikvm.Signed-off-by: Marvin Lin <milkfafa@gmail.com>Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>