| bb04712e | 03-Mar-2025 |
Olivier Certner <olce@FreeBSD.org> |
smbios: Carefully print wrong entry point signature on identify
Using printf() with '%s' can lead to arbitrary long printing (although, usually, a NUL byte should appear quite quickly) and trying to
smbios: Carefully print wrong entry point signature on identify
Using printf() with '%s' can lead to arbitrary long printing (although, usually, a NUL byte should appear quite quickly) and trying to print unprintable characters.
Instead, print in hexadecimal the exact bytes that are compared to the expected signature.
MFC after: 2 weeks Sponsored by: The FreeBSD Foundation
show more ...
|
| fdf08ac1 | 03-Mar-2025 |
Olivier Certner <olce@FreeBSD.org> |
smbios: Print an error on unexpected entry point length on identify
This helps figuring out quickly why no SMBIOS device appears in this case.
MFC after: 2 weeks Sponsored by: The FreeBSD Fo
smbios: Print an error on unexpected entry point length on identify
This helps figuring out quickly why no SMBIOS device appears in this case.
MFC after: 2 weeks Sponsored by: The FreeBSD Foundation
show more ...
|
| f6cbd6b6 | 03-Mar-2025 |
Olivier Certner <olce@FreeBSD.org> |
smbios: Apply the v2.1's length fixup only on a 32-bit entry point
Only allow the length tolerance (0x1e instead of 0x1f) for a 32-bit entry point, as there was no 64-bit entry point in the erroneou
smbios: Apply the v2.1's length fixup only on a 32-bit entry point
Only allow the length tolerance (0x1e instead of 0x1f) for a 32-bit entry point, as there was no 64-bit entry point in the erroneous SMBIOS v2.1 standard and assigning the length with 0x1f does not make sense in this case.
While here, fix accessing the major/minor versions via 'eps' even in the 64-bit entry point case (not causing any practical problem thus far as the entry point length is greater than any SMBIOS revisions in existence, so the comparison guarding the fixup would not pass).
MFC after: 2 weeks Sponsored by: The FreeBSD Foundation
show more ...
|
| 67d510f0 | 28-Feb-2025 |
Olivier Certner <olce@FreeBSD.org> |
smbios: Unmap memory on error on identify
While here, de-indent most of the code by simply bailing out if 'addr' is still 0 after the various detection methods have been tried.
Reviewed by: emas
smbios: Unmap memory on error on identify
While here, de-indent most of the code by simply bailing out if 'addr' is still 0 after the various detection methods have been tried.
Reviewed by: emaste, imp MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D49180
show more ...
|
| e421a661 | 04-Mar-2025 |
Olivier Certner <olce@FreeBSD.org> |
smbios: On attach, print the entry point version and revision
Additionally, on verbose boot, print the entry point revision as a diagnostic/debugging help.
PR: 284460 Reviewed by: ma
smbios: On attach, print the entry point version and revision
Additionally, on verbose boot, print the entry point revision as a diagnostic/debugging help.
PR: 284460 Reviewed by: markj, imp (both older version) MFC after: 2 weeks Event: February src bug-busting session Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D49179
show more ...
|
| bc7f6508 | 28-Feb-2025 |
Olivier Certner <olce@FreeBSD.org> |
smbios: Search for v3 (64-bit) entry point first on BIOS boot
When booted from BIOS (i.e., not EFI), also search for a 64-bit version of the SMBIOS Entry Point.
This allows us to detect and report
smbios: Search for v3 (64-bit) entry point first on BIOS boot
When booted from BIOS (i.e., not EFI), also search for a 64-bit version of the SMBIOS Entry Point.
This allows us to detect and report the proper SMBIOS version with BIOSes that only provide the v3 table, as happens on Hetzner virtual machines.
For machines that provide both, leverage the v3 table in priority consistently with the EFI case.
PR: 284460 Reviewed by: markj, imp (both older version) MFC after: 2 weeks Relnotes: yes Event: February src bug-busting session Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D49179
show more ...
|
| 06326613 | 25-Jul-2024 |
Warner Losh <imp@FreeBSD.org> |
smbios: Add length sanity checking
D28743 was commited, reverted and then f689cb23b2782 landed before it was recommitted. However, D28743 included an extra length check. Redo that functionality so w
smbios: Add length sanity checking
D28743 was commited, reverted and then f689cb23b2782 landed before it was recommitted. However, D28743 included an extra length check. Redo that functionality so we check both the number of entries as well as the length checks for wacky data.
Sponsored by: Netflix Reviewed by: gallatin Differential Revision: https://reviews.freebsd.org/D45763
show more ...
|
| f689cb23 | 07-Apr-2021 |
Greg V <greg@unrelenting.technology> |
ipmi,smbios: move smbios_walk_table to smbios.h
This function will be used for exposing DMI info as sysctls in the smbios module (in an upcoming review).
While here, add __packed to the structs.
R
ipmi,smbios: move smbios_walk_table to smbios.h
This function will be used for exposing DMI info as sysctls in the smbios module (in an upcoming review).
While here, add __packed to the structs.
Reviewed by: dab MFC after: 1 week Sponsored by: Dell EMC Isilon Differential Revision: https://reviews.freebsd.org/D29270
show more ...
|