drm/amd/display: replace fast_validate with enum dc_validate_mode[Why]The boolean fast_validate is used as aninput parameter in multiple functions. Tosupport more scenarios, we arereplacing it
drm/amd/display: replace fast_validate with enum dc_validate_mode[Why]The boolean fast_validate is used as aninput parameter in multiple functions. Tosupport more scenarios, we arereplacing it with enum dc_validate_mode.[How]The enum dc_validate_mode introduces threepossible values:1) DC_VALIDATE_MODE_AND_PROGRAMMING: Apply the mode to hardware2) DC_VALIDATE_MODE_ONLY: Check whether the mode can be supported3) DC_VALIDATE_MODE_AND_STATE_INDEX: Check if the mode can be supported, and determine the optimal voltage level needed to support it.Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>Signed-off-by: Yan Li <yan.li@amd.com>Signed-off-by: Wayne Lin <wayne.lin@amd.com>Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
show more ...
drm/amd/display: Refactor SubVP cursor limiting logic[WHY]There are several gaps that can result in SubVP being enabled withincompatible HW cursor sizes, and unjust restrictions to cursor size du
drm/amd/display: Refactor SubVP cursor limiting logic[WHY]There are several gaps that can result in SubVP being enabled withincompatible HW cursor sizes, and unjust restrictions to cursor size dueto wrong predictions on future usage of SubVP.[HOW]- remove "prediction" logic in favor of tagging based on previous SubVP usage- block SubVP if current HW cursor settings are incompatible- provide interface for DM to determine if HW cursor should be disabled due to an attempt to enable SubVPReviewed-by: Alvin Lee <alvin.lee2@amd.com>Signed-off-by: Dillon Varone <dillon.varone@amd.com>Signed-off-by: Ray Wu <ray.wu@amd.com>Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Revert "drm/amd/display: Refactor SubVP cursor limiting logic"This reverts commit 19e743f0fb73 ("drm/amd/display: Refactor SubVP cursor limiting logic")Reason for revert: CorruptionReviewed-by:
Revert "drm/amd/display: Refactor SubVP cursor limiting logic"This reverts commit 19e743f0fb73 ("drm/amd/display: Refactor SubVP cursor limiting logic")Reason for revert: CorruptionReviewed-by: Alvin Lee <alvin.lee2@amd.com>Signed-off-by: Ryan Seto <ryanseto@amd.com>Signed-off-by: Ray Wu <ray.wu@amd.com>Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/display: Refactor SubVP cursor limiting logic[WHY]There are several gaps that can result in SubVP being enabled withincompatible HW cursor sizes, and unjust restrictions to cursor size dueto wrong predictions on future usage of SubVP[HOW]- remove "prediction" logic in favor of tagging based on previous SubVP usage- block SubVP if current HW cursor settings are incompatible- provide interface for DM to determine if HW cursor should be disabled due to an attempt to enable SubVPReviewed-by: Alvin Lee <alvin.lee2@amd.com>Signed-off-by: Dillon Varone <dillon.varone@amd.com>Signed-off-by: Zaeem Mohamed <zaeem.mohamed@amd.com>Tested-by: Mark Broadworth <mark.broadworth@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/display: Add hpd_source index check for DCE60/80/100/110/112/120 link encodersThis patch adds a boundary check for the hpd_source index during thelink encoder creation process for all DCEx
drm/amd/display: Add hpd_source index check for DCE60/80/100/110/112/120 link encodersThis patch adds a boundary check for the hpd_source index during thelink encoder creation process for all DCExxx IP's. The check ensuresthat the index is within the valid range of the link_enc_hpd_regs arrayto prevent out-of-bounds access.Cc: Tom Chung <chiahsuan.chung@amd.com>Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>Cc: Roman Li <roman.li@amd.com>Cc: Alex Hung <alex.hung@amd.com>Cc: Aurabindo Pillai <aurabindo.pillai@amd.com>Cc: Harry Wentland <harry.wentland@amd.com>Cc: Hamza Mahfooz <hamza.mahfooz@amd.com>Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam@amd.com>Reviewed-by: Roman Li <roman.li@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/display: Release clck_src memory if clk_src_construct fails[Why]Coverity reports RESOURCE_LEAK for some implemenationsof clock_source_create. Do not release memory of clk_srcif contructo
drm/amd/display: Release clck_src memory if clk_src_construct fails[Why]Coverity reports RESOURCE_LEAK for some implemenationsof clock_source_create. Do not release memory of clk_srcif contructor fails.[How]Free clk_src if contructor fails.Reviewed-by: Harry Wentland <harry.wentland@amd.com>Acked-by: Tom Chung <chiahsuan.chung@amd.com>Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/display: Remove unnecessary files[Why & How]We accidentally upstream unnecessary files. Remove them.Reviewed-by: Tom Chung <chiahsuan.chung@amd.com>Signed-off-by: Wayne Lin <Wayne.Lin@a
drm/amd/display: Remove unnecessary files[Why & How]We accidentally upstream unnecessary files. Remove them.Reviewed-by: Tom Chung <chiahsuan.chung@amd.com>Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/display: Add comments to improve the code readabilityThis commit just introduce some basic comments that helps to understandthe overall behavior of some structs.Acked-by: Hamza Mahfooz <
drm/amd/display: Add comments to improve the code readabilityThis commit just introduce some basic comments that helps to understandthe overall behavior of some structs.Acked-by: Hamza Mahfooz <hamza.mahfooz@amd.com>Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/display: Refactor resource into component directory[WHY]Move all resource files to unique folder resource.[HOW]Created resource folder in dc, moved thedcnxx_resource.c and dcnxx_resour
drm/amd/display: Refactor resource into component directory[WHY]Move all resource files to unique folder resource.[HOW]Created resource folder in dc, moved thedcnxx_resource.c and dcnxx_resource.h files intocorresponding new folders inside the resource andmade appropriate changes for compilation in Makefiles.Reviewed-by: Martin Leung <martin.leung@amd.com>Acked-by: Alex Hung <alex.hung@amd.com>Signed-off-by: Mounika Adhuri <moadhuri@amd.com>Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>