| 099cf1fb | 24-Jun-2025 |
Andrei Kuchynski <akuchynski@chromium.org> |
usb: typec: displayport: Fix potential deadlock
The deadlock can occur due to a recursive lock acquisition of `cros_typec_altmode_data::mutex`. The call chain is as follows: 1. cros_typec_altmode_wo
usb: typec: displayport: Fix potential deadlock
The deadlock can occur due to a recursive lock acquisition of `cros_typec_altmode_data::mutex`. The call chain is as follows: 1. cros_typec_altmode_work() acquires the mutex 2. typec_altmode_vdm() -> dp_altmode_vdm() -> 3. typec_altmode_exit() -> cros_typec_altmode_exit() 4. cros_typec_altmode_exit() attempts to acquire the mutex again
To prevent this, defer the `typec_altmode_exit()` call by scheduling it rather than calling it directly from within the mutex-protected context.
Cc: stable <stable@kernel.org> Fixes: b4b38ffb38c9 ("usb: typec: displayport: Receive DP Status Update NAK request exit dp altmode") Signed-off-by: Andrei Kuchynski <akuchynski@chromium.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://lore.kernel.org/r/20250624133246.3936737-1-akuchynski@chromium.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| 9682c35f | 24-Jan-2025 |
Benson Leung <bleung@chromium.org> |
usb: typec: thunderbolt: Remove IS_ERR check for plug
Fixes these Smatch static checker warnings: drivers/usb/typec/altmodes/thunderbolt.c:354 tbt_ready() warn: 'plug' is not an error pointer
Fixes
usb: typec: thunderbolt: Remove IS_ERR check for plug
Fixes these Smatch static checker warnings: drivers/usb/typec/altmodes/thunderbolt.c:354 tbt_ready() warn: 'plug' is not an error pointer
Fixes: 100e25738659 ("usb: typec: Add driver for Thunderbolt 3 Alternate Mode") Signed-off-by: Benson Leung <bleung@chromium.org> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://lore.kernel.org/r/Z5PstnlA52Z1F2SU@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| 5399a1ba | 14-Dec-2024 |
Abhishek Pandit-Subedi <abhishekpandit@chromium.org> |
usb: typec: Print err when displayport fails to enter
Print the error reason for typec_altmode_enter so users can understand why displayport failed to enter.
Signed-off-by: Abhishek Pandit-Subedi <
usb: typec: Print err when displayport fails to enter
Print the error reason for typec_altmode_enter so users can understand why displayport failed to enter.
Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Reviewed-by: Benson Leung <bleung@chromium.org> Link: https://lore.kernel.org/r/20241213153543.v5.4.I6cff9d767b0f8ab6458d8940941e42c920902d49@changeid Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| 100e2573 | 14-Dec-2024 |
Heikki Krogerus <heikki.krogerus@linux.intel.com> |
usb: typec: Add driver for Thunderbolt 3 Alternate Mode
Thunderbolt 3 Alternate Mode entry flow is described in USB Type-C Specification Release 2.0.
Signed-off-by: Heikki Krogerus <heikki.krogerus
usb: typec: Add driver for Thunderbolt 3 Alternate Mode
Thunderbolt 3 Alternate Mode entry flow is described in USB Type-C Specification Release 2.0.
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Co-developed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> Reviewed-by: Benson Leung <bleung@chromium.org> Link: https://lore.kernel.org/r/20241213153543.v5.2.I3080b036e8de0b9957c57c1c3059db7149c5e549@changeid Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| db2ed6ec | 31-Mar-2024 |
Krzysztof Kozlowski <krzk@kernel.org> |
usb: typec: displayport: drop driver owner assignment
Core in typec_altmode_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.or
usb: typec: displayport: drop driver owner assignment
Core in typec_altmode_register_driver() already sets the .owner, so driver does not need to.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://lore.kernel.org/r/20240331091737.19836-3-krzk@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|