| b8394732 | 03-Jun-2025 |
Dave Penkler <dpenkler@gmail.com> |
staging: gpib: Add bit and byte padding to ioctl structs
Ensure that all structs have a size that is an integral mutliple
of 32 bits.
Change trailing single bit field to __u32 in gpib_open_dev_ioct
staging: gpib: Add bit and byte padding to ioctl structs
Ensure that all structs have a size that is an integral mutliple
of 32 bits.
Change trailing single bit field to __u32 in gpib_open_dev_ioctl
Add byte padding to gpib_serial_poll_ioctl and gpib_request_service2
Add bit padding to gpib_board_info_ioctl and gpib_ppoll_config_ioctl
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250603184320.30594-5-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| eaad2a42 | 03-Jun-2025 |
Dave Penkler <dpenkler@gmail.com> |
staging: gpib: Use standard size basic uapi types
Change unsigned int to __u32,
int to __s32
and short to __s16
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: http
staging: gpib: Use standard size basic uapi types
Change unsigned int to __u32,
int to __s32
and short to __s16
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250603184320.30594-4-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| 5aac9532 | 20-May-2025 |
Dave Penkler <dpenkler@gmail.com> |
staging: gpib: Fix secondary address restriction
GPIB secondary addresses have valid values between 0 and 31
inclusive. The Make Secondary Address function MSA, used to form
the protocol byte, was u
staging: gpib: Fix secondary address restriction
GPIB secondary addresses have valid values between 0 and 31
inclusive. The Make Secondary Address function MSA, used to form
the protocol byte, was using the gpib_address_restrict function
erroneously restricting the address range to 0 through 30.
Remove the call to gpib_address_restrict and simply trim the
address to 5 bits.
Fixes: 2da03e7e31aa ("staging: gpib: Add user api include files")
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250520155100.5808-1-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| c7184cbf | 18-Apr-2025 |
Dave Penkler <dpenkler@gmail.com> |
staging: gpib: Rename common include file
User code includes gpib_user.h. Since this include has diverged
from the original by
- removing unused functions and defines
- changing camel-case ident
staging: gpib: Rename common include file
User code includes gpib_user.h. Since this include has diverged
from the original by
- removing unused functions and defines
- changing camel-case identifiers
- removing typedefs
we need to change the name of the kernel include. This include
will be included in the userland gpib_user.h ensuring backward
compatibility for application programmes.
Rename the file and change the references to it.
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250418093111.8820-3-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| db144780 | 18-Apr-2025 |
Dave Penkler <dpenkler@gmail.com> |
staging: gpib: Remove unused enums from common include file
The error code and timeout code enums are not used by any
of the gpib kernel code. This patch removes them.
Signed-off-by: Dave Penkler
staging: gpib: Remove unused enums from common include file
The error code and timeout code enums are not used by any
of the gpib kernel code. This patch removes them.
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250418093111.8820-2-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| f207bc3a | 17-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: gpib_user: u8 over uint8_t
Reported by checkpatch.pl.
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kerne
staging: gpib: gpib_user: u8 over uint8_t
Reported by checkpatch.pl.
CHECK: Prefer kernel type 'u8' over 'uint8_t'
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250417004533.86765-3-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| 132ea587 | 09-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: local_ppoll_mode_ioctl_t now short
Using Linux code style to replace typedef local_ppoll_mode_ioctl_t with
type short.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNI
staging: gpib: local_ppoll_mode_ioctl_t now short
Using Linux code style to replace typedef local_ppoll_mode_ioctl_t with
type short.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING: do not add new typedefs
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-22-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| 9979a80c | 09-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: autospoll_ioctl_t now short
Using Linux code style to replace typedef autospoll_ioctl_t with type short.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING: do not add
staging: gpib: autospoll_ioctl_t now short
Using Linux code style to replace typedef autospoll_ioctl_t with type short.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING: do not add new typedefs
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-21-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| 7c3a08ff | 09-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: t1_delay_ioctl_t now unsigned int
Using Linux code style to replace typedef t1_delay_ioctl_t with type
unsigned int.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING
staging: gpib: t1_delay_ioctl_t now unsigned int
Using Linux code style to replace typedef t1_delay_ioctl_t with type
unsigned int.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING: do not add new typedefs
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-20-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| 6856bb17 | 09-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: rsc_ioctl_t now int
Using Linux code style to replace typedef rsc_ioctl_t with type int.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING: do not add new typedefs
S
staging: gpib: rsc_ioctl_t now int
Using Linux code style to replace typedef rsc_ioctl_t with type int.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING: do not add new typedefs
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-19-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| 8cc35955 | 09-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: event_ioctl_t now short
Using Linux code style to replace typedef event_ioctl_t with type short.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING: do not add new typ
staging: gpib: event_ioctl_t now short
Using Linux code style to replace typedef event_ioctl_t with type short.
Adhering to Linux code style.
Reported by checkpatch.pl
WARNING: do not add new typedefs
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-18-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| ad368b53 | 09-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: Using struct gpib_request_service2
Using Linux code style for 'struct gpib_request_service2' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general,
staging: gpib: Using struct gpib_request_service2
Using Linux code style for 'struct gpib_request_service2' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-17-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| 1b462bf2 | 09-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: Using gpib_select_device_path_ioctl
Using Linux code style for 'struct gpib_select_device_path_ioctl' to
remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In
staging: gpib: Using gpib_select_device_path_ioctl
Using Linux code style for 'struct gpib_select_device_path_ioctl' to
remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-16-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| d178bc14 | 09-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: Using struct gpib_sad_ioctl
Using Linux code style for 'struct gpib_sad_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or
staging: gpib: Using struct gpib_sad_ioctl
Using Linux code style for 'struct gpib_sad_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-15-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| faebdfab | 09-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: Using struct gpib_pad_ioctl
Using Linux code style for 'struct gpib_pad_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or
staging: gpib: Using struct gpib_pad_ioctl
Using Linux code style for 'struct gpib_pad_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-14-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| 419a3433 | 09-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: Using struct gpib_ppoll_config_ioctl`
Using Linux code style for 'struct gpib_ppoll_config_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In gene
staging: gpib: Using struct gpib_ppoll_config_ioctl`
Using Linux code style for 'struct gpib_ppoll_config_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-13-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| 4c217037 | 09-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: Using struct gpib_select_pci_ioctl
Using Linux code style for 'struct gpib_select_pci_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general,
staging: gpib: Using struct gpib_select_pci_ioctl
Using Linux code style for 'struct gpib_select_pci_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-12-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| c39eabbf | 09-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: Using struct gpib_board_info_ioctl
Using Linux code style for 'struct gpib_board_info_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general,
staging: gpib: Using struct gpib_board_info_ioctl
Using Linux code style for 'struct gpib_board_info_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-11-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
| 770b63fd | 09-Apr-2025 |
Michael Rubin <matchstick@neverthere.org> |
staging: gpib: Using struct gpib_spoll_bytes_ioctl
Using Linux code style for 'struct gpib_spoll_bytes_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general
staging: gpib: Using struct gpib_spoll_bytes_ioctl
Using Linux code style for 'struct gpib_spoll_bytes_ioctl' to remove typedef.
Adhering to Linux code style.
Reported by checkpatch.pl
In general, a pointer, or a struct that has elements that can reasonably be
directly accessed should never be a typedef.
Signed-off-by: Michael Rubin <matchstick@neverthere.org>
Link: https://lore.kernel.org/r/20250409055903.321438-10-matchstick@neverthere.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|