media: mediatek: vcodec: Remove trailing space after \n newlineThere is a extraneous space after a newline in a mtk_venc_debug message.Remove it.Signed-off-by: Colin Ian King <colin.i.king@gmail
media: mediatek: vcodec: Remove trailing space after \n newlineThere is a extraneous space after a newline in a mtk_venc_debug message.Remove it.Signed-off-by: Colin Ian King <colin.i.king@gmail.com>Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>Signed-off-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
show more ...
media: mtk-vcodec: venc: avoid -Wenum-compare-conditional warningThis is one of three clang warnings about incompatible enum typesin a conditional expression:drivers/media/platform/mediatek/vcod
media: mtk-vcodec: venc: avoid -Wenum-compare-conditional warningThis is one of three clang warnings about incompatible enum typesin a conditional expression:drivers/media/platform/mediatek/vcodec/encoder/venc/venc_h264_if.c:597:29: error: conditional expression between different enumeration types ('enum scp_ipi_id' and 'enum ipi_id') [-Werror,-Wenum-compare-conditional] 597 | inst->vpu_inst.id = is_ext ? SCP_IPI_VENC_H264 : IPI_VENC_H264; | ^ ~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~The code is correct, so just rework it to avoid the warning.Fixes: 0dc4b3286125 ("media: mtk-vcodec: venc: support SCP firmware")Cc: stable@vger.kernel.orgSigned-off-by: Arnd Bergmann <arnd@arndb.de>Reviewed-by: Nathan Chancellor <nathan@kernel.org>Reviewed-by: Alexandre Courbot <acourbot@google.com>Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
media: mediatek: vcodec: Only free buffer VA that is not NULLIn the MediaTek vcodec driver, while mtk_vcodec_mem_free() is mostlycalled only when the buffer to free exists, there are some instance
media: mediatek: vcodec: Only free buffer VA that is not NULLIn the MediaTek vcodec driver, while mtk_vcodec_mem_free() is mostlycalled only when the buffer to free exists, there are some instancesthat didn't do the check and triggered warnings in practice.We believe those checks were forgotten unintentionally. Add the checksback to fix the warnings.Signed-off-by: Fei Shao <fshao@chromium.org>Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
media: mediatek: vcodec: separate decoder and encoderMove all decoder files to folder decoder.Move all encoder files to folder encoder.Move common files which shared for encoder and decoder to fo
media: mediatek: vcodec: separate decoder and encoderMove all decoder files to folder decoder.Move all encoder files to folder encoder.Move common files which shared for encoder and decoder to folder common.Change include header files and Makefile to fix build error.Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>