drm/amd/display: adjust floating point format for gamut remap when needed[Why]The MPCCs different gamut remap matrices allow for S2D13 and S3D12 floatingpoint formats, but only S2D13 is used. The
drm/amd/display: adjust floating point format for gamut remap when needed[Why]The MPCCs different gamut remap matrices allow for S2D13 and S3D12 floatingpoint formats, but only S2D13 is used. There may be cases where moreinteger bits are required.[How]Switch to S3D12 if any entries in the remap matrix cannot fit in S2D13.Otherwise, prefer the extra precision of S2D13. Communicate the max valuethat hw can support to dm via dc color caps.Reviewed-by: Dillon Varone <dillon.varone@amd.com>Signed-off-by: Clay King <clayking@amd.com>Signed-off-by: Fangzhi Zuo <jerry.zuo@amd.com>Tested-by: Dan Wheeler <daniel.wheeler@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
show more ...
drm/amd/display: Fix warnings[Why & How]Fix various warnings related to unsigned/signed mismatches- Consistently use the same signedness for a given value- Explcitly cast between types when ne
drm/amd/display: Fix warnings[Why & How]Fix various warnings related to unsigned/signed mismatches- Consistently use the same signedness for a given value- Explcitly cast between types when neededReviewed-by: Dillon Varone <dillon.varone@amd.com>Signed-off-by: Clay King <clayking@amd.com>Signed-off-by: James Lin <pinglei.lin@amd.com>Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/display: Remove unused NUM_ELEMENTS macrosRemoves unused NUM_ELEMENTS macros. Discovered while removing caseswhere ARRAY_SIZE from the header <linus/array_size.h> can be used.This also al
drm/amd/display: Remove unused NUM_ELEMENTS macrosRemoves unused NUM_ELEMENTS macros. Discovered while removing caseswhere ARRAY_SIZE from the header <linus/array_size.h> can be used.This also aligns with the array_size.cocci coccinelle check.Suggested-by: Robert P. J. Day <rpjday@crashcourse.ca>Signed-off-by: Linus Probert <linus.probert@gmail.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/display: Fixed Silence complier warnings in dc[Why]Resolve compiler warnings by marking unused parameters explicitly.[How]In .c and .h function definitions, keep parameter namesin sign
drm/amd/display: Fixed Silence complier warnings in dc[Why]Resolve compiler warnings by marking unused parameters explicitly.[How]In .c and .h function definitions, keep parameter namesin signatures and add a line with `(void)param;` in function bodyPreserved function signatures and avoids breaking code paths thatmay reference the parameter under conditional compilation.Reviewed-by: Dillon Varone <dillon.varone@amd.com>Reviewed-by: Austin Zheng <austin.zheng@amd.com>Signed-off-by: Gaghik Khachatrian <gaghik.khachatrian@amd.com>Signed-off-by: Chuanyu Tseng <chuanyu.tseng@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/display: Fix Silence signed/unsighed mismatch warning in dc[Why]Implicit signed-to-unsigned conversions caused compilerwarnings in DC paths.[How]Added explicit (unsigned int)/(uint32_t
drm/amd/display: Fix Silence signed/unsighed mismatch warning in dc[Why]Implicit signed-to-unsigned conversions caused compilerwarnings in DC paths.[How]Added explicit (unsigned int)/(uint32_t) casts for sentinel -1assignments and IRQ ~MASK initializers, with small cast alignmentin logging/DPCD code.Functionality and behavior is unchanged; only type intent is explicit.Reviewed-by: Dillon Varone <dillon.varone@amd.com>Signed-off-by: Gaghik Khachatrian <gaghik.khachatrian@amd.com>Signed-off-by: Chuanyu Tseng <chuanyu.tseng@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/display: Add more DC HW state info to underflow logging[Why]Debugging underflow issues frequently requires knowing theHW state at the time of underflow. To enable capturing thisHW state
drm/amd/display: Add more DC HW state info to underflow logging[Why]Debugging underflow issues frequently requires knowing theHW state at the time of underflow. To enable capturing thisHW state information, interface functions are needed for thevarious DC HW blocks.[How]This change adds the interface functions to read HW state forthe following DC HW blocks:- HUBBUB- HUBP- DPP- MPC- OPP- DSC- OPTC- DCCGReviewed-by: George Shen <george.shen@amd.com>Signed-off-by: Karen Chen <Karen.Chen@amd.com>Signed-off-by: Wayne Lin <wayne.lin@amd.com>Tested-by: Dan Wheeler <daniel.wheeler@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/display: Disable MPC rate control on ODM pipe update[Why]Seamless boot skips MPC init for the active pipe, resulting in stale MPCrate control state being retained. This will cause issues
drm/amd/display: Disable MPC rate control on ODM pipe update[Why]Seamless boot skips MPC init for the active pipe, resulting in stale MPCrate control state being retained. This will cause issues since otherlogic assumes it is disabled (as DCN30 and newer does not need it).[How]Disable MPC rate control on ODM pipe update to cover the seamless bootcase.Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>Reviewed-by: Alvin Lee <alvin.lee2@amd.com>Signed-off-by: George Shen <george.shen@amd.com>Signed-off-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drm/amd/display: Refactoring MPC[Why]To refactor MPC files[How]Moved MPC files to respective folders andupdated makefiles appropriately.Reviewed-by: Martin Leung <martin.leung@amd.com>Signe
drm/amd/display: Refactoring MPC[Why]To refactor MPC files[How]Moved MPC files to respective folders andupdated makefiles appropriately.Reviewed-by: Martin Leung <martin.leung@amd.com>Signed-off-by: Jerry Zuo <jerry.zuo@amd.com>Signed-off-by: Mounika Adhuri <moadhuri@amd.com>Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>Signed-off-by: Alex Deucher <alexander.deucher@amd.com>