| 97a07dd2 | 17-Oct-2025 |
Peng Fan <peng.fan@nxp.com> |
firmware: imx: scu: Use devm_mutex_init
In normal case, there is no need to invoke mutex_destroy in error path, but it is useful when CONFIG_DEBUG_MUTEXES, so use devm_mutex_init().
Reviewed-by: Fr
firmware: imx: scu: Use devm_mutex_init
In normal case, there is no need to invoke mutex_destroy in error path, but it is useful when CONFIG_DEBUG_MUTEXES, so use devm_mutex_init().
Reviewed-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Peng Fan <peng.fan@nxp.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
show more ...
|
| ff79af93 | 17-Oct-2025 |
Peng Fan <peng.fan@nxp.com> |
firmware: imx: scu: Suppress bind attrs
The SCU driver is critical for system working properly, it should never be removed and binded again. So suppress the bind attrs
Reviewed-by: Frank Li <Frank.
firmware: imx: scu: Suppress bind attrs
The SCU driver is critical for system working properly, it should never be removed and binded again. So suppress the bind attrs
Reviewed-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Peng Fan <peng.fan@nxp.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
show more ...
|
| 27d40869 | 17-Oct-2025 |
Peng Fan <peng.fan@nxp.com> |
firmware: imx: scu: Update error code
IMX_SC_ERR_NOTFOUND should map with -ENOENT, not -EEXIST. -ENODEV makes more sense for IMX_SC_ERR_NOPOWER, and -ECOMM makes more sense for IMX_SC_ERR_IPC.
Revi
firmware: imx: scu: Update error code
IMX_SC_ERR_NOTFOUND should map with -ENOENT, not -EEXIST. -ENODEV makes more sense for IMX_SC_ERR_NOPOWER, and -ECOMM makes more sense for IMX_SC_ERR_IPC.
Reviewed-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Peng Fan <peng.fan@nxp.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
show more ...
|
| ea2f83c6 | 17-Oct-2025 |
Peng Fan <peng.fan@nxp.com> |
firmware: imx: scu-irq: Remove unused export of imx_scu_enable_general_irq_channel
Since its introduction, this symbol has not been used by any loadable modules. It remains only referenced within im
firmware: imx: scu-irq: Remove unused export of imx_scu_enable_general_irq_channel
Since its introduction, this symbol has not been used by any loadable modules. It remains only referenced within imx-scu.c, which is always built together with imx-scu-irq.c
As such, exporting imx_scu_enable_general_irq_channel is unnecessary, so remove the export.
Reviewed-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Peng Fan <peng.fan@nxp.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
show more ...
|
| ff3f9913 | 17-Oct-2025 |
Peng Fan <peng.fan@nxp.com> |
firmware: imx: scu-irq: Set mu_resource_id before get handle
mu_resource_id is referenced in imx_scu_irq_get_status() and imx_scu_irq_group_enable() which could be used by other modules, so need to
firmware: imx: scu-irq: Set mu_resource_id before get handle
mu_resource_id is referenced in imx_scu_irq_get_status() and imx_scu_irq_group_enable() which could be used by other modules, so need to set correct value before using imx_sc_irq_ipc_handle in SCU API call.
Reviewed-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Peng Fan <peng.fan@nxp.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
show more ...
|
| 81fb53fe | 17-Oct-2025 |
Peng Fan <peng.fan@nxp.com> |
firmware: imx: scu-irq: Init workqueue before request mbox channel
With mailbox channel requested, there is possibility that interrupts may come in, so need to make sure the workqueue is initialized
firmware: imx: scu-irq: Init workqueue before request mbox channel
With mailbox channel requested, there is possibility that interrupts may come in, so need to make sure the workqueue is initialized before the queue is scheduled by mailbox rx callback.
Reviewed-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Peng Fan <peng.fan@nxp.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
show more ...
|
| 62c740fb | 17-Oct-2025 |
Peng Fan <peng.fan@nxp.com> |
firmware: imx: scu-irq: Free mailbox client on failure at imx_scu_enable_general_irq_channel()
The IRQ mailbox is an optional channel and does not need to be kept until driver removal when an error
firmware: imx: scu-irq: Free mailbox client on failure at imx_scu_enable_general_irq_channel()
The IRQ mailbox is an optional channel and does not need to be kept until driver removal when an error occurs. Free the allocated memory in the error path.
Add 'goto free_cl' when mbox_request_channel_byname() fails, to keep free at one place.
Signed-off-by: Peng Fan <peng.fan@nxp.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
show more ...
|
| 1055faa5 | 08-Apr-2025 |
Peng Fan <peng.fan@nxp.com> |
firmware: imx: Add i.MX95 SCMI CPU driver
The i.MX95 System manager exports SCMI CPU protocol for linux to manage cpu cores. The driver is to use the cpu Protocol interface to start, stop a cpu core
firmware: imx: Add i.MX95 SCMI CPU driver
The i.MX95 System manager exports SCMI CPU protocol for linux to manage cpu cores. The driver is to use the cpu Protocol interface to start, stop a cpu cores (eg, M7).
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com> Signed-off-by: Peng Fan <peng.fan@nxp.com> Message-Id: <20250408-imx-lmm-cpu-v4-6-4c5f4a456e49@nxp.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
show more ...
|
| 1558b1a8 | 08-Oct-2023 |
Hao Ge <gehao@kylinos.cn> |
firmware/imx-dsp: Fix use_after_free in imx_dsp_setup_channels()
dsp_chan->name and chan_name points to same block of memory, because dev_err still needs to be used it,so we need free it's memory af
firmware/imx-dsp: Fix use_after_free in imx_dsp_setup_channels()
dsp_chan->name and chan_name points to same block of memory, because dev_err still needs to be used it,so we need free it's memory after use to avoid use_after_free.
Fixes: e527adfb9b7d ("firmware: imx-dsp: Fix an error handling path in imx_dsp_setup_channels()") Signed-off-by: Hao Ge <gehao@kylinos.cn> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com> Signed-off-by: Shawn Guo <shawnguo@kernel.org>
show more ...
|