makefs/zfs/tests: Force-destroy md devices

Most of these tests create a md(4) device backed by a makefs-generated
image, then import the pool, using the md device as a pool vdev. When
a test finish

makefs/zfs/tests: Force-destroy md devices

Most of these tests create a md(4) device backed by a makefs-generated
image, then import the pool, using the md device as a pool vdev. When
a test finishes, it destroys the pool, then destroys the md device.

Once in a while md device destruction fails with EBUSY. This happens
when a GEOM consumer is holding the device open; kern_mddetach_locked()
simply fails if any consumers are present. zpool destruction is
synchronous so ZFS is innocent, rather, the problem seems to be that
GEOM re-tastes the device after the zpool reference goes away. This
operation creates a transient reference that causes the spurious
failure.

Use "mdconfig -o force" to work around this.

MFC after: 2 weeks

show more ...

makefs.8: Cleanup man page

Reviewed by: ziaee
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D54538

makefs: Fix typo 's/mirrorring/mirroring/'

MFC after: 1 week

makefs: tests: Fix timestamp-related tests

Use a variable for mtree that includes the DEFAULT_MTREE_KEYWORDS, in
order to avoid missing the important "time" keyword or passing an
unimplemented "nlin

makefs: tests: Fix timestamp-related tests

Use a variable for mtree that includes the DEFAULT_MTREE_KEYWORDS, in
order to avoid missing the important "time" keyword or passing an
unimplemented "nlink" keyword.

Unskip the "failing" tests, and comment out the specific failing checks,
these will be addressed (or at least discussed) in a different revision.

For MS-DOS tests, use an even value timestamp, as precision is 2s.

For ZFS tests, use import_image instead of mount_image consistently.

Reviewed by: bnovkov, markj
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D54429

show more ...

makefs: tests: Fix -D flag test

As stated in the manual page:

-F is almost certainly not the option you are looking for. To
create an image from a list of files in an mtree format manifest,
specif

makefs: tests: Fix -D flag test

As stated in the manual page:

-F is almost certainly not the option you are looking for. To
create an image from a list of files in an mtree format manifest,
specify it as the last argument on the command line, not as the
argument to -F.

This change does exactly that. Also bug #192839 has already been fixed.

Reviewed by: ngie
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D54428

show more ...

makefs: tests: Cleanup and remove default flags

Cleanup and remove default atf_check flags for clarity. The following
two lines are equivalent:

atf_check $cmd
atf_check -s exit:0 -e empty

makefs: tests: Cleanup and remove default flags

Cleanup and remove default atf_check flags for clarity. The following
two lines are equivalent:

atf_check $cmd
atf_check -s exit:0 -e empty -o empty $cmd

Update the links to the reference documents.

Remove the D_flag_cleanup function, as common_cleanup() for these
particular set of tests does two things:

1. Unmount the md(4) device.
2. Destroy the md(4) device.

Essentially, one should only call common_cleanup() if the test body
invokes mount_image(). This is not the case for D_flag_body().

No functional changes intended.

Reviewed by: ngie
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D54427

show more ...

makefs: tests: Double the timeout of ZFS file_extend test

The test makefs_zfs_tests:file_extend is timing out on ci.freebsd.org.
Double the default timeout to allow it to finish.

Reported by: Jenki

makefs: tests: Double the timeout of ZFS file_extend test

The test makefs_zfs_tests:file_extend is timing out on ci.freebsd.org.
Double the default timeout to allow it to finish.

Reported by: Jenkins
Reviewed by: asomers
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D54425

show more ...

makefs: tests: Double the timeout of ZFS compression test

The test makefs_zfs_tests:compression is timing out on ci.freebsd.org.
Double the default timeout to allow it to finish.

While here, check

makefs: tests: Double the timeout of ZFS compression test

The test makefs_zfs_tests:compression is timing out on ci.freebsd.org.
Double the default timeout to allow it to finish.

While here, check if the file exists before cleaning up, otherwise, cat
may fail.

Reported by: Jenkins
Reviewed by: asomers
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D54424

show more ...

makefs: avoid warnings about too-long initializer strings

Mark `direntry::deName` as `__non_string`, to avoid warnings from clang
21 similar to:

usr.sbin/makefs/msdos/msdosfs_vnops.c:512:4: error

makefs: avoid warnings about too-long initializer strings

Mark `direntry::deName` as `__non_string`, to avoid warnings from clang
21 similar to:

usr.sbin/makefs/msdos/msdosfs_vnops.c:512:4: error: initializer-string for character array is too long, array size is 11 but initializer has size 12 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
512 | { ". ", /* the . entry */
| ^~~~~~~~~~~~~
usr.sbin/makefs/msdos/msdosfs_vnops.c:522:4: error: initializer-string for character array is too long, array size is 11 but initializer has size 12 (including the null terminating character); did you mean to use the 'nonstring' attribute? [-Werror,-Wunterminated-string-initialization]
522 | { ".. ", /* the .. entry */
| ^~~~~~~~~~~~~

MFC after: 3 days

show more ...

makefs/tests: Use require.kmods property instead of ad-hoc checks

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Pull Request: https://github.

makefs/tests: Use require.kmods property instead of ad-hoc checks

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Pull Request: https://github.com/freebsd/freebsd-src/pull/1870

show more ...