netlink: Bypass refcounting when setting promiscuity

When asking for IFF_PROMISC when modifying interfaces with netlink, set
permanent flag instead (IFF_PPROMISC) as netlink interface modification
h

netlink: Bypass refcounting when setting promiscuity

When asking for IFF_PROMISC when modifying interfaces with netlink, set
permanent flag instead (IFF_PPROMISC) as netlink interface modification
has no way of doing promiscuity reference counting through ifpromisc().
We can't do reference counting because every netlink interface
modification necessarily either sets or unsets IFF_PROMISC in ifi_flags,
and ifi_change is usually set to 0xFFFFFFFF.

This logic was the same between this and SIOCSIFFLAGS, so factor out
if_setppromisc() function.

Reviewed by: melifaro, saheed, kp, mckusick (mentor)
Approved by: melifaro, saheed, mckusick (mentor)
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52056

show more ...

netlink: Handle `ifhwioctl(SIOCSIFMTU)` failure

Print out error message if setting MTU fails when modifying interface
using netlink.

Reviewed by: saheed, melifaro, mckusick (mentor)
Approved by: sa

netlink: Handle `ifhwioctl(SIOCSIFMTU)` failure

Print out error message if setting MTU fails when modifying interface
using netlink.

Reviewed by: saheed, melifaro, mckusick (mentor)
Approved by: saheed, melifaro, mckusick (mentor)
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D52132

show more ...

netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler

IFF_UP could previously only be unset via RTM_NEWLINK. Requests to set
IFF_UP, though they succeeded, did not actually set the

netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler

IFF_UP could previously only be unset via RTM_NEWLINK. Requests to set
IFF_UP, though they succeeded, did not actually set the flag.

Reviewed by: obiwac, kp, mckusick (mentor)
Approved by: obiwac, kp, mckusick (mentor)
Sponsored by: Google LLC (GSoC)
Differential Revision: https://reviews.freebsd.org/D51871

show more ...

netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK

Allows setting link-layer address (MAC) by specifying the IFLA_ADDRESS
attribute on RTM_NEWLINK requests.

Reviewed by: melifaro, obiwa

netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK

Allows setting link-layer address (MAC) by specifying the IFLA_ADDRESS
attribute on RTM_NEWLINK requests.

Reviewed by: melifaro, obiwac, mckusick (mentor)
Approved by: melifaro, obiwac, mckusick (mentor)
Sponsored by: Google LLC (GSoC)
Differential Revision: https://reviews.freebsd.org/D51922

show more ...

Revert "netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler"

This reverts commit 39dbadb7a410f3955540041848d669264266e552.

This broke the
`sys/netlink/test_rtnl_iface.py:TestRtNl

Revert "netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler"

This reverts commit 39dbadb7a410f3955540041848d669264266e552.

This broke the
`sys/netlink/test_rtnl_iface.py:TestRtNlIface::test_create_iface_attrs`
testcase.

PR: 288967
Reported by: guest-svmhdvn
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D51871

show more ...

netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler

IFF_UP could previously only be unset via RTM_NEWLINK. Requests to set
IFF_UP, though they succeed, did not actually set the fl

netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler

IFF_UP could previously only be unset via RTM_NEWLINK. Requests to set
IFF_UP, though they succeed, did not actually set the flag.

RTM_NEWLINK messages with ifi_change=0 are treated as
ifi_change=0xFFFFFFFF, modifying all the link flags (currently IFF_UP
and IFF_PROMISC) to match the behavior seen on Linux.

Reviewed by: obiwac, kp, mckusick (mentor)
Approved by: obiwac, mckusick (mentor)
Sponsored by: Google LLC (GSoC)
Differential Revision: https://reviews.freebsd.org/D51871

show more ...