netlink.h: Align macro declarations with tabs

Sponsored by: Future Crew, LLC
Approved by: melifaro
Differential Revision: https://reviews.freebsd.org/D47333

netlink: Use __align_up() instead of homegrown roundup2 macro

Sponsored by: Future Crew, LLC
Approved by: melifaro
Differential Revision: https://reviews.freebsd.org/D47333

netlink: Pop NLMSG_ALIGNTO and NLMSG_ALIGN out of the #ifndef _KERNEL block

Sponsored by: Future Crew, LLC
Approved by: melifaro
Differential Revision: https://reviews.freebsd.org/D47333

netlink: Do not cast to int in NLMSG_HDRLEN and _NLMSG_LEN

Approved by: melifaro
Sponsored by: Future Crew, LLC
Differential Revision: https://reviews.freebsd.org/D47333

netlink: use nitems() and roundup(2) from param.h

While here style nested includes (kernel ones go first).

Reviewed by: melifaro
Differential Revision: https://reviews.freebsd.org/D47557

netlink: use proper argument types in genl_register_family()

Reviewed by: melifaro
Differential Revision: https://reviews.freebsd.org/D47553

netlink: use correct uint16_t type for attribute type & length

Reviewed by: melifaro
Differential Revision: https://reviews.freebsd.org/D47552

netlink: use size_t through the allocation KPI

This fixes some signedness bugs and potential underflows. The length of
nl_buf is still limited by UINT_MAX and this is asserted now.

Reviewed by: m

netlink: use size_t through the allocation KPI

This fixes some signedness bugs and potential underflows. The length of
nl_buf is still limited by UINT_MAX and this is asserted now.

Reviewed by: melifaro
Differential Revision: https://reviews.freebsd.org/D47551

show more ...

netlink: check buffer length fits into u_int

We may increase it to size_t later, KPI allows that already, but
doesn't seem to be needed today.

Reviewed by: melifaro
Differential Revision: https://

netlink: check buffer length fits into u_int

We may increase it to size_t later, KPI allows that already, but
doesn't seem to be needed today.

Reviewed by: melifaro
Differential Revision: https://reviews.freebsd.org/D47550

show more ...

netlink: refactor writer initialization KPI

o Allow callers to initialize a writer that will malloc(9) with M_WAITOK.
o Use size_t for expected malloc size.
o Use correct types to initialize a group

netlink: refactor writer initialization KPI

o Allow callers to initialize a writer that will malloc(9) with M_WAITOK.
o Use size_t for expected malloc size.
o Use correct types to initialize a group writer.
o Rename functions into nl_writer_ namespace instead of nlmsg_, cause
they are working on nl_writer, not on nlmsg.
o Make the KPI responsible to sparsely initialize the writer structure.
o Garbage collect chain writer. Fixes 17083b94a915.

All current consumers are left as is, however some may benefit from
M_WAITOK allocation as well as supplying a correct expected size.

Reviewed by: melifaro
Differential Revision: https://reviews.freebsd.org/D47549

show more ...

netlink: use bitset(9)

Reviewed by: melifaro
Differential Revision: https://reviews.freebsd.org/D47548

netlink: consistently use uint16_t for family id

Reviewed by: melifaro
Differential Revision: https://reviews.freebsd.org/D47547

netlink/route: Fix the argument list for rtnl_handle_iflink()

This function is registered as a ifnet_link_event and so should have the
corresponding argument list.

PR: 282870
Reported by: nakayama

netlink/route: Fix the argument list for rtnl_handle_iflink()

This function is registered as a ifnet_link_event and so should have the
corresponding argument list.

PR: 282870
Reported by: nakayamakenjiro@gmail.com
MFC after: 1 week

show more ...

netlink: Don't directly access ifnet members

Summary:
Remove the final direct access of struct ifnet members from netlink.
Since only the first address is used, create the iterator and then free,
wi

netlink: Don't directly access ifnet members

Summary:
Remove the final direct access of struct ifnet members from netlink.
Since only the first address is used, create the iterator and then free,
without fully iterating.

Reviewed By: kp
Sponsored by: Juniper Networks, Inc.
Differential Revision: https://reviews.freebsd.org/D42972

show more ...