Use bus_generic_detach instead of device_delete_children in detach

While here, check for errors from bus_generic_detach and move it to
the start of detach if necessary.

Differential Revision: https

Use bus_generic_detach instead of device_delete_children in detach

While here, check for errors from bus_generic_detach and move it to
the start of detach if necessary.

Differential Revision: https://reviews.freebsd.org/D47969

show more ...

bus_delayed_attach_children: Switch return type to void

This function never fails similar to bus_attach_children.

Reviewed by: imp
Differential Revision: https://reviews.freebsd.org/D47677

newbus: globally replace device_add_child(..., -1) with DEVICE_UNIT_ANY

Sponsored by: Netflix

intelspi: Add support for ddb/kdb -compatible polled mode

Required for Apple and Microsoft -compatible HID-over-SPI drivers.

Most logic was already implemented in commit 3c0867343819
"spibus: exten

intelspi: Add support for ddb/kdb -compatible polled mode

Required for Apple and Microsoft -compatible HID-over-SPI drivers.

Most logic was already implemented in commit 3c0867343819
"spibus: extend API: add cs_delay ivar, KEEP_CS and NO_SLEEP flags".
It dissallowed driver sleeps in the interrupt context. This commit
extends this feature to handle ddb/kdb context with following:
- Skip driver locking if SPI functions were called from kdb/ddb.
- Reinitialize controller if kdb/ddb initiated SPI transfer has
interrupted another already running one. Does not work very
reliable yet.

Reviewed by: manu
Differential Revision: https://reviews.freebsd.org/D41247

show more ...

intelspi: Release LPSS reset on Sunrise Point controllers.

MacBookPro 14.1 SPI controller requires that to start functioning.

MFC after: 1 week
Reviewed by: manu
Differential Revision: https://revi

intelspi: Release LPSS reset on Sunrise Point controllers.

MacBookPro 14.1 SPI controller requires that to start functioning.

MFC after: 1 week
Reviewed by: manu
Differential Revision: https://reviews.freebsd.org/D41245

show more ...

intelspi: Move ACPI/PCI ids table out of header file.

There is no reason to store it multiple times.

MFC after: 1 week
Reviewed by: manu
Differential Revision: https://reviews.freebsd.org/D41244

intelspi: don't leak spibus on detach.

MFC after: 1 week
Reviewed by: manu
Differential Revision: https://reviews.freebsd.org/D41241

intelspi(4): Add missing driver mutex unlock in NO_SLEEP mode

Fixes: 1f40866feb21 ("intelspi: add PCI attachment (Lynx/Wildcat/Sunrise Point)")

MFC after: 1 week

intelspi: add PCI attachment (Lynx/Wildcat/Sunrise Point)

Also adds fixups and cleanups:

- apply the child's mode/speed
- implement suspend/resume support
- use RF_SHAREABLE interrupts
- use bus_de

intelspi: add PCI attachment (Lynx/Wildcat/Sunrise Point)

Also adds fixups and cleanups:

- apply the child's mode/speed
- implement suspend/resume support
- use RF_SHAREABLE interrupts
- use bus_delayed_attach_children since the transfer can use interrupts
- add support for newly added spibus features (cs_delay and flags)

Operation tested on Broadwell (Wildcat Point) MacBookPro12,1.
Attachment also tested on Kaby Lake (Sunrise Point) Pixelbook.

Reviewed by: wulf
MFC after: 1 month
Differential revision: https://reviews.freebsd.org/D29249

show more ...

pchtherm/intelspi: Remove unused devclass arguments to DRIVER_MODULE.

Merge ^/head r339670 through r339812.

Distinguish _CID match and _HID match and make lower priority probe
when _CID match.

Reviewed by: jhb, imp
Differential Revision:https://reviews.freebsd.org/D16468

Merge ^/head r338392 through r338594.

intelspi: don't leak spibus children on detach.

Submitted by: Yuri Pankov
MFC after: 1 week
Approved by: re (gjb)
Differential revision: https://reviews.freebsd.org/D17076

Specify the correct resource type in teardown paths.

Submitted by: Yuri Pankov <yuripv@yuripv.net>
Approved by: re (kib)
MFC after: 1 week

[intelspi] Add SPI driver for Intel BayTrail SoC

Add SPI mode (PIO-only) support for Intel Synchronous Serial Port that
can be found in several Intel's products starting from PXA family.
Most of imp

[intelspi] Add SPI driver for Intel BayTrail SoC

Add SPI mode (PIO-only) support for Intel Synchronous Serial Port that
can be found in several Intel's products starting from PXA family.
Most of implementations have slight differences in behavior and in
addresses for registers subset. This driver covers only BayTrail SoC
implementation for it's the only hardware I have to test it on.

Driver attaches to ACPI bus only and does not have PCI or FDT support
for now due to lack of hardware to test it on.

"intelspi" is the best name I've managed to come up with. Linux driver
name (spi-pxa2xx) does not make sense because current implementation
does not support actual PXA2xx SoCs. And as far as I know there is no
codename assigned to Intel SSP chip.

Reviewed by: br, manu
MFC after: 1 month
Differential Revision: https://reviews.freebsd.org/D8896

show more ...