aq(4): style(9) cleanup

aq(4): Style, whitespace and misc cleanup

The compiled objects do not change other than a few diagnostic messages
that include __LINE__.

Sponsored by: The FreeBSD Foundation
Differential Revision:

aq(4): Style, whitespace and misc cleanup

The compiled objects do not change other than a few diagnostic messages
that include __LINE__.

Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D54304

show more ...

aq(4): Use standard ETHER_ADDR_LEN definition

No need for a bespoke #define.

aq(4): Use sys, not userland, headers

And remove some unused definitions.

Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D54152

aq(4): Fix VLAN tag test

Previously emitted a compiler warning "warning: bitwise comparison
always evaluates to false."

Looking at the OpenBSD driver (which is based on this code) it looks
like the

aq(4): Fix VLAN tag test

Previously emitted a compiler warning "warning: bitwise comparison
always evaluates to false."

Looking at the OpenBSD driver (which is based on this code) it looks
like the VLAN flag should be set if either of these bits is. In the
OpenBSD driver these are AQ_RXDESC_TYPE_VLAN and AQ_RXDESC_TYPE_VLAN2
rather than a magic number 0x60.

Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53836

show more ...

aq(4): Remove unimplemented functions

aq_if_priv_ioctl and aq_if_debug have prototypes but are not yet
implemented. Just remove the commented-out DEVMETHODs and the unused
prototypes, to clear a bu

aq(4): Remove unimplemented functions

aq_if_priv_ioctl and aq_if_debug have prototypes but are not yet
implemented. Just remove the commented-out DEVMETHODs and the unused
prototypes, to clear a build-time warning; the DEVMETHODs and prototypes
can be readded if / when they are implemented.

show more ...

aq(4): Remove unused DRIVER_MODULE devclass

aq(4): Port to IfAPI

Direct access to struct ifnet members is not possible in FreeBSD 15;
accessors must be used. These exist in all supported FreeBSD versions,
so we do not need to make this condi

aq(4): Port to IfAPI

Direct access to struct ifnet members is not possible in FreeBSD 15;
accessors must be used. These exist in all supported FreeBSD versions,
so we do not need to make this conditional.

show more ...

aq(4): Remove #include of user header <unistd.h>

pause() has 2 different definition in unistd.h and sys/systm.h

sys: Import snapshot of Aquantia ACQ107 vendor driver

Obtained from https://github.com/Aquantia/aqtion-freebsd commit
c61d27b1d94af72c642deefa0595884481ea7377.

This is not using a vendor branch. T

sys: Import snapshot of Aquantia ACQ107 vendor driver

Obtained from https://github.com/Aquantia/aqtion-freebsd commit
c61d27b1d94af72c642deefa0595884481ea7377.

This is not using a vendor branch. The formerly-upstream repo is
abandoned and I do not believe it will receive updates. This initial
import serves as a snapshot of the vendor code, but from here we will
iterate on it in the tree as our own code.

Bug fixes, code cleanup, and build infrastructure will follow.

NetBSD and OpenBSD have derivatives of this driver (with additional
hardware support). We can look to changes in those drivers, and the
Linux driver, to add support here.

Reviewed by: adrian
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D53813

show more ...