Fix poor performance of ftp(1) due to small SO_SNDBUF and SO_RCVBUF.ftp(1) from vendor/tnftp always tried the following forevery TCP connection:1. Get the current buffer length of SO_SNDBUF and
Fix poor performance of ftp(1) due to small SO_SNDBUF and SO_RCVBUF.ftp(1) from vendor/tnftp always tried the following forevery TCP connection:1. Get the current buffer length of SO_SNDBUF and SO_RCVBUF by getsockopt(2).2. Invoke setsockopt(2) to set them to the same values after checking if they are in a range between 8 KiB to 8 MiB.This behavior broke dynamic buffer sizing enabled bydefault (net.inet.tcp.{recv,send}buf_auto sysctls) andled to a very poor transfer rate. The fetch(1) utilitydoes not have this problem.This change prevents SO_SNDBUF and SO_RCVBUF from configuringwhen the buffer auto-sizing is enabled unless the buffer sizes areexplicitly specified.PR: 240827Spotted by: Yuichiro NAITOMFC after: 3 daysDifferential Revision: https://reviews.freebsd.org/D23732
show more ...
Switch the default pager for most commands to lessFinally, a pager for the nineties.MFC after: NeverRelnotes: YesDifferential Revision: https://reviews.freebsd.org/D13465Poll: https://reviews
Switch the default pager for most commands to lessFinally, a pager for the nineties.MFC after: NeverRelnotes: YesDifferential Revision: https://reviews.freebsd.org/D13465Poll: https://reviews.freebsd.org/V7
ftp(1): Use closefrom() instead of individual close()s.Use closefrom(3) instead of manually closing all file descriptorsbetween 3 and 19.Obtained from: OpenBSD (CVS 1.80)
Fix warnings in tnftp about invalid constant conversions, e.g.:contrib/tnftp/src/ftp.c:2067:11: error: implicit conversion from 'int'to 'char' changes value from 255 to -1 [-Werror,-Wconstant-conv
Fix warnings in tnftp about invalid constant conversions, e.g.:contrib/tnftp/src/ftp.c:2067:11: error: implicit conversion from 'int'to 'char' changes value from 255 to -1 [-Werror,-Wconstant-conversion] buf[0] = IAC; ~ ^~~/usr/include/arpa/telnet.h:39:13: note: expanded from macro 'IAC'#define IAC 255 /* interpret as command: */ ^~~contrib/tnftp/src/ftp.c:2068:11: error: implicit conversion from 'int'to 'char' changes value from 244 to -12 [-Werror,-Wconstant-conversion] buf[1] = IP; ~ ^~/usr/include/arpa/telnet.h:50:12: note: expanded from macro 'IP'#define IP 244 /* interrupt process--permanently */ ^~~Use an unsigned char buffer instead.MFC after: 1 week
[SA-14:25] Fix kernel stack disclosure in setlogin(2) / getlogin(2).[SA-14:26] Fix remote command execution in ftp(1).Approved by: so (des)
Update NetBSD Foundation copyrights to 2-clause BSDThe NetBSD Foundation states "Third parties are encouraged to change thelicense on any files which have a 4-clause license contributed to theNet
Update NetBSD Foundation copyrights to 2-clause BSDThe NetBSD Foundation states "Third parties are encouraged to change thelicense on any files which have a 4-clause license contributed to theNetBSD Foundation to a 2-clause license."This change removes clauses 3 and 4 from copyright / license blocks thatlist The NetBSD Foundation as the only copyright holder.Sponsored by: The FreeBSD Foundation
Move determination of socket buffer sizes from startup to the first time asocket is used. The previous code structure assumed that AF_INET socketswere always available, which is an invalid assumpt
Move determination of socket buffer sizes from startup to the first time asocket is used. The previous code structure assumed that AF_INET socketswere always available, which is an invalid assumption on IPv6-only systems.This merges the fololowing revisions from NetBSD:src/usr.bin/ftp/main.c 1.120src/usr.bin/ftp/util.c 1.156PR: bin/162661Tested by: bzObtained from: NetBSDMFC after: 1 week
Merge tnftp-20100108 from the vendor branch into head.PR: bin/112288 bin/120256 bin/129014 bin/145528MFC after: 1 month
Copy lukemftp to its new home, tnftp. I'm doing this in stages so as tonot confuse the CVS exporter.