| 81ef0012 | 09-Jun-2025 |
Konstantin Belousov <kib@FreeBSD.org> |
timeout(1): pass full 32bit error return code from the exited child
Switch to use waitid(2) to receive siginfo_t with the complete error
code from the exited process.
Tested by: pho
Reviewed by: ma
timeout(1): pass full 32bit error return code from the exited child
Switch to use waitid(2) to receive siginfo_t with the complete error
code from the exited process.
Tested by: pho
Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D50752
show more ...
|
| aa8cdb7c | 08-Jun-2025 |
Konstantin Belousov <kib@FreeBSD.org> |
timeout(1): only start the child command after the parent is fully set up
Since the default disposition for SIGCHLD is ignore, the prematurely
exited child would cause SIGCHLD dropped. This makes t
timeout(1): only start the child command after the parent is fully set up
Since the default disposition for SIGCHLD is ignore, the prematurely
exited child would cause SIGCHLD dropped. This makes timeout(1) hang,
because REAP_STATUS reports a zombie not waited for, but SIGCHLD for it
was already lost, so the main loop cannot exit, instead calling into
sigsuspend().
Reported and tested by: pho
Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D50752
show more ...
|
| bff05e8a | 07-Jun-2025 |
Konstantin Belousov <kib@FreeBSD.org> |
timeout(1): print errno when signalling syscalls failed
Tested by: pho
Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D5
timeout(1): print errno when signalling syscalls failed
Tested by: pho
Reviewed by: markj
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Differential revision: https://reviews.freebsd.org/D50752
show more ...
|
| c362781c | 03-Apr-2025 |
Aaron LI <aly@aaronly.me> |
timeout(1): Document the reaper implementation and behaivor
If timeout(1) runs with the --foreground option, it becomes the reaper
of the command and its descendants and will wait for all of them to
timeout(1): Document the reaper implementation and behaivor
If timeout(1) runs with the --foreground option, it becomes the reaper
of the command and its descendants and will wait for all of them to
terminate. This behavior is different from the old FreeBSD version and
GNU version.
For example, if there is a descendant running in the background, like:
$ timeout -s INT 2 sh -c 'sleep 4 & sleep 5'
when timeout(1) sends the SIGINT to all descendants, the child 'sh'
process and the foreground 'sleep 5' process will immediately terminate,
but the background 'sleep 4' will be reparented to the timeout(1)
itself. Because a background process ignores SIGINT and SIGQUIT,
the whole command completes until the background 'sleep 4' finishes.
In comparison, the old FreeBSD version and GNU version will just
terminate itself, letting the background 'sleep 4' process be reparented
to an upper reaper like init.
The POSIX.1-2024 standard doesn't specify the required behavior in such
cases, so I decided to keep the current implementation. Nonetheless,
the updated timeout(1) has changed a lot in order to conform to the
standard.
Obtained-from: DragonFly BSD
show more ...
|
| a25b0379 | 16-Apr-2025 |
Baptiste Daroussin <bapt@FreeBSD.org> |
timeout(1): adapt the preserve_status test to the new behaviour
atf-check cannot check anymore the exit number if the program is
terminated via a signal, it needs to be catched by -s signal
because
timeout(1): adapt the preserve_status test to the new behaviour
atf-check cannot check anymore the exit number if the program is
terminated via a signal, it needs to be catched by -s signal
because we cannot pass twice the -s command, we cannot anymore check
for the exit value :(
show more ...
|
| 61331026 | 03-Apr-2025 |
Aaron LI <aly@aaronly.me> |
timeout(1): Kill self with the same signal that terminated the child
A shell may not set '$?' to '128 + signal_number' when the process was
terminated by a signal. For example, KornShell 93 sets '$
timeout(1): Kill self with the same signal that terminated the child
A shell may not set '$?' to '128 + signal_number' when the process was
terminated by a signal. For example, KornShell 93 sets '$?' to
'256 + signal_number' in such cases. In order to avoid any possible
ambiguity, the POSIX.1-2024 standard requires that timeout mimic the
wait status of the child process by terminating itself with the same
signal, while disabling core generation.
Update the man page accordingly.
Obtained-from: DragonFly BSD
Reference: https://pubs.opengroup.org/onlinepubs/9799919799/utilities/timeout.html
show more ...
|
| 844cef26 | 03-Apr-2025 |
Aaron LI <aly@aaronly.me> |
timeout(1): Catch all signals and propagate them
The POSIX.1-2024 standard requires that timeout(1) utility propagate all
signals except SIGALRM, so timeout(1) needs to catch all signals for
this pu
timeout(1): Catch all signals and propagate them
The POSIX.1-2024 standard requires that timeout(1) utility propagate all
signals except SIGALRM, so timeout(1) needs to catch all signals for
this purpose. In addition, we need to separate those signals whose
default action is to terminate the program, because timeout(1) should
start the second timer for the kill signal if those signals are
received.
Obtained-from: DragonFly BSD
Reference: https://pubs.opengroup.org/onlinepubs/9799919799/utilities/timeout.html
show more ...
|
| 2390cbfe | 03-Apr-2025 |
Aaron LI <aly@aaronly.me> |
timeout(1): Fix the inheritance of signal dispositions
POSIX.1-2024 requires that the child process inherit the same signal
dispositions as the timeout(1) utility inherited, except for the signal
to
timeout(1): Fix the inheritance of signal dispositions
POSIX.1-2024 requires that the child process inherit the same signal
dispositions as the timeout(1) utility inherited, except for the signal
to be sent upon timeout.
For example, when timeout(1) is run by nohup(1), the command should be
protected from SIGHUP.
Obtained-from: DragonFly BSD
show more ...
|
| aae3eb24 | 02-Apr-2025 |
Aaron LI <aly@aaronly.me> |
timeout(1): Fix the handling of repeated terminating signals
This actually fixes the following two issues:
* If a terminating signal (e.g., HUP/INT/TERM) was received, timeout
would propagate it
timeout(1): Fix the handling of repeated terminating signals
This actually fixes the following two issues:
* If a terminating signal (e.g., HUP/INT/TERM) was received, timeout
would propagate it to the command and then ignore it. So it was
unable to resend the same terminating signal to the command. This was
different from the GNU's timeout(1), and also contradicted the
POSIX.1-2024 standard.
* Sending two different terminating signals would break timeout(1)'s
--kill-after mechanism. That was because the second signal would
break the for() loop, so the second SIGALRM set by '--kill-after'
would never be caught.
For example, in one shell run:
$ time timeout -f -v -s INT -k 1 2 sh -T -c \
'trap date INT HUP; sleep 5; echo ok; date'
and in another shell run:
$ pkill -INT timeout; pkill -HUP timeout
in the end, the time(1) would report it cost 5 seconds instead of the
expected 3 seconds.
Obtained-from: DragonFly BSD
show more ...
|
| 06c74693 | 02-Apr-2025 |
Aaron LI <aly@aaronly.me> |
timeout(1): Also send SIGCONT because the child may be stopped
The POSIX.1-2024 says:
"If the subsequent wait status of the child process shows that it was
stopped by a signal, a SIGCONT signal sha
timeout(1): Also send SIGCONT because the child may be stopped
The POSIX.1-2024 says:
"If the subsequent wait status of the child process shows that it was
stopped by a signal, a SIGCONT signal shall also be sent in the same
manner as the first signal; otherwise, a SIGCONT signal may be sent in
the same manner."
As it's allowed by the standard, we just always send the SIGCONT signal
to the child process regardless of its stop state, so that timeout could
terminate a stopped child.
Obtained-from: DragonFly BSD
Reference: https://pubs.opengroup.org/onlinepubs/9799919799/utilities/timeout.html
show more ...
|
| 086f1785 | 02-Apr-2025 |
Aaron LI <aly@aaronly.me> |
timeout(1): Enhance send_sig() and prepare for later updates
Enhance send_sig() to better encapsulate the signal sending for
both foreground and non-foreground modes. This also fixes the issue
that
timeout(1): Enhance send_sig() and prepare for later updates
Enhance send_sig() to better encapsulate the signal sending for
both foreground and non-foreground modes. This also fixes the issue
that the latter mode was missing verbose messages.
In addition, improve the verbose logging for signals.
Obtained-from: DragonFly BSD
show more ...
|
| 8a9927ec | 02-Apr-2025 |
Aaron LI <aly@aaronly.me> |
timeout(1): Add -f and -p options as per POSIX.1-2024
POSIX.1-2024 first defined the timeout(1) utility and specified the '-f'
and '-p' options, which are the short versions of '--foreground' and
'-
timeout(1): Add -f and -p options as per POSIX.1-2024
POSIX.1-2024 first defined the timeout(1) utility and specified the '-f'
and '-p' options, which are the short versions of '--foreground' and
'--preserve-status' options, respectively. Add the short versions to
comply with the Standard.
Obtained-from: DragonFly BSD
Reference: https://pubs.opengroup.org/onlinepubs/9799919799/utilities/timeout.html
show more ...
|
| 35503fe2 | 02-Apr-2025 |
Aaron LI <aly@aaronly.me> |
timeout(1): Use _exit(2) instead of err() in child if exec failed
* The child should _exit(2) instead of calling exit(3) via err(3) if the
execvp() failed.
* execvp(2) does not return except on er
timeout(1): Use _exit(2) instead of err() in child if exec failed
* The child should _exit(2) instead of calling exit(3) via err(3) if the
execvp() failed.
* execvp(2) does not return except on error, so there is no need to
check if the return value is -1.
Obtained-from: OpenBSD (via DragonFly BSD)
show more ...
|