xref: /linux/security/apparmor/policy.c (revision c140dcd1246bfe705921ca881bbb247ff1ba2bca)
1 // SPDX-License-Identifier: GPL-2.0-only
2 /*
3  * AppArmor security module
4  *
5  * This file contains AppArmor policy manipulation functions
6  *
7  * Copyright (C) 1998-2008 Novell/SUSE
8  * Copyright 2009-2010 Canonical Ltd.
9  *
10  * AppArmor policy is based around profiles, which contain the rules a
11  * task is confined by.  Every task in the system has a profile attached
12  * to it determined either by matching "unconfined" tasks against the
13  * visible set of profiles or by following a profiles attachment rules.
14  *
15  * Each profile exists in a profile namespace which is a container of
16  * visible profiles.  Each namespace contains a special "unconfined" profile,
17  * which doesn't enforce any confinement on a task beyond DAC.
18  *
19  * Namespace and profile names can be written together in either
20  * of two syntaxes.
21  *	:namespace:profile - used by kernel interfaces for easy detection
22  *	namespace://profile - used by policy
23  *
24  * Profile names can not start with : or @ or ^ and may not contain \0
25  *
26  * Reserved profile names
27  *	unconfined - special automatically generated unconfined profile
28  *	inherit - special name to indicate profile inheritance
29  *	null-XXXX-YYYY - special automatically generated learning profiles
30  *
31  * Namespace names may not start with / or @ and may not contain \0 or :
32  * Reserved namespace names
33  *	user-XXXX - user defined profiles
34  *
35  * a // in a profile or namespace name indicates a hierarchical name with the
36  * name before the // being the parent and the name after the child.
37  *
38  * Profile and namespace hierarchies serve two different but similar purposes.
39  * The namespace contains the set of visible profiles that are considered
40  * for attachment.  The hierarchy of namespaces allows for virtualizing
41  * the namespace so that for example a chroot can have its own set of profiles
42  * which may define some local user namespaces.
43  * The profile hierarchy severs two distinct purposes,
44  * -  it allows for sub profiles or hats, which allows an application to run
45  *    subprograms under its own profile with different restriction than it
46  *    self, and not have it use the system profile.
47  *    eg. if a mail program starts an editor, the policy might make the
48  *        restrictions tighter on the editor tighter than the mail program,
49  *        and definitely different than general editor restrictions
50  * - it allows for binary hierarchy of profiles, so that execution history
51  *   is preserved.  This feature isn't exploited by AppArmor reference policy
52  *   but is allowed.  NOTE: this is currently suboptimal because profile
53  *   aliasing is not currently implemented so that a profile for each
54  *   level must be defined.
55  *   eg. /bin/bash///bin/ls as a name would indicate /bin/ls was started
56  *       from /bin/bash
57  *
58  *   A profile or namespace name that can contain one or more // separators
59  *   is referred to as an hname (hierarchical).
60  *   eg.  /bin/bash//bin/ls
61  *
62  *   An fqname is a name that may contain both namespace and profile hnames.
63  *   eg. :ns:/bin/bash//bin/ls
64  *
65  * NOTES:
66  *   - locking of profile lists is currently fairly coarse.  All profile
67  *     lists within a namespace use the namespace lock.
68  * FIXME: move profile lists to using rcu_lists
69  */
70 
71 #include <linux/slab.h>
72 #include <linux/spinlock.h>
73 #include <linux/string.h>
74 #include <linux/cred.h>
75 #include <linux/rculist.h>
76 #include <linux/user_namespace.h>
77 
78 #include "include/apparmor.h"
79 #include "include/capability.h"
80 #include "include/cred.h"
81 #include "include/file.h"
82 #include "include/ipc.h"
83 #include "include/match.h"
84 #include "include/path.h"
85 #include "include/policy.h"
86 #include "include/policy_ns.h"
87 #include "include/policy_unpack.h"
88 #include "include/resource.h"
89 
90 int unprivileged_userns_apparmor_policy = 1;
91 int aa_unprivileged_unconfined_restricted;
92 
93 const char *const aa_profile_mode_names[] = {
94 	"enforce",
95 	"complain",
96 	"kill",
97 	"unconfined",
98 	"user",
99 };
100 
101 
102 static void aa_free_pdb(struct aa_policydb *pdb)
103 {
104 	if (pdb) {
105 		aa_put_dfa(pdb->dfa);
106 		kvfree(pdb->perms);
107 		aa_destroy_str_table(&pdb->trans);
108 		kfree(pdb);
109 	}
110 }
111 
112 /**
113  * aa_pdb_free_kref - free aa_policydb by kref (called by aa_put_pdb)
114  * @kref: kref callback for freeing of a dfa  (NOT NULL)
115  */
116 void aa_pdb_free_kref(struct kref *kref)
117 {
118 	struct aa_policydb *pdb = container_of(kref, struct aa_policydb, count);
119 
120 	aa_free_pdb(pdb);
121 }
122 
123 
124 struct aa_policydb *aa_alloc_pdb(gfp_t gfp)
125 {
126 	struct aa_policydb *pdb = kzalloc(sizeof(struct aa_policydb), gfp);
127 
128 	if (!pdb)
129 		return NULL;
130 
131 	kref_init(&pdb->count);
132 
133 	return pdb;
134 }
135 
136 
137 /**
138  * __add_profile - add a profiles to list and label tree
139  * @list: list to add it to  (NOT NULL)
140  * @profile: the profile to add  (NOT NULL)
141  *
142  * refcount @profile, should be put by __list_remove_profile
143  *
144  * Requires: namespace lock be held, or list not be shared
145  */
146 static void __add_profile(struct list_head *list, struct aa_profile *profile)
147 {
148 	struct aa_label *l;
149 
150 	AA_BUG(!list);
151 	AA_BUG(!profile);
152 	AA_BUG(!profile->ns);
153 	AA_BUG(!mutex_is_locked(&profile->ns->lock));
154 
155 	list_add_rcu(&profile->base.list, list);
156 	/* get list reference */
157 	aa_get_profile(profile);
158 	l = aa_label_insert(&profile->ns->labels, &profile->label);
159 	AA_BUG(l != &profile->label);
160 	aa_put_label(l);
161 }
162 
163 /**
164  * __list_remove_profile - remove a profile from the list it is on
165  * @profile: the profile to remove  (NOT NULL)
166  *
167  * remove a profile from the list, warning generally removal should
168  * be done with __replace_profile as most profile removals are
169  * replacements to the unconfined profile.
170  *
171  * put @profile list refcount
172  *
173  * Requires: namespace lock be held, or list not have been live
174  */
175 static void __list_remove_profile(struct aa_profile *profile)
176 {
177 	AA_BUG(!profile);
178 	AA_BUG(!profile->ns);
179 	AA_BUG(!mutex_is_locked(&profile->ns->lock));
180 
181 	list_del_rcu(&profile->base.list);
182 	aa_put_profile(profile);
183 }
184 
185 /**
186  * __remove_profile - remove old profile, and children
187  * @profile: profile to be replaced  (NOT NULL)
188  *
189  * Requires: namespace list lock be held, or list not be shared
190  */
191 static void __remove_profile(struct aa_profile *profile)
192 {
193 	AA_BUG(!profile);
194 	AA_BUG(!profile->ns);
195 	AA_BUG(!mutex_is_locked(&profile->ns->lock));
196 
197 	/* release any children lists first */
198 	__aa_profile_list_release(&profile->base.profiles);
199 	/* released by free_profile */
200 	aa_label_remove(&profile->label);
201 	__aafs_profile_rmdir(profile);
202 	__list_remove_profile(profile);
203 }
204 
205 /**
206  * __aa_profile_list_release - remove all profiles on the list and put refs
207  * @head: list of profiles  (NOT NULL)
208  *
209  * Requires: namespace lock be held
210  */
211 void __aa_profile_list_release(struct list_head *head)
212 {
213 	struct aa_profile *profile, *tmp;
214 	list_for_each_entry_safe(profile, tmp, head, base.list)
215 		__remove_profile(profile);
216 }
217 
218 /**
219  * aa_free_data - free a data blob
220  * @ptr: data to free
221  * @arg: unused
222  */
223 static void aa_free_data(void *ptr, void *arg)
224 {
225 	struct aa_data *data = ptr;
226 
227 	kvfree_sensitive(data->data, data->size);
228 	kfree_sensitive(data->key);
229 	kfree_sensitive(data);
230 }
231 
232 static void free_attachment(struct aa_attachment *attach)
233 {
234 	int i;
235 
236 	for (i = 0; i < attach->xattr_count; i++)
237 		kfree_sensitive(attach->xattrs[i]);
238 	kfree_sensitive(attach->xattrs);
239 	aa_put_pdb(attach->xmatch);
240 }
241 
242 static void free_ruleset(struct aa_ruleset *rules)
243 {
244 	int i;
245 
246 	if (!rules)
247 	  return;
248 
249 	aa_put_pdb(rules->file);
250 	aa_put_pdb(rules->policy);
251 	aa_free_cap_rules(&rules->caps);
252 	aa_free_rlimit_rules(&rules->rlimits);
253 
254 	for (i = 0; i < rules->secmark_count; i++)
255 		kfree_sensitive(rules->secmark[i].label);
256 	kfree_sensitive(rules->secmark);
257 	kfree_sensitive(rules);
258 }
259 
260 struct aa_ruleset *aa_alloc_ruleset(gfp_t gfp)
261 {
262 	struct aa_ruleset *rules;
263 
264 	rules = kzalloc(sizeof(*rules), gfp);
265 
266 	return rules;
267 }
268 
269 /**
270  * aa_free_profile - free a profile
271  * @profile: the profile to free  (MAYBE NULL)
272  *
273  * Free a profile, its hats and null_profile. All references to the profile,
274  * its hats and null_profile must have been put.
275  *
276  * If the profile was referenced from a task context, free_profile() will
277  * be called from an rcu callback routine, so we must not sleep here.
278  */
279 void aa_free_profile(struct aa_profile *profile)
280 {
281 	struct rhashtable *rht;
282 
283 	AA_DEBUG(DEBUG_POLICY, "%s(%p)\n", __func__, profile);
284 
285 	if (!profile)
286 		return;
287 
288 	/* free children profiles */
289 	aa_policy_destroy(&profile->base);
290 	aa_put_profile(rcu_access_pointer(profile->parent));
291 
292 	aa_put_ns(profile->ns);
293 	kfree_sensitive(profile->rename);
294 	kfree_sensitive(profile->disconnected);
295 
296 	free_attachment(&profile->attach);
297 
298 	/*
299 	 * at this point there are no tasks that can have a reference
300 	 * to rules
301 	 */
302 	for (int i = 0; i < profile->n_rules; i++)
303 		free_ruleset(profile->label.rules[i]);
304 
305 	kfree_sensitive(profile->dirname);
306 
307 	if (profile->data) {
308 		rht = profile->data;
309 		profile->data = NULL;
310 		rhashtable_free_and_destroy(rht, aa_free_data, NULL);
311 		kfree_sensitive(rht);
312 	}
313 
314 	kfree_sensitive(profile->hash);
315 	aa_put_loaddata(profile->rawdata);
316 	aa_label_destroy(&profile->label);
317 
318 	kfree_sensitive(profile);
319 }
320 
321 /**
322  * aa_alloc_profile - allocate, initialize and return a new profile
323  * @hname: name of the profile  (NOT NULL)
324  * @proxy: proxy to use OR null if to allocate a new one
325  * @gfp: allocation type
326  *
327  * Returns: refcount profile or NULL on failure
328  */
329 struct aa_profile *aa_alloc_profile(const char *hname, struct aa_proxy *proxy,
330 				    gfp_t gfp)
331 {
332 	struct aa_profile *profile;
333 
334 	/* freed by free_profile - usually through aa_put_profile
335 	 * this adds space for a single ruleset in the rules section of the
336 	 * label
337 	 */
338 	profile = kzalloc(struct_size(profile, label.rules, 1), gfp);
339 	if (!profile)
340 		return NULL;
341 
342 	if (!aa_policy_init(&profile->base, NULL, hname, gfp))
343 		goto fail;
344 	if (!aa_label_init(&profile->label, 1, gfp))
345 		goto fail;
346 
347 	/* allocate the first ruleset, but leave it empty */
348 	profile->label.rules[0] = aa_alloc_ruleset(gfp);
349 	if (!profile->label.rules[0])
350 		goto fail;
351 	profile->n_rules = 1;
352 
353 	/* update being set needed by fs interface */
354 	if (!proxy) {
355 		proxy = aa_alloc_proxy(&profile->label, gfp);
356 		if (!proxy)
357 			goto fail;
358 	} else
359 		aa_get_proxy(proxy);
360 	profile->label.proxy = proxy;
361 
362 	profile->label.hname = profile->base.hname;
363 	profile->label.flags |= FLAG_PROFILE;
364 	profile->label.vec[0] = profile;
365 
366 	profile->signal = SIGKILL;
367 	/* refcount released by caller */
368 	return profile;
369 
370 fail:
371 	aa_free_profile(profile);
372 
373 	return NULL;
374 }
375 
376 static inline bool ANY_RULE_MEDIATES(struct aa_profile *profile,
377 				     unsigned char class)
378 {
379 	int i;
380 
381 	for (i = 0; i < profile->n_rules; i++) {
382 		if (RULE_MEDIATES(profile->label.rules[i], class))
383 			return true;
384 	}
385 	return false;
386 }
387 
388 /* set of rules that are mediated by unconfined */
389 static int unconfined_mediates[] = { AA_CLASS_NS, AA_CLASS_IO_URING, 0 };
390 
391 /* must be called after profile rulesets and start information is setup */
392 void aa_compute_profile_mediates(struct aa_profile *profile)
393 {
394 	int c;
395 
396 	if (profile_unconfined(profile)) {
397 		int *pos;
398 
399 		for (pos = unconfined_mediates; *pos; pos++) {
400 			if (ANY_RULE_MEDIATES(profile, *pos))
401 				profile->label.mediates |= ((u64) 1) << AA_CLASS_NS;
402 		}
403 		return;
404 	}
405 	for (c = 0; c <= AA_CLASS_LAST; c++) {
406 		if (ANY_RULE_MEDIATES(profile, c))
407 			profile->label.mediates |= ((u64) 1) << c;
408 	}
409 }
410 
411 /* TODO: profile accounting - setup in remove */
412 
413 /**
414  * __strn_find_child - find a profile on @head list using substring of @name
415  * @head: list to search  (NOT NULL)
416  * @name: name of profile (NOT NULL)
417  * @len: length of @name substring to match
418  *
419  * Requires: rcu_read_lock be held
420  *
421  * Returns: unrefcounted profile ptr, or NULL if not found
422  */
423 static struct aa_profile *__strn_find_child(struct list_head *head,
424 					    const char *name, int len)
425 {
426 	return (struct aa_profile *)__policy_strn_find(head, name, len);
427 }
428 
429 /**
430  * __find_child - find a profile on @head list with a name matching @name
431  * @head: list to search  (NOT NULL)
432  * @name: name of profile (NOT NULL)
433  *
434  * Requires: rcu_read_lock be held
435  *
436  * Returns: unrefcounted profile ptr, or NULL if not found
437  */
438 static struct aa_profile *__find_child(struct list_head *head, const char *name)
439 {
440 	return __strn_find_child(head, name, strlen(name));
441 }
442 
443 /**
444  * aa_find_child - find a profile by @name in @parent
445  * @parent: profile to search  (NOT NULL)
446  * @name: profile name to search for  (NOT NULL)
447  *
448  * Returns: a refcounted profile or NULL if not found
449  */
450 struct aa_profile *aa_find_child(struct aa_profile *parent, const char *name)
451 {
452 	struct aa_profile *profile;
453 
454 	rcu_read_lock();
455 	do {
456 		profile = __find_child(&parent->base.profiles, name);
457 	} while (profile && !aa_get_profile_not0(profile));
458 	rcu_read_unlock();
459 
460 	/* refcount released by caller */
461 	return profile;
462 }
463 
464 /**
465  * __lookup_parent - lookup the parent of a profile of name @hname
466  * @ns: namespace to lookup profile in  (NOT NULL)
467  * @hname: hierarchical profile name to find parent of  (NOT NULL)
468  *
469  * Lookups up the parent of a fully qualified profile name, the profile
470  * that matches hname does not need to exist, in general this
471  * is used to load a new profile.
472  *
473  * Requires: rcu_read_lock be held
474  *
475  * Returns: unrefcounted policy or NULL if not found
476  */
477 static struct aa_policy *__lookup_parent(struct aa_ns *ns,
478 					 const char *hname)
479 {
480 	struct aa_policy *policy;
481 	struct aa_profile *profile = NULL;
482 	char *split;
483 
484 	policy = &ns->base;
485 
486 	for (split = strstr(hname, "//"); split;) {
487 		profile = __strn_find_child(&policy->profiles, hname,
488 					    split - hname);
489 		if (!profile)
490 			return NULL;
491 		policy = &profile->base;
492 		hname = split + 2;
493 		split = strstr(hname, "//");
494 	}
495 	if (!profile)
496 		return &ns->base;
497 	return &profile->base;
498 }
499 
500 /**
501  * __create_missing_ancestors - create place holders for missing ancestors
502  * @ns: namespace to lookup profile in (NOT NULL)
503  * @hname: hierarchical profile name to find parent of (NOT NULL)
504  * @gfp: type of allocation.
505  *
506  * Requires: ns mutex lock held
507  *
508  * Return: unrefcounted parent policy on success or %NULL if error creating
509  *          place holder profiles.
510  */
511 static struct aa_policy *__create_missing_ancestors(struct aa_ns *ns,
512 						    const char *hname,
513 						    gfp_t gfp)
514 {
515 	struct aa_policy *policy;
516 	struct aa_profile *parent, *profile = NULL;
517 	char *split;
518 
519 	AA_BUG(!ns);
520 	AA_BUG(!hname);
521 
522 	policy = &ns->base;
523 
524 	for (split = strstr(hname, "//"); split;) {
525 		parent = profile;
526 		profile = __strn_find_child(&policy->profiles, hname,
527 					    split - hname);
528 		if (!profile) {
529 			const char *name = kstrndup(hname, split - hname,
530 						    gfp);
531 			if (!name)
532 				return NULL;
533 			profile = aa_alloc_null(parent, name, gfp);
534 			kfree(name);
535 			if (!profile)
536 				return NULL;
537 			if (!parent)
538 				profile->ns = aa_get_ns(ns);
539 		}
540 		policy = &profile->base;
541 		hname = split + 2;
542 		split = strstr(hname, "//");
543 	}
544 	if (!profile)
545 		return &ns->base;
546 	return &profile->base;
547 }
548 
549 /**
550  * __lookupn_profile - lookup the profile matching @hname
551  * @base: base list to start looking up profile name from  (NOT NULL)
552  * @hname: hierarchical profile name  (NOT NULL)
553  * @n: length of @hname
554  *
555  * Requires: rcu_read_lock be held
556  *
557  * Returns: unrefcounted profile pointer or NULL if not found
558  *
559  * Do a relative name lookup, recursing through profile tree.
560  */
561 static struct aa_profile *__lookupn_profile(struct aa_policy *base,
562 					    const char *hname, size_t n)
563 {
564 	struct aa_profile *profile = NULL;
565 	const char *split;
566 
567 	for (split = strnstr(hname, "//", n); split;
568 	     split = strnstr(hname, "//", n)) {
569 		profile = __strn_find_child(&base->profiles, hname,
570 					    split - hname);
571 		if (!profile)
572 			return NULL;
573 
574 		base = &profile->base;
575 		n -= split + 2 - hname;
576 		hname = split + 2;
577 	}
578 
579 	if (n)
580 		return __strn_find_child(&base->profiles, hname, n);
581 	return NULL;
582 }
583 
584 static struct aa_profile *__lookup_profile(struct aa_policy *base,
585 					   const char *hname)
586 {
587 	return __lookupn_profile(base, hname, strlen(hname));
588 }
589 
590 /**
591  * aa_lookupn_profile - find a profile by its full or partial name
592  * @ns: the namespace to start from (NOT NULL)
593  * @hname: name to do lookup on.  Does not contain namespace prefix (NOT NULL)
594  * @n: size of @hname
595  *
596  * Returns: refcounted profile or NULL if not found
597  */
598 struct aa_profile *aa_lookupn_profile(struct aa_ns *ns, const char *hname,
599 				      size_t n)
600 {
601 	struct aa_profile *profile;
602 
603 	rcu_read_lock();
604 	do {
605 		profile = __lookupn_profile(&ns->base, hname, n);
606 	} while (profile && !aa_get_profile_not0(profile));
607 	rcu_read_unlock();
608 
609 	/* the unconfined profile is not in the regular profile list */
610 	if (!profile && strncmp(hname, "unconfined", n) == 0)
611 		profile = aa_get_newest_profile(ns->unconfined);
612 
613 	/* refcount released by caller */
614 	return profile;
615 }
616 
617 struct aa_profile *aa_fqlookupn_profile(struct aa_label *base,
618 					const char *fqname, size_t n)
619 {
620 	struct aa_profile *profile;
621 	struct aa_ns *ns;
622 	const char *name, *ns_name;
623 	size_t ns_len;
624 
625 	name = aa_splitn_fqname(fqname, n, &ns_name, &ns_len);
626 	if (ns_name) {
627 		ns = aa_lookupn_ns(labels_ns(base), ns_name, ns_len);
628 		if (!ns)
629 			return NULL;
630 	} else
631 		ns = aa_get_ns(labels_ns(base));
632 
633 	if (name)
634 		profile = aa_lookupn_profile(ns, name, n - (name - fqname));
635 	else if (ns)
636 		/* default profile for ns, currently unconfined */
637 		profile = aa_get_newest_profile(ns->unconfined);
638 	else
639 		profile = NULL;
640 	aa_put_ns(ns);
641 
642 	return profile;
643 }
644 
645 
646 struct aa_profile *aa_alloc_null(struct aa_profile *parent, const char *name,
647 				 gfp_t gfp)
648 {
649 	struct aa_profile *profile;
650 	struct aa_ruleset *rules;
651 
652 	profile = aa_alloc_profile(name, NULL, gfp);
653 	if (!profile)
654 		return NULL;
655 
656 	/* TODO: ideally we should inherit abi from parent */
657 	profile->label.flags |= FLAG_NULL;
658 	profile->attach.xmatch = aa_get_pdb(nullpdb);
659 	rules = profile->label.rules[0];
660 	rules->file = aa_get_pdb(nullpdb);
661 	rules->policy = aa_get_pdb(nullpdb);
662 	aa_compute_profile_mediates(profile);
663 
664 	if (parent) {
665 		profile->path_flags = parent->path_flags;
666 		/* override/inherit what is mediated from parent */
667 		profile->label.mediates = parent->label.mediates;
668 		/* released on free_profile */
669 		rcu_assign_pointer(profile->parent, aa_get_profile(parent));
670 		profile->ns = aa_get_ns(parent->ns);
671 	}
672 
673 	return profile;
674 }
675 
676 /**
677  * aa_new_learning_profile - create or find a null-X learning profile
678  * @parent: profile that caused this profile to be created (NOT NULL)
679  * @hat: true if the null- learning profile is a hat
680  * @base: name to base the null profile off of
681  * @gfp: type of allocation
682  *
683  * Find/Create a null- complain mode profile used in learning mode.  The
684  * name of the profile is unique and follows the format of parent//null-XXX.
685  * where XXX is based on the @name or if that fails or is not supplied
686  * a unique number
687  *
688  * null profiles are added to the profile list but the list does not
689  * hold a count on them so that they are automatically released when
690  * not in use.
691  *
692  * Returns: new refcounted profile else NULL on failure
693  */
694 struct aa_profile *aa_new_learning_profile(struct aa_profile *parent, bool hat,
695 					   const char *base, gfp_t gfp)
696 {
697 	struct aa_profile *p, *profile;
698 	const char *bname;
699 	char *name = NULL;
700 	size_t name_sz;
701 
702 	AA_BUG(!parent);
703 
704 	if (base) {
705 		name_sz = strlen(parent->base.hname) + 8 + strlen(base);
706 		name = kmalloc(name_sz, gfp);
707 		if (name) {
708 			snprintf(name, name_sz, "%s//null-%s",
709 				 parent->base.hname, base);
710 			goto name;
711 		}
712 		/* fall through to try shorter uniq */
713 	}
714 
715 	name_sz = strlen(parent->base.hname) + 2 + 7 + 8;
716 	name = kmalloc(name_sz, gfp);
717 	if (!name)
718 		return NULL;
719 	snprintf(name, name_sz, "%s//null-%x", parent->base.hname,
720 		 atomic_inc_return(&parent->ns->uniq_null));
721 
722 name:
723 	/* lookup to see if this is a dup creation */
724 	bname = basename(name);
725 	profile = aa_find_child(parent, bname);
726 	if (profile)
727 		goto out;
728 
729 	profile = aa_alloc_null(parent, name, gfp);
730 	if (!profile)
731 		goto fail;
732 	profile->mode = APPARMOR_COMPLAIN;
733 	if (hat)
734 		profile->label.flags |= FLAG_HAT;
735 
736 	mutex_lock_nested(&profile->ns->lock, profile->ns->level);
737 	p = __find_child(&parent->base.profiles, bname);
738 	if (p) {
739 		aa_free_profile(profile);
740 		profile = aa_get_profile(p);
741 	} else {
742 		__add_profile(&parent->base.profiles, profile);
743 	}
744 	mutex_unlock(&profile->ns->lock);
745 
746 	/* refcount released by caller */
747 out:
748 	kfree(name);
749 
750 	return profile;
751 
752 fail:
753 	kfree(name);
754 	aa_free_profile(profile);
755 	return NULL;
756 }
757 
758 /**
759  * replacement_allowed - test to see if replacement is allowed
760  * @profile: profile to test if it can be replaced  (MAYBE NULL)
761  * @noreplace: true if replacement shouldn't be allowed but addition is okay
762  * @info: Returns - info about why replacement failed (NOT NULL)
763  *
764  * Returns: %0 if replacement allowed else error code
765  */
766 static int replacement_allowed(struct aa_profile *profile, int noreplace,
767 			       const char **info)
768 {
769 	if (profile) {
770 		if (profile->label.flags & FLAG_IMMUTIBLE) {
771 			*info = "cannot replace immutable profile";
772 			return -EPERM;
773 		} else if (noreplace) {
774 			*info = "profile already exists";
775 			return -EEXIST;
776 		}
777 	}
778 	return 0;
779 }
780 
781 /* audit callback for net specific fields */
782 static void audit_cb(struct audit_buffer *ab, void *va)
783 {
784 	struct common_audit_data *sa = va;
785 	struct apparmor_audit_data *ad = aad(sa);
786 
787 	if (ad->iface.ns) {
788 		audit_log_format(ab, " ns=");
789 		audit_log_untrustedstring(ab, ad->iface.ns);
790 	}
791 }
792 
793 /**
794  * audit_policy - Do auditing of policy changes
795  * @subj_label: label to check if it can manage policy
796  * @op: policy operation being performed
797  * @ns_name: name of namespace being manipulated
798  * @name: name of profile being manipulated (NOT NULL)
799  * @info: any extra information to be audited (MAYBE NULL)
800  * @error: error code
801  *
802  * Returns: the error to be returned after audit is done
803  */
804 static int audit_policy(struct aa_label *subj_label, const char *op,
805 			const char *ns_name, const char *name,
806 			const char *info, int error)
807 {
808 	DEFINE_AUDIT_DATA(ad, LSM_AUDIT_DATA_NONE, AA_CLASS_NONE, op);
809 
810 	ad.iface.ns = ns_name;
811 	ad.name = name;
812 	ad.info = info;
813 	ad.error = error;
814 	ad.subj_label = subj_label;
815 
816 	aa_audit_msg(AUDIT_APPARMOR_STATUS, &ad, audit_cb);
817 
818 	return error;
819 }
820 
821 /* don't call out to other LSMs in the stack for apparmor policy admin
822  * permissions
823  */
824 static int policy_ns_capable(const struct cred *subj_cred,
825 			     struct aa_label *label,
826 			     struct user_namespace *userns, int cap)
827 {
828 	int err;
829 
830 	/* check for MAC_ADMIN cap in cred */
831 	err = cap_capable(subj_cred, userns, cap, CAP_OPT_NONE);
832 	if (!err)
833 		err = aa_capable(subj_cred, label, cap, CAP_OPT_NONE);
834 
835 	return err;
836 }
837 
838 /**
839  * aa_policy_view_capable - check if viewing policy in at @ns is allowed
840  * @subj_cred: cred of subject
841  * @label: label that is trying to view policy in ns
842  * @ns: namespace being viewed by @label (may be NULL if @label's ns)
843  *
844  * Returns: true if viewing policy is allowed
845  *
846  * If @ns is NULL then the namespace being viewed is assumed to be the
847  * tasks current namespace.
848  */
849 bool aa_policy_view_capable(const struct cred *subj_cred,
850 			     struct aa_label *label, struct aa_ns *ns)
851 {
852 	struct user_namespace *user_ns = subj_cred->user_ns;
853 	struct aa_ns *view_ns = labels_view(label);
854 	bool root_in_user_ns = uid_eq(current_euid(), make_kuid(user_ns, 0)) ||
855 			       in_egroup_p(make_kgid(user_ns, 0));
856 	bool response = false;
857 	if (!ns)
858 		ns = view_ns;
859 
860 	if (root_in_user_ns && aa_ns_visible(view_ns, ns, true) &&
861 	    (user_ns == &init_user_ns ||
862 	     (unprivileged_userns_apparmor_policy != 0 &&
863 	      user_ns->level == view_ns->level)))
864 		response = true;
865 
866 	return response;
867 }
868 
869 bool aa_policy_admin_capable(const struct cred *subj_cred,
870 			     struct aa_label *label, struct aa_ns *ns)
871 {
872 	struct user_namespace *user_ns = subj_cred->user_ns;
873 	bool capable = policy_ns_capable(subj_cred, label, user_ns,
874 					 CAP_MAC_ADMIN) == 0;
875 
876 	AA_DEBUG(DEBUG_POLICY, "cap_mac_admin? %d\n", capable);
877 	AA_DEBUG(DEBUG_POLICY, "policy locked? %d\n", aa_g_lock_policy);
878 
879 	return aa_policy_view_capable(subj_cred, label, ns) && capable &&
880 		!aa_g_lock_policy;
881 }
882 
883 bool aa_current_policy_view_capable(struct aa_ns *ns)
884 {
885 	struct aa_label *label;
886 	bool needput, res;
887 
888 	label = __begin_current_label_crit_section(&needput);
889 	res = aa_policy_view_capable(current_cred(), label, ns);
890 	__end_current_label_crit_section(label, needput);
891 
892 	return res;
893 }
894 
895 bool aa_current_policy_admin_capable(struct aa_ns *ns)
896 {
897 	struct aa_label *label;
898 	bool needput, res;
899 
900 	label = __begin_current_label_crit_section(&needput);
901 	res = aa_policy_admin_capable(current_cred(), label, ns);
902 	__end_current_label_crit_section(label, needput);
903 
904 	return res;
905 }
906 
907 /**
908  * aa_may_manage_policy - can the current task manage policy
909  * @subj_cred: subjects cred
910  * @label: label to check if it can manage policy
911  * @ns: namespace being managed by @label (may be NULL if @label's ns)
912  * @mask: contains the policy manipulation operation being done
913  *
914  * Returns: 0 if the task is allowed to manipulate policy else error
915  */
916 int aa_may_manage_policy(const struct cred *subj_cred, struct aa_label *label,
917 			 struct aa_ns *ns, u32 mask)
918 {
919 	const char *op;
920 
921 	if (mask & AA_MAY_REMOVE_POLICY)
922 		op = OP_PROF_RM;
923 	else if (mask & AA_MAY_REPLACE_POLICY)
924 		op = OP_PROF_REPL;
925 	else
926 		op = OP_PROF_LOAD;
927 
928 	/* check if loading policy is locked out */
929 	if (aa_g_lock_policy)
930 		return audit_policy(label, op, NULL, NULL, "policy_locked",
931 				    -EACCES);
932 
933 	if (!aa_policy_admin_capable(subj_cred, label, ns))
934 		return audit_policy(label, op, NULL, NULL, "not policy admin",
935 				    -EACCES);
936 
937 	/* TODO: add fine grained mediation of policy loads */
938 	return 0;
939 }
940 
941 static struct aa_profile *__list_lookup_parent(struct list_head *lh,
942 					       struct aa_profile *profile)
943 {
944 	const char *base = basename(profile->base.hname);
945 	long len = base - profile->base.hname;
946 	struct aa_load_ent *ent;
947 
948 	/* parent won't have trailing // so remove from len */
949 	if (len <= 2)
950 		return NULL;
951 	len -= 2;
952 
953 	list_for_each_entry(ent, lh, list) {
954 		if (ent->new == profile)
955 			continue;
956 		if (strncmp(ent->new->base.hname, profile->base.hname, len) ==
957 		    0 && ent->new->base.hname[len] == 0)
958 			return ent->new;
959 	}
960 
961 	return NULL;
962 }
963 
964 /**
965  * __replace_profile - replace @old with @new on a list
966  * @old: profile to be replaced  (NOT NULL)
967  * @new: profile to replace @old with  (NOT NULL)
968  *
969  * Will duplicate and refcount elements that @new inherits from @old
970  * and will inherit @old children.
971  *
972  * refcount @new for list, put @old list refcount
973  *
974  * Requires: namespace list lock be held, or list not be shared
975  */
976 static void __replace_profile(struct aa_profile *old, struct aa_profile *new)
977 {
978 	struct aa_profile *child, *tmp;
979 
980 	if (!list_empty(&old->base.profiles)) {
981 		LIST_HEAD(lh);
982 		list_splice_init_rcu(&old->base.profiles, &lh, synchronize_rcu);
983 
984 		list_for_each_entry_safe(child, tmp, &lh, base.list) {
985 			struct aa_profile *p;
986 
987 			list_del_init(&child->base.list);
988 			p = __find_child(&new->base.profiles, child->base.name);
989 			if (p) {
990 				/* @p replaces @child  */
991 				__replace_profile(child, p);
992 				continue;
993 			}
994 
995 			/* inherit @child and its children */
996 			/* TODO: update hname of inherited children */
997 			/* list refcount transferred to @new */
998 			p = aa_deref_parent(child);
999 			rcu_assign_pointer(child->parent, aa_get_profile(new));
1000 			list_add_rcu(&child->base.list, &new->base.profiles);
1001 			aa_put_profile(p);
1002 		}
1003 	}
1004 
1005 	if (!rcu_access_pointer(new->parent)) {
1006 		struct aa_profile *parent = aa_deref_parent(old);
1007 		rcu_assign_pointer(new->parent, aa_get_profile(parent));
1008 	}
1009 	aa_label_replace(&old->label, &new->label);
1010 	/* migrate dents must come after label replacement b/c update */
1011 	__aafs_profile_migrate_dents(old, new);
1012 
1013 	if (list_empty(&new->base.list)) {
1014 		/* new is not on a list already */
1015 		list_replace_rcu(&old->base.list, &new->base.list);
1016 		aa_get_profile(new);
1017 		aa_put_profile(old);
1018 	} else
1019 		__list_remove_profile(old);
1020 }
1021 
1022 /**
1023  * __lookup_replace - lookup replacement information for a profile
1024  * @ns: namespace the lookup occurs in
1025  * @hname: name of profile to lookup
1026  * @noreplace: true if not replacing an existing profile
1027  * @p: Returns - profile to be replaced
1028  * @info: Returns - info string on why lookup failed
1029  *
1030  * Returns: profile to replace (no ref) on success else ptr error
1031  */
1032 static int __lookup_replace(struct aa_ns *ns, const char *hname,
1033 			    bool noreplace, struct aa_profile **p,
1034 			    const char **info)
1035 {
1036 	*p = aa_get_profile(__lookup_profile(&ns->base, hname));
1037 	if (*p) {
1038 		int error = replacement_allowed(*p, noreplace, info);
1039 		if (error) {
1040 			*info = "profile can not be replaced";
1041 			return error;
1042 		}
1043 	}
1044 
1045 	return 0;
1046 }
1047 
1048 static void share_name(struct aa_profile *old, struct aa_profile *new)
1049 {
1050 	aa_put_str(new->base.hname);
1051 	aa_get_str(old->base.hname);
1052 	new->base.hname = old->base.hname;
1053 	new->base.name = old->base.name;
1054 	new->label.hname = old->label.hname;
1055 }
1056 
1057 /* Update to newest version of parent after previous replacements
1058  * Returns: unrefcount newest version of parent
1059  */
1060 static struct aa_profile *update_to_newest_parent(struct aa_profile *new)
1061 {
1062 	struct aa_profile *parent, *newest;
1063 
1064 	parent = rcu_dereference_protected(new->parent,
1065 					   mutex_is_locked(&new->ns->lock));
1066 	newest = aa_get_newest_profile(parent);
1067 
1068 	/* parent replaced in this atomic set? */
1069 	if (newest != parent) {
1070 		aa_put_profile(parent);
1071 		rcu_assign_pointer(new->parent, newest);
1072 	} else
1073 		aa_put_profile(newest);
1074 
1075 	return newest;
1076 }
1077 
1078 /**
1079  * aa_replace_profiles - replace profile(s) on the profile list
1080  * @policy_ns: namespace load is occurring on
1081  * @label: label that is attempting to load/replace policy
1082  * @mask: permission mask
1083  * @udata: serialized data stream  (NOT NULL)
1084  *
1085  * unpack and replace a profile on the profile list and uses of that profile
1086  * by any task creds via invalidating the old version of the profile, which
1087  * tasks will notice to update their own cred.  If the profile does not exist
1088  * on the profile list it is added.
1089  *
1090  * Returns: size of data consumed else error code on failure.
1091  */
1092 ssize_t aa_replace_profiles(struct aa_ns *policy_ns, struct aa_label *label,
1093 			    u32 mask, struct aa_loaddata *udata)
1094 {
1095 	const char *ns_name = NULL, *info = NULL;
1096 	struct aa_ns *ns = NULL;
1097 	struct aa_load_ent *ent, *tmp;
1098 	struct aa_loaddata *rawdata_ent;
1099 	const char *op;
1100 	ssize_t count, error;
1101 	LIST_HEAD(lh);
1102 
1103 	op = mask & AA_MAY_REPLACE_POLICY ? OP_PROF_REPL : OP_PROF_LOAD;
1104 	aa_get_loaddata(udata);
1105 	/* released below */
1106 	error = aa_unpack(udata, &lh, &ns_name);
1107 	if (error)
1108 		goto out;
1109 
1110 	/* ensure that profiles are all for the same ns
1111 	 * TODO: update locking to remove this constraint. All profiles in
1112 	 *       the load set must succeed as a set or the load will
1113 	 *       fail. Sort ent list and take ns locks in hierarchy order
1114 	 */
1115 	count = 0;
1116 	list_for_each_entry(ent, &lh, list) {
1117 		if (ns_name) {
1118 			if (ent->ns_name &&
1119 			    strcmp(ent->ns_name, ns_name) != 0) {
1120 				info = "policy load has mixed namespaces";
1121 				error = -EACCES;
1122 				goto fail;
1123 			}
1124 		} else if (ent->ns_name) {
1125 			if (count) {
1126 				info = "policy load has mixed namespaces";
1127 				error = -EACCES;
1128 				goto fail;
1129 			}
1130 			ns_name = ent->ns_name;
1131 		} else
1132 			count++;
1133 	}
1134 	if (ns_name) {
1135 		ns = aa_prepare_ns(policy_ns ? policy_ns : labels_ns(label),
1136 				   ns_name);
1137 		if (IS_ERR(ns)) {
1138 			op = OP_PROF_LOAD;
1139 			info = "failed to prepare namespace";
1140 			error = PTR_ERR(ns);
1141 			ns = NULL;
1142 			ent = NULL;
1143 			goto fail;
1144 		}
1145 	} else
1146 		ns = aa_get_ns(policy_ns ? policy_ns : labels_ns(label));
1147 
1148 	mutex_lock_nested(&ns->lock, ns->level);
1149 	/* check for duplicate rawdata blobs: space and file dedup */
1150 	if (!list_empty(&ns->rawdata_list)) {
1151 		list_for_each_entry(rawdata_ent, &ns->rawdata_list, list) {
1152 			if (aa_rawdata_eq(rawdata_ent, udata)) {
1153 				struct aa_loaddata *tmp;
1154 
1155 				tmp = __aa_get_loaddata(rawdata_ent);
1156 				/* check we didn't fail the race */
1157 				if (tmp) {
1158 					aa_put_loaddata(udata);
1159 					udata = tmp;
1160 					break;
1161 				}
1162 			}
1163 		}
1164 	}
1165 	/* setup parent and ns info */
1166 	list_for_each_entry(ent, &lh, list) {
1167 		struct aa_policy *policy;
1168 		struct aa_profile *p;
1169 
1170 		if (aa_g_export_binary)
1171 			ent->new->rawdata = aa_get_loaddata(udata);
1172 		error = __lookup_replace(ns, ent->new->base.hname,
1173 					 !(mask & AA_MAY_REPLACE_POLICY),
1174 					 &ent->old, &info);
1175 		if (error)
1176 			goto fail_lock;
1177 
1178 		if (ent->new->rename) {
1179 			error = __lookup_replace(ns, ent->new->rename,
1180 						!(mask & AA_MAY_REPLACE_POLICY),
1181 						&ent->rename, &info);
1182 			if (error)
1183 				goto fail_lock;
1184 		}
1185 
1186 		/* released when @new is freed */
1187 		ent->new->ns = aa_get_ns(ns);
1188 
1189 		if (ent->old || ent->rename)
1190 			continue;
1191 
1192 		/* no ref on policy only use inside lock */
1193 		p = NULL;
1194 		policy = __lookup_parent(ns, ent->new->base.hname);
1195 		if (!policy) {
1196 			/* first check for parent in the load set */
1197 			p = __list_lookup_parent(&lh, ent->new);
1198 			if (!p) {
1199 				/*
1200 				 * fill in missing parent with null
1201 				 * profile that doesn't have
1202 				 * permissions. This allows for
1203 				 * individual profile loading where
1204 				 * the child is loaded before the
1205 				 * parent, and outside of the current
1206 				 * atomic set. This unfortunately can
1207 				 * happen with some userspaces.  The
1208 				 * null profile will be replaced once
1209 				 * the parent is loaded.
1210 				 */
1211 				policy = __create_missing_ancestors(ns,
1212 							ent->new->base.hname,
1213 							GFP_KERNEL);
1214 				if (!policy) {
1215 					error = -ENOENT;
1216 					info = "parent does not exist";
1217 					goto fail_lock;
1218 				}
1219 			}
1220 		}
1221 		if (!p && policy != &ns->base)
1222 			/* released on profile replacement or free_profile */
1223 			p = (struct aa_profile *) policy;
1224 		rcu_assign_pointer(ent->new->parent, aa_get_profile(p));
1225 	}
1226 
1227 	/* create new fs entries for introspection if needed */
1228 	if (!udata->dents[AAFS_LOADDATA_DIR] && aa_g_export_binary) {
1229 		error = __aa_fs_create_rawdata(ns, udata);
1230 		if (error) {
1231 			info = "failed to create raw_data dir and files";
1232 			ent = NULL;
1233 			goto fail_lock;
1234 		}
1235 	}
1236 	list_for_each_entry(ent, &lh, list) {
1237 		if (!ent->old) {
1238 			struct dentry *parent;
1239 			if (rcu_access_pointer(ent->new->parent)) {
1240 				struct aa_profile *p;
1241 				p = aa_deref_parent(ent->new);
1242 				parent = prof_child_dir(p);
1243 			} else
1244 				parent = ns_subprofs_dir(ent->new->ns);
1245 			error = __aafs_profile_mkdir(ent->new, parent);
1246 		}
1247 
1248 		if (error) {
1249 			info = "failed to create";
1250 			goto fail_lock;
1251 		}
1252 	}
1253 
1254 	/* Done with checks that may fail - do actual replacement */
1255 	__aa_bump_ns_revision(ns);
1256 	if (aa_g_export_binary)
1257 		__aa_loaddata_update(udata, ns->revision);
1258 	list_for_each_entry_safe(ent, tmp, &lh, list) {
1259 		list_del_init(&ent->list);
1260 		op = (!ent->old && !ent->rename) ? OP_PROF_LOAD : OP_PROF_REPL;
1261 
1262 		if (ent->old && ent->old->rawdata == ent->new->rawdata &&
1263 		    ent->new->rawdata) {
1264 			/* dedup actual profile replacement */
1265 			audit_policy(label, op, ns_name, ent->new->base.hname,
1266 				     "same as current profile, skipping",
1267 				     error);
1268 			/* break refcount cycle with proxy. */
1269 			aa_put_proxy(ent->new->label.proxy);
1270 			ent->new->label.proxy = NULL;
1271 			goto skip;
1272 		}
1273 
1274 		/*
1275 		 * TODO: finer dedup based on profile range in data. Load set
1276 		 * can differ but profile may remain unchanged
1277 		 */
1278 		audit_policy(label, op, ns_name, ent->new->base.hname, NULL,
1279 			     error);
1280 
1281 		if (ent->old) {
1282 			share_name(ent->old, ent->new);
1283 			__replace_profile(ent->old, ent->new);
1284 		} else {
1285 			struct list_head *lh;
1286 
1287 			if (rcu_access_pointer(ent->new->parent)) {
1288 				struct aa_profile *parent;
1289 
1290 				parent = update_to_newest_parent(ent->new);
1291 				lh = &parent->base.profiles;
1292 			} else
1293 				lh = &ns->base.profiles;
1294 			__add_profile(lh, ent->new);
1295 		}
1296 	skip:
1297 		aa_load_ent_free(ent);
1298 	}
1299 	__aa_labelset_update_subtree(ns);
1300 	mutex_unlock(&ns->lock);
1301 
1302 out:
1303 	aa_put_ns(ns);
1304 	aa_put_loaddata(udata);
1305 	kfree(ns_name);
1306 
1307 	if (error)
1308 		return error;
1309 	return udata->size;
1310 
1311 fail_lock:
1312 	mutex_unlock(&ns->lock);
1313 
1314 	/* audit cause of failure */
1315 	op = (ent && !ent->old) ? OP_PROF_LOAD : OP_PROF_REPL;
1316 fail:
1317 	  audit_policy(label, op, ns_name, ent ? ent->new->base.hname : NULL,
1318 		       info, error);
1319 	/* audit status that rest of profiles in the atomic set failed too */
1320 	info = "valid profile in failed atomic policy load";
1321 	list_for_each_entry(tmp, &lh, list) {
1322 		if (tmp == ent) {
1323 			info = "unchecked profile in failed atomic policy load";
1324 			/* skip entry that caused failure */
1325 			continue;
1326 		}
1327 		op = (!tmp->old) ? OP_PROF_LOAD : OP_PROF_REPL;
1328 		audit_policy(label, op, ns_name, tmp->new->base.hname, info,
1329 			     error);
1330 	}
1331 	list_for_each_entry_safe(ent, tmp, &lh, list) {
1332 		list_del_init(&ent->list);
1333 		aa_load_ent_free(ent);
1334 	}
1335 
1336 	goto out;
1337 }
1338 
1339 /**
1340  * aa_remove_profiles - remove profile(s) from the system
1341  * @policy_ns: namespace the remove is being done from
1342  * @subj: label attempting to remove policy
1343  * @fqname: name of the profile or namespace to remove  (NOT NULL)
1344  * @size: size of the name
1345  *
1346  * Remove a profile or sub namespace from the current namespace, so that
1347  * they can not be found anymore and mark them as replaced by unconfined
1348  *
1349  * NOTE: removing confinement does not restore rlimits to preconfinement values
1350  *
1351  * Returns: size of data consume else error code if fails
1352  */
1353 ssize_t aa_remove_profiles(struct aa_ns *policy_ns, struct aa_label *subj,
1354 			   char *fqname, size_t size)
1355 {
1356 	struct aa_ns *ns = NULL;
1357 	struct aa_profile *profile = NULL;
1358 	const char *name = fqname, *info = NULL;
1359 	const char *ns_name = NULL;
1360 	ssize_t error = 0;
1361 
1362 	if (*fqname == 0) {
1363 		info = "no profile specified";
1364 		error = -ENOENT;
1365 		goto fail;
1366 	}
1367 
1368 	if (fqname[0] == ':') {
1369 		size_t ns_len;
1370 
1371 		name = aa_splitn_fqname(fqname, size, &ns_name, &ns_len);
1372 		/* released below */
1373 		ns = aa_lookupn_ns(policy_ns ? policy_ns : labels_ns(subj),
1374 				   ns_name, ns_len);
1375 		if (!ns) {
1376 			info = "namespace does not exist";
1377 			error = -ENOENT;
1378 			goto fail;
1379 		}
1380 	} else
1381 		/* released below */
1382 		ns = aa_get_ns(policy_ns ? policy_ns : labels_ns(subj));
1383 
1384 	if (!name) {
1385 		/* remove namespace - can only happen if fqname[0] == ':' */
1386 		mutex_lock_nested(&ns->parent->lock, ns->parent->level);
1387 		__aa_bump_ns_revision(ns);
1388 		__aa_remove_ns(ns);
1389 		mutex_unlock(&ns->parent->lock);
1390 	} else {
1391 		/* remove profile */
1392 		mutex_lock_nested(&ns->lock, ns->level);
1393 		profile = aa_get_profile(__lookup_profile(&ns->base, name));
1394 		if (!profile) {
1395 			error = -ENOENT;
1396 			info = "profile does not exist";
1397 			goto fail_ns_lock;
1398 		}
1399 		name = profile->base.hname;
1400 		__aa_bump_ns_revision(ns);
1401 		__remove_profile(profile);
1402 		__aa_labelset_update_subtree(ns);
1403 		mutex_unlock(&ns->lock);
1404 	}
1405 
1406 	/* don't fail removal if audit fails */
1407 	(void) audit_policy(subj, OP_PROF_RM, ns_name, name, info,
1408 			    error);
1409 	aa_put_ns(ns);
1410 	aa_put_profile(profile);
1411 	return size;
1412 
1413 fail_ns_lock:
1414 	mutex_unlock(&ns->lock);
1415 	aa_put_ns(ns);
1416 
1417 fail:
1418 	(void) audit_policy(subj, OP_PROF_RM, ns_name, name, info,
1419 			    error);
1420 	return error;
1421 }
1422