xref: /linux/security/apparmor/policy.c (revision 9afdc6abb007d5a86f54e9f10870ac1468155ca5)
1 // SPDX-License-Identifier: GPL-2.0-only
2 /*
3  * AppArmor security module
4  *
5  * This file contains AppArmor policy manipulation functions
6  *
7  * Copyright (C) 1998-2008 Novell/SUSE
8  * Copyright 2009-2010 Canonical Ltd.
9  *
10  * AppArmor policy is based around profiles, which contain the rules a
11  * task is confined by.  Every task in the system has a profile attached
12  * to it determined either by matching "unconfined" tasks against the
13  * visible set of profiles or by following a profiles attachment rules.
14  *
15  * Each profile exists in a profile namespace which is a container of
16  * visible profiles.  Each namespace contains a special "unconfined" profile,
17  * which doesn't enforce any confinement on a task beyond DAC.
18  *
19  * Namespace and profile names can be written together in either
20  * of two syntaxes.
21  *	:namespace:profile - used by kernel interfaces for easy detection
22  *	namespace://profile - used by policy
23  *
24  * Profile names can not start with : or @ or ^ and may not contain \0
25  *
26  * Reserved profile names
27  *	unconfined - special automatically generated unconfined profile
28  *	inherit - special name to indicate profile inheritance
29  *	null-XXXX-YYYY - special automatically generated learning profiles
30  *
31  * Namespace names may not start with / or @ and may not contain \0 or :
32  * Reserved namespace names
33  *	user-XXXX - user defined profiles
34  *
35  * a // in a profile or namespace name indicates a hierarchical name with the
36  * name before the // being the parent and the name after the child.
37  *
38  * Profile and namespace hierarchies serve two different but similar purposes.
39  * The namespace contains the set of visible profiles that are considered
40  * for attachment.  The hierarchy of namespaces allows for virtualizing
41  * the namespace so that for example a chroot can have its own set of profiles
42  * which may define some local user namespaces.
43  * The profile hierarchy severs two distinct purposes,
44  * -  it allows for sub profiles or hats, which allows an application to run
45  *    subprograms under its own profile with different restriction than it
46  *    self, and not have it use the system profile.
47  *    eg. if a mail program starts an editor, the policy might make the
48  *        restrictions tighter on the editor tighter than the mail program,
49  *        and definitely different than general editor restrictions
50  * - it allows for binary hierarchy of profiles, so that execution history
51  *   is preserved.  This feature isn't exploited by AppArmor reference policy
52  *   but is allowed.  NOTE: this is currently suboptimal because profile
53  *   aliasing is not currently implemented so that a profile for each
54  *   level must be defined.
55  *   eg. /bin/bash///bin/ls as a name would indicate /bin/ls was started
56  *       from /bin/bash
57  *
58  *   A profile or namespace name that can contain one or more // separators
59  *   is referred to as an hname (hierarchical).
60  *   eg.  /bin/bash//bin/ls
61  *
62  *   An fqname is a name that may contain both namespace and profile hnames.
63  *   eg. :ns:/bin/bash//bin/ls
64  *
65  * NOTES:
66  *   - locking of profile lists is currently fairly coarse.  All profile
67  *     lists within a namespace use the namespace lock.
68  * FIXME: move profile lists to using rcu_lists
69  */
70 
71 #include <linux/slab.h>
72 #include <linux/spinlock.h>
73 #include <linux/string.h>
74 #include <linux/cred.h>
75 #include <linux/rculist.h>
76 #include <linux/user_namespace.h>
77 
78 #include "include/apparmor.h"
79 #include "include/capability.h"
80 #include "include/cred.h"
81 #include "include/file.h"
82 #include "include/ipc.h"
83 #include "include/match.h"
84 #include "include/path.h"
85 #include "include/policy.h"
86 #include "include/policy_ns.h"
87 #include "include/policy_unpack.h"
88 #include "include/resource.h"
89 
90 int unprivileged_userns_apparmor_policy = 1;
91 int aa_unprivileged_unconfined_restricted;
92 
93 const char *const aa_profile_mode_names[] = {
94 	"enforce",
95 	"complain",
96 	"kill",
97 	"unconfined",
98 	"user",
99 };
100 
101 
102 static void aa_free_pdb(struct aa_policydb *pdb)
103 {
104 	if (pdb) {
105 		aa_put_dfa(pdb->dfa);
106 		kvfree(pdb->perms);
107 		aa_free_str_table(&pdb->trans);
108 		kfree(pdb);
109 	}
110 }
111 
112 /**
113  * aa_pdb_free_kref - free aa_policydb by kref (called by aa_put_pdb)
114  * @kref: kref callback for freeing of a dfa  (NOT NULL)
115  */
116 void aa_pdb_free_kref(struct kref *kref)
117 {
118 	struct aa_policydb *pdb = container_of(kref, struct aa_policydb, count);
119 
120 	aa_free_pdb(pdb);
121 }
122 
123 
124 struct aa_policydb *aa_alloc_pdb(gfp_t gfp)
125 {
126 	struct aa_policydb *pdb = kzalloc(sizeof(struct aa_policydb), gfp);
127 
128 	if (!pdb)
129 		return NULL;
130 
131 	kref_init(&pdb->count);
132 
133 	return pdb;
134 }
135 
136 
137 /**
138  * __add_profile - add a profiles to list and label tree
139  * @list: list to add it to  (NOT NULL)
140  * @profile: the profile to add  (NOT NULL)
141  *
142  * refcount @profile, should be put by __list_remove_profile
143  *
144  * Requires: namespace lock be held, or list not be shared
145  */
146 static void __add_profile(struct list_head *list, struct aa_profile *profile)
147 {
148 	struct aa_label *l;
149 
150 	AA_BUG(!list);
151 	AA_BUG(!profile);
152 	AA_BUG(!profile->ns);
153 	AA_BUG(!mutex_is_locked(&profile->ns->lock));
154 
155 	list_add_rcu(&profile->base.list, list);
156 	/* get list reference */
157 	aa_get_profile(profile);
158 	l = aa_label_insert(&profile->ns->labels, &profile->label);
159 	AA_BUG(l != &profile->label);
160 	aa_put_label(l);
161 }
162 
163 /**
164  * __list_remove_profile - remove a profile from the list it is on
165  * @profile: the profile to remove  (NOT NULL)
166  *
167  * remove a profile from the list, warning generally removal should
168  * be done with __replace_profile as most profile removals are
169  * replacements to the unconfined profile.
170  *
171  * put @profile list refcount
172  *
173  * Requires: namespace lock be held, or list not have been live
174  */
175 static void __list_remove_profile(struct aa_profile *profile)
176 {
177 	AA_BUG(!profile);
178 	AA_BUG(!profile->ns);
179 	AA_BUG(!mutex_is_locked(&profile->ns->lock));
180 
181 	list_del_rcu(&profile->base.list);
182 	aa_put_profile(profile);
183 }
184 
185 /**
186  * __remove_profile - remove old profile, and children
187  * @profile: profile to be replaced  (NOT NULL)
188  *
189  * Requires: namespace list lock be held, or list not be shared
190  */
191 static void __remove_profile(struct aa_profile *profile)
192 {
193 	AA_BUG(!profile);
194 	AA_BUG(!profile->ns);
195 	AA_BUG(!mutex_is_locked(&profile->ns->lock));
196 
197 	/* release any children lists first */
198 	__aa_profile_list_release(&profile->base.profiles);
199 	/* released by free_profile */
200 	aa_label_remove(&profile->label);
201 	__aafs_profile_rmdir(profile);
202 	__list_remove_profile(profile);
203 }
204 
205 /**
206  * __aa_profile_list_release - remove all profiles on the list and put refs
207  * @head: list of profiles  (NOT NULL)
208  *
209  * Requires: namespace lock be held
210  */
211 void __aa_profile_list_release(struct list_head *head)
212 {
213 	struct aa_profile *profile, *tmp;
214 	list_for_each_entry_safe(profile, tmp, head, base.list)
215 		__remove_profile(profile);
216 }
217 
218 /**
219  * aa_free_data - free a data blob
220  * @ptr: data to free
221  * @arg: unused
222  */
223 static void aa_free_data(void *ptr, void *arg)
224 {
225 	struct aa_data *data = ptr;
226 
227 	kvfree_sensitive(data->data, data->size);
228 	kfree_sensitive(data->key);
229 	kfree_sensitive(data);
230 }
231 
232 static void free_attachment(struct aa_attachment *attach)
233 {
234 	int i;
235 
236 	for (i = 0; i < attach->xattr_count; i++)
237 		kfree_sensitive(attach->xattrs[i]);
238 	kfree_sensitive(attach->xattrs);
239 	aa_put_pdb(attach->xmatch);
240 }
241 
242 static void free_ruleset(struct aa_ruleset *rules)
243 {
244 	int i;
245 
246 	aa_put_pdb(rules->file);
247 	aa_put_pdb(rules->policy);
248 	aa_free_cap_rules(&rules->caps);
249 	aa_free_rlimit_rules(&rules->rlimits);
250 
251 	for (i = 0; i < rules->secmark_count; i++)
252 		kfree_sensitive(rules->secmark[i].label);
253 	kfree_sensitive(rules->secmark);
254 	kfree_sensitive(rules);
255 }
256 
257 struct aa_ruleset *aa_alloc_ruleset(gfp_t gfp)
258 {
259 	struct aa_ruleset *rules;
260 
261 	rules = kzalloc(sizeof(*rules), gfp);
262 
263 	return rules;
264 }
265 
266 /**
267  * aa_free_profile - free a profile
268  * @profile: the profile to free  (MAYBE NULL)
269  *
270  * Free a profile, its hats and null_profile. All references to the profile,
271  * its hats and null_profile must have been put.
272  *
273  * If the profile was referenced from a task context, free_profile() will
274  * be called from an rcu callback routine, so we must not sleep here.
275  */
276 void aa_free_profile(struct aa_profile *profile)
277 {
278 	struct rhashtable *rht;
279 
280 	AA_DEBUG(DEBUG_POLICY, "%s(%p)\n", __func__, profile);
281 
282 	if (!profile)
283 		return;
284 
285 	/* free children profiles */
286 	aa_policy_destroy(&profile->base);
287 	aa_put_profile(rcu_access_pointer(profile->parent));
288 
289 	aa_put_ns(profile->ns);
290 	kfree_sensitive(profile->rename);
291 	kfree_sensitive(profile->disconnected);
292 
293 	free_attachment(&profile->attach);
294 
295 	/*
296 	 * at this point there are no tasks that can have a reference
297 	 * to rules
298 	 */
299 	for (int i = 0; i < profile->n_rules; i++)
300 		free_ruleset(profile->label.rules[i]);
301 
302 	kfree_sensitive(profile->dirname);
303 
304 	if (profile->data) {
305 		rht = profile->data;
306 		profile->data = NULL;
307 		rhashtable_free_and_destroy(rht, aa_free_data, NULL);
308 		kfree_sensitive(rht);
309 	}
310 
311 	kfree_sensitive(profile->hash);
312 	aa_put_loaddata(profile->rawdata);
313 	aa_label_destroy(&profile->label);
314 
315 	kfree_sensitive(profile);
316 }
317 
318 /**
319  * aa_alloc_profile - allocate, initialize and return a new profile
320  * @hname: name of the profile  (NOT NULL)
321  * @proxy: proxy to use OR null if to allocate a new one
322  * @gfp: allocation type
323  *
324  * Returns: refcount profile or NULL on failure
325  */
326 struct aa_profile *aa_alloc_profile(const char *hname, struct aa_proxy *proxy,
327 				    gfp_t gfp)
328 {
329 	struct aa_profile *profile;
330 
331 	/* freed by free_profile - usually through aa_put_profile
332 	 * this adds space for a single ruleset in the rules section of the
333 	 * label
334 	 */
335 	profile = kzalloc(struct_size(profile, label.rules, 1), gfp);
336 	if (!profile)
337 		return NULL;
338 	profile->n_rules = 1;
339 
340 	if (!aa_policy_init(&profile->base, NULL, hname, gfp))
341 		goto fail;
342 	if (!aa_label_init(&profile->label, 1, gfp))
343 		goto fail;
344 
345 	/* allocate the first ruleset, but leave it empty */
346 	profile->label.rules[0] = aa_alloc_ruleset(gfp);
347 	if (!profile->label.rules[0])
348 		goto fail;
349 
350 	/* update being set needed by fs interface */
351 	if (!proxy) {
352 		proxy = aa_alloc_proxy(&profile->label, gfp);
353 		if (!proxy)
354 			goto fail;
355 	} else
356 		aa_get_proxy(proxy);
357 	profile->label.proxy = proxy;
358 
359 	profile->label.hname = profile->base.hname;
360 	profile->label.flags |= FLAG_PROFILE;
361 	profile->label.vec[0] = profile;
362 
363 	profile->signal = SIGKILL;
364 	/* refcount released by caller */
365 	return profile;
366 
367 fail:
368 	aa_free_profile(profile);
369 
370 	return NULL;
371 }
372 
373 static inline bool ANY_RULE_MEDIATES(struct aa_profile *profile,
374 				     unsigned char class)
375 {
376 	int i;
377 
378 	for (i = 0; i < profile->n_rules; i++) {
379 		if (RULE_MEDIATES(profile->label.rules[i], class))
380 			return true;
381 	}
382 	return false;
383 }
384 
385 /* set of rules that are mediated by unconfined */
386 static int unconfined_mediates[] = { AA_CLASS_NS, AA_CLASS_IO_URING, 0 };
387 
388 /* must be called after profile rulesets and start information is setup */
389 void aa_compute_profile_mediates(struct aa_profile *profile)
390 {
391 	int c;
392 
393 	if (profile_unconfined(profile)) {
394 		int *pos;
395 
396 		for (pos = unconfined_mediates; *pos; pos++) {
397 			if (ANY_RULE_MEDIATES(profile, *pos))
398 				profile->label.mediates |= ((u64) 1) << AA_CLASS_NS;
399 		}
400 		return;
401 	}
402 	for (c = 0; c <= AA_CLASS_LAST; c++) {
403 		if (ANY_RULE_MEDIATES(profile, c))
404 			profile->label.mediates |= ((u64) 1) << c;
405 	}
406 }
407 
408 /* TODO: profile accounting - setup in remove */
409 
410 /**
411  * __strn_find_child - find a profile on @head list using substring of @name
412  * @head: list to search  (NOT NULL)
413  * @name: name of profile (NOT NULL)
414  * @len: length of @name substring to match
415  *
416  * Requires: rcu_read_lock be held
417  *
418  * Returns: unrefcounted profile ptr, or NULL if not found
419  */
420 static struct aa_profile *__strn_find_child(struct list_head *head,
421 					    const char *name, int len)
422 {
423 	return (struct aa_profile *)__policy_strn_find(head, name, len);
424 }
425 
426 /**
427  * __find_child - find a profile on @head list with a name matching @name
428  * @head: list to search  (NOT NULL)
429  * @name: name of profile (NOT NULL)
430  *
431  * Requires: rcu_read_lock be held
432  *
433  * Returns: unrefcounted profile ptr, or NULL if not found
434  */
435 static struct aa_profile *__find_child(struct list_head *head, const char *name)
436 {
437 	return __strn_find_child(head, name, strlen(name));
438 }
439 
440 /**
441  * aa_find_child - find a profile by @name in @parent
442  * @parent: profile to search  (NOT NULL)
443  * @name: profile name to search for  (NOT NULL)
444  *
445  * Returns: a refcounted profile or NULL if not found
446  */
447 struct aa_profile *aa_find_child(struct aa_profile *parent, const char *name)
448 {
449 	struct aa_profile *profile;
450 
451 	rcu_read_lock();
452 	do {
453 		profile = __find_child(&parent->base.profiles, name);
454 	} while (profile && !aa_get_profile_not0(profile));
455 	rcu_read_unlock();
456 
457 	/* refcount released by caller */
458 	return profile;
459 }
460 
461 /**
462  * __lookup_parent - lookup the parent of a profile of name @hname
463  * @ns: namespace to lookup profile in  (NOT NULL)
464  * @hname: hierarchical profile name to find parent of  (NOT NULL)
465  *
466  * Lookups up the parent of a fully qualified profile name, the profile
467  * that matches hname does not need to exist, in general this
468  * is used to load a new profile.
469  *
470  * Requires: rcu_read_lock be held
471  *
472  * Returns: unrefcounted policy or NULL if not found
473  */
474 static struct aa_policy *__lookup_parent(struct aa_ns *ns,
475 					 const char *hname)
476 {
477 	struct aa_policy *policy;
478 	struct aa_profile *profile = NULL;
479 	char *split;
480 
481 	policy = &ns->base;
482 
483 	for (split = strstr(hname, "//"); split;) {
484 		profile = __strn_find_child(&policy->profiles, hname,
485 					    split - hname);
486 		if (!profile)
487 			return NULL;
488 		policy = &profile->base;
489 		hname = split + 2;
490 		split = strstr(hname, "//");
491 	}
492 	if (!profile)
493 		return &ns->base;
494 	return &profile->base;
495 }
496 
497 /**
498  * __create_missing_ancestors - create place holders for missing ancestors
499  * @ns: namespace to lookup profile in (NOT NULL)
500  * @hname: hierarchical profile name to find parent of (NOT NULL)
501  * @gfp: type of allocation.
502  *
503  * Requires: ns mutex lock held
504  *
505  * Return: unrefcounted parent policy on success or %NULL if error creating
506  *          place holder profiles.
507  */
508 static struct aa_policy *__create_missing_ancestors(struct aa_ns *ns,
509 						    const char *hname,
510 						    gfp_t gfp)
511 {
512 	struct aa_policy *policy;
513 	struct aa_profile *parent, *profile = NULL;
514 	char *split;
515 
516 	AA_BUG(!ns);
517 	AA_BUG(!hname);
518 
519 	policy = &ns->base;
520 
521 	for (split = strstr(hname, "//"); split;) {
522 		parent = profile;
523 		profile = __strn_find_child(&policy->profiles, hname,
524 					    split - hname);
525 		if (!profile) {
526 			const char *name = kstrndup(hname, split - hname,
527 						    gfp);
528 			if (!name)
529 				return NULL;
530 			profile = aa_alloc_null(parent, name, gfp);
531 			kfree(name);
532 			if (!profile)
533 				return NULL;
534 			if (!parent)
535 				profile->ns = aa_get_ns(ns);
536 		}
537 		policy = &profile->base;
538 		hname = split + 2;
539 		split = strstr(hname, "//");
540 	}
541 	if (!profile)
542 		return &ns->base;
543 	return &profile->base;
544 }
545 
546 /**
547  * __lookupn_profile - lookup the profile matching @hname
548  * @base: base list to start looking up profile name from  (NOT NULL)
549  * @hname: hierarchical profile name  (NOT NULL)
550  * @n: length of @hname
551  *
552  * Requires: rcu_read_lock be held
553  *
554  * Returns: unrefcounted profile pointer or NULL if not found
555  *
556  * Do a relative name lookup, recursing through profile tree.
557  */
558 static struct aa_profile *__lookupn_profile(struct aa_policy *base,
559 					    const char *hname, size_t n)
560 {
561 	struct aa_profile *profile = NULL;
562 	const char *split;
563 
564 	for (split = strnstr(hname, "//", n); split;
565 	     split = strnstr(hname, "//", n)) {
566 		profile = __strn_find_child(&base->profiles, hname,
567 					    split - hname);
568 		if (!profile)
569 			return NULL;
570 
571 		base = &profile->base;
572 		n -= split + 2 - hname;
573 		hname = split + 2;
574 	}
575 
576 	if (n)
577 		return __strn_find_child(&base->profiles, hname, n);
578 	return NULL;
579 }
580 
581 static struct aa_profile *__lookup_profile(struct aa_policy *base,
582 					   const char *hname)
583 {
584 	return __lookupn_profile(base, hname, strlen(hname));
585 }
586 
587 /**
588  * aa_lookupn_profile - find a profile by its full or partial name
589  * @ns: the namespace to start from (NOT NULL)
590  * @hname: name to do lookup on.  Does not contain namespace prefix (NOT NULL)
591  * @n: size of @hname
592  *
593  * Returns: refcounted profile or NULL if not found
594  */
595 struct aa_profile *aa_lookupn_profile(struct aa_ns *ns, const char *hname,
596 				      size_t n)
597 {
598 	struct aa_profile *profile;
599 
600 	rcu_read_lock();
601 	do {
602 		profile = __lookupn_profile(&ns->base, hname, n);
603 	} while (profile && !aa_get_profile_not0(profile));
604 	rcu_read_unlock();
605 
606 	/* the unconfined profile is not in the regular profile list */
607 	if (!profile && strncmp(hname, "unconfined", n) == 0)
608 		profile = aa_get_newest_profile(ns->unconfined);
609 
610 	/* refcount released by caller */
611 	return profile;
612 }
613 
614 struct aa_profile *aa_fqlookupn_profile(struct aa_label *base,
615 					const char *fqname, size_t n)
616 {
617 	struct aa_profile *profile;
618 	struct aa_ns *ns;
619 	const char *name, *ns_name;
620 	size_t ns_len;
621 
622 	name = aa_splitn_fqname(fqname, n, &ns_name, &ns_len);
623 	if (ns_name) {
624 		ns = aa_lookupn_ns(labels_ns(base), ns_name, ns_len);
625 		if (!ns)
626 			return NULL;
627 	} else
628 		ns = aa_get_ns(labels_ns(base));
629 
630 	if (name)
631 		profile = aa_lookupn_profile(ns, name, n - (name - fqname));
632 	else if (ns)
633 		/* default profile for ns, currently unconfined */
634 		profile = aa_get_newest_profile(ns->unconfined);
635 	else
636 		profile = NULL;
637 	aa_put_ns(ns);
638 
639 	return profile;
640 }
641 
642 
643 struct aa_profile *aa_alloc_null(struct aa_profile *parent, const char *name,
644 				 gfp_t gfp)
645 {
646 	struct aa_profile *profile;
647 	struct aa_ruleset *rules;
648 
649 	profile = aa_alloc_profile(name, NULL, gfp);
650 	if (!profile)
651 		return NULL;
652 
653 	/* TODO: ideally we should inherit abi from parent */
654 	profile->label.flags |= FLAG_NULL;
655 	profile->attach.xmatch = aa_get_pdb(nullpdb);
656 	rules = profile->label.rules[0];
657 	rules->file = aa_get_pdb(nullpdb);
658 	rules->policy = aa_get_pdb(nullpdb);
659 	aa_compute_profile_mediates(profile);
660 
661 	if (parent) {
662 		profile->path_flags = parent->path_flags;
663 		/* override/inherit what is mediated from parent */
664 		profile->label.mediates = parent->label.mediates;
665 		/* released on free_profile */
666 		rcu_assign_pointer(profile->parent, aa_get_profile(parent));
667 		profile->ns = aa_get_ns(parent->ns);
668 	}
669 
670 	return profile;
671 }
672 
673 /**
674  * aa_new_learning_profile - create or find a null-X learning profile
675  * @parent: profile that caused this profile to be created (NOT NULL)
676  * @hat: true if the null- learning profile is a hat
677  * @base: name to base the null profile off of
678  * @gfp: type of allocation
679  *
680  * Find/Create a null- complain mode profile used in learning mode.  The
681  * name of the profile is unique and follows the format of parent//null-XXX.
682  * where XXX is based on the @name or if that fails or is not supplied
683  * a unique number
684  *
685  * null profiles are added to the profile list but the list does not
686  * hold a count on them so that they are automatically released when
687  * not in use.
688  *
689  * Returns: new refcounted profile else NULL on failure
690  */
691 struct aa_profile *aa_new_learning_profile(struct aa_profile *parent, bool hat,
692 					   const char *base, gfp_t gfp)
693 {
694 	struct aa_profile *p, *profile;
695 	const char *bname;
696 	char *name = NULL;
697 
698 	AA_BUG(!parent);
699 
700 	if (base) {
701 		name = kmalloc(strlen(parent->base.hname) + 8 + strlen(base),
702 			       gfp);
703 		if (name) {
704 			sprintf(name, "%s//null-%s", parent->base.hname, base);
705 			goto name;
706 		}
707 		/* fall through to try shorter uniq */
708 	}
709 
710 	name = kmalloc(strlen(parent->base.hname) + 2 + 7 + 8, gfp);
711 	if (!name)
712 		return NULL;
713 	sprintf(name, "%s//null-%x", parent->base.hname,
714 		atomic_inc_return(&parent->ns->uniq_null));
715 
716 name:
717 	/* lookup to see if this is a dup creation */
718 	bname = basename(name);
719 	profile = aa_find_child(parent, bname);
720 	if (profile)
721 		goto out;
722 
723 	profile = aa_alloc_null(parent, name, gfp);
724 	if (!profile)
725 		goto fail;
726 	profile->mode = APPARMOR_COMPLAIN;
727 	if (hat)
728 		profile->label.flags |= FLAG_HAT;
729 
730 	mutex_lock_nested(&profile->ns->lock, profile->ns->level);
731 	p = __find_child(&parent->base.profiles, bname);
732 	if (p) {
733 		aa_free_profile(profile);
734 		profile = aa_get_profile(p);
735 	} else {
736 		__add_profile(&parent->base.profiles, profile);
737 	}
738 	mutex_unlock(&profile->ns->lock);
739 
740 	/* refcount released by caller */
741 out:
742 	kfree(name);
743 
744 	return profile;
745 
746 fail:
747 	kfree(name);
748 	aa_free_profile(profile);
749 	return NULL;
750 }
751 
752 /**
753  * replacement_allowed - test to see if replacement is allowed
754  * @profile: profile to test if it can be replaced  (MAYBE NULL)
755  * @noreplace: true if replacement shouldn't be allowed but addition is okay
756  * @info: Returns - info about why replacement failed (NOT NULL)
757  *
758  * Returns: %0 if replacement allowed else error code
759  */
760 static int replacement_allowed(struct aa_profile *profile, int noreplace,
761 			       const char **info)
762 {
763 	if (profile) {
764 		if (profile->label.flags & FLAG_IMMUTIBLE) {
765 			*info = "cannot replace immutable profile";
766 			return -EPERM;
767 		} else if (noreplace) {
768 			*info = "profile already exists";
769 			return -EEXIST;
770 		}
771 	}
772 	return 0;
773 }
774 
775 /* audit callback for net specific fields */
776 static void audit_cb(struct audit_buffer *ab, void *va)
777 {
778 	struct common_audit_data *sa = va;
779 	struct apparmor_audit_data *ad = aad(sa);
780 
781 	if (ad->iface.ns) {
782 		audit_log_format(ab, " ns=");
783 		audit_log_untrustedstring(ab, ad->iface.ns);
784 	}
785 }
786 
787 /**
788  * audit_policy - Do auditing of policy changes
789  * @subj_label: label to check if it can manage policy
790  * @op: policy operation being performed
791  * @ns_name: name of namespace being manipulated
792  * @name: name of profile being manipulated (NOT NULL)
793  * @info: any extra information to be audited (MAYBE NULL)
794  * @error: error code
795  *
796  * Returns: the error to be returned after audit is done
797  */
798 static int audit_policy(struct aa_label *subj_label, const char *op,
799 			const char *ns_name, const char *name,
800 			const char *info, int error)
801 {
802 	DEFINE_AUDIT_DATA(ad, LSM_AUDIT_DATA_NONE, AA_CLASS_NONE, op);
803 
804 	ad.iface.ns = ns_name;
805 	ad.name = name;
806 	ad.info = info;
807 	ad.error = error;
808 	ad.subj_label = subj_label;
809 
810 	aa_audit_msg(AUDIT_APPARMOR_STATUS, &ad, audit_cb);
811 
812 	return error;
813 }
814 
815 /* don't call out to other LSMs in the stack for apparmor policy admin
816  * permissions
817  */
818 static int policy_ns_capable(const struct cred *subj_cred,
819 			     struct aa_label *label,
820 			     struct user_namespace *userns, int cap)
821 {
822 	int err;
823 
824 	/* check for MAC_ADMIN cap in cred */
825 	err = cap_capable(subj_cred, userns, cap, CAP_OPT_NONE);
826 	if (!err)
827 		err = aa_capable(subj_cred, label, cap, CAP_OPT_NONE);
828 
829 	return err;
830 }
831 
832 /**
833  * aa_policy_view_capable - check if viewing policy in at @ns is allowed
834  * @subj_cred: cred of subject
835  * @label: label that is trying to view policy in ns
836  * @ns: namespace being viewed by @label (may be NULL if @label's ns)
837  *
838  * Returns: true if viewing policy is allowed
839  *
840  * If @ns is NULL then the namespace being viewed is assumed to be the
841  * tasks current namespace.
842  */
843 bool aa_policy_view_capable(const struct cred *subj_cred,
844 			     struct aa_label *label, struct aa_ns *ns)
845 {
846 	struct user_namespace *user_ns = subj_cred->user_ns;
847 	struct aa_ns *view_ns = labels_view(label);
848 	bool root_in_user_ns = uid_eq(current_euid(), make_kuid(user_ns, 0)) ||
849 			       in_egroup_p(make_kgid(user_ns, 0));
850 	bool response = false;
851 	if (!ns)
852 		ns = view_ns;
853 
854 	if (root_in_user_ns && aa_ns_visible(view_ns, ns, true) &&
855 	    (user_ns == &init_user_ns ||
856 	     (unprivileged_userns_apparmor_policy != 0 &&
857 	      user_ns->level == view_ns->level)))
858 		response = true;
859 
860 	return response;
861 }
862 
863 bool aa_policy_admin_capable(const struct cred *subj_cred,
864 			     struct aa_label *label, struct aa_ns *ns)
865 {
866 	struct user_namespace *user_ns = subj_cred->user_ns;
867 	bool capable = policy_ns_capable(subj_cred, label, user_ns,
868 					 CAP_MAC_ADMIN) == 0;
869 
870 	AA_DEBUG(DEBUG_POLICY, "cap_mac_admin? %d\n", capable);
871 	AA_DEBUG(DEBUG_POLICY, "policy locked? %d\n", aa_g_lock_policy);
872 
873 	return aa_policy_view_capable(subj_cred, label, ns) && capable &&
874 		!aa_g_lock_policy;
875 }
876 
877 bool aa_current_policy_view_capable(struct aa_ns *ns)
878 {
879 	struct aa_label *label;
880 	bool needput, res;
881 
882 	label = __begin_current_label_crit_section(&needput);
883 	res = aa_policy_view_capable(current_cred(), label, ns);
884 	__end_current_label_crit_section(label, needput);
885 
886 	return res;
887 }
888 
889 bool aa_current_policy_admin_capable(struct aa_ns *ns)
890 {
891 	struct aa_label *label;
892 	bool needput, res;
893 
894 	label = __begin_current_label_crit_section(&needput);
895 	res = aa_policy_admin_capable(current_cred(), label, ns);
896 	__end_current_label_crit_section(label, needput);
897 
898 	return res;
899 }
900 
901 /**
902  * aa_may_manage_policy - can the current task manage policy
903  * @subj_cred: subjects cred
904  * @label: label to check if it can manage policy
905  * @ns: namespace being managed by @label (may be NULL if @label's ns)
906  * @mask: contains the policy manipulation operation being done
907  *
908  * Returns: 0 if the task is allowed to manipulate policy else error
909  */
910 int aa_may_manage_policy(const struct cred *subj_cred, struct aa_label *label,
911 			 struct aa_ns *ns, u32 mask)
912 {
913 	const char *op;
914 
915 	if (mask & AA_MAY_REMOVE_POLICY)
916 		op = OP_PROF_RM;
917 	else if (mask & AA_MAY_REPLACE_POLICY)
918 		op = OP_PROF_REPL;
919 	else
920 		op = OP_PROF_LOAD;
921 
922 	/* check if loading policy is locked out */
923 	if (aa_g_lock_policy)
924 		return audit_policy(label, op, NULL, NULL, "policy_locked",
925 				    -EACCES);
926 
927 	if (!aa_policy_admin_capable(subj_cred, label, ns))
928 		return audit_policy(label, op, NULL, NULL, "not policy admin",
929 				    -EACCES);
930 
931 	/* TODO: add fine grained mediation of policy loads */
932 	return 0;
933 }
934 
935 static struct aa_profile *__list_lookup_parent(struct list_head *lh,
936 					       struct aa_profile *profile)
937 {
938 	const char *base = basename(profile->base.hname);
939 	long len = base - profile->base.hname;
940 	struct aa_load_ent *ent;
941 
942 	/* parent won't have trailing // so remove from len */
943 	if (len <= 2)
944 		return NULL;
945 	len -= 2;
946 
947 	list_for_each_entry(ent, lh, list) {
948 		if (ent->new == profile)
949 			continue;
950 		if (strncmp(ent->new->base.hname, profile->base.hname, len) ==
951 		    0 && ent->new->base.hname[len] == 0)
952 			return ent->new;
953 	}
954 
955 	return NULL;
956 }
957 
958 /**
959  * __replace_profile - replace @old with @new on a list
960  * @old: profile to be replaced  (NOT NULL)
961  * @new: profile to replace @old with  (NOT NULL)
962  *
963  * Will duplicate and refcount elements that @new inherits from @old
964  * and will inherit @old children.
965  *
966  * refcount @new for list, put @old list refcount
967  *
968  * Requires: namespace list lock be held, or list not be shared
969  */
970 static void __replace_profile(struct aa_profile *old, struct aa_profile *new)
971 {
972 	struct aa_profile *child, *tmp;
973 
974 	if (!list_empty(&old->base.profiles)) {
975 		LIST_HEAD(lh);
976 		list_splice_init_rcu(&old->base.profiles, &lh, synchronize_rcu);
977 
978 		list_for_each_entry_safe(child, tmp, &lh, base.list) {
979 			struct aa_profile *p;
980 
981 			list_del_init(&child->base.list);
982 			p = __find_child(&new->base.profiles, child->base.name);
983 			if (p) {
984 				/* @p replaces @child  */
985 				__replace_profile(child, p);
986 				continue;
987 			}
988 
989 			/* inherit @child and its children */
990 			/* TODO: update hname of inherited children */
991 			/* list refcount transferred to @new */
992 			p = aa_deref_parent(child);
993 			rcu_assign_pointer(child->parent, aa_get_profile(new));
994 			list_add_rcu(&child->base.list, &new->base.profiles);
995 			aa_put_profile(p);
996 		}
997 	}
998 
999 	if (!rcu_access_pointer(new->parent)) {
1000 		struct aa_profile *parent = aa_deref_parent(old);
1001 		rcu_assign_pointer(new->parent, aa_get_profile(parent));
1002 	}
1003 	aa_label_replace(&old->label, &new->label);
1004 	/* migrate dents must come after label replacement b/c update */
1005 	__aafs_profile_migrate_dents(old, new);
1006 
1007 	if (list_empty(&new->base.list)) {
1008 		/* new is not on a list already */
1009 		list_replace_rcu(&old->base.list, &new->base.list);
1010 		aa_get_profile(new);
1011 		aa_put_profile(old);
1012 	} else
1013 		__list_remove_profile(old);
1014 }
1015 
1016 /**
1017  * __lookup_replace - lookup replacement information for a profile
1018  * @ns: namespace the lookup occurs in
1019  * @hname: name of profile to lookup
1020  * @noreplace: true if not replacing an existing profile
1021  * @p: Returns - profile to be replaced
1022  * @info: Returns - info string on why lookup failed
1023  *
1024  * Returns: profile to replace (no ref) on success else ptr error
1025  */
1026 static int __lookup_replace(struct aa_ns *ns, const char *hname,
1027 			    bool noreplace, struct aa_profile **p,
1028 			    const char **info)
1029 {
1030 	*p = aa_get_profile(__lookup_profile(&ns->base, hname));
1031 	if (*p) {
1032 		int error = replacement_allowed(*p, noreplace, info);
1033 		if (error) {
1034 			*info = "profile can not be replaced";
1035 			return error;
1036 		}
1037 	}
1038 
1039 	return 0;
1040 }
1041 
1042 static void share_name(struct aa_profile *old, struct aa_profile *new)
1043 {
1044 	aa_put_str(new->base.hname);
1045 	aa_get_str(old->base.hname);
1046 	new->base.hname = old->base.hname;
1047 	new->base.name = old->base.name;
1048 	new->label.hname = old->label.hname;
1049 }
1050 
1051 /* Update to newest version of parent after previous replacements
1052  * Returns: unrefcount newest version of parent
1053  */
1054 static struct aa_profile *update_to_newest_parent(struct aa_profile *new)
1055 {
1056 	struct aa_profile *parent, *newest;
1057 
1058 	parent = rcu_dereference_protected(new->parent,
1059 					   mutex_is_locked(&new->ns->lock));
1060 	newest = aa_get_newest_profile(parent);
1061 
1062 	/* parent replaced in this atomic set? */
1063 	if (newest != parent) {
1064 		aa_put_profile(parent);
1065 		rcu_assign_pointer(new->parent, newest);
1066 	} else
1067 		aa_put_profile(newest);
1068 
1069 	return newest;
1070 }
1071 
1072 /**
1073  * aa_replace_profiles - replace profile(s) on the profile list
1074  * @policy_ns: namespace load is occurring on
1075  * @label: label that is attempting to load/replace policy
1076  * @mask: permission mask
1077  * @udata: serialized data stream  (NOT NULL)
1078  *
1079  * unpack and replace a profile on the profile list and uses of that profile
1080  * by any task creds via invalidating the old version of the profile, which
1081  * tasks will notice to update their own cred.  If the profile does not exist
1082  * on the profile list it is added.
1083  *
1084  * Returns: size of data consumed else error code on failure.
1085  */
1086 ssize_t aa_replace_profiles(struct aa_ns *policy_ns, struct aa_label *label,
1087 			    u32 mask, struct aa_loaddata *udata)
1088 {
1089 	const char *ns_name = NULL, *info = NULL;
1090 	struct aa_ns *ns = NULL;
1091 	struct aa_load_ent *ent, *tmp;
1092 	struct aa_loaddata *rawdata_ent;
1093 	const char *op;
1094 	ssize_t count, error;
1095 	LIST_HEAD(lh);
1096 
1097 	op = mask & AA_MAY_REPLACE_POLICY ? OP_PROF_REPL : OP_PROF_LOAD;
1098 	aa_get_loaddata(udata);
1099 	/* released below */
1100 	error = aa_unpack(udata, &lh, &ns_name);
1101 	if (error)
1102 		goto out;
1103 
1104 	/* ensure that profiles are all for the same ns
1105 	 * TODO: update locking to remove this constraint. All profiles in
1106 	 *       the load set must succeed as a set or the load will
1107 	 *       fail. Sort ent list and take ns locks in hierarchy order
1108 	 */
1109 	count = 0;
1110 	list_for_each_entry(ent, &lh, list) {
1111 		if (ns_name) {
1112 			if (ent->ns_name &&
1113 			    strcmp(ent->ns_name, ns_name) != 0) {
1114 				info = "policy load has mixed namespaces";
1115 				error = -EACCES;
1116 				goto fail;
1117 			}
1118 		} else if (ent->ns_name) {
1119 			if (count) {
1120 				info = "policy load has mixed namespaces";
1121 				error = -EACCES;
1122 				goto fail;
1123 			}
1124 			ns_name = ent->ns_name;
1125 		} else
1126 			count++;
1127 	}
1128 	if (ns_name) {
1129 		ns = aa_prepare_ns(policy_ns ? policy_ns : labels_ns(label),
1130 				   ns_name);
1131 		if (IS_ERR(ns)) {
1132 			op = OP_PROF_LOAD;
1133 			info = "failed to prepare namespace";
1134 			error = PTR_ERR(ns);
1135 			ns = NULL;
1136 			ent = NULL;
1137 			goto fail;
1138 		}
1139 	} else
1140 		ns = aa_get_ns(policy_ns ? policy_ns : labels_ns(label));
1141 
1142 	mutex_lock_nested(&ns->lock, ns->level);
1143 	/* check for duplicate rawdata blobs: space and file dedup */
1144 	if (!list_empty(&ns->rawdata_list)) {
1145 		list_for_each_entry(rawdata_ent, &ns->rawdata_list, list) {
1146 			if (aa_rawdata_eq(rawdata_ent, udata)) {
1147 				struct aa_loaddata *tmp;
1148 
1149 				tmp = __aa_get_loaddata(rawdata_ent);
1150 				/* check we didn't fail the race */
1151 				if (tmp) {
1152 					aa_put_loaddata(udata);
1153 					udata = tmp;
1154 					break;
1155 				}
1156 			}
1157 		}
1158 	}
1159 	/* setup parent and ns info */
1160 	list_for_each_entry(ent, &lh, list) {
1161 		struct aa_policy *policy;
1162 		struct aa_profile *p;
1163 
1164 		if (aa_g_export_binary)
1165 			ent->new->rawdata = aa_get_loaddata(udata);
1166 		error = __lookup_replace(ns, ent->new->base.hname,
1167 					 !(mask & AA_MAY_REPLACE_POLICY),
1168 					 &ent->old, &info);
1169 		if (error)
1170 			goto fail_lock;
1171 
1172 		if (ent->new->rename) {
1173 			error = __lookup_replace(ns, ent->new->rename,
1174 						!(mask & AA_MAY_REPLACE_POLICY),
1175 						&ent->rename, &info);
1176 			if (error)
1177 				goto fail_lock;
1178 		}
1179 
1180 		/* released when @new is freed */
1181 		ent->new->ns = aa_get_ns(ns);
1182 
1183 		if (ent->old || ent->rename)
1184 			continue;
1185 
1186 		/* no ref on policy only use inside lock */
1187 		p = NULL;
1188 		policy = __lookup_parent(ns, ent->new->base.hname);
1189 		if (!policy) {
1190 			/* first check for parent in the load set */
1191 			p = __list_lookup_parent(&lh, ent->new);
1192 			if (!p) {
1193 				/*
1194 				 * fill in missing parent with null
1195 				 * profile that doesn't have
1196 				 * permissions. This allows for
1197 				 * individual profile loading where
1198 				 * the child is loaded before the
1199 				 * parent, and outside of the current
1200 				 * atomic set. This unfortunately can
1201 				 * happen with some userspaces.  The
1202 				 * null profile will be replaced once
1203 				 * the parent is loaded.
1204 				 */
1205 				policy = __create_missing_ancestors(ns,
1206 							ent->new->base.hname,
1207 							GFP_KERNEL);
1208 				if (!policy) {
1209 					error = -ENOENT;
1210 					info = "parent does not exist";
1211 					goto fail_lock;
1212 				}
1213 			}
1214 		}
1215 		if (!p && policy != &ns->base)
1216 			/* released on profile replacement or free_profile */
1217 			p = (struct aa_profile *) policy;
1218 		rcu_assign_pointer(ent->new->parent, aa_get_profile(p));
1219 	}
1220 
1221 	/* create new fs entries for introspection if needed */
1222 	if (!udata->dents[AAFS_LOADDATA_DIR] && aa_g_export_binary) {
1223 		error = __aa_fs_create_rawdata(ns, udata);
1224 		if (error) {
1225 			info = "failed to create raw_data dir and files";
1226 			ent = NULL;
1227 			goto fail_lock;
1228 		}
1229 	}
1230 	list_for_each_entry(ent, &lh, list) {
1231 		if (!ent->old) {
1232 			struct dentry *parent;
1233 			if (rcu_access_pointer(ent->new->parent)) {
1234 				struct aa_profile *p;
1235 				p = aa_deref_parent(ent->new);
1236 				parent = prof_child_dir(p);
1237 			} else
1238 				parent = ns_subprofs_dir(ent->new->ns);
1239 			error = __aafs_profile_mkdir(ent->new, parent);
1240 		}
1241 
1242 		if (error) {
1243 			info = "failed to create";
1244 			goto fail_lock;
1245 		}
1246 	}
1247 
1248 	/* Done with checks that may fail - do actual replacement */
1249 	__aa_bump_ns_revision(ns);
1250 	if (aa_g_export_binary)
1251 		__aa_loaddata_update(udata, ns->revision);
1252 	list_for_each_entry_safe(ent, tmp, &lh, list) {
1253 		list_del_init(&ent->list);
1254 		op = (!ent->old && !ent->rename) ? OP_PROF_LOAD : OP_PROF_REPL;
1255 
1256 		if (ent->old && ent->old->rawdata == ent->new->rawdata &&
1257 		    ent->new->rawdata) {
1258 			/* dedup actual profile replacement */
1259 			audit_policy(label, op, ns_name, ent->new->base.hname,
1260 				     "same as current profile, skipping",
1261 				     error);
1262 			/* break refcount cycle with proxy. */
1263 			aa_put_proxy(ent->new->label.proxy);
1264 			ent->new->label.proxy = NULL;
1265 			goto skip;
1266 		}
1267 
1268 		/*
1269 		 * TODO: finer dedup based on profile range in data. Load set
1270 		 * can differ but profile may remain unchanged
1271 		 */
1272 		audit_policy(label, op, ns_name, ent->new->base.hname, NULL,
1273 			     error);
1274 
1275 		if (ent->old) {
1276 			share_name(ent->old, ent->new);
1277 			__replace_profile(ent->old, ent->new);
1278 		} else {
1279 			struct list_head *lh;
1280 
1281 			if (rcu_access_pointer(ent->new->parent)) {
1282 				struct aa_profile *parent;
1283 
1284 				parent = update_to_newest_parent(ent->new);
1285 				lh = &parent->base.profiles;
1286 			} else
1287 				lh = &ns->base.profiles;
1288 			__add_profile(lh, ent->new);
1289 		}
1290 	skip:
1291 		aa_load_ent_free(ent);
1292 	}
1293 	__aa_labelset_update_subtree(ns);
1294 	mutex_unlock(&ns->lock);
1295 
1296 out:
1297 	aa_put_ns(ns);
1298 	aa_put_loaddata(udata);
1299 	kfree(ns_name);
1300 
1301 	if (error)
1302 		return error;
1303 	return udata->size;
1304 
1305 fail_lock:
1306 	mutex_unlock(&ns->lock);
1307 
1308 	/* audit cause of failure */
1309 	op = (ent && !ent->old) ? OP_PROF_LOAD : OP_PROF_REPL;
1310 fail:
1311 	  audit_policy(label, op, ns_name, ent ? ent->new->base.hname : NULL,
1312 		       info, error);
1313 	/* audit status that rest of profiles in the atomic set failed too */
1314 	info = "valid profile in failed atomic policy load";
1315 	list_for_each_entry(tmp, &lh, list) {
1316 		if (tmp == ent) {
1317 			info = "unchecked profile in failed atomic policy load";
1318 			/* skip entry that caused failure */
1319 			continue;
1320 		}
1321 		op = (!tmp->old) ? OP_PROF_LOAD : OP_PROF_REPL;
1322 		audit_policy(label, op, ns_name, tmp->new->base.hname, info,
1323 			     error);
1324 	}
1325 	list_for_each_entry_safe(ent, tmp, &lh, list) {
1326 		list_del_init(&ent->list);
1327 		aa_load_ent_free(ent);
1328 	}
1329 
1330 	goto out;
1331 }
1332 
1333 /**
1334  * aa_remove_profiles - remove profile(s) from the system
1335  * @policy_ns: namespace the remove is being done from
1336  * @subj: label attempting to remove policy
1337  * @fqname: name of the profile or namespace to remove  (NOT NULL)
1338  * @size: size of the name
1339  *
1340  * Remove a profile or sub namespace from the current namespace, so that
1341  * they can not be found anymore and mark them as replaced by unconfined
1342  *
1343  * NOTE: removing confinement does not restore rlimits to preconfinement values
1344  *
1345  * Returns: size of data consume else error code if fails
1346  */
1347 ssize_t aa_remove_profiles(struct aa_ns *policy_ns, struct aa_label *subj,
1348 			   char *fqname, size_t size)
1349 {
1350 	struct aa_ns *ns = NULL;
1351 	struct aa_profile *profile = NULL;
1352 	const char *name = fqname, *info = NULL;
1353 	const char *ns_name = NULL;
1354 	ssize_t error = 0;
1355 
1356 	if (*fqname == 0) {
1357 		info = "no profile specified";
1358 		error = -ENOENT;
1359 		goto fail;
1360 	}
1361 
1362 	if (fqname[0] == ':') {
1363 		size_t ns_len;
1364 
1365 		name = aa_splitn_fqname(fqname, size, &ns_name, &ns_len);
1366 		/* released below */
1367 		ns = aa_lookupn_ns(policy_ns ? policy_ns : labels_ns(subj),
1368 				   ns_name, ns_len);
1369 		if (!ns) {
1370 			info = "namespace does not exist";
1371 			error = -ENOENT;
1372 			goto fail;
1373 		}
1374 	} else
1375 		/* released below */
1376 		ns = aa_get_ns(policy_ns ? policy_ns : labels_ns(subj));
1377 
1378 	if (!name) {
1379 		/* remove namespace - can only happen if fqname[0] == ':' */
1380 		mutex_lock_nested(&ns->parent->lock, ns->parent->level);
1381 		__aa_bump_ns_revision(ns);
1382 		__aa_remove_ns(ns);
1383 		mutex_unlock(&ns->parent->lock);
1384 	} else {
1385 		/* remove profile */
1386 		mutex_lock_nested(&ns->lock, ns->level);
1387 		profile = aa_get_profile(__lookup_profile(&ns->base, name));
1388 		if (!profile) {
1389 			error = -ENOENT;
1390 			info = "profile does not exist";
1391 			goto fail_ns_lock;
1392 		}
1393 		name = profile->base.hname;
1394 		__aa_bump_ns_revision(ns);
1395 		__remove_profile(profile);
1396 		__aa_labelset_update_subtree(ns);
1397 		mutex_unlock(&ns->lock);
1398 	}
1399 
1400 	/* don't fail removal if audit fails */
1401 	(void) audit_policy(subj, OP_PROF_RM, ns_name, name, info,
1402 			    error);
1403 	aa_put_ns(ns);
1404 	aa_put_profile(profile);
1405 	return size;
1406 
1407 fail_ns_lock:
1408 	mutex_unlock(&ns->lock);
1409 	aa_put_ns(ns);
1410 
1411 fail:
1412 	(void) audit_policy(subj, OP_PROF_RM, ns_name, name, info,
1413 			    error);
1414 	return error;
1415 }
1416