xref: /linux/security/apparmor/policy.c (revision 84c455decf27ce97a23fb70b58075592ab88d66a)
1 // SPDX-License-Identifier: GPL-2.0-only
2 /*
3  * AppArmor security module
4  *
5  * This file contains AppArmor policy manipulation functions
6  *
7  * Copyright (C) 1998-2008 Novell/SUSE
8  * Copyright 2009-2010 Canonical Ltd.
9  *
10  * AppArmor policy is based around profiles, which contain the rules a
11  * task is confined by.  Every task in the system has a profile attached
12  * to it determined either by matching "unconfined" tasks against the
13  * visible set of profiles or by following a profiles attachment rules.
14  *
15  * Each profile exists in a profile namespace which is a container of
16  * visible profiles.  Each namespace contains a special "unconfined" profile,
17  * which doesn't enforce any confinement on a task beyond DAC.
18  *
19  * Namespace and profile names can be written together in either
20  * of two syntaxes.
21  *	:namespace:profile - used by kernel interfaces for easy detection
22  *	namespace://profile - used by policy
23  *
24  * Profile names can not start with : or @ or ^ and may not contain \0
25  *
26  * Reserved profile names
27  *	unconfined - special automatically generated unconfined profile
28  *	inherit - special name to indicate profile inheritance
29  *	null-XXXX-YYYY - special automatically generated learning profiles
30  *
31  * Namespace names may not start with / or @ and may not contain \0 or :
32  * Reserved namespace names
33  *	user-XXXX - user defined profiles
34  *
35  * a // in a profile or namespace name indicates a hierarchical name with the
36  * name before the // being the parent and the name after the child.
37  *
38  * Profile and namespace hierarchies serve two different but similar purposes.
39  * The namespace contains the set of visible profiles that are considered
40  * for attachment.  The hierarchy of namespaces allows for virtualizing
41  * the namespace so that for example a chroot can have its own set of profiles
42  * which may define some local user namespaces.
43  * The profile hierarchy severs two distinct purposes,
44  * -  it allows for sub profiles or hats, which allows an application to run
45  *    subprograms under its own profile with different restriction than it
46  *    self, and not have it use the system profile.
47  *    eg. if a mail program starts an editor, the policy might make the
48  *        restrictions tighter on the editor tighter than the mail program,
49  *        and definitely different than general editor restrictions
50  * - it allows for binary hierarchy of profiles, so that execution history
51  *   is preserved.  This feature isn't exploited by AppArmor reference policy
52  *   but is allowed.  NOTE: this is currently suboptimal because profile
53  *   aliasing is not currently implemented so that a profile for each
54  *   level must be defined.
55  *   eg. /bin/bash///bin/ls as a name would indicate /bin/ls was started
56  *       from /bin/bash
57  *
58  *   A profile or namespace name that can contain one or more // separators
59  *   is referred to as an hname (hierarchical).
60  *   eg.  /bin/bash//bin/ls
61  *
62  *   An fqname is a name that may contain both namespace and profile hnames.
63  *   eg. :ns:/bin/bash//bin/ls
64  *
65  * NOTES:
66  *   - locking of profile lists is currently fairly coarse.  All profile
67  *     lists within a namespace use the namespace lock.
68  * FIXME: move profile lists to using rcu_lists
69  */
70 
71 #include <linux/slab.h>
72 #include <linux/spinlock.h>
73 #include <linux/string.h>
74 #include <linux/cred.h>
75 #include <linux/rculist.h>
76 #include <linux/user_namespace.h>
77 
78 #include "include/apparmor.h"
79 #include "include/capability.h"
80 #include "include/cred.h"
81 #include "include/file.h"
82 #include "include/ipc.h"
83 #include "include/match.h"
84 #include "include/path.h"
85 #include "include/policy.h"
86 #include "include/policy_ns.h"
87 #include "include/policy_unpack.h"
88 #include "include/resource.h"
89 
90 int unprivileged_userns_apparmor_policy = 1;
91 int aa_unprivileged_unconfined_restricted;
92 
93 const char *const aa_profile_mode_names[] = {
94 	"enforce",
95 	"complain",
96 	"kill",
97 	"unconfined",
98 	"user",
99 };
100 
101 
102 static void aa_free_pdb(struct aa_policydb *pdb)
103 {
104 	if (pdb) {
105 		aa_put_dfa(pdb->dfa);
106 		kvfree(pdb->perms);
107 		aa_free_str_table(&pdb->trans);
108 		kfree(pdb);
109 	}
110 }
111 
112 /**
113  * aa_pdb_free_kref - free aa_policydb by kref (called by aa_put_pdb)
114  * @kref: kref callback for freeing of a dfa  (NOT NULL)
115  */
116 void aa_pdb_free_kref(struct kref *kref)
117 {
118 	struct aa_policydb *pdb = container_of(kref, struct aa_policydb, count);
119 
120 	aa_free_pdb(pdb);
121 }
122 
123 
124 struct aa_policydb *aa_alloc_pdb(gfp_t gfp)
125 {
126 	struct aa_policydb *pdb = kzalloc(sizeof(struct aa_policydb), gfp);
127 
128 	if (!pdb)
129 		return NULL;
130 
131 	kref_init(&pdb->count);
132 
133 	return pdb;
134 }
135 
136 
137 /**
138  * __add_profile - add a profiles to list and label tree
139  * @list: list to add it to  (NOT NULL)
140  * @profile: the profile to add  (NOT NULL)
141  *
142  * refcount @profile, should be put by __list_remove_profile
143  *
144  * Requires: namespace lock be held, or list not be shared
145  */
146 static void __add_profile(struct list_head *list, struct aa_profile *profile)
147 {
148 	struct aa_label *l;
149 
150 	AA_BUG(!list);
151 	AA_BUG(!profile);
152 	AA_BUG(!profile->ns);
153 	AA_BUG(!mutex_is_locked(&profile->ns->lock));
154 
155 	list_add_rcu(&profile->base.list, list);
156 	/* get list reference */
157 	aa_get_profile(profile);
158 	l = aa_label_insert(&profile->ns->labels, &profile->label);
159 	AA_BUG(l != &profile->label);
160 	aa_put_label(l);
161 }
162 
163 /**
164  * __list_remove_profile - remove a profile from the list it is on
165  * @profile: the profile to remove  (NOT NULL)
166  *
167  * remove a profile from the list, warning generally removal should
168  * be done with __replace_profile as most profile removals are
169  * replacements to the unconfined profile.
170  *
171  * put @profile list refcount
172  *
173  * Requires: namespace lock be held, or list not have been live
174  */
175 static void __list_remove_profile(struct aa_profile *profile)
176 {
177 	AA_BUG(!profile);
178 	AA_BUG(!profile->ns);
179 	AA_BUG(!mutex_is_locked(&profile->ns->lock));
180 
181 	list_del_rcu(&profile->base.list);
182 	aa_put_profile(profile);
183 }
184 
185 /**
186  * __remove_profile - remove old profile, and children
187  * @profile: profile to be replaced  (NOT NULL)
188  *
189  * Requires: namespace list lock be held, or list not be shared
190  */
191 static void __remove_profile(struct aa_profile *profile)
192 {
193 	AA_BUG(!profile);
194 	AA_BUG(!profile->ns);
195 	AA_BUG(!mutex_is_locked(&profile->ns->lock));
196 
197 	/* release any children lists first */
198 	__aa_profile_list_release(&profile->base.profiles);
199 	/* released by free_profile */
200 	aa_label_remove(&profile->label);
201 	__aafs_profile_rmdir(profile);
202 	__list_remove_profile(profile);
203 }
204 
205 /**
206  * __aa_profile_list_release - remove all profiles on the list and put refs
207  * @head: list of profiles  (NOT NULL)
208  *
209  * Requires: namespace lock be held
210  */
211 void __aa_profile_list_release(struct list_head *head)
212 {
213 	struct aa_profile *profile, *tmp;
214 	list_for_each_entry_safe(profile, tmp, head, base.list)
215 		__remove_profile(profile);
216 }
217 
218 /**
219  * aa_free_data - free a data blob
220  * @ptr: data to free
221  * @arg: unused
222  */
223 static void aa_free_data(void *ptr, void *arg)
224 {
225 	struct aa_data *data = ptr;
226 
227 	kvfree_sensitive(data->data, data->size);
228 	kfree_sensitive(data->key);
229 	kfree_sensitive(data);
230 }
231 
232 static void free_attachment(struct aa_attachment *attach)
233 {
234 	int i;
235 
236 	for (i = 0; i < attach->xattr_count; i++)
237 		kfree_sensitive(attach->xattrs[i]);
238 	kfree_sensitive(attach->xattrs);
239 	aa_put_pdb(attach->xmatch);
240 }
241 
242 static void free_ruleset(struct aa_ruleset *rules)
243 {
244 	int i;
245 
246 	aa_put_pdb(rules->file);
247 	aa_put_pdb(rules->policy);
248 	aa_free_cap_rules(&rules->caps);
249 	aa_free_rlimit_rules(&rules->rlimits);
250 
251 	for (i = 0; i < rules->secmark_count; i++)
252 		kfree_sensitive(rules->secmark[i].label);
253 	kfree_sensitive(rules->secmark);
254 	kfree_sensitive(rules);
255 }
256 
257 struct aa_ruleset *aa_alloc_ruleset(gfp_t gfp)
258 {
259 	struct aa_ruleset *rules;
260 
261 	rules = kzalloc(sizeof(*rules), gfp);
262 	if (rules)
263 		INIT_LIST_HEAD(&rules->list);
264 
265 	return rules;
266 }
267 
268 /**
269  * aa_free_profile - free a profile
270  * @profile: the profile to free  (MAYBE NULL)
271  *
272  * Free a profile, its hats and null_profile. All references to the profile,
273  * its hats and null_profile must have been put.
274  *
275  * If the profile was referenced from a task context, free_profile() will
276  * be called from an rcu callback routine, so we must not sleep here.
277  */
278 void aa_free_profile(struct aa_profile *profile)
279 {
280 	struct aa_ruleset *rule, *tmp;
281 	struct rhashtable *rht;
282 
283 	AA_DEBUG(DEBUG_POLICY, "%s(%p)\n", __func__, profile);
284 
285 	if (!profile)
286 		return;
287 
288 	/* free children profiles */
289 	aa_policy_destroy(&profile->base);
290 	aa_put_profile(rcu_access_pointer(profile->parent));
291 
292 	aa_put_ns(profile->ns);
293 	kfree_sensitive(profile->rename);
294 	kfree_sensitive(profile->disconnected);
295 
296 	free_attachment(&profile->attach);
297 
298 	/*
299 	 * at this point there are no tasks that can have a reference
300 	 * to rules
301 	 */
302 	list_for_each_entry_safe(rule, tmp, &profile->rules, list) {
303 		list_del_init(&rule->list);
304 		free_ruleset(rule);
305 	}
306 	kfree_sensitive(profile->dirname);
307 
308 	if (profile->data) {
309 		rht = profile->data;
310 		profile->data = NULL;
311 		rhashtable_free_and_destroy(rht, aa_free_data, NULL);
312 		kfree_sensitive(rht);
313 	}
314 
315 	kfree_sensitive(profile->hash);
316 	aa_put_loaddata(profile->rawdata);
317 	aa_label_destroy(&profile->label);
318 
319 	kfree_sensitive(profile);
320 }
321 
322 /**
323  * aa_alloc_profile - allocate, initialize and return a new profile
324  * @hname: name of the profile  (NOT NULL)
325  * @proxy: proxy to use OR null if to allocate a new one
326  * @gfp: allocation type
327  *
328  * Returns: refcount profile or NULL on failure
329  */
330 struct aa_profile *aa_alloc_profile(const char *hname, struct aa_proxy *proxy,
331 				    gfp_t gfp)
332 {
333 	struct aa_profile *profile;
334 	struct aa_ruleset *rules;
335 
336 	/* freed by free_profile - usually through aa_put_profile */
337 	profile = kzalloc(struct_size(profile, label.vec, 2), gfp);
338 	if (!profile)
339 		return NULL;
340 
341 	if (!aa_policy_init(&profile->base, NULL, hname, gfp))
342 		goto fail;
343 	if (!aa_label_init(&profile->label, 1, gfp))
344 		goto fail;
345 
346 	INIT_LIST_HEAD(&profile->rules);
347 
348 	/* allocate the first ruleset, but leave it empty */
349 	rules = aa_alloc_ruleset(gfp);
350 	if (!rules)
351 		goto fail;
352 	list_add(&rules->list, &profile->rules);
353 
354 	/* update being set needed by fs interface */
355 	if (!proxy) {
356 		proxy = aa_alloc_proxy(&profile->label, gfp);
357 		if (!proxy)
358 			goto fail;
359 	} else
360 		aa_get_proxy(proxy);
361 	profile->label.proxy = proxy;
362 
363 	profile->label.hname = profile->base.hname;
364 	profile->label.flags |= FLAG_PROFILE;
365 	profile->label.vec[0] = profile;
366 
367 	profile->signal = SIGKILL;
368 	/* refcount released by caller */
369 	return profile;
370 
371 fail:
372 	aa_free_profile(profile);
373 
374 	return NULL;
375 }
376 
377 /* set of rules that are mediated by unconfined */
378 static int unconfined_mediates[] = { AA_CLASS_NS, AA_CLASS_IO_URING, 0 };
379 
380 /* must be called after profile rulesets and start information is setup */
381 void aa_compute_profile_mediates(struct aa_profile *profile)
382 {
383 	int c;
384 
385 	if (profile_unconfined(profile)) {
386 		int *pos;
387 
388 		for (pos = unconfined_mediates; *pos; pos++) {
389 			if (ANY_RULE_MEDIATES(&profile->rules, AA_CLASS_NS) !=
390 			    DFA_NOMATCH)
391 				profile->label.mediates |= ((u64) 1) << AA_CLASS_NS;
392 		}
393 		return;
394 	}
395 	for (c = 0; c <= AA_CLASS_LAST; c++) {
396 		if (ANY_RULE_MEDIATES(&profile->rules, c) != DFA_NOMATCH)
397 			profile->label.mediates |= ((u64) 1) << c;
398 	}
399 }
400 
401 /* TODO: profile accounting - setup in remove */
402 
403 /**
404  * __strn_find_child - find a profile on @head list using substring of @name
405  * @head: list to search  (NOT NULL)
406  * @name: name of profile (NOT NULL)
407  * @len: length of @name substring to match
408  *
409  * Requires: rcu_read_lock be held
410  *
411  * Returns: unrefcounted profile ptr, or NULL if not found
412  */
413 static struct aa_profile *__strn_find_child(struct list_head *head,
414 					    const char *name, int len)
415 {
416 	return (struct aa_profile *)__policy_strn_find(head, name, len);
417 }
418 
419 /**
420  * __find_child - find a profile on @head list with a name matching @name
421  * @head: list to search  (NOT NULL)
422  * @name: name of profile (NOT NULL)
423  *
424  * Requires: rcu_read_lock be held
425  *
426  * Returns: unrefcounted profile ptr, or NULL if not found
427  */
428 static struct aa_profile *__find_child(struct list_head *head, const char *name)
429 {
430 	return __strn_find_child(head, name, strlen(name));
431 }
432 
433 /**
434  * aa_find_child - find a profile by @name in @parent
435  * @parent: profile to search  (NOT NULL)
436  * @name: profile name to search for  (NOT NULL)
437  *
438  * Returns: a refcounted profile or NULL if not found
439  */
440 struct aa_profile *aa_find_child(struct aa_profile *parent, const char *name)
441 {
442 	struct aa_profile *profile;
443 
444 	rcu_read_lock();
445 	do {
446 		profile = __find_child(&parent->base.profiles, name);
447 	} while (profile && !aa_get_profile_not0(profile));
448 	rcu_read_unlock();
449 
450 	/* refcount released by caller */
451 	return profile;
452 }
453 
454 /**
455  * __lookup_parent - lookup the parent of a profile of name @hname
456  * @ns: namespace to lookup profile in  (NOT NULL)
457  * @hname: hierarchical profile name to find parent of  (NOT NULL)
458  *
459  * Lookups up the parent of a fully qualified profile name, the profile
460  * that matches hname does not need to exist, in general this
461  * is used to load a new profile.
462  *
463  * Requires: rcu_read_lock be held
464  *
465  * Returns: unrefcounted policy or NULL if not found
466  */
467 static struct aa_policy *__lookup_parent(struct aa_ns *ns,
468 					 const char *hname)
469 {
470 	struct aa_policy *policy;
471 	struct aa_profile *profile = NULL;
472 	char *split;
473 
474 	policy = &ns->base;
475 
476 	for (split = strstr(hname, "//"); split;) {
477 		profile = __strn_find_child(&policy->profiles, hname,
478 					    split - hname);
479 		if (!profile)
480 			return NULL;
481 		policy = &profile->base;
482 		hname = split + 2;
483 		split = strstr(hname, "//");
484 	}
485 	if (!profile)
486 		return &ns->base;
487 	return &profile->base;
488 }
489 
490 /**
491  * __create_missing_ancestors - create place holders for missing ancestores
492  * @ns: namespace to lookup profile in (NOT NULL)
493  * @hname: hierarchical profile name to find parent of (NOT NULL)
494  * @gfp: type of allocation.
495  *
496  * Requires: ns mutex lock held
497  *
498  * Return: unrefcounted parent policy on success or %NULL if error creating
499  *          place holder profiles.
500  */
501 static struct aa_policy *__create_missing_ancestors(struct aa_ns *ns,
502 						    const char *hname,
503 						    gfp_t gfp)
504 {
505 	struct aa_policy *policy;
506 	struct aa_profile *parent, *profile = NULL;
507 	char *split;
508 
509 	AA_BUG(!ns);
510 	AA_BUG(!hname);
511 
512 	policy = &ns->base;
513 
514 	for (split = strstr(hname, "//"); split;) {
515 		parent = profile;
516 		profile = __strn_find_child(&policy->profiles, hname,
517 					    split - hname);
518 		if (!profile) {
519 			const char *name = kstrndup(hname, split - hname,
520 						    gfp);
521 			if (!name)
522 				return NULL;
523 			profile = aa_alloc_null(parent, name, gfp);
524 			kfree(name);
525 			if (!profile)
526 				return NULL;
527 			if (!parent)
528 				profile->ns = aa_get_ns(ns);
529 		}
530 		policy = &profile->base;
531 		hname = split + 2;
532 		split = strstr(hname, "//");
533 	}
534 	if (!profile)
535 		return &ns->base;
536 	return &profile->base;
537 }
538 
539 /**
540  * __lookupn_profile - lookup the profile matching @hname
541  * @base: base list to start looking up profile name from  (NOT NULL)
542  * @hname: hierarchical profile name  (NOT NULL)
543  * @n: length of @hname
544  *
545  * Requires: rcu_read_lock be held
546  *
547  * Returns: unrefcounted profile pointer or NULL if not found
548  *
549  * Do a relative name lookup, recursing through profile tree.
550  */
551 static struct aa_profile *__lookupn_profile(struct aa_policy *base,
552 					    const char *hname, size_t n)
553 {
554 	struct aa_profile *profile = NULL;
555 	const char *split;
556 
557 	for (split = strnstr(hname, "//", n); split;
558 	     split = strnstr(hname, "//", n)) {
559 		profile = __strn_find_child(&base->profiles, hname,
560 					    split - hname);
561 		if (!profile)
562 			return NULL;
563 
564 		base = &profile->base;
565 		n -= split + 2 - hname;
566 		hname = split + 2;
567 	}
568 
569 	if (n)
570 		return __strn_find_child(&base->profiles, hname, n);
571 	return NULL;
572 }
573 
574 static struct aa_profile *__lookup_profile(struct aa_policy *base,
575 					   const char *hname)
576 {
577 	return __lookupn_profile(base, hname, strlen(hname));
578 }
579 
580 /**
581  * aa_lookupn_profile - find a profile by its full or partial name
582  * @ns: the namespace to start from (NOT NULL)
583  * @hname: name to do lookup on.  Does not contain namespace prefix (NOT NULL)
584  * @n: size of @hname
585  *
586  * Returns: refcounted profile or NULL if not found
587  */
588 struct aa_profile *aa_lookupn_profile(struct aa_ns *ns, const char *hname,
589 				      size_t n)
590 {
591 	struct aa_profile *profile;
592 
593 	rcu_read_lock();
594 	do {
595 		profile = __lookupn_profile(&ns->base, hname, n);
596 	} while (profile && !aa_get_profile_not0(profile));
597 	rcu_read_unlock();
598 
599 	/* the unconfined profile is not in the regular profile list */
600 	if (!profile && strncmp(hname, "unconfined", n) == 0)
601 		profile = aa_get_newest_profile(ns->unconfined);
602 
603 	/* refcount released by caller */
604 	return profile;
605 }
606 
607 struct aa_profile *aa_fqlookupn_profile(struct aa_label *base,
608 					const char *fqname, size_t n)
609 {
610 	struct aa_profile *profile;
611 	struct aa_ns *ns;
612 	const char *name, *ns_name;
613 	size_t ns_len;
614 
615 	name = aa_splitn_fqname(fqname, n, &ns_name, &ns_len);
616 	if (ns_name) {
617 		ns = aa_lookupn_ns(labels_ns(base), ns_name, ns_len);
618 		if (!ns)
619 			return NULL;
620 	} else
621 		ns = aa_get_ns(labels_ns(base));
622 
623 	if (name)
624 		profile = aa_lookupn_profile(ns, name, n - (name - fqname));
625 	else if (ns)
626 		/* default profile for ns, currently unconfined */
627 		profile = aa_get_newest_profile(ns->unconfined);
628 	else
629 		profile = NULL;
630 	aa_put_ns(ns);
631 
632 	return profile;
633 }
634 
635 
636 struct aa_profile *aa_alloc_null(struct aa_profile *parent, const char *name,
637 				 gfp_t gfp)
638 {
639 	struct aa_profile *profile;
640 	struct aa_ruleset *rules;
641 
642 	profile = aa_alloc_profile(name, NULL, gfp);
643 	if (!profile)
644 		return NULL;
645 
646 	/* TODO: ideally we should inherit abi from parent */
647 	profile->label.flags |= FLAG_NULL;
648 	profile->attach.xmatch = aa_get_pdb(nullpdb);
649 	rules = list_first_entry(&profile->rules, typeof(*rules), list);
650 	rules->file = aa_get_pdb(nullpdb);
651 	rules->policy = aa_get_pdb(nullpdb);
652 	aa_compute_profile_mediates(profile);
653 
654 	if (parent) {
655 		profile->path_flags = parent->path_flags;
656 		/* override/inherit what is mediated from parent */
657 		profile->label.mediates = parent->label.mediates;
658 		/* released on free_profile */
659 		rcu_assign_pointer(profile->parent, aa_get_profile(parent));
660 		profile->ns = aa_get_ns(parent->ns);
661 	}
662 
663 	return profile;
664 }
665 
666 /**
667  * aa_new_learning_profile - create or find a null-X learning profile
668  * @parent: profile that caused this profile to be created (NOT NULL)
669  * @hat: true if the null- learning profile is a hat
670  * @base: name to base the null profile off of
671  * @gfp: type of allocation
672  *
673  * Find/Create a null- complain mode profile used in learning mode.  The
674  * name of the profile is unique and follows the format of parent//null-XXX.
675  * where XXX is based on the @name or if that fails or is not supplied
676  * a unique number
677  *
678  * null profiles are added to the profile list but the list does not
679  * hold a count on them so that they are automatically released when
680  * not in use.
681  *
682  * Returns: new refcounted profile else NULL on failure
683  */
684 struct aa_profile *aa_new_learning_profile(struct aa_profile *parent, bool hat,
685 					   const char *base, gfp_t gfp)
686 {
687 	struct aa_profile *p, *profile;
688 	const char *bname;
689 	char *name = NULL;
690 
691 	AA_BUG(!parent);
692 
693 	if (base) {
694 		name = kmalloc(strlen(parent->base.hname) + 8 + strlen(base),
695 			       gfp);
696 		if (name) {
697 			sprintf(name, "%s//null-%s", parent->base.hname, base);
698 			goto name;
699 		}
700 		/* fall through to try shorter uniq */
701 	}
702 
703 	name = kmalloc(strlen(parent->base.hname) + 2 + 7 + 8, gfp);
704 	if (!name)
705 		return NULL;
706 	sprintf(name, "%s//null-%x", parent->base.hname,
707 		atomic_inc_return(&parent->ns->uniq_null));
708 
709 name:
710 	/* lookup to see if this is a dup creation */
711 	bname = basename(name);
712 	profile = aa_find_child(parent, bname);
713 	if (profile)
714 		goto out;
715 
716 	profile = aa_alloc_null(parent, name, gfp);
717 	if (!profile)
718 		goto fail;
719 	profile->mode = APPARMOR_COMPLAIN;
720 	if (hat)
721 		profile->label.flags |= FLAG_HAT;
722 
723 	mutex_lock_nested(&profile->ns->lock, profile->ns->level);
724 	p = __find_child(&parent->base.profiles, bname);
725 	if (p) {
726 		aa_free_profile(profile);
727 		profile = aa_get_profile(p);
728 	} else {
729 		__add_profile(&parent->base.profiles, profile);
730 	}
731 	mutex_unlock(&profile->ns->lock);
732 
733 	/* refcount released by caller */
734 out:
735 	kfree(name);
736 
737 	return profile;
738 
739 fail:
740 	kfree(name);
741 	aa_free_profile(profile);
742 	return NULL;
743 }
744 
745 /**
746  * replacement_allowed - test to see if replacement is allowed
747  * @profile: profile to test if it can be replaced  (MAYBE NULL)
748  * @noreplace: true if replacement shouldn't be allowed but addition is okay
749  * @info: Returns - info about why replacement failed (NOT NULL)
750  *
751  * Returns: %0 if replacement allowed else error code
752  */
753 static int replacement_allowed(struct aa_profile *profile, int noreplace,
754 			       const char **info)
755 {
756 	if (profile) {
757 		if (profile->label.flags & FLAG_IMMUTIBLE) {
758 			*info = "cannot replace immutable profile";
759 			return -EPERM;
760 		} else if (noreplace) {
761 			*info = "profile already exists";
762 			return -EEXIST;
763 		}
764 	}
765 	return 0;
766 }
767 
768 /* audit callback for net specific fields */
769 static void audit_cb(struct audit_buffer *ab, void *va)
770 {
771 	struct common_audit_data *sa = va;
772 	struct apparmor_audit_data *ad = aad(sa);
773 
774 	if (ad->iface.ns) {
775 		audit_log_format(ab, " ns=");
776 		audit_log_untrustedstring(ab, ad->iface.ns);
777 	}
778 }
779 
780 /**
781  * audit_policy - Do auditing of policy changes
782  * @subj_label: label to check if it can manage policy
783  * @op: policy operation being performed
784  * @ns_name: name of namespace being manipulated
785  * @name: name of profile being manipulated (NOT NULL)
786  * @info: any extra information to be audited (MAYBE NULL)
787  * @error: error code
788  *
789  * Returns: the error to be returned after audit is done
790  */
791 static int audit_policy(struct aa_label *subj_label, const char *op,
792 			const char *ns_name, const char *name,
793 			const char *info, int error)
794 {
795 	DEFINE_AUDIT_DATA(ad, LSM_AUDIT_DATA_NONE, AA_CLASS_NONE, op);
796 
797 	ad.iface.ns = ns_name;
798 	ad.name = name;
799 	ad.info = info;
800 	ad.error = error;
801 	ad.subj_label = subj_label;
802 
803 	aa_audit_msg(AUDIT_APPARMOR_STATUS, &ad, audit_cb);
804 
805 	return error;
806 }
807 
808 /* don't call out to other LSMs in the stack for apparmor policy admin
809  * permissions
810  */
811 static int policy_ns_capable(const struct cred *subj_cred,
812 			     struct aa_label *label,
813 			     struct user_namespace *userns, int cap)
814 {
815 	int err;
816 
817 	/* check for MAC_ADMIN cap in cred */
818 	err = cap_capable(subj_cred, userns, cap, CAP_OPT_NONE);
819 	if (!err)
820 		err = aa_capable(subj_cred, label, cap, CAP_OPT_NONE);
821 
822 	return err;
823 }
824 
825 /**
826  * aa_policy_view_capable - check if viewing policy in at @ns is allowed
827  * @subj_cred: cred of subject
828  * @label: label that is trying to view policy in ns
829  * @ns: namespace being viewed by @label (may be NULL if @label's ns)
830  *
831  * Returns: true if viewing policy is allowed
832  *
833  * If @ns is NULL then the namespace being viewed is assumed to be the
834  * tasks current namespace.
835  */
836 bool aa_policy_view_capable(const struct cred *subj_cred,
837 			     struct aa_label *label, struct aa_ns *ns)
838 {
839 	struct user_namespace *user_ns = subj_cred->user_ns;
840 	struct aa_ns *view_ns = labels_view(label);
841 	bool root_in_user_ns = uid_eq(current_euid(), make_kuid(user_ns, 0)) ||
842 			       in_egroup_p(make_kgid(user_ns, 0));
843 	bool response = false;
844 	if (!ns)
845 		ns = view_ns;
846 
847 	if (root_in_user_ns && aa_ns_visible(view_ns, ns, true) &&
848 	    (user_ns == &init_user_ns ||
849 	     (unprivileged_userns_apparmor_policy != 0 &&
850 	      user_ns->level == view_ns->level)))
851 		response = true;
852 
853 	return response;
854 }
855 
856 bool aa_policy_admin_capable(const struct cred *subj_cred,
857 			     struct aa_label *label, struct aa_ns *ns)
858 {
859 	struct user_namespace *user_ns = subj_cred->user_ns;
860 	bool capable = policy_ns_capable(subj_cred, label, user_ns,
861 					 CAP_MAC_ADMIN) == 0;
862 
863 	AA_DEBUG(DEBUG_POLICY, "cap_mac_admin? %d\n", capable);
864 	AA_DEBUG(DEBUG_POLICY, "policy locked? %d\n", aa_g_lock_policy);
865 
866 	return aa_policy_view_capable(subj_cred, label, ns) && capable &&
867 		!aa_g_lock_policy;
868 }
869 
870 bool aa_current_policy_view_capable(struct aa_ns *ns)
871 {
872 	struct aa_label *label;
873 	bool res;
874 
875 	label = __begin_current_label_crit_section();
876 	res = aa_policy_view_capable(current_cred(), label, ns);
877 	__end_current_label_crit_section(label);
878 
879 	return res;
880 }
881 
882 bool aa_current_policy_admin_capable(struct aa_ns *ns)
883 {
884 	struct aa_label *label;
885 	bool res;
886 
887 	label = __begin_current_label_crit_section();
888 	res = aa_policy_admin_capable(current_cred(), label, ns);
889 	__end_current_label_crit_section(label);
890 
891 	return res;
892 }
893 
894 /**
895  * aa_may_manage_policy - can the current task manage policy
896  * @subj_cred: subjects cred
897  * @label: label to check if it can manage policy
898  * @ns: namespace being managed by @label (may be NULL if @label's ns)
899  * @mask: contains the policy manipulation operation being done
900  *
901  * Returns: 0 if the task is allowed to manipulate policy else error
902  */
903 int aa_may_manage_policy(const struct cred *subj_cred, struct aa_label *label,
904 			 struct aa_ns *ns, u32 mask)
905 {
906 	const char *op;
907 
908 	if (mask & AA_MAY_REMOVE_POLICY)
909 		op = OP_PROF_RM;
910 	else if (mask & AA_MAY_REPLACE_POLICY)
911 		op = OP_PROF_REPL;
912 	else
913 		op = OP_PROF_LOAD;
914 
915 	/* check if loading policy is locked out */
916 	if (aa_g_lock_policy)
917 		return audit_policy(label, op, NULL, NULL, "policy_locked",
918 				    -EACCES);
919 
920 	if (!aa_policy_admin_capable(subj_cred, label, ns))
921 		return audit_policy(label, op, NULL, NULL, "not policy admin",
922 				    -EACCES);
923 
924 	/* TODO: add fine grained mediation of policy loads */
925 	return 0;
926 }
927 
928 static struct aa_profile *__list_lookup_parent(struct list_head *lh,
929 					       struct aa_profile *profile)
930 {
931 	const char *base = basename(profile->base.hname);
932 	long len = base - profile->base.hname;
933 	struct aa_load_ent *ent;
934 
935 	/* parent won't have trailing // so remove from len */
936 	if (len <= 2)
937 		return NULL;
938 	len -= 2;
939 
940 	list_for_each_entry(ent, lh, list) {
941 		if (ent->new == profile)
942 			continue;
943 		if (strncmp(ent->new->base.hname, profile->base.hname, len) ==
944 		    0 && ent->new->base.hname[len] == 0)
945 			return ent->new;
946 	}
947 
948 	return NULL;
949 }
950 
951 /**
952  * __replace_profile - replace @old with @new on a list
953  * @old: profile to be replaced  (NOT NULL)
954  * @new: profile to replace @old with  (NOT NULL)
955  *
956  * Will duplicate and refcount elements that @new inherits from @old
957  * and will inherit @old children.
958  *
959  * refcount @new for list, put @old list refcount
960  *
961  * Requires: namespace list lock be held, or list not be shared
962  */
963 static void __replace_profile(struct aa_profile *old, struct aa_profile *new)
964 {
965 	struct aa_profile *child, *tmp;
966 
967 	if (!list_empty(&old->base.profiles)) {
968 		LIST_HEAD(lh);
969 		list_splice_init_rcu(&old->base.profiles, &lh, synchronize_rcu);
970 
971 		list_for_each_entry_safe(child, tmp, &lh, base.list) {
972 			struct aa_profile *p;
973 
974 			list_del_init(&child->base.list);
975 			p = __find_child(&new->base.profiles, child->base.name);
976 			if (p) {
977 				/* @p replaces @child  */
978 				__replace_profile(child, p);
979 				continue;
980 			}
981 
982 			/* inherit @child and its children */
983 			/* TODO: update hname of inherited children */
984 			/* list refcount transferred to @new */
985 			p = aa_deref_parent(child);
986 			rcu_assign_pointer(child->parent, aa_get_profile(new));
987 			list_add_rcu(&child->base.list, &new->base.profiles);
988 			aa_put_profile(p);
989 		}
990 	}
991 
992 	if (!rcu_access_pointer(new->parent)) {
993 		struct aa_profile *parent = aa_deref_parent(old);
994 		rcu_assign_pointer(new->parent, aa_get_profile(parent));
995 	}
996 	aa_label_replace(&old->label, &new->label);
997 	/* migrate dents must come after label replacement b/c update */
998 	__aafs_profile_migrate_dents(old, new);
999 
1000 	if (list_empty(&new->base.list)) {
1001 		/* new is not on a list already */
1002 		list_replace_rcu(&old->base.list, &new->base.list);
1003 		aa_get_profile(new);
1004 		aa_put_profile(old);
1005 	} else
1006 		__list_remove_profile(old);
1007 }
1008 
1009 /**
1010  * __lookup_replace - lookup replacement information for a profile
1011  * @ns: namespace the lookup occurs in
1012  * @hname: name of profile to lookup
1013  * @noreplace: true if not replacing an existing profile
1014  * @p: Returns - profile to be replaced
1015  * @info: Returns - info string on why lookup failed
1016  *
1017  * Returns: profile to replace (no ref) on success else ptr error
1018  */
1019 static int __lookup_replace(struct aa_ns *ns, const char *hname,
1020 			    bool noreplace, struct aa_profile **p,
1021 			    const char **info)
1022 {
1023 	*p = aa_get_profile(__lookup_profile(&ns->base, hname));
1024 	if (*p) {
1025 		int error = replacement_allowed(*p, noreplace, info);
1026 		if (error) {
1027 			*info = "profile can not be replaced";
1028 			return error;
1029 		}
1030 	}
1031 
1032 	return 0;
1033 }
1034 
1035 static void share_name(struct aa_profile *old, struct aa_profile *new)
1036 {
1037 	aa_put_str(new->base.hname);
1038 	aa_get_str(old->base.hname);
1039 	new->base.hname = old->base.hname;
1040 	new->base.name = old->base.name;
1041 	new->label.hname = old->label.hname;
1042 }
1043 
1044 /* Update to newest version of parent after previous replacements
1045  * Returns: unrefcount newest version of parent
1046  */
1047 static struct aa_profile *update_to_newest_parent(struct aa_profile *new)
1048 {
1049 	struct aa_profile *parent, *newest;
1050 
1051 	parent = rcu_dereference_protected(new->parent,
1052 					   mutex_is_locked(&new->ns->lock));
1053 	newest = aa_get_newest_profile(parent);
1054 
1055 	/* parent replaced in this atomic set? */
1056 	if (newest != parent) {
1057 		aa_put_profile(parent);
1058 		rcu_assign_pointer(new->parent, newest);
1059 	} else
1060 		aa_put_profile(newest);
1061 
1062 	return newest;
1063 }
1064 
1065 /**
1066  * aa_replace_profiles - replace profile(s) on the profile list
1067  * @policy_ns: namespace load is occurring on
1068  * @label: label that is attempting to load/replace policy
1069  * @mask: permission mask
1070  * @udata: serialized data stream  (NOT NULL)
1071  *
1072  * unpack and replace a profile on the profile list and uses of that profile
1073  * by any task creds via invalidating the old version of the profile, which
1074  * tasks will notice to update their own cred.  If the profile does not exist
1075  * on the profile list it is added.
1076  *
1077  * Returns: size of data consumed else error code on failure.
1078  */
1079 ssize_t aa_replace_profiles(struct aa_ns *policy_ns, struct aa_label *label,
1080 			    u32 mask, struct aa_loaddata *udata)
1081 {
1082 	const char *ns_name = NULL, *info = NULL;
1083 	struct aa_ns *ns = NULL;
1084 	struct aa_load_ent *ent, *tmp;
1085 	struct aa_loaddata *rawdata_ent;
1086 	const char *op;
1087 	ssize_t count, error;
1088 	LIST_HEAD(lh);
1089 
1090 	op = mask & AA_MAY_REPLACE_POLICY ? OP_PROF_REPL : OP_PROF_LOAD;
1091 	aa_get_loaddata(udata);
1092 	/* released below */
1093 	error = aa_unpack(udata, &lh, &ns_name);
1094 	if (error)
1095 		goto out;
1096 
1097 	/* ensure that profiles are all for the same ns
1098 	 * TODO: update locking to remove this constaint. All profiles in
1099 	 *       the load set must succeed as a set or the load will
1100 	 *       fail. Sort ent list and take ns locks in hierarchy order
1101 	 */
1102 	count = 0;
1103 	list_for_each_entry(ent, &lh, list) {
1104 		if (ns_name) {
1105 			if (ent->ns_name &&
1106 			    strcmp(ent->ns_name, ns_name) != 0) {
1107 				info = "policy load has mixed namespaces";
1108 				error = -EACCES;
1109 				goto fail;
1110 			}
1111 		} else if (ent->ns_name) {
1112 			if (count) {
1113 				info = "policy load has mixed namespaces";
1114 				error = -EACCES;
1115 				goto fail;
1116 			}
1117 			ns_name = ent->ns_name;
1118 		} else
1119 			count++;
1120 	}
1121 	if (ns_name) {
1122 		ns = aa_prepare_ns(policy_ns ? policy_ns : labels_ns(label),
1123 				   ns_name);
1124 		if (IS_ERR(ns)) {
1125 			op = OP_PROF_LOAD;
1126 			info = "failed to prepare namespace";
1127 			error = PTR_ERR(ns);
1128 			ns = NULL;
1129 			ent = NULL;
1130 			goto fail;
1131 		}
1132 	} else
1133 		ns = aa_get_ns(policy_ns ? policy_ns : labels_ns(label));
1134 
1135 	mutex_lock_nested(&ns->lock, ns->level);
1136 	/* check for duplicate rawdata blobs: space and file dedup */
1137 	if (!list_empty(&ns->rawdata_list)) {
1138 		list_for_each_entry(rawdata_ent, &ns->rawdata_list, list) {
1139 			if (aa_rawdata_eq(rawdata_ent, udata)) {
1140 				struct aa_loaddata *tmp;
1141 
1142 				tmp = __aa_get_loaddata(rawdata_ent);
1143 				/* check we didn't fail the race */
1144 				if (tmp) {
1145 					aa_put_loaddata(udata);
1146 					udata = tmp;
1147 					break;
1148 				}
1149 			}
1150 		}
1151 	}
1152 	/* setup parent and ns info */
1153 	list_for_each_entry(ent, &lh, list) {
1154 		struct aa_policy *policy;
1155 		struct aa_profile *p;
1156 
1157 		if (aa_g_export_binary)
1158 			ent->new->rawdata = aa_get_loaddata(udata);
1159 		error = __lookup_replace(ns, ent->new->base.hname,
1160 					 !(mask & AA_MAY_REPLACE_POLICY),
1161 					 &ent->old, &info);
1162 		if (error)
1163 			goto fail_lock;
1164 
1165 		if (ent->new->rename) {
1166 			error = __lookup_replace(ns, ent->new->rename,
1167 						!(mask & AA_MAY_REPLACE_POLICY),
1168 						&ent->rename, &info);
1169 			if (error)
1170 				goto fail_lock;
1171 		}
1172 
1173 		/* released when @new is freed */
1174 		ent->new->ns = aa_get_ns(ns);
1175 
1176 		if (ent->old || ent->rename)
1177 			continue;
1178 
1179 		/* no ref on policy only use inside lock */
1180 		p = NULL;
1181 		policy = __lookup_parent(ns, ent->new->base.hname);
1182 		if (!policy) {
1183 			/* first check for parent in the load set */
1184 			p = __list_lookup_parent(&lh, ent->new);
1185 			if (!p) {
1186 				/*
1187 				 * fill in missing parent with null
1188 				 * profile that doesn't have
1189 				 * permissions. This allows for
1190 				 * individual profile loading where
1191 				 * the child is loaded before the
1192 				 * parent, and outside of the current
1193 				 * atomic set. This unfortunately can
1194 				 * happen with some userspaces.  The
1195 				 * null profile will be replaced once
1196 				 * the parent is loaded.
1197 				 */
1198 				policy = __create_missing_ancestors(ns,
1199 							ent->new->base.hname,
1200 							GFP_KERNEL);
1201 				if (!policy) {
1202 					error = -ENOENT;
1203 					info = "parent does not exist";
1204 					goto fail_lock;
1205 				}
1206 			}
1207 		}
1208 		if (!p && policy != &ns->base)
1209 			/* released on profile replacement or free_profile */
1210 			p = (struct aa_profile *) policy;
1211 		rcu_assign_pointer(ent->new->parent, aa_get_profile(p));
1212 	}
1213 
1214 	/* create new fs entries for introspection if needed */
1215 	if (!udata->dents[AAFS_LOADDATA_DIR] && aa_g_export_binary) {
1216 		error = __aa_fs_create_rawdata(ns, udata);
1217 		if (error) {
1218 			info = "failed to create raw_data dir and files";
1219 			ent = NULL;
1220 			goto fail_lock;
1221 		}
1222 	}
1223 	list_for_each_entry(ent, &lh, list) {
1224 		if (!ent->old) {
1225 			struct dentry *parent;
1226 			if (rcu_access_pointer(ent->new->parent)) {
1227 				struct aa_profile *p;
1228 				p = aa_deref_parent(ent->new);
1229 				parent = prof_child_dir(p);
1230 			} else
1231 				parent = ns_subprofs_dir(ent->new->ns);
1232 			error = __aafs_profile_mkdir(ent->new, parent);
1233 		}
1234 
1235 		if (error) {
1236 			info = "failed to create";
1237 			goto fail_lock;
1238 		}
1239 	}
1240 
1241 	/* Done with checks that may fail - do actual replacement */
1242 	__aa_bump_ns_revision(ns);
1243 	if (aa_g_export_binary)
1244 		__aa_loaddata_update(udata, ns->revision);
1245 	list_for_each_entry_safe(ent, tmp, &lh, list) {
1246 		list_del_init(&ent->list);
1247 		op = (!ent->old && !ent->rename) ? OP_PROF_LOAD : OP_PROF_REPL;
1248 
1249 		if (ent->old && ent->old->rawdata == ent->new->rawdata &&
1250 		    ent->new->rawdata) {
1251 			/* dedup actual profile replacement */
1252 			audit_policy(label, op, ns_name, ent->new->base.hname,
1253 				     "same as current profile, skipping",
1254 				     error);
1255 			/* break refcount cycle with proxy. */
1256 			aa_put_proxy(ent->new->label.proxy);
1257 			ent->new->label.proxy = NULL;
1258 			goto skip;
1259 		}
1260 
1261 		/*
1262 		 * TODO: finer dedup based on profile range in data. Load set
1263 		 * can differ but profile may remain unchanged
1264 		 */
1265 		audit_policy(label, op, ns_name, ent->new->base.hname, NULL,
1266 			     error);
1267 
1268 		if (ent->old) {
1269 			share_name(ent->old, ent->new);
1270 			__replace_profile(ent->old, ent->new);
1271 		} else {
1272 			struct list_head *lh;
1273 
1274 			if (rcu_access_pointer(ent->new->parent)) {
1275 				struct aa_profile *parent;
1276 
1277 				parent = update_to_newest_parent(ent->new);
1278 				lh = &parent->base.profiles;
1279 			} else
1280 				lh = &ns->base.profiles;
1281 			__add_profile(lh, ent->new);
1282 		}
1283 	skip:
1284 		aa_load_ent_free(ent);
1285 	}
1286 	__aa_labelset_update_subtree(ns);
1287 	mutex_unlock(&ns->lock);
1288 
1289 out:
1290 	aa_put_ns(ns);
1291 	aa_put_loaddata(udata);
1292 	kfree(ns_name);
1293 
1294 	if (error)
1295 		return error;
1296 	return udata->size;
1297 
1298 fail_lock:
1299 	mutex_unlock(&ns->lock);
1300 
1301 	/* audit cause of failure */
1302 	op = (ent && !ent->old) ? OP_PROF_LOAD : OP_PROF_REPL;
1303 fail:
1304 	  audit_policy(label, op, ns_name, ent ? ent->new->base.hname : NULL,
1305 		       info, error);
1306 	/* audit status that rest of profiles in the atomic set failed too */
1307 	info = "valid profile in failed atomic policy load";
1308 	list_for_each_entry(tmp, &lh, list) {
1309 		if (tmp == ent) {
1310 			info = "unchecked profile in failed atomic policy load";
1311 			/* skip entry that caused failure */
1312 			continue;
1313 		}
1314 		op = (!tmp->old) ? OP_PROF_LOAD : OP_PROF_REPL;
1315 		audit_policy(label, op, ns_name, tmp->new->base.hname, info,
1316 			     error);
1317 	}
1318 	list_for_each_entry_safe(ent, tmp, &lh, list) {
1319 		list_del_init(&ent->list);
1320 		aa_load_ent_free(ent);
1321 	}
1322 
1323 	goto out;
1324 }
1325 
1326 /**
1327  * aa_remove_profiles - remove profile(s) from the system
1328  * @policy_ns: namespace the remove is being done from
1329  * @subj: label attempting to remove policy
1330  * @fqname: name of the profile or namespace to remove  (NOT NULL)
1331  * @size: size of the name
1332  *
1333  * Remove a profile or sub namespace from the current namespace, so that
1334  * they can not be found anymore and mark them as replaced by unconfined
1335  *
1336  * NOTE: removing confinement does not restore rlimits to preconfinement values
1337  *
1338  * Returns: size of data consume else error code if fails
1339  */
1340 ssize_t aa_remove_profiles(struct aa_ns *policy_ns, struct aa_label *subj,
1341 			   char *fqname, size_t size)
1342 {
1343 	struct aa_ns *ns = NULL;
1344 	struct aa_profile *profile = NULL;
1345 	const char *name = fqname, *info = NULL;
1346 	const char *ns_name = NULL;
1347 	ssize_t error = 0;
1348 
1349 	if (*fqname == 0) {
1350 		info = "no profile specified";
1351 		error = -ENOENT;
1352 		goto fail;
1353 	}
1354 
1355 	if (fqname[0] == ':') {
1356 		size_t ns_len;
1357 
1358 		name = aa_splitn_fqname(fqname, size, &ns_name, &ns_len);
1359 		/* released below */
1360 		ns = aa_lookupn_ns(policy_ns ? policy_ns : labels_ns(subj),
1361 				   ns_name, ns_len);
1362 		if (!ns) {
1363 			info = "namespace does not exist";
1364 			error = -ENOENT;
1365 			goto fail;
1366 		}
1367 	} else
1368 		/* released below */
1369 		ns = aa_get_ns(policy_ns ? policy_ns : labels_ns(subj));
1370 
1371 	if (!name) {
1372 		/* remove namespace - can only happen if fqname[0] == ':' */
1373 		mutex_lock_nested(&ns->parent->lock, ns->parent->level);
1374 		__aa_bump_ns_revision(ns);
1375 		__aa_remove_ns(ns);
1376 		mutex_unlock(&ns->parent->lock);
1377 	} else {
1378 		/* remove profile */
1379 		mutex_lock_nested(&ns->lock, ns->level);
1380 		profile = aa_get_profile(__lookup_profile(&ns->base, name));
1381 		if (!profile) {
1382 			error = -ENOENT;
1383 			info = "profile does not exist";
1384 			goto fail_ns_lock;
1385 		}
1386 		name = profile->base.hname;
1387 		__aa_bump_ns_revision(ns);
1388 		__remove_profile(profile);
1389 		__aa_labelset_update_subtree(ns);
1390 		mutex_unlock(&ns->lock);
1391 	}
1392 
1393 	/* don't fail removal if audit fails */
1394 	(void) audit_policy(subj, OP_PROF_RM, ns_name, name, info,
1395 			    error);
1396 	aa_put_ns(ns);
1397 	aa_put_profile(profile);
1398 	return size;
1399 
1400 fail_ns_lock:
1401 	mutex_unlock(&ns->lock);
1402 	aa_put_ns(ns);
1403 
1404 fail:
1405 	(void) audit_policy(subj, OP_PROF_RM, ns_name, name, info,
1406 			    error);
1407 	return error;
1408 }
1409