1/// Make sure calls to d_find_alias() have a corresponding call to dput(). 2// 3// Keywords: d_find_alias, dput 4// 5// Confidence: Moderate 6// URL: http://coccinelle.lip6.fr/ 7// Options: --include-headers 8 9virtual context 10virtual org 11virtual patch 12virtual report 13 14@r exists@ 15local idexpression struct dentry *dent; 16expression E, E1; 17statement S1, S2; 18position p1, p2; 19@@ 20( 21 if (!(dent@p1 = d_find_alias(...))) S1 22| 23 dent@p1 = d_find_alias(...) 24) 25 26<...when != dput(dent) 27 when != if (...) { <+... dput(dent) ...+> } 28 when != true !dent || ... 29 when != dent = E 30 when != E = dent 31if (!dent || ...) S2 32...> 33( 34 return <+...dent...+>; 35| 36 return @p2 ...; 37| 38 dent@p2 = E1; 39| 40 E1 = dent; 41) 42 43@depends on context@ 44local idexpression struct dentry *r.dent; 45position r.p1,r.p2; 46@@ 47* dent@p1 = ... 48 ... 49( 50* return@p2 ...; 51| 52* dent@p2 53) 54 55 56@script:python depends on org@ 57p1 << r.p1; 58p2 << r.p2; 59@@ 60cocci.print_main("Missing call to dput()",p1) 61cocci.print_secs("",p2) 62 63@depends on patch@ 64local idexpression struct dentry *r.dent; 65position r.p2; 66@@ 67( 68+ dput(dent); 69 return @p2 ...; 70| 71+ dput(dent); 72 dent@p2 = ...; 73) 74 75@script:python depends on report@ 76p1 << r.p1; 77p2 << r.p2; 78@@ 79msg = "Missing call to dput() at line %s." 80coccilib.report.print_report(p1[0], msg % (p2[0].line)) 81