xref: /linux/net/hsr/hsr_device.c (revision 49ac6f05ace5bb0070c68a0193aa05d3c25d4c83)
1 // SPDX-License-Identifier: GPL-2.0
2 /* Copyright 2011-2014 Autronica Fire and Security AS
3  *
4  * Author(s):
5  *	2011-2014 Arvid Brodin, arvid.brodin@alten.se
6  * This file contains device methods for creating, using and destroying
7  * virtual HSR or PRP devices.
8  */
9 
10 #include <linux/netdevice.h>
11 #include <linux/skbuff.h>
12 #include <linux/etherdevice.h>
13 #include <linux/rtnetlink.h>
14 #include <linux/pkt_sched.h>
15 #include "hsr_device.h"
16 #include "hsr_slave.h"
17 #include "hsr_framereg.h"
18 #include "hsr_main.h"
19 #include "hsr_forward.h"
20 
21 static bool is_admin_up(struct net_device *dev)
22 {
23 	return dev && (dev->flags & IFF_UP);
24 }
25 
26 static bool is_slave_up(struct net_device *dev)
27 {
28 	return dev && is_admin_up(dev) && netif_oper_up(dev);
29 }
30 
31 static void hsr_set_operstate(struct hsr_port *master, bool has_carrier)
32 {
33 	struct net_device *dev = master->dev;
34 
35 	if (!is_admin_up(dev)) {
36 		netdev_set_operstate(dev, IF_OPER_DOWN);
37 		return;
38 	}
39 
40 	if (has_carrier)
41 		netdev_set_operstate(dev, IF_OPER_UP);
42 	else
43 		netdev_set_operstate(dev, IF_OPER_LOWERLAYERDOWN);
44 }
45 
46 static bool hsr_check_carrier(struct hsr_port *master)
47 {
48 	struct hsr_port *port;
49 
50 	ASSERT_RTNL();
51 
52 	hsr_for_each_port(master->hsr, port) {
53 		if (port->type != HSR_PT_MASTER && is_slave_up(port->dev)) {
54 			netif_carrier_on(master->dev);
55 			return true;
56 		}
57 	}
58 
59 	netif_carrier_off(master->dev);
60 
61 	return false;
62 }
63 
64 static void hsr_check_announce(struct net_device *hsr_dev)
65 {
66 	struct hsr_priv *hsr;
67 
68 	hsr = netdev_priv(hsr_dev);
69 	if (netif_running(hsr_dev) && netif_oper_up(hsr_dev)) {
70 		/* Enable announce timer and start sending supervisory frames */
71 		if (!timer_pending(&hsr->announce_timer)) {
72 			hsr->announce_count = 0;
73 			mod_timer(&hsr->announce_timer, jiffies +
74 				  msecs_to_jiffies(HSR_ANNOUNCE_INTERVAL));
75 		}
76 
77 		if (hsr->redbox && !timer_pending(&hsr->announce_proxy_timer))
78 			mod_timer(&hsr->announce_proxy_timer, jiffies +
79 				  msecs_to_jiffies(HSR_ANNOUNCE_INTERVAL) / 2);
80 	} else {
81 		/* Deactivate the announce timer  */
82 		timer_delete(&hsr->announce_timer);
83 		if (hsr->redbox)
84 			timer_delete(&hsr->announce_proxy_timer);
85 	}
86 }
87 
88 void hsr_check_carrier_and_operstate(struct hsr_priv *hsr)
89 {
90 	struct hsr_port *master;
91 	bool has_carrier;
92 
93 	master = hsr_port_get_hsr(hsr, HSR_PT_MASTER);
94 	/* netif_stacked_transfer_operstate() cannot be used here since
95 	 * it doesn't set IF_OPER_LOWERLAYERDOWN (?)
96 	 */
97 	has_carrier = hsr_check_carrier(master);
98 	hsr_set_operstate(master, has_carrier);
99 	hsr_check_announce(master->dev);
100 }
101 
102 int hsr_get_max_mtu(struct hsr_priv *hsr)
103 {
104 	unsigned int mtu_max;
105 	struct hsr_port *port;
106 
107 	mtu_max = ETH_DATA_LEN;
108 	hsr_for_each_port(hsr, port)
109 		if (port->type != HSR_PT_MASTER)
110 			mtu_max = min(port->dev->mtu, mtu_max);
111 
112 	if (mtu_max < HSR_HLEN)
113 		return 0;
114 	return mtu_max - HSR_HLEN;
115 }
116 
117 static int hsr_dev_change_mtu(struct net_device *dev, int new_mtu)
118 {
119 	struct hsr_priv *hsr;
120 
121 	hsr = netdev_priv(dev);
122 
123 	if (new_mtu > hsr_get_max_mtu(hsr)) {
124 		netdev_info(dev, "A HSR master's MTU cannot be greater than the smallest MTU of its slaves minus the HSR Tag length (%d octets).\n",
125 			    HSR_HLEN);
126 		return -EINVAL;
127 	}
128 
129 	WRITE_ONCE(dev->mtu, new_mtu);
130 
131 	return 0;
132 }
133 
134 static int hsr_dev_open(struct net_device *dev)
135 {
136 	struct hsr_priv *hsr;
137 	struct hsr_port *port;
138 	const char *designation = NULL;
139 
140 	hsr = netdev_priv(dev);
141 
142 	hsr_for_each_port(hsr, port) {
143 		if (port->type == HSR_PT_MASTER)
144 			continue;
145 		switch (port->type) {
146 		case HSR_PT_SLAVE_A:
147 			designation = "Slave A";
148 			break;
149 		case HSR_PT_SLAVE_B:
150 			designation = "Slave B";
151 			break;
152 		case HSR_PT_INTERLINK:
153 			designation = "Interlink";
154 			break;
155 		default:
156 			designation = "Unknown";
157 		}
158 		if (!is_slave_up(port->dev))
159 			netdev_warn(dev, "%s (%s) is not up; please bring it up to get a fully working HSR network\n",
160 				    designation, port->dev->name);
161 	}
162 
163 	if (!designation)
164 		netdev_warn(dev, "No slave devices configured\n");
165 
166 	return 0;
167 }
168 
169 static int hsr_dev_close(struct net_device *dev)
170 {
171 	struct hsr_port *port;
172 	struct hsr_priv *hsr;
173 
174 	hsr = netdev_priv(dev);
175 	hsr_for_each_port(hsr, port) {
176 		if (port->type == HSR_PT_MASTER)
177 			continue;
178 		switch (port->type) {
179 		case HSR_PT_SLAVE_A:
180 		case HSR_PT_SLAVE_B:
181 			dev_uc_unsync(port->dev, dev);
182 			dev_mc_unsync(port->dev, dev);
183 			break;
184 		default:
185 			break;
186 		}
187 	}
188 
189 	return 0;
190 }
191 
192 static netdev_features_t hsr_features_recompute(struct hsr_priv *hsr,
193 						netdev_features_t features)
194 {
195 	netdev_features_t mask;
196 	struct hsr_port *port;
197 
198 	mask = features;
199 
200 	/* Mask out all features that, if supported by one device, should be
201 	 * enabled for all devices (see NETIF_F_ONE_FOR_ALL).
202 	 *
203 	 * Anything that's off in mask will not be enabled - so only things
204 	 * that were in features originally, and also is in NETIF_F_ONE_FOR_ALL,
205 	 * may become enabled.
206 	 */
207 	features &= ~NETIF_F_ONE_FOR_ALL;
208 	hsr_for_each_port(hsr, port)
209 		features = netdev_increment_features(features,
210 						     port->dev->features,
211 						     mask);
212 
213 	return features;
214 }
215 
216 static netdev_features_t hsr_fix_features(struct net_device *dev,
217 					  netdev_features_t features)
218 {
219 	struct hsr_priv *hsr = netdev_priv(dev);
220 
221 	return hsr_features_recompute(hsr, features);
222 }
223 
224 static netdev_tx_t hsr_dev_xmit(struct sk_buff *skb, struct net_device *dev)
225 {
226 	struct hsr_priv *hsr = netdev_priv(dev);
227 	struct hsr_port *master;
228 
229 	master = hsr_port_get_hsr(hsr, HSR_PT_MASTER);
230 	if (master) {
231 		skb->dev = master->dev;
232 		skb_reset_mac_header(skb);
233 		skb_reset_mac_len(skb);
234 		hsr_forward_skb(skb, master);
235 	} else {
236 		dev_core_stats_tx_dropped_inc(dev);
237 		dev_kfree_skb_any(skb);
238 	}
239 	return NETDEV_TX_OK;
240 }
241 
242 static const struct header_ops hsr_header_ops = {
243 	.create	 = eth_header,
244 	.parse	 = eth_header_parse,
245 };
246 
247 static struct sk_buff *hsr_init_skb(struct hsr_port *master)
248 {
249 	struct hsr_priv *hsr = master->hsr;
250 	struct sk_buff *skb;
251 	int hlen, tlen;
252 
253 	hlen = LL_RESERVED_SPACE(master->dev);
254 	tlen = master->dev->needed_tailroom;
255 	/* skb size is same for PRP/HSR frames, only difference
256 	 * being, for PRP it is a trailer and for HSR it is a
257 	 * header
258 	 */
259 	skb = dev_alloc_skb(sizeof(struct hsr_sup_tag) +
260 			    sizeof(struct hsr_sup_payload) + hlen + tlen);
261 
262 	if (!skb)
263 		return skb;
264 
265 	skb_reserve(skb, hlen);
266 	skb->dev = master->dev;
267 	skb->priority = TC_PRIO_CONTROL;
268 
269 	if (dev_hard_header(skb, skb->dev, ETH_P_PRP,
270 			    hsr->sup_multicast_addr,
271 			    skb->dev->dev_addr, skb->len) <= 0)
272 		goto out;
273 
274 	skb_reset_mac_header(skb);
275 	skb_reset_mac_len(skb);
276 	skb_reset_network_header(skb);
277 	skb_reset_transport_header(skb);
278 
279 	return skb;
280 out:
281 	kfree_skb(skb);
282 
283 	return NULL;
284 }
285 
286 static void send_hsr_supervision_frame(struct hsr_port *port,
287 				       unsigned long *interval,
288 				       const unsigned char *addr)
289 {
290 	struct hsr_priv *hsr = port->hsr;
291 	__u8 type = HSR_TLV_LIFE_CHECK;
292 	struct hsr_sup_payload *hsr_sp;
293 	struct hsr_sup_tlv *hsr_stlv;
294 	struct hsr_sup_tag *hsr_stag;
295 	struct sk_buff *skb;
296 
297 	*interval = msecs_to_jiffies(HSR_LIFE_CHECK_INTERVAL);
298 	if (hsr->announce_count < 3 && hsr->prot_version == 0) {
299 		type = HSR_TLV_ANNOUNCE;
300 		*interval = msecs_to_jiffies(HSR_ANNOUNCE_INTERVAL);
301 		hsr->announce_count++;
302 	}
303 
304 	skb = hsr_init_skb(port);
305 	if (!skb) {
306 		netdev_warn_once(port->dev, "HSR: Could not send supervision frame\n");
307 		return;
308 	}
309 
310 	hsr_stag = skb_put(skb, sizeof(struct hsr_sup_tag));
311 	set_hsr_stag_path(hsr_stag, (hsr->prot_version ? 0x0 : 0xf));
312 	set_hsr_stag_HSR_ver(hsr_stag, hsr->prot_version);
313 
314 	/* From HSRv1 on we have separate supervision sequence numbers. */
315 	if (hsr->prot_version > 0)
316 		hsr_stag->sequence_nr = htons(atomic_inc_return(&hsr->sup_sequence_nr));
317 	else
318 		hsr_stag->sequence_nr = htons(atomic_inc_return(&hsr->sequence_nr));
319 
320 	hsr_stag->tlv.HSR_TLV_type = type;
321 	/* TODO: Why 12 in HSRv0? */
322 	hsr_stag->tlv.HSR_TLV_length = hsr->prot_version ?
323 				sizeof(struct hsr_sup_payload) : 12;
324 
325 	/* Payload: MacAddressA / SAN MAC from ProxyNodeTable */
326 	hsr_sp = skb_put(skb, sizeof(struct hsr_sup_payload));
327 	ether_addr_copy(hsr_sp->macaddress_A, addr);
328 
329 	if (hsr->redbox &&
330 	    hsr_is_node_in_db(&hsr->proxy_node_db, addr)) {
331 		hsr_stlv = skb_put(skb, sizeof(struct hsr_sup_tlv));
332 		hsr_stlv->HSR_TLV_type = PRP_TLV_REDBOX_MAC;
333 		hsr_stlv->HSR_TLV_length = sizeof(struct hsr_sup_payload);
334 
335 		/* Payload: MacAddressRedBox */
336 		hsr_sp = skb_put(skb, sizeof(struct hsr_sup_payload));
337 		ether_addr_copy(hsr_sp->macaddress_A, hsr->macaddress_redbox);
338 	}
339 
340 	if (skb_put_padto(skb, ETH_ZLEN))
341 		return;
342 
343 	hsr_forward_skb(skb, port);
344 
345 	return;
346 }
347 
348 static void send_prp_supervision_frame(struct hsr_port *master,
349 				       unsigned long *interval,
350 				       const unsigned char *addr)
351 {
352 	struct hsr_priv *hsr = master->hsr;
353 	struct hsr_sup_payload *hsr_sp;
354 	struct hsr_sup_tag *hsr_stag;
355 	struct sk_buff *skb;
356 
357 	skb = hsr_init_skb(master);
358 	if (!skb) {
359 		netdev_warn_once(master->dev, "PRP: Could not send supervision frame\n");
360 		return;
361 	}
362 
363 	*interval = msecs_to_jiffies(HSR_LIFE_CHECK_INTERVAL);
364 	hsr_stag = skb_put(skb, sizeof(struct hsr_sup_tag));
365 	set_hsr_stag_path(hsr_stag, (hsr->prot_version ? 0x0 : 0xf));
366 	set_hsr_stag_HSR_ver(hsr_stag, (hsr->prot_version ? 1 : 0));
367 
368 	/* From HSRv1 on we have separate supervision sequence numbers. */
369 	hsr_stag->sequence_nr = htons(atomic_inc_return(&hsr->sup_sequence_nr));
370 	hsr_stag->tlv.HSR_TLV_type = PRP_TLV_LIFE_CHECK_DD;
371 	hsr_stag->tlv.HSR_TLV_length = sizeof(struct hsr_sup_payload);
372 
373 	/* Payload: MacAddressA */
374 	hsr_sp = skb_put(skb, sizeof(struct hsr_sup_payload));
375 	ether_addr_copy(hsr_sp->macaddress_A, master->dev->dev_addr);
376 
377 	if (skb_put_padto(skb, ETH_ZLEN))
378 		return;
379 
380 	hsr_forward_skb(skb, master);
381 }
382 
383 /* Announce (supervision frame) timer function
384  */
385 static void hsr_announce(struct timer_list *t)
386 {
387 	struct hsr_priv *hsr;
388 	struct hsr_port *master;
389 	unsigned long interval;
390 
391 	hsr = from_timer(hsr, t, announce_timer);
392 
393 	rcu_read_lock();
394 	master = hsr_port_get_hsr(hsr, HSR_PT_MASTER);
395 	hsr->proto_ops->send_sv_frame(master, &interval, master->dev->dev_addr);
396 
397 	if (is_admin_up(master->dev))
398 		mod_timer(&hsr->announce_timer, jiffies + interval);
399 
400 	rcu_read_unlock();
401 }
402 
403 /* Announce (supervision frame) timer function for RedBox
404  */
405 static void hsr_proxy_announce(struct timer_list *t)
406 {
407 	struct hsr_priv *hsr = from_timer(hsr, t, announce_proxy_timer);
408 	struct hsr_port *interlink;
409 	unsigned long interval = 0;
410 	struct hsr_node *node;
411 
412 	rcu_read_lock();
413 	/* RedBOX sends supervisory frames to HSR network with MAC addresses
414 	 * of SAN nodes stored in ProxyNodeTable.
415 	 */
416 	interlink = hsr_port_get_hsr(hsr, HSR_PT_INTERLINK);
417 	list_for_each_entry_rcu(node, &hsr->proxy_node_db, mac_list) {
418 		if (hsr_addr_is_redbox(hsr, node->macaddress_A))
419 			continue;
420 		hsr->proto_ops->send_sv_frame(interlink, &interval,
421 					      node->macaddress_A);
422 	}
423 
424 	if (is_admin_up(interlink->dev)) {
425 		if (!interval)
426 			interval = msecs_to_jiffies(HSR_ANNOUNCE_INTERVAL);
427 
428 		mod_timer(&hsr->announce_proxy_timer, jiffies + interval);
429 	}
430 
431 	rcu_read_unlock();
432 }
433 
434 void hsr_del_ports(struct hsr_priv *hsr)
435 {
436 	struct hsr_port *port;
437 
438 	port = hsr_port_get_hsr(hsr, HSR_PT_SLAVE_A);
439 	if (port)
440 		hsr_del_port(port);
441 
442 	port = hsr_port_get_hsr(hsr, HSR_PT_SLAVE_B);
443 	if (port)
444 		hsr_del_port(port);
445 
446 	port = hsr_port_get_hsr(hsr, HSR_PT_INTERLINK);
447 	if (port)
448 		hsr_del_port(port);
449 
450 	port = hsr_port_get_hsr(hsr, HSR_PT_MASTER);
451 	if (port)
452 		hsr_del_port(port);
453 }
454 
455 static void hsr_set_rx_mode(struct net_device *dev)
456 {
457 	struct hsr_port *port;
458 	struct hsr_priv *hsr;
459 
460 	hsr = netdev_priv(dev);
461 
462 	hsr_for_each_port(hsr, port) {
463 		if (port->type == HSR_PT_MASTER)
464 			continue;
465 		switch (port->type) {
466 		case HSR_PT_SLAVE_A:
467 		case HSR_PT_SLAVE_B:
468 			dev_mc_sync_multiple(port->dev, dev);
469 			dev_uc_sync_multiple(port->dev, dev);
470 			break;
471 		default:
472 			break;
473 		}
474 	}
475 }
476 
477 static void hsr_change_rx_flags(struct net_device *dev, int change)
478 {
479 	struct hsr_port *port;
480 	struct hsr_priv *hsr;
481 
482 	hsr = netdev_priv(dev);
483 
484 	hsr_for_each_port(hsr, port) {
485 		if (port->type == HSR_PT_MASTER)
486 			continue;
487 		switch (port->type) {
488 		case HSR_PT_SLAVE_A:
489 		case HSR_PT_SLAVE_B:
490 			if (change & IFF_ALLMULTI)
491 				dev_set_allmulti(port->dev,
492 						 dev->flags &
493 						 IFF_ALLMULTI ? 1 : -1);
494 			break;
495 		default:
496 			break;
497 		}
498 	}
499 }
500 
501 static const struct net_device_ops hsr_device_ops = {
502 	.ndo_change_mtu = hsr_dev_change_mtu,
503 	.ndo_open = hsr_dev_open,
504 	.ndo_stop = hsr_dev_close,
505 	.ndo_start_xmit = hsr_dev_xmit,
506 	.ndo_change_rx_flags = hsr_change_rx_flags,
507 	.ndo_fix_features = hsr_fix_features,
508 	.ndo_set_rx_mode = hsr_set_rx_mode,
509 };
510 
511 static const struct device_type hsr_type = {
512 	.name = "hsr",
513 };
514 
515 static struct hsr_proto_ops hsr_ops = {
516 	.send_sv_frame = send_hsr_supervision_frame,
517 	.create_tagged_frame = hsr_create_tagged_frame,
518 	.get_untagged_frame = hsr_get_untagged_frame,
519 	.drop_frame = hsr_drop_frame,
520 	.fill_frame_info = hsr_fill_frame_info,
521 	.invalid_dan_ingress_frame = hsr_invalid_dan_ingress_frame,
522 };
523 
524 static struct hsr_proto_ops prp_ops = {
525 	.send_sv_frame = send_prp_supervision_frame,
526 	.create_tagged_frame = prp_create_tagged_frame,
527 	.get_untagged_frame = prp_get_untagged_frame,
528 	.drop_frame = prp_drop_frame,
529 	.fill_frame_info = prp_fill_frame_info,
530 	.handle_san_frame = prp_handle_san_frame,
531 	.update_san_info = prp_update_san_info,
532 };
533 
534 void hsr_dev_setup(struct net_device *dev)
535 {
536 	eth_hw_addr_random(dev);
537 
538 	ether_setup(dev);
539 	dev->min_mtu = 0;
540 	dev->header_ops = &hsr_header_ops;
541 	dev->netdev_ops = &hsr_device_ops;
542 	SET_NETDEV_DEVTYPE(dev, &hsr_type);
543 	dev->priv_flags |= IFF_NO_QUEUE | IFF_DISABLE_NETPOLL;
544 
545 	dev->needs_free_netdev = true;
546 
547 	dev->hw_features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HIGHDMA |
548 			   NETIF_F_GSO_MASK | NETIF_F_HW_CSUM |
549 			   NETIF_F_HW_VLAN_CTAG_TX;
550 
551 	dev->features = dev->hw_features;
552 
553 	/* Prevent recursive tx locking */
554 	dev->features |= NETIF_F_LLTX;
555 	/* VLAN on top of HSR needs testing and probably some work on
556 	 * hsr_header_create() etc.
557 	 */
558 	dev->features |= NETIF_F_VLAN_CHALLENGED;
559 	/* Not sure about this. Taken from bridge code. netdev_features.h says
560 	 * it means "Does not change network namespaces".
561 	 */
562 	dev->features |= NETIF_F_NETNS_LOCAL;
563 }
564 
565 /* Return true if dev is a HSR master; return false otherwise.
566  */
567 bool is_hsr_master(struct net_device *dev)
568 {
569 	return (dev->netdev_ops->ndo_start_xmit == hsr_dev_xmit);
570 }
571 EXPORT_SYMBOL(is_hsr_master);
572 
573 /* Default multicast address for HSR Supervision frames */
574 static const unsigned char def_multicast_addr[ETH_ALEN] __aligned(2) = {
575 	0x01, 0x15, 0x4e, 0x00, 0x01, 0x00
576 };
577 
578 int hsr_dev_finalize(struct net_device *hsr_dev, struct net_device *slave[2],
579 		     struct net_device *interlink, unsigned char multicast_spec,
580 		     u8 protocol_version, struct netlink_ext_ack *extack)
581 {
582 	bool unregister = false;
583 	struct hsr_priv *hsr;
584 	int res;
585 
586 	hsr = netdev_priv(hsr_dev);
587 	INIT_LIST_HEAD(&hsr->ports);
588 	INIT_LIST_HEAD(&hsr->node_db);
589 	INIT_LIST_HEAD(&hsr->proxy_node_db);
590 	spin_lock_init(&hsr->list_lock);
591 
592 	eth_hw_addr_set(hsr_dev, slave[0]->dev_addr);
593 
594 	/* initialize protocol specific functions */
595 	if (protocol_version == PRP_V1) {
596 		/* For PRP, lan_id has most significant 3 bits holding
597 		 * the net_id of PRP_LAN_ID
598 		 */
599 		hsr->net_id = PRP_LAN_ID << 1;
600 		hsr->proto_ops = &prp_ops;
601 	} else {
602 		hsr->proto_ops = &hsr_ops;
603 	}
604 
605 	/* Make sure we recognize frames from ourselves in hsr_rcv() */
606 	res = hsr_create_self_node(hsr, hsr_dev->dev_addr,
607 				   slave[1]->dev_addr);
608 	if (res < 0)
609 		return res;
610 
611 	/* Overflow soon to find bugs easier: */
612 	atomic_set(&hsr->sequence_nr, HSR_SEQNR_START);
613 	atomic_set(&hsr->sup_sequence_nr, HSR_SUP_SEQNR_START);
614 
615 	timer_setup(&hsr->announce_timer, hsr_announce, 0);
616 	timer_setup(&hsr->prune_timer, hsr_prune_nodes, 0);
617 	timer_setup(&hsr->prune_proxy_timer, hsr_prune_proxy_nodes, 0);
618 	timer_setup(&hsr->announce_proxy_timer, hsr_proxy_announce, 0);
619 
620 	ether_addr_copy(hsr->sup_multicast_addr, def_multicast_addr);
621 	hsr->sup_multicast_addr[ETH_ALEN - 1] = multicast_spec;
622 
623 	hsr->prot_version = protocol_version;
624 
625 	/* Make sure the 1st call to netif_carrier_on() gets through */
626 	netif_carrier_off(hsr_dev);
627 
628 	res = hsr_add_port(hsr, hsr_dev, HSR_PT_MASTER, extack);
629 	if (res)
630 		goto err_add_master;
631 
632 	/* HSR forwarding offload supported in lower device? */
633 	if ((slave[0]->features & NETIF_F_HW_HSR_FWD) &&
634 	    (slave[1]->features & NETIF_F_HW_HSR_FWD))
635 		hsr->fwd_offloaded = true;
636 
637 	res = register_netdevice(hsr_dev);
638 	if (res)
639 		goto err_unregister;
640 
641 	unregister = true;
642 
643 	res = hsr_add_port(hsr, slave[0], HSR_PT_SLAVE_A, extack);
644 	if (res)
645 		goto err_unregister;
646 
647 	res = hsr_add_port(hsr, slave[1], HSR_PT_SLAVE_B, extack);
648 	if (res)
649 		goto err_unregister;
650 
651 	if (interlink) {
652 		res = hsr_add_port(hsr, interlink, HSR_PT_INTERLINK, extack);
653 		if (res)
654 			goto err_unregister;
655 
656 		hsr->redbox = true;
657 		ether_addr_copy(hsr->macaddress_redbox, interlink->dev_addr);
658 		mod_timer(&hsr->prune_proxy_timer,
659 			  jiffies + msecs_to_jiffies(PRUNE_PROXY_PERIOD));
660 	}
661 
662 	hsr_debugfs_init(hsr, hsr_dev);
663 	mod_timer(&hsr->prune_timer, jiffies + msecs_to_jiffies(PRUNE_PERIOD));
664 
665 	return 0;
666 
667 err_unregister:
668 	hsr_del_ports(hsr);
669 err_add_master:
670 	hsr_del_self_node(hsr);
671 
672 	if (unregister)
673 		unregister_netdevice(hsr_dev);
674 	return res;
675 }
676