xref: /linux/net/dsa/port.c (revision b6459415b384cb829f0b2a4268f211c789f6cf0b)
1 // SPDX-License-Identifier: GPL-2.0-or-later
2 /*
3  * Handling of a single switch port
4  *
5  * Copyright (c) 2017 Savoir-faire Linux Inc.
6  *	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
7  */
8 
9 #include <linux/if_bridge.h>
10 #include <linux/notifier.h>
11 #include <linux/of_mdio.h>
12 #include <linux/of_net.h>
13 
14 #include "dsa_priv.h"
15 
16 /**
17  * dsa_port_notify - Notify the switching fabric of changes to a port
18  * @dp: port on which change occurred
19  * @e: event, must be of type DSA_NOTIFIER_*
20  * @v: event-specific value.
21  *
22  * Notify all switches in the DSA tree that this port's switch belongs to,
23  * including this switch itself, of an event. Allows the other switches to
24  * reconfigure themselves for cross-chip operations. Can also be used to
25  * reconfigure ports without net_devices (CPU ports, DSA links) whenever
26  * a user port's state changes.
27  */
28 static int dsa_port_notify(const struct dsa_port *dp, unsigned long e, void *v)
29 {
30 	return dsa_tree_notify(dp->ds->dst, e, v);
31 }
32 
33 static void dsa_port_notify_bridge_fdb_flush(const struct dsa_port *dp)
34 {
35 	struct net_device *brport_dev = dsa_port_to_bridge_port(dp);
36 	struct switchdev_notifier_fdb_info info = {
37 		/* flush all VLANs */
38 		.vid = 0,
39 	};
40 
41 	/* When the port becomes standalone it has already left the bridge.
42 	 * Don't notify the bridge in that case.
43 	 */
44 	if (!brport_dev)
45 		return;
46 
47 	call_switchdev_notifiers(SWITCHDEV_FDB_FLUSH_TO_BRIDGE,
48 				 brport_dev, &info.info, NULL);
49 }
50 
51 static void dsa_port_fast_age(const struct dsa_port *dp)
52 {
53 	struct dsa_switch *ds = dp->ds;
54 
55 	if (!ds->ops->port_fast_age)
56 		return;
57 
58 	ds->ops->port_fast_age(ds, dp->index);
59 
60 	dsa_port_notify_bridge_fdb_flush(dp);
61 }
62 
63 static bool dsa_port_can_configure_learning(struct dsa_port *dp)
64 {
65 	struct switchdev_brport_flags flags = {
66 		.mask = BR_LEARNING,
67 	};
68 	struct dsa_switch *ds = dp->ds;
69 	int err;
70 
71 	if (!ds->ops->port_bridge_flags || !ds->ops->port_pre_bridge_flags)
72 		return false;
73 
74 	err = ds->ops->port_pre_bridge_flags(ds, dp->index, flags, NULL);
75 	return !err;
76 }
77 
78 int dsa_port_set_state(struct dsa_port *dp, u8 state, bool do_fast_age)
79 {
80 	struct dsa_switch *ds = dp->ds;
81 	int port = dp->index;
82 
83 	if (!ds->ops->port_stp_state_set)
84 		return -EOPNOTSUPP;
85 
86 	ds->ops->port_stp_state_set(ds, port, state);
87 
88 	if (!dsa_port_can_configure_learning(dp) ||
89 	    (do_fast_age && dp->learning)) {
90 		/* Fast age FDB entries or flush appropriate forwarding database
91 		 * for the given port, if we are moving it from Learning or
92 		 * Forwarding state, to Disabled or Blocking or Listening state.
93 		 * Ports that were standalone before the STP state change don't
94 		 * need to fast age the FDB, since address learning is off in
95 		 * standalone mode.
96 		 */
97 
98 		if ((dp->stp_state == BR_STATE_LEARNING ||
99 		     dp->stp_state == BR_STATE_FORWARDING) &&
100 		    (state == BR_STATE_DISABLED ||
101 		     state == BR_STATE_BLOCKING ||
102 		     state == BR_STATE_LISTENING))
103 			dsa_port_fast_age(dp);
104 	}
105 
106 	dp->stp_state = state;
107 
108 	return 0;
109 }
110 
111 static void dsa_port_set_state_now(struct dsa_port *dp, u8 state,
112 				   bool do_fast_age)
113 {
114 	int err;
115 
116 	err = dsa_port_set_state(dp, state, do_fast_age);
117 	if (err)
118 		pr_err("DSA: failed to set STP state %u (%d)\n", state, err);
119 }
120 
121 int dsa_port_enable_rt(struct dsa_port *dp, struct phy_device *phy)
122 {
123 	struct dsa_switch *ds = dp->ds;
124 	int port = dp->index;
125 	int err;
126 
127 	if (ds->ops->port_enable) {
128 		err = ds->ops->port_enable(ds, port, phy);
129 		if (err)
130 			return err;
131 	}
132 
133 	if (!dp->bridge)
134 		dsa_port_set_state_now(dp, BR_STATE_FORWARDING, false);
135 
136 	if (dp->pl)
137 		phylink_start(dp->pl);
138 
139 	return 0;
140 }
141 
142 int dsa_port_enable(struct dsa_port *dp, struct phy_device *phy)
143 {
144 	int err;
145 
146 	rtnl_lock();
147 	err = dsa_port_enable_rt(dp, phy);
148 	rtnl_unlock();
149 
150 	return err;
151 }
152 
153 void dsa_port_disable_rt(struct dsa_port *dp)
154 {
155 	struct dsa_switch *ds = dp->ds;
156 	int port = dp->index;
157 
158 	if (dp->pl)
159 		phylink_stop(dp->pl);
160 
161 	if (!dp->bridge)
162 		dsa_port_set_state_now(dp, BR_STATE_DISABLED, false);
163 
164 	if (ds->ops->port_disable)
165 		ds->ops->port_disable(ds, port);
166 }
167 
168 void dsa_port_disable(struct dsa_port *dp)
169 {
170 	rtnl_lock();
171 	dsa_port_disable_rt(dp);
172 	rtnl_unlock();
173 }
174 
175 static int dsa_port_inherit_brport_flags(struct dsa_port *dp,
176 					 struct netlink_ext_ack *extack)
177 {
178 	const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD |
179 				   BR_BCAST_FLOOD;
180 	struct net_device *brport_dev = dsa_port_to_bridge_port(dp);
181 	int flag, err;
182 
183 	for_each_set_bit(flag, &mask, 32) {
184 		struct switchdev_brport_flags flags = {0};
185 
186 		flags.mask = BIT(flag);
187 
188 		if (br_port_flag_is_set(brport_dev, BIT(flag)))
189 			flags.val = BIT(flag);
190 
191 		err = dsa_port_bridge_flags(dp, flags, extack);
192 		if (err && err != -EOPNOTSUPP)
193 			return err;
194 	}
195 
196 	return 0;
197 }
198 
199 static void dsa_port_clear_brport_flags(struct dsa_port *dp)
200 {
201 	const unsigned long val = BR_FLOOD | BR_MCAST_FLOOD | BR_BCAST_FLOOD;
202 	const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD |
203 				   BR_BCAST_FLOOD;
204 	int flag, err;
205 
206 	for_each_set_bit(flag, &mask, 32) {
207 		struct switchdev_brport_flags flags = {0};
208 
209 		flags.mask = BIT(flag);
210 		flags.val = val & BIT(flag);
211 
212 		err = dsa_port_bridge_flags(dp, flags, NULL);
213 		if (err && err != -EOPNOTSUPP)
214 			dev_err(dp->ds->dev,
215 				"failed to clear bridge port flag %lu: %pe\n",
216 				flags.val, ERR_PTR(err));
217 	}
218 }
219 
220 static int dsa_port_switchdev_sync_attrs(struct dsa_port *dp,
221 					 struct netlink_ext_ack *extack)
222 {
223 	struct net_device *brport_dev = dsa_port_to_bridge_port(dp);
224 	struct net_device *br = dsa_port_bridge_dev_get(dp);
225 	int err;
226 
227 	err = dsa_port_inherit_brport_flags(dp, extack);
228 	if (err)
229 		return err;
230 
231 	err = dsa_port_set_state(dp, br_port_get_stp_state(brport_dev), false);
232 	if (err && err != -EOPNOTSUPP)
233 		return err;
234 
235 	err = dsa_port_vlan_filtering(dp, br_vlan_enabled(br), extack);
236 	if (err && err != -EOPNOTSUPP)
237 		return err;
238 
239 	err = dsa_port_ageing_time(dp, br_get_ageing_time(br));
240 	if (err && err != -EOPNOTSUPP)
241 		return err;
242 
243 	return 0;
244 }
245 
246 static void dsa_port_switchdev_unsync_attrs(struct dsa_port *dp)
247 {
248 	/* Configure the port for standalone mode (no address learning,
249 	 * flood everything).
250 	 * The bridge only emits SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS events
251 	 * when the user requests it through netlink or sysfs, but not
252 	 * automatically at port join or leave, so we need to handle resetting
253 	 * the brport flags ourselves. But we even prefer it that way, because
254 	 * otherwise, some setups might never get the notification they need,
255 	 * for example, when a port leaves a LAG that offloads the bridge,
256 	 * it becomes standalone, but as far as the bridge is concerned, no
257 	 * port ever left.
258 	 */
259 	dsa_port_clear_brport_flags(dp);
260 
261 	/* Port left the bridge, put in BR_STATE_DISABLED by the bridge layer,
262 	 * so allow it to be in BR_STATE_FORWARDING to be kept functional
263 	 */
264 	dsa_port_set_state_now(dp, BR_STATE_FORWARDING, true);
265 
266 	/* VLAN filtering is handled by dsa_switch_bridge_leave */
267 
268 	/* Ageing time may be global to the switch chip, so don't change it
269 	 * here because we have no good reason (or value) to change it to.
270 	 */
271 }
272 
273 static int dsa_port_bridge_create(struct dsa_port *dp,
274 				  struct net_device *br,
275 				  struct netlink_ext_ack *extack)
276 {
277 	struct dsa_switch *ds = dp->ds;
278 	struct dsa_bridge *bridge;
279 
280 	bridge = dsa_tree_bridge_find(ds->dst, br);
281 	if (bridge) {
282 		refcount_inc(&bridge->refcount);
283 		dp->bridge = bridge;
284 		return 0;
285 	}
286 
287 	bridge = kzalloc(sizeof(*bridge), GFP_KERNEL);
288 	if (!bridge)
289 		return -ENOMEM;
290 
291 	refcount_set(&bridge->refcount, 1);
292 
293 	bridge->dev = br;
294 
295 	bridge->num = dsa_bridge_num_get(br, ds->max_num_bridges);
296 	if (ds->max_num_bridges && !bridge->num) {
297 		NL_SET_ERR_MSG_MOD(extack,
298 				   "Range of offloadable bridges exceeded");
299 		kfree(bridge);
300 		return -EOPNOTSUPP;
301 	}
302 
303 	dp->bridge = bridge;
304 
305 	return 0;
306 }
307 
308 static void dsa_port_bridge_destroy(struct dsa_port *dp,
309 				    const struct net_device *br)
310 {
311 	struct dsa_bridge *bridge = dp->bridge;
312 
313 	dp->bridge = NULL;
314 
315 	if (!refcount_dec_and_test(&bridge->refcount))
316 		return;
317 
318 	if (bridge->num)
319 		dsa_bridge_num_put(br, bridge->num);
320 
321 	kfree(bridge);
322 }
323 
324 int dsa_port_bridge_join(struct dsa_port *dp, struct net_device *br,
325 			 struct netlink_ext_ack *extack)
326 {
327 	struct dsa_notifier_bridge_info info = {
328 		.tree_index = dp->ds->dst->index,
329 		.sw_index = dp->ds->index,
330 		.port = dp->index,
331 	};
332 	struct net_device *dev = dp->slave;
333 	struct net_device *brport_dev;
334 	int err;
335 
336 	/* Here the interface is already bridged. Reflect the current
337 	 * configuration so that drivers can program their chips accordingly.
338 	 */
339 	err = dsa_port_bridge_create(dp, br, extack);
340 	if (err)
341 		return err;
342 
343 	brport_dev = dsa_port_to_bridge_port(dp);
344 
345 	info.bridge = *dp->bridge;
346 	err = dsa_broadcast(DSA_NOTIFIER_BRIDGE_JOIN, &info);
347 	if (err)
348 		goto out_rollback;
349 
350 	/* Drivers which support bridge TX forwarding should set this */
351 	dp->bridge->tx_fwd_offload = info.tx_fwd_offload;
352 
353 	err = switchdev_bridge_port_offload(brport_dev, dev, dp,
354 					    &dsa_slave_switchdev_notifier,
355 					    &dsa_slave_switchdev_blocking_notifier,
356 					    dp->bridge->tx_fwd_offload, extack);
357 	if (err)
358 		goto out_rollback_unbridge;
359 
360 	err = dsa_port_switchdev_sync_attrs(dp, extack);
361 	if (err)
362 		goto out_rollback_unoffload;
363 
364 	return 0;
365 
366 out_rollback_unoffload:
367 	switchdev_bridge_port_unoffload(brport_dev, dp,
368 					&dsa_slave_switchdev_notifier,
369 					&dsa_slave_switchdev_blocking_notifier);
370 out_rollback_unbridge:
371 	dsa_broadcast(DSA_NOTIFIER_BRIDGE_LEAVE, &info);
372 out_rollback:
373 	dsa_port_bridge_destroy(dp, br);
374 	return err;
375 }
376 
377 void dsa_port_pre_bridge_leave(struct dsa_port *dp, struct net_device *br)
378 {
379 	struct net_device *brport_dev = dsa_port_to_bridge_port(dp);
380 
381 	/* Don't try to unoffload something that is not offloaded */
382 	if (!brport_dev)
383 		return;
384 
385 	switchdev_bridge_port_unoffload(brport_dev, dp,
386 					&dsa_slave_switchdev_notifier,
387 					&dsa_slave_switchdev_blocking_notifier);
388 
389 	dsa_flush_workqueue();
390 }
391 
392 void dsa_port_bridge_leave(struct dsa_port *dp, struct net_device *br)
393 {
394 	struct dsa_notifier_bridge_info info = {
395 		.tree_index = dp->ds->dst->index,
396 		.sw_index = dp->ds->index,
397 		.port = dp->index,
398 		.bridge = *dp->bridge,
399 	};
400 	int err;
401 
402 	/* Here the port is already unbridged. Reflect the current configuration
403 	 * so that drivers can program their chips accordingly.
404 	 */
405 	dsa_port_bridge_destroy(dp, br);
406 
407 	err = dsa_broadcast(DSA_NOTIFIER_BRIDGE_LEAVE, &info);
408 	if (err)
409 		dev_err(dp->ds->dev,
410 			"port %d failed to notify DSA_NOTIFIER_BRIDGE_LEAVE: %pe\n",
411 			dp->index, ERR_PTR(err));
412 
413 	dsa_port_switchdev_unsync_attrs(dp);
414 }
415 
416 int dsa_port_lag_change(struct dsa_port *dp,
417 			struct netdev_lag_lower_state_info *linfo)
418 {
419 	struct dsa_notifier_lag_info info = {
420 		.sw_index = dp->ds->index,
421 		.port = dp->index,
422 	};
423 	bool tx_enabled;
424 
425 	if (!dp->lag_dev)
426 		return 0;
427 
428 	/* On statically configured aggregates (e.g. loadbalance
429 	 * without LACP) ports will always be tx_enabled, even if the
430 	 * link is down. Thus we require both link_up and tx_enabled
431 	 * in order to include it in the tx set.
432 	 */
433 	tx_enabled = linfo->link_up && linfo->tx_enabled;
434 
435 	if (tx_enabled == dp->lag_tx_enabled)
436 		return 0;
437 
438 	dp->lag_tx_enabled = tx_enabled;
439 
440 	return dsa_port_notify(dp, DSA_NOTIFIER_LAG_CHANGE, &info);
441 }
442 
443 int dsa_port_lag_join(struct dsa_port *dp, struct net_device *lag,
444 		      struct netdev_lag_upper_info *uinfo,
445 		      struct netlink_ext_ack *extack)
446 {
447 	struct dsa_notifier_lag_info info = {
448 		.sw_index = dp->ds->index,
449 		.port = dp->index,
450 		.lag = lag,
451 		.info = uinfo,
452 	};
453 	struct net_device *bridge_dev;
454 	int err;
455 
456 	dsa_lag_map(dp->ds->dst, lag);
457 	dp->lag_dev = lag;
458 
459 	err = dsa_port_notify(dp, DSA_NOTIFIER_LAG_JOIN, &info);
460 	if (err)
461 		goto err_lag_join;
462 
463 	bridge_dev = netdev_master_upper_dev_get(lag);
464 	if (!bridge_dev || !netif_is_bridge_master(bridge_dev))
465 		return 0;
466 
467 	err = dsa_port_bridge_join(dp, bridge_dev, extack);
468 	if (err)
469 		goto err_bridge_join;
470 
471 	return 0;
472 
473 err_bridge_join:
474 	dsa_port_notify(dp, DSA_NOTIFIER_LAG_LEAVE, &info);
475 err_lag_join:
476 	dp->lag_dev = NULL;
477 	dsa_lag_unmap(dp->ds->dst, lag);
478 	return err;
479 }
480 
481 void dsa_port_pre_lag_leave(struct dsa_port *dp, struct net_device *lag)
482 {
483 	struct net_device *br = dsa_port_bridge_dev_get(dp);
484 
485 	if (br)
486 		dsa_port_pre_bridge_leave(dp, br);
487 }
488 
489 void dsa_port_lag_leave(struct dsa_port *dp, struct net_device *lag)
490 {
491 	struct net_device *br = dsa_port_bridge_dev_get(dp);
492 	struct dsa_notifier_lag_info info = {
493 		.sw_index = dp->ds->index,
494 		.port = dp->index,
495 		.lag = lag,
496 	};
497 	int err;
498 
499 	if (!dp->lag_dev)
500 		return;
501 
502 	/* Port might have been part of a LAG that in turn was
503 	 * attached to a bridge.
504 	 */
505 	if (br)
506 		dsa_port_bridge_leave(dp, br);
507 
508 	dp->lag_tx_enabled = false;
509 	dp->lag_dev = NULL;
510 
511 	err = dsa_port_notify(dp, DSA_NOTIFIER_LAG_LEAVE, &info);
512 	if (err)
513 		dev_err(dp->ds->dev,
514 			"port %d failed to notify DSA_NOTIFIER_LAG_LEAVE: %pe\n",
515 			dp->index, ERR_PTR(err));
516 
517 	dsa_lag_unmap(dp->ds->dst, lag);
518 }
519 
520 /* Must be called under rcu_read_lock() */
521 static bool dsa_port_can_apply_vlan_filtering(struct dsa_port *dp,
522 					      bool vlan_filtering,
523 					      struct netlink_ext_ack *extack)
524 {
525 	struct dsa_switch *ds = dp->ds;
526 	struct dsa_port *other_dp;
527 	int err;
528 
529 	/* VLAN awareness was off, so the question is "can we turn it on".
530 	 * We may have had 8021q uppers, those need to go. Make sure we don't
531 	 * enter an inconsistent state: deny changing the VLAN awareness state
532 	 * as long as we have 8021q uppers.
533 	 */
534 	if (vlan_filtering && dsa_port_is_user(dp)) {
535 		struct net_device *br = dsa_port_bridge_dev_get(dp);
536 		struct net_device *upper_dev, *slave = dp->slave;
537 		struct list_head *iter;
538 
539 		netdev_for_each_upper_dev_rcu(slave, upper_dev, iter) {
540 			struct bridge_vlan_info br_info;
541 			u16 vid;
542 
543 			if (!is_vlan_dev(upper_dev))
544 				continue;
545 
546 			vid = vlan_dev_vlan_id(upper_dev);
547 
548 			/* br_vlan_get_info() returns -EINVAL or -ENOENT if the
549 			 * device, respectively the VID is not found, returning
550 			 * 0 means success, which is a failure for us here.
551 			 */
552 			err = br_vlan_get_info(br, vid, &br_info);
553 			if (err == 0) {
554 				NL_SET_ERR_MSG_MOD(extack,
555 						   "Must first remove VLAN uppers having VIDs also present in bridge");
556 				return false;
557 			}
558 		}
559 	}
560 
561 	if (!ds->vlan_filtering_is_global)
562 		return true;
563 
564 	/* For cases where enabling/disabling VLAN awareness is global to the
565 	 * switch, we need to handle the case where multiple bridges span
566 	 * different ports of the same switch device and one of them has a
567 	 * different setting than what is being requested.
568 	 */
569 	dsa_switch_for_each_port(other_dp, ds) {
570 		struct net_device *other_br = dsa_port_bridge_dev_get(other_dp);
571 
572 		/* If it's the same bridge, it also has same
573 		 * vlan_filtering setting => no need to check
574 		 */
575 		if (!other_br || other_br == dsa_port_bridge_dev_get(dp))
576 			continue;
577 
578 		if (br_vlan_enabled(other_br) != vlan_filtering) {
579 			NL_SET_ERR_MSG_MOD(extack,
580 					   "VLAN filtering is a global setting");
581 			return false;
582 		}
583 	}
584 	return true;
585 }
586 
587 int dsa_port_vlan_filtering(struct dsa_port *dp, bool vlan_filtering,
588 			    struct netlink_ext_ack *extack)
589 {
590 	bool old_vlan_filtering = dsa_port_is_vlan_filtering(dp);
591 	struct dsa_switch *ds = dp->ds;
592 	bool apply;
593 	int err;
594 
595 	if (!ds->ops->port_vlan_filtering)
596 		return -EOPNOTSUPP;
597 
598 	/* We are called from dsa_slave_switchdev_blocking_event(),
599 	 * which is not under rcu_read_lock(), unlike
600 	 * dsa_slave_switchdev_event().
601 	 */
602 	rcu_read_lock();
603 	apply = dsa_port_can_apply_vlan_filtering(dp, vlan_filtering, extack);
604 	rcu_read_unlock();
605 	if (!apply)
606 		return -EINVAL;
607 
608 	if (dsa_port_is_vlan_filtering(dp) == vlan_filtering)
609 		return 0;
610 
611 	err = ds->ops->port_vlan_filtering(ds, dp->index, vlan_filtering,
612 					   extack);
613 	if (err)
614 		return err;
615 
616 	if (ds->vlan_filtering_is_global) {
617 		struct dsa_port *other_dp;
618 
619 		ds->vlan_filtering = vlan_filtering;
620 
621 		dsa_switch_for_each_user_port(other_dp, ds) {
622 			struct net_device *slave = dp->slave;
623 
624 			/* We might be called in the unbind path, so not
625 			 * all slave devices might still be registered.
626 			 */
627 			if (!slave)
628 				continue;
629 
630 			err = dsa_slave_manage_vlan_filtering(slave,
631 							      vlan_filtering);
632 			if (err)
633 				goto restore;
634 		}
635 	} else {
636 		dp->vlan_filtering = vlan_filtering;
637 
638 		err = dsa_slave_manage_vlan_filtering(dp->slave,
639 						      vlan_filtering);
640 		if (err)
641 			goto restore;
642 	}
643 
644 	return 0;
645 
646 restore:
647 	ds->ops->port_vlan_filtering(ds, dp->index, old_vlan_filtering, NULL);
648 
649 	if (ds->vlan_filtering_is_global)
650 		ds->vlan_filtering = old_vlan_filtering;
651 	else
652 		dp->vlan_filtering = old_vlan_filtering;
653 
654 	return err;
655 }
656 
657 /* This enforces legacy behavior for switch drivers which assume they can't
658  * receive VLAN configuration when enslaved to a bridge with vlan_filtering=0
659  */
660 bool dsa_port_skip_vlan_configuration(struct dsa_port *dp)
661 {
662 	struct net_device *br = dsa_port_bridge_dev_get(dp);
663 	struct dsa_switch *ds = dp->ds;
664 
665 	if (!br)
666 		return false;
667 
668 	return !ds->configure_vlan_while_not_filtering && !br_vlan_enabled(br);
669 }
670 
671 int dsa_port_ageing_time(struct dsa_port *dp, clock_t ageing_clock)
672 {
673 	unsigned long ageing_jiffies = clock_t_to_jiffies(ageing_clock);
674 	unsigned int ageing_time = jiffies_to_msecs(ageing_jiffies);
675 	struct dsa_notifier_ageing_time_info info;
676 	int err;
677 
678 	info.ageing_time = ageing_time;
679 
680 	err = dsa_port_notify(dp, DSA_NOTIFIER_AGEING_TIME, &info);
681 	if (err)
682 		return err;
683 
684 	dp->ageing_time = ageing_time;
685 
686 	return 0;
687 }
688 
689 int dsa_port_pre_bridge_flags(const struct dsa_port *dp,
690 			      struct switchdev_brport_flags flags,
691 			      struct netlink_ext_ack *extack)
692 {
693 	struct dsa_switch *ds = dp->ds;
694 
695 	if (!ds->ops->port_pre_bridge_flags)
696 		return -EINVAL;
697 
698 	return ds->ops->port_pre_bridge_flags(ds, dp->index, flags, extack);
699 }
700 
701 int dsa_port_bridge_flags(struct dsa_port *dp,
702 			  struct switchdev_brport_flags flags,
703 			  struct netlink_ext_ack *extack)
704 {
705 	struct dsa_switch *ds = dp->ds;
706 	int err;
707 
708 	if (!ds->ops->port_bridge_flags)
709 		return -EOPNOTSUPP;
710 
711 	err = ds->ops->port_bridge_flags(ds, dp->index, flags, extack);
712 	if (err)
713 		return err;
714 
715 	if (flags.mask & BR_LEARNING) {
716 		bool learning = flags.val & BR_LEARNING;
717 
718 		if (learning == dp->learning)
719 			return 0;
720 
721 		if ((dp->learning && !learning) &&
722 		    (dp->stp_state == BR_STATE_LEARNING ||
723 		     dp->stp_state == BR_STATE_FORWARDING))
724 			dsa_port_fast_age(dp);
725 
726 		dp->learning = learning;
727 	}
728 
729 	return 0;
730 }
731 
732 int dsa_port_mtu_change(struct dsa_port *dp, int new_mtu,
733 			bool targeted_match)
734 {
735 	struct dsa_notifier_mtu_info info = {
736 		.sw_index = dp->ds->index,
737 		.targeted_match = targeted_match,
738 		.port = dp->index,
739 		.mtu = new_mtu,
740 	};
741 
742 	return dsa_port_notify(dp, DSA_NOTIFIER_MTU, &info);
743 }
744 
745 int dsa_port_fdb_add(struct dsa_port *dp, const unsigned char *addr,
746 		     u16 vid)
747 {
748 	struct dsa_notifier_fdb_info info = {
749 		.sw_index = dp->ds->index,
750 		.port = dp->index,
751 		.addr = addr,
752 		.vid = vid,
753 	};
754 
755 	return dsa_port_notify(dp, DSA_NOTIFIER_FDB_ADD, &info);
756 }
757 
758 int dsa_port_fdb_del(struct dsa_port *dp, const unsigned char *addr,
759 		     u16 vid)
760 {
761 	struct dsa_notifier_fdb_info info = {
762 		.sw_index = dp->ds->index,
763 		.port = dp->index,
764 		.addr = addr,
765 		.vid = vid,
766 
767 	};
768 
769 	return dsa_port_notify(dp, DSA_NOTIFIER_FDB_DEL, &info);
770 }
771 
772 int dsa_port_host_fdb_add(struct dsa_port *dp, const unsigned char *addr,
773 			  u16 vid)
774 {
775 	struct dsa_notifier_fdb_info info = {
776 		.sw_index = dp->ds->index,
777 		.port = dp->index,
778 		.addr = addr,
779 		.vid = vid,
780 	};
781 	struct dsa_port *cpu_dp = dp->cpu_dp;
782 	int err;
783 
784 	err = dev_uc_add(cpu_dp->master, addr);
785 	if (err)
786 		return err;
787 
788 	return dsa_port_notify(dp, DSA_NOTIFIER_HOST_FDB_ADD, &info);
789 }
790 
791 int dsa_port_host_fdb_del(struct dsa_port *dp, const unsigned char *addr,
792 			  u16 vid)
793 {
794 	struct dsa_notifier_fdb_info info = {
795 		.sw_index = dp->ds->index,
796 		.port = dp->index,
797 		.addr = addr,
798 		.vid = vid,
799 	};
800 	struct dsa_port *cpu_dp = dp->cpu_dp;
801 	int err;
802 
803 	err = dev_uc_del(cpu_dp->master, addr);
804 	if (err)
805 		return err;
806 
807 	return dsa_port_notify(dp, DSA_NOTIFIER_HOST_FDB_DEL, &info);
808 }
809 
810 int dsa_port_fdb_dump(struct dsa_port *dp, dsa_fdb_dump_cb_t *cb, void *data)
811 {
812 	struct dsa_switch *ds = dp->ds;
813 	int port = dp->index;
814 
815 	if (!ds->ops->port_fdb_dump)
816 		return -EOPNOTSUPP;
817 
818 	return ds->ops->port_fdb_dump(ds, port, cb, data);
819 }
820 
821 int dsa_port_mdb_add(const struct dsa_port *dp,
822 		     const struct switchdev_obj_port_mdb *mdb)
823 {
824 	struct dsa_notifier_mdb_info info = {
825 		.sw_index = dp->ds->index,
826 		.port = dp->index,
827 		.mdb = mdb,
828 	};
829 
830 	return dsa_port_notify(dp, DSA_NOTIFIER_MDB_ADD, &info);
831 }
832 
833 int dsa_port_mdb_del(const struct dsa_port *dp,
834 		     const struct switchdev_obj_port_mdb *mdb)
835 {
836 	struct dsa_notifier_mdb_info info = {
837 		.sw_index = dp->ds->index,
838 		.port = dp->index,
839 		.mdb = mdb,
840 	};
841 
842 	return dsa_port_notify(dp, DSA_NOTIFIER_MDB_DEL, &info);
843 }
844 
845 int dsa_port_host_mdb_add(const struct dsa_port *dp,
846 			  const struct switchdev_obj_port_mdb *mdb)
847 {
848 	struct dsa_notifier_mdb_info info = {
849 		.sw_index = dp->ds->index,
850 		.port = dp->index,
851 		.mdb = mdb,
852 	};
853 	struct dsa_port *cpu_dp = dp->cpu_dp;
854 	int err;
855 
856 	err = dev_mc_add(cpu_dp->master, mdb->addr);
857 	if (err)
858 		return err;
859 
860 	return dsa_port_notify(dp, DSA_NOTIFIER_HOST_MDB_ADD, &info);
861 }
862 
863 int dsa_port_host_mdb_del(const struct dsa_port *dp,
864 			  const struct switchdev_obj_port_mdb *mdb)
865 {
866 	struct dsa_notifier_mdb_info info = {
867 		.sw_index = dp->ds->index,
868 		.port = dp->index,
869 		.mdb = mdb,
870 	};
871 	struct dsa_port *cpu_dp = dp->cpu_dp;
872 	int err;
873 
874 	err = dev_mc_del(cpu_dp->master, mdb->addr);
875 	if (err)
876 		return err;
877 
878 	return dsa_port_notify(dp, DSA_NOTIFIER_HOST_MDB_DEL, &info);
879 }
880 
881 int dsa_port_vlan_add(struct dsa_port *dp,
882 		      const struct switchdev_obj_port_vlan *vlan,
883 		      struct netlink_ext_ack *extack)
884 {
885 	struct dsa_notifier_vlan_info info = {
886 		.sw_index = dp->ds->index,
887 		.port = dp->index,
888 		.vlan = vlan,
889 		.extack = extack,
890 	};
891 
892 	return dsa_port_notify(dp, DSA_NOTIFIER_VLAN_ADD, &info);
893 }
894 
895 int dsa_port_vlan_del(struct dsa_port *dp,
896 		      const struct switchdev_obj_port_vlan *vlan)
897 {
898 	struct dsa_notifier_vlan_info info = {
899 		.sw_index = dp->ds->index,
900 		.port = dp->index,
901 		.vlan = vlan,
902 	};
903 
904 	return dsa_port_notify(dp, DSA_NOTIFIER_VLAN_DEL, &info);
905 }
906 
907 int dsa_port_mrp_add(const struct dsa_port *dp,
908 		     const struct switchdev_obj_mrp *mrp)
909 {
910 	struct dsa_notifier_mrp_info info = {
911 		.sw_index = dp->ds->index,
912 		.port = dp->index,
913 		.mrp = mrp,
914 	};
915 
916 	return dsa_port_notify(dp, DSA_NOTIFIER_MRP_ADD, &info);
917 }
918 
919 int dsa_port_mrp_del(const struct dsa_port *dp,
920 		     const struct switchdev_obj_mrp *mrp)
921 {
922 	struct dsa_notifier_mrp_info info = {
923 		.sw_index = dp->ds->index,
924 		.port = dp->index,
925 		.mrp = mrp,
926 	};
927 
928 	return dsa_port_notify(dp, DSA_NOTIFIER_MRP_DEL, &info);
929 }
930 
931 int dsa_port_mrp_add_ring_role(const struct dsa_port *dp,
932 			       const struct switchdev_obj_ring_role_mrp *mrp)
933 {
934 	struct dsa_notifier_mrp_ring_role_info info = {
935 		.sw_index = dp->ds->index,
936 		.port = dp->index,
937 		.mrp = mrp,
938 	};
939 
940 	return dsa_port_notify(dp, DSA_NOTIFIER_MRP_ADD_RING_ROLE, &info);
941 }
942 
943 int dsa_port_mrp_del_ring_role(const struct dsa_port *dp,
944 			       const struct switchdev_obj_ring_role_mrp *mrp)
945 {
946 	struct dsa_notifier_mrp_ring_role_info info = {
947 		.sw_index = dp->ds->index,
948 		.port = dp->index,
949 		.mrp = mrp,
950 	};
951 
952 	return dsa_port_notify(dp, DSA_NOTIFIER_MRP_DEL_RING_ROLE, &info);
953 }
954 
955 void dsa_port_set_tag_protocol(struct dsa_port *cpu_dp,
956 			       const struct dsa_device_ops *tag_ops)
957 {
958 	cpu_dp->rcv = tag_ops->rcv;
959 	cpu_dp->tag_ops = tag_ops;
960 }
961 
962 static struct phy_device *dsa_port_get_phy_device(struct dsa_port *dp)
963 {
964 	struct device_node *phy_dn;
965 	struct phy_device *phydev;
966 
967 	phy_dn = of_parse_phandle(dp->dn, "phy-handle", 0);
968 	if (!phy_dn)
969 		return NULL;
970 
971 	phydev = of_phy_find_device(phy_dn);
972 	if (!phydev) {
973 		of_node_put(phy_dn);
974 		return ERR_PTR(-EPROBE_DEFER);
975 	}
976 
977 	of_node_put(phy_dn);
978 	return phydev;
979 }
980 
981 static void dsa_port_phylink_validate(struct phylink_config *config,
982 				      unsigned long *supported,
983 				      struct phylink_link_state *state)
984 {
985 	struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
986 	struct dsa_switch *ds = dp->ds;
987 
988 	if (!ds->ops->phylink_validate) {
989 		if (config->mac_capabilities)
990 			phylink_generic_validate(config, supported, state);
991 		return;
992 	}
993 
994 	ds->ops->phylink_validate(ds, dp->index, supported, state);
995 }
996 
997 static void dsa_port_phylink_mac_pcs_get_state(struct phylink_config *config,
998 					       struct phylink_link_state *state)
999 {
1000 	struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
1001 	struct dsa_switch *ds = dp->ds;
1002 	int err;
1003 
1004 	/* Only called for inband modes */
1005 	if (!ds->ops->phylink_mac_link_state) {
1006 		state->link = 0;
1007 		return;
1008 	}
1009 
1010 	err = ds->ops->phylink_mac_link_state(ds, dp->index, state);
1011 	if (err < 0) {
1012 		dev_err(ds->dev, "p%d: phylink_mac_link_state() failed: %d\n",
1013 			dp->index, err);
1014 		state->link = 0;
1015 	}
1016 }
1017 
1018 static void dsa_port_phylink_mac_config(struct phylink_config *config,
1019 					unsigned int mode,
1020 					const struct phylink_link_state *state)
1021 {
1022 	struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
1023 	struct dsa_switch *ds = dp->ds;
1024 
1025 	if (!ds->ops->phylink_mac_config)
1026 		return;
1027 
1028 	ds->ops->phylink_mac_config(ds, dp->index, mode, state);
1029 }
1030 
1031 static void dsa_port_phylink_mac_an_restart(struct phylink_config *config)
1032 {
1033 	struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
1034 	struct dsa_switch *ds = dp->ds;
1035 
1036 	if (!ds->ops->phylink_mac_an_restart)
1037 		return;
1038 
1039 	ds->ops->phylink_mac_an_restart(ds, dp->index);
1040 }
1041 
1042 static void dsa_port_phylink_mac_link_down(struct phylink_config *config,
1043 					   unsigned int mode,
1044 					   phy_interface_t interface)
1045 {
1046 	struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
1047 	struct phy_device *phydev = NULL;
1048 	struct dsa_switch *ds = dp->ds;
1049 
1050 	if (dsa_port_is_user(dp))
1051 		phydev = dp->slave->phydev;
1052 
1053 	if (!ds->ops->phylink_mac_link_down) {
1054 		if (ds->ops->adjust_link && phydev)
1055 			ds->ops->adjust_link(ds, dp->index, phydev);
1056 		return;
1057 	}
1058 
1059 	ds->ops->phylink_mac_link_down(ds, dp->index, mode, interface);
1060 }
1061 
1062 static void dsa_port_phylink_mac_link_up(struct phylink_config *config,
1063 					 struct phy_device *phydev,
1064 					 unsigned int mode,
1065 					 phy_interface_t interface,
1066 					 int speed, int duplex,
1067 					 bool tx_pause, bool rx_pause)
1068 {
1069 	struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
1070 	struct dsa_switch *ds = dp->ds;
1071 
1072 	if (!ds->ops->phylink_mac_link_up) {
1073 		if (ds->ops->adjust_link && phydev)
1074 			ds->ops->adjust_link(ds, dp->index, phydev);
1075 		return;
1076 	}
1077 
1078 	ds->ops->phylink_mac_link_up(ds, dp->index, mode, interface, phydev,
1079 				     speed, duplex, tx_pause, rx_pause);
1080 }
1081 
1082 static const struct phylink_mac_ops dsa_port_phylink_mac_ops = {
1083 	.validate = dsa_port_phylink_validate,
1084 	.mac_pcs_get_state = dsa_port_phylink_mac_pcs_get_state,
1085 	.mac_config = dsa_port_phylink_mac_config,
1086 	.mac_an_restart = dsa_port_phylink_mac_an_restart,
1087 	.mac_link_down = dsa_port_phylink_mac_link_down,
1088 	.mac_link_up = dsa_port_phylink_mac_link_up,
1089 };
1090 
1091 int dsa_port_phylink_create(struct dsa_port *dp)
1092 {
1093 	struct dsa_switch *ds = dp->ds;
1094 	phy_interface_t mode;
1095 	int err;
1096 
1097 	err = of_get_phy_mode(dp->dn, &mode);
1098 	if (err)
1099 		mode = PHY_INTERFACE_MODE_NA;
1100 
1101 	/* Presence of phylink_mac_link_state or phylink_mac_an_restart is
1102 	 * an indicator of a legacy phylink driver.
1103 	 */
1104 	if (ds->ops->phylink_mac_link_state ||
1105 	    ds->ops->phylink_mac_an_restart)
1106 		dp->pl_config.legacy_pre_march2020 = true;
1107 
1108 	if (ds->ops->phylink_get_caps)
1109 		ds->ops->phylink_get_caps(ds, dp->index, &dp->pl_config);
1110 
1111 	dp->pl = phylink_create(&dp->pl_config, of_fwnode_handle(dp->dn),
1112 				mode, &dsa_port_phylink_mac_ops);
1113 	if (IS_ERR(dp->pl)) {
1114 		pr_err("error creating PHYLINK: %ld\n", PTR_ERR(dp->pl));
1115 		return PTR_ERR(dp->pl);
1116 	}
1117 
1118 	return 0;
1119 }
1120 
1121 static int dsa_port_setup_phy_of(struct dsa_port *dp, bool enable)
1122 {
1123 	struct dsa_switch *ds = dp->ds;
1124 	struct phy_device *phydev;
1125 	int port = dp->index;
1126 	int err = 0;
1127 
1128 	phydev = dsa_port_get_phy_device(dp);
1129 	if (!phydev)
1130 		return 0;
1131 
1132 	if (IS_ERR(phydev))
1133 		return PTR_ERR(phydev);
1134 
1135 	if (enable) {
1136 		err = genphy_resume(phydev);
1137 		if (err < 0)
1138 			goto err_put_dev;
1139 
1140 		err = genphy_read_status(phydev);
1141 		if (err < 0)
1142 			goto err_put_dev;
1143 	} else {
1144 		err = genphy_suspend(phydev);
1145 		if (err < 0)
1146 			goto err_put_dev;
1147 	}
1148 
1149 	if (ds->ops->adjust_link)
1150 		ds->ops->adjust_link(ds, port, phydev);
1151 
1152 	dev_dbg(ds->dev, "enabled port's phy: %s", phydev_name(phydev));
1153 
1154 err_put_dev:
1155 	put_device(&phydev->mdio.dev);
1156 	return err;
1157 }
1158 
1159 static int dsa_port_fixed_link_register_of(struct dsa_port *dp)
1160 {
1161 	struct device_node *dn = dp->dn;
1162 	struct dsa_switch *ds = dp->ds;
1163 	struct phy_device *phydev;
1164 	int port = dp->index;
1165 	phy_interface_t mode;
1166 	int err;
1167 
1168 	err = of_phy_register_fixed_link(dn);
1169 	if (err) {
1170 		dev_err(ds->dev,
1171 			"failed to register the fixed PHY of port %d\n",
1172 			port);
1173 		return err;
1174 	}
1175 
1176 	phydev = of_phy_find_device(dn);
1177 
1178 	err = of_get_phy_mode(dn, &mode);
1179 	if (err)
1180 		mode = PHY_INTERFACE_MODE_NA;
1181 	phydev->interface = mode;
1182 
1183 	genphy_read_status(phydev);
1184 
1185 	if (ds->ops->adjust_link)
1186 		ds->ops->adjust_link(ds, port, phydev);
1187 
1188 	put_device(&phydev->mdio.dev);
1189 
1190 	return 0;
1191 }
1192 
1193 static int dsa_port_phylink_register(struct dsa_port *dp)
1194 {
1195 	struct dsa_switch *ds = dp->ds;
1196 	struct device_node *port_dn = dp->dn;
1197 	int err;
1198 
1199 	dp->pl_config.dev = ds->dev;
1200 	dp->pl_config.type = PHYLINK_DEV;
1201 	dp->pl_config.pcs_poll = ds->pcs_poll;
1202 
1203 	err = dsa_port_phylink_create(dp);
1204 	if (err)
1205 		return err;
1206 
1207 	err = phylink_of_phy_connect(dp->pl, port_dn, 0);
1208 	if (err && err != -ENODEV) {
1209 		pr_err("could not attach to PHY: %d\n", err);
1210 		goto err_phy_connect;
1211 	}
1212 
1213 	return 0;
1214 
1215 err_phy_connect:
1216 	phylink_destroy(dp->pl);
1217 	return err;
1218 }
1219 
1220 int dsa_port_link_register_of(struct dsa_port *dp)
1221 {
1222 	struct dsa_switch *ds = dp->ds;
1223 	struct device_node *phy_np;
1224 	int port = dp->index;
1225 
1226 	if (!ds->ops->adjust_link) {
1227 		phy_np = of_parse_phandle(dp->dn, "phy-handle", 0);
1228 		if (of_phy_is_fixed_link(dp->dn) || phy_np) {
1229 			if (ds->ops->phylink_mac_link_down)
1230 				ds->ops->phylink_mac_link_down(ds, port,
1231 					MLO_AN_FIXED, PHY_INTERFACE_MODE_NA);
1232 			return dsa_port_phylink_register(dp);
1233 		}
1234 		return 0;
1235 	}
1236 
1237 	dev_warn(ds->dev,
1238 		 "Using legacy PHYLIB callbacks. Please migrate to PHYLINK!\n");
1239 
1240 	if (of_phy_is_fixed_link(dp->dn))
1241 		return dsa_port_fixed_link_register_of(dp);
1242 	else
1243 		return dsa_port_setup_phy_of(dp, true);
1244 }
1245 
1246 void dsa_port_link_unregister_of(struct dsa_port *dp)
1247 {
1248 	struct dsa_switch *ds = dp->ds;
1249 
1250 	if (!ds->ops->adjust_link && dp->pl) {
1251 		rtnl_lock();
1252 		phylink_disconnect_phy(dp->pl);
1253 		rtnl_unlock();
1254 		phylink_destroy(dp->pl);
1255 		dp->pl = NULL;
1256 		return;
1257 	}
1258 
1259 	if (of_phy_is_fixed_link(dp->dn))
1260 		of_phy_deregister_fixed_link(dp->dn);
1261 	else
1262 		dsa_port_setup_phy_of(dp, false);
1263 }
1264 
1265 int dsa_port_get_phy_strings(struct dsa_port *dp, uint8_t *data)
1266 {
1267 	struct phy_device *phydev;
1268 	int ret = -EOPNOTSUPP;
1269 
1270 	if (of_phy_is_fixed_link(dp->dn))
1271 		return ret;
1272 
1273 	phydev = dsa_port_get_phy_device(dp);
1274 	if (IS_ERR_OR_NULL(phydev))
1275 		return ret;
1276 
1277 	ret = phy_ethtool_get_strings(phydev, data);
1278 	put_device(&phydev->mdio.dev);
1279 
1280 	return ret;
1281 }
1282 EXPORT_SYMBOL_GPL(dsa_port_get_phy_strings);
1283 
1284 int dsa_port_get_ethtool_phy_stats(struct dsa_port *dp, uint64_t *data)
1285 {
1286 	struct phy_device *phydev;
1287 	int ret = -EOPNOTSUPP;
1288 
1289 	if (of_phy_is_fixed_link(dp->dn))
1290 		return ret;
1291 
1292 	phydev = dsa_port_get_phy_device(dp);
1293 	if (IS_ERR_OR_NULL(phydev))
1294 		return ret;
1295 
1296 	ret = phy_ethtool_get_stats(phydev, NULL, data);
1297 	put_device(&phydev->mdio.dev);
1298 
1299 	return ret;
1300 }
1301 EXPORT_SYMBOL_GPL(dsa_port_get_ethtool_phy_stats);
1302 
1303 int dsa_port_get_phy_sset_count(struct dsa_port *dp)
1304 {
1305 	struct phy_device *phydev;
1306 	int ret = -EOPNOTSUPP;
1307 
1308 	if (of_phy_is_fixed_link(dp->dn))
1309 		return ret;
1310 
1311 	phydev = dsa_port_get_phy_device(dp);
1312 	if (IS_ERR_OR_NULL(phydev))
1313 		return ret;
1314 
1315 	ret = phy_ethtool_get_sset_count(phydev);
1316 	put_device(&phydev->mdio.dev);
1317 
1318 	return ret;
1319 }
1320 EXPORT_SYMBOL_GPL(dsa_port_get_phy_sset_count);
1321 
1322 int dsa_port_hsr_join(struct dsa_port *dp, struct net_device *hsr)
1323 {
1324 	struct dsa_notifier_hsr_info info = {
1325 		.sw_index = dp->ds->index,
1326 		.port = dp->index,
1327 		.hsr = hsr,
1328 	};
1329 	int err;
1330 
1331 	dp->hsr_dev = hsr;
1332 
1333 	err = dsa_port_notify(dp, DSA_NOTIFIER_HSR_JOIN, &info);
1334 	if (err)
1335 		dp->hsr_dev = NULL;
1336 
1337 	return err;
1338 }
1339 
1340 void dsa_port_hsr_leave(struct dsa_port *dp, struct net_device *hsr)
1341 {
1342 	struct dsa_notifier_hsr_info info = {
1343 		.sw_index = dp->ds->index,
1344 		.port = dp->index,
1345 		.hsr = hsr,
1346 	};
1347 	int err;
1348 
1349 	dp->hsr_dev = NULL;
1350 
1351 	err = dsa_port_notify(dp, DSA_NOTIFIER_HSR_LEAVE, &info);
1352 	if (err)
1353 		dev_err(dp->ds->dev,
1354 			"port %d failed to notify DSA_NOTIFIER_HSR_LEAVE: %pe\n",
1355 			dp->index, ERR_PTR(err));
1356 }
1357 
1358 int dsa_port_tag_8021q_vlan_add(struct dsa_port *dp, u16 vid, bool broadcast)
1359 {
1360 	struct dsa_notifier_tag_8021q_vlan_info info = {
1361 		.tree_index = dp->ds->dst->index,
1362 		.sw_index = dp->ds->index,
1363 		.port = dp->index,
1364 		.vid = vid,
1365 	};
1366 
1367 	if (broadcast)
1368 		return dsa_broadcast(DSA_NOTIFIER_TAG_8021Q_VLAN_ADD, &info);
1369 
1370 	return dsa_port_notify(dp, DSA_NOTIFIER_TAG_8021Q_VLAN_ADD, &info);
1371 }
1372 
1373 void dsa_port_tag_8021q_vlan_del(struct dsa_port *dp, u16 vid, bool broadcast)
1374 {
1375 	struct dsa_notifier_tag_8021q_vlan_info info = {
1376 		.tree_index = dp->ds->dst->index,
1377 		.sw_index = dp->ds->index,
1378 		.port = dp->index,
1379 		.vid = vid,
1380 	};
1381 	int err;
1382 
1383 	if (broadcast)
1384 		err = dsa_broadcast(DSA_NOTIFIER_TAG_8021Q_VLAN_DEL, &info);
1385 	else
1386 		err = dsa_port_notify(dp, DSA_NOTIFIER_TAG_8021Q_VLAN_DEL, &info);
1387 	if (err)
1388 		dev_err(dp->ds->dev,
1389 			"port %d failed to notify tag_8021q VLAN %d deletion: %pe\n",
1390 			dp->index, vid, ERR_PTR(err));
1391 }
1392