xref: /linux/net/dsa/port.c (revision 7996acffd7cc83504eb300e791c80ac9c7f7e893)
1 // SPDX-License-Identifier: GPL-2.0-or-later
2 /*
3  * Handling of a single switch port
4  *
5  * Copyright (c) 2017 Savoir-faire Linux Inc.
6  *	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
7  */
8 
9 #include <linux/if_bridge.h>
10 #include <linux/notifier.h>
11 #include <linux/of_mdio.h>
12 #include <linux/of_net.h>
13 
14 #include "dsa_priv.h"
15 
16 /**
17  * dsa_port_notify - Notify the switching fabric of changes to a port
18  * @dp: port on which change occurred
19  * @e: event, must be of type DSA_NOTIFIER_*
20  * @v: event-specific value.
21  *
22  * Notify all switches in the DSA tree that this port's switch belongs to,
23  * including this switch itself, of an event. Allows the other switches to
24  * reconfigure themselves for cross-chip operations. Can also be used to
25  * reconfigure ports without net_devices (CPU ports, DSA links) whenever
26  * a user port's state changes.
27  */
28 static int dsa_port_notify(const struct dsa_port *dp, unsigned long e, void *v)
29 {
30 	return dsa_tree_notify(dp->ds->dst, e, v);
31 }
32 
33 static void dsa_port_notify_bridge_fdb_flush(const struct dsa_port *dp)
34 {
35 	struct net_device *brport_dev = dsa_port_to_bridge_port(dp);
36 	struct switchdev_notifier_fdb_info info = {
37 		/* flush all VLANs */
38 		.vid = 0,
39 	};
40 
41 	/* When the port becomes standalone it has already left the bridge.
42 	 * Don't notify the bridge in that case.
43 	 */
44 	if (!brport_dev)
45 		return;
46 
47 	call_switchdev_notifiers(SWITCHDEV_FDB_FLUSH_TO_BRIDGE,
48 				 brport_dev, &info.info, NULL);
49 }
50 
51 static void dsa_port_fast_age(const struct dsa_port *dp)
52 {
53 	struct dsa_switch *ds = dp->ds;
54 
55 	if (!ds->ops->port_fast_age)
56 		return;
57 
58 	ds->ops->port_fast_age(ds, dp->index);
59 
60 	dsa_port_notify_bridge_fdb_flush(dp);
61 }
62 
63 static bool dsa_port_can_configure_learning(struct dsa_port *dp)
64 {
65 	struct switchdev_brport_flags flags = {
66 		.mask = BR_LEARNING,
67 	};
68 	struct dsa_switch *ds = dp->ds;
69 	int err;
70 
71 	if (!ds->ops->port_bridge_flags || !ds->ops->port_pre_bridge_flags)
72 		return false;
73 
74 	err = ds->ops->port_pre_bridge_flags(ds, dp->index, flags, NULL);
75 	return !err;
76 }
77 
78 int dsa_port_set_state(struct dsa_port *dp, u8 state, bool do_fast_age)
79 {
80 	struct dsa_switch *ds = dp->ds;
81 	int port = dp->index;
82 
83 	if (!ds->ops->port_stp_state_set)
84 		return -EOPNOTSUPP;
85 
86 	ds->ops->port_stp_state_set(ds, port, state);
87 
88 	if (!dsa_port_can_configure_learning(dp) ||
89 	    (do_fast_age && dp->learning)) {
90 		/* Fast age FDB entries or flush appropriate forwarding database
91 		 * for the given port, if we are moving it from Learning or
92 		 * Forwarding state, to Disabled or Blocking or Listening state.
93 		 * Ports that were standalone before the STP state change don't
94 		 * need to fast age the FDB, since address learning is off in
95 		 * standalone mode.
96 		 */
97 
98 		if ((dp->stp_state == BR_STATE_LEARNING ||
99 		     dp->stp_state == BR_STATE_FORWARDING) &&
100 		    (state == BR_STATE_DISABLED ||
101 		     state == BR_STATE_BLOCKING ||
102 		     state == BR_STATE_LISTENING))
103 			dsa_port_fast_age(dp);
104 	}
105 
106 	dp->stp_state = state;
107 
108 	return 0;
109 }
110 
111 static void dsa_port_set_state_now(struct dsa_port *dp, u8 state,
112 				   bool do_fast_age)
113 {
114 	int err;
115 
116 	err = dsa_port_set_state(dp, state, do_fast_age);
117 	if (err)
118 		pr_err("DSA: failed to set STP state %u (%d)\n", state, err);
119 }
120 
121 int dsa_port_enable_rt(struct dsa_port *dp, struct phy_device *phy)
122 {
123 	struct dsa_switch *ds = dp->ds;
124 	int port = dp->index;
125 	int err;
126 
127 	if (ds->ops->port_enable) {
128 		err = ds->ops->port_enable(ds, port, phy);
129 		if (err)
130 			return err;
131 	}
132 
133 	if (!dp->bridge_dev)
134 		dsa_port_set_state_now(dp, BR_STATE_FORWARDING, false);
135 
136 	if (dp->pl)
137 		phylink_start(dp->pl);
138 
139 	return 0;
140 }
141 
142 int dsa_port_enable(struct dsa_port *dp, struct phy_device *phy)
143 {
144 	int err;
145 
146 	rtnl_lock();
147 	err = dsa_port_enable_rt(dp, phy);
148 	rtnl_unlock();
149 
150 	return err;
151 }
152 
153 void dsa_port_disable_rt(struct dsa_port *dp)
154 {
155 	struct dsa_switch *ds = dp->ds;
156 	int port = dp->index;
157 
158 	if (dp->pl)
159 		phylink_stop(dp->pl);
160 
161 	if (!dp->bridge_dev)
162 		dsa_port_set_state_now(dp, BR_STATE_DISABLED, false);
163 
164 	if (ds->ops->port_disable)
165 		ds->ops->port_disable(ds, port);
166 }
167 
168 void dsa_port_disable(struct dsa_port *dp)
169 {
170 	rtnl_lock();
171 	dsa_port_disable_rt(dp);
172 	rtnl_unlock();
173 }
174 
175 static int dsa_port_inherit_brport_flags(struct dsa_port *dp,
176 					 struct netlink_ext_ack *extack)
177 {
178 	const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD |
179 				   BR_BCAST_FLOOD;
180 	struct net_device *brport_dev = dsa_port_to_bridge_port(dp);
181 	int flag, err;
182 
183 	for_each_set_bit(flag, &mask, 32) {
184 		struct switchdev_brport_flags flags = {0};
185 
186 		flags.mask = BIT(flag);
187 
188 		if (br_port_flag_is_set(brport_dev, BIT(flag)))
189 			flags.val = BIT(flag);
190 
191 		err = dsa_port_bridge_flags(dp, flags, extack);
192 		if (err && err != -EOPNOTSUPP)
193 			return err;
194 	}
195 
196 	return 0;
197 }
198 
199 static void dsa_port_clear_brport_flags(struct dsa_port *dp)
200 {
201 	const unsigned long val = BR_FLOOD | BR_MCAST_FLOOD | BR_BCAST_FLOOD;
202 	const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD |
203 				   BR_BCAST_FLOOD;
204 	int flag, err;
205 
206 	for_each_set_bit(flag, &mask, 32) {
207 		struct switchdev_brport_flags flags = {0};
208 
209 		flags.mask = BIT(flag);
210 		flags.val = val & BIT(flag);
211 
212 		err = dsa_port_bridge_flags(dp, flags, NULL);
213 		if (err && err != -EOPNOTSUPP)
214 			dev_err(dp->ds->dev,
215 				"failed to clear bridge port flag %lu: %pe\n",
216 				flags.val, ERR_PTR(err));
217 	}
218 }
219 
220 static int dsa_port_switchdev_sync_attrs(struct dsa_port *dp,
221 					 struct netlink_ext_ack *extack)
222 {
223 	struct net_device *brport_dev = dsa_port_to_bridge_port(dp);
224 	struct net_device *br = dp->bridge_dev;
225 	int err;
226 
227 	err = dsa_port_inherit_brport_flags(dp, extack);
228 	if (err)
229 		return err;
230 
231 	err = dsa_port_set_state(dp, br_port_get_stp_state(brport_dev), false);
232 	if (err && err != -EOPNOTSUPP)
233 		return err;
234 
235 	err = dsa_port_vlan_filtering(dp, br_vlan_enabled(br), extack);
236 	if (err && err != -EOPNOTSUPP)
237 		return err;
238 
239 	err = dsa_port_ageing_time(dp, br_get_ageing_time(br));
240 	if (err && err != -EOPNOTSUPP)
241 		return err;
242 
243 	return 0;
244 }
245 
246 static void dsa_port_switchdev_unsync_attrs(struct dsa_port *dp)
247 {
248 	/* Configure the port for standalone mode (no address learning,
249 	 * flood everything).
250 	 * The bridge only emits SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS events
251 	 * when the user requests it through netlink or sysfs, but not
252 	 * automatically at port join or leave, so we need to handle resetting
253 	 * the brport flags ourselves. But we even prefer it that way, because
254 	 * otherwise, some setups might never get the notification they need,
255 	 * for example, when a port leaves a LAG that offloads the bridge,
256 	 * it becomes standalone, but as far as the bridge is concerned, no
257 	 * port ever left.
258 	 */
259 	dsa_port_clear_brport_flags(dp);
260 
261 	/* Port left the bridge, put in BR_STATE_DISABLED by the bridge layer,
262 	 * so allow it to be in BR_STATE_FORWARDING to be kept functional
263 	 */
264 	dsa_port_set_state_now(dp, BR_STATE_FORWARDING, true);
265 
266 	/* VLAN filtering is handled by dsa_switch_bridge_leave */
267 
268 	/* Ageing time may be global to the switch chip, so don't change it
269 	 * here because we have no good reason (or value) to change it to.
270 	 */
271 }
272 
273 static void dsa_port_bridge_tx_fwd_unoffload(struct dsa_port *dp,
274 					     struct net_device *bridge_dev)
275 {
276 	int bridge_num = dp->bridge_num;
277 	struct dsa_switch *ds = dp->ds;
278 
279 	/* No bridge TX forwarding offload => do nothing */
280 	if (!ds->ops->port_bridge_tx_fwd_unoffload || dp->bridge_num == -1)
281 		return;
282 
283 	dp->bridge_num = -1;
284 
285 	dsa_bridge_num_put(bridge_dev, bridge_num);
286 
287 	/* Notify the chips only once the offload has been deactivated, so
288 	 * that they can update their configuration accordingly.
289 	 */
290 	ds->ops->port_bridge_tx_fwd_unoffload(ds, dp->index, bridge_dev,
291 					      bridge_num);
292 }
293 
294 static bool dsa_port_bridge_tx_fwd_offload(struct dsa_port *dp,
295 					   struct net_device *bridge_dev)
296 {
297 	struct dsa_switch *ds = dp->ds;
298 	int bridge_num, err;
299 
300 	if (!ds->ops->port_bridge_tx_fwd_offload)
301 		return false;
302 
303 	bridge_num = dsa_bridge_num_get(bridge_dev,
304 					ds->num_fwd_offloading_bridges);
305 	if (bridge_num < 0)
306 		return false;
307 
308 	dp->bridge_num = bridge_num;
309 
310 	/* Notify the driver */
311 	err = ds->ops->port_bridge_tx_fwd_offload(ds, dp->index, bridge_dev,
312 						  bridge_num);
313 	if (err) {
314 		dsa_port_bridge_tx_fwd_unoffload(dp, bridge_dev);
315 		return false;
316 	}
317 
318 	return true;
319 }
320 
321 int dsa_port_bridge_join(struct dsa_port *dp, struct net_device *br,
322 			 struct netlink_ext_ack *extack)
323 {
324 	struct dsa_notifier_bridge_info info = {
325 		.tree_index = dp->ds->dst->index,
326 		.sw_index = dp->ds->index,
327 		.port = dp->index,
328 		.br = br,
329 	};
330 	struct net_device *dev = dp->slave;
331 	struct net_device *brport_dev;
332 	bool tx_fwd_offload;
333 	int err;
334 
335 	/* Here the interface is already bridged. Reflect the current
336 	 * configuration so that drivers can program their chips accordingly.
337 	 */
338 	dp->bridge_dev = br;
339 
340 	brport_dev = dsa_port_to_bridge_port(dp);
341 
342 	err = dsa_broadcast(DSA_NOTIFIER_BRIDGE_JOIN, &info);
343 	if (err)
344 		goto out_rollback;
345 
346 	tx_fwd_offload = dsa_port_bridge_tx_fwd_offload(dp, br);
347 
348 	err = switchdev_bridge_port_offload(brport_dev, dev, dp,
349 					    &dsa_slave_switchdev_notifier,
350 					    &dsa_slave_switchdev_blocking_notifier,
351 					    tx_fwd_offload, extack);
352 	if (err)
353 		goto out_rollback_unbridge;
354 
355 	err = dsa_port_switchdev_sync_attrs(dp, extack);
356 	if (err)
357 		goto out_rollback_unoffload;
358 
359 	return 0;
360 
361 out_rollback_unoffload:
362 	switchdev_bridge_port_unoffload(brport_dev, dp,
363 					&dsa_slave_switchdev_notifier,
364 					&dsa_slave_switchdev_blocking_notifier);
365 out_rollback_unbridge:
366 	dsa_broadcast(DSA_NOTIFIER_BRIDGE_LEAVE, &info);
367 out_rollback:
368 	dp->bridge_dev = NULL;
369 	return err;
370 }
371 
372 void dsa_port_pre_bridge_leave(struct dsa_port *dp, struct net_device *br)
373 {
374 	struct net_device *brport_dev = dsa_port_to_bridge_port(dp);
375 
376 	/* Don't try to unoffload something that is not offloaded */
377 	if (!brport_dev)
378 		return;
379 
380 	switchdev_bridge_port_unoffload(brport_dev, dp,
381 					&dsa_slave_switchdev_notifier,
382 					&dsa_slave_switchdev_blocking_notifier);
383 }
384 
385 void dsa_port_bridge_leave(struct dsa_port *dp, struct net_device *br)
386 {
387 	struct dsa_notifier_bridge_info info = {
388 		.tree_index = dp->ds->dst->index,
389 		.sw_index = dp->ds->index,
390 		.port = dp->index,
391 		.br = br,
392 	};
393 	int err;
394 
395 	/* Here the port is already unbridged. Reflect the current configuration
396 	 * so that drivers can program their chips accordingly.
397 	 */
398 	dp->bridge_dev = NULL;
399 
400 	dsa_port_bridge_tx_fwd_unoffload(dp, br);
401 
402 	err = dsa_broadcast(DSA_NOTIFIER_BRIDGE_LEAVE, &info);
403 	if (err)
404 		dev_err(dp->ds->dev,
405 			"port %d failed to notify DSA_NOTIFIER_BRIDGE_LEAVE: %pe\n",
406 			dp->index, ERR_PTR(err));
407 
408 	dsa_port_switchdev_unsync_attrs(dp);
409 }
410 
411 int dsa_port_lag_change(struct dsa_port *dp,
412 			struct netdev_lag_lower_state_info *linfo)
413 {
414 	struct dsa_notifier_lag_info info = {
415 		.sw_index = dp->ds->index,
416 		.port = dp->index,
417 	};
418 	bool tx_enabled;
419 
420 	if (!dp->lag_dev)
421 		return 0;
422 
423 	/* On statically configured aggregates (e.g. loadbalance
424 	 * without LACP) ports will always be tx_enabled, even if the
425 	 * link is down. Thus we require both link_up and tx_enabled
426 	 * in order to include it in the tx set.
427 	 */
428 	tx_enabled = linfo->link_up && linfo->tx_enabled;
429 
430 	if (tx_enabled == dp->lag_tx_enabled)
431 		return 0;
432 
433 	dp->lag_tx_enabled = tx_enabled;
434 
435 	return dsa_port_notify(dp, DSA_NOTIFIER_LAG_CHANGE, &info);
436 }
437 
438 int dsa_port_lag_join(struct dsa_port *dp, struct net_device *lag,
439 		      struct netdev_lag_upper_info *uinfo,
440 		      struct netlink_ext_ack *extack)
441 {
442 	struct dsa_notifier_lag_info info = {
443 		.sw_index = dp->ds->index,
444 		.port = dp->index,
445 		.lag = lag,
446 		.info = uinfo,
447 	};
448 	struct net_device *bridge_dev;
449 	int err;
450 
451 	dsa_lag_map(dp->ds->dst, lag);
452 	dp->lag_dev = lag;
453 
454 	err = dsa_port_notify(dp, DSA_NOTIFIER_LAG_JOIN, &info);
455 	if (err)
456 		goto err_lag_join;
457 
458 	bridge_dev = netdev_master_upper_dev_get(lag);
459 	if (!bridge_dev || !netif_is_bridge_master(bridge_dev))
460 		return 0;
461 
462 	err = dsa_port_bridge_join(dp, bridge_dev, extack);
463 	if (err)
464 		goto err_bridge_join;
465 
466 	return 0;
467 
468 err_bridge_join:
469 	dsa_port_notify(dp, DSA_NOTIFIER_LAG_LEAVE, &info);
470 err_lag_join:
471 	dp->lag_dev = NULL;
472 	dsa_lag_unmap(dp->ds->dst, lag);
473 	return err;
474 }
475 
476 void dsa_port_pre_lag_leave(struct dsa_port *dp, struct net_device *lag)
477 {
478 	if (dp->bridge_dev)
479 		dsa_port_pre_bridge_leave(dp, dp->bridge_dev);
480 }
481 
482 void dsa_port_lag_leave(struct dsa_port *dp, struct net_device *lag)
483 {
484 	struct dsa_notifier_lag_info info = {
485 		.sw_index = dp->ds->index,
486 		.port = dp->index,
487 		.lag = lag,
488 	};
489 	int err;
490 
491 	if (!dp->lag_dev)
492 		return;
493 
494 	/* Port might have been part of a LAG that in turn was
495 	 * attached to a bridge.
496 	 */
497 	if (dp->bridge_dev)
498 		dsa_port_bridge_leave(dp, dp->bridge_dev);
499 
500 	dp->lag_tx_enabled = false;
501 	dp->lag_dev = NULL;
502 
503 	err = dsa_port_notify(dp, DSA_NOTIFIER_LAG_LEAVE, &info);
504 	if (err)
505 		dev_err(dp->ds->dev,
506 			"port %d failed to notify DSA_NOTIFIER_LAG_LEAVE: %pe\n",
507 			dp->index, ERR_PTR(err));
508 
509 	dsa_lag_unmap(dp->ds->dst, lag);
510 }
511 
512 /* Must be called under rcu_read_lock() */
513 static bool dsa_port_can_apply_vlan_filtering(struct dsa_port *dp,
514 					      bool vlan_filtering,
515 					      struct netlink_ext_ack *extack)
516 {
517 	struct dsa_switch *ds = dp->ds;
518 	struct dsa_port *other_dp;
519 	int err;
520 
521 	/* VLAN awareness was off, so the question is "can we turn it on".
522 	 * We may have had 8021q uppers, those need to go. Make sure we don't
523 	 * enter an inconsistent state: deny changing the VLAN awareness state
524 	 * as long as we have 8021q uppers.
525 	 */
526 	if (vlan_filtering && dsa_port_is_user(dp)) {
527 		struct net_device *upper_dev, *slave = dp->slave;
528 		struct net_device *br = dp->bridge_dev;
529 		struct list_head *iter;
530 
531 		netdev_for_each_upper_dev_rcu(slave, upper_dev, iter) {
532 			struct bridge_vlan_info br_info;
533 			u16 vid;
534 
535 			if (!is_vlan_dev(upper_dev))
536 				continue;
537 
538 			vid = vlan_dev_vlan_id(upper_dev);
539 
540 			/* br_vlan_get_info() returns -EINVAL or -ENOENT if the
541 			 * device, respectively the VID is not found, returning
542 			 * 0 means success, which is a failure for us here.
543 			 */
544 			err = br_vlan_get_info(br, vid, &br_info);
545 			if (err == 0) {
546 				NL_SET_ERR_MSG_MOD(extack,
547 						   "Must first remove VLAN uppers having VIDs also present in bridge");
548 				return false;
549 			}
550 		}
551 	}
552 
553 	if (!ds->vlan_filtering_is_global)
554 		return true;
555 
556 	/* For cases where enabling/disabling VLAN awareness is global to the
557 	 * switch, we need to handle the case where multiple bridges span
558 	 * different ports of the same switch device and one of them has a
559 	 * different setting than what is being requested.
560 	 */
561 	dsa_switch_for_each_port(other_dp, ds) {
562 		struct net_device *other_bridge;
563 
564 		other_bridge = other_dp->bridge_dev;
565 		if (!other_bridge)
566 			continue;
567 		/* If it's the same bridge, it also has same
568 		 * vlan_filtering setting => no need to check
569 		 */
570 		if (other_bridge == dp->bridge_dev)
571 			continue;
572 		if (br_vlan_enabled(other_bridge) != vlan_filtering) {
573 			NL_SET_ERR_MSG_MOD(extack,
574 					   "VLAN filtering is a global setting");
575 			return false;
576 		}
577 	}
578 	return true;
579 }
580 
581 int dsa_port_vlan_filtering(struct dsa_port *dp, bool vlan_filtering,
582 			    struct netlink_ext_ack *extack)
583 {
584 	bool old_vlan_filtering = dsa_port_is_vlan_filtering(dp);
585 	struct dsa_switch *ds = dp->ds;
586 	bool apply;
587 	int err;
588 
589 	if (!ds->ops->port_vlan_filtering)
590 		return -EOPNOTSUPP;
591 
592 	/* We are called from dsa_slave_switchdev_blocking_event(),
593 	 * which is not under rcu_read_lock(), unlike
594 	 * dsa_slave_switchdev_event().
595 	 */
596 	rcu_read_lock();
597 	apply = dsa_port_can_apply_vlan_filtering(dp, vlan_filtering, extack);
598 	rcu_read_unlock();
599 	if (!apply)
600 		return -EINVAL;
601 
602 	if (dsa_port_is_vlan_filtering(dp) == vlan_filtering)
603 		return 0;
604 
605 	err = ds->ops->port_vlan_filtering(ds, dp->index, vlan_filtering,
606 					   extack);
607 	if (err)
608 		return err;
609 
610 	if (ds->vlan_filtering_is_global) {
611 		struct dsa_port *other_dp;
612 
613 		ds->vlan_filtering = vlan_filtering;
614 
615 		dsa_switch_for_each_user_port(other_dp, ds) {
616 			struct net_device *slave = dp->slave;
617 
618 			/* We might be called in the unbind path, so not
619 			 * all slave devices might still be registered.
620 			 */
621 			if (!slave)
622 				continue;
623 
624 			err = dsa_slave_manage_vlan_filtering(slave,
625 							      vlan_filtering);
626 			if (err)
627 				goto restore;
628 		}
629 	} else {
630 		dp->vlan_filtering = vlan_filtering;
631 
632 		err = dsa_slave_manage_vlan_filtering(dp->slave,
633 						      vlan_filtering);
634 		if (err)
635 			goto restore;
636 	}
637 
638 	return 0;
639 
640 restore:
641 	ds->ops->port_vlan_filtering(ds, dp->index, old_vlan_filtering, NULL);
642 
643 	if (ds->vlan_filtering_is_global)
644 		ds->vlan_filtering = old_vlan_filtering;
645 	else
646 		dp->vlan_filtering = old_vlan_filtering;
647 
648 	return err;
649 }
650 
651 /* This enforces legacy behavior for switch drivers which assume they can't
652  * receive VLAN configuration when enslaved to a bridge with vlan_filtering=0
653  */
654 bool dsa_port_skip_vlan_configuration(struct dsa_port *dp)
655 {
656 	struct dsa_switch *ds = dp->ds;
657 
658 	if (!dp->bridge_dev)
659 		return false;
660 
661 	return (!ds->configure_vlan_while_not_filtering &&
662 		!br_vlan_enabled(dp->bridge_dev));
663 }
664 
665 int dsa_port_ageing_time(struct dsa_port *dp, clock_t ageing_clock)
666 {
667 	unsigned long ageing_jiffies = clock_t_to_jiffies(ageing_clock);
668 	unsigned int ageing_time = jiffies_to_msecs(ageing_jiffies);
669 	struct dsa_notifier_ageing_time_info info;
670 	int err;
671 
672 	info.ageing_time = ageing_time;
673 
674 	err = dsa_port_notify(dp, DSA_NOTIFIER_AGEING_TIME, &info);
675 	if (err)
676 		return err;
677 
678 	dp->ageing_time = ageing_time;
679 
680 	return 0;
681 }
682 
683 int dsa_port_pre_bridge_flags(const struct dsa_port *dp,
684 			      struct switchdev_brport_flags flags,
685 			      struct netlink_ext_ack *extack)
686 {
687 	struct dsa_switch *ds = dp->ds;
688 
689 	if (!ds->ops->port_pre_bridge_flags)
690 		return -EINVAL;
691 
692 	return ds->ops->port_pre_bridge_flags(ds, dp->index, flags, extack);
693 }
694 
695 int dsa_port_bridge_flags(struct dsa_port *dp,
696 			  struct switchdev_brport_flags flags,
697 			  struct netlink_ext_ack *extack)
698 {
699 	struct dsa_switch *ds = dp->ds;
700 	int err;
701 
702 	if (!ds->ops->port_bridge_flags)
703 		return -EOPNOTSUPP;
704 
705 	err = ds->ops->port_bridge_flags(ds, dp->index, flags, extack);
706 	if (err)
707 		return err;
708 
709 	if (flags.mask & BR_LEARNING) {
710 		bool learning = flags.val & BR_LEARNING;
711 
712 		if (learning == dp->learning)
713 			return 0;
714 
715 		if ((dp->learning && !learning) &&
716 		    (dp->stp_state == BR_STATE_LEARNING ||
717 		     dp->stp_state == BR_STATE_FORWARDING))
718 			dsa_port_fast_age(dp);
719 
720 		dp->learning = learning;
721 	}
722 
723 	return 0;
724 }
725 
726 int dsa_port_mtu_change(struct dsa_port *dp, int new_mtu,
727 			bool targeted_match)
728 {
729 	struct dsa_notifier_mtu_info info = {
730 		.sw_index = dp->ds->index,
731 		.targeted_match = targeted_match,
732 		.port = dp->index,
733 		.mtu = new_mtu,
734 	};
735 
736 	return dsa_port_notify(dp, DSA_NOTIFIER_MTU, &info);
737 }
738 
739 int dsa_port_fdb_add(struct dsa_port *dp, const unsigned char *addr,
740 		     u16 vid)
741 {
742 	struct dsa_notifier_fdb_info info = {
743 		.sw_index = dp->ds->index,
744 		.port = dp->index,
745 		.addr = addr,
746 		.vid = vid,
747 	};
748 
749 	return dsa_port_notify(dp, DSA_NOTIFIER_FDB_ADD, &info);
750 }
751 
752 int dsa_port_fdb_del(struct dsa_port *dp, const unsigned char *addr,
753 		     u16 vid)
754 {
755 	struct dsa_notifier_fdb_info info = {
756 		.sw_index = dp->ds->index,
757 		.port = dp->index,
758 		.addr = addr,
759 		.vid = vid,
760 
761 	};
762 
763 	return dsa_port_notify(dp, DSA_NOTIFIER_FDB_DEL, &info);
764 }
765 
766 int dsa_port_host_fdb_add(struct dsa_port *dp, const unsigned char *addr,
767 			  u16 vid)
768 {
769 	struct dsa_notifier_fdb_info info = {
770 		.sw_index = dp->ds->index,
771 		.port = dp->index,
772 		.addr = addr,
773 		.vid = vid,
774 	};
775 	struct dsa_port *cpu_dp = dp->cpu_dp;
776 	int err;
777 
778 	err = dev_uc_add(cpu_dp->master, addr);
779 	if (err)
780 		return err;
781 
782 	return dsa_port_notify(dp, DSA_NOTIFIER_HOST_FDB_ADD, &info);
783 }
784 
785 int dsa_port_host_fdb_del(struct dsa_port *dp, const unsigned char *addr,
786 			  u16 vid)
787 {
788 	struct dsa_notifier_fdb_info info = {
789 		.sw_index = dp->ds->index,
790 		.port = dp->index,
791 		.addr = addr,
792 		.vid = vid,
793 	};
794 	struct dsa_port *cpu_dp = dp->cpu_dp;
795 	int err;
796 
797 	err = dev_uc_del(cpu_dp->master, addr);
798 	if (err)
799 		return err;
800 
801 	return dsa_port_notify(dp, DSA_NOTIFIER_HOST_FDB_DEL, &info);
802 }
803 
804 int dsa_port_fdb_dump(struct dsa_port *dp, dsa_fdb_dump_cb_t *cb, void *data)
805 {
806 	struct dsa_switch *ds = dp->ds;
807 	int port = dp->index;
808 
809 	if (!ds->ops->port_fdb_dump)
810 		return -EOPNOTSUPP;
811 
812 	return ds->ops->port_fdb_dump(ds, port, cb, data);
813 }
814 
815 int dsa_port_mdb_add(const struct dsa_port *dp,
816 		     const struct switchdev_obj_port_mdb *mdb)
817 {
818 	struct dsa_notifier_mdb_info info = {
819 		.sw_index = dp->ds->index,
820 		.port = dp->index,
821 		.mdb = mdb,
822 	};
823 
824 	return dsa_port_notify(dp, DSA_NOTIFIER_MDB_ADD, &info);
825 }
826 
827 int dsa_port_mdb_del(const struct dsa_port *dp,
828 		     const struct switchdev_obj_port_mdb *mdb)
829 {
830 	struct dsa_notifier_mdb_info info = {
831 		.sw_index = dp->ds->index,
832 		.port = dp->index,
833 		.mdb = mdb,
834 	};
835 
836 	return dsa_port_notify(dp, DSA_NOTIFIER_MDB_DEL, &info);
837 }
838 
839 int dsa_port_host_mdb_add(const struct dsa_port *dp,
840 			  const struct switchdev_obj_port_mdb *mdb)
841 {
842 	struct dsa_notifier_mdb_info info = {
843 		.sw_index = dp->ds->index,
844 		.port = dp->index,
845 		.mdb = mdb,
846 	};
847 	struct dsa_port *cpu_dp = dp->cpu_dp;
848 	int err;
849 
850 	err = dev_mc_add(cpu_dp->master, mdb->addr);
851 	if (err)
852 		return err;
853 
854 	return dsa_port_notify(dp, DSA_NOTIFIER_HOST_MDB_ADD, &info);
855 }
856 
857 int dsa_port_host_mdb_del(const struct dsa_port *dp,
858 			  const struct switchdev_obj_port_mdb *mdb)
859 {
860 	struct dsa_notifier_mdb_info info = {
861 		.sw_index = dp->ds->index,
862 		.port = dp->index,
863 		.mdb = mdb,
864 	};
865 	struct dsa_port *cpu_dp = dp->cpu_dp;
866 	int err;
867 
868 	err = dev_mc_del(cpu_dp->master, mdb->addr);
869 	if (err)
870 		return err;
871 
872 	return dsa_port_notify(dp, DSA_NOTIFIER_HOST_MDB_DEL, &info);
873 }
874 
875 int dsa_port_vlan_add(struct dsa_port *dp,
876 		      const struct switchdev_obj_port_vlan *vlan,
877 		      struct netlink_ext_ack *extack)
878 {
879 	struct dsa_notifier_vlan_info info = {
880 		.sw_index = dp->ds->index,
881 		.port = dp->index,
882 		.vlan = vlan,
883 		.extack = extack,
884 	};
885 
886 	return dsa_port_notify(dp, DSA_NOTIFIER_VLAN_ADD, &info);
887 }
888 
889 int dsa_port_vlan_del(struct dsa_port *dp,
890 		      const struct switchdev_obj_port_vlan *vlan)
891 {
892 	struct dsa_notifier_vlan_info info = {
893 		.sw_index = dp->ds->index,
894 		.port = dp->index,
895 		.vlan = vlan,
896 	};
897 
898 	return dsa_port_notify(dp, DSA_NOTIFIER_VLAN_DEL, &info);
899 }
900 
901 int dsa_port_mrp_add(const struct dsa_port *dp,
902 		     const struct switchdev_obj_mrp *mrp)
903 {
904 	struct dsa_notifier_mrp_info info = {
905 		.sw_index = dp->ds->index,
906 		.port = dp->index,
907 		.mrp = mrp,
908 	};
909 
910 	return dsa_port_notify(dp, DSA_NOTIFIER_MRP_ADD, &info);
911 }
912 
913 int dsa_port_mrp_del(const struct dsa_port *dp,
914 		     const struct switchdev_obj_mrp *mrp)
915 {
916 	struct dsa_notifier_mrp_info info = {
917 		.sw_index = dp->ds->index,
918 		.port = dp->index,
919 		.mrp = mrp,
920 	};
921 
922 	return dsa_port_notify(dp, DSA_NOTIFIER_MRP_DEL, &info);
923 }
924 
925 int dsa_port_mrp_add_ring_role(const struct dsa_port *dp,
926 			       const struct switchdev_obj_ring_role_mrp *mrp)
927 {
928 	struct dsa_notifier_mrp_ring_role_info info = {
929 		.sw_index = dp->ds->index,
930 		.port = dp->index,
931 		.mrp = mrp,
932 	};
933 
934 	return dsa_port_notify(dp, DSA_NOTIFIER_MRP_ADD_RING_ROLE, &info);
935 }
936 
937 int dsa_port_mrp_del_ring_role(const struct dsa_port *dp,
938 			       const struct switchdev_obj_ring_role_mrp *mrp)
939 {
940 	struct dsa_notifier_mrp_ring_role_info info = {
941 		.sw_index = dp->ds->index,
942 		.port = dp->index,
943 		.mrp = mrp,
944 	};
945 
946 	return dsa_port_notify(dp, DSA_NOTIFIER_MRP_DEL_RING_ROLE, &info);
947 }
948 
949 void dsa_port_set_tag_protocol(struct dsa_port *cpu_dp,
950 			       const struct dsa_device_ops *tag_ops)
951 {
952 	cpu_dp->rcv = tag_ops->rcv;
953 	cpu_dp->tag_ops = tag_ops;
954 }
955 
956 static struct phy_device *dsa_port_get_phy_device(struct dsa_port *dp)
957 {
958 	struct device_node *phy_dn;
959 	struct phy_device *phydev;
960 
961 	phy_dn = of_parse_phandle(dp->dn, "phy-handle", 0);
962 	if (!phy_dn)
963 		return NULL;
964 
965 	phydev = of_phy_find_device(phy_dn);
966 	if (!phydev) {
967 		of_node_put(phy_dn);
968 		return ERR_PTR(-EPROBE_DEFER);
969 	}
970 
971 	of_node_put(phy_dn);
972 	return phydev;
973 }
974 
975 static void dsa_port_phylink_validate(struct phylink_config *config,
976 				      unsigned long *supported,
977 				      struct phylink_link_state *state)
978 {
979 	struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
980 	struct dsa_switch *ds = dp->ds;
981 
982 	if (!ds->ops->phylink_validate)
983 		return;
984 
985 	ds->ops->phylink_validate(ds, dp->index, supported, state);
986 }
987 
988 static void dsa_port_phylink_mac_pcs_get_state(struct phylink_config *config,
989 					       struct phylink_link_state *state)
990 {
991 	struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
992 	struct dsa_switch *ds = dp->ds;
993 	int err;
994 
995 	/* Only called for inband modes */
996 	if (!ds->ops->phylink_mac_link_state) {
997 		state->link = 0;
998 		return;
999 	}
1000 
1001 	err = ds->ops->phylink_mac_link_state(ds, dp->index, state);
1002 	if (err < 0) {
1003 		dev_err(ds->dev, "p%d: phylink_mac_link_state() failed: %d\n",
1004 			dp->index, err);
1005 		state->link = 0;
1006 	}
1007 }
1008 
1009 static void dsa_port_phylink_mac_config(struct phylink_config *config,
1010 					unsigned int mode,
1011 					const struct phylink_link_state *state)
1012 {
1013 	struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
1014 	struct dsa_switch *ds = dp->ds;
1015 
1016 	if (!ds->ops->phylink_mac_config)
1017 		return;
1018 
1019 	ds->ops->phylink_mac_config(ds, dp->index, mode, state);
1020 }
1021 
1022 static void dsa_port_phylink_mac_an_restart(struct phylink_config *config)
1023 {
1024 	struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
1025 	struct dsa_switch *ds = dp->ds;
1026 
1027 	if (!ds->ops->phylink_mac_an_restart)
1028 		return;
1029 
1030 	ds->ops->phylink_mac_an_restart(ds, dp->index);
1031 }
1032 
1033 static void dsa_port_phylink_mac_link_down(struct phylink_config *config,
1034 					   unsigned int mode,
1035 					   phy_interface_t interface)
1036 {
1037 	struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
1038 	struct phy_device *phydev = NULL;
1039 	struct dsa_switch *ds = dp->ds;
1040 
1041 	if (dsa_port_is_user(dp))
1042 		phydev = dp->slave->phydev;
1043 
1044 	if (!ds->ops->phylink_mac_link_down) {
1045 		if (ds->ops->adjust_link && phydev)
1046 			ds->ops->adjust_link(ds, dp->index, phydev);
1047 		return;
1048 	}
1049 
1050 	ds->ops->phylink_mac_link_down(ds, dp->index, mode, interface);
1051 }
1052 
1053 static void dsa_port_phylink_mac_link_up(struct phylink_config *config,
1054 					 struct phy_device *phydev,
1055 					 unsigned int mode,
1056 					 phy_interface_t interface,
1057 					 int speed, int duplex,
1058 					 bool tx_pause, bool rx_pause)
1059 {
1060 	struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
1061 	struct dsa_switch *ds = dp->ds;
1062 
1063 	if (!ds->ops->phylink_mac_link_up) {
1064 		if (ds->ops->adjust_link && phydev)
1065 			ds->ops->adjust_link(ds, dp->index, phydev);
1066 		return;
1067 	}
1068 
1069 	ds->ops->phylink_mac_link_up(ds, dp->index, mode, interface, phydev,
1070 				     speed, duplex, tx_pause, rx_pause);
1071 }
1072 
1073 const struct phylink_mac_ops dsa_port_phylink_mac_ops = {
1074 	.validate = dsa_port_phylink_validate,
1075 	.mac_pcs_get_state = dsa_port_phylink_mac_pcs_get_state,
1076 	.mac_config = dsa_port_phylink_mac_config,
1077 	.mac_an_restart = dsa_port_phylink_mac_an_restart,
1078 	.mac_link_down = dsa_port_phylink_mac_link_down,
1079 	.mac_link_up = dsa_port_phylink_mac_link_up,
1080 };
1081 
1082 static int dsa_port_setup_phy_of(struct dsa_port *dp, bool enable)
1083 {
1084 	struct dsa_switch *ds = dp->ds;
1085 	struct phy_device *phydev;
1086 	int port = dp->index;
1087 	int err = 0;
1088 
1089 	phydev = dsa_port_get_phy_device(dp);
1090 	if (!phydev)
1091 		return 0;
1092 
1093 	if (IS_ERR(phydev))
1094 		return PTR_ERR(phydev);
1095 
1096 	if (enable) {
1097 		err = genphy_resume(phydev);
1098 		if (err < 0)
1099 			goto err_put_dev;
1100 
1101 		err = genphy_read_status(phydev);
1102 		if (err < 0)
1103 			goto err_put_dev;
1104 	} else {
1105 		err = genphy_suspend(phydev);
1106 		if (err < 0)
1107 			goto err_put_dev;
1108 	}
1109 
1110 	if (ds->ops->adjust_link)
1111 		ds->ops->adjust_link(ds, port, phydev);
1112 
1113 	dev_dbg(ds->dev, "enabled port's phy: %s", phydev_name(phydev));
1114 
1115 err_put_dev:
1116 	put_device(&phydev->mdio.dev);
1117 	return err;
1118 }
1119 
1120 static int dsa_port_fixed_link_register_of(struct dsa_port *dp)
1121 {
1122 	struct device_node *dn = dp->dn;
1123 	struct dsa_switch *ds = dp->ds;
1124 	struct phy_device *phydev;
1125 	int port = dp->index;
1126 	phy_interface_t mode;
1127 	int err;
1128 
1129 	err = of_phy_register_fixed_link(dn);
1130 	if (err) {
1131 		dev_err(ds->dev,
1132 			"failed to register the fixed PHY of port %d\n",
1133 			port);
1134 		return err;
1135 	}
1136 
1137 	phydev = of_phy_find_device(dn);
1138 
1139 	err = of_get_phy_mode(dn, &mode);
1140 	if (err)
1141 		mode = PHY_INTERFACE_MODE_NA;
1142 	phydev->interface = mode;
1143 
1144 	genphy_read_status(phydev);
1145 
1146 	if (ds->ops->adjust_link)
1147 		ds->ops->adjust_link(ds, port, phydev);
1148 
1149 	put_device(&phydev->mdio.dev);
1150 
1151 	return 0;
1152 }
1153 
1154 static int dsa_port_phylink_register(struct dsa_port *dp)
1155 {
1156 	struct dsa_switch *ds = dp->ds;
1157 	struct device_node *port_dn = dp->dn;
1158 	phy_interface_t mode;
1159 	int err;
1160 
1161 	err = of_get_phy_mode(port_dn, &mode);
1162 	if (err)
1163 		mode = PHY_INTERFACE_MODE_NA;
1164 
1165 	dp->pl_config.dev = ds->dev;
1166 	dp->pl_config.type = PHYLINK_DEV;
1167 	dp->pl_config.pcs_poll = ds->pcs_poll;
1168 
1169 	dp->pl = phylink_create(&dp->pl_config, of_fwnode_handle(port_dn),
1170 				mode, &dsa_port_phylink_mac_ops);
1171 	if (IS_ERR(dp->pl)) {
1172 		pr_err("error creating PHYLINK: %ld\n", PTR_ERR(dp->pl));
1173 		return PTR_ERR(dp->pl);
1174 	}
1175 
1176 	err = phylink_of_phy_connect(dp->pl, port_dn, 0);
1177 	if (err && err != -ENODEV) {
1178 		pr_err("could not attach to PHY: %d\n", err);
1179 		goto err_phy_connect;
1180 	}
1181 
1182 	return 0;
1183 
1184 err_phy_connect:
1185 	phylink_destroy(dp->pl);
1186 	return err;
1187 }
1188 
1189 int dsa_port_link_register_of(struct dsa_port *dp)
1190 {
1191 	struct dsa_switch *ds = dp->ds;
1192 	struct device_node *phy_np;
1193 	int port = dp->index;
1194 
1195 	if (!ds->ops->adjust_link) {
1196 		phy_np = of_parse_phandle(dp->dn, "phy-handle", 0);
1197 		if (of_phy_is_fixed_link(dp->dn) || phy_np) {
1198 			if (ds->ops->phylink_mac_link_down)
1199 				ds->ops->phylink_mac_link_down(ds, port,
1200 					MLO_AN_FIXED, PHY_INTERFACE_MODE_NA);
1201 			return dsa_port_phylink_register(dp);
1202 		}
1203 		return 0;
1204 	}
1205 
1206 	dev_warn(ds->dev,
1207 		 "Using legacy PHYLIB callbacks. Please migrate to PHYLINK!\n");
1208 
1209 	if (of_phy_is_fixed_link(dp->dn))
1210 		return dsa_port_fixed_link_register_of(dp);
1211 	else
1212 		return dsa_port_setup_phy_of(dp, true);
1213 }
1214 
1215 void dsa_port_link_unregister_of(struct dsa_port *dp)
1216 {
1217 	struct dsa_switch *ds = dp->ds;
1218 
1219 	if (!ds->ops->adjust_link && dp->pl) {
1220 		rtnl_lock();
1221 		phylink_disconnect_phy(dp->pl);
1222 		rtnl_unlock();
1223 		phylink_destroy(dp->pl);
1224 		dp->pl = NULL;
1225 		return;
1226 	}
1227 
1228 	if (of_phy_is_fixed_link(dp->dn))
1229 		of_phy_deregister_fixed_link(dp->dn);
1230 	else
1231 		dsa_port_setup_phy_of(dp, false);
1232 }
1233 
1234 int dsa_port_get_phy_strings(struct dsa_port *dp, uint8_t *data)
1235 {
1236 	struct phy_device *phydev;
1237 	int ret = -EOPNOTSUPP;
1238 
1239 	if (of_phy_is_fixed_link(dp->dn))
1240 		return ret;
1241 
1242 	phydev = dsa_port_get_phy_device(dp);
1243 	if (IS_ERR_OR_NULL(phydev))
1244 		return ret;
1245 
1246 	ret = phy_ethtool_get_strings(phydev, data);
1247 	put_device(&phydev->mdio.dev);
1248 
1249 	return ret;
1250 }
1251 EXPORT_SYMBOL_GPL(dsa_port_get_phy_strings);
1252 
1253 int dsa_port_get_ethtool_phy_stats(struct dsa_port *dp, uint64_t *data)
1254 {
1255 	struct phy_device *phydev;
1256 	int ret = -EOPNOTSUPP;
1257 
1258 	if (of_phy_is_fixed_link(dp->dn))
1259 		return ret;
1260 
1261 	phydev = dsa_port_get_phy_device(dp);
1262 	if (IS_ERR_OR_NULL(phydev))
1263 		return ret;
1264 
1265 	ret = phy_ethtool_get_stats(phydev, NULL, data);
1266 	put_device(&phydev->mdio.dev);
1267 
1268 	return ret;
1269 }
1270 EXPORT_SYMBOL_GPL(dsa_port_get_ethtool_phy_stats);
1271 
1272 int dsa_port_get_phy_sset_count(struct dsa_port *dp)
1273 {
1274 	struct phy_device *phydev;
1275 	int ret = -EOPNOTSUPP;
1276 
1277 	if (of_phy_is_fixed_link(dp->dn))
1278 		return ret;
1279 
1280 	phydev = dsa_port_get_phy_device(dp);
1281 	if (IS_ERR_OR_NULL(phydev))
1282 		return ret;
1283 
1284 	ret = phy_ethtool_get_sset_count(phydev);
1285 	put_device(&phydev->mdio.dev);
1286 
1287 	return ret;
1288 }
1289 EXPORT_SYMBOL_GPL(dsa_port_get_phy_sset_count);
1290 
1291 int dsa_port_hsr_join(struct dsa_port *dp, struct net_device *hsr)
1292 {
1293 	struct dsa_notifier_hsr_info info = {
1294 		.sw_index = dp->ds->index,
1295 		.port = dp->index,
1296 		.hsr = hsr,
1297 	};
1298 	int err;
1299 
1300 	dp->hsr_dev = hsr;
1301 
1302 	err = dsa_port_notify(dp, DSA_NOTIFIER_HSR_JOIN, &info);
1303 	if (err)
1304 		dp->hsr_dev = NULL;
1305 
1306 	return err;
1307 }
1308 
1309 void dsa_port_hsr_leave(struct dsa_port *dp, struct net_device *hsr)
1310 {
1311 	struct dsa_notifier_hsr_info info = {
1312 		.sw_index = dp->ds->index,
1313 		.port = dp->index,
1314 		.hsr = hsr,
1315 	};
1316 	int err;
1317 
1318 	dp->hsr_dev = NULL;
1319 
1320 	err = dsa_port_notify(dp, DSA_NOTIFIER_HSR_LEAVE, &info);
1321 	if (err)
1322 		dev_err(dp->ds->dev,
1323 			"port %d failed to notify DSA_NOTIFIER_HSR_LEAVE: %pe\n",
1324 			dp->index, ERR_PTR(err));
1325 }
1326 
1327 int dsa_port_tag_8021q_vlan_add(struct dsa_port *dp, u16 vid, bool broadcast)
1328 {
1329 	struct dsa_notifier_tag_8021q_vlan_info info = {
1330 		.tree_index = dp->ds->dst->index,
1331 		.sw_index = dp->ds->index,
1332 		.port = dp->index,
1333 		.vid = vid,
1334 	};
1335 
1336 	if (broadcast)
1337 		return dsa_broadcast(DSA_NOTIFIER_TAG_8021Q_VLAN_ADD, &info);
1338 
1339 	return dsa_port_notify(dp, DSA_NOTIFIER_TAG_8021Q_VLAN_ADD, &info);
1340 }
1341 
1342 void dsa_port_tag_8021q_vlan_del(struct dsa_port *dp, u16 vid, bool broadcast)
1343 {
1344 	struct dsa_notifier_tag_8021q_vlan_info info = {
1345 		.tree_index = dp->ds->dst->index,
1346 		.sw_index = dp->ds->index,
1347 		.port = dp->index,
1348 		.vid = vid,
1349 	};
1350 	int err;
1351 
1352 	if (broadcast)
1353 		err = dsa_broadcast(DSA_NOTIFIER_TAG_8021Q_VLAN_DEL, &info);
1354 	else
1355 		err = dsa_port_notify(dp, DSA_NOTIFIER_TAG_8021Q_VLAN_DEL, &info);
1356 	if (err)
1357 		dev_err(dp->ds->dev,
1358 			"port %d failed to notify tag_8021q VLAN %d deletion: %pe\n",
1359 			dp->index, vid, ERR_PTR(err));
1360 }
1361