1 // SPDX-License-Identifier: GPL-2.0-only 2 /* Copyright (c) 2026 Meta Platforms, Inc. and affiliates. */ 3 #include <linux/bpf.h> 4 #include <linux/bpf_verifier.h> 5 #include <linux/cnum.h> 6 #include <linux/filter.h> 7 8 #define verbose(env, fmt, args...) bpf_verifier_log_write(env, fmt, ##args) 9 10 #define BPF_COMPLEXITY_LIMIT_STATES 64 11 12 static bool is_may_goto_insn_at(struct bpf_verifier_env *env, int insn_idx) 13 { 14 return bpf_is_may_goto_insn(&env->prog->insnsi[insn_idx]); 15 } 16 17 static bool is_iter_next_insn(struct bpf_verifier_env *env, int insn_idx) 18 { 19 return env->insn_aux_data[insn_idx].is_iter_next; 20 } 21 22 static void update_peak_states(struct bpf_verifier_env *env) 23 { 24 u32 cur_states; 25 26 cur_states = env->explored_states_size + env->free_list_size + env->num_backedges; 27 env->peak_states = max(env->peak_states, cur_states); 28 } 29 30 /* struct bpf_verifier_state->parent refers to states 31 * that are in either of env->{expored_states,free_list}. 32 * In both cases the state is contained in struct bpf_verifier_state_list. 33 */ 34 static struct bpf_verifier_state_list *state_parent_as_list(struct bpf_verifier_state *st) 35 { 36 if (st->parent) 37 return container_of(st->parent, struct bpf_verifier_state_list, state); 38 return NULL; 39 } 40 41 static bool incomplete_read_marks(struct bpf_verifier_env *env, 42 struct bpf_verifier_state *st); 43 44 /* A state can be freed if it is no longer referenced: 45 * - is in the env->free_list; 46 * - has no children states; 47 */ 48 static void maybe_free_verifier_state(struct bpf_verifier_env *env, 49 struct bpf_verifier_state_list *sl) 50 { 51 if (!sl->in_free_list 52 || sl->state.branches != 0 53 || incomplete_read_marks(env, &sl->state)) 54 return; 55 list_del(&sl->node); 56 bpf_free_verifier_state(&sl->state, false); 57 kfree(sl); 58 env->free_list_size--; 59 } 60 61 /* For state @st look for a topmost frame with frame_insn_idx() in some SCC, 62 * if such frame exists form a corresponding @callchain as an array of 63 * call sites leading to this frame and SCC id. 64 * E.g.: 65 * 66 * void foo() { A: loop {... SCC#1 ...}; } 67 * void bar() { B: loop { C: foo(); ... SCC#2 ... } 68 * D: loop { E: foo(); ... SCC#3 ... } } 69 * void main() { F: bar(); } 70 * 71 * @callchain at (A) would be either (F,SCC#2) or (F,SCC#3) depending 72 * on @st frame call sites being (F,C,A) or (F,E,A). 73 */ 74 static bool compute_scc_callchain(struct bpf_verifier_env *env, 75 struct bpf_verifier_state *st, 76 struct bpf_scc_callchain *callchain) 77 { 78 u32 i, scc, insn_idx; 79 80 memset(callchain, 0, sizeof(*callchain)); 81 for (i = 0; i <= st->curframe; i++) { 82 insn_idx = bpf_frame_insn_idx(st, i); 83 scc = env->insn_aux_data[insn_idx].scc; 84 if (scc) { 85 callchain->scc = scc; 86 break; 87 } else if (i < st->curframe) { 88 callchain->callsites[i] = insn_idx; 89 } else { 90 return false; 91 } 92 } 93 return true; 94 } 95 96 /* Check if bpf_scc_visit instance for @callchain exists. */ 97 static struct bpf_scc_visit *scc_visit_lookup(struct bpf_verifier_env *env, 98 struct bpf_scc_callchain *callchain) 99 { 100 struct bpf_scc_info *info = env->scc_info[callchain->scc]; 101 struct bpf_scc_visit *visits = info->visits; 102 u32 i; 103 104 if (!info) 105 return NULL; 106 for (i = 0; i < info->num_visits; i++) 107 if (memcmp(callchain, &visits[i].callchain, sizeof(*callchain)) == 0) 108 return &visits[i]; 109 return NULL; 110 } 111 112 /* Allocate a new bpf_scc_visit instance corresponding to @callchain. 113 * Allocated instances are alive for a duration of the do_check_common() 114 * call and are freed by free_states(). 115 */ 116 static struct bpf_scc_visit *scc_visit_alloc(struct bpf_verifier_env *env, 117 struct bpf_scc_callchain *callchain) 118 { 119 struct bpf_scc_visit *visit; 120 struct bpf_scc_info *info; 121 u32 scc, num_visits; 122 u64 new_sz; 123 124 scc = callchain->scc; 125 info = env->scc_info[scc]; 126 num_visits = info ? info->num_visits : 0; 127 new_sz = sizeof(*info) + sizeof(struct bpf_scc_visit) * (num_visits + 1); 128 info = kvrealloc(env->scc_info[scc], new_sz, GFP_KERNEL_ACCOUNT); 129 if (!info) 130 return NULL; 131 env->scc_info[scc] = info; 132 info->num_visits = num_visits + 1; 133 visit = &info->visits[num_visits]; 134 memset(visit, 0, sizeof(*visit)); 135 memcpy(&visit->callchain, callchain, sizeof(*callchain)); 136 return visit; 137 } 138 139 /* Form a string '(callsite#1,callsite#2,...,scc)' in env->tmp_str_buf */ 140 static char *format_callchain(struct bpf_verifier_env *env, struct bpf_scc_callchain *callchain) 141 { 142 char *buf = env->tmp_str_buf; 143 int i, delta = 0; 144 145 delta += snprintf(buf + delta, TMP_STR_BUF_LEN - delta, "("); 146 for (i = 0; i < ARRAY_SIZE(callchain->callsites); i++) { 147 if (!callchain->callsites[i]) 148 break; 149 delta += snprintf(buf + delta, TMP_STR_BUF_LEN - delta, "%u,", 150 callchain->callsites[i]); 151 } 152 delta += snprintf(buf + delta, TMP_STR_BUF_LEN - delta, "%u)", callchain->scc); 153 return env->tmp_str_buf; 154 } 155 156 /* If callchain for @st exists (@st is in some SCC), ensure that 157 * bpf_scc_visit instance for this callchain exists. 158 * If instance does not exist or is empty, assign visit->entry_state to @st. 159 */ 160 static int maybe_enter_scc(struct bpf_verifier_env *env, struct bpf_verifier_state *st) 161 { 162 struct bpf_scc_callchain *callchain = &env->callchain_buf; 163 struct bpf_scc_visit *visit; 164 165 if (!compute_scc_callchain(env, st, callchain)) 166 return 0; 167 visit = scc_visit_lookup(env, callchain); 168 visit = visit ?: scc_visit_alloc(env, callchain); 169 if (!visit) 170 return -ENOMEM; 171 if (!visit->entry_state) { 172 visit->entry_state = st; 173 if (env->log.level & BPF_LOG_LEVEL2) 174 verbose(env, "SCC enter %s\n", format_callchain(env, callchain)); 175 } 176 return 0; 177 } 178 179 static int propagate_backedges(struct bpf_verifier_env *env, struct bpf_scc_visit *visit); 180 181 /* If callchain for @st exists (@st is in some SCC), make it empty: 182 * - set visit->entry_state to NULL; 183 * - flush accumulated backedges. 184 */ 185 static int maybe_exit_scc(struct bpf_verifier_env *env, struct bpf_verifier_state *st) 186 { 187 struct bpf_scc_callchain *callchain = &env->callchain_buf; 188 struct bpf_scc_visit *visit; 189 190 if (!compute_scc_callchain(env, st, callchain)) 191 return 0; 192 visit = scc_visit_lookup(env, callchain); 193 if (!visit) { 194 /* 195 * If path traversal stops inside an SCC, corresponding bpf_scc_visit 196 * must exist for non-speculative paths. For non-speculative paths 197 * traversal stops when: 198 * a. Verification error is found, maybe_exit_scc() is not called. 199 * b. Top level BPF_EXIT is reached. Top level BPF_EXIT is not a member 200 * of any SCC. 201 * c. A checkpoint is reached and matched. Checkpoints are created by 202 * is_state_visited(), which calls maybe_enter_scc(), which allocates 203 * bpf_scc_visit instances for checkpoints within SCCs. 204 * (c) is the only case that can reach this point. 205 */ 206 if (!st->speculative) { 207 verifier_bug(env, "scc exit: no visit info for call chain %s", 208 format_callchain(env, callchain)); 209 return -EFAULT; 210 } 211 return 0; 212 } 213 if (visit->entry_state != st) 214 return 0; 215 if (env->log.level & BPF_LOG_LEVEL2) 216 verbose(env, "SCC exit %s\n", format_callchain(env, callchain)); 217 visit->entry_state = NULL; 218 env->num_backedges -= visit->num_backedges; 219 visit->num_backedges = 0; 220 update_peak_states(env); 221 return propagate_backedges(env, visit); 222 } 223 224 /* Lookup an bpf_scc_visit instance corresponding to @st callchain 225 * and add @backedge to visit->backedges. @st callchain must exist. 226 */ 227 static int add_scc_backedge(struct bpf_verifier_env *env, 228 struct bpf_verifier_state *st, 229 struct bpf_scc_backedge *backedge) 230 { 231 struct bpf_scc_callchain *callchain = &env->callchain_buf; 232 struct bpf_scc_visit *visit; 233 234 if (!compute_scc_callchain(env, st, callchain)) { 235 verifier_bug(env, "add backedge: no SCC in verification path, insn_idx %d", 236 st->insn_idx); 237 return -EFAULT; 238 } 239 visit = scc_visit_lookup(env, callchain); 240 if (!visit) { 241 verifier_bug(env, "add backedge: no visit info for call chain %s", 242 format_callchain(env, callchain)); 243 return -EFAULT; 244 } 245 if (env->log.level & BPF_LOG_LEVEL2) 246 verbose(env, "SCC backedge %s\n", format_callchain(env, callchain)); 247 backedge->next = visit->backedges; 248 visit->backedges = backedge; 249 visit->num_backedges++; 250 env->num_backedges++; 251 update_peak_states(env); 252 return 0; 253 } 254 255 /* bpf_reg_state->live marks for registers in a state @st are incomplete, 256 * if state @st is in some SCC and not all execution paths starting at this 257 * SCC are fully explored. 258 */ 259 static bool incomplete_read_marks(struct bpf_verifier_env *env, 260 struct bpf_verifier_state *st) 261 { 262 struct bpf_scc_callchain *callchain = &env->callchain_buf; 263 struct bpf_scc_visit *visit; 264 265 if (!compute_scc_callchain(env, st, callchain)) 266 return false; 267 visit = scc_visit_lookup(env, callchain); 268 if (!visit) 269 return false; 270 return !!visit->backedges; 271 } 272 273 int bpf_update_branch_counts(struct bpf_verifier_env *env, struct bpf_verifier_state *st) 274 { 275 struct bpf_verifier_state_list *sl = NULL, *parent_sl; 276 struct bpf_verifier_state *parent; 277 int err; 278 279 while (st) { 280 u32 br = --st->branches; 281 282 /* verifier_bug_if(br > 1, ...) technically makes sense here, 283 * but see comment in push_stack(), hence: 284 */ 285 verifier_bug_if((int)br < 0, env, "%s:branches_to_explore=%d", __func__, br); 286 if (br) 287 break; 288 err = maybe_exit_scc(env, st); 289 if (err) 290 return err; 291 parent = st->parent; 292 parent_sl = state_parent_as_list(st); 293 if (sl) 294 maybe_free_verifier_state(env, sl); 295 st = parent; 296 sl = parent_sl; 297 } 298 return 0; 299 } 300 301 /* check %cur's range satisfies %old's */ 302 static bool range_within(const struct bpf_reg_state *old, 303 const struct bpf_reg_state *cur) 304 { 305 return cnum64_is_subset(old->r64, cur->r64) && 306 cnum32_is_subset(old->r32, cur->r32); 307 } 308 309 /* If in the old state two registers had the same id, then they need to have 310 * the same id in the new state as well. But that id could be different from 311 * the old state, so we need to track the mapping from old to new ids. 312 * Once we have seen that, say, a reg with old id 5 had new id 9, any subsequent 313 * regs with old id 5 must also have new id 9 for the new state to be safe. But 314 * regs with a different old id could still have new id 9, we don't care about 315 * that. 316 * So we look through our idmap to see if this old id has been seen before. If 317 * so, we require the new id to match; otherwise, we add the id pair to the map. 318 */ 319 static bool check_ids(u32 old_id, u32 cur_id, struct bpf_idmap *idmap) 320 { 321 struct bpf_id_pair *map = idmap->map; 322 unsigned int i; 323 324 /* either both IDs should be set or both should be zero */ 325 if (!!old_id != !!cur_id) 326 return false; 327 328 if (old_id == 0) /* cur_id == 0 as well */ 329 return true; 330 331 for (i = 0; i < idmap->cnt; i++) { 332 if (map[i].old == old_id) 333 return map[i].cur == cur_id; 334 if (map[i].cur == cur_id) 335 return false; 336 } 337 338 /* Reached the end of known mappings; haven't seen this id before */ 339 if (idmap->cnt < BPF_ID_MAP_SIZE) { 340 map[idmap->cnt].old = old_id; 341 map[idmap->cnt].cur = cur_id; 342 idmap->cnt++; 343 return true; 344 } 345 346 /* 347 * idmap slots are bounded by the number of registers and stack slots. 348 * Since referenced dynptrs acquire intermediate references that do 349 * not live in either, so the map can be exhausted. Since it is unlikely, 350 * fail the verification by treating the states as not equivalent. 351 */ 352 return false; 353 } 354 355 /* 356 * Compare scalar register IDs for state equivalence. 357 * 358 * When old_id == 0, the old register is independent - not linked to any 359 * other register. Any linking in the current state only adds constraints, 360 * making it more restrictive. Since the old state didn't rely on any ID 361 * relationships for this register, it's always safe to accept cur regardless 362 * of its ID. Hence, return true immediately. 363 * 364 * When old_id != 0 but cur_id == 0, we need to ensure that different 365 * independent registers in cur don't incorrectly satisfy the ID matching 366 * requirements of linked registers in old. 367 * 368 * Example: if old has r6.id=X and r7.id=X (linked), but cur has r6.id=0 369 * and r7.id=0 (both independent), without temp IDs both would map old_id=X 370 * to cur_id=0 and pass. With temp IDs: r6 maps X->temp1, r7 tries to map 371 * X->temp2, but X is already mapped to temp1, so the check fails correctly. 372 * 373 * When old_id has BPF_ADD_CONST set, the compound id (base | flag) and the 374 * base id (flag stripped) must both map consistently. Example: old has 375 * r2.id=A, r3.id=A|flag (r3 = r2 + delta), cur has r2.id=B, r3.id=C|flag 376 * (r3 derived from unrelated r4). Without the base check, idmap gets two 377 * independent entries A->B and A|flag->C|flag, missing that A->C conflicts 378 * with A->B. The base ID cross-check catches this. 379 */ 380 static bool check_scalar_ids(u32 old_id, u32 cur_id, struct bpf_idmap *idmap) 381 { 382 if (!old_id) 383 return true; 384 385 cur_id = cur_id ? cur_id : ++idmap->tmp_id_gen; 386 387 if (!check_ids(old_id, cur_id, idmap)) 388 return false; 389 if (old_id & BPF_ADD_CONST) { 390 old_id &= ~BPF_ADD_CONST; 391 cur_id &= ~BPF_ADD_CONST; 392 if (!check_ids(old_id, cur_id, idmap)) 393 return false; 394 } 395 return true; 396 } 397 398 static void __clean_func_state(struct bpf_verifier_env *env, 399 struct bpf_func_state *st, 400 u16 live_regs, int frame) 401 { 402 int i, j; 403 404 for (i = 0; i < BPF_REG_FP; i++) { 405 /* liveness must not touch this register anymore */ 406 if (!(live_regs & BIT(i))) 407 /* since the register is unused, clear its state 408 * to make further comparison simpler 409 */ 410 bpf_mark_reg_not_init(env, &st->regs[i]); 411 } 412 413 /* 414 * Clean dead 4-byte halves within each SPI independently. 415 * half_spi 2*i → lower half: slot_type[0..3] (closer to FP) 416 * half_spi 2*i+1 → upper half: slot_type[4..7] (farther from FP) 417 */ 418 for (i = 0; i < bpf_stack_nr_slots(st); i++) { 419 bool lo_live = bpf_stack_slot_alive(env, frame, i * 2); 420 bool hi_live = bpf_stack_slot_alive(env, frame, i * 2 + 1); 421 422 if (!hi_live || !lo_live) { 423 int start = !lo_live ? 0 : BPF_REG_SIZE / 2; 424 int end = !hi_live ? BPF_REG_SIZE : BPF_REG_SIZE / 2; 425 u8 stype = bpf_stack_slot(st, i)->slot_type[7]; 426 427 /* 428 * Don't clear special slots. 429 * destroy_if_dynptr_stack_slot() needs STACK_DYNPTR to 430 * detect overwrites and invalidate associated data slices. 431 * is_iter_reg_valid_uninit() and is_irq_flag_reg_valid_uninit() 432 * check for their respective slot types to detect double-create. 433 */ 434 if (stype == STACK_DYNPTR || stype == STACK_ITER || 435 stype == STACK_IRQ_FLAG) 436 continue; 437 438 /* 439 * Only scalar spills can be degraded to raw stack bytes 440 * when their high half is dead. Pointer spills need the 441 * saved spilled_ptr metadata so partial fills keep 442 * rejecting as non-scalar register fills. 443 */ 444 if (!hi_live) { 445 struct bpf_reg_state *spill = &bpf_stack_slot(st, i)->spilled_ptr; 446 447 if (lo_live && stype == STACK_SPILL) { 448 if (spill->type != SCALAR_VALUE) 449 continue; 450 /* 451 * Can't replace with STACK_ZERO, because 452 * that requires bpf_mark_chain_precision(). 453 */ 454 if (bpf_register_is_null(spill)) 455 continue; 456 for (j = 0; j < 4; j++) { 457 u8 *t = &bpf_stack_slot(st, i)->slot_type[j]; 458 459 if (*t == STACK_SPILL) 460 *t = STACK_MISC; 461 } 462 } 463 bpf_mark_reg_not_init(env, spill); 464 } 465 for (j = start; j < end; j++) 466 bpf_stack_slot(st, i)->slot_type[j] = STACK_POISON; 467 } 468 } 469 } 470 471 static int clean_verifier_state(struct bpf_verifier_env *env, 472 struct bpf_verifier_state *st) 473 { 474 int i, err; 475 476 err = bpf_live_stack_query_init(env, st); 477 if (err) 478 return err; 479 for (i = 0; i <= st->curframe; i++) { 480 u32 ip = bpf_frame_insn_idx(st, i); 481 u16 live_regs = env->insn_aux_data[ip].live_regs_before; 482 483 __clean_func_state(env, st->frame[i], live_regs, i); 484 } 485 return 0; 486 } 487 488 static bool regs_exact(const struct bpf_reg_state *rold, 489 const struct bpf_reg_state *rcur, 490 struct bpf_idmap *idmap) 491 { 492 return memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)) == 0 && 493 check_ids(rold->id, rcur->id, idmap) && 494 check_ids(rold->parent_id, rcur->parent_id, idmap) && 495 check_ids(rold->map_uid, rcur->map_uid, idmap); 496 } 497 498 enum exact_level { 499 NOT_EXACT, 500 EXACT, 501 RANGE_WITHIN 502 }; 503 504 /* Returns true if (rold safe implies rcur safe) */ 505 static bool regsafe(struct bpf_verifier_env *env, struct bpf_reg_state *rold, 506 struct bpf_reg_state *rcur, struct bpf_idmap *idmap, 507 enum exact_level exact) 508 { 509 if (exact == EXACT) 510 return regs_exact(rold, rcur, idmap); 511 512 if (rold->type == NOT_INIT) 513 /* explored state can't have used this */ 514 return true; 515 516 /* Enforce that register types have to match exactly, including their 517 * modifiers (like PTR_MAYBE_NULL, MEM_RDONLY, etc), as a general 518 * rule. 519 * 520 * One can make a point that using a pointer register as unbounded 521 * SCALAR would be technically acceptable, but this could lead to 522 * pointer leaks because scalars are allowed to leak while pointers 523 * are not. We could make this safe in special cases if root is 524 * calling us, but it's probably not worth the hassle. 525 * 526 * Also, register types that are *not* MAYBE_NULL could technically be 527 * safe to use as their MAYBE_NULL variants (e.g., PTR_TO_MAP_VALUE 528 * is safe to be used as PTR_TO_MAP_VALUE_OR_NULL, provided both point 529 * to the same map). 530 * However, if the old MAYBE_NULL register then got NULL checked, 531 * doing so could have affected others with the same id, and we can't 532 * check for that because we lost the id when we converted to 533 * a non-MAYBE_NULL variant. 534 * So, as a general rule we don't allow mixing MAYBE_NULL and 535 * non-MAYBE_NULL registers as well. 536 */ 537 if (rold->type != rcur->type) 538 return false; 539 540 switch (base_type(rold->type)) { 541 case SCALAR_VALUE: 542 if (env->explore_alu_limits) { 543 /* explore_alu_limits disables tnum_in() and range_within() 544 * logic and requires everything to be strict 545 */ 546 return memcmp(rold, rcur, offsetof(struct bpf_reg_state, id)) == 0 && 547 check_scalar_ids(rold->id, rcur->id, idmap); 548 } 549 if (!rold->precise && exact == NOT_EXACT) 550 return true; 551 /* 552 * Linked register tracking uses rold->id to detect relationships. 553 * When rold->id == 0, the register is independent and any linking 554 * in rcur only adds constraints. When rold->id != 0, we must verify 555 * id mapping and (for BPF_ADD_CONST) offset consistency. 556 * 557 * +------------------+-----------+------------------+---------------+ 558 * | | rold->id | rold + ADD_CONST | rold->id == 0 | 559 * |------------------+-----------+------------------+---------------| 560 * | rcur->id | range,ids | false | range | 561 * | rcur + ADD_CONST | false | range,ids,off | range | 562 * | rcur->id == 0 | range,ids | false | range | 563 * +------------------+-----------+------------------+---------------+ 564 * 565 * Why check_ids() for scalar registers? 566 * 567 * Consider the following BPF code: 568 * 1: r6 = ... unbound scalar, ID=a ... 569 * 2: r7 = ... unbound scalar, ID=b ... 570 * 3: if (r6 > r7) goto +1 571 * 4: r6 = r7 572 * 5: if (r6 > X) goto ... 573 * 6: ... memory operation using r7 ... 574 * 575 * First verification path is [1-6]: 576 * - at (4) same bpf_reg_state::id (b) would be assigned to r6 and r7; 577 * - at (5) r6 would be marked <= X, sync_linked_regs() would also mark 578 * r7 <= X, because r6 and r7 share same id. 579 * Next verification path is [1-4, 6]. 580 * 581 * Instruction (6) would be reached in two states: 582 * I. r6{.id=b}, r7{.id=b} via path 1-6; 583 * II. r6{.id=a}, r7{.id=b} via path 1-4, 6. 584 * 585 * Use check_ids() to distinguish these states. 586 * --- 587 * Also verify that new value satisfies old value range knowledge. 588 */ 589 590 /* 591 * ADD_CONST flags must match exactly: BPF_ADD_CONST32 and 592 * BPF_ADD_CONST64 have different linking semantics in 593 * sync_linked_regs() (alu32 zero-extends, alu64 does not), 594 * so pruning across different flag types is unsafe. 595 */ 596 if (rold->id && 597 (rold->id & BPF_ADD_CONST) != (rcur->id & BPF_ADD_CONST)) 598 return false; 599 600 /* Both have offset linkage: offsets must match */ 601 if ((rold->id & BPF_ADD_CONST) && rold->delta != rcur->delta) 602 return false; 603 604 if (!check_scalar_ids(rold->id, rcur->id, idmap)) 605 return false; 606 607 return range_within(rold, rcur) && tnum_in(rold->var_off, rcur->var_off); 608 case PTR_TO_MAP_KEY: 609 case PTR_TO_MAP_VALUE: 610 case PTR_TO_MEM: 611 case PTR_TO_BUF: 612 case PTR_TO_TP_BUFFER: 613 /* If the new min/max/var_off satisfy the old ones and 614 * everything else matches, we are OK. 615 */ 616 return memcmp(rold, rcur, offsetof(struct bpf_reg_state, var_off)) == 0 && 617 range_within(rold, rcur) && 618 tnum_in(rold->var_off, rcur->var_off) && 619 check_ids(rold->id, rcur->id, idmap) && 620 check_ids(rold->parent_id, rcur->parent_id, idmap) && 621 check_ids(rold->map_uid, rcur->map_uid, idmap); 622 case PTR_TO_PACKET_META: 623 case PTR_TO_PACKET: 624 /* We must have at least as much range as the old ptr 625 * did, so that any accesses which were safe before are 626 * still safe. This is true even if old range < old off, 627 * since someone could have accessed through (ptr - k), or 628 * even done ptr -= k in a register, to get a safe access. 629 */ 630 if (rold->range < 0 || rcur->range < 0) { 631 /* special case for [BEYOND|AT]_PKT_END */ 632 if (rold->range != rcur->range) 633 return false; 634 } else if (rold->range > rcur->range) { 635 return false; 636 } 637 /* id relations must be preserved */ 638 if (!check_ids(rold->id, rcur->id, idmap)) 639 return false; 640 /* Preserve displacements between pointers sharing an ID. */ 641 if (rold->id && rold->r64.base != rcur->r64.base) 642 return false; 643 /* new val must satisfy old val knowledge */ 644 return range_within(rold, rcur) && 645 tnum_in(rold->var_off, rcur->var_off); 646 case PTR_TO_STACK: 647 return regs_exact(rold, rcur, idmap); 648 case PTR_TO_ARENA: 649 return true; 650 case PTR_TO_INSN: 651 return memcmp(rold, rcur, offsetof(struct bpf_reg_state, var_off)) == 0 && 652 range_within(rold, rcur) && tnum_in(rold->var_off, rcur->var_off); 653 default: 654 return regs_exact(rold, rcur, idmap); 655 } 656 } 657 658 static struct bpf_reg_state unbound_reg; 659 660 static __init int unbound_reg_init(void) 661 { 662 bpf_mark_reg_unknown_imprecise(&unbound_reg); 663 return 0; 664 } 665 late_initcall(unbound_reg_init); 666 667 static bool is_spilled_scalar_after(const struct bpf_stack_state *stack, int im) 668 { 669 return stack->slot_type[im] == STACK_SPILL && 670 stack->spilled_ptr.type == SCALAR_VALUE; 671 } 672 673 static bool is_stack_misc_after(struct bpf_verifier_env *env, 674 struct bpf_stack_state *stack, int im) 675 { 676 u32 i; 677 678 for (i = im; i < ARRAY_SIZE(stack->slot_type); ++i) { 679 if ((stack->slot_type[i] == STACK_MISC) || 680 ((stack->slot_type[i] == STACK_INVALID || stack->slot_type[i] == STACK_POISON) && 681 env->allow_uninit_stack)) 682 continue; 683 return false; 684 } 685 686 return true; 687 } 688 689 static struct bpf_reg_state *scalar_reg_for_stack(struct bpf_verifier_env *env, 690 struct bpf_stack_state *stack, int im) 691 { 692 if (is_spilled_scalar_after(stack, im)) 693 return &stack->spilled_ptr; 694 695 if (is_stack_misc_after(env, stack, im)) 696 return &unbound_reg; 697 698 return NULL; 699 } 700 701 static bool stacksafe(struct bpf_verifier_env *env, struct bpf_func_state *old, 702 struct bpf_func_state *cur, struct bpf_idmap *idmap, 703 enum exact_level exact) 704 { 705 int i, spi; 706 707 /* walk slots of the explored stack and ignore any additional 708 * slots in the current stack, since explored(safe) state 709 * didn't use them 710 */ 711 for (i = 0; i < old->allocated_stack; i++) { 712 struct bpf_stack_state *old_slot, *cur_slot; 713 struct bpf_reg_state *old_reg, *cur_reg; 714 int im = i % BPF_REG_SIZE; 715 u8 old_type; 716 717 spi = i / BPF_REG_SIZE; 718 old_slot = bpf_stack_slot(old, spi); 719 old_type = old_slot->slot_type[im]; 720 cur_slot = i < cur->allocated_stack ? bpf_stack_slot(cur, spi) : NULL; 721 722 if (exact == EXACT) { 723 u8 cur_type = cur_slot ? cur_slot->slot_type[im] : STACK_INVALID; 724 725 /* STACK_INVALID and STACK_POISON are equivalent for pruning */ 726 if (old_type == STACK_POISON) 727 old_type = STACK_INVALID; 728 if (cur_type == STACK_POISON) 729 cur_type = STACK_INVALID; 730 if (!cur_slot || old_type != cur_type) 731 return false; 732 } 733 734 if (old_type == STACK_INVALID || old_type == STACK_POISON) 735 continue; 736 737 if (env->allow_uninit_stack && old_type == STACK_MISC) 738 continue; 739 740 /* explored stack has more populated slots than current stack 741 * and these slots were used 742 */ 743 if (!cur_slot) 744 return false; 745 746 /* 747 * 64 and 32-bit scalar spills vs MISC/INVALID slots and vice versa. 748 * Load from MISC/INVALID slots produces unbound scalar. 749 * Construct a fake register for such stack and call 750 * regsafe() to ensure scalar ids are compared. 751 */ 752 if (im == 0 || im == 4) { 753 old_reg = scalar_reg_for_stack(env, old_slot, im); 754 cur_reg = scalar_reg_for_stack(env, cur_slot, im); 755 if (old_reg && cur_reg) { 756 if (!regsafe(env, old_reg, cur_reg, idmap, exact)) 757 return false; 758 i += (im == 0 ? BPF_REG_SIZE - 1 : 3); 759 continue; 760 } 761 } 762 763 /* if old state was safe with misc data in the stack 764 * it will be safe with zero-initialized stack. 765 * The opposite is not true 766 */ 767 if (old_type == STACK_MISC && cur_slot->slot_type[im] == STACK_ZERO) 768 continue; 769 if (old_type != cur_slot->slot_type[im]) 770 /* Ex: old explored (safe) state has STACK_SPILL in 771 * this stack slot, but current has STACK_MISC -> 772 * this verifier states are not equivalent, 773 * return false to continue verification of this path 774 */ 775 return false; 776 if (im != BPF_REG_SIZE - 1) 777 continue; 778 /* Both old and cur are having same slot_type */ 779 switch (old_type) { 780 case STACK_SPILL: 781 /* when explored and current stack slot are both storing 782 * spilled registers, check that stored pointers types 783 * are the same as well. 784 * Ex: explored safe path could have stored 785 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -8} 786 * but current path has stored: 787 * (bpf_reg_state) {.type = PTR_TO_STACK, .off = -16} 788 * such verifier states are not equivalent. 789 * return false to continue verification of this path 790 */ 791 if (!regsafe(env, &old_slot->spilled_ptr, &cur_slot->spilled_ptr, 792 idmap, exact)) 793 return false; 794 break; 795 case STACK_DYNPTR: 796 old_reg = &old_slot->spilled_ptr; 797 cur_reg = &cur_slot->spilled_ptr; 798 if (old_reg->dynptr.type != cur_reg->dynptr.type || 799 old_reg->dynptr.first_slot != cur_reg->dynptr.first_slot || 800 !check_ids(old_reg->id, cur_reg->id, idmap) || 801 !check_ids(old_reg->parent_id, cur_reg->parent_id, idmap)) 802 return false; 803 break; 804 case STACK_ITER: 805 old_reg = &old_slot->spilled_ptr; 806 cur_reg = &cur_slot->spilled_ptr; 807 /* iter.depth is not compared between states as it 808 * doesn't matter for correctness and would otherwise 809 * prevent convergence; we maintain it only to prevent 810 * infinite loop check triggering, see 811 * iter_active_depths_differ() 812 */ 813 if (old_reg->type != cur_reg->type || 814 old_reg->iter.btf != cur_reg->iter.btf || 815 old_reg->iter.btf_id != cur_reg->iter.btf_id || 816 old_reg->iter.state != cur_reg->iter.state || 817 /* ignore {old_reg,cur_reg}->iter.depth, see above */ 818 !check_ids(old_reg->id, cur_reg->id, idmap)) 819 return false; 820 break; 821 case STACK_IRQ_FLAG: 822 old_reg = &old_slot->spilled_ptr; 823 cur_reg = &cur_slot->spilled_ptr; 824 if (!check_ids(old_reg->id, cur_reg->id, idmap) || 825 old_reg->irq.kfunc_class != cur_reg->irq.kfunc_class) 826 return false; 827 break; 828 case STACK_MISC: 829 case STACK_ZERO: 830 case STACK_INVALID: 831 case STACK_POISON: 832 continue; 833 /* Ensure that new unhandled slot types return false by default */ 834 default: 835 return false; 836 } 837 } 838 return true; 839 } 840 841 /* 842 * Compare stack arg slots between old and current states. 843 * Outgoing stack args are path-local state and must agree for pruning. 844 */ 845 static bool stack_arg_safe(struct bpf_verifier_env *env, struct bpf_func_state *old, 846 struct bpf_func_state *cur, struct bpf_idmap *idmap, 847 enum exact_level exact) 848 { 849 int i, nslots; 850 851 nslots = max(old->out_stack_arg_cnt, cur->out_stack_arg_cnt); 852 for (i = 0; i < nslots; i++) { 853 struct bpf_reg_state *old_arg, *cur_arg; 854 struct bpf_reg_state not_init = { .type = NOT_INIT }; 855 856 old_arg = i < old->out_stack_arg_cnt ? 857 &old->stack_arg_regs[i] : ¬_init; 858 cur_arg = i < cur->out_stack_arg_cnt ? 859 &cur->stack_arg_regs[i] : ¬_init; 860 if (!regsafe(env, old_arg, cur_arg, idmap, exact)) 861 return false; 862 } 863 864 return true; 865 } 866 867 static bool refsafe(struct bpf_verifier_state *old, struct bpf_verifier_state *cur, 868 struct bpf_idmap *idmap) 869 { 870 int i; 871 872 if (old->acquired_refs != cur->acquired_refs) 873 return false; 874 875 if (old->active_locks != cur->active_locks) 876 return false; 877 878 if (old->active_preempt_locks != cur->active_preempt_locks) 879 return false; 880 881 if (old->active_rcu_locks != cur->active_rcu_locks) 882 return false; 883 884 if (!check_ids(old->active_irq_id, cur->active_irq_id, idmap)) 885 return false; 886 887 if (!check_ids(old->active_lock_id, cur->active_lock_id, idmap) || 888 old->active_lock_ptr != cur->active_lock_ptr) 889 return false; 890 891 for (i = 0; i < old->acquired_refs; i++) { 892 if (!check_ids(old->refs[i].id, cur->refs[i].id, idmap) || 893 old->refs[i].type != cur->refs[i].type) 894 return false; 895 switch (old->refs[i].type) { 896 case REF_TYPE_PTR: 897 if (!check_ids(old->refs[i].parent_id, cur->refs[i].parent_id, idmap)) 898 return false; 899 break; 900 case REF_TYPE_IRQ: 901 break; 902 case REF_TYPE_LOCK: 903 case REF_TYPE_RES_LOCK: 904 case REF_TYPE_RES_LOCK_IRQ: 905 if (old->refs[i].ptr != cur->refs[i].ptr) 906 return false; 907 break; 908 default: 909 WARN_ONCE(1, "Unhandled enum type for reference state: %d\n", old->refs[i].type); 910 return false; 911 } 912 } 913 914 return true; 915 } 916 917 /* compare two verifier states 918 * 919 * all states stored in state_list are known to be valid, since 920 * verifier reached 'bpf_exit' instruction through them 921 * 922 * this function is called when verifier exploring different branches of 923 * execution popped from the state stack. If it sees an old state that has 924 * more strict register state and more strict stack state then this execution 925 * branch doesn't need to be explored further, since verifier already 926 * concluded that more strict state leads to valid finish. 927 * 928 * Therefore two states are equivalent if register state is more conservative 929 * and explored stack state is more conservative than the current one. 930 * Example: 931 * explored current 932 * (slot1=INV slot2=MISC) == (slot1=MISC slot2=MISC) 933 * (slot1=MISC slot2=MISC) != (slot1=INV slot2=MISC) 934 * 935 * In other words if current stack state (one being explored) has more 936 * valid slots than old one that already passed validation, it means 937 * the verifier can stop exploring and conclude that current state is valid too 938 * 939 * Similarly with registers. If explored state has register type as invalid 940 * whereas register type in current state is meaningful, it means that 941 * the current state will reach 'bpf_exit' instruction safely 942 */ 943 static bool func_states_equal(struct bpf_verifier_env *env, struct bpf_func_state *old, 944 struct bpf_func_state *cur, u32 insn_idx, enum exact_level exact) 945 { 946 u16 live_regs = env->insn_aux_data[insn_idx].live_regs_before; 947 u16 i; 948 949 if (old->callback_depth > cur->callback_depth) 950 return false; 951 952 if (!old->no_stack_arg_load && cur->no_stack_arg_load) 953 return false; 954 955 for (i = 0; i < MAX_BPF_REG; i++) 956 if (((1 << i) & live_regs) && 957 !regsafe(env, &old->regs[i], &cur->regs[i], 958 &env->idmap_scratch, exact)) 959 return false; 960 961 if (!stacksafe(env, old, cur, &env->idmap_scratch, exact)) 962 return false; 963 964 if (!stack_arg_safe(env, old, cur, &env->idmap_scratch, exact)) 965 return false; 966 967 return true; 968 } 969 970 static void reset_idmap_scratch(struct bpf_verifier_env *env) 971 { 972 struct bpf_idmap *idmap = &env->idmap_scratch; 973 974 idmap->tmp_id_gen = env->id_gen; 975 idmap->cnt = 0; 976 } 977 978 static bool states_equal(struct bpf_verifier_env *env, 979 struct bpf_verifier_state *old, 980 struct bpf_verifier_state *cur, 981 enum exact_level exact) 982 { 983 u32 insn_idx; 984 int i; 985 986 if (old->curframe != cur->curframe) 987 return false; 988 989 reset_idmap_scratch(env); 990 991 /* Verification state from speculative execution simulation 992 * must never prune a non-speculative execution one. 993 */ 994 if (old->speculative && !cur->speculative) 995 return false; 996 997 if (old->in_sleepable != cur->in_sleepable) 998 return false; 999 1000 if (!refsafe(old, cur, &env->idmap_scratch)) 1001 return false; 1002 1003 /* for states to be equal callsites have to be the same 1004 * and all frame states need to be equivalent 1005 */ 1006 for (i = 0; i <= old->curframe; i++) { 1007 insn_idx = bpf_frame_insn_idx(old, i); 1008 if (old->frame[i]->callsite != cur->frame[i]->callsite) 1009 return false; 1010 if (!func_states_equal(env, old->frame[i], cur->frame[i], insn_idx, exact)) 1011 return false; 1012 } 1013 return true; 1014 } 1015 1016 /* find precise scalars in the previous equivalent state and 1017 * propagate them into the current state 1018 */ 1019 static int propagate_precision(struct bpf_verifier_env *env, 1020 const struct bpf_verifier_state *old, 1021 struct bpf_verifier_state *cur, 1022 bool *changed) 1023 { 1024 struct bpf_reg_state *state_reg; 1025 struct bpf_func_state *state; 1026 int i, err = 0, fr; 1027 bool first; 1028 1029 for (fr = old->curframe; fr >= 0; fr--) { 1030 state = old->frame[fr]; 1031 state_reg = state->regs; 1032 first = true; 1033 for (i = 0; i < BPF_REG_FP; i++, state_reg++) { 1034 if (state_reg->type != SCALAR_VALUE || 1035 !state_reg->precise) 1036 continue; 1037 if (env->log.level & BPF_LOG_LEVEL2) { 1038 if (first) 1039 verbose(env, "frame %d: propagating r%d", fr, i); 1040 else 1041 verbose(env, ",r%d", i); 1042 } 1043 bpf_bt_set_frame_reg(&env->bt, fr, i); 1044 first = false; 1045 } 1046 1047 for (i = 0; i < bpf_stack_nr_slots(state); i++) { 1048 struct bpf_stack_state *ss = bpf_stack_slot(state, i); 1049 1050 if (!bpf_is_spilled_reg(ss)) 1051 continue; 1052 state_reg = &ss->spilled_ptr; 1053 if (state_reg->type != SCALAR_VALUE || 1054 !state_reg->precise) 1055 continue; 1056 if (env->log.level & BPF_LOG_LEVEL2) { 1057 if (first) 1058 verbose(env, "frame %d: propagating fp%d", 1059 fr, (-i - 1) * BPF_REG_SIZE); 1060 else 1061 verbose(env, ",fp%d", (-i - 1) * BPF_REG_SIZE); 1062 } 1063 bpf_bt_set_frame_slot(&env->bt, fr, i); 1064 first = false; 1065 } 1066 if (!first && (env->log.level & BPF_LOG_LEVEL2)) 1067 verbose(env, "\n"); 1068 } 1069 1070 err = bpf_mark_chain_precision(env, cur, -1, changed); 1071 if (err < 0) 1072 return err; 1073 1074 return 0; 1075 } 1076 1077 #define MAX_BACKEDGE_ITERS 64 1078 1079 /* Propagate read and precision marks from visit->backedges[*].state->equal_state 1080 * to corresponding parent states of visit->backedges[*].state until fixed point is reached, 1081 * then free visit->backedges. 1082 * After execution of this function incomplete_read_marks() will return false 1083 * for all states corresponding to @visit->callchain. 1084 */ 1085 static int propagate_backedges(struct bpf_verifier_env *env, struct bpf_scc_visit *visit) 1086 { 1087 struct bpf_scc_backedge *backedge; 1088 struct bpf_verifier_state *st; 1089 bool changed; 1090 int i, err; 1091 1092 i = 0; 1093 do { 1094 if (i++ > MAX_BACKEDGE_ITERS) { 1095 if (env->log.level & BPF_LOG_LEVEL2) 1096 verbose(env, "%s: too many iterations\n", __func__); 1097 for (backedge = visit->backedges; backedge; backedge = backedge->next) 1098 bpf_mark_all_scalars_precise(env, &backedge->state); 1099 break; 1100 } 1101 changed = false; 1102 for (backedge = visit->backedges; backedge; backedge = backedge->next) { 1103 st = &backedge->state; 1104 err = propagate_precision(env, st->equal_state, st, &changed); 1105 if (err) 1106 return err; 1107 } 1108 } while (changed); 1109 1110 bpf_free_backedges(visit); 1111 return 0; 1112 } 1113 1114 static bool states_maybe_looping(struct bpf_verifier_state *old, 1115 struct bpf_verifier_state *cur) 1116 { 1117 struct bpf_func_state *fold, *fcur; 1118 int i, fr = cur->curframe; 1119 1120 if (old->curframe != fr) 1121 return false; 1122 1123 fold = old->frame[fr]; 1124 fcur = cur->frame[fr]; 1125 for (i = 0; i < MAX_BPF_REG; i++) 1126 if (memcmp(&fold->regs[i], &fcur->regs[i], 1127 offsetof(struct bpf_reg_state, precise))) 1128 return false; 1129 return true; 1130 } 1131 1132 /* is_state_visited() handles iter_next() (see process_iter_next_call() for 1133 * terminology) calls specially: as opposed to bounded BPF loops, it *expects* 1134 * states to match, which otherwise would look like an infinite loop. So while 1135 * iter_next() calls are taken care of, we still need to be careful and 1136 * prevent erroneous and too eager declaration of "infinite loop", when 1137 * iterators are involved. 1138 * 1139 * Here's a situation in pseudo-BPF assembly form: 1140 * 1141 * 0: again: ; set up iter_next() call args 1142 * 1: r1 = &it ; <CHECKPOINT HERE> 1143 * 2: call bpf_iter_num_next ; this is iter_next() call 1144 * 3: if r0 == 0 goto done 1145 * 4: ... something useful here ... 1146 * 5: goto again ; another iteration 1147 * 6: done: 1148 * 7: r1 = &it 1149 * 8: call bpf_iter_num_destroy ; clean up iter state 1150 * 9: exit 1151 * 1152 * This is a typical loop. Let's assume that we have a prune point at 1:, 1153 * before we get to `call bpf_iter_num_next` (e.g., because of that `goto 1154 * again`, assuming other heuristics don't get in a way). 1155 * 1156 * When we first time come to 1:, let's say we have some state X. We proceed 1157 * to 2:, fork states, enqueue ACTIVE, validate NULL case successfully, exit. 1158 * Now we come back to validate that forked ACTIVE state. We proceed through 1159 * 3-5, come to goto, jump to 1:. Let's assume our state didn't change, so we 1160 * are converging. But the problem is that we don't know that yet, as this 1161 * convergence has to happen at iter_next() call site only. So if nothing is 1162 * done, at 1: verifier will use bounded loop logic and declare infinite 1163 * looping (and would be *technically* correct, if not for iterator's 1164 * "eventual sticky NULL" contract, see process_iter_next_call()). But we 1165 * don't want that. So what we do in process_iter_next_call() when we go on 1166 * another ACTIVE iteration, we bump slot->iter.depth, to mark that it's 1167 * a different iteration. So when we suspect an infinite loop, we additionally 1168 * check if any of the *ACTIVE* iterator states depths differ. If yes, we 1169 * pretend we are not looping and wait for next iter_next() call. 1170 * 1171 * This only applies to ACTIVE state. In DRAINED state we don't expect to 1172 * loop, because that would actually mean infinite loop, as DRAINED state is 1173 * "sticky", and so we'll keep returning into the same instruction with the 1174 * same state (at least in one of possible code paths). 1175 * 1176 * This approach allows to keep infinite loop heuristic even in the face of 1177 * active iterator. E.g., C snippet below is and will be detected as 1178 * infinitely looping: 1179 * 1180 * struct bpf_iter_num it; 1181 * int *p, x; 1182 * 1183 * bpf_iter_num_new(&it, 0, 10); 1184 * while ((p = bpf_iter_num_next(&t))) { 1185 * x = p; 1186 * while (x--) {} // <<-- infinite loop here 1187 * } 1188 * 1189 */ 1190 static bool iter_active_depths_differ(struct bpf_verifier_state *old, struct bpf_verifier_state *cur) 1191 { 1192 struct bpf_reg_state *slot, *cur_slot; 1193 struct bpf_func_state *state; 1194 int i, fr; 1195 1196 for (fr = old->curframe; fr >= 0; fr--) { 1197 state = old->frame[fr]; 1198 for (i = 0; i < bpf_stack_nr_slots(state); i++) { 1199 struct bpf_stack_state *ss = bpf_stack_slot(state, i); 1200 1201 if (ss->slot_type[0] != STACK_ITER) 1202 continue; 1203 1204 slot = &ss->spilled_ptr; 1205 if (slot->iter.state != BPF_ITER_STATE_ACTIVE) 1206 continue; 1207 1208 cur_slot = &bpf_stack_slot(cur->frame[fr], i)->spilled_ptr; 1209 if (cur_slot->iter.depth != slot->iter.depth) 1210 return true; 1211 } 1212 } 1213 return false; 1214 } 1215 1216 static void mark_all_scalars_imprecise(struct bpf_verifier_env *env, struct bpf_verifier_state *st) 1217 { 1218 struct bpf_func_state *func; 1219 struct bpf_reg_state *reg; 1220 int i, j; 1221 1222 for (i = 0; i <= st->curframe; i++) { 1223 func = st->frame[i]; 1224 for (j = 0; j < BPF_REG_FP; j++) { 1225 reg = &func->regs[j]; 1226 if (reg->type != SCALAR_VALUE) 1227 continue; 1228 reg->precise = false; 1229 } 1230 for (j = 0; j < bpf_stack_nr_slots(func); j++) { 1231 struct bpf_stack_state *ss = bpf_stack_slot(func, j); 1232 1233 if (!bpf_is_spilled_reg(ss)) 1234 continue; 1235 reg = &ss->spilled_ptr; 1236 if (reg->type != SCALAR_VALUE) 1237 continue; 1238 reg->precise = false; 1239 } 1240 } 1241 } 1242 1243 int bpf_is_state_visited(struct bpf_verifier_env *env, int insn_idx) 1244 { 1245 struct bpf_verifier_state_list *new_sl; 1246 struct bpf_verifier_state_list *sl; 1247 struct bpf_verifier_state *cur = env->cur_state, *new; 1248 bool force_new_state, add_new_state, loop; 1249 int n, err, states_cnt = 0; 1250 struct list_head *pos, *tmp, *head; 1251 1252 force_new_state = env->test_state_freq || bpf_is_force_checkpoint(env, insn_idx) || 1253 /* Avoid accumulating infinitely long jmp history */ 1254 cur->jmp_history_cnt > 40; 1255 1256 /* bpf progs typically have pruning point every 4 instructions 1257 * http://vger.kernel.org/bpfconf2019.html#session-1 1258 * Do not add new state for future pruning if the verifier hasn't seen 1259 * at least 2 jumps and at least 8 instructions. 1260 * This heuristics helps decrease 'total_states' and 'peak_states' metric. 1261 * In tests that amounts to up to 50% reduction into total verifier 1262 * memory consumption and 20% verifier time speedup. 1263 */ 1264 add_new_state = force_new_state; 1265 if (env->jmps_processed - env->prev_jmps_processed >= 2 && 1266 env->insn_processed - env->prev_insn_processed >= 8) 1267 add_new_state = true; 1268 1269 /* keep cleaning the current state as registers/stack become dead */ 1270 err = clean_verifier_state(env, cur); 1271 if (err) 1272 return err; 1273 1274 loop = false; 1275 head = bpf_explored_state(env, insn_idx); 1276 list_for_each_safe(pos, tmp, head) { 1277 sl = container_of(pos, struct bpf_verifier_state_list, node); 1278 states_cnt++; 1279 if (sl->state.insn_idx != insn_idx) 1280 continue; 1281 1282 if (sl->state.branches) { 1283 struct bpf_func_state *frame = sl->state.frame[0]; 1284 1285 if (frame->in_async_callback_fn && 1286 frame->async_entry_cnt != cur->frame[0]->async_entry_cnt) { 1287 /* Different async_entry_cnt means that the verifier is 1288 * processing another entry into async callback. 1289 * Seeing the same state is not an indication of infinite 1290 * loop or infinite recursion. 1291 * But finding the same state doesn't mean that it's safe 1292 * to stop processing the current state. The previous state 1293 * hasn't yet reached bpf_exit, since state.branches > 0. 1294 * Checking in_async_callback_fn alone is not enough either. 1295 * Since the verifier still needs to catch infinite loops 1296 * inside async callbacks. 1297 */ 1298 goto skip_inf_loop_check; 1299 } 1300 /* BPF open-coded iterators loop detection is special. 1301 * states_maybe_looping() logic is too simplistic in detecting 1302 * states that *might* be equivalent, because it doesn't know 1303 * about ID remapping, so don't even perform it. 1304 * See process_iter_next_call() and iter_active_depths_differ() 1305 * for overview of the logic. When current and one of parent 1306 * states are detected as equivalent, it's a good thing: we prove 1307 * convergence and can stop simulating further iterations. 1308 * It's safe to assume that iterator loop will finish, taking into 1309 * account iter_next() contract of eventually returning 1310 * sticky NULL result. 1311 * 1312 * Note, that states have to be compared exactly in this case because 1313 * read and precision marks might not be finalized inside the loop. 1314 * E.g. as in the program below: 1315 * 1316 * 1. r7 = -16 1317 * 2. r6 = bpf_get_prandom_u32() 1318 * 3. while (bpf_iter_num_next(&fp[-8])) { 1319 * 4. if (r6 != 42) { 1320 * 5. r7 = -32 1321 * 6. r6 = bpf_get_prandom_u32() 1322 * 7. continue 1323 * 8. } 1324 * 9. r0 = r10 1325 * 10. r0 += r7 1326 * 11. r8 = *(u64 *)(r0 + 0) 1327 * 12. r6 = bpf_get_prandom_u32() 1328 * 13. } 1329 * 1330 * Here verifier would first visit path 1-3, create a checkpoint at 3 1331 * with r7=-16, continue to 4-7,3. Existing checkpoint at 3 does 1332 * not have read or precision mark for r7 yet, thus inexact states 1333 * comparison would discard current state with r7=-32 1334 * => unsafe memory access at 11 would not be caught. 1335 */ 1336 if (is_iter_next_insn(env, insn_idx)) { 1337 if (states_equal(env, &sl->state, cur, RANGE_WITHIN)) { 1338 struct bpf_func_state *cur_frame, *iter_frame, *old_frame; 1339 struct bpf_reg_state *iter_state, *iter_reg; 1340 struct bpf_reg_state *old_iter; 1341 int spi; 1342 1343 cur_frame = cur->frame[cur->curframe]; 1344 /* btf_check_iter_kfuncs() enforces that 1345 * iter state pointer is always the first arg 1346 */ 1347 iter_reg = &cur_frame->regs[BPF_REG_1]; 1348 /* current state is valid due to states_equal(), 1349 * so we can assume valid iter and reg state, 1350 * no need for extra (re-)validations 1351 */ 1352 spi = bpf_get_spi(iter_reg->var_off.value); 1353 iter_frame = bpf_func(env, iter_reg); 1354 iter_state = &bpf_stack_slot(iter_frame, spi)->spilled_ptr; 1355 old_frame = sl->state.frame[iter_reg->frameno]; 1356 old_iter = &bpf_stack_slot(old_frame, spi)->spilled_ptr; 1357 /* 1358 * states_equal() matches ids through idmap. 1359 * The loop converged only if it's the same 1360 * iterator. The one that was destroyed and 1361 * created again starts from the beginning. 1362 */ 1363 if (iter_state->iter.state == BPF_ITER_STATE_ACTIVE && 1364 iter_state->id == old_iter->id) { 1365 loop = true; 1366 goto hit; 1367 } 1368 } 1369 goto skip_inf_loop_check; 1370 } 1371 if (is_may_goto_insn_at(env, insn_idx)) { 1372 if (sl->state.may_goto_depth != cur->may_goto_depth && 1373 states_equal(env, &sl->state, cur, RANGE_WITHIN)) { 1374 loop = true; 1375 goto hit; 1376 } 1377 } 1378 if (bpf_calls_callback(env, insn_idx)) { 1379 if (states_equal(env, &sl->state, cur, RANGE_WITHIN)) { 1380 loop = true; 1381 goto hit; 1382 } 1383 goto skip_inf_loop_check; 1384 } 1385 /* attempt to detect infinite loop to avoid unnecessary doomed work */ 1386 if (states_maybe_looping(&sl->state, cur) && 1387 states_equal(env, &sl->state, cur, EXACT) && 1388 !iter_active_depths_differ(&sl->state, cur) && 1389 sl->state.may_goto_depth == cur->may_goto_depth && 1390 sl->state.callback_unroll_depth == cur->callback_unroll_depth) { 1391 verbose_linfo(env, insn_idx, "; "); 1392 verbose(env, "infinite loop detected at insn %d\n", insn_idx); 1393 verbose(env, "cur state:"); 1394 print_verifier_state(env, cur, cur->curframe, true); 1395 verbose(env, "old state:"); 1396 print_verifier_state(env, &sl->state, cur->curframe, true); 1397 return -EINVAL; 1398 } 1399 /* if the verifier is processing a loop, avoid adding new state 1400 * too often, since different loop iterations have distinct 1401 * states and may not help future pruning. 1402 * This threshold shouldn't be too low to make sure that 1403 * a loop with large bound will be rejected quickly. 1404 * The most abusive loop will be: 1405 * r1 += 1 1406 * if r1 < 1000000 goto pc-2 1407 * 1M insn_procssed limit / 100 == 10k peak states. 1408 * This threshold shouldn't be too high either, since states 1409 * at the end of the loop are likely to be useful in pruning. 1410 */ 1411 skip_inf_loop_check: 1412 if (!force_new_state && 1413 env->jmps_processed - env->prev_jmps_processed < 20 && 1414 env->insn_processed - env->prev_insn_processed < 100) 1415 add_new_state = false; 1416 goto miss; 1417 } 1418 /* See comments for mark_all_regs_read_and_precise() */ 1419 loop = incomplete_read_marks(env, &sl->state); 1420 if (states_equal(env, &sl->state, cur, loop ? RANGE_WITHIN : NOT_EXACT)) { 1421 hit: 1422 sl->hit_cnt++; 1423 1424 /* if previous state reached the exit with precision and 1425 * current state is equivalent to it (except precision marks) 1426 * the precision needs to be propagated back in 1427 * the current state. 1428 */ 1429 err = 0; 1430 if (bpf_is_jmp_point(env, env->insn_idx)) 1431 err = bpf_push_jmp_history(env, cur, 0, 0, 0, NULL, 0); 1432 err = err ? : propagate_precision(env, &sl->state, cur, NULL); 1433 if (err) 1434 return err; 1435 /* When processing iterator based loops above propagate_liveness and 1436 * propagate_precision calls are not sufficient to transfer all relevant 1437 * read and precision marks. E.g. consider the following case: 1438 * 1439 * .-> A --. Assume the states are visited in the order A, B, C. 1440 * | | | Assume that state B reaches a state equivalent to state A. 1441 * | v v At this point, state C is not processed yet, so state A 1442 * '-- B C has not received any read or precision marks from C. 1443 * Thus, marks propagated from A to B are incomplete. 1444 * 1445 * The verifier mitigates this by performing the following steps: 1446 * 1447 * - Prior to the main verification pass, strongly connected components 1448 * (SCCs) are computed over the program's control flow graph, 1449 * intraprocedurally. 1450 * 1451 * - During the main verification pass, `maybe_enter_scc()` checks 1452 * whether the current verifier state is entering an SCC. If so, an 1453 * instance of a `bpf_scc_visit` object is created, and the state 1454 * entering the SCC is recorded as the entry state. 1455 * 1456 * - This instance is associated not with the SCC itself, but with a 1457 * `bpf_scc_callchain`: a tuple consisting of the call sites leading to 1458 * the SCC and the SCC id. See `compute_scc_callchain()`. 1459 * 1460 * - When a verification path encounters a `states_equal(..., 1461 * RANGE_WITHIN)` condition, there exists a call chain describing the 1462 * current state and a corresponding `bpf_scc_visit` instance. A copy 1463 * of the current state is created and added to 1464 * `bpf_scc_visit->backedges`. 1465 * 1466 * - When a verification path terminates, `maybe_exit_scc()` is called 1467 * from `bpf_update_branch_counts()`. For states with `branches == 0`, it 1468 * checks whether the state is the entry state of any `bpf_scc_visit` 1469 * instance. If it is, this indicates that all paths originating from 1470 * this SCC visit have been explored. `propagate_backedges()` is then 1471 * called, which propagates read and precision marks through the 1472 * backedges until a fixed point is reached. 1473 * (In the earlier example, this would propagate marks from A to B, 1474 * from C to A, and then again from A to B.) 1475 * 1476 * A note on callchains 1477 * -------------------- 1478 * 1479 * Consider the following example: 1480 * 1481 * void foo() { loop { ... SCC#1 ... } } 1482 * void main() { 1483 * A: foo(); 1484 * B: ... 1485 * C: foo(); 1486 * } 1487 * 1488 * Here, there are two distinct callchains leading to SCC#1: 1489 * - (A, SCC#1) 1490 * - (C, SCC#1) 1491 * 1492 * Each callchain identifies a separate `bpf_scc_visit` instance that 1493 * accumulates backedge states. The `propagate_{liveness,precision}()` 1494 * functions traverse the parent state of each backedge state, which 1495 * means these parent states must remain valid (i.e., not freed) while 1496 * the corresponding `bpf_scc_visit` instance exists. 1497 * 1498 * Associating `bpf_scc_visit` instances directly with SCCs instead of 1499 * callchains would break this invariant: 1500 * - States explored during `C: foo()` would contribute backedges to 1501 * SCC#1, but SCC#1 would only be exited once the exploration of 1502 * `A: foo()` completes. 1503 * - By that time, the states explored between `A: foo()` and `C: foo()` 1504 * (i.e., `B: ...`) may have already been freed, causing the parent 1505 * links for states from `C: foo()` to become invalid. 1506 */ 1507 if (loop) { 1508 struct bpf_scc_backedge *backedge; 1509 1510 backedge = kzalloc_obj(*backedge, 1511 GFP_KERNEL_ACCOUNT); 1512 if (!backedge) 1513 return -ENOMEM; 1514 err = bpf_copy_verifier_state(&backedge->state, cur); 1515 backedge->state.equal_state = &sl->state; 1516 backedge->state.insn_idx = insn_idx; 1517 err = err ?: add_scc_backedge(env, &sl->state, backedge); 1518 if (err) { 1519 bpf_free_verifier_state(&backedge->state, false); 1520 kfree(backedge); 1521 return err; 1522 } 1523 } 1524 return 1; 1525 } 1526 miss: 1527 /* when new state is not going to be added do not increase miss count. 1528 * Otherwise several loop iterations will remove the state 1529 * recorded earlier. The goal of these heuristics is to have 1530 * states from some iterations of the loop (some in the beginning 1531 * and some at the end) to help pruning. 1532 */ 1533 if (add_new_state) 1534 sl->miss_cnt++; 1535 /* heuristic to determine whether this state is beneficial 1536 * to keep checking from state equivalence point of view. 1537 * Higher numbers increase max_states_per_insn and verification time, 1538 * but do not meaningfully decrease insn_processed. 1539 * 'n' controls how many times state could miss before eviction. 1540 * Use bigger 'n' for checkpoints because evicting checkpoint states 1541 * too early would hinder iterator convergence. 1542 */ 1543 n = bpf_is_force_checkpoint(env, insn_idx) && sl->state.branches > 0 ? 64 : 3; 1544 if (sl->miss_cnt > sl->hit_cnt * n + n) { 1545 /* the state is unlikely to be useful. Remove it to 1546 * speed up verification 1547 */ 1548 sl->in_free_list = true; 1549 list_del(&sl->node); 1550 list_add(&sl->node, &env->free_list); 1551 env->free_list_size++; 1552 env->explored_states_size--; 1553 maybe_free_verifier_state(env, sl); 1554 } 1555 } 1556 1557 if (env->max_states_per_insn < states_cnt) 1558 env->max_states_per_insn = states_cnt; 1559 1560 if (!env->bpf_capable && states_cnt > BPF_COMPLEXITY_LIMIT_STATES) 1561 return 0; 1562 1563 if (!add_new_state) 1564 return 0; 1565 1566 /* There were no equivalent states, remember the current one. 1567 * Technically the current state is not proven to be safe yet, 1568 * but it will either reach outer most bpf_exit (which means it's safe) 1569 * or it will be rejected. When there are no loops the verifier won't be 1570 * seeing this tuple (frame[0].callsite, frame[1].callsite, .. insn_idx) 1571 * again on the way to bpf_exit. 1572 * When looping the sl->state.branches will be > 0 and this state 1573 * will not be considered for equivalence until branches == 0. 1574 */ 1575 new_sl = kzalloc_obj(struct bpf_verifier_state_list, GFP_KERNEL_ACCOUNT); 1576 if (!new_sl) 1577 return -ENOMEM; 1578 env->total_states++; 1579 env->explored_states_size++; 1580 update_peak_states(env); 1581 env->prev_jmps_processed = env->jmps_processed; 1582 env->prev_insn_processed = env->insn_processed; 1583 1584 /* forget precise markings we inherited, see __mark_chain_precision */ 1585 if (env->bpf_capable) 1586 mark_all_scalars_imprecise(env, cur); 1587 1588 bpf_clear_singular_ids(env, cur); 1589 1590 /* add new state to the head of linked list */ 1591 new = &new_sl->state; 1592 err = bpf_copy_verifier_state(new, cur); 1593 if (err) { 1594 bpf_free_verifier_state(new, false); 1595 kfree(new_sl); 1596 return err; 1597 } 1598 new->insn_idx = insn_idx; 1599 verifier_bug_if(new->branches != 1, env, 1600 "%s:branches_to_explore=%d insn %d", 1601 __func__, new->branches, insn_idx); 1602 err = maybe_enter_scc(env, new); 1603 if (err) { 1604 bpf_free_verifier_state(new, false); 1605 kfree(new_sl); 1606 return err; 1607 } 1608 1609 cur->parent = new; 1610 cur->first_insn_idx = insn_idx; 1611 cur->dfs_depth = new->dfs_depth + 1; 1612 bpf_clear_jmp_history(cur); 1613 list_add(&new_sl->node, head); 1614 return 0; 1615 } 1616