xref: /linux/fs/ext4/dir.c (revision 62597edf6340191511bdf9a7f64fa315ddc58805)
1 // SPDX-License-Identifier: GPL-2.0
2 /*
3  *  linux/fs/ext4/dir.c
4  *
5  * Copyright (C) 1992, 1993, 1994, 1995
6  * Remy Card (card@masi.ibp.fr)
7  * Laboratoire MASI - Institut Blaise Pascal
8  * Universite Pierre et Marie Curie (Paris VI)
9  *
10  *  from
11  *
12  *  linux/fs/minix/dir.c
13  *
14  *  Copyright (C) 1991, 1992  Linus Torvalds
15  *
16  *  ext4 directory handling functions
17  *
18  *  Big-endian to little-endian byte-swapping/bitmaps by
19  *        David S. Miller (davem@caip.rutgers.edu), 1995
20  *
21  * Hash Tree Directory indexing (c) 2001  Daniel Phillips
22  *
23  */
24 
25 #include <linux/fs.h>
26 #include <linux/buffer_head.h>
27 #include <linux/slab.h>
28 #include <linux/iversion.h>
29 #include <linux/unicode.h>
30 #include "ext4.h"
31 #include "xattr.h"
32 
33 static int ext4_dx_readdir(struct file *, struct dir_context *);
34 
35 /**
36  * is_dx_dir() - check if a directory is using htree indexing
37  * @inode: directory inode
38  *
39  * Check if the given dir-inode refers to an htree-indexed directory
40  * (or a directory which could potentially get converted to use htree
41  * indexing).
42  *
43  * Return 1 if it is a dx dir, 0 if not
44  */
45 static int is_dx_dir(struct inode *inode)
46 {
47 	struct super_block *sb = inode->i_sb;
48 
49 	if (ext4_has_feature_dir_index(inode->i_sb) &&
50 	    ((ext4_test_inode_flag(inode, EXT4_INODE_INDEX)) ||
51 	     ((inode->i_size >> sb->s_blocksize_bits) == 1) ||
52 	     ext4_has_inline_data(inode)))
53 		return 1;
54 
55 	return 0;
56 }
57 
58 static bool is_fake_dir_entry(struct ext4_dir_entry_2 *de)
59 {
60 	/* Check if . or .. , or skip if namelen is 0 */
61 	if ((de->name_len > 0) && (de->name_len <= 2) && (de->name[0] == '.') &&
62 	    (de->name[1] == '.' || de->name[1] == '\0'))
63 		return true;
64 	/* Check if this is a csum entry */
65 	if (de->file_type == EXT4_FT_DIR_CSUM)
66 		return true;
67 	return false;
68 }
69 
70 /*
71  * Return 0 if the directory entry is OK, and 1 if there is a problem
72  *
73  * Note: this is the opposite of what ext2 and ext3 historically returned...
74  *
75  * bh passed here can be an inode block or a dir data block, depending
76  * on the inode inline data flag.
77  */
78 int __ext4_check_dir_entry(const char *function, unsigned int line,
79 			   struct inode *dir, struct file *filp,
80 			   struct ext4_dir_entry_2 *de,
81 			   struct buffer_head *bh, char *buf, int size,
82 			   unsigned int offset)
83 {
84 	const char *error_msg = NULL;
85 	const int rlen = ext4_rec_len_from_disk(de->rec_len,
86 						dir->i_sb->s_blocksize);
87 	const int next_offset = ((char *) de - buf) + rlen;
88 	bool fake = is_fake_dir_entry(de);
89 	bool has_csum = ext4_has_metadata_csum(dir->i_sb);
90 
91 	if (unlikely(rlen < ext4_dir_rec_len(1, fake ? NULL : dir)))
92 		error_msg = "rec_len is smaller than minimal";
93 	else if (unlikely(rlen % 4 != 0))
94 		error_msg = "rec_len % 4 != 0";
95 	else if (unlikely(rlen < ext4_dir_rec_len(de->name_len,
96 							fake ? NULL : dir)))
97 		error_msg = "rec_len is too small for name_len";
98 	else if (unlikely(next_offset > size))
99 		error_msg = "directory entry overrun";
100 	else if (unlikely(next_offset > size - ext4_dir_rec_len(1,
101 						  has_csum ? NULL : dir) &&
102 			  next_offset != size))
103 		error_msg = "directory entry too close to block end";
104 	else if (unlikely(le32_to_cpu(de->inode) >
105 			le32_to_cpu(EXT4_SB(dir->i_sb)->s_es->s_inodes_count)))
106 		error_msg = "inode out of bounds";
107 	else
108 		return 0;
109 
110 	if (filp)
111 		ext4_error_file(filp, function, line, bh->b_blocknr,
112 				"bad entry in directory: %s - offset=%u, "
113 				"inode=%u, rec_len=%d, size=%d fake=%d",
114 				error_msg, offset, le32_to_cpu(de->inode),
115 				rlen, size, fake);
116 	else
117 		ext4_error_inode(dir, function, line, bh->b_blocknr,
118 				"bad entry in directory: %s - offset=%u, "
119 				"inode=%u, rec_len=%d, size=%d fake=%d",
120 				 error_msg, offset, le32_to_cpu(de->inode),
121 				 rlen, size, fake);
122 
123 	return 1;
124 }
125 
126 static int ext4_readdir(struct file *file, struct dir_context *ctx)
127 {
128 	unsigned int offset;
129 	int i;
130 	struct ext4_dir_entry_2 *de;
131 	int err;
132 	struct inode *inode = file_inode(file);
133 	struct super_block *sb = inode->i_sb;
134 	struct buffer_head *bh = NULL;
135 	struct fscrypt_str fstr = FSTR_INIT(NULL, 0);
136 	struct dir_private_info *info = file->private_data;
137 
138 	err = fscrypt_prepare_readdir(inode);
139 	if (err)
140 		return err;
141 
142 	if (is_dx_dir(inode)) {
143 		err = ext4_dx_readdir(file, ctx);
144 		if (err != ERR_BAD_DX_DIR)
145 			return err;
146 
147 		/* Can we just clear INDEX flag to ignore htree information? */
148 		if (!ext4_has_metadata_csum(sb)) {
149 			/*
150 			 * We don't set the inode dirty flag since it's not
151 			 * critical that it gets flushed back to the disk.
152 			 */
153 			ext4_clear_inode_flag(inode, EXT4_INODE_INDEX);
154 		}
155 	}
156 
157 	if (ext4_has_inline_data(inode)) {
158 		int has_inline_data = 1;
159 		err = ext4_read_inline_dir(file, ctx,
160 					   &has_inline_data);
161 		if (has_inline_data)
162 			return err;
163 	}
164 
165 	if (IS_ENCRYPTED(inode)) {
166 		err = fscrypt_fname_alloc_buffer(EXT4_NAME_LEN, &fstr);
167 		if (err < 0)
168 			return err;
169 	}
170 
171 	while (ctx->pos < inode->i_size) {
172 		struct ext4_map_blocks map;
173 
174 		if (fatal_signal_pending(current)) {
175 			err = -ERESTARTSYS;
176 			goto errout;
177 		}
178 		cond_resched();
179 		offset = ctx->pos & (sb->s_blocksize - 1);
180 		map.m_lblk = ctx->pos >> EXT4_BLOCK_SIZE_BITS(sb);
181 		map.m_len = 1;
182 		err = ext4_map_blocks(NULL, inode, &map, 0);
183 		if (err == 0) {
184 			/* m_len should never be zero but let's avoid
185 			 * an infinite loop if it somehow is */
186 			if (map.m_len == 0)
187 				map.m_len = 1;
188 			ctx->pos += map.m_len * sb->s_blocksize;
189 			continue;
190 		}
191 		if (err > 0) {
192 			pgoff_t index = map.m_pblk >>
193 					(PAGE_SHIFT - inode->i_blkbits);
194 			if (!ra_has_index(&file->f_ra, index))
195 				page_cache_sync_readahead(
196 					sb->s_bdev->bd_mapping,
197 					&file->f_ra, file,
198 					index, 1);
199 			file->f_ra.prev_pos = (loff_t)index << PAGE_SHIFT;
200 			bh = ext4_bread(NULL, inode, map.m_lblk, 0);
201 			if (IS_ERR(bh)) {
202 				err = PTR_ERR(bh);
203 				bh = NULL;
204 				goto errout;
205 			}
206 		}
207 
208 		if (!bh) {
209 			/* corrupt size?  Maybe no more blocks to read */
210 			if (ctx->pos > inode->i_blocks << 9)
211 				break;
212 			ctx->pos += sb->s_blocksize - offset;
213 			continue;
214 		}
215 
216 		/* Check the checksum */
217 		if (!buffer_verified(bh) &&
218 		    !ext4_dirblock_csum_verify(inode, bh)) {
219 			EXT4_ERROR_FILE(file, 0, "directory fails checksum "
220 					"at offset %llu",
221 					(unsigned long long)ctx->pos);
222 			ctx->pos += sb->s_blocksize - offset;
223 			brelse(bh);
224 			bh = NULL;
225 			continue;
226 		}
227 		set_buffer_verified(bh);
228 
229 		/* If the dir block has changed since the last call to
230 		 * readdir(2), then we might be pointing to an invalid
231 		 * dirent right now.  Scan from the start of the block
232 		 * to make sure. */
233 		if (!inode_eq_iversion(inode, info->cookie)) {
234 			for (i = 0; i < sb->s_blocksize && i < offset; ) {
235 				de = (struct ext4_dir_entry_2 *)
236 					(bh->b_data + i);
237 				/* It's too expensive to do a full
238 				 * dirent test each time round this
239 				 * loop, but we do have to test at
240 				 * least that it is non-zero.  A
241 				 * failure will be detected in the
242 				 * dirent test below. */
243 				if (ext4_rec_len_from_disk(de->rec_len,
244 					sb->s_blocksize) < ext4_dir_rec_len(1,
245 									inode))
246 					break;
247 				i += ext4_rec_len_from_disk(de->rec_len,
248 							    sb->s_blocksize);
249 			}
250 			offset = i;
251 			ctx->pos = (ctx->pos & ~(sb->s_blocksize - 1))
252 				| offset;
253 			info->cookie = inode_query_iversion(inode);
254 		}
255 
256 		while (ctx->pos < inode->i_size
257 		       && offset < sb->s_blocksize) {
258 			de = (struct ext4_dir_entry_2 *) (bh->b_data + offset);
259 			if (ext4_check_dir_entry(inode, file, de, bh,
260 						 bh->b_data, bh->b_size,
261 						 offset)) {
262 				/*
263 				 * On error, skip to the next block
264 				 */
265 				ctx->pos = (ctx->pos |
266 						(sb->s_blocksize - 1)) + 1;
267 				break;
268 			}
269 			offset += ext4_rec_len_from_disk(de->rec_len,
270 					sb->s_blocksize);
271 			if (le32_to_cpu(de->inode)) {
272 				if (!IS_ENCRYPTED(inode)) {
273 					if (!dir_emit(ctx, de->name,
274 					    de->name_len,
275 					    le32_to_cpu(de->inode),
276 					    get_dtype(sb, de->file_type)))
277 						goto done;
278 				} else {
279 					int save_len = fstr.len;
280 					struct fscrypt_str de_name =
281 							FSTR_INIT(de->name,
282 								de->name_len);
283 
284 					/* Directory is encrypted */
285 					err = fscrypt_fname_disk_to_usr(inode,
286 						EXT4_DIRENT_HASH(de),
287 						EXT4_DIRENT_MINOR_HASH(de),
288 						&de_name, &fstr);
289 					de_name = fstr;
290 					fstr.len = save_len;
291 					if (err)
292 						goto errout;
293 					if (!dir_emit(ctx,
294 					    de_name.name, de_name.len,
295 					    le32_to_cpu(de->inode),
296 					    get_dtype(sb, de->file_type)))
297 						goto done;
298 				}
299 			}
300 			ctx->pos += ext4_rec_len_from_disk(de->rec_len,
301 						sb->s_blocksize);
302 		}
303 		if ((ctx->pos < inode->i_size) && !dir_relax_shared(inode))
304 			goto done;
305 		brelse(bh);
306 		bh = NULL;
307 	}
308 done:
309 	err = 0;
310 errout:
311 	fscrypt_fname_free_buffer(&fstr);
312 	brelse(bh);
313 	return err;
314 }
315 
316 static inline int is_32bit_api(void)
317 {
318 #ifdef CONFIG_COMPAT
319 	return in_compat_syscall();
320 #else
321 	return (BITS_PER_LONG == 32);
322 #endif
323 }
324 
325 /*
326  * These functions convert from the major/minor hash to an f_pos
327  * value for dx directories
328  *
329  * Upper layer (for example NFS) should specify FMODE_32BITHASH or
330  * FMODE_64BITHASH explicitly. On the other hand, we allow ext4 to be mounted
331  * directly on both 32-bit and 64-bit nodes, under such case, neither
332  * FMODE_32BITHASH nor FMODE_64BITHASH is specified.
333  */
334 static inline loff_t hash2pos(struct file *filp, __u32 major, __u32 minor)
335 {
336 	if ((filp->f_mode & FMODE_32BITHASH) ||
337 	    (!(filp->f_mode & FMODE_64BITHASH) && is_32bit_api()))
338 		return major >> 1;
339 	else
340 		return ((__u64)(major >> 1) << 32) | (__u64)minor;
341 }
342 
343 static inline __u32 pos2maj_hash(struct file *filp, loff_t pos)
344 {
345 	if ((filp->f_mode & FMODE_32BITHASH) ||
346 	    (!(filp->f_mode & FMODE_64BITHASH) && is_32bit_api()))
347 		return (pos << 1) & 0xffffffff;
348 	else
349 		return ((pos >> 32) << 1) & 0xffffffff;
350 }
351 
352 static inline __u32 pos2min_hash(struct file *filp, loff_t pos)
353 {
354 	if ((filp->f_mode & FMODE_32BITHASH) ||
355 	    (!(filp->f_mode & FMODE_64BITHASH) && is_32bit_api()))
356 		return 0;
357 	else
358 		return pos & 0xffffffff;
359 }
360 
361 /*
362  * Return 32- or 64-bit end-of-file for dx directories
363  */
364 static inline loff_t ext4_get_htree_eof(struct file *filp)
365 {
366 	if ((filp->f_mode & FMODE_32BITHASH) ||
367 	    (!(filp->f_mode & FMODE_64BITHASH) && is_32bit_api()))
368 		return EXT4_HTREE_EOF_32BIT;
369 	else
370 		return EXT4_HTREE_EOF_64BIT;
371 }
372 
373 
374 /*
375  * ext4_dir_llseek() calls generic_file_llseek_size to handle htree
376  * directories, where the "offset" is in terms of the filename hash
377  * value instead of the byte offset.
378  *
379  * Because we may return a 64-bit hash that is well beyond offset limits,
380  * we need to pass the max hash as the maximum allowable offset in
381  * the htree directory case.
382  *
383  * For non-htree, ext4_llseek already chooses the proper max offset.
384  */
385 static loff_t ext4_dir_llseek(struct file *file, loff_t offset, int whence)
386 {
387 	struct inode *inode = file->f_mapping->host;
388 	struct dir_private_info *info = file->private_data;
389 	int dx_dir = is_dx_dir(inode);
390 	loff_t ret, htree_max = ext4_get_htree_eof(file);
391 
392 	if (likely(dx_dir))
393 		ret = generic_file_llseek_size(file, offset, whence,
394 						    htree_max, htree_max);
395 	else
396 		ret = ext4_llseek(file, offset, whence);
397 	info->cookie = inode_peek_iversion(inode) - 1;
398 	return ret;
399 }
400 
401 /*
402  * This structure holds the nodes of the red-black tree used to store
403  * the directory entry in hash order.
404  */
405 struct fname {
406 	__u32		hash;
407 	__u32		minor_hash;
408 	struct rb_node	rb_hash;
409 	struct fname	*next;
410 	__u32		inode;
411 	__u8		name_len;
412 	__u8		file_type;
413 	char		name[];
414 };
415 
416 /*
417  * This function implements a non-recursive way of freeing all of the
418  * nodes in the red-black tree.
419  */
420 static void free_rb_tree_fname(struct rb_root *root)
421 {
422 	struct fname *fname, *next;
423 
424 	rbtree_postorder_for_each_entry_safe(fname, next, root, rb_hash)
425 		while (fname) {
426 			struct fname *old = fname;
427 			fname = fname->next;
428 			kfree(old);
429 		}
430 
431 	*root = RB_ROOT;
432 }
433 
434 static void ext4_htree_init_dir_info(struct file *filp, loff_t pos)
435 {
436 	struct dir_private_info *p = filp->private_data;
437 
438 	if (is_dx_dir(file_inode(filp)) && !p->initialized) {
439 		p->curr_hash = pos2maj_hash(filp, pos);
440 		p->curr_minor_hash = pos2min_hash(filp, pos);
441 		p->initialized = true;
442 	}
443 }
444 
445 void ext4_htree_free_dir_info(struct dir_private_info *p)
446 {
447 	free_rb_tree_fname(&p->root);
448 	kfree(p);
449 }
450 
451 /*
452  * Given a directory entry, enter it into the fname rb tree.
453  *
454  * When filename encryption is enabled, the dirent will hold the
455  * encrypted filename, while the htree will hold decrypted filename.
456  * The decrypted filename is passed in via ent_name.  parameter.
457  */
458 int ext4_htree_store_dirent(struct file *dir_file, __u32 hash,
459 			     __u32 minor_hash,
460 			    struct ext4_dir_entry_2 *dirent,
461 			    struct fscrypt_str *ent_name)
462 {
463 	struct rb_node **p, *parent = NULL;
464 	struct fname *fname, *new_fn;
465 	struct dir_private_info *info;
466 	int len;
467 
468 	info = dir_file->private_data;
469 	p = &info->root.rb_node;
470 
471 	/* Create and allocate the fname structure */
472 	len = sizeof(struct fname) + ent_name->len + 1;
473 	new_fn = kzalloc(len, GFP_KERNEL);
474 	if (!new_fn)
475 		return -ENOMEM;
476 	new_fn->hash = hash;
477 	new_fn->minor_hash = minor_hash;
478 	new_fn->inode = le32_to_cpu(dirent->inode);
479 	new_fn->name_len = ent_name->len;
480 	new_fn->file_type = dirent->file_type;
481 	memcpy(new_fn->name, ent_name->name, ent_name->len);
482 
483 	while (*p) {
484 		parent = *p;
485 		fname = rb_entry(parent, struct fname, rb_hash);
486 
487 		/*
488 		 * If the hash and minor hash match up, then we put
489 		 * them on a linked list.  This rarely happens...
490 		 */
491 		if ((new_fn->hash == fname->hash) &&
492 		    (new_fn->minor_hash == fname->minor_hash)) {
493 			new_fn->next = fname->next;
494 			fname->next = new_fn;
495 			return 0;
496 		}
497 
498 		if (new_fn->hash < fname->hash)
499 			p = &(*p)->rb_left;
500 		else if (new_fn->hash > fname->hash)
501 			p = &(*p)->rb_right;
502 		else if (new_fn->minor_hash < fname->minor_hash)
503 			p = &(*p)->rb_left;
504 		else /* if (new_fn->minor_hash > fname->minor_hash) */
505 			p = &(*p)->rb_right;
506 	}
507 
508 	rb_link_node(&new_fn->rb_hash, parent, p);
509 	rb_insert_color(&new_fn->rb_hash, &info->root);
510 	return 0;
511 }
512 
513 
514 
515 /*
516  * This is a helper function for ext4_dx_readdir.  It calls filldir
517  * for all entries on the fname linked list.  (Normally there is only
518  * one entry on the linked list, unless there are 62 bit hash collisions.)
519  */
520 static int call_filldir(struct file *file, struct dir_context *ctx,
521 			struct fname *fname)
522 {
523 	struct dir_private_info *info = file->private_data;
524 	struct inode *inode = file_inode(file);
525 	struct super_block *sb = inode->i_sb;
526 
527 	if (!fname) {
528 		ext4_msg(sb, KERN_ERR, "%s:%d: inode #%lu: comm %s: "
529 			 "called with null fname?!?", __func__, __LINE__,
530 			 inode->i_ino, current->comm);
531 		return 0;
532 	}
533 	ctx->pos = hash2pos(file, fname->hash, fname->minor_hash);
534 	while (fname) {
535 		if (!dir_emit(ctx, fname->name,
536 				fname->name_len,
537 				fname->inode,
538 				get_dtype(sb, fname->file_type))) {
539 			info->extra_fname = fname;
540 			return 1;
541 		}
542 		fname = fname->next;
543 	}
544 	return 0;
545 }
546 
547 static int ext4_dx_readdir(struct file *file, struct dir_context *ctx)
548 {
549 	struct dir_private_info *info = file->private_data;
550 	struct inode *inode = file_inode(file);
551 	struct fname *fname;
552 	int ret = 0;
553 
554 	ext4_htree_init_dir_info(file, ctx->pos);
555 
556 	if (ctx->pos == ext4_get_htree_eof(file))
557 		return 0;	/* EOF */
558 
559 	/* Some one has messed with f_pos; reset the world */
560 	if (info->last_pos != ctx->pos) {
561 		free_rb_tree_fname(&info->root);
562 		info->curr_node = NULL;
563 		info->extra_fname = NULL;
564 		info->curr_hash = pos2maj_hash(file, ctx->pos);
565 		info->curr_minor_hash = pos2min_hash(file, ctx->pos);
566 	}
567 
568 	/*
569 	 * If there are any leftover names on the hash collision
570 	 * chain, return them first.
571 	 */
572 	if (info->extra_fname) {
573 		if (call_filldir(file, ctx, info->extra_fname))
574 			goto finished;
575 		info->extra_fname = NULL;
576 		goto next_node;
577 	} else if (!info->curr_node)
578 		info->curr_node = rb_first(&info->root);
579 
580 	while (1) {
581 		/*
582 		 * Fill the rbtree if we have no more entries,
583 		 * or the inode has changed since we last read in the
584 		 * cached entries.
585 		 */
586 		if ((!info->curr_node) ||
587 		    !inode_eq_iversion(inode, info->cookie)) {
588 			info->curr_node = NULL;
589 			free_rb_tree_fname(&info->root);
590 			info->cookie = inode_query_iversion(inode);
591 			ret = ext4_htree_fill_tree(file, info->curr_hash,
592 						   info->curr_minor_hash,
593 						   &info->next_hash);
594 			if (ret < 0)
595 				goto finished;
596 			if (ret == 0) {
597 				ctx->pos = ext4_get_htree_eof(file);
598 				break;
599 			}
600 			info->curr_node = rb_first(&info->root);
601 		}
602 
603 		fname = rb_entry(info->curr_node, struct fname, rb_hash);
604 		info->curr_hash = fname->hash;
605 		info->curr_minor_hash = fname->minor_hash;
606 		if (call_filldir(file, ctx, fname))
607 			break;
608 	next_node:
609 		info->curr_node = rb_next(info->curr_node);
610 		if (info->curr_node) {
611 			fname = rb_entry(info->curr_node, struct fname,
612 					 rb_hash);
613 			info->curr_hash = fname->hash;
614 			info->curr_minor_hash = fname->minor_hash;
615 		} else {
616 			if (info->next_hash == ~0) {
617 				ctx->pos = ext4_get_htree_eof(file);
618 				break;
619 			}
620 			info->curr_hash = info->next_hash;
621 			info->curr_minor_hash = 0;
622 		}
623 	}
624 finished:
625 	info->last_pos = ctx->pos;
626 	return ret < 0 ? ret : 0;
627 }
628 
629 static int ext4_release_dir(struct inode *inode, struct file *filp)
630 {
631 	if (filp->private_data)
632 		ext4_htree_free_dir_info(filp->private_data);
633 
634 	return 0;
635 }
636 
637 int ext4_check_all_de(struct inode *dir, struct buffer_head *bh, void *buf,
638 		      int buf_size)
639 {
640 	struct ext4_dir_entry_2 *de;
641 	int rlen;
642 	unsigned int offset = 0;
643 	char *top;
644 
645 	de = buf;
646 	top = buf + buf_size;
647 	while ((char *) de < top) {
648 		if (ext4_check_dir_entry(dir, NULL, de, bh,
649 					 buf, buf_size, offset))
650 			return -EFSCORRUPTED;
651 		rlen = ext4_rec_len_from_disk(de->rec_len, buf_size);
652 		de = (struct ext4_dir_entry_2 *)((char *)de + rlen);
653 		offset += rlen;
654 	}
655 	if ((char *) de > top)
656 		return -EFSCORRUPTED;
657 
658 	return 0;
659 }
660 
661 static int ext4_dir_open(struct inode *inode, struct file *file)
662 {
663 	struct dir_private_info *info;
664 
665 	info = kzalloc(sizeof(*info), GFP_KERNEL);
666 	if (!info)
667 		return -ENOMEM;
668 	file->private_data = info;
669 	return 0;
670 }
671 
672 const struct file_operations ext4_dir_operations = {
673 	.open		= ext4_dir_open,
674 	.llseek		= ext4_dir_llseek,
675 	.read		= generic_read_dir,
676 	.iterate_shared	= ext4_readdir,
677 	.unlocked_ioctl = ext4_ioctl,
678 #ifdef CONFIG_COMPAT
679 	.compat_ioctl	= ext4_compat_ioctl,
680 #endif
681 	.fsync		= ext4_sync_file,
682 	.release	= ext4_release_dir,
683 };
684