xref: /linux/drivers/usb/musb/da8xx.c (revision 93d90ad708b8da6efc0e487b66111aa9db7f70c7)
1 /*
2  * Texas Instruments DA8xx/OMAP-L1x "glue layer"
3  *
4  * Copyright (c) 2008-2009 MontaVista Software, Inc. <source@mvista.com>
5  *
6  * Based on the DaVinci "glue layer" code.
7  * Copyright (C) 2005-2006 by Texas Instruments
8  *
9  * This file is part of the Inventra Controller Driver for Linux.
10  *
11  * The Inventra Controller Driver for Linux is free software; you
12  * can redistribute it and/or modify it under the terms of the GNU
13  * General Public License version 2 as published by the Free Software
14  * Foundation.
15  *
16  * The Inventra Controller Driver for Linux is distributed in
17  * the hope that it will be useful, but WITHOUT ANY WARRANTY;
18  * without even the implied warranty of MERCHANTABILITY or
19  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public
20  * License for more details.
21  *
22  * You should have received a copy of the GNU General Public License
23  * along with The Inventra Controller Driver for Linux ; if not,
24  * write to the Free Software Foundation, Inc., 59 Temple Place,
25  * Suite 330, Boston, MA  02111-1307  USA
26  *
27  */
28 
29 #include <linux/module.h>
30 #include <linux/clk.h>
31 #include <linux/err.h>
32 #include <linux/io.h>
33 #include <linux/platform_device.h>
34 #include <linux/dma-mapping.h>
35 #include <linux/usb/usb_phy_generic.h>
36 
37 #include <mach/da8xx.h>
38 #include <linux/platform_data/usb-davinci.h>
39 
40 #include "musb_core.h"
41 
42 /*
43  * DA8XX specific definitions
44  */
45 
46 /* USB 2.0 OTG module registers */
47 #define DA8XX_USB_REVISION_REG	0x00
48 #define DA8XX_USB_CTRL_REG	0x04
49 #define DA8XX_USB_STAT_REG	0x08
50 #define DA8XX_USB_EMULATION_REG 0x0c
51 #define DA8XX_USB_MODE_REG	0x10	/* Transparent, CDC, [Generic] RNDIS */
52 #define DA8XX_USB_AUTOREQ_REG	0x14
53 #define DA8XX_USB_SRP_FIX_TIME_REG 0x18
54 #define DA8XX_USB_TEARDOWN_REG	0x1c
55 #define DA8XX_USB_INTR_SRC_REG	0x20
56 #define DA8XX_USB_INTR_SRC_SET_REG 0x24
57 #define DA8XX_USB_INTR_SRC_CLEAR_REG 0x28
58 #define DA8XX_USB_INTR_MASK_REG 0x2c
59 #define DA8XX_USB_INTR_MASK_SET_REG 0x30
60 #define DA8XX_USB_INTR_MASK_CLEAR_REG 0x34
61 #define DA8XX_USB_INTR_SRC_MASKED_REG 0x38
62 #define DA8XX_USB_END_OF_INTR_REG 0x3c
63 #define DA8XX_USB_GENERIC_RNDIS_EP_SIZE_REG(n) (0x50 + (((n) - 1) << 2))
64 
65 /* Control register bits */
66 #define DA8XX_SOFT_RESET_MASK	1
67 
68 #define DA8XX_USB_TX_EP_MASK	0x1f		/* EP0 + 4 Tx EPs */
69 #define DA8XX_USB_RX_EP_MASK	0x1e		/* 4 Rx EPs */
70 
71 /* USB interrupt register bits */
72 #define DA8XX_INTR_USB_SHIFT	16
73 #define DA8XX_INTR_USB_MASK	(0x1ff << DA8XX_INTR_USB_SHIFT) /* 8 Mentor */
74 					/* interrupts and DRVVBUS interrupt */
75 #define DA8XX_INTR_DRVVBUS	0x100
76 #define DA8XX_INTR_RX_SHIFT	8
77 #define DA8XX_INTR_RX_MASK	(DA8XX_USB_RX_EP_MASK << DA8XX_INTR_RX_SHIFT)
78 #define DA8XX_INTR_TX_SHIFT	0
79 #define DA8XX_INTR_TX_MASK	(DA8XX_USB_TX_EP_MASK << DA8XX_INTR_TX_SHIFT)
80 
81 #define DA8XX_MENTOR_CORE_OFFSET 0x400
82 
83 #define CFGCHIP2	IO_ADDRESS(DA8XX_SYSCFG0_BASE + DA8XX_CFGCHIP2_REG)
84 
85 struct da8xx_glue {
86 	struct device		*dev;
87 	struct platform_device	*musb;
88 	struct platform_device	*phy;
89 	struct clk		*clk;
90 };
91 
92 /*
93  * REVISIT (PM): we should be able to keep the PHY in low power mode most
94  * of the time (24 MHz oscillator and PLL off, etc.) by setting POWER.D0
95  * and, when in host mode, autosuspending idle root ports... PHY_PLLON
96  * (overriding SUSPENDM?) then likely needs to stay off.
97  */
98 
99 static inline void phy_on(void)
100 {
101 	u32 cfgchip2 = __raw_readl(CFGCHIP2);
102 
103 	/*
104 	 * Start the on-chip PHY and its PLL.
105 	 */
106 	cfgchip2 &= ~(CFGCHIP2_RESET | CFGCHIP2_PHYPWRDN | CFGCHIP2_OTGPWRDN);
107 	cfgchip2 |= CFGCHIP2_PHY_PLLON;
108 	__raw_writel(cfgchip2, CFGCHIP2);
109 
110 	pr_info("Waiting for USB PHY clock good...\n");
111 	while (!(__raw_readl(CFGCHIP2) & CFGCHIP2_PHYCLKGD))
112 		cpu_relax();
113 }
114 
115 static inline void phy_off(void)
116 {
117 	u32 cfgchip2 = __raw_readl(CFGCHIP2);
118 
119 	/*
120 	 * Ensure that USB 1.1 reference clock is not being sourced from
121 	 * USB 2.0 PHY.  Otherwise do not power down the PHY.
122 	 */
123 	if (!(cfgchip2 & CFGCHIP2_USB1PHYCLKMUX) &&
124 	     (cfgchip2 & CFGCHIP2_USB1SUSPENDM)) {
125 		pr_warning("USB 1.1 clocked from USB 2.0 PHY -- "
126 			   "can't power it down\n");
127 		return;
128 	}
129 
130 	/*
131 	 * Power down the on-chip PHY.
132 	 */
133 	cfgchip2 |= CFGCHIP2_PHYPWRDN | CFGCHIP2_OTGPWRDN;
134 	__raw_writel(cfgchip2, CFGCHIP2);
135 }
136 
137 /*
138  * Because we don't set CTRL.UINT, it's "important" to:
139  *	- not read/write INTRUSB/INTRUSBE (except during
140  *	  initial setup, as a workaround);
141  *	- use INTSET/INTCLR instead.
142  */
143 
144 /**
145  * da8xx_musb_enable - enable interrupts
146  */
147 static void da8xx_musb_enable(struct musb *musb)
148 {
149 	void __iomem *reg_base = musb->ctrl_base;
150 	u32 mask;
151 
152 	/* Workaround: setup IRQs through both register sets. */
153 	mask = ((musb->epmask & DA8XX_USB_TX_EP_MASK) << DA8XX_INTR_TX_SHIFT) |
154 	       ((musb->epmask & DA8XX_USB_RX_EP_MASK) << DA8XX_INTR_RX_SHIFT) |
155 	       DA8XX_INTR_USB_MASK;
156 	musb_writel(reg_base, DA8XX_USB_INTR_MASK_SET_REG, mask);
157 
158 	/* Force the DRVVBUS IRQ so we can start polling for ID change. */
159 	musb_writel(reg_base, DA8XX_USB_INTR_SRC_SET_REG,
160 			DA8XX_INTR_DRVVBUS << DA8XX_INTR_USB_SHIFT);
161 }
162 
163 /**
164  * da8xx_musb_disable - disable HDRC and flush interrupts
165  */
166 static void da8xx_musb_disable(struct musb *musb)
167 {
168 	void __iomem *reg_base = musb->ctrl_base;
169 
170 	musb_writel(reg_base, DA8XX_USB_INTR_MASK_CLEAR_REG,
171 		    DA8XX_INTR_USB_MASK |
172 		    DA8XX_INTR_TX_MASK | DA8XX_INTR_RX_MASK);
173 	musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
174 	musb_writel(reg_base, DA8XX_USB_END_OF_INTR_REG, 0);
175 }
176 
177 #define portstate(stmt)		stmt
178 
179 static void da8xx_musb_set_vbus(struct musb *musb, int is_on)
180 {
181 	WARN_ON(is_on && is_peripheral_active(musb));
182 }
183 
184 #define	POLL_SECONDS	2
185 
186 static struct timer_list otg_workaround;
187 
188 static void otg_timer(unsigned long _musb)
189 {
190 	struct musb		*musb = (void *)_musb;
191 	void __iomem		*mregs = musb->mregs;
192 	u8			devctl;
193 	unsigned long		flags;
194 
195 	/*
196 	 * We poll because DaVinci's won't expose several OTG-critical
197 	 * status change events (from the transceiver) otherwise.
198 	 */
199 	devctl = musb_readb(mregs, MUSB_DEVCTL);
200 	dev_dbg(musb->controller, "Poll devctl %02x (%s)\n", devctl,
201 		usb_otg_state_string(musb->xceiv->otg->state));
202 
203 	spin_lock_irqsave(&musb->lock, flags);
204 	switch (musb->xceiv->otg->state) {
205 	case OTG_STATE_A_WAIT_BCON:
206 		devctl &= ~MUSB_DEVCTL_SESSION;
207 		musb_writeb(musb->mregs, MUSB_DEVCTL, devctl);
208 
209 		devctl = musb_readb(musb->mregs, MUSB_DEVCTL);
210 		if (devctl & MUSB_DEVCTL_BDEVICE) {
211 			musb->xceiv->otg->state = OTG_STATE_B_IDLE;
212 			MUSB_DEV_MODE(musb);
213 		} else {
214 			musb->xceiv->otg->state = OTG_STATE_A_IDLE;
215 			MUSB_HST_MODE(musb);
216 		}
217 		break;
218 	case OTG_STATE_A_WAIT_VFALL:
219 		/*
220 		 * Wait till VBUS falls below SessionEnd (~0.2 V); the 1.3
221 		 * RTL seems to mis-handle session "start" otherwise (or in
222 		 * our case "recover"), in routine "VBUS was valid by the time
223 		 * VBUSERR got reported during enumeration" cases.
224 		 */
225 		if (devctl & MUSB_DEVCTL_VBUS) {
226 			mod_timer(&otg_workaround, jiffies + POLL_SECONDS * HZ);
227 			break;
228 		}
229 		musb->xceiv->otg->state = OTG_STATE_A_WAIT_VRISE;
230 		musb_writel(musb->ctrl_base, DA8XX_USB_INTR_SRC_SET_REG,
231 			    MUSB_INTR_VBUSERROR << DA8XX_INTR_USB_SHIFT);
232 		break;
233 	case OTG_STATE_B_IDLE:
234 		/*
235 		 * There's no ID-changed IRQ, so we have no good way to tell
236 		 * when to switch to the A-Default state machine (by setting
237 		 * the DEVCTL.Session bit).
238 		 *
239 		 * Workaround:  whenever we're in B_IDLE, try setting the
240 		 * session flag every few seconds.  If it works, ID was
241 		 * grounded and we're now in the A-Default state machine.
242 		 *
243 		 * NOTE: setting the session flag is _supposed_ to trigger
244 		 * SRP but clearly it doesn't.
245 		 */
246 		musb_writeb(mregs, MUSB_DEVCTL, devctl | MUSB_DEVCTL_SESSION);
247 		devctl = musb_readb(mregs, MUSB_DEVCTL);
248 		if (devctl & MUSB_DEVCTL_BDEVICE)
249 			mod_timer(&otg_workaround, jiffies + POLL_SECONDS * HZ);
250 		else
251 			musb->xceiv->otg->state = OTG_STATE_A_IDLE;
252 		break;
253 	default:
254 		break;
255 	}
256 	spin_unlock_irqrestore(&musb->lock, flags);
257 }
258 
259 static void da8xx_musb_try_idle(struct musb *musb, unsigned long timeout)
260 {
261 	static unsigned long last_timer;
262 
263 	if (timeout == 0)
264 		timeout = jiffies + msecs_to_jiffies(3);
265 
266 	/* Never idle if active, or when VBUS timeout is not set as host */
267 	if (musb->is_active || (musb->a_wait_bcon == 0 &&
268 				musb->xceiv->otg->state == OTG_STATE_A_WAIT_BCON)) {
269 		dev_dbg(musb->controller, "%s active, deleting timer\n",
270 			usb_otg_state_string(musb->xceiv->otg->state));
271 		del_timer(&otg_workaround);
272 		last_timer = jiffies;
273 		return;
274 	}
275 
276 	if (time_after(last_timer, timeout) && timer_pending(&otg_workaround)) {
277 		dev_dbg(musb->controller, "Longer idle timer already pending, ignoring...\n");
278 		return;
279 	}
280 	last_timer = timeout;
281 
282 	dev_dbg(musb->controller, "%s inactive, starting idle timer for %u ms\n",
283 		usb_otg_state_string(musb->xceiv->otg->state),
284 		jiffies_to_msecs(timeout - jiffies));
285 	mod_timer(&otg_workaround, timeout);
286 }
287 
288 static irqreturn_t da8xx_musb_interrupt(int irq, void *hci)
289 {
290 	struct musb		*musb = hci;
291 	void __iomem		*reg_base = musb->ctrl_base;
292 	struct usb_otg		*otg = musb->xceiv->otg;
293 	unsigned long		flags;
294 	irqreturn_t		ret = IRQ_NONE;
295 	u32			status;
296 
297 	spin_lock_irqsave(&musb->lock, flags);
298 
299 	/*
300 	 * NOTE: DA8XX shadows the Mentor IRQs.  Don't manage them through
301 	 * the Mentor registers (except for setup), use the TI ones and EOI.
302 	 */
303 
304 	/* Acknowledge and handle non-CPPI interrupts */
305 	status = musb_readl(reg_base, DA8XX_USB_INTR_SRC_MASKED_REG);
306 	if (!status)
307 		goto eoi;
308 
309 	musb_writel(reg_base, DA8XX_USB_INTR_SRC_CLEAR_REG, status);
310 	dev_dbg(musb->controller, "USB IRQ %08x\n", status);
311 
312 	musb->int_rx = (status & DA8XX_INTR_RX_MASK) >> DA8XX_INTR_RX_SHIFT;
313 	musb->int_tx = (status & DA8XX_INTR_TX_MASK) >> DA8XX_INTR_TX_SHIFT;
314 	musb->int_usb = (status & DA8XX_INTR_USB_MASK) >> DA8XX_INTR_USB_SHIFT;
315 
316 	/*
317 	 * DRVVBUS IRQs are the only proxy we have (a very poor one!) for
318 	 * DA8xx's missing ID change IRQ.  We need an ID change IRQ to
319 	 * switch appropriately between halves of the OTG state machine.
320 	 * Managing DEVCTL.Session per Mentor docs requires that we know its
321 	 * value but DEVCTL.BDevice is invalid without DEVCTL.Session set.
322 	 * Also, DRVVBUS pulses for SRP (but not at 5 V)...
323 	 */
324 	if (status & (DA8XX_INTR_DRVVBUS << DA8XX_INTR_USB_SHIFT)) {
325 		int drvvbus = musb_readl(reg_base, DA8XX_USB_STAT_REG);
326 		void __iomem *mregs = musb->mregs;
327 		u8 devctl = musb_readb(mregs, MUSB_DEVCTL);
328 		int err;
329 
330 		err = musb->int_usb & MUSB_INTR_VBUSERROR;
331 		if (err) {
332 			/*
333 			 * The Mentor core doesn't debounce VBUS as needed
334 			 * to cope with device connect current spikes. This
335 			 * means it's not uncommon for bus-powered devices
336 			 * to get VBUS errors during enumeration.
337 			 *
338 			 * This is a workaround, but newer RTL from Mentor
339 			 * seems to allow a better one: "re"-starting sessions
340 			 * without waiting for VBUS to stop registering in
341 			 * devctl.
342 			 */
343 			musb->int_usb &= ~MUSB_INTR_VBUSERROR;
344 			musb->xceiv->otg->state = OTG_STATE_A_WAIT_VFALL;
345 			mod_timer(&otg_workaround, jiffies + POLL_SECONDS * HZ);
346 			WARNING("VBUS error workaround (delay coming)\n");
347 		} else if (drvvbus) {
348 			MUSB_HST_MODE(musb);
349 			otg->default_a = 1;
350 			musb->xceiv->otg->state = OTG_STATE_A_WAIT_VRISE;
351 			portstate(musb->port1_status |= USB_PORT_STAT_POWER);
352 			del_timer(&otg_workaround);
353 		} else {
354 			musb->is_active = 0;
355 			MUSB_DEV_MODE(musb);
356 			otg->default_a = 0;
357 			musb->xceiv->otg->state = OTG_STATE_B_IDLE;
358 			portstate(musb->port1_status &= ~USB_PORT_STAT_POWER);
359 		}
360 
361 		dev_dbg(musb->controller, "VBUS %s (%s)%s, devctl %02x\n",
362 				drvvbus ? "on" : "off",
363 				usb_otg_state_string(musb->xceiv->otg->state),
364 				err ? " ERROR" : "",
365 				devctl);
366 		ret = IRQ_HANDLED;
367 	}
368 
369 	if (musb->int_tx || musb->int_rx || musb->int_usb)
370 		ret |= musb_interrupt(musb);
371 
372  eoi:
373 	/* EOI needs to be written for the IRQ to be re-asserted. */
374 	if (ret == IRQ_HANDLED || status)
375 		musb_writel(reg_base, DA8XX_USB_END_OF_INTR_REG, 0);
376 
377 	/* Poll for ID change */
378 	if (musb->xceiv->otg->state == OTG_STATE_B_IDLE)
379 		mod_timer(&otg_workaround, jiffies + POLL_SECONDS * HZ);
380 
381 	spin_unlock_irqrestore(&musb->lock, flags);
382 
383 	return ret;
384 }
385 
386 static int da8xx_musb_set_mode(struct musb *musb, u8 musb_mode)
387 {
388 	u32 cfgchip2 = __raw_readl(CFGCHIP2);
389 
390 	cfgchip2 &= ~CFGCHIP2_OTGMODE;
391 	switch (musb_mode) {
392 	case MUSB_HOST:		/* Force VBUS valid, ID = 0 */
393 		cfgchip2 |= CFGCHIP2_FORCE_HOST;
394 		break;
395 	case MUSB_PERIPHERAL:	/* Force VBUS valid, ID = 1 */
396 		cfgchip2 |= CFGCHIP2_FORCE_DEVICE;
397 		break;
398 	case MUSB_OTG:		/* Don't override the VBUS/ID comparators */
399 		cfgchip2 |= CFGCHIP2_NO_OVERRIDE;
400 		break;
401 	default:
402 		dev_dbg(musb->controller, "Trying to set unsupported mode %u\n", musb_mode);
403 	}
404 
405 	__raw_writel(cfgchip2, CFGCHIP2);
406 	return 0;
407 }
408 
409 static int da8xx_musb_init(struct musb *musb)
410 {
411 	void __iomem *reg_base = musb->ctrl_base;
412 	u32 rev;
413 	int ret = -ENODEV;
414 
415 	musb->mregs += DA8XX_MENTOR_CORE_OFFSET;
416 
417 	/* Returns zero if e.g. not clocked */
418 	rev = musb_readl(reg_base, DA8XX_USB_REVISION_REG);
419 	if (!rev)
420 		goto fail;
421 
422 	musb->xceiv = usb_get_phy(USB_PHY_TYPE_USB2);
423 	if (IS_ERR_OR_NULL(musb->xceiv)) {
424 		ret = -EPROBE_DEFER;
425 		goto fail;
426 	}
427 
428 	setup_timer(&otg_workaround, otg_timer, (unsigned long)musb);
429 
430 	/* Reset the controller */
431 	musb_writel(reg_base, DA8XX_USB_CTRL_REG, DA8XX_SOFT_RESET_MASK);
432 
433 	/* Start the on-chip PHY and its PLL. */
434 	phy_on();
435 
436 	msleep(5);
437 
438 	/* NOTE: IRQs are in mixed mode, not bypass to pure MUSB */
439 	pr_debug("DA8xx OTG revision %08x, PHY %03x, control %02x\n",
440 		 rev, __raw_readl(CFGCHIP2),
441 		 musb_readb(reg_base, DA8XX_USB_CTRL_REG));
442 
443 	musb->isr = da8xx_musb_interrupt;
444 	return 0;
445 fail:
446 	return ret;
447 }
448 
449 static int da8xx_musb_exit(struct musb *musb)
450 {
451 	del_timer_sync(&otg_workaround);
452 
453 	phy_off();
454 
455 	usb_put_phy(musb->xceiv);
456 
457 	return 0;
458 }
459 
460 static const struct musb_platform_ops da8xx_ops = {
461 	.quirks		= MUSB_INDEXED_EP,
462 	.init		= da8xx_musb_init,
463 	.exit		= da8xx_musb_exit,
464 
465 	.fifo_mode	= 2,
466 	.enable		= da8xx_musb_enable,
467 	.disable	= da8xx_musb_disable,
468 
469 	.set_mode	= da8xx_musb_set_mode,
470 	.try_idle	= da8xx_musb_try_idle,
471 
472 	.set_vbus	= da8xx_musb_set_vbus,
473 };
474 
475 static const struct platform_device_info da8xx_dev_info = {
476 	.name		= "musb-hdrc",
477 	.id		= PLATFORM_DEVID_AUTO,
478 	.dma_mask	= DMA_BIT_MASK(32),
479 };
480 
481 static int da8xx_probe(struct platform_device *pdev)
482 {
483 	struct resource musb_resources[2];
484 	struct musb_hdrc_platform_data	*pdata = dev_get_platdata(&pdev->dev);
485 	struct platform_device		*musb;
486 	struct da8xx_glue		*glue;
487 	struct platform_device_info	pinfo;
488 	struct clk			*clk;
489 
490 	int				ret = -ENOMEM;
491 
492 	glue = kzalloc(sizeof(*glue), GFP_KERNEL);
493 	if (!glue) {
494 		dev_err(&pdev->dev, "failed to allocate glue context\n");
495 		goto err0;
496 	}
497 
498 	clk = clk_get(&pdev->dev, "usb20");
499 	if (IS_ERR(clk)) {
500 		dev_err(&pdev->dev, "failed to get clock\n");
501 		ret = PTR_ERR(clk);
502 		goto err3;
503 	}
504 
505 	ret = clk_enable(clk);
506 	if (ret) {
507 		dev_err(&pdev->dev, "failed to enable clock\n");
508 		goto err4;
509 	}
510 
511 	glue->dev			= &pdev->dev;
512 	glue->clk			= clk;
513 
514 	pdata->platform_ops		= &da8xx_ops;
515 
516 	glue->phy = usb_phy_generic_register();
517 	if (IS_ERR(glue->phy)) {
518 		ret = PTR_ERR(glue->phy);
519 		goto err5;
520 	}
521 	platform_set_drvdata(pdev, glue);
522 
523 	memset(musb_resources, 0x00, sizeof(*musb_resources) *
524 			ARRAY_SIZE(musb_resources));
525 
526 	musb_resources[0].name = pdev->resource[0].name;
527 	musb_resources[0].start = pdev->resource[0].start;
528 	musb_resources[0].end = pdev->resource[0].end;
529 	musb_resources[0].flags = pdev->resource[0].flags;
530 
531 	musb_resources[1].name = pdev->resource[1].name;
532 	musb_resources[1].start = pdev->resource[1].start;
533 	musb_resources[1].end = pdev->resource[1].end;
534 	musb_resources[1].flags = pdev->resource[1].flags;
535 
536 	pinfo = da8xx_dev_info;
537 	pinfo.parent = &pdev->dev;
538 	pinfo.res = musb_resources;
539 	pinfo.num_res = ARRAY_SIZE(musb_resources);
540 	pinfo.data = pdata;
541 	pinfo.size_data = sizeof(*pdata);
542 
543 	glue->musb = musb = platform_device_register_full(&pinfo);
544 	if (IS_ERR(musb)) {
545 		ret = PTR_ERR(musb);
546 		dev_err(&pdev->dev, "failed to register musb device: %d\n", ret);
547 		goto err6;
548 	}
549 
550 	return 0;
551 
552 err6:
553 	usb_phy_generic_unregister(glue->phy);
554 
555 err5:
556 	clk_disable(clk);
557 
558 err4:
559 	clk_put(clk);
560 
561 err3:
562 	kfree(glue);
563 
564 err0:
565 	return ret;
566 }
567 
568 static int da8xx_remove(struct platform_device *pdev)
569 {
570 	struct da8xx_glue		*glue = platform_get_drvdata(pdev);
571 
572 	platform_device_unregister(glue->musb);
573 	usb_phy_generic_unregister(glue->phy);
574 	clk_disable(glue->clk);
575 	clk_put(glue->clk);
576 	kfree(glue);
577 
578 	return 0;
579 }
580 
581 static struct platform_driver da8xx_driver = {
582 	.probe		= da8xx_probe,
583 	.remove		= da8xx_remove,
584 	.driver		= {
585 		.name	= "musb-da8xx",
586 	},
587 };
588 
589 MODULE_DESCRIPTION("DA8xx/OMAP-L1x MUSB Glue Layer");
590 MODULE_AUTHOR("Sergei Shtylyov <sshtylyov@ru.mvista.com>");
591 MODULE_LICENSE("GPL v2");
592 module_platform_driver(da8xx_driver);
593