xref: /linux/drivers/remoteproc/remoteproc_virtio.c (revision c6aed238b7a9b15a5c90a0c31f1d36577b5d2cbe)
104a9016eSOhad Ben-Cohen /*
204a9016eSOhad Ben-Cohen  * Remote processor messaging transport (OMAP platform-specific bits)
304a9016eSOhad Ben-Cohen  *
404a9016eSOhad Ben-Cohen  * Copyright (C) 2011 Texas Instruments, Inc.
504a9016eSOhad Ben-Cohen  * Copyright (C) 2011 Google, Inc.
604a9016eSOhad Ben-Cohen  *
704a9016eSOhad Ben-Cohen  * Ohad Ben-Cohen <ohad@wizery.com>
804a9016eSOhad Ben-Cohen  * Brian Swetland <swetland@google.com>
904a9016eSOhad Ben-Cohen  *
1004a9016eSOhad Ben-Cohen  * This software is licensed under the terms of the GNU General Public
1104a9016eSOhad Ben-Cohen  * License version 2, as published by the Free Software Foundation, and
1204a9016eSOhad Ben-Cohen  * may be copied, distributed, and modified under those terms.
1304a9016eSOhad Ben-Cohen  *
1404a9016eSOhad Ben-Cohen  * This program is distributed in the hope that it will be useful,
1504a9016eSOhad Ben-Cohen  * but WITHOUT ANY WARRANTY; without even the implied warranty of
1604a9016eSOhad Ben-Cohen  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
1704a9016eSOhad Ben-Cohen  * GNU General Public License for more details.
1804a9016eSOhad Ben-Cohen  */
1904a9016eSOhad Ben-Cohen 
2004a9016eSOhad Ben-Cohen #include <linux/export.h>
2104a9016eSOhad Ben-Cohen #include <linux/remoteproc.h>
2204a9016eSOhad Ben-Cohen #include <linux/virtio.h>
2304a9016eSOhad Ben-Cohen #include <linux/virtio_config.h>
2404a9016eSOhad Ben-Cohen #include <linux/virtio_ids.h>
2504a9016eSOhad Ben-Cohen #include <linux/virtio_ring.h>
2604a9016eSOhad Ben-Cohen #include <linux/err.h>
2704a9016eSOhad Ben-Cohen #include <linux/kref.h>
2804a9016eSOhad Ben-Cohen #include <linux/slab.h>
2904a9016eSOhad Ben-Cohen 
3004a9016eSOhad Ben-Cohen #include "remoteproc_internal.h"
3104a9016eSOhad Ben-Cohen 
3204a9016eSOhad Ben-Cohen /* kick the remote processor, and let it know which virtqueue to poke at */
3346f9c2b9SHeinz Graalfs static bool rproc_virtio_notify(struct virtqueue *vq)
3404a9016eSOhad Ben-Cohen {
357a186941SOhad Ben-Cohen 	struct rproc_vring *rvring = vq->priv;
367a186941SOhad Ben-Cohen 	struct rproc *rproc = rvring->rvdev->rproc;
377a186941SOhad Ben-Cohen 	int notifyid = rvring->notifyid;
3804a9016eSOhad Ben-Cohen 
39b5ab5e24SOhad Ben-Cohen 	dev_dbg(&rproc->dev, "kicking vq index: %d\n", notifyid);
4004a9016eSOhad Ben-Cohen 
417a186941SOhad Ben-Cohen 	rproc->ops->kick(rproc, notifyid);
4246f9c2b9SHeinz Graalfs 	return true;
4304a9016eSOhad Ben-Cohen }
4404a9016eSOhad Ben-Cohen 
4504a9016eSOhad Ben-Cohen /**
4604a9016eSOhad Ben-Cohen  * rproc_vq_interrupt() - tell remoteproc that a virtqueue is interrupted
4704a9016eSOhad Ben-Cohen  * @rproc: handle to the remote processor
487a186941SOhad Ben-Cohen  * @notifyid: index of the signalled virtqueue (unique per this @rproc)
4904a9016eSOhad Ben-Cohen  *
5004a9016eSOhad Ben-Cohen  * This function should be called by the platform-specific rproc driver,
5104a9016eSOhad Ben-Cohen  * when the remote processor signals that a specific virtqueue has pending
5204a9016eSOhad Ben-Cohen  * messages available.
5304a9016eSOhad Ben-Cohen  *
547a186941SOhad Ben-Cohen  * Returns IRQ_NONE if no message was found in the @notifyid virtqueue,
5504a9016eSOhad Ben-Cohen  * and otherwise returns IRQ_HANDLED.
5604a9016eSOhad Ben-Cohen  */
577a186941SOhad Ben-Cohen irqreturn_t rproc_vq_interrupt(struct rproc *rproc, int notifyid)
5804a9016eSOhad Ben-Cohen {
597a186941SOhad Ben-Cohen 	struct rproc_vring *rvring;
607a186941SOhad Ben-Cohen 
61b5ab5e24SOhad Ben-Cohen 	dev_dbg(&rproc->dev, "vq index %d is interrupted\n", notifyid);
627a186941SOhad Ben-Cohen 
637a186941SOhad Ben-Cohen 	rvring = idr_find(&rproc->notifyids, notifyid);
647a186941SOhad Ben-Cohen 	if (!rvring || !rvring->vq)
657a186941SOhad Ben-Cohen 		return IRQ_NONE;
667a186941SOhad Ben-Cohen 
677a186941SOhad Ben-Cohen 	return vring_interrupt(0, rvring->vq);
6804a9016eSOhad Ben-Cohen }
6904a9016eSOhad Ben-Cohen EXPORT_SYMBOL(rproc_vq_interrupt);
7004a9016eSOhad Ben-Cohen 
7104a9016eSOhad Ben-Cohen static struct virtqueue *rp_find_vq(struct virtio_device *vdev,
72f145928dSAnna, Suman 				    unsigned int id,
7304a9016eSOhad Ben-Cohen 				    void (*callback)(struct virtqueue *vq),
74f94682ddSMichael S. Tsirkin 				    const char *name, bool ctx)
7504a9016eSOhad Ben-Cohen {
767a186941SOhad Ben-Cohen 	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev);
7704a9016eSOhad Ben-Cohen 	struct rproc *rproc = vdev_to_rproc(vdev);
78b5ab5e24SOhad Ben-Cohen 	struct device *dev = &rproc->dev;
79*c6aed238SLoic Pallardy 	struct rproc_mem_entry *mem;
807a186941SOhad Ben-Cohen 	struct rproc_vring *rvring;
81*c6aed238SLoic Pallardy 	struct fw_rsc_vdev *rsc;
8204a9016eSOhad Ben-Cohen 	struct virtqueue *vq;
8304a9016eSOhad Ben-Cohen 	void *addr;
84a863af5dSBjorn Andersson 	int len, size;
8504a9016eSOhad Ben-Cohen 
867a186941SOhad Ben-Cohen 	/* we're temporarily limited to two virtqueues per rvdev */
877a186941SOhad Ben-Cohen 	if (id >= ARRAY_SIZE(rvdev->vring))
887a186941SOhad Ben-Cohen 		return ERR_PTR(-EINVAL);
8904a9016eSOhad Ben-Cohen 
906457f126SMichael S. Tsirkin 	if (!name)
916457f126SMichael S. Tsirkin 		return NULL;
926457f126SMichael S. Tsirkin 
93*c6aed238SLoic Pallardy 	/* Search allocated memory region by name */
94*c6aed238SLoic Pallardy 	mem = rproc_find_carveout_by_name(rproc, "vdev%dvring%d", rvdev->index,
95*c6aed238SLoic Pallardy 					  id);
96*c6aed238SLoic Pallardy 	if (!mem || !mem->va)
97*c6aed238SLoic Pallardy 		return ERR_PTR(-ENOMEM);
98*c6aed238SLoic Pallardy 
996db20ea8SOhad Ben-Cohen 	rvring = &rvdev->vring[id];
100*c6aed238SLoic Pallardy 	addr = mem->va;
1017a186941SOhad Ben-Cohen 	len = rvring->len;
10204a9016eSOhad Ben-Cohen 
1037a186941SOhad Ben-Cohen 	/* zero vring */
1047a186941SOhad Ben-Cohen 	size = vring_size(len, rvring->align);
1057a186941SOhad Ben-Cohen 	memset(addr, 0, size);
1067a186941SOhad Ben-Cohen 
107276ec993SLoic Pallardy 	dev_dbg(dev, "vring%d: va %pK qsz %d notifyid %d\n",
1087a186941SOhad Ben-Cohen 		id, addr, len, rvring->notifyid);
10904a9016eSOhad Ben-Cohen 
11004a9016eSOhad Ben-Cohen 	/*
11104a9016eSOhad Ben-Cohen 	 * Create the new vq, and tell virtio we're not interested in
11204a9016eSOhad Ben-Cohen 	 * the 'weak' smp barriers, since we're talking with a real device.
11304a9016eSOhad Ben-Cohen 	 */
114f94682ddSMichael S. Tsirkin 	vq = vring_new_virtqueue(id, len, rvring->align, vdev, false, ctx,
115f94682ddSMichael S. Tsirkin 				 addr, rproc_virtio_notify, callback, name);
11604a9016eSOhad Ben-Cohen 	if (!vq) {
117b5ab5e24SOhad Ben-Cohen 		dev_err(dev, "vring_new_virtqueue %s failed\n", name);
1186db20ea8SOhad Ben-Cohen 		rproc_free_vring(rvring);
1197a186941SOhad Ben-Cohen 		return ERR_PTR(-ENOMEM);
12004a9016eSOhad Ben-Cohen 	}
12104a9016eSOhad Ben-Cohen 
1227a186941SOhad Ben-Cohen 	rvring->vq = vq;
1237a186941SOhad Ben-Cohen 	vq->priv = rvring;
12404a9016eSOhad Ben-Cohen 
125*c6aed238SLoic Pallardy 	/* Update vring in resource table */
126*c6aed238SLoic Pallardy 	rsc = (void *)rproc->table_ptr + rvdev->rsc_offset;
127*c6aed238SLoic Pallardy 	rsc->vring[id].da = mem->da;
128*c6aed238SLoic Pallardy 
12904a9016eSOhad Ben-Cohen 	return vq;
13004a9016eSOhad Ben-Cohen }
13104a9016eSOhad Ben-Cohen 
132dab55bbaSOhad Ben-Cohen static void __rproc_virtio_del_vqs(struct virtio_device *vdev)
13304a9016eSOhad Ben-Cohen {
13404a9016eSOhad Ben-Cohen 	struct virtqueue *vq, *n;
1357a186941SOhad Ben-Cohen 	struct rproc_vring *rvring;
13604a9016eSOhad Ben-Cohen 
13704a9016eSOhad Ben-Cohen 	list_for_each_entry_safe(vq, n, &vdev->vqs, list) {
1387a186941SOhad Ben-Cohen 		rvring = vq->priv;
1397a186941SOhad Ben-Cohen 		rvring->vq = NULL;
14004a9016eSOhad Ben-Cohen 		vring_del_virtqueue(vq);
14104a9016eSOhad Ben-Cohen 	}
14204a9016eSOhad Ben-Cohen }
14304a9016eSOhad Ben-Cohen 
144dab55bbaSOhad Ben-Cohen static void rproc_virtio_del_vqs(struct virtio_device *vdev)
145dab55bbaSOhad Ben-Cohen {
146dab55bbaSOhad Ben-Cohen 	__rproc_virtio_del_vqs(vdev);
147dab55bbaSOhad Ben-Cohen }
148dab55bbaSOhad Ben-Cohen 
149f145928dSAnna, Suman static int rproc_virtio_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
15004a9016eSOhad Ben-Cohen 				 struct virtqueue *vqs[],
15104a9016eSOhad Ben-Cohen 				 vq_callback_t *callbacks[],
152fb5e31d9SChristoph Hellwig 				 const char * const names[],
153f94682ddSMichael S. Tsirkin 				 const bool * ctx,
154fb5e31d9SChristoph Hellwig 				 struct irq_affinity *desc)
15504a9016eSOhad Ben-Cohen {
15604a9016eSOhad Ben-Cohen 	int i, ret;
15704a9016eSOhad Ben-Cohen 
15804a9016eSOhad Ben-Cohen 	for (i = 0; i < nvqs; ++i) {
159f94682ddSMichael S. Tsirkin 		vqs[i] = rp_find_vq(vdev, i, callbacks[i], names[i],
160f94682ddSMichael S. Tsirkin 				    ctx ? ctx[i] : false);
16104a9016eSOhad Ben-Cohen 		if (IS_ERR(vqs[i])) {
16204a9016eSOhad Ben-Cohen 			ret = PTR_ERR(vqs[i]);
16304a9016eSOhad Ben-Cohen 			goto error;
16404a9016eSOhad Ben-Cohen 		}
16504a9016eSOhad Ben-Cohen 	}
16604a9016eSOhad Ben-Cohen 
16704a9016eSOhad Ben-Cohen 	return 0;
16804a9016eSOhad Ben-Cohen 
16904a9016eSOhad Ben-Cohen error:
170dab55bbaSOhad Ben-Cohen 	__rproc_virtio_del_vqs(vdev);
17104a9016eSOhad Ben-Cohen 	return ret;
17204a9016eSOhad Ben-Cohen }
17304a9016eSOhad Ben-Cohen 
17404a9016eSOhad Ben-Cohen static u8 rproc_virtio_get_status(struct virtio_device *vdev)
17504a9016eSOhad Ben-Cohen {
17692b38f85SSjur Brændeland 	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev);
17792b38f85SSjur Brændeland 	struct fw_rsc_vdev *rsc;
17892b38f85SSjur Brændeland 
17992b38f85SSjur Brændeland 	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset;
18092b38f85SSjur Brændeland 
18192b38f85SSjur Brændeland 	return rsc->status;
18204a9016eSOhad Ben-Cohen }
18304a9016eSOhad Ben-Cohen 
18404a9016eSOhad Ben-Cohen static void rproc_virtio_set_status(struct virtio_device *vdev, u8 status)
18504a9016eSOhad Ben-Cohen {
18692b38f85SSjur Brændeland 	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev);
18792b38f85SSjur Brændeland 	struct fw_rsc_vdev *rsc;
18892b38f85SSjur Brændeland 
18992b38f85SSjur Brændeland 	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset;
19092b38f85SSjur Brændeland 
19192b38f85SSjur Brændeland 	rsc->status = status;
1927a186941SOhad Ben-Cohen 	dev_dbg(&vdev->dev, "status: %d\n", status);
19304a9016eSOhad Ben-Cohen }
19404a9016eSOhad Ben-Cohen 
19504a9016eSOhad Ben-Cohen static void rproc_virtio_reset(struct virtio_device *vdev)
19604a9016eSOhad Ben-Cohen {
19792b38f85SSjur Brændeland 	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev);
19892b38f85SSjur Brændeland 	struct fw_rsc_vdev *rsc;
19992b38f85SSjur Brændeland 
20092b38f85SSjur Brændeland 	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset;
20192b38f85SSjur Brændeland 
20292b38f85SSjur Brændeland 	rsc->status = 0;
20304a9016eSOhad Ben-Cohen 	dev_dbg(&vdev->dev, "reset !\n");
20404a9016eSOhad Ben-Cohen }
20504a9016eSOhad Ben-Cohen 
20604a9016eSOhad Ben-Cohen /* provide the vdev features as retrieved from the firmware */
207d0254773SMichael S. Tsirkin static u64 rproc_virtio_get_features(struct virtio_device *vdev)
20804a9016eSOhad Ben-Cohen {
2097a186941SOhad Ben-Cohen 	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev);
21092b38f85SSjur Brændeland 	struct fw_rsc_vdev *rsc;
21104a9016eSOhad Ben-Cohen 
21292b38f85SSjur Brændeland 	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset;
21392b38f85SSjur Brændeland 
21492b38f85SSjur Brændeland 	return rsc->dfeatures;
21504a9016eSOhad Ben-Cohen }
21604a9016eSOhad Ben-Cohen 
2175c609a5eSMichael S. Tsirkin static int rproc_virtio_finalize_features(struct virtio_device *vdev)
21804a9016eSOhad Ben-Cohen {
2197a186941SOhad Ben-Cohen 	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev);
22092b38f85SSjur Brændeland 	struct fw_rsc_vdev *rsc;
22192b38f85SSjur Brændeland 
22292b38f85SSjur Brændeland 	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset;
22304a9016eSOhad Ben-Cohen 
22404a9016eSOhad Ben-Cohen 	/* Give virtio_ring a chance to accept features */
22504a9016eSOhad Ben-Cohen 	vring_transport_features(vdev);
22604a9016eSOhad Ben-Cohen 
22793d389f8SMichael S. Tsirkin 	/* Make sure we don't have any features > 32 bits! */
22893d389f8SMichael S. Tsirkin 	BUG_ON((u32)vdev->features != vdev->features);
22993d389f8SMichael S. Tsirkin 
23004a9016eSOhad Ben-Cohen 	/*
23104a9016eSOhad Ben-Cohen 	 * Remember the finalized features of our vdev, and provide it
23204a9016eSOhad Ben-Cohen 	 * to the remote processor once it is powered on.
23304a9016eSOhad Ben-Cohen 	 */
234e16e12beSMichael S. Tsirkin 	rsc->gfeatures = vdev->features;
2355c609a5eSMichael S. Tsirkin 
2365c609a5eSMichael S. Tsirkin 	return 0;
23792b38f85SSjur Brændeland }
23892b38f85SSjur Brændeland 
239f145928dSAnna, Suman static void rproc_virtio_get(struct virtio_device *vdev, unsigned int offset,
240f145928dSAnna, Suman 			     void *buf, unsigned int len)
24192b38f85SSjur Brændeland {
24292b38f85SSjur Brændeland 	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev);
24392b38f85SSjur Brændeland 	struct fw_rsc_vdev *rsc;
24492b38f85SSjur Brændeland 	void *cfg;
24592b38f85SSjur Brændeland 
24692b38f85SSjur Brændeland 	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset;
24792b38f85SSjur Brændeland 	cfg = &rsc->vring[rsc->num_of_vrings];
24892b38f85SSjur Brændeland 
24992b38f85SSjur Brændeland 	if (offset + len > rsc->config_len || offset + len < len) {
25092b38f85SSjur Brændeland 		dev_err(&vdev->dev, "rproc_virtio_get: access out of bounds\n");
25192b38f85SSjur Brændeland 		return;
25292b38f85SSjur Brændeland 	}
25392b38f85SSjur Brændeland 
25492b38f85SSjur Brændeland 	memcpy(buf, cfg + offset, len);
25592b38f85SSjur Brændeland }
25692b38f85SSjur Brændeland 
257f145928dSAnna, Suman static void rproc_virtio_set(struct virtio_device *vdev, unsigned int offset,
258f145928dSAnna, Suman 			     const void *buf, unsigned int len)
25992b38f85SSjur Brændeland {
26092b38f85SSjur Brændeland 	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev);
26192b38f85SSjur Brændeland 	struct fw_rsc_vdev *rsc;
26292b38f85SSjur Brændeland 	void *cfg;
26392b38f85SSjur Brændeland 
26492b38f85SSjur Brændeland 	rsc = (void *)rvdev->rproc->table_ptr + rvdev->rsc_offset;
26592b38f85SSjur Brændeland 	cfg = &rsc->vring[rsc->num_of_vrings];
26692b38f85SSjur Brændeland 
26792b38f85SSjur Brændeland 	if (offset + len > rsc->config_len || offset + len < len) {
26892b38f85SSjur Brændeland 		dev_err(&vdev->dev, "rproc_virtio_set: access out of bounds\n");
26992b38f85SSjur Brændeland 		return;
27092b38f85SSjur Brændeland 	}
27192b38f85SSjur Brændeland 
27292b38f85SSjur Brændeland 	memcpy(cfg + offset, buf, len);
27304a9016eSOhad Ben-Cohen }
27404a9016eSOhad Ben-Cohen 
27593503932SStephen Hemminger static const struct virtio_config_ops rproc_virtio_config_ops = {
27604a9016eSOhad Ben-Cohen 	.get_features	= rproc_virtio_get_features,
27704a9016eSOhad Ben-Cohen 	.finalize_features = rproc_virtio_finalize_features,
27804a9016eSOhad Ben-Cohen 	.find_vqs	= rproc_virtio_find_vqs,
27904a9016eSOhad Ben-Cohen 	.del_vqs	= rproc_virtio_del_vqs,
28004a9016eSOhad Ben-Cohen 	.reset		= rproc_virtio_reset,
28104a9016eSOhad Ben-Cohen 	.set_status	= rproc_virtio_set_status,
28204a9016eSOhad Ben-Cohen 	.get_status	= rproc_virtio_get_status,
28392b38f85SSjur Brændeland 	.get		= rproc_virtio_get,
28492b38f85SSjur Brændeland 	.set		= rproc_virtio_set,
28504a9016eSOhad Ben-Cohen };
28604a9016eSOhad Ben-Cohen 
28704a9016eSOhad Ben-Cohen /*
28804a9016eSOhad Ben-Cohen  * This function is called whenever vdev is released, and is responsible
2897183a2a7SOhad Ben-Cohen  * to decrement the remote processor's refcount which was taken when vdev was
29004a9016eSOhad Ben-Cohen  * added.
29104a9016eSOhad Ben-Cohen  *
29204a9016eSOhad Ben-Cohen  * Never call this function directly; it will be called by the driver
29304a9016eSOhad Ben-Cohen  * core when needed.
29404a9016eSOhad Ben-Cohen  */
295aab8d802SBjorn Andersson static void rproc_virtio_dev_release(struct device *dev)
29604a9016eSOhad Ben-Cohen {
29704a9016eSOhad Ben-Cohen 	struct virtio_device *vdev = dev_to_virtio(dev);
2986db20ea8SOhad Ben-Cohen 	struct rproc_vdev *rvdev = vdev_to_rvdev(vdev);
29904a9016eSOhad Ben-Cohen 	struct rproc *rproc = vdev_to_rproc(vdev);
30004a9016eSOhad Ben-Cohen 
301aab8d802SBjorn Andersson 	kref_put(&rvdev->refcount, rproc_vdev_release);
3026db20ea8SOhad Ben-Cohen 
3037183a2a7SOhad Ben-Cohen 	put_device(&rproc->dev);
30404a9016eSOhad Ben-Cohen }
30504a9016eSOhad Ben-Cohen 
30604a9016eSOhad Ben-Cohen /**
3077a186941SOhad Ben-Cohen  * rproc_add_virtio_dev() - register an rproc-induced virtio device
3087a186941SOhad Ben-Cohen  * @rvdev: the remote vdev
30904a9016eSOhad Ben-Cohen  *
3107a186941SOhad Ben-Cohen  * This function registers a virtio device. This vdev's partent is
3117a186941SOhad Ben-Cohen  * the rproc device.
31204a9016eSOhad Ben-Cohen  *
3137a186941SOhad Ben-Cohen  * Returns 0 on success or an appropriate error value otherwise.
31404a9016eSOhad Ben-Cohen  */
3157a186941SOhad Ben-Cohen int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)
31604a9016eSOhad Ben-Cohen {
3177a186941SOhad Ben-Cohen 	struct rproc *rproc = rvdev->rproc;
318b5ab5e24SOhad Ben-Cohen 	struct device *dev = &rproc->dev;
3197a186941SOhad Ben-Cohen 	struct virtio_device *vdev = &rvdev->vdev;
32004a9016eSOhad Ben-Cohen 	int ret;
32104a9016eSOhad Ben-Cohen 
3227a186941SOhad Ben-Cohen 	vdev->id.device	= id,
3237a186941SOhad Ben-Cohen 	vdev->config = &rproc_virtio_config_ops,
3247a186941SOhad Ben-Cohen 	vdev->dev.parent = dev;
325aab8d802SBjorn Andersson 	vdev->dev.release = rproc_virtio_dev_release;
32604a9016eSOhad Ben-Cohen 
32704a9016eSOhad Ben-Cohen 	/*
32804a9016eSOhad Ben-Cohen 	 * We're indirectly making a non-temporary copy of the rproc pointer
32904a9016eSOhad Ben-Cohen 	 * here, because drivers probed with this vdev will indirectly
33004a9016eSOhad Ben-Cohen 	 * access the wrapping rproc.
33104a9016eSOhad Ben-Cohen 	 *
33204a9016eSOhad Ben-Cohen 	 * Therefore we must increment the rproc refcount here, and decrement
33304a9016eSOhad Ben-Cohen 	 * it _only_ when the vdev is released.
33404a9016eSOhad Ben-Cohen 	 */
3357183a2a7SOhad Ben-Cohen 	get_device(&rproc->dev);
33604a9016eSOhad Ben-Cohen 
337aab8d802SBjorn Andersson 	/* Reference the vdev and vring allocations */
338aab8d802SBjorn Andersson 	kref_get(&rvdev->refcount);
339aab8d802SBjorn Andersson 
3407a186941SOhad Ben-Cohen 	ret = register_virtio_device(vdev);
34104a9016eSOhad Ben-Cohen 	if (ret) {
342900a163eSweiping zhang 		put_device(&vdev->dev);
34304a9016eSOhad Ben-Cohen 		dev_err(dev, "failed to register vdev: %d\n", ret);
3447a186941SOhad Ben-Cohen 		goto out;
34504a9016eSOhad Ben-Cohen 	}
34604a9016eSOhad Ben-Cohen 
3477a186941SOhad Ben-Cohen 	dev_info(dev, "registered %s (type %d)\n", dev_name(&vdev->dev), id);
3487a186941SOhad Ben-Cohen 
3497a186941SOhad Ben-Cohen out:
35004a9016eSOhad Ben-Cohen 	return ret;
35104a9016eSOhad Ben-Cohen }
35204a9016eSOhad Ben-Cohen 
35304a9016eSOhad Ben-Cohen /**
3547a186941SOhad Ben-Cohen  * rproc_remove_virtio_dev() - remove an rproc-induced virtio device
3557a186941SOhad Ben-Cohen  * @rvdev: the remote vdev
35604a9016eSOhad Ben-Cohen  *
3577a186941SOhad Ben-Cohen  * This function unregisters an existing virtio device.
35804a9016eSOhad Ben-Cohen  */
3597a186941SOhad Ben-Cohen void rproc_remove_virtio_dev(struct rproc_vdev *rvdev)
36004a9016eSOhad Ben-Cohen {
36104a9016eSOhad Ben-Cohen 	unregister_virtio_device(&rvdev->vdev);
36204a9016eSOhad Ben-Cohen }
363