xref: /linux/drivers/regulator/wm831x-dcdc.c (revision 1aa20d27b4d23c18a20a9268e49e5d21a74789ff)
1 /*
2  * wm831x-dcdc.c  --  DC-DC buck convertor driver for the WM831x series
3  *
4  * Copyright 2009 Wolfson Microelectronics PLC.
5  *
6  * Author: Mark Brown <broonie@opensource.wolfsonmicro.com>
7  *
8  *  This program is free software; you can redistribute  it and/or modify it
9  *  under  the terms of  the GNU General  Public License as published by the
10  *  Free Software Foundation;  either version 2 of the  License, or (at your
11  *  option) any later version.
12  */
13 
14 #include <linux/module.h>
15 #include <linux/moduleparam.h>
16 #include <linux/init.h>
17 #include <linux/bitops.h>
18 #include <linux/err.h>
19 #include <linux/i2c.h>
20 #include <linux/platform_device.h>
21 #include <linux/regulator/driver.h>
22 #include <linux/regulator/machine.h>
23 #include <linux/gpio.h>
24 #include <linux/slab.h>
25 
26 #include <linux/mfd/wm831x/core.h>
27 #include <linux/mfd/wm831x/regulator.h>
28 #include <linux/mfd/wm831x/pdata.h>
29 
30 #define WM831X_BUCKV_MAX_SELECTOR 0x68
31 #define WM831X_BUCKP_MAX_SELECTOR 0x66
32 
33 #define WM831X_DCDC_MODE_FAST    0
34 #define WM831X_DCDC_MODE_NORMAL  1
35 #define WM831X_DCDC_MODE_IDLE    2
36 #define WM831X_DCDC_MODE_STANDBY 3
37 
38 #define WM831X_DCDC_MAX_NAME 9
39 
40 /* Register offsets in control block */
41 #define WM831X_DCDC_CONTROL_1     0
42 #define WM831X_DCDC_CONTROL_2     1
43 #define WM831X_DCDC_ON_CONFIG     2
44 #define WM831X_DCDC_SLEEP_CONTROL 3
45 #define WM831X_DCDC_DVS_CONTROL   4
46 
47 /*
48  * Shared
49  */
50 
51 struct wm831x_dcdc {
52 	char name[WM831X_DCDC_MAX_NAME];
53 	char supply_name[WM831X_DCDC_MAX_NAME];
54 	struct regulator_desc desc;
55 	int base;
56 	struct wm831x *wm831x;
57 	struct regulator_dev *regulator;
58 	int dvs_gpio;
59 	int dvs_gpio_state;
60 	int on_vsel;
61 	int dvs_vsel;
62 };
63 
64 static unsigned int wm831x_dcdc_get_mode(struct regulator_dev *rdev)
65 
66 {
67 	struct wm831x_dcdc *dcdc = rdev_get_drvdata(rdev);
68 	struct wm831x *wm831x = dcdc->wm831x;
69 	u16 reg = dcdc->base + WM831X_DCDC_ON_CONFIG;
70 	int val;
71 
72 	val = wm831x_reg_read(wm831x, reg);
73 	if (val < 0)
74 		return val;
75 
76 	val = (val & WM831X_DC1_ON_MODE_MASK) >> WM831X_DC1_ON_MODE_SHIFT;
77 
78 	switch (val) {
79 	case WM831X_DCDC_MODE_FAST:
80 		return REGULATOR_MODE_FAST;
81 	case WM831X_DCDC_MODE_NORMAL:
82 		return REGULATOR_MODE_NORMAL;
83 	case WM831X_DCDC_MODE_STANDBY:
84 		return REGULATOR_MODE_STANDBY;
85 	case WM831X_DCDC_MODE_IDLE:
86 		return REGULATOR_MODE_IDLE;
87 	default:
88 		BUG();
89 		return -EINVAL;
90 	}
91 }
92 
93 static int wm831x_dcdc_set_mode_int(struct wm831x *wm831x, int reg,
94 				    unsigned int mode)
95 {
96 	int val;
97 
98 	switch (mode) {
99 	case REGULATOR_MODE_FAST:
100 		val = WM831X_DCDC_MODE_FAST;
101 		break;
102 	case REGULATOR_MODE_NORMAL:
103 		val = WM831X_DCDC_MODE_NORMAL;
104 		break;
105 	case REGULATOR_MODE_STANDBY:
106 		val = WM831X_DCDC_MODE_STANDBY;
107 		break;
108 	case REGULATOR_MODE_IDLE:
109 		val = WM831X_DCDC_MODE_IDLE;
110 		break;
111 	default:
112 		return -EINVAL;
113 	}
114 
115 	return wm831x_set_bits(wm831x, reg, WM831X_DC1_ON_MODE_MASK,
116 			       val << WM831X_DC1_ON_MODE_SHIFT);
117 }
118 
119 static int wm831x_dcdc_set_mode(struct regulator_dev *rdev, unsigned int mode)
120 {
121 	struct wm831x_dcdc *dcdc = rdev_get_drvdata(rdev);
122 	struct wm831x *wm831x = dcdc->wm831x;
123 	u16 reg = dcdc->base + WM831X_DCDC_ON_CONFIG;
124 
125 	return wm831x_dcdc_set_mode_int(wm831x, reg, mode);
126 }
127 
128 static int wm831x_dcdc_set_suspend_mode(struct regulator_dev *rdev,
129 					unsigned int mode)
130 {
131 	struct wm831x_dcdc *dcdc = rdev_get_drvdata(rdev);
132 	struct wm831x *wm831x = dcdc->wm831x;
133 	u16 reg = dcdc->base + WM831X_DCDC_SLEEP_CONTROL;
134 
135 	return wm831x_dcdc_set_mode_int(wm831x, reg, mode);
136 }
137 
138 static int wm831x_dcdc_get_status(struct regulator_dev *rdev)
139 {
140 	struct wm831x_dcdc *dcdc = rdev_get_drvdata(rdev);
141 	struct wm831x *wm831x = dcdc->wm831x;
142 	int ret;
143 
144 	/* First, check for errors */
145 	ret = wm831x_reg_read(wm831x, WM831X_DCDC_UV_STATUS);
146 	if (ret < 0)
147 		return ret;
148 
149 	if (ret & (1 << rdev_get_id(rdev))) {
150 		dev_dbg(wm831x->dev, "DCDC%d under voltage\n",
151 			rdev_get_id(rdev) + 1);
152 		return REGULATOR_STATUS_ERROR;
153 	}
154 
155 	/* DCDC1 and DCDC2 can additionally detect high voltage/current */
156 	if (rdev_get_id(rdev) < 2) {
157 		if (ret & (WM831X_DC1_OV_STS << rdev_get_id(rdev))) {
158 			dev_dbg(wm831x->dev, "DCDC%d over voltage\n",
159 				rdev_get_id(rdev) + 1);
160 			return REGULATOR_STATUS_ERROR;
161 		}
162 
163 		if (ret & (WM831X_DC1_HC_STS << rdev_get_id(rdev))) {
164 			dev_dbg(wm831x->dev, "DCDC%d over current\n",
165 				rdev_get_id(rdev) + 1);
166 			return REGULATOR_STATUS_ERROR;
167 		}
168 	}
169 
170 	/* Is the regulator on? */
171 	ret = wm831x_reg_read(wm831x, WM831X_DCDC_STATUS);
172 	if (ret < 0)
173 		return ret;
174 	if (!(ret & (1 << rdev_get_id(rdev))))
175 		return REGULATOR_STATUS_OFF;
176 
177 	/* TODO: When we handle hardware control modes so we can report the
178 	 * current mode. */
179 	return REGULATOR_STATUS_ON;
180 }
181 
182 static irqreturn_t wm831x_dcdc_uv_irq(int irq, void *data)
183 {
184 	struct wm831x_dcdc *dcdc = data;
185 
186 	regulator_notifier_call_chain(dcdc->regulator,
187 				      REGULATOR_EVENT_UNDER_VOLTAGE,
188 				      NULL);
189 
190 	return IRQ_HANDLED;
191 }
192 
193 static irqreturn_t wm831x_dcdc_oc_irq(int irq, void *data)
194 {
195 	struct wm831x_dcdc *dcdc = data;
196 
197 	regulator_notifier_call_chain(dcdc->regulator,
198 				      REGULATOR_EVENT_OVER_CURRENT,
199 				      NULL);
200 
201 	return IRQ_HANDLED;
202 }
203 
204 /*
205  * BUCKV specifics
206  */
207 
208 static int wm831x_buckv_list_voltage(struct regulator_dev *rdev,
209 				      unsigned selector)
210 {
211 	if (selector <= 0x8)
212 		return 600000;
213 	if (selector <= WM831X_BUCKV_MAX_SELECTOR)
214 		return 600000 + ((selector - 0x8) * 12500);
215 	return -EINVAL;
216 }
217 
218 static int wm831x_buckv_map_voltage(struct regulator_dev *rdev,
219 				   int min_uV, int max_uV)
220 {
221 	u16 vsel;
222 
223 	if (min_uV < 600000)
224 		vsel = 0;
225 	else if (min_uV <= 1800000)
226 		vsel = DIV_ROUND_UP(min_uV - 600000, 12500) + 8;
227 	else
228 		return -EINVAL;
229 
230 	if (wm831x_buckv_list_voltage(rdev, vsel) > max_uV)
231 		return -EINVAL;
232 
233 	return vsel;
234 }
235 
236 static int wm831x_buckv_set_dvs(struct regulator_dev *rdev, int state)
237 {
238 	struct wm831x_dcdc *dcdc = rdev_get_drvdata(rdev);
239 
240 	if (state == dcdc->dvs_gpio_state)
241 		return 0;
242 
243 	dcdc->dvs_gpio_state = state;
244 	gpio_set_value(dcdc->dvs_gpio, state);
245 
246 	/* Should wait for DVS state change to be asserted if we have
247 	 * a GPIO for it, for now assume the device is configured
248 	 * for the fastest possible transition.
249 	 */
250 
251 	return 0;
252 }
253 
254 static int wm831x_buckv_set_voltage_sel(struct regulator_dev *rdev,
255 					unsigned vsel)
256 {
257 	struct wm831x_dcdc *dcdc = rdev_get_drvdata(rdev);
258 	struct wm831x *wm831x = dcdc->wm831x;
259 	int on_reg = dcdc->base + WM831X_DCDC_ON_CONFIG;
260 	int dvs_reg = dcdc->base + WM831X_DCDC_DVS_CONTROL;
261 	int ret;
262 
263 	/* If this value is already set then do a GPIO update if we can */
264 	if (dcdc->dvs_gpio && dcdc->on_vsel == vsel)
265 		return wm831x_buckv_set_dvs(rdev, 0);
266 
267 	if (dcdc->dvs_gpio && dcdc->dvs_vsel == vsel)
268 		return wm831x_buckv_set_dvs(rdev, 1);
269 
270 	/* Always set the ON status to the minimum voltage */
271 	ret = wm831x_set_bits(wm831x, on_reg, WM831X_DC1_ON_VSEL_MASK, vsel);
272 	if (ret < 0)
273 		return ret;
274 	dcdc->on_vsel = vsel;
275 
276 	if (!dcdc->dvs_gpio)
277 		return ret;
278 
279 	/* Kick the voltage transition now */
280 	ret = wm831x_buckv_set_dvs(rdev, 0);
281 	if (ret < 0)
282 		return ret;
283 
284 	/*
285 	 * If this VSEL is higher than the last one we've seen then
286 	 * remember it as the DVS VSEL.  This is optimised for CPUfreq
287 	 * usage where we want to get to the highest voltage very
288 	 * quickly.
289 	 */
290 	if (vsel > dcdc->dvs_vsel) {
291 		ret = wm831x_set_bits(wm831x, dvs_reg,
292 				      WM831X_DC1_DVS_VSEL_MASK,
293 				      vsel);
294 		if (ret == 0)
295 			dcdc->dvs_vsel = vsel;
296 		else
297 			dev_warn(wm831x->dev,
298 				 "Failed to set DCDC DVS VSEL: %d\n", ret);
299 	}
300 
301 	return 0;
302 }
303 
304 static int wm831x_buckv_set_suspend_voltage(struct regulator_dev *rdev,
305 					    int uV)
306 {
307 	struct wm831x_dcdc *dcdc = rdev_get_drvdata(rdev);
308 	struct wm831x *wm831x = dcdc->wm831x;
309 	u16 reg = dcdc->base + WM831X_DCDC_SLEEP_CONTROL;
310 	int vsel;
311 
312 	vsel = wm831x_buckv_map_voltage(rdev, uV, uV);
313 	if (vsel < 0)
314 		return vsel;
315 
316 	return wm831x_set_bits(wm831x, reg, WM831X_DC1_SLP_VSEL_MASK, vsel);
317 }
318 
319 static int wm831x_buckv_get_voltage_sel(struct regulator_dev *rdev)
320 {
321 	struct wm831x_dcdc *dcdc = rdev_get_drvdata(rdev);
322 
323 	if (dcdc->dvs_gpio && dcdc->dvs_gpio_state)
324 		return dcdc->dvs_vsel;
325 	else
326 		return dcdc->on_vsel;
327 }
328 
329 /* Current limit options */
330 static u16 wm831x_dcdc_ilim[] = {
331 	125, 250, 375, 500, 625, 750, 875, 1000
332 };
333 
334 static int wm831x_buckv_set_current_limit(struct regulator_dev *rdev,
335 					   int min_uA, int max_uA)
336 {
337 	struct wm831x_dcdc *dcdc = rdev_get_drvdata(rdev);
338 	struct wm831x *wm831x = dcdc->wm831x;
339 	u16 reg = dcdc->base + WM831X_DCDC_CONTROL_2;
340 	int i;
341 
342 	for (i = ARRAY_SIZE(wm831x_dcdc_ilim) - 1; i >= 0; i--) {
343 		if ((min_uA <= wm831x_dcdc_ilim[i]) &&
344 		    (wm831x_dcdc_ilim[i] <= max_uA))
345 			return wm831x_set_bits(wm831x, reg,
346 					       WM831X_DC1_HC_THR_MASK,
347 						i << WM831X_DC1_HC_THR_SHIFT);
348 	}
349 
350 	return -EINVAL;
351 }
352 
353 static int wm831x_buckv_get_current_limit(struct regulator_dev *rdev)
354 {
355 	struct wm831x_dcdc *dcdc = rdev_get_drvdata(rdev);
356 	struct wm831x *wm831x = dcdc->wm831x;
357 	u16 reg = dcdc->base + WM831X_DCDC_CONTROL_2;
358 	int val;
359 
360 	val = wm831x_reg_read(wm831x, reg);
361 	if (val < 0)
362 		return val;
363 
364 	val = (val & WM831X_DC1_HC_THR_MASK) >> WM831X_DC1_HC_THR_SHIFT;
365 	return wm831x_dcdc_ilim[val];
366 }
367 
368 static struct regulator_ops wm831x_buckv_ops = {
369 	.set_voltage_sel = wm831x_buckv_set_voltage_sel,
370 	.get_voltage_sel = wm831x_buckv_get_voltage_sel,
371 	.list_voltage = wm831x_buckv_list_voltage,
372 	.map_voltage = wm831x_buckv_map_voltage,
373 	.set_suspend_voltage = wm831x_buckv_set_suspend_voltage,
374 	.set_current_limit = wm831x_buckv_set_current_limit,
375 	.get_current_limit = wm831x_buckv_get_current_limit,
376 
377 	.is_enabled = regulator_is_enabled_regmap,
378 	.enable = regulator_enable_regmap,
379 	.disable = regulator_disable_regmap,
380 	.get_status = wm831x_dcdc_get_status,
381 	.get_mode = wm831x_dcdc_get_mode,
382 	.set_mode = wm831x_dcdc_set_mode,
383 	.set_suspend_mode = wm831x_dcdc_set_suspend_mode,
384 };
385 
386 /*
387  * Set up DVS control.  We just log errors since we can still run
388  * (with reduced performance) if we fail.
389  */
390 static void wm831x_buckv_dvs_init(struct platform_device *pdev,
391 				  struct wm831x_dcdc *dcdc,
392 				  struct wm831x_buckv_pdata *pdata)
393 {
394 	struct wm831x *wm831x = dcdc->wm831x;
395 	int ret;
396 	u16 ctrl;
397 
398 	if (!pdata || !pdata->dvs_gpio)
399 		return;
400 
401 	/* gpiolib won't let us read the GPIO status so pick the higher
402 	 * of the two existing voltages so we take it as platform data.
403 	 */
404 	dcdc->dvs_gpio_state = pdata->dvs_init_state;
405 
406 	ret = devm_gpio_request_one(&pdev->dev, pdata->dvs_gpio,
407 				    dcdc->dvs_gpio_state ? GPIOF_INIT_HIGH : 0,
408 				    "DCDC DVS");
409 	if (ret < 0) {
410 		dev_err(wm831x->dev, "Failed to get %s DVS GPIO: %d\n",
411 			dcdc->name, ret);
412 		return;
413 	}
414 
415 	dcdc->dvs_gpio = pdata->dvs_gpio;
416 
417 	switch (pdata->dvs_control_src) {
418 	case 1:
419 		ctrl = 2 << WM831X_DC1_DVS_SRC_SHIFT;
420 		break;
421 	case 2:
422 		ctrl = 3 << WM831X_DC1_DVS_SRC_SHIFT;
423 		break;
424 	default:
425 		dev_err(wm831x->dev, "Invalid DVS control source %d for %s\n",
426 			pdata->dvs_control_src, dcdc->name);
427 		return;
428 	}
429 
430 	/* If DVS_VSEL is set to the minimum value then raise it to ON_VSEL
431 	 * to make bootstrapping a bit smoother.
432 	 */
433 	if (!dcdc->dvs_vsel) {
434 		ret = wm831x_set_bits(wm831x,
435 				      dcdc->base + WM831X_DCDC_DVS_CONTROL,
436 				      WM831X_DC1_DVS_VSEL_MASK, dcdc->on_vsel);
437 		if (ret == 0)
438 			dcdc->dvs_vsel = dcdc->on_vsel;
439 		else
440 			dev_warn(wm831x->dev, "Failed to set DVS_VSEL: %d\n",
441 				 ret);
442 	}
443 
444 	ret = wm831x_set_bits(wm831x, dcdc->base + WM831X_DCDC_DVS_CONTROL,
445 			      WM831X_DC1_DVS_SRC_MASK, ctrl);
446 	if (ret < 0) {
447 		dev_err(wm831x->dev, "Failed to set %s DVS source: %d\n",
448 			dcdc->name, ret);
449 	}
450 }
451 
452 static int wm831x_buckv_probe(struct platform_device *pdev)
453 {
454 	struct wm831x *wm831x = dev_get_drvdata(pdev->dev.parent);
455 	struct wm831x_pdata *pdata = dev_get_platdata(wm831x->dev);
456 	struct regulator_config config = { };
457 	int id;
458 	struct wm831x_dcdc *dcdc;
459 	struct resource *res;
460 	int ret, irq;
461 
462 	if (pdata && pdata->wm831x_num)
463 		id = (pdata->wm831x_num * 10) + 1;
464 	else
465 		id = 0;
466 	id = pdev->id - id;
467 
468 	dev_dbg(&pdev->dev, "Probing DCDC%d\n", id + 1);
469 
470 	dcdc = devm_kzalloc(&pdev->dev,  sizeof(struct wm831x_dcdc),
471 			    GFP_KERNEL);
472 	if (dcdc == NULL) {
473 		dev_err(&pdev->dev, "Unable to allocate private data\n");
474 		return -ENOMEM;
475 	}
476 
477 	dcdc->wm831x = wm831x;
478 
479 	res = platform_get_resource(pdev, IORESOURCE_REG, 0);
480 	if (res == NULL) {
481 		dev_err(&pdev->dev, "No REG resource\n");
482 		ret = -EINVAL;
483 		goto err;
484 	}
485 	dcdc->base = res->start;
486 
487 	snprintf(dcdc->name, sizeof(dcdc->name), "DCDC%d", id + 1);
488 	dcdc->desc.name = dcdc->name;
489 
490 	snprintf(dcdc->supply_name, sizeof(dcdc->supply_name),
491 		 "DC%dVDD", id + 1);
492 	dcdc->desc.supply_name = dcdc->supply_name;
493 
494 	dcdc->desc.id = id;
495 	dcdc->desc.type = REGULATOR_VOLTAGE;
496 	dcdc->desc.n_voltages = WM831X_BUCKV_MAX_SELECTOR + 1;
497 	dcdc->desc.ops = &wm831x_buckv_ops;
498 	dcdc->desc.owner = THIS_MODULE;
499 	dcdc->desc.enable_reg = WM831X_DCDC_ENABLE;
500 	dcdc->desc.enable_mask = 1 << id;
501 
502 	ret = wm831x_reg_read(wm831x, dcdc->base + WM831X_DCDC_ON_CONFIG);
503 	if (ret < 0) {
504 		dev_err(wm831x->dev, "Failed to read ON VSEL: %d\n", ret);
505 		goto err;
506 	}
507 	dcdc->on_vsel = ret & WM831X_DC1_ON_VSEL_MASK;
508 
509 	ret = wm831x_reg_read(wm831x, dcdc->base + WM831X_DCDC_DVS_CONTROL);
510 	if (ret < 0) {
511 		dev_err(wm831x->dev, "Failed to read DVS VSEL: %d\n", ret);
512 		goto err;
513 	}
514 	dcdc->dvs_vsel = ret & WM831X_DC1_DVS_VSEL_MASK;
515 
516 	if (pdata && pdata->dcdc[id])
517 		wm831x_buckv_dvs_init(pdev, dcdc,
518 				      pdata->dcdc[id]->driver_data);
519 
520 	config.dev = pdev->dev.parent;
521 	if (pdata)
522 		config.init_data = pdata->dcdc[id];
523 	config.driver_data = dcdc;
524 	config.regmap = wm831x->regmap;
525 
526 	dcdc->regulator = regulator_register(&dcdc->desc, &config);
527 	if (IS_ERR(dcdc->regulator)) {
528 		ret = PTR_ERR(dcdc->regulator);
529 		dev_err(wm831x->dev, "Failed to register DCDC%d: %d\n",
530 			id + 1, ret);
531 		goto err;
532 	}
533 
534 	irq = wm831x_irq(wm831x, platform_get_irq_byname(pdev, "UV"));
535 	ret = request_threaded_irq(irq, NULL, wm831x_dcdc_uv_irq,
536 				   IRQF_TRIGGER_RISING, dcdc->name, dcdc);
537 	if (ret != 0) {
538 		dev_err(&pdev->dev, "Failed to request UV IRQ %d: %d\n",
539 			irq, ret);
540 		goto err_regulator;
541 	}
542 
543 	irq = wm831x_irq(wm831x, platform_get_irq_byname(pdev, "HC"));
544 	ret = request_threaded_irq(irq, NULL, wm831x_dcdc_oc_irq,
545 				   IRQF_TRIGGER_RISING, dcdc->name, dcdc);
546 	if (ret != 0) {
547 		dev_err(&pdev->dev, "Failed to request HC IRQ %d: %d\n",
548 			irq, ret);
549 		goto err_uv;
550 	}
551 
552 	platform_set_drvdata(pdev, dcdc);
553 
554 	return 0;
555 
556 err_uv:
557 	free_irq(wm831x_irq(wm831x, platform_get_irq_byname(pdev, "UV")),
558 		 dcdc);
559 err_regulator:
560 	regulator_unregister(dcdc->regulator);
561 err:
562 	return ret;
563 }
564 
565 static int wm831x_buckv_remove(struct platform_device *pdev)
566 {
567 	struct wm831x_dcdc *dcdc = platform_get_drvdata(pdev);
568 	struct wm831x *wm831x = dcdc->wm831x;
569 
570 	free_irq(wm831x_irq(wm831x, platform_get_irq_byname(pdev, "HC")),
571 			    dcdc);
572 	free_irq(wm831x_irq(wm831x, platform_get_irq_byname(pdev, "UV")),
573 			    dcdc);
574 	regulator_unregister(dcdc->regulator);
575 
576 	return 0;
577 }
578 
579 static struct platform_driver wm831x_buckv_driver = {
580 	.probe = wm831x_buckv_probe,
581 	.remove = wm831x_buckv_remove,
582 	.driver		= {
583 		.name	= "wm831x-buckv",
584 		.owner	= THIS_MODULE,
585 	},
586 };
587 
588 /*
589  * BUCKP specifics
590  */
591 
592 static int wm831x_buckp_set_suspend_voltage(struct regulator_dev *rdev, int uV)
593 {
594 	struct wm831x_dcdc *dcdc = rdev_get_drvdata(rdev);
595 	struct wm831x *wm831x = dcdc->wm831x;
596 	u16 reg = dcdc->base + WM831X_DCDC_SLEEP_CONTROL;
597 	int sel;
598 
599 	sel = regulator_map_voltage_linear(rdev, uV, uV);
600 	if (sel < 0)
601 		return sel;
602 
603 	return wm831x_set_bits(wm831x, reg, WM831X_DC3_ON_VSEL_MASK, sel);
604 }
605 
606 static struct regulator_ops wm831x_buckp_ops = {
607 	.set_voltage_sel = regulator_set_voltage_sel_regmap,
608 	.get_voltage_sel = regulator_get_voltage_sel_regmap,
609 	.list_voltage = regulator_list_voltage_linear,
610 	.map_voltage = regulator_map_voltage_linear,
611 	.set_suspend_voltage = wm831x_buckp_set_suspend_voltage,
612 
613 	.is_enabled = regulator_is_enabled_regmap,
614 	.enable = regulator_enable_regmap,
615 	.disable = regulator_disable_regmap,
616 	.get_status = wm831x_dcdc_get_status,
617 	.get_mode = wm831x_dcdc_get_mode,
618 	.set_mode = wm831x_dcdc_set_mode,
619 	.set_suspend_mode = wm831x_dcdc_set_suspend_mode,
620 };
621 
622 static int wm831x_buckp_probe(struct platform_device *pdev)
623 {
624 	struct wm831x *wm831x = dev_get_drvdata(pdev->dev.parent);
625 	struct wm831x_pdata *pdata = dev_get_platdata(wm831x->dev);
626 	struct regulator_config config = { };
627 	int id;
628 	struct wm831x_dcdc *dcdc;
629 	struct resource *res;
630 	int ret, irq;
631 
632 	if (pdata && pdata->wm831x_num)
633 		id = (pdata->wm831x_num * 10) + 1;
634 	else
635 		id = 0;
636 	id = pdev->id - id;
637 
638 	dev_dbg(&pdev->dev, "Probing DCDC%d\n", id + 1);
639 
640 	dcdc = devm_kzalloc(&pdev->dev, sizeof(struct wm831x_dcdc),
641 			    GFP_KERNEL);
642 	if (dcdc == NULL) {
643 		dev_err(&pdev->dev, "Unable to allocate private data\n");
644 		return -ENOMEM;
645 	}
646 
647 	dcdc->wm831x = wm831x;
648 
649 	res = platform_get_resource(pdev, IORESOURCE_REG, 0);
650 	if (res == NULL) {
651 		dev_err(&pdev->dev, "No REG resource\n");
652 		ret = -EINVAL;
653 		goto err;
654 	}
655 	dcdc->base = res->start;
656 
657 	snprintf(dcdc->name, sizeof(dcdc->name), "DCDC%d", id + 1);
658 	dcdc->desc.name = dcdc->name;
659 
660 	snprintf(dcdc->supply_name, sizeof(dcdc->supply_name),
661 		 "DC%dVDD", id + 1);
662 	dcdc->desc.supply_name = dcdc->supply_name;
663 
664 	dcdc->desc.id = id;
665 	dcdc->desc.type = REGULATOR_VOLTAGE;
666 	dcdc->desc.n_voltages = WM831X_BUCKP_MAX_SELECTOR + 1;
667 	dcdc->desc.ops = &wm831x_buckp_ops;
668 	dcdc->desc.owner = THIS_MODULE;
669 	dcdc->desc.vsel_reg = dcdc->base + WM831X_DCDC_ON_CONFIG;
670 	dcdc->desc.vsel_mask = WM831X_DC3_ON_VSEL_MASK;
671 	dcdc->desc.enable_reg = WM831X_DCDC_ENABLE;
672 	dcdc->desc.enable_mask = 1 << id;
673 	dcdc->desc.min_uV = 850000;
674 	dcdc->desc.uV_step = 25000;
675 
676 	config.dev = pdev->dev.parent;
677 	if (pdata)
678 		config.init_data = pdata->dcdc[id];
679 	config.driver_data = dcdc;
680 	config.regmap = wm831x->regmap;
681 
682 	dcdc->regulator = regulator_register(&dcdc->desc, &config);
683 	if (IS_ERR(dcdc->regulator)) {
684 		ret = PTR_ERR(dcdc->regulator);
685 		dev_err(wm831x->dev, "Failed to register DCDC%d: %d\n",
686 			id + 1, ret);
687 		goto err;
688 	}
689 
690 	irq = wm831x_irq(wm831x, platform_get_irq_byname(pdev, "UV"));
691 	ret = request_threaded_irq(irq, NULL, wm831x_dcdc_uv_irq,
692 				   IRQF_TRIGGER_RISING,	dcdc->name, dcdc);
693 	if (ret != 0) {
694 		dev_err(&pdev->dev, "Failed to request UV IRQ %d: %d\n",
695 			irq, ret);
696 		goto err_regulator;
697 	}
698 
699 	platform_set_drvdata(pdev, dcdc);
700 
701 	return 0;
702 
703 err_regulator:
704 	regulator_unregister(dcdc->regulator);
705 err:
706 	return ret;
707 }
708 
709 static int wm831x_buckp_remove(struct platform_device *pdev)
710 {
711 	struct wm831x_dcdc *dcdc = platform_get_drvdata(pdev);
712 
713 	free_irq(wm831x_irq(dcdc->wm831x, platform_get_irq_byname(pdev, "UV")),
714 			    dcdc);
715 	regulator_unregister(dcdc->regulator);
716 
717 	return 0;
718 }
719 
720 static struct platform_driver wm831x_buckp_driver = {
721 	.probe = wm831x_buckp_probe,
722 	.remove = wm831x_buckp_remove,
723 	.driver		= {
724 		.name	= "wm831x-buckp",
725 		.owner	= THIS_MODULE,
726 	},
727 };
728 
729 /*
730  * DCDC boost convertors
731  */
732 
733 static int wm831x_boostp_get_status(struct regulator_dev *rdev)
734 {
735 	struct wm831x_dcdc *dcdc = rdev_get_drvdata(rdev);
736 	struct wm831x *wm831x = dcdc->wm831x;
737 	int ret;
738 
739 	/* First, check for errors */
740 	ret = wm831x_reg_read(wm831x, WM831X_DCDC_UV_STATUS);
741 	if (ret < 0)
742 		return ret;
743 
744 	if (ret & (1 << rdev_get_id(rdev))) {
745 		dev_dbg(wm831x->dev, "DCDC%d under voltage\n",
746 			rdev_get_id(rdev) + 1);
747 		return REGULATOR_STATUS_ERROR;
748 	}
749 
750 	/* Is the regulator on? */
751 	ret = wm831x_reg_read(wm831x, WM831X_DCDC_STATUS);
752 	if (ret < 0)
753 		return ret;
754 	if (ret & (1 << rdev_get_id(rdev)))
755 		return REGULATOR_STATUS_ON;
756 	else
757 		return REGULATOR_STATUS_OFF;
758 }
759 
760 static struct regulator_ops wm831x_boostp_ops = {
761 	.get_status = wm831x_boostp_get_status,
762 
763 	.is_enabled = regulator_is_enabled_regmap,
764 	.enable = regulator_enable_regmap,
765 	.disable = regulator_disable_regmap,
766 };
767 
768 static int wm831x_boostp_probe(struct platform_device *pdev)
769 {
770 	struct wm831x *wm831x = dev_get_drvdata(pdev->dev.parent);
771 	struct wm831x_pdata *pdata = dev_get_platdata(wm831x->dev);
772 	struct regulator_config config = { };
773 	int id = pdev->id % ARRAY_SIZE(pdata->dcdc);
774 	struct wm831x_dcdc *dcdc;
775 	struct resource *res;
776 	int ret, irq;
777 
778 	dev_dbg(&pdev->dev, "Probing DCDC%d\n", id + 1);
779 
780 	if (pdata == NULL || pdata->dcdc[id] == NULL)
781 		return -ENODEV;
782 
783 	dcdc = devm_kzalloc(&pdev->dev, sizeof(struct wm831x_dcdc), GFP_KERNEL);
784 	if (dcdc == NULL) {
785 		dev_err(&pdev->dev, "Unable to allocate private data\n");
786 		return -ENOMEM;
787 	}
788 
789 	dcdc->wm831x = wm831x;
790 
791 	res = platform_get_resource(pdev, IORESOURCE_REG, 0);
792 	if (res == NULL) {
793 		dev_err(&pdev->dev, "No REG resource\n");
794 		ret = -EINVAL;
795 		goto err;
796 	}
797 	dcdc->base = res->start;
798 
799 	snprintf(dcdc->name, sizeof(dcdc->name), "DCDC%d", id + 1);
800 	dcdc->desc.name = dcdc->name;
801 	dcdc->desc.id = id;
802 	dcdc->desc.type = REGULATOR_VOLTAGE;
803 	dcdc->desc.ops = &wm831x_boostp_ops;
804 	dcdc->desc.owner = THIS_MODULE;
805 	dcdc->desc.enable_reg = WM831X_DCDC_ENABLE;
806 	dcdc->desc.enable_mask = 1 << id;
807 
808 	config.dev = pdev->dev.parent;
809 	if (pdata)
810 		config.init_data = pdata->dcdc[id];
811 	config.driver_data = dcdc;
812 	config.regmap = wm831x->regmap;
813 
814 	dcdc->regulator = regulator_register(&dcdc->desc, &config);
815 	if (IS_ERR(dcdc->regulator)) {
816 		ret = PTR_ERR(dcdc->regulator);
817 		dev_err(wm831x->dev, "Failed to register DCDC%d: %d\n",
818 			id + 1, ret);
819 		goto err;
820 	}
821 
822 	irq = wm831x_irq(wm831x, platform_get_irq_byname(pdev, "UV"));
823 	ret = request_threaded_irq(irq, NULL, wm831x_dcdc_uv_irq,
824 				   IRQF_TRIGGER_RISING, dcdc->name,
825 				   dcdc);
826 	if (ret != 0) {
827 		dev_err(&pdev->dev, "Failed to request UV IRQ %d: %d\n",
828 			irq, ret);
829 		goto err_regulator;
830 	}
831 
832 	platform_set_drvdata(pdev, dcdc);
833 
834 	return 0;
835 
836 err_regulator:
837 	regulator_unregister(dcdc->regulator);
838 err:
839 	return ret;
840 }
841 
842 static int wm831x_boostp_remove(struct platform_device *pdev)
843 {
844 	struct wm831x_dcdc *dcdc = platform_get_drvdata(pdev);
845 
846 	free_irq(wm831x_irq(dcdc->wm831x, platform_get_irq_byname(pdev, "UV")),
847 		 dcdc);
848 	regulator_unregister(dcdc->regulator);
849 
850 	return 0;
851 }
852 
853 static struct platform_driver wm831x_boostp_driver = {
854 	.probe = wm831x_boostp_probe,
855 	.remove = wm831x_boostp_remove,
856 	.driver		= {
857 		.name	= "wm831x-boostp",
858 		.owner	= THIS_MODULE,
859 	},
860 };
861 
862 /*
863  * External Power Enable
864  *
865  * These aren't actually DCDCs but look like them in hardware so share
866  * code.
867  */
868 
869 #define WM831X_EPE_BASE 6
870 
871 static struct regulator_ops wm831x_epe_ops = {
872 	.is_enabled = regulator_is_enabled_regmap,
873 	.enable = regulator_enable_regmap,
874 	.disable = regulator_disable_regmap,
875 	.get_status = wm831x_dcdc_get_status,
876 };
877 
878 static int wm831x_epe_probe(struct platform_device *pdev)
879 {
880 	struct wm831x *wm831x = dev_get_drvdata(pdev->dev.parent);
881 	struct wm831x_pdata *pdata = dev_get_platdata(wm831x->dev);
882 	struct regulator_config config = { };
883 	int id = pdev->id % ARRAY_SIZE(pdata->epe);
884 	struct wm831x_dcdc *dcdc;
885 	int ret;
886 
887 	dev_dbg(&pdev->dev, "Probing EPE%d\n", id + 1);
888 
889 	dcdc = devm_kzalloc(&pdev->dev, sizeof(struct wm831x_dcdc), GFP_KERNEL);
890 	if (dcdc == NULL) {
891 		dev_err(&pdev->dev, "Unable to allocate private data\n");
892 		return -ENOMEM;
893 	}
894 
895 	dcdc->wm831x = wm831x;
896 
897 	/* For current parts this is correct; probably need to revisit
898 	 * in future.
899 	 */
900 	snprintf(dcdc->name, sizeof(dcdc->name), "EPE%d", id + 1);
901 	dcdc->desc.name = dcdc->name;
902 	dcdc->desc.id = id + WM831X_EPE_BASE; /* Offset in DCDC registers */
903 	dcdc->desc.ops = &wm831x_epe_ops;
904 	dcdc->desc.type = REGULATOR_VOLTAGE;
905 	dcdc->desc.owner = THIS_MODULE;
906 	dcdc->desc.enable_reg = WM831X_DCDC_ENABLE;
907 	dcdc->desc.enable_mask = 1 << dcdc->desc.id;
908 
909 	config.dev = pdev->dev.parent;
910 	if (pdata)
911 		config.init_data = pdata->epe[id];
912 	config.driver_data = dcdc;
913 	config.regmap = wm831x->regmap;
914 
915 	dcdc->regulator = regulator_register(&dcdc->desc, &config);
916 	if (IS_ERR(dcdc->regulator)) {
917 		ret = PTR_ERR(dcdc->regulator);
918 		dev_err(wm831x->dev, "Failed to register EPE%d: %d\n",
919 			id + 1, ret);
920 		goto err;
921 	}
922 
923 	platform_set_drvdata(pdev, dcdc);
924 
925 	return 0;
926 
927 err:
928 	return ret;
929 }
930 
931 static int wm831x_epe_remove(struct platform_device *pdev)
932 {
933 	struct wm831x_dcdc *dcdc = platform_get_drvdata(pdev);
934 
935 	regulator_unregister(dcdc->regulator);
936 
937 	return 0;
938 }
939 
940 static struct platform_driver wm831x_epe_driver = {
941 	.probe = wm831x_epe_probe,
942 	.remove = wm831x_epe_remove,
943 	.driver		= {
944 		.name	= "wm831x-epe",
945 		.owner	= THIS_MODULE,
946 	},
947 };
948 
949 static int __init wm831x_dcdc_init(void)
950 {
951 	int ret;
952 	ret = platform_driver_register(&wm831x_buckv_driver);
953 	if (ret != 0)
954 		pr_err("Failed to register WM831x BUCKV driver: %d\n", ret);
955 
956 	ret = platform_driver_register(&wm831x_buckp_driver);
957 	if (ret != 0)
958 		pr_err("Failed to register WM831x BUCKP driver: %d\n", ret);
959 
960 	ret = platform_driver_register(&wm831x_boostp_driver);
961 	if (ret != 0)
962 		pr_err("Failed to register WM831x BOOST driver: %d\n", ret);
963 
964 	ret = platform_driver_register(&wm831x_epe_driver);
965 	if (ret != 0)
966 		pr_err("Failed to register WM831x EPE driver: %d\n", ret);
967 
968 	return 0;
969 }
970 subsys_initcall(wm831x_dcdc_init);
971 
972 static void __exit wm831x_dcdc_exit(void)
973 {
974 	platform_driver_unregister(&wm831x_epe_driver);
975 	platform_driver_unregister(&wm831x_boostp_driver);
976 	platform_driver_unregister(&wm831x_buckp_driver);
977 	platform_driver_unregister(&wm831x_buckv_driver);
978 }
979 module_exit(wm831x_dcdc_exit);
980 
981 /* Module information */
982 MODULE_AUTHOR("Mark Brown");
983 MODULE_DESCRIPTION("WM831x DC-DC convertor driver");
984 MODULE_LICENSE("GPL");
985 MODULE_ALIAS("platform:wm831x-buckv");
986 MODULE_ALIAS("platform:wm831x-buckp");
987 MODULE_ALIAS("platform:wm831x-boostp");
988 MODULE_ALIAS("platform:wm831x-epe");
989