xref: /linux/drivers/phy/cadence/phy-cadence-sierra.c (revision adc4bd6f6545bedc5547c76c2bf52257a8fffa97)
1 // SPDX-License-Identifier: GPL-2.0
2 /*
3  * Cadence Sierra PHY Driver
4  *
5  * Copyright (c) 2018 Cadence Design Systems
6  * Author: Alan Douglas <adouglas@cadence.com>
7  *
8  */
9 #include <linux/clk.h>
10 #include <linux/delay.h>
11 #include <linux/err.h>
12 #include <linux/io.h>
13 #include <linux/module.h>
14 #include <linux/phy/phy.h>
15 #include <linux/platform_device.h>
16 #include <linux/pm_runtime.h>
17 #include <linux/regmap.h>
18 #include <linux/reset.h>
19 #include <linux/slab.h>
20 #include <linux/of.h>
21 #include <linux/of_platform.h>
22 #include <dt-bindings/phy/phy.h>
23 
24 /* PHY register offsets */
25 #define SIERRA_COMMON_CDB_OFFSET			0x0
26 #define SIERRA_MACRO_ID_REG				0x0
27 #define SIERRA_CMN_PLLLC_MODE_PREG			0x48
28 #define SIERRA_CMN_PLLLC_LF_COEFF_MODE1_PREG		0x49
29 #define SIERRA_CMN_PLLLC_LF_COEFF_MODE0_PREG		0x4A
30 #define SIERRA_CMN_PLLLC_LOCK_CNTSTART_PREG		0x4B
31 #define SIERRA_CMN_PLLLC_BWCAL_MODE1_PREG		0x4F
32 #define SIERRA_CMN_PLLLC_BWCAL_MODE0_PREG		0x50
33 #define SIERRA_CMN_PLLLC_SS_TIME_STEPSIZE_MODE_PREG	0x62
34 
35 #define SIERRA_LANE_CDB_OFFSET(ln, block_offset, reg_offset)	\
36 				((0x4000 << (block_offset)) + \
37 				 (((ln) << 9) << (reg_offset)))
38 
39 #define SIERRA_DET_STANDEC_A_PREG			0x000
40 #define SIERRA_DET_STANDEC_B_PREG			0x001
41 #define SIERRA_DET_STANDEC_C_PREG			0x002
42 #define SIERRA_DET_STANDEC_D_PREG			0x003
43 #define SIERRA_DET_STANDEC_E_PREG			0x004
44 #define SIERRA_PSM_LANECAL_DLY_A1_RESETS_PREG		0x008
45 #define SIERRA_PSM_A0IN_TMR_PREG			0x009
46 #define SIERRA_PSM_DIAG_PREG				0x015
47 #define SIERRA_PSC_TX_A0_PREG				0x028
48 #define SIERRA_PSC_TX_A1_PREG				0x029
49 #define SIERRA_PSC_TX_A2_PREG				0x02A
50 #define SIERRA_PSC_TX_A3_PREG				0x02B
51 #define SIERRA_PSC_RX_A0_PREG				0x030
52 #define SIERRA_PSC_RX_A1_PREG				0x031
53 #define SIERRA_PSC_RX_A2_PREG				0x032
54 #define SIERRA_PSC_RX_A3_PREG				0x033
55 #define SIERRA_PLLCTRL_SUBRATE_PREG			0x03A
56 #define SIERRA_PLLCTRL_GEN_D_PREG			0x03E
57 #define SIERRA_PLLCTRL_CPGAIN_MODE_PREG			0x03F
58 #define SIERRA_PLLCTRL_STATUS_PREG			0x044
59 #define SIERRA_CLKPATH_BIASTRIM_PREG			0x04B
60 #define SIERRA_DFE_BIASTRIM_PREG			0x04C
61 #define SIERRA_DRVCTRL_ATTEN_PREG			0x06A
62 #define SIERRA_CLKPATHCTRL_TMR_PREG			0x081
63 #define SIERRA_RX_CREQ_FLTR_A_MODE3_PREG		0x085
64 #define SIERRA_RX_CREQ_FLTR_A_MODE2_PREG		0x086
65 #define SIERRA_RX_CREQ_FLTR_A_MODE1_PREG		0x087
66 #define SIERRA_RX_CREQ_FLTR_A_MODE0_PREG		0x088
67 #define SIERRA_CREQ_CCLKDET_MODE01_PREG			0x08E
68 #define SIERRA_RX_CTLE_MAINTENANCE_PREG			0x091
69 #define SIERRA_CREQ_FSMCLK_SEL_PREG			0x092
70 #define SIERRA_CREQ_EQ_CTRL_PREG			0x093
71 #define SIERRA_CREQ_SPARE_PREG				0x096
72 #define SIERRA_CREQ_EQ_OPEN_EYE_THRESH_PREG		0x097
73 #define SIERRA_CTLELUT_CTRL_PREG			0x098
74 #define SIERRA_DFE_ECMP_RATESEL_PREG			0x0C0
75 #define SIERRA_DFE_SMP_RATESEL_PREG			0x0C1
76 #define SIERRA_DEQ_PHALIGN_CTRL				0x0C4
77 #define SIERRA_DEQ_CONCUR_CTRL1_PREG			0x0C8
78 #define SIERRA_DEQ_CONCUR_CTRL2_PREG			0x0C9
79 #define SIERRA_DEQ_EPIPWR_CTRL2_PREG			0x0CD
80 #define SIERRA_DEQ_FAST_MAINT_CYCLES_PREG		0x0CE
81 #define SIERRA_DEQ_ERRCMP_CTRL_PREG			0x0D0
82 #define SIERRA_DEQ_OFFSET_CTRL_PREG			0x0D8
83 #define SIERRA_DEQ_GAIN_CTRL_PREG			0x0E0
84 #define SIERRA_DEQ_VGATUNE_CTRL_PREG			0x0E1
85 #define SIERRA_DEQ_GLUT0				0x0E8
86 #define SIERRA_DEQ_GLUT1				0x0E9
87 #define SIERRA_DEQ_GLUT2				0x0EA
88 #define SIERRA_DEQ_GLUT3				0x0EB
89 #define SIERRA_DEQ_GLUT4				0x0EC
90 #define SIERRA_DEQ_GLUT5				0x0ED
91 #define SIERRA_DEQ_GLUT6				0x0EE
92 #define SIERRA_DEQ_GLUT7				0x0EF
93 #define SIERRA_DEQ_GLUT8				0x0F0
94 #define SIERRA_DEQ_GLUT9				0x0F1
95 #define SIERRA_DEQ_GLUT10				0x0F2
96 #define SIERRA_DEQ_GLUT11				0x0F3
97 #define SIERRA_DEQ_GLUT12				0x0F4
98 #define SIERRA_DEQ_GLUT13				0x0F5
99 #define SIERRA_DEQ_GLUT14				0x0F6
100 #define SIERRA_DEQ_GLUT15				0x0F7
101 #define SIERRA_DEQ_GLUT16				0x0F8
102 #define SIERRA_DEQ_ALUT0				0x108
103 #define SIERRA_DEQ_ALUT1				0x109
104 #define SIERRA_DEQ_ALUT2				0x10A
105 #define SIERRA_DEQ_ALUT3				0x10B
106 #define SIERRA_DEQ_ALUT4				0x10C
107 #define SIERRA_DEQ_ALUT5				0x10D
108 #define SIERRA_DEQ_ALUT6				0x10E
109 #define SIERRA_DEQ_ALUT7				0x10F
110 #define SIERRA_DEQ_ALUT8				0x110
111 #define SIERRA_DEQ_ALUT9				0x111
112 #define SIERRA_DEQ_ALUT10				0x112
113 #define SIERRA_DEQ_ALUT11				0x113
114 #define SIERRA_DEQ_ALUT12				0x114
115 #define SIERRA_DEQ_ALUT13				0x115
116 #define SIERRA_DEQ_DFETAP_CTRL_PREG			0x128
117 #define SIERRA_DFE_EN_1010_IGNORE_PREG			0x134
118 #define SIERRA_DEQ_TAU_CTRL1_SLOW_MAINT_PREG		0x150
119 #define SIERRA_DEQ_TAU_CTRL2_PREG			0x151
120 #define SIERRA_DEQ_PICTRL_PREG				0x161
121 #define SIERRA_CPICAL_TMRVAL_MODE1_PREG			0x170
122 #define SIERRA_CPICAL_TMRVAL_MODE0_PREG			0x171
123 #define SIERRA_CPICAL_PICNT_MODE1_PREG			0x174
124 #define SIERRA_CPI_OUTBUF_RATESEL_PREG			0x17C
125 #define SIERRA_CPICAL_RES_STARTCODE_MODE23_PREG		0x183
126 #define SIERRA_LFPSDET_SUPPORT_PREG			0x188
127 #define SIERRA_LFPSFILT_NS_PREG				0x18A
128 #define SIERRA_LFPSFILT_RD_PREG				0x18B
129 #define SIERRA_LFPSFILT_MP_PREG				0x18C
130 #define SIERRA_SIGDET_SUPPORT_PREG			0x190
131 #define SIERRA_SDFILT_H2L_A_PREG			0x191
132 #define SIERRA_SDFILT_L2H_PREG				0x193
133 #define SIERRA_RXBUFFER_CTLECTRL_PREG			0x19E
134 #define SIERRA_RXBUFFER_RCDFECTRL_PREG			0x19F
135 #define SIERRA_RXBUFFER_DFECTRL_PREG			0x1A0
136 #define SIERRA_DEQ_TAU_CTRL1_FAST_MAINT_PREG		0x14F
137 #define SIERRA_DEQ_TAU_CTRL1_SLOW_MAINT_PREG		0x150
138 
139 #define SIERRA_PHY_CONFIG_CTRL_OFFSET(block_offset)	\
140 				      (0xc000 << (block_offset))
141 #define SIERRA_PHY_PLL_CFG				0xe
142 
143 #define SIERRA_MACRO_ID					0x00007364
144 #define SIERRA_MAX_LANES				4
145 #define PLL_LOCK_TIME					100000
146 
147 static const struct reg_field macro_id_type =
148 				REG_FIELD(SIERRA_MACRO_ID_REG, 0, 15);
149 static const struct reg_field phy_pll_cfg_1 =
150 				REG_FIELD(SIERRA_PHY_PLL_CFG, 1, 1);
151 static const struct reg_field pllctrl_lock =
152 				REG_FIELD(SIERRA_PLLCTRL_STATUS_PREG, 0, 0);
153 
154 struct cdns_sierra_inst {
155 	struct phy *phy;
156 	u32 phy_type;
157 	u32 num_lanes;
158 	u32 mlane;
159 	struct reset_control *lnk_rst;
160 };
161 
162 struct cdns_reg_pairs {
163 	u16 val;
164 	u32 off;
165 };
166 
167 struct cdns_sierra_data {
168 		u32 id_value;
169 		u8 block_offset_shift;
170 		u8 reg_offset_shift;
171 		u32 pcie_cmn_regs;
172 		u32 pcie_ln_regs;
173 		u32 usb_cmn_regs;
174 		u32 usb_ln_regs;
175 		struct cdns_reg_pairs *pcie_cmn_vals;
176 		struct cdns_reg_pairs *pcie_ln_vals;
177 		struct cdns_reg_pairs *usb_cmn_vals;
178 		struct cdns_reg_pairs *usb_ln_vals;
179 };
180 
181 struct cdns_regmap_cdb_context {
182 	struct device *dev;
183 	void __iomem *base;
184 	u8 reg_offset_shift;
185 };
186 
187 struct cdns_sierra_phy {
188 	struct device *dev;
189 	struct regmap *regmap;
190 	struct cdns_sierra_data *init_data;
191 	struct cdns_sierra_inst phys[SIERRA_MAX_LANES];
192 	struct reset_control *phy_rst;
193 	struct reset_control *apb_rst;
194 	struct regmap *regmap_lane_cdb[SIERRA_MAX_LANES];
195 	struct regmap *regmap_phy_config_ctrl;
196 	struct regmap *regmap_common_cdb;
197 	struct regmap_field *macro_id_type;
198 	struct regmap_field *phy_pll_cfg_1;
199 	struct regmap_field *pllctrl_lock[SIERRA_MAX_LANES];
200 	struct clk *clk;
201 	int nsubnodes;
202 	bool autoconf;
203 };
204 
205 static int cdns_regmap_write(void *context, unsigned int reg, unsigned int val)
206 {
207 	struct cdns_regmap_cdb_context *ctx = context;
208 	u32 offset = reg << ctx->reg_offset_shift;
209 
210 	writew(val, ctx->base + offset);
211 
212 	return 0;
213 }
214 
215 static int cdns_regmap_read(void *context, unsigned int reg, unsigned int *val)
216 {
217 	struct cdns_regmap_cdb_context *ctx = context;
218 	u32 offset = reg << ctx->reg_offset_shift;
219 
220 	*val = readw(ctx->base + offset);
221 	return 0;
222 }
223 
224 #define SIERRA_LANE_CDB_REGMAP_CONF(n) \
225 { \
226 	.name = "sierra_lane" n "_cdb", \
227 	.reg_stride = 1, \
228 	.fast_io = true, \
229 	.reg_write = cdns_regmap_write, \
230 	.reg_read = cdns_regmap_read, \
231 }
232 
233 static struct regmap_config cdns_sierra_lane_cdb_config[] = {
234 	SIERRA_LANE_CDB_REGMAP_CONF("0"),
235 	SIERRA_LANE_CDB_REGMAP_CONF("1"),
236 	SIERRA_LANE_CDB_REGMAP_CONF("2"),
237 	SIERRA_LANE_CDB_REGMAP_CONF("3"),
238 };
239 
240 static struct regmap_config cdns_sierra_common_cdb_config = {
241 	.name = "sierra_common_cdb",
242 	.reg_stride = 1,
243 	.fast_io = true,
244 	.reg_write = cdns_regmap_write,
245 	.reg_read = cdns_regmap_read,
246 };
247 
248 static struct regmap_config cdns_sierra_phy_config_ctrl_config = {
249 	.name = "sierra_phy_config_ctrl",
250 	.reg_stride = 1,
251 	.fast_io = true,
252 	.reg_write = cdns_regmap_write,
253 	.reg_read = cdns_regmap_read,
254 };
255 
256 static int cdns_sierra_phy_init(struct phy *gphy)
257 {
258 	struct cdns_sierra_inst *ins = phy_get_drvdata(gphy);
259 	struct cdns_sierra_phy *phy = dev_get_drvdata(gphy->dev.parent);
260 	struct regmap *regmap = phy->regmap;
261 	int i, j;
262 	struct cdns_reg_pairs *cmn_vals, *ln_vals;
263 	u32 num_cmn_regs, num_ln_regs;
264 
265 	/* Initialise the PHY registers, unless auto configured */
266 	if (phy->autoconf)
267 		return 0;
268 
269 	if (ins->phy_type == PHY_TYPE_PCIE) {
270 		num_cmn_regs = phy->init_data->pcie_cmn_regs;
271 		num_ln_regs = phy->init_data->pcie_ln_regs;
272 		cmn_vals = phy->init_data->pcie_cmn_vals;
273 		ln_vals = phy->init_data->pcie_ln_vals;
274 	} else if (ins->phy_type == PHY_TYPE_USB3) {
275 		num_cmn_regs = phy->init_data->usb_cmn_regs;
276 		num_ln_regs = phy->init_data->usb_ln_regs;
277 		cmn_vals = phy->init_data->usb_cmn_vals;
278 		ln_vals = phy->init_data->usb_ln_vals;
279 	} else {
280 		return -EINVAL;
281 	}
282 
283 	regmap = phy->regmap_common_cdb;
284 	for (j = 0; j < num_cmn_regs ; j++)
285 		regmap_write(regmap, cmn_vals[j].off, cmn_vals[j].val);
286 
287 	for (i = 0; i < ins->num_lanes; i++) {
288 		for (j = 0; j < num_ln_regs ; j++) {
289 			regmap = phy->regmap_lane_cdb[i + ins->mlane];
290 			regmap_write(regmap, ln_vals[j].off, ln_vals[j].val);
291 		}
292 	}
293 
294 	return 0;
295 }
296 
297 static int cdns_sierra_phy_on(struct phy *gphy)
298 {
299 	struct cdns_sierra_phy *sp = dev_get_drvdata(gphy->dev.parent);
300 	struct cdns_sierra_inst *ins = phy_get_drvdata(gphy);
301 	struct device *dev = sp->dev;
302 	u32 val;
303 	int ret;
304 
305 	/* Take the PHY lane group out of reset */
306 	ret = reset_control_deassert(ins->lnk_rst);
307 	if (ret) {
308 		dev_err(dev, "Failed to take the PHY lane out of reset\n");
309 		return ret;
310 	}
311 
312 	ret = regmap_field_read_poll_timeout(sp->pllctrl_lock[ins->mlane],
313 					     val, val, 1000, PLL_LOCK_TIME);
314 	if (ret < 0)
315 		dev_err(dev, "PLL lock of lane failed\n");
316 
317 	return ret;
318 }
319 
320 static int cdns_sierra_phy_off(struct phy *gphy)
321 {
322 	struct cdns_sierra_inst *ins = phy_get_drvdata(gphy);
323 
324 	return reset_control_assert(ins->lnk_rst);
325 }
326 
327 static const struct phy_ops ops = {
328 	.init		= cdns_sierra_phy_init,
329 	.power_on	= cdns_sierra_phy_on,
330 	.power_off	= cdns_sierra_phy_off,
331 	.owner		= THIS_MODULE,
332 };
333 
334 static int cdns_sierra_get_optional(struct cdns_sierra_inst *inst,
335 				    struct device_node *child)
336 {
337 	if (of_property_read_u32(child, "reg", &inst->mlane))
338 		return -EINVAL;
339 
340 	if (of_property_read_u32(child, "cdns,num-lanes", &inst->num_lanes))
341 		return -EINVAL;
342 
343 	if (of_property_read_u32(child, "cdns,phy-type", &inst->phy_type))
344 		return -EINVAL;
345 
346 	return 0;
347 }
348 
349 static const struct of_device_id cdns_sierra_id_table[];
350 
351 static struct regmap *cdns_regmap_init(struct device *dev, void __iomem *base,
352 				       u32 block_offset, u8 reg_offset_shift,
353 				       const struct regmap_config *config)
354 {
355 	struct cdns_regmap_cdb_context *ctx;
356 
357 	ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
358 	if (!ctx)
359 		return ERR_PTR(-ENOMEM);
360 
361 	ctx->dev = dev;
362 	ctx->base = base + block_offset;
363 	ctx->reg_offset_shift = reg_offset_shift;
364 
365 	return devm_regmap_init(dev, NULL, ctx, config);
366 }
367 
368 static int cdns_regfield_init(struct cdns_sierra_phy *sp)
369 {
370 	struct device *dev = sp->dev;
371 	struct regmap_field *field;
372 	struct regmap *regmap;
373 	int i;
374 
375 	regmap = sp->regmap_common_cdb;
376 	field = devm_regmap_field_alloc(dev, regmap, macro_id_type);
377 	if (IS_ERR(field)) {
378 		dev_err(dev, "MACRO_ID_TYPE reg field init failed\n");
379 		return PTR_ERR(field);
380 	}
381 	sp->macro_id_type = field;
382 
383 	regmap = sp->regmap_phy_config_ctrl;
384 	field = devm_regmap_field_alloc(dev, regmap, phy_pll_cfg_1);
385 	if (IS_ERR(field)) {
386 		dev_err(dev, "PHY_PLL_CFG_1 reg field init failed\n");
387 		return PTR_ERR(field);
388 	}
389 	sp->phy_pll_cfg_1 = field;
390 
391 	for (i = 0; i < SIERRA_MAX_LANES; i++) {
392 		regmap = sp->regmap_lane_cdb[i];
393 		field = devm_regmap_field_alloc(dev, regmap, pllctrl_lock);
394 		if (IS_ERR(field)) {
395 			dev_err(dev, "P%d_ENABLE reg field init failed\n", i);
396 			return PTR_ERR(field);
397 		}
398 		sp->pllctrl_lock[i] =  field;
399 	}
400 
401 	return 0;
402 }
403 
404 static int cdns_regmap_init_blocks(struct cdns_sierra_phy *sp,
405 				   void __iomem *base, u8 block_offset_shift,
406 				   u8 reg_offset_shift)
407 {
408 	struct device *dev = sp->dev;
409 	struct regmap *regmap;
410 	u32 block_offset;
411 	int i;
412 
413 	for (i = 0; i < SIERRA_MAX_LANES; i++) {
414 		block_offset = SIERRA_LANE_CDB_OFFSET(i, block_offset_shift,
415 						      reg_offset_shift);
416 		regmap = cdns_regmap_init(dev, base, block_offset,
417 					  reg_offset_shift,
418 					  &cdns_sierra_lane_cdb_config[i]);
419 		if (IS_ERR(regmap)) {
420 			dev_err(dev, "Failed to init lane CDB regmap\n");
421 			return PTR_ERR(regmap);
422 		}
423 		sp->regmap_lane_cdb[i] = regmap;
424 	}
425 
426 	regmap = cdns_regmap_init(dev, base, SIERRA_COMMON_CDB_OFFSET,
427 				  reg_offset_shift,
428 				  &cdns_sierra_common_cdb_config);
429 	if (IS_ERR(regmap)) {
430 		dev_err(dev, "Failed to init common CDB regmap\n");
431 		return PTR_ERR(regmap);
432 	}
433 	sp->regmap_common_cdb = regmap;
434 
435 	block_offset = SIERRA_PHY_CONFIG_CTRL_OFFSET(block_offset_shift);
436 	regmap = cdns_regmap_init(dev, base, block_offset, reg_offset_shift,
437 				  &cdns_sierra_phy_config_ctrl_config);
438 	if (IS_ERR(regmap)) {
439 		dev_err(dev, "Failed to init PHY config and control regmap\n");
440 		return PTR_ERR(regmap);
441 	}
442 	sp->regmap_phy_config_ctrl = regmap;
443 
444 	return 0;
445 }
446 
447 static int cdns_sierra_phy_probe(struct platform_device *pdev)
448 {
449 	struct cdns_sierra_phy *sp;
450 	struct phy_provider *phy_provider;
451 	struct device *dev = &pdev->dev;
452 	const struct of_device_id *match;
453 	struct cdns_sierra_data *data;
454 	unsigned int id_value;
455 	struct resource *res;
456 	int i, ret, node = 0;
457 	void __iomem *base;
458 	struct device_node *dn = dev->of_node, *child;
459 
460 	if (of_get_child_count(dn) == 0)
461 		return -ENODEV;
462 
463 	/* Get init data for this PHY */
464 	match = of_match_device(cdns_sierra_id_table, dev);
465 	if (!match)
466 		return -EINVAL;
467 
468 	data = (struct cdns_sierra_data *)match->data;
469 
470 	sp = devm_kzalloc(dev, sizeof(*sp), GFP_KERNEL);
471 	if (!sp)
472 		return -ENOMEM;
473 	dev_set_drvdata(dev, sp);
474 	sp->dev = dev;
475 	sp->init_data = data;
476 
477 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
478 	base = devm_ioremap_resource(dev, res);
479 	if (IS_ERR(base)) {
480 		dev_err(dev, "missing \"reg\"\n");
481 		return PTR_ERR(base);
482 	}
483 
484 	ret = cdns_regmap_init_blocks(sp, base, data->block_offset_shift,
485 				      data->reg_offset_shift);
486 	if (ret)
487 		return ret;
488 
489 	ret = cdns_regfield_init(sp);
490 	if (ret)
491 		return ret;
492 
493 	platform_set_drvdata(pdev, sp);
494 
495 	sp->clk = devm_clk_get_optional(dev, "phy_clk");
496 	if (IS_ERR(sp->clk)) {
497 		dev_err(dev, "failed to get clock phy_clk\n");
498 		return PTR_ERR(sp->clk);
499 	}
500 
501 	sp->phy_rst = devm_reset_control_get(dev, "sierra_reset");
502 	if (IS_ERR(sp->phy_rst)) {
503 		dev_err(dev, "failed to get reset\n");
504 		return PTR_ERR(sp->phy_rst);
505 	}
506 
507 	sp->apb_rst = devm_reset_control_get_optional(dev, "sierra_apb");
508 	if (IS_ERR(sp->apb_rst)) {
509 		dev_err(dev, "failed to get apb reset\n");
510 		return PTR_ERR(sp->apb_rst);
511 	}
512 
513 	ret = clk_prepare_enable(sp->clk);
514 	if (ret)
515 		return ret;
516 
517 	/* Enable APB */
518 	reset_control_deassert(sp->apb_rst);
519 
520 	/* Check that PHY is present */
521 	regmap_field_read(sp->macro_id_type, &id_value);
522 	if  (sp->init_data->id_value != id_value) {
523 		ret = -EINVAL;
524 		goto clk_disable;
525 	}
526 
527 	sp->autoconf = of_property_read_bool(dn, "cdns,autoconf");
528 
529 	for_each_available_child_of_node(dn, child) {
530 		struct phy *gphy;
531 
532 		sp->phys[node].lnk_rst =
533 			of_reset_control_array_get_exclusive(child);
534 
535 		if (IS_ERR(sp->phys[node].lnk_rst)) {
536 			dev_err(dev, "failed to get reset %s\n",
537 				child->full_name);
538 			ret = PTR_ERR(sp->phys[node].lnk_rst);
539 			goto put_child2;
540 		}
541 
542 		if (!sp->autoconf) {
543 			ret = cdns_sierra_get_optional(&sp->phys[node], child);
544 			if (ret) {
545 				dev_err(dev, "missing property in node %s\n",
546 					child->name);
547 				goto put_child;
548 			}
549 		}
550 
551 		gphy = devm_phy_create(dev, child, &ops);
552 
553 		if (IS_ERR(gphy)) {
554 			ret = PTR_ERR(gphy);
555 			goto put_child;
556 		}
557 		sp->phys[node].phy = gphy;
558 		phy_set_drvdata(gphy, &sp->phys[node]);
559 
560 		node++;
561 	}
562 	sp->nsubnodes = node;
563 
564 	/* If more than one subnode, configure the PHY as multilink */
565 	if (!sp->autoconf && sp->nsubnodes > 1)
566 		regmap_field_write(sp->phy_pll_cfg_1, 0x1);
567 
568 	pm_runtime_enable(dev);
569 	phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
570 	reset_control_deassert(sp->phy_rst);
571 	return PTR_ERR_OR_ZERO(phy_provider);
572 
573 put_child:
574 	node++;
575 put_child2:
576 	for (i = 0; i < node; i++)
577 		reset_control_put(sp->phys[i].lnk_rst);
578 	of_node_put(child);
579 clk_disable:
580 	clk_disable_unprepare(sp->clk);
581 	reset_control_assert(sp->apb_rst);
582 	return ret;
583 }
584 
585 static int cdns_sierra_phy_remove(struct platform_device *pdev)
586 {
587 	struct cdns_sierra_phy *phy = dev_get_drvdata(pdev->dev.parent);
588 	int i;
589 
590 	reset_control_assert(phy->phy_rst);
591 	reset_control_assert(phy->apb_rst);
592 	pm_runtime_disable(&pdev->dev);
593 
594 	/*
595 	 * The device level resets will be put automatically.
596 	 * Need to put the subnode resets here though.
597 	 */
598 	for (i = 0; i < phy->nsubnodes; i++) {
599 		reset_control_assert(phy->phys[i].lnk_rst);
600 		reset_control_put(phy->phys[i].lnk_rst);
601 	}
602 	return 0;
603 }
604 
605 /* refclk100MHz_32b_PCIe_cmn_pll_ext_ssc */
606 static struct cdns_reg_pairs cdns_pcie_cmn_regs_ext_ssc[] = {
607 	{0x2106, SIERRA_CMN_PLLLC_LF_COEFF_MODE1_PREG},
608 	{0x2106, SIERRA_CMN_PLLLC_LF_COEFF_MODE0_PREG},
609 	{0x8A06, SIERRA_CMN_PLLLC_BWCAL_MODE1_PREG},
610 	{0x8A06, SIERRA_CMN_PLLLC_BWCAL_MODE0_PREG},
611 	{0x1B1B, SIERRA_CMN_PLLLC_SS_TIME_STEPSIZE_MODE_PREG}
612 };
613 
614 /* refclk100MHz_32b_PCIe_ln_ext_ssc */
615 static struct cdns_reg_pairs cdns_pcie_ln_regs_ext_ssc[] = {
616 	{0x813E, SIERRA_CLKPATHCTRL_TMR_PREG},
617 	{0x8047, SIERRA_RX_CREQ_FLTR_A_MODE3_PREG},
618 	{0x808F, SIERRA_RX_CREQ_FLTR_A_MODE2_PREG},
619 	{0x808F, SIERRA_RX_CREQ_FLTR_A_MODE1_PREG},
620 	{0x808F, SIERRA_RX_CREQ_FLTR_A_MODE0_PREG},
621 	{0x033C, SIERRA_RX_CTLE_MAINTENANCE_PREG},
622 	{0x44CC, SIERRA_CREQ_EQ_OPEN_EYE_THRESH_PREG}
623 };
624 
625 /* refclk100MHz_20b_USB_cmn_pll_ext_ssc */
626 static struct cdns_reg_pairs cdns_usb_cmn_regs_ext_ssc[] = {
627 	{0x2085, SIERRA_CMN_PLLLC_LF_COEFF_MODE1_PREG},
628 	{0x2085, SIERRA_CMN_PLLLC_LF_COEFF_MODE0_PREG},
629 	{0x0000, SIERRA_CMN_PLLLC_BWCAL_MODE0_PREG},
630 	{0x0000, SIERRA_CMN_PLLLC_SS_TIME_STEPSIZE_MODE_PREG}
631 };
632 
633 /* refclk100MHz_20b_USB_ln_ext_ssc */
634 static struct cdns_reg_pairs cdns_usb_ln_regs_ext_ssc[] = {
635 	{0xFE0A, SIERRA_DET_STANDEC_A_PREG},
636 	{0x000F, SIERRA_DET_STANDEC_B_PREG},
637 	{0x00A5, SIERRA_DET_STANDEC_C_PREG},
638 	{0x69ad, SIERRA_DET_STANDEC_D_PREG},
639 	{0x0241, SIERRA_DET_STANDEC_E_PREG},
640 	{0x0010, SIERRA_PSM_LANECAL_DLY_A1_RESETS_PREG},
641 	{0x0014, SIERRA_PSM_A0IN_TMR_PREG},
642 	{0xCF00, SIERRA_PSM_DIAG_PREG},
643 	{0x001F, SIERRA_PSC_TX_A0_PREG},
644 	{0x0007, SIERRA_PSC_TX_A1_PREG},
645 	{0x0003, SIERRA_PSC_TX_A2_PREG},
646 	{0x0003, SIERRA_PSC_TX_A3_PREG},
647 	{0x0FFF, SIERRA_PSC_RX_A0_PREG},
648 	{0x0619, SIERRA_PSC_RX_A1_PREG},
649 	{0x0003, SIERRA_PSC_RX_A2_PREG},
650 	{0x0001, SIERRA_PSC_RX_A3_PREG},
651 	{0x0001, SIERRA_PLLCTRL_SUBRATE_PREG},
652 	{0x0406, SIERRA_PLLCTRL_GEN_D_PREG},
653 	{0x5233, SIERRA_PLLCTRL_CPGAIN_MODE_PREG},
654 	{0x00CA, SIERRA_CLKPATH_BIASTRIM_PREG},
655 	{0x2512, SIERRA_DFE_BIASTRIM_PREG},
656 	{0x0000, SIERRA_DRVCTRL_ATTEN_PREG},
657 	{0x873E, SIERRA_CLKPATHCTRL_TMR_PREG},
658 	{0x03CF, SIERRA_RX_CREQ_FLTR_A_MODE1_PREG},
659 	{0x01CE, SIERRA_RX_CREQ_FLTR_A_MODE0_PREG},
660 	{0x7B3C, SIERRA_CREQ_CCLKDET_MODE01_PREG},
661 	{0x033F, SIERRA_RX_CTLE_MAINTENANCE_PREG},
662 	{0x3232, SIERRA_CREQ_FSMCLK_SEL_PREG},
663 	{0x0000, SIERRA_CREQ_EQ_CTRL_PREG},
664 	{0x8000, SIERRA_CREQ_SPARE_PREG},
665 	{0xCC44, SIERRA_CREQ_EQ_OPEN_EYE_THRESH_PREG},
666 	{0x8453, SIERRA_CTLELUT_CTRL_PREG},
667 	{0x4110, SIERRA_DFE_ECMP_RATESEL_PREG},
668 	{0x4110, SIERRA_DFE_SMP_RATESEL_PREG},
669 	{0x0002, SIERRA_DEQ_PHALIGN_CTRL},
670 	{0x3200, SIERRA_DEQ_CONCUR_CTRL1_PREG},
671 	{0x5064, SIERRA_DEQ_CONCUR_CTRL2_PREG},
672 	{0x0030, SIERRA_DEQ_EPIPWR_CTRL2_PREG},
673 	{0x0048, SIERRA_DEQ_FAST_MAINT_CYCLES_PREG},
674 	{0x5A5A, SIERRA_DEQ_ERRCMP_CTRL_PREG},
675 	{0x02F5, SIERRA_DEQ_OFFSET_CTRL_PREG},
676 	{0x02F5, SIERRA_DEQ_GAIN_CTRL_PREG},
677 	{0x9A8A, SIERRA_DEQ_VGATUNE_CTRL_PREG},
678 	{0x0014, SIERRA_DEQ_GLUT0},
679 	{0x0014, SIERRA_DEQ_GLUT1},
680 	{0x0014, SIERRA_DEQ_GLUT2},
681 	{0x0014, SIERRA_DEQ_GLUT3},
682 	{0x0014, SIERRA_DEQ_GLUT4},
683 	{0x0014, SIERRA_DEQ_GLUT5},
684 	{0x0014, SIERRA_DEQ_GLUT6},
685 	{0x0014, SIERRA_DEQ_GLUT7},
686 	{0x0014, SIERRA_DEQ_GLUT8},
687 	{0x0014, SIERRA_DEQ_GLUT9},
688 	{0x0014, SIERRA_DEQ_GLUT10},
689 	{0x0014, SIERRA_DEQ_GLUT11},
690 	{0x0014, SIERRA_DEQ_GLUT12},
691 	{0x0014, SIERRA_DEQ_GLUT13},
692 	{0x0014, SIERRA_DEQ_GLUT14},
693 	{0x0014, SIERRA_DEQ_GLUT15},
694 	{0x0014, SIERRA_DEQ_GLUT16},
695 	{0x0BAE, SIERRA_DEQ_ALUT0},
696 	{0x0AEB, SIERRA_DEQ_ALUT1},
697 	{0x0A28, SIERRA_DEQ_ALUT2},
698 	{0x0965, SIERRA_DEQ_ALUT3},
699 	{0x08A2, SIERRA_DEQ_ALUT4},
700 	{0x07DF, SIERRA_DEQ_ALUT5},
701 	{0x071C, SIERRA_DEQ_ALUT6},
702 	{0x0659, SIERRA_DEQ_ALUT7},
703 	{0x0596, SIERRA_DEQ_ALUT8},
704 	{0x0514, SIERRA_DEQ_ALUT9},
705 	{0x0492, SIERRA_DEQ_ALUT10},
706 	{0x0410, SIERRA_DEQ_ALUT11},
707 	{0x038E, SIERRA_DEQ_ALUT12},
708 	{0x030C, SIERRA_DEQ_ALUT13},
709 	{0x03F4, SIERRA_DEQ_DFETAP_CTRL_PREG},
710 	{0x0001, SIERRA_DFE_EN_1010_IGNORE_PREG},
711 	{0x3C01, SIERRA_DEQ_TAU_CTRL1_FAST_MAINT_PREG},
712 	{0x3C40, SIERRA_DEQ_TAU_CTRL1_SLOW_MAINT_PREG},
713 	{0x1C08, SIERRA_DEQ_TAU_CTRL2_PREG},
714 	{0x0033, SIERRA_DEQ_PICTRL_PREG},
715 	{0x0400, SIERRA_CPICAL_TMRVAL_MODE1_PREG},
716 	{0x0330, SIERRA_CPICAL_TMRVAL_MODE0_PREG},
717 	{0x01FF, SIERRA_CPICAL_PICNT_MODE1_PREG},
718 	{0x0009, SIERRA_CPI_OUTBUF_RATESEL_PREG},
719 	{0x3232, SIERRA_CPICAL_RES_STARTCODE_MODE23_PREG},
720 	{0x0005, SIERRA_LFPSDET_SUPPORT_PREG},
721 	{0x000F, SIERRA_LFPSFILT_NS_PREG},
722 	{0x0009, SIERRA_LFPSFILT_RD_PREG},
723 	{0x0001, SIERRA_LFPSFILT_MP_PREG},
724 	{0x8013, SIERRA_SDFILT_H2L_A_PREG},
725 	{0x8009, SIERRA_SDFILT_L2H_PREG},
726 	{0x0024, SIERRA_RXBUFFER_CTLECTRL_PREG},
727 	{0x0020, SIERRA_RXBUFFER_RCDFECTRL_PREG},
728 	{0x4243, SIERRA_RXBUFFER_DFECTRL_PREG}
729 };
730 
731 static const struct cdns_sierra_data cdns_map_sierra = {
732 	SIERRA_MACRO_ID,
733 	0x2,
734 	0x2,
735 	ARRAY_SIZE(cdns_pcie_cmn_regs_ext_ssc),
736 	ARRAY_SIZE(cdns_pcie_ln_regs_ext_ssc),
737 	ARRAY_SIZE(cdns_usb_cmn_regs_ext_ssc),
738 	ARRAY_SIZE(cdns_usb_ln_regs_ext_ssc),
739 	cdns_pcie_cmn_regs_ext_ssc,
740 	cdns_pcie_ln_regs_ext_ssc,
741 	cdns_usb_cmn_regs_ext_ssc,
742 	cdns_usb_ln_regs_ext_ssc,
743 };
744 
745 static const struct cdns_sierra_data cdns_ti_map_sierra = {
746 	SIERRA_MACRO_ID,
747 	0x0,
748 	0x1,
749 	ARRAY_SIZE(cdns_pcie_cmn_regs_ext_ssc),
750 	ARRAY_SIZE(cdns_pcie_ln_regs_ext_ssc),
751 	ARRAY_SIZE(cdns_usb_cmn_regs_ext_ssc),
752 	ARRAY_SIZE(cdns_usb_ln_regs_ext_ssc),
753 	cdns_pcie_cmn_regs_ext_ssc,
754 	cdns_pcie_ln_regs_ext_ssc,
755 	cdns_usb_cmn_regs_ext_ssc,
756 	cdns_usb_ln_regs_ext_ssc,
757 };
758 
759 static const struct of_device_id cdns_sierra_id_table[] = {
760 	{
761 		.compatible = "cdns,sierra-phy-t0",
762 		.data = &cdns_map_sierra,
763 	},
764 	{
765 		.compatible = "ti,sierra-phy-t0",
766 		.data = &cdns_ti_map_sierra,
767 	},
768 	{}
769 };
770 MODULE_DEVICE_TABLE(of, cdns_sierra_id_table);
771 
772 static struct platform_driver cdns_sierra_driver = {
773 	.probe		= cdns_sierra_phy_probe,
774 	.remove		= cdns_sierra_phy_remove,
775 	.driver		= {
776 		.name	= "cdns-sierra-phy",
777 		.of_match_table = cdns_sierra_id_table,
778 	},
779 };
780 module_platform_driver(cdns_sierra_driver);
781 
782 MODULE_ALIAS("platform:cdns_sierra");
783 MODULE_AUTHOR("Cadence Design Systems");
784 MODULE_DESCRIPTION("CDNS sierra phy driver");
785 MODULE_LICENSE("GPL v2");
786