xref: /linux/drivers/net/wireless/intel/iwlwifi/mvm/power.c (revision bca5cfbb694d66a1c482d0c347eee80f6afbc870)
1 // SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
2 /*
3  * Copyright (C) 2012-2014, 2018-2019, 2021-2025 Intel Corporation
4  * Copyright (C) 2013-2014 Intel Mobile Communications GmbH
5  * Copyright (C) 2015-2017 Intel Deutschland GmbH
6  */
7 #include <linux/kernel.h>
8 #include <linux/module.h>
9 #include <linux/slab.h>
10 #include <linux/etherdevice.h>
11 
12 #include <net/mac80211.h>
13 
14 #include "iwl-debug.h"
15 #include "mvm.h"
16 #include "iwl-modparams.h"
17 #include "fw/api/power.h"
18 
19 #define POWER_KEEP_ALIVE_PERIOD_SEC    25
20 
21 static
22 int iwl_mvm_beacon_filter_send_cmd(struct iwl_mvm *mvm,
23 				   struct iwl_beacon_filter_cmd *cmd)
24 {
25 	u16 len;
26 
27 	IWL_DEBUG_POWER(mvm, "ba_enable_beacon_abort is: %d\n",
28 			le32_to_cpu(cmd->ba_enable_beacon_abort));
29 	IWL_DEBUG_POWER(mvm, "ba_escape_timer is: %d\n",
30 			le32_to_cpu(cmd->ba_escape_timer));
31 	IWL_DEBUG_POWER(mvm, "bf_debug_flag is: %d\n",
32 			le32_to_cpu(cmd->bf_debug_flag));
33 	IWL_DEBUG_POWER(mvm, "bf_enable_beacon_filter is: %d\n",
34 			le32_to_cpu(cmd->bf_enable_beacon_filter));
35 	IWL_DEBUG_POWER(mvm, "bf_energy_delta is: %d\n",
36 			le32_to_cpu(cmd->bf_energy_delta));
37 	IWL_DEBUG_POWER(mvm, "bf_escape_timer is: %d\n",
38 			le32_to_cpu(cmd->bf_escape_timer));
39 	IWL_DEBUG_POWER(mvm, "bf_roaming_energy_delta is: %d\n",
40 			le32_to_cpu(cmd->bf_roaming_energy_delta));
41 	IWL_DEBUG_POWER(mvm, "bf_roaming_state is: %d\n",
42 			le32_to_cpu(cmd->bf_roaming_state));
43 	IWL_DEBUG_POWER(mvm, "bf_temp_threshold is: %d\n",
44 			le32_to_cpu(cmd->bf_temp_threshold));
45 	IWL_DEBUG_POWER(mvm, "bf_temp_fast_filter is: %d\n",
46 			le32_to_cpu(cmd->bf_temp_fast_filter));
47 	IWL_DEBUG_POWER(mvm, "bf_temp_slow_filter is: %d\n",
48 			le32_to_cpu(cmd->bf_temp_slow_filter));
49 	IWL_DEBUG_POWER(mvm, "bf_threshold_absolute_low is: %d, %d\n",
50 			le32_to_cpu(cmd->bf_threshold_absolute_low[0]),
51 			le32_to_cpu(cmd->bf_threshold_absolute_low[1]));
52 
53 	IWL_DEBUG_POWER(mvm, "bf_threshold_absolute_high is: %d, %d\n",
54 			le32_to_cpu(cmd->bf_threshold_absolute_high[0]),
55 			le32_to_cpu(cmd->bf_threshold_absolute_high[1]));
56 
57 	if (fw_has_api(&mvm->fw->ucode_capa,
58 		       IWL_UCODE_TLV_API_BEACON_FILTER_V4))
59 		len = sizeof(struct iwl_beacon_filter_cmd);
60 	else
61 		len = offsetof(struct iwl_beacon_filter_cmd,
62 			       bf_threshold_absolute_low);
63 
64 	return iwl_mvm_send_cmd_pdu(mvm, REPLY_BEACON_FILTERING_CMD, 0,
65 				    len, cmd);
66 }
67 
68 static
69 void iwl_mvm_beacon_filter_set_cqm_params(struct iwl_mvm *mvm,
70 					  struct ieee80211_vif *vif,
71 					  struct iwl_beacon_filter_cmd *cmd)
72 {
73 	struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
74 
75 	if (vif->bss_conf.cqm_rssi_thold) {
76 		cmd->bf_energy_delta =
77 			cpu_to_le32(vif->bss_conf.cqm_rssi_hyst);
78 		/* fw uses an absolute value for this */
79 		cmd->bf_roaming_state =
80 			cpu_to_le32(-vif->bss_conf.cqm_rssi_thold);
81 	}
82 	cmd->ba_enable_beacon_abort = cpu_to_le32(mvmvif->ba_enabled);
83 }
84 
85 static void iwl_mvm_power_log(struct iwl_mvm *mvm,
86 			      struct iwl_mac_power_cmd *cmd)
87 {
88 	IWL_DEBUG_POWER(mvm,
89 			"Sending power table command on mac id 0x%X for power level %d, flags = 0x%X\n",
90 			cmd->id_and_color, iwlmvm_mod_params.power_scheme,
91 			le16_to_cpu(cmd->flags));
92 	IWL_DEBUG_POWER(mvm, "Keep alive = %u sec\n",
93 			le16_to_cpu(cmd->keep_alive_seconds));
94 
95 	if (!(cmd->flags & cpu_to_le16(POWER_FLAGS_POWER_MANAGEMENT_ENA_MSK))) {
96 		IWL_DEBUG_POWER(mvm, "Disable power management\n");
97 		return;
98 	}
99 
100 	IWL_DEBUG_POWER(mvm, "Rx timeout = %u usec\n",
101 			le32_to_cpu(cmd->rx_data_timeout));
102 	IWL_DEBUG_POWER(mvm, "Tx timeout = %u usec\n",
103 			le32_to_cpu(cmd->tx_data_timeout));
104 	if (cmd->flags & cpu_to_le16(POWER_FLAGS_SKIP_OVER_DTIM_MSK))
105 		IWL_DEBUG_POWER(mvm, "DTIM periods to skip = %u\n",
106 				cmd->skip_dtim_periods);
107 	if (cmd->flags & cpu_to_le16(POWER_FLAGS_LPRX_ENA_MSK))
108 		IWL_DEBUG_POWER(mvm, "LP RX RSSI threshold = %u\n",
109 				cmd->lprx_rssi_threshold);
110 	if (cmd->flags & cpu_to_le16(POWER_FLAGS_ADVANCE_PM_ENA_MSK)) {
111 		IWL_DEBUG_POWER(mvm, "uAPSD enabled\n");
112 		IWL_DEBUG_POWER(mvm, "Rx timeout (uAPSD) = %u usec\n",
113 				le32_to_cpu(cmd->rx_data_timeout_uapsd));
114 		IWL_DEBUG_POWER(mvm, "Tx timeout (uAPSD) = %u usec\n",
115 				le32_to_cpu(cmd->tx_data_timeout_uapsd));
116 		IWL_DEBUG_POWER(mvm, "QNDP TID = %d\n", cmd->qndp_tid);
117 		IWL_DEBUG_POWER(mvm, "ACs flags = 0x%x\n", cmd->uapsd_ac_flags);
118 		IWL_DEBUG_POWER(mvm, "Max SP = %d\n", cmd->uapsd_max_sp);
119 	}
120 }
121 
122 static void iwl_mvm_power_configure_uapsd(struct iwl_mvm *mvm,
123 					  struct ieee80211_vif *vif,
124 					  struct iwl_mac_power_cmd *cmd)
125 {
126 	struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
127 	enum ieee80211_ac_numbers ac;
128 	bool tid_found = false;
129 
130 	if (test_bit(IWL_MVM_STATUS_IN_D3, &mvm->status) ||
131 	    cmd->flags & cpu_to_le16(POWER_FLAGS_SNOOZE_ENA_MSK)) {
132 		cmd->rx_data_timeout_uapsd =
133 			cpu_to_le32(IWL_MVM_WOWLAN_PS_RX_DATA_TIMEOUT);
134 		cmd->tx_data_timeout_uapsd =
135 			cpu_to_le32(IWL_MVM_WOWLAN_PS_TX_DATA_TIMEOUT);
136 	} else {
137 		cmd->rx_data_timeout_uapsd =
138 			cpu_to_le32(IWL_MVM_UAPSD_RX_DATA_TIMEOUT);
139 		cmd->tx_data_timeout_uapsd =
140 			cpu_to_le32(IWL_MVM_UAPSD_TX_DATA_TIMEOUT);
141 	}
142 
143 #ifdef CONFIG_IWLWIFI_DEBUGFS
144 	/* set advanced pm flag with no uapsd ACs to enable ps-poll */
145 	if (mvmvif->dbgfs_pm.use_ps_poll) {
146 		cmd->flags |= cpu_to_le16(POWER_FLAGS_ADVANCE_PM_ENA_MSK);
147 		return;
148 	}
149 #endif
150 
151 	for (ac = IEEE80211_AC_VO; ac <= IEEE80211_AC_BK; ac++) {
152 		if (!mvmvif->deflink.queue_params[ac].uapsd)
153 			continue;
154 
155 		if (!test_bit(IWL_MVM_STATUS_IN_D3, &mvm->status))
156 			cmd->flags |=
157 				cpu_to_le16(POWER_FLAGS_ADVANCE_PM_ENA_MSK);
158 
159 		cmd->uapsd_ac_flags |= BIT(ac);
160 
161 		/* QNDP TID - the highest TID with no admission control */
162 		if (!tid_found && !mvmvif->deflink.queue_params[ac].acm) {
163 			tid_found = true;
164 			switch (ac) {
165 			case IEEE80211_AC_VO:
166 				cmd->qndp_tid = 6;
167 				break;
168 			case IEEE80211_AC_VI:
169 				cmd->qndp_tid = 5;
170 				break;
171 			case IEEE80211_AC_BE:
172 				cmd->qndp_tid = 0;
173 				break;
174 			case IEEE80211_AC_BK:
175 				cmd->qndp_tid = 1;
176 				break;
177 			}
178 		}
179 	}
180 
181 	cmd->flags |= cpu_to_le16(POWER_FLAGS_UAPSD_MISBEHAVING_ENA_MSK);
182 
183 	if (cmd->uapsd_ac_flags == (BIT(IEEE80211_AC_VO) |
184 				    BIT(IEEE80211_AC_VI) |
185 				    BIT(IEEE80211_AC_BE) |
186 				    BIT(IEEE80211_AC_BK))) {
187 		cmd->flags |= cpu_to_le16(POWER_FLAGS_SNOOZE_ENA_MSK);
188 		cmd->snooze_interval = cpu_to_le16(IWL_MVM_PS_SNOOZE_INTERVAL);
189 		cmd->snooze_window =
190 			test_bit(IWL_MVM_STATUS_IN_D3, &mvm->status) ?
191 				cpu_to_le16(IWL_MVM_WOWLAN_PS_SNOOZE_WINDOW) :
192 				cpu_to_le16(IWL_MVM_PS_SNOOZE_WINDOW);
193 	}
194 
195 	cmd->uapsd_max_sp = mvm->hw->uapsd_max_sp_len;
196 
197 	if (cmd->flags & cpu_to_le16(POWER_FLAGS_SNOOZE_ENA_MSK)) {
198 		cmd->heavy_tx_thld_packets =
199 			IWL_MVM_PS_SNOOZE_HEAVY_TX_THLD_PACKETS;
200 		cmd->heavy_rx_thld_packets =
201 			IWL_MVM_PS_SNOOZE_HEAVY_RX_THLD_PACKETS;
202 	} else {
203 		cmd->heavy_tx_thld_packets =
204 			IWL_MVM_PS_HEAVY_TX_THLD_PACKETS;
205 		cmd->heavy_rx_thld_packets =
206 			IWL_MVM_PS_HEAVY_RX_THLD_PACKETS;
207 	}
208 	cmd->heavy_tx_thld_percentage =
209 		IWL_MVM_PS_HEAVY_TX_THLD_PERCENT;
210 	cmd->heavy_rx_thld_percentage =
211 		IWL_MVM_PS_HEAVY_RX_THLD_PERCENT;
212 }
213 
214 struct iwl_allow_uapsd_iface_iterator_data {
215 	struct ieee80211_vif *current_vif;
216 	bool allow_uapsd;
217 };
218 
219 static void iwl_mvm_allow_uapsd_iterator(void *_data, u8 *mac,
220 					 struct ieee80211_vif *vif)
221 {
222 	struct iwl_allow_uapsd_iface_iterator_data *data = _data;
223 	struct iwl_mvm_vif *other_mvmvif = iwl_mvm_vif_from_mac80211(vif);
224 	struct iwl_mvm_vif *curr_mvmvif =
225 		iwl_mvm_vif_from_mac80211(data->current_vif);
226 
227 	/* exclude the given vif */
228 	if (vif == data->current_vif)
229 		return;
230 
231 	switch (vif->type) {
232 	case NL80211_IFTYPE_AP:
233 	case NL80211_IFTYPE_ADHOC:
234 	case NL80211_IFTYPE_NAN:
235 		data->allow_uapsd = false;
236 		break;
237 	case NL80211_IFTYPE_STATION:
238 		/* allow UAPSD if P2P interface and BSS station interface share
239 		 * the same channel.
240 		 */
241 		if (vif->cfg.assoc && other_mvmvif->deflink.phy_ctxt &&
242 		    curr_mvmvif->deflink.phy_ctxt &&
243 		    other_mvmvif->deflink.phy_ctxt->id != curr_mvmvif->deflink.phy_ctxt->id)
244 			data->allow_uapsd = false;
245 		break;
246 
247 	default:
248 		break;
249 	}
250 }
251 
252 static bool iwl_mvm_power_allow_uapsd(struct iwl_mvm *mvm,
253 				       struct ieee80211_vif *vif)
254 {
255 	struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
256 	struct iwl_allow_uapsd_iface_iterator_data data = {
257 		.current_vif = vif,
258 		.allow_uapsd = true,
259 	};
260 
261 	if (ether_addr_equal(mvmvif->uapsd_misbehaving_ap_addr,
262 			     vif->cfg.ap_addr))
263 		return false;
264 
265 	/*
266 	 * Avoid using uAPSD if P2P client is associated to GO that uses
267 	 * opportunistic power save. This is due to current FW limitation.
268 	 */
269 	if (vif->p2p &&
270 	    (vif->bss_conf.p2p_noa_attr.oppps_ctwindow &
271 	    IEEE80211_P2P_OPPPS_ENABLE_BIT))
272 		return false;
273 
274 	if (vif->p2p && !iwl_mvm_is_p2p_scm_uapsd_supported(mvm))
275 		return false;
276 
277 	ieee80211_iterate_active_interfaces_atomic(mvm->hw,
278 				IEEE80211_IFACE_ITER_NORMAL,
279 				iwl_mvm_allow_uapsd_iterator,
280 				&data);
281 
282 	return data.allow_uapsd;
283 }
284 
285 static bool iwl_mvm_power_is_radar(struct ieee80211_bss_conf *link_conf)
286 {
287 	struct ieee80211_chanctx_conf *chanctx_conf;
288 
289 	chanctx_conf = rcu_dereference(link_conf->chanctx_conf);
290 
291 	/* this happens on link switching, just ignore inactive ones */
292 	if (!chanctx_conf)
293 		return false;
294 
295 	return chanctx_conf->def.chan->flags & IEEE80211_CHAN_RADAR;
296 }
297 
298 static void iwl_mvm_power_config_skip_dtim(struct iwl_mvm *mvm,
299 					   struct ieee80211_vif *vif,
300 					   struct iwl_mac_power_cmd *cmd)
301 {
302 	struct ieee80211_bss_conf *link_conf;
303 	unsigned int min_link_skip = ~0;
304 	unsigned int link_id;
305 
306 	/* disable, in case we're supposed to override */
307 	cmd->skip_dtim_periods = 0;
308 	cmd->flags &= ~cpu_to_le16(POWER_FLAGS_SKIP_OVER_DTIM_MSK);
309 
310 	if (!test_bit(IWL_MVM_STATUS_IN_D3, &mvm->status)) {
311 		if (iwlmvm_mod_params.power_scheme != IWL_POWER_SCHEME_LP)
312 			return;
313 		cmd->skip_dtim_periods = 2;
314 		cmd->flags |= cpu_to_le16(POWER_FLAGS_SKIP_OVER_DTIM_MSK);
315 		return;
316 	}
317 
318 	rcu_read_lock();
319 	for_each_vif_active_link(vif, link_conf, link_id) {
320 		unsigned int dtimper = link_conf->dtim_period ?: 1;
321 		unsigned int dtimper_tu = dtimper * link_conf->beacon_int;
322 		unsigned int skip;
323 
324 		if (dtimper >= 10 || iwl_mvm_power_is_radar(link_conf)) {
325 			rcu_read_unlock();
326 			return;
327 		}
328 
329 		if (WARN_ON(!dtimper_tu))
330 			continue;
331 
332 		/* configure skip over dtim up to 900 TU DTIM interval */
333 		skip = max_t(int, 1, 900 / dtimper_tu);
334 		min_link_skip = min(min_link_skip, skip);
335 	}
336 	rcu_read_unlock();
337 
338 	/* no WARN_ON, can only happen with WARN_ON above */
339 	if (min_link_skip == ~0)
340 		return;
341 
342 	cmd->skip_dtim_periods = min_link_skip;
343 	cmd->flags |= cpu_to_le16(POWER_FLAGS_SKIP_OVER_DTIM_MSK);
344 }
345 
346 static void iwl_mvm_power_build_cmd(struct iwl_mvm *mvm,
347 				    struct ieee80211_vif *vif,
348 				    struct iwl_mac_power_cmd *cmd)
349 {
350 	int dtimper, bi;
351 	int keep_alive;
352 	struct iwl_mvm_vif *mvmvif __maybe_unused =
353 		iwl_mvm_vif_from_mac80211(vif);
354 
355 	cmd->id_and_color = cpu_to_le32(FW_CMD_ID_AND_COLOR(mvmvif->id,
356 							    mvmvif->color));
357 	dtimper = vif->bss_conf.dtim_period;
358 	bi = vif->bss_conf.beacon_int;
359 
360 	/*
361 	 * Regardless of power management state the driver must set
362 	 * keep alive period. FW will use it for sending keep alive NDPs
363 	 * immediately after association. Check that keep alive period
364 	 * is at least 3 * DTIM
365 	 */
366 	keep_alive = DIV_ROUND_UP(ieee80211_tu_to_usec(3 * dtimper * bi),
367 				  USEC_PER_SEC);
368 	keep_alive = max(keep_alive, POWER_KEEP_ALIVE_PERIOD_SEC);
369 	cmd->keep_alive_seconds = cpu_to_le16(keep_alive);
370 
371 	if (mvm->ps_disabled)
372 		return;
373 
374 	cmd->flags |= cpu_to_le16(POWER_FLAGS_POWER_SAVE_ENA_MSK);
375 
376 	if (!vif->cfg.ps || !mvmvif->pm_enabled)
377 		return;
378 
379 	if (iwl_fw_lookup_cmd_ver(mvm->fw, MAC_PM_POWER_TABLE, 0) >= 2)
380 		cmd->flags |= cpu_to_le16(POWER_FLAGS_ENABLE_SMPS_MSK);
381 
382 	if (iwl_mvm_vif_low_latency(mvmvif) && vif->p2p &&
383 	    (!fw_has_capa(&mvm->fw->ucode_capa,
384 			 IWL_UCODE_TLV_CAPA_SHORT_PM_TIMEOUTS) ||
385 	     !IWL_MVM_P2P_LOWLATENCY_PS_ENABLE))
386 		return;
387 
388 	cmd->flags |= cpu_to_le16(POWER_FLAGS_POWER_MANAGEMENT_ENA_MSK);
389 
390 	if (vif->bss_conf.beacon_rate &&
391 	    (vif->bss_conf.beacon_rate->bitrate == 10 ||
392 	     vif->bss_conf.beacon_rate->bitrate == 60)) {
393 		cmd->flags |= cpu_to_le16(POWER_FLAGS_LPRX_ENA_MSK);
394 		cmd->lprx_rssi_threshold = POWER_LPRX_RSSI_THRESHOLD;
395 	}
396 
397 	iwl_mvm_power_config_skip_dtim(mvm, vif, cmd);
398 
399 	if (test_bit(IWL_MVM_STATUS_IN_D3, &mvm->status)) {
400 		cmd->rx_data_timeout =
401 			cpu_to_le32(IWL_MVM_WOWLAN_PS_RX_DATA_TIMEOUT);
402 		cmd->tx_data_timeout =
403 			cpu_to_le32(IWL_MVM_WOWLAN_PS_TX_DATA_TIMEOUT);
404 	} else if (iwl_mvm_vif_low_latency(mvmvif) && vif->p2p &&
405 		   fw_has_capa(&mvm->fw->ucode_capa,
406 			       IWL_UCODE_TLV_CAPA_SHORT_PM_TIMEOUTS)) {
407 		cmd->tx_data_timeout =
408 			cpu_to_le32(IWL_MVM_SHORT_PS_TX_DATA_TIMEOUT);
409 		cmd->rx_data_timeout =
410 			cpu_to_le32(IWL_MVM_SHORT_PS_RX_DATA_TIMEOUT);
411 	} else {
412 		cmd->rx_data_timeout =
413 			cpu_to_le32(IWL_MVM_DEFAULT_PS_RX_DATA_TIMEOUT);
414 		cmd->tx_data_timeout =
415 			cpu_to_le32(IWL_MVM_DEFAULT_PS_TX_DATA_TIMEOUT);
416 	}
417 
418 	if (iwl_mvm_power_allow_uapsd(mvm, vif))
419 		iwl_mvm_power_configure_uapsd(mvm, vif, cmd);
420 
421 #ifdef CONFIG_IWLWIFI_DEBUGFS
422 	if (mvmvif->dbgfs_pm.mask & MVM_DEBUGFS_PM_KEEP_ALIVE)
423 		cmd->keep_alive_seconds =
424 			cpu_to_le16(mvmvif->dbgfs_pm.keep_alive_seconds);
425 	if (mvmvif->dbgfs_pm.mask & MVM_DEBUGFS_PM_SKIP_OVER_DTIM) {
426 		if (mvmvif->dbgfs_pm.skip_over_dtim)
427 			cmd->flags |=
428 				cpu_to_le16(POWER_FLAGS_SKIP_OVER_DTIM_MSK);
429 		else
430 			cmd->flags &=
431 				cpu_to_le16(~POWER_FLAGS_SKIP_OVER_DTIM_MSK);
432 	}
433 	if (mvmvif->dbgfs_pm.mask & MVM_DEBUGFS_PM_RX_DATA_TIMEOUT)
434 		cmd->rx_data_timeout =
435 			cpu_to_le32(mvmvif->dbgfs_pm.rx_data_timeout);
436 	if (mvmvif->dbgfs_pm.mask & MVM_DEBUGFS_PM_TX_DATA_TIMEOUT)
437 		cmd->tx_data_timeout =
438 			cpu_to_le32(mvmvif->dbgfs_pm.tx_data_timeout);
439 	if (mvmvif->dbgfs_pm.mask & MVM_DEBUGFS_PM_SKIP_DTIM_PERIODS)
440 		cmd->skip_dtim_periods = mvmvif->dbgfs_pm.skip_dtim_periods;
441 	if (mvmvif->dbgfs_pm.mask & MVM_DEBUGFS_PM_LPRX_ENA) {
442 		if (mvmvif->dbgfs_pm.lprx_ena)
443 			cmd->flags |= cpu_to_le16(POWER_FLAGS_LPRX_ENA_MSK);
444 		else
445 			cmd->flags &= cpu_to_le16(~POWER_FLAGS_LPRX_ENA_MSK);
446 	}
447 	if (mvmvif->dbgfs_pm.mask & MVM_DEBUGFS_PM_LPRX_RSSI_THRESHOLD)
448 		cmd->lprx_rssi_threshold = mvmvif->dbgfs_pm.lprx_rssi_threshold;
449 	if (mvmvif->dbgfs_pm.mask & MVM_DEBUGFS_PM_SNOOZE_ENABLE) {
450 		if (mvmvif->dbgfs_pm.snooze_ena)
451 			cmd->flags |=
452 				cpu_to_le16(POWER_FLAGS_SNOOZE_ENA_MSK);
453 		else
454 			cmd->flags &=
455 				cpu_to_le16(~POWER_FLAGS_SNOOZE_ENA_MSK);
456 	}
457 	if (mvmvif->dbgfs_pm.mask & MVM_DEBUGFS_PM_UAPSD_MISBEHAVING) {
458 		u16 flag = POWER_FLAGS_UAPSD_MISBEHAVING_ENA_MSK;
459 		if (mvmvif->dbgfs_pm.uapsd_misbehaving)
460 			cmd->flags |= cpu_to_le16(flag);
461 		else
462 			cmd->flags &= cpu_to_le16(flag);
463 	}
464 #endif /* CONFIG_IWLWIFI_DEBUGFS */
465 }
466 
467 static int iwl_mvm_power_send_cmd(struct iwl_mvm *mvm,
468 					 struct ieee80211_vif *vif)
469 {
470 	struct iwl_mac_power_cmd cmd = {};
471 
472 	iwl_mvm_power_build_cmd(mvm, vif, &cmd);
473 	iwl_mvm_power_log(mvm, &cmd);
474 #ifdef CONFIG_IWLWIFI_DEBUGFS
475 	memcpy(&iwl_mvm_vif_from_mac80211(vif)->mac_pwr_cmd, &cmd, sizeof(cmd));
476 #endif
477 
478 	return iwl_mvm_send_cmd_pdu(mvm, MAC_PM_POWER_TABLE, 0,
479 				    sizeof(cmd), &cmd);
480 }
481 
482 int iwl_mvm_power_update_device(struct iwl_mvm *mvm)
483 {
484 	struct iwl_device_power_cmd cmd = {
485 		.flags = 0,
486 	};
487 
488 	if (iwlmvm_mod_params.power_scheme == IWL_POWER_SCHEME_CAM)
489 		mvm->ps_disabled = true;
490 
491 	if (!mvm->ps_disabled)
492 		cmd.flags |= cpu_to_le16(DEVICE_POWER_FLAGS_POWER_SAVE_ENA_MSK);
493 
494 #ifdef CONFIG_IWLWIFI_DEBUGFS
495 	if (test_bit(IWL_MVM_STATUS_IN_D3, &mvm->status) ?
496 			mvm->disable_power_off_d3 : mvm->disable_power_off)
497 		cmd.flags &=
498 			cpu_to_le16(~DEVICE_POWER_FLAGS_POWER_SAVE_ENA_MSK);
499 #endif
500 	if (mvm->ext_clock_valid)
501 		cmd.flags |= cpu_to_le16(DEVICE_POWER_FLAGS_32K_CLK_VALID_MSK);
502 
503 	if (iwl_fw_lookup_cmd_ver(mvm->fw, POWER_TABLE_CMD, 0) >= 7 &&
504 	    test_bit(IWL_MVM_STATUS_IN_D3, &mvm->status))
505 		cmd.flags |=
506 			cpu_to_le16(DEVICE_POWER_FLAGS_NO_SLEEP_TILL_D3_MSK);
507 
508 	IWL_DEBUG_POWER(mvm,
509 			"Sending device power command with flags = 0x%X\n",
510 			cmd.flags);
511 
512 	return iwl_mvm_send_cmd_pdu(mvm, POWER_TABLE_CMD, 0, sizeof(cmd),
513 				    &cmd);
514 }
515 
516 void iwl_mvm_power_vif_assoc(struct iwl_mvm *mvm, struct ieee80211_vif *vif)
517 {
518 	struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
519 
520 	if (!ether_addr_equal(mvmvif->uapsd_misbehaving_ap_addr,
521 			      vif->cfg.ap_addr))
522 		eth_zero_addr(mvmvif->uapsd_misbehaving_ap_addr);
523 }
524 
525 static void iwl_mvm_power_uapsd_misbehav_ap_iterator(void *_data, u8 *mac,
526 						     struct ieee80211_vif *vif)
527 {
528 	u8 *ap_sta_id = _data;
529 	struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
530 	struct ieee80211_bss_conf *link_conf;
531 	unsigned int link_id;
532 
533 	rcu_read_lock();
534 	for_each_vif_active_link(vif, link_conf, link_id) {
535 		struct iwl_mvm_vif_link_info *link_info = mvmvif->link[link_id];
536 
537 		/* The ap_sta_id is not expected to change during current
538 		 * association so no explicit protection is needed
539 		 */
540 		if (link_info->ap_sta_id == *ap_sta_id) {
541 			ether_addr_copy(mvmvif->uapsd_misbehaving_ap_addr,
542 					vif->cfg.ap_addr);
543 			break;
544 		}
545 	}
546 	rcu_read_unlock();
547 }
548 
549 void iwl_mvm_power_uapsd_misbehaving_ap_notif(struct iwl_mvm *mvm,
550 					      struct iwl_rx_cmd_buffer *rxb)
551 {
552 	struct iwl_rx_packet *pkt = rxb_addr(rxb);
553 	struct iwl_uapsd_misbehaving_ap_notif *notif = (void *)pkt->data;
554 	u8 ap_sta_id = le32_to_cpu(notif->sta_id);
555 
556 	ieee80211_iterate_active_interfaces_atomic(
557 		mvm->hw, IEEE80211_IFACE_ITER_NORMAL,
558 		iwl_mvm_power_uapsd_misbehav_ap_iterator, &ap_sta_id);
559 }
560 
561 struct iwl_power_vifs {
562 	struct iwl_mvm *mvm;
563 	struct ieee80211_vif *bss_vif;
564 	struct ieee80211_vif *p2p_vif;
565 	struct ieee80211_vif *ap_vif;
566 	struct ieee80211_vif *monitor_vif;
567 	bool p2p_active;
568 	bool bss_active;
569 	bool ap_active;
570 	bool monitor_active;
571 };
572 
573 static void iwl_mvm_power_disable_pm_iterator(void *_data, u8 *mac,
574 					      struct ieee80211_vif *vif)
575 {
576 	struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
577 
578 	mvmvif->pm_enabled = false;
579 }
580 
581 static void iwl_mvm_power_ps_disabled_iterator(void *_data, u8 *mac,
582 					       struct ieee80211_vif *vif)
583 {
584 	struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
585 	bool *disable_ps = _data;
586 
587 	if (iwl_mvm_vif_is_active(mvmvif))
588 		*disable_ps |= mvmvif->ps_disabled;
589 }
590 
591 static void iwl_mvm_power_get_vifs_iterator(void *_data, u8 *mac,
592 					    struct ieee80211_vif *vif)
593 {
594 	struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
595 	struct iwl_power_vifs *power_iterator = _data;
596 	bool active;
597 
598 	if (!mvmvif->uploaded)
599 		return;
600 
601 	active = iwl_mvm_vif_is_active(mvmvif);
602 
603 	switch (ieee80211_vif_type_p2p(vif)) {
604 	case NL80211_IFTYPE_P2P_DEVICE:
605 		break;
606 
607 	case NL80211_IFTYPE_P2P_GO:
608 	case NL80211_IFTYPE_AP:
609 		/* only a single MAC of the same type */
610 		WARN_ON(power_iterator->ap_vif);
611 		power_iterator->ap_vif = vif;
612 		if (active)
613 			power_iterator->ap_active = true;
614 		break;
615 
616 	case NL80211_IFTYPE_MONITOR:
617 		/* only a single MAC of the same type */
618 		WARN_ON(power_iterator->monitor_vif);
619 		power_iterator->monitor_vif = vif;
620 		if (active)
621 			power_iterator->monitor_active = true;
622 		break;
623 
624 	case NL80211_IFTYPE_P2P_CLIENT:
625 		/* only a single MAC of the same type */
626 		WARN_ON(power_iterator->p2p_vif);
627 		power_iterator->p2p_vif = vif;
628 		if (active)
629 			power_iterator->p2p_active = true;
630 		break;
631 
632 	case NL80211_IFTYPE_STATION:
633 		power_iterator->bss_vif = vif;
634 		if (active)
635 			power_iterator->bss_active = true;
636 		break;
637 
638 	default:
639 		break;
640 	}
641 }
642 
643 static void iwl_mvm_power_set_pm(struct iwl_mvm *mvm,
644 				 struct iwl_power_vifs *vifs)
645 {
646 	struct iwl_mvm_vif *bss_mvmvif = NULL;
647 	struct iwl_mvm_vif *p2p_mvmvif = NULL;
648 	struct iwl_mvm_vif *ap_mvmvif = NULL;
649 	bool client_same_channel = false;
650 	bool ap_same_channel = false;
651 
652 	lockdep_assert_held(&mvm->mutex);
653 
654 	/* set pm_enable to false */
655 	ieee80211_iterate_active_interfaces_atomic(mvm->hw,
656 					IEEE80211_IFACE_ITER_NORMAL,
657 					iwl_mvm_power_disable_pm_iterator,
658 					NULL);
659 
660 	if (vifs->bss_vif)
661 		bss_mvmvif = iwl_mvm_vif_from_mac80211(vifs->bss_vif);
662 
663 	if (vifs->p2p_vif)
664 		p2p_mvmvif = iwl_mvm_vif_from_mac80211(vifs->p2p_vif);
665 
666 	if (vifs->ap_vif)
667 		ap_mvmvif = iwl_mvm_vif_from_mac80211(vifs->ap_vif);
668 
669 	/* don't allow PM if any TDLS stations exist */
670 	if (iwl_mvm_tdls_sta_count(mvm, NULL))
671 		return;
672 
673 	/* enable PM on bss if bss stand alone */
674 	if (bss_mvmvif && vifs->bss_active && !vifs->p2p_active &&
675 	    !vifs->ap_active) {
676 		bss_mvmvif->pm_enabled = true;
677 		return;
678 	}
679 
680 	/* enable PM on p2p if p2p stand alone */
681 	if (p2p_mvmvif && vifs->p2p_active && !vifs->bss_active &&
682 	    !vifs->ap_active) {
683 		p2p_mvmvif->pm_enabled = true;
684 		return;
685 	}
686 
687 	if (p2p_mvmvif && bss_mvmvif && vifs->bss_active && vifs->p2p_active)
688 		client_same_channel =
689 			iwl_mvm_have_links_same_channel(bss_mvmvif, p2p_mvmvif);
690 
691 	if (bss_mvmvif && ap_mvmvif && vifs->bss_active && vifs->ap_active)
692 		ap_same_channel =
693 			iwl_mvm_have_links_same_channel(bss_mvmvif, ap_mvmvif);
694 
695 	/* clients are not stand alone: enable PM if DCM */
696 	if (!(client_same_channel || ap_same_channel)) {
697 		if (bss_mvmvif && vifs->bss_active)
698 			bss_mvmvif->pm_enabled = true;
699 		if (p2p_mvmvif && vifs->p2p_active)
700 			p2p_mvmvif->pm_enabled = true;
701 		return;
702 	}
703 
704 	/*
705 	 * There is only one channel in the system and there are only
706 	 * bss and p2p clients that share it
707 	 */
708 	if (client_same_channel && !vifs->ap_active) {
709 		/* share same channel*/
710 		bss_mvmvif->pm_enabled = true;
711 		p2p_mvmvif->pm_enabled = true;
712 	}
713 }
714 
715 #ifdef CONFIG_IWLWIFI_DEBUGFS
716 int iwl_mvm_power_mac_dbgfs_read(struct iwl_mvm *mvm,
717 				 struct ieee80211_vif *vif, char *buf,
718 				 int bufsz)
719 {
720 	struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
721 	struct iwl_mac_power_cmd cmd = {};
722 	int pos = 0;
723 
724 	mutex_lock(&mvm->mutex);
725 	memcpy(&cmd, &mvmvif->mac_pwr_cmd, sizeof(cmd));
726 	mutex_unlock(&mvm->mutex);
727 
728 	pos += scnprintf(buf+pos, bufsz-pos, "power_scheme = %d\n",
729 			 iwlmvm_mod_params.power_scheme);
730 	pos += scnprintf(buf+pos, bufsz-pos, "flags = 0x%x\n",
731 			 le16_to_cpu(cmd.flags));
732 	pos += scnprintf(buf+pos, bufsz-pos, "keep_alive = %d\n",
733 			 le16_to_cpu(cmd.keep_alive_seconds));
734 
735 	if (!(cmd.flags & cpu_to_le16(POWER_FLAGS_POWER_MANAGEMENT_ENA_MSK)))
736 		return pos;
737 
738 	pos += scnprintf(buf+pos, bufsz-pos, "skip_over_dtim = %d\n",
739 			 (cmd.flags &
740 			 cpu_to_le16(POWER_FLAGS_SKIP_OVER_DTIM_MSK)) ? 1 : 0);
741 	pos += scnprintf(buf+pos, bufsz-pos, "skip_dtim_periods = %d\n",
742 			 cmd.skip_dtim_periods);
743 	if (!(cmd.flags & cpu_to_le16(POWER_FLAGS_ADVANCE_PM_ENA_MSK))) {
744 		pos += scnprintf(buf+pos, bufsz-pos, "rx_data_timeout = %d\n",
745 				 le32_to_cpu(cmd.rx_data_timeout));
746 		pos += scnprintf(buf+pos, bufsz-pos, "tx_data_timeout = %d\n",
747 				 le32_to_cpu(cmd.tx_data_timeout));
748 	}
749 	if (cmd.flags & cpu_to_le16(POWER_FLAGS_LPRX_ENA_MSK))
750 		pos += scnprintf(buf+pos, bufsz-pos,
751 				 "lprx_rssi_threshold = %d\n",
752 				 cmd.lprx_rssi_threshold);
753 
754 	if (!(cmd.flags & cpu_to_le16(POWER_FLAGS_ADVANCE_PM_ENA_MSK)))
755 		return pos;
756 
757 	pos += scnprintf(buf+pos, bufsz-pos, "rx_data_timeout_uapsd = %d\n",
758 			 le32_to_cpu(cmd.rx_data_timeout_uapsd));
759 	pos += scnprintf(buf+pos, bufsz-pos, "tx_data_timeout_uapsd = %d\n",
760 			 le32_to_cpu(cmd.tx_data_timeout_uapsd));
761 	pos += scnprintf(buf+pos, bufsz-pos, "qndp_tid = %d\n", cmd.qndp_tid);
762 	pos += scnprintf(buf+pos, bufsz-pos, "uapsd_ac_flags = 0x%x\n",
763 			 cmd.uapsd_ac_flags);
764 	pos += scnprintf(buf+pos, bufsz-pos, "uapsd_max_sp = %d\n",
765 			 cmd.uapsd_max_sp);
766 	pos += scnprintf(buf+pos, bufsz-pos, "heavy_tx_thld_packets = %d\n",
767 			 cmd.heavy_tx_thld_packets);
768 	pos += scnprintf(buf+pos, bufsz-pos, "heavy_rx_thld_packets = %d\n",
769 			 cmd.heavy_rx_thld_packets);
770 	pos += scnprintf(buf+pos, bufsz-pos, "heavy_tx_thld_percentage = %d\n",
771 			 cmd.heavy_tx_thld_percentage);
772 	pos += scnprintf(buf+pos, bufsz-pos, "heavy_rx_thld_percentage = %d\n",
773 			 cmd.heavy_rx_thld_percentage);
774 	pos += scnprintf(buf+pos, bufsz-pos, "uapsd_misbehaving_enable = %d\n",
775 			 (cmd.flags &
776 			  cpu_to_le16(POWER_FLAGS_UAPSD_MISBEHAVING_ENA_MSK)) ?
777 			 1 : 0);
778 
779 	if (!(cmd.flags & cpu_to_le16(POWER_FLAGS_SNOOZE_ENA_MSK)))
780 		return pos;
781 
782 	pos += scnprintf(buf+pos, bufsz-pos, "snooze_interval = %d\n",
783 			 cmd.snooze_interval);
784 	pos += scnprintf(buf+pos, bufsz-pos, "snooze_window = %d\n",
785 			 cmd.snooze_window);
786 
787 	return pos;
788 }
789 
790 void
791 iwl_mvm_beacon_filter_debugfs_parameters(struct ieee80211_vif *vif,
792 					 struct iwl_beacon_filter_cmd *cmd)
793 {
794 	struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
795 	struct iwl_dbgfs_bf *dbgfs_bf = &mvmvif->dbgfs_bf;
796 
797 	if (dbgfs_bf->mask & MVM_DEBUGFS_BF_ENERGY_DELTA)
798 		cmd->bf_energy_delta = cpu_to_le32(dbgfs_bf->bf_energy_delta);
799 	if (dbgfs_bf->mask & MVM_DEBUGFS_BF_ROAMING_ENERGY_DELTA)
800 		cmd->bf_roaming_energy_delta =
801 				cpu_to_le32(dbgfs_bf->bf_roaming_energy_delta);
802 	if (dbgfs_bf->mask & MVM_DEBUGFS_BF_ROAMING_STATE)
803 		cmd->bf_roaming_state = cpu_to_le32(dbgfs_bf->bf_roaming_state);
804 	if (dbgfs_bf->mask & MVM_DEBUGFS_BF_TEMP_THRESHOLD)
805 		cmd->bf_temp_threshold =
806 				cpu_to_le32(dbgfs_bf->bf_temp_threshold);
807 	if (dbgfs_bf->mask & MVM_DEBUGFS_BF_TEMP_FAST_FILTER)
808 		cmd->bf_temp_fast_filter =
809 				cpu_to_le32(dbgfs_bf->bf_temp_fast_filter);
810 	if (dbgfs_bf->mask & MVM_DEBUGFS_BF_TEMP_SLOW_FILTER)
811 		cmd->bf_temp_slow_filter =
812 				cpu_to_le32(dbgfs_bf->bf_temp_slow_filter);
813 	if (dbgfs_bf->mask & MVM_DEBUGFS_BF_DEBUG_FLAG)
814 		cmd->bf_debug_flag = cpu_to_le32(dbgfs_bf->bf_debug_flag);
815 	if (dbgfs_bf->mask & MVM_DEBUGFS_BF_ESCAPE_TIMER)
816 		cmd->bf_escape_timer = cpu_to_le32(dbgfs_bf->bf_escape_timer);
817 	if (dbgfs_bf->mask & MVM_DEBUGFS_BA_ESCAPE_TIMER)
818 		cmd->ba_escape_timer = cpu_to_le32(dbgfs_bf->ba_escape_timer);
819 	if (dbgfs_bf->mask & MVM_DEBUGFS_BA_ENABLE_BEACON_ABORT)
820 		cmd->ba_enable_beacon_abort =
821 				cpu_to_le32(dbgfs_bf->ba_enable_beacon_abort);
822 }
823 #endif
824 
825 static int _iwl_mvm_enable_beacon_filter(struct iwl_mvm *mvm,
826 					 struct ieee80211_vif *vif,
827 					 struct iwl_beacon_filter_cmd *cmd)
828 {
829 	struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
830 	int ret;
831 
832 	if (mvmvif != mvm->bf_allowed_vif || !vif->bss_conf.dtim_period ||
833 	    vif->type != NL80211_IFTYPE_STATION || vif->p2p)
834 		return 0;
835 
836 	iwl_mvm_beacon_filter_set_cqm_params(mvm, vif, cmd);
837 	iwl_mvm_beacon_filter_debugfs_parameters(vif, cmd);
838 	ret = iwl_mvm_beacon_filter_send_cmd(mvm, cmd);
839 
840 	if (!ret)
841 		mvmvif->bf_enabled = true;
842 
843 	return ret;
844 }
845 
846 int iwl_mvm_enable_beacon_filter(struct iwl_mvm *mvm,
847 				 struct ieee80211_vif *vif)
848 {
849 	struct iwl_beacon_filter_cmd cmd = {
850 		IWL_BF_CMD_CONFIG_DEFAULTS,
851 		.bf_enable_beacon_filter = cpu_to_le32(1),
852 	};
853 
854 	return _iwl_mvm_enable_beacon_filter(mvm, vif, &cmd);
855 }
856 
857 static int _iwl_mvm_disable_beacon_filter(struct iwl_mvm *mvm,
858 					  struct ieee80211_vif *vif)
859 {
860 	struct iwl_beacon_filter_cmd cmd = {};
861 	struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
862 	int ret;
863 
864 	if (vif->type != NL80211_IFTYPE_STATION || vif->p2p)
865 		return 0;
866 
867 	ret = iwl_mvm_beacon_filter_send_cmd(mvm, &cmd);
868 
869 	if (!ret)
870 		mvmvif->bf_enabled = false;
871 
872 	return ret;
873 }
874 
875 int iwl_mvm_disable_beacon_filter(struct iwl_mvm *mvm,
876 				  struct ieee80211_vif *vif)
877 {
878 	return _iwl_mvm_disable_beacon_filter(mvm, vif);
879 }
880 
881 static int iwl_mvm_power_set_ps(struct iwl_mvm *mvm)
882 {
883 	bool disable_ps;
884 	int ret;
885 
886 	/* disable PS if CAM */
887 	disable_ps = (iwlmvm_mod_params.power_scheme == IWL_POWER_SCHEME_CAM);
888 	/* ...or if any of the vifs require PS to be off */
889 	ieee80211_iterate_active_interfaces_atomic(mvm->hw,
890 					IEEE80211_IFACE_ITER_NORMAL,
891 					iwl_mvm_power_ps_disabled_iterator,
892 					&disable_ps);
893 
894 	/* update device power state if it has changed */
895 	if (mvm->ps_disabled != disable_ps) {
896 		bool old_ps_disabled = mvm->ps_disabled;
897 
898 		mvm->ps_disabled = disable_ps;
899 		ret = iwl_mvm_power_update_device(mvm);
900 		if (ret) {
901 			mvm->ps_disabled = old_ps_disabled;
902 			return ret;
903 		}
904 	}
905 
906 	return 0;
907 }
908 
909 static int iwl_mvm_power_set_ba(struct iwl_mvm *mvm,
910 				struct ieee80211_vif *vif)
911 {
912 	struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(vif);
913 	struct iwl_beacon_filter_cmd cmd = {
914 		IWL_BF_CMD_CONFIG_DEFAULTS,
915 		.bf_enable_beacon_filter = cpu_to_le32(1),
916 	};
917 
918 	if (!mvmvif->bf_enabled)
919 		return 0;
920 
921 	if (test_bit(IWL_MVM_STATUS_IN_D3, &mvm->status))
922 		cmd.ba_escape_timer = cpu_to_le32(IWL_BA_ESCAPE_TIMER_D3);
923 
924 	mvmvif->ba_enabled = !(!mvmvif->pm_enabled ||
925 			       mvm->ps_disabled ||
926 			       !vif->cfg.ps ||
927 			       iwl_mvm_vif_low_latency(mvmvif));
928 
929 	return _iwl_mvm_enable_beacon_filter(mvm, vif, &cmd);
930 }
931 
932 int iwl_mvm_power_update_ps(struct iwl_mvm *mvm)
933 {
934 	struct iwl_power_vifs vifs = {
935 		.mvm = mvm,
936 	};
937 	int ret;
938 
939 	lockdep_assert_held(&mvm->mutex);
940 
941 	/* get vifs info */
942 	ieee80211_iterate_active_interfaces_atomic(mvm->hw,
943 					IEEE80211_IFACE_ITER_NORMAL,
944 					iwl_mvm_power_get_vifs_iterator, &vifs);
945 
946 	ret = iwl_mvm_power_set_ps(mvm);
947 	if (ret)
948 		return ret;
949 
950 	if (vifs.bss_vif)
951 		return iwl_mvm_power_set_ba(mvm, vifs.bss_vif);
952 
953 	return 0;
954 }
955 
956 int iwl_mvm_power_update_mac(struct iwl_mvm *mvm)
957 {
958 	struct iwl_power_vifs vifs = {
959 		.mvm = mvm,
960 	};
961 	int ret;
962 
963 	lockdep_assert_held(&mvm->mutex);
964 
965 	/* get vifs info */
966 	ieee80211_iterate_active_interfaces_atomic(mvm->hw,
967 					IEEE80211_IFACE_ITER_NORMAL,
968 					iwl_mvm_power_get_vifs_iterator, &vifs);
969 
970 	iwl_mvm_power_set_pm(mvm, &vifs);
971 
972 	ret = iwl_mvm_power_set_ps(mvm);
973 	if (ret)
974 		return ret;
975 
976 	if (vifs.bss_vif) {
977 		ret = iwl_mvm_power_send_cmd(mvm, vifs.bss_vif);
978 		if (ret)
979 			return ret;
980 	}
981 
982 	if (vifs.p2p_vif) {
983 		ret = iwl_mvm_power_send_cmd(mvm, vifs.p2p_vif);
984 		if (ret)
985 			return ret;
986 	}
987 
988 	if (vifs.bss_vif)
989 		return iwl_mvm_power_set_ba(mvm, vifs.bss_vif);
990 
991 	return 0;
992 }
993