xref: /linux/drivers/net/wireless/ath/wil6210/cfg80211.c (revision 7f71507851fc7764b36a3221839607d3a45c2025)
1 // SPDX-License-Identifier: ISC
2 /*
3  * Copyright (c) 2012-2017 Qualcomm Atheros, Inc.
4  * Copyright (c) 2018-2019, The Linux Foundation. All rights reserved.
5  */
6 
7 #include <linux/etherdevice.h>
8 #include <linux/moduleparam.h>
9 #include <net/netlink.h>
10 #include <net/cfg80211.h>
11 #include "wil6210.h"
12 #include "wmi.h"
13 #include "fw.h"
14 
15 #define WIL_MAX_ROC_DURATION_MS 5000
16 
17 #define WIL_EDMG_CHANNEL_9_SUBCHANNELS	(BIT(0) | BIT(1))
18 #define WIL_EDMG_CHANNEL_10_SUBCHANNELS	(BIT(1) | BIT(2))
19 #define WIL_EDMG_CHANNEL_11_SUBCHANNELS	(BIT(2) | BIT(3))
20 
21 /* WIL_EDMG_BW_CONFIGURATION define the allowed channel bandwidth
22  * configurations as defined by IEEE 802.11 section 9.4.2.251, Table 13.
23  * The value 5 allowing CB1 and CB2 of adjacent channels.
24  */
25 #define WIL_EDMG_BW_CONFIGURATION 5
26 
27 /* WIL_EDMG_CHANNELS is a bitmap that indicates the 2.16 GHz channel(s) that
28  * are allowed to be used for EDMG transmissions in the BSS as defined by
29  * IEEE 802.11 section 9.4.2.251.
30  */
31 #define WIL_EDMG_CHANNELS (BIT(0) | BIT(1) | BIT(2) | BIT(3))
32 
33 bool disable_ap_sme;
34 module_param(disable_ap_sme, bool, 0444);
35 MODULE_PARM_DESC(disable_ap_sme, " let user space handle AP mode SME");
36 
37 #ifdef CONFIG_PM
38 static struct wiphy_wowlan_support wil_wowlan_support = {
39 	.flags = WIPHY_WOWLAN_ANY | WIPHY_WOWLAN_DISCONNECT,
40 };
41 #endif
42 
43 #define CHAN60G(_channel, _flags) {				\
44 	.band			= NL80211_BAND_60GHZ,		\
45 	.center_freq		= 56160 + (2160 * (_channel)),	\
46 	.hw_value		= (_channel),			\
47 	.flags			= (_flags),			\
48 	.max_antenna_gain	= 0,				\
49 	.max_power		= 40,				\
50 }
51 
52 static struct ieee80211_channel wil_60ghz_channels[] = {
53 	CHAN60G(1, 0),
54 	CHAN60G(2, 0),
55 	CHAN60G(3, 0),
56 	CHAN60G(4, 0),
57 };
58 
59 /* Rx channel bonding mode */
60 enum wil_rx_cb_mode {
61 	WIL_RX_CB_MODE_DMG,
62 	WIL_RX_CB_MODE_EDMG,
63 	WIL_RX_CB_MODE_WIDE,
64 };
65 
66 static int wil_rx_cb_mode_to_n_bonded(u8 cb_mode)
67 {
68 	switch (cb_mode) {
69 	case WIL_RX_CB_MODE_DMG:
70 	case WIL_RX_CB_MODE_EDMG:
71 		return 1;
72 	case WIL_RX_CB_MODE_WIDE:
73 		return 2;
74 	default:
75 		return 1;
76 	}
77 }
78 
79 static int wil_tx_cb_mode_to_n_bonded(u8 cb_mode)
80 {
81 	switch (cb_mode) {
82 	case WMI_TX_MODE_DMG:
83 	case WMI_TX_MODE_EDMG_CB1:
84 		return 1;
85 	case WMI_TX_MODE_EDMG_CB2:
86 		return 2;
87 	default:
88 		return 1;
89 	}
90 }
91 
92 static void
93 wil_memdup_ie(u8 **pdst, size_t *pdst_len, const u8 *src, size_t src_len)
94 {
95 	kfree(*pdst);
96 	*pdst = NULL;
97 	*pdst_len = 0;
98 	if (src_len > 0) {
99 		*pdst = kmemdup(src, src_len, GFP_KERNEL);
100 		if (*pdst)
101 			*pdst_len = src_len;
102 	}
103 }
104 
105 static int wil_num_supported_channels(struct wil6210_priv *wil)
106 {
107 	int num_channels = ARRAY_SIZE(wil_60ghz_channels);
108 
109 	if (!test_bit(WMI_FW_CAPABILITY_CHANNEL_4, wil->fw_capabilities))
110 		num_channels--;
111 
112 	return num_channels;
113 }
114 
115 void update_supported_bands(struct wil6210_priv *wil)
116 {
117 	struct wiphy *wiphy = wil_to_wiphy(wil);
118 
119 	wil_dbg_misc(wil, "update supported bands");
120 
121 	wiphy->bands[NL80211_BAND_60GHZ]->n_channels =
122 						wil_num_supported_channels(wil);
123 
124 	if (test_bit(WMI_FW_CAPABILITY_CHANNEL_BONDING, wil->fw_capabilities)) {
125 		wiphy->bands[NL80211_BAND_60GHZ]->edmg_cap.channels =
126 							WIL_EDMG_CHANNELS;
127 		wiphy->bands[NL80211_BAND_60GHZ]->edmg_cap.bw_config =
128 						      WIL_EDMG_BW_CONFIGURATION;
129 	}
130 }
131 
132 /* Vendor id to be used in vendor specific command and events
133  * to user space.
134  * NOTE: The authoritative place for definition of QCA_NL80211_VENDOR_ID,
135  * vendor subcmd definitions prefixed with QCA_NL80211_VENDOR_SUBCMD, and
136  * qca_wlan_vendor_attr is open source file src/common/qca-vendor.h in
137  * git://w1.fi/srv/git/hostap.git; the values here are just a copy of that
138  */
139 
140 #define QCA_NL80211_VENDOR_ID	0x001374
141 
142 #define WIL_MAX_RF_SECTORS (128)
143 #define WIL_CID_ALL (0xff)
144 
145 enum qca_wlan_vendor_attr_rf_sector {
146 	QCA_ATTR_MAC_ADDR = 6,
147 	QCA_ATTR_PAD = 13,
148 	QCA_ATTR_TSF = 29,
149 	QCA_ATTR_DMG_RF_SECTOR_INDEX = 30,
150 	QCA_ATTR_DMG_RF_SECTOR_TYPE = 31,
151 	QCA_ATTR_DMG_RF_MODULE_MASK = 32,
152 	QCA_ATTR_DMG_RF_SECTOR_CFG = 33,
153 	QCA_ATTR_DMG_RF_SECTOR_MAX,
154 };
155 
156 enum qca_wlan_vendor_attr_dmg_rf_sector_type {
157 	QCA_ATTR_DMG_RF_SECTOR_TYPE_RX,
158 	QCA_ATTR_DMG_RF_SECTOR_TYPE_TX,
159 	QCA_ATTR_DMG_RF_SECTOR_TYPE_MAX
160 };
161 
162 enum qca_wlan_vendor_attr_dmg_rf_sector_cfg {
163 	QCA_ATTR_DMG_RF_SECTOR_CFG_INVALID = 0,
164 	QCA_ATTR_DMG_RF_SECTOR_CFG_MODULE_INDEX,
165 	QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE0,
166 	QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE1,
167 	QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE2,
168 	QCA_ATTR_DMG_RF_SECTOR_CFG_PSH_HI,
169 	QCA_ATTR_DMG_RF_SECTOR_CFG_PSH_LO,
170 	QCA_ATTR_DMG_RF_SECTOR_CFG_DTYPE_X16,
171 
172 	/* keep last */
173 	QCA_ATTR_DMG_RF_SECTOR_CFG_AFTER_LAST,
174 	QCA_ATTR_DMG_RF_SECTOR_CFG_MAX =
175 	QCA_ATTR_DMG_RF_SECTOR_CFG_AFTER_LAST - 1
176 };
177 
178 static const struct
179 nla_policy wil_rf_sector_policy[QCA_ATTR_DMG_RF_SECTOR_MAX + 1] = {
180 	[QCA_ATTR_MAC_ADDR] = { .len = ETH_ALEN },
181 	[QCA_ATTR_DMG_RF_SECTOR_INDEX] = { .type = NLA_U16 },
182 	[QCA_ATTR_DMG_RF_SECTOR_TYPE] = { .type = NLA_U8 },
183 	[QCA_ATTR_DMG_RF_MODULE_MASK] = { .type = NLA_U32 },
184 	[QCA_ATTR_DMG_RF_SECTOR_CFG] = { .type = NLA_NESTED },
185 };
186 
187 static const struct
188 nla_policy wil_rf_sector_cfg_policy[QCA_ATTR_DMG_RF_SECTOR_CFG_MAX + 1] = {
189 	[QCA_ATTR_DMG_RF_SECTOR_CFG_MODULE_INDEX] = { .type = NLA_U8 },
190 	[QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE0] = { .type = NLA_U32 },
191 	[QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE1] = { .type = NLA_U32 },
192 	[QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE2] = { .type = NLA_U32 },
193 	[QCA_ATTR_DMG_RF_SECTOR_CFG_PSH_HI] = { .type = NLA_U32 },
194 	[QCA_ATTR_DMG_RF_SECTOR_CFG_PSH_LO] = { .type = NLA_U32 },
195 	[QCA_ATTR_DMG_RF_SECTOR_CFG_DTYPE_X16] = { .type = NLA_U32 },
196 };
197 
198 enum qca_nl80211_vendor_subcmds {
199 	QCA_NL80211_VENDOR_SUBCMD_DMG_RF_GET_SECTOR_CFG = 139,
200 	QCA_NL80211_VENDOR_SUBCMD_DMG_RF_SET_SECTOR_CFG = 140,
201 	QCA_NL80211_VENDOR_SUBCMD_DMG_RF_GET_SELECTED_SECTOR = 141,
202 	QCA_NL80211_VENDOR_SUBCMD_DMG_RF_SET_SELECTED_SECTOR = 142,
203 };
204 
205 static int wil_rf_sector_get_cfg(struct wiphy *wiphy,
206 				 struct wireless_dev *wdev,
207 				 const void *data, int data_len);
208 static int wil_rf_sector_set_cfg(struct wiphy *wiphy,
209 				 struct wireless_dev *wdev,
210 				 const void *data, int data_len);
211 static int wil_rf_sector_get_selected(struct wiphy *wiphy,
212 				      struct wireless_dev *wdev,
213 				      const void *data, int data_len);
214 static int wil_rf_sector_set_selected(struct wiphy *wiphy,
215 				      struct wireless_dev *wdev,
216 				      const void *data, int data_len);
217 
218 /* vendor specific commands */
219 static const struct wiphy_vendor_command wil_nl80211_vendor_commands[] = {
220 	{
221 		.info.vendor_id = QCA_NL80211_VENDOR_ID,
222 		.info.subcmd = QCA_NL80211_VENDOR_SUBCMD_DMG_RF_GET_SECTOR_CFG,
223 		.flags = WIPHY_VENDOR_CMD_NEED_WDEV |
224 			 WIPHY_VENDOR_CMD_NEED_RUNNING,
225 		.policy = wil_rf_sector_policy,
226 		.doit = wil_rf_sector_get_cfg
227 	},
228 	{
229 		.info.vendor_id = QCA_NL80211_VENDOR_ID,
230 		.info.subcmd = QCA_NL80211_VENDOR_SUBCMD_DMG_RF_SET_SECTOR_CFG,
231 		.flags = WIPHY_VENDOR_CMD_NEED_WDEV |
232 			 WIPHY_VENDOR_CMD_NEED_RUNNING,
233 		.policy = wil_rf_sector_policy,
234 		.doit = wil_rf_sector_set_cfg
235 	},
236 	{
237 		.info.vendor_id = QCA_NL80211_VENDOR_ID,
238 		.info.subcmd =
239 			QCA_NL80211_VENDOR_SUBCMD_DMG_RF_GET_SELECTED_SECTOR,
240 		.flags = WIPHY_VENDOR_CMD_NEED_WDEV |
241 			 WIPHY_VENDOR_CMD_NEED_RUNNING,
242 		.policy = wil_rf_sector_policy,
243 		.doit = wil_rf_sector_get_selected
244 	},
245 	{
246 		.info.vendor_id = QCA_NL80211_VENDOR_ID,
247 		.info.subcmd =
248 			QCA_NL80211_VENDOR_SUBCMD_DMG_RF_SET_SELECTED_SECTOR,
249 		.flags = WIPHY_VENDOR_CMD_NEED_WDEV |
250 			 WIPHY_VENDOR_CMD_NEED_RUNNING,
251 		.policy = wil_rf_sector_policy,
252 		.doit = wil_rf_sector_set_selected
253 	},
254 };
255 
256 static struct ieee80211_supported_band wil_band_60ghz = {
257 	.channels = wil_60ghz_channels,
258 	.n_channels = ARRAY_SIZE(wil_60ghz_channels),
259 	.ht_cap = {
260 		.ht_supported = true,
261 		.cap = 0, /* TODO */
262 		.ampdu_factor = IEEE80211_HT_MAX_AMPDU_64K, /* TODO */
263 		.ampdu_density = IEEE80211_HT_MPDU_DENSITY_8, /* TODO */
264 		.mcs = {
265 				/* MCS 1..12 - SC PHY */
266 			.rx_mask = {0xfe, 0x1f}, /* 1..12 */
267 			.tx_params = IEEE80211_HT_MCS_TX_DEFINED, /* TODO */
268 		},
269 	},
270 };
271 
272 static const struct ieee80211_txrx_stypes
273 wil_mgmt_stypes[NUM_NL80211_IFTYPES] = {
274 	[NL80211_IFTYPE_STATION] = {
275 		.tx = BIT(IEEE80211_STYPE_ACTION >> 4) |
276 		BIT(IEEE80211_STYPE_PROBE_RESP >> 4),
277 		.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
278 		BIT(IEEE80211_STYPE_PROBE_REQ >> 4)
279 	},
280 	[NL80211_IFTYPE_AP] = {
281 		.tx = BIT(IEEE80211_STYPE_ACTION >> 4) |
282 		BIT(IEEE80211_STYPE_PROBE_RESP >> 4) |
283 		BIT(IEEE80211_STYPE_ASSOC_RESP >> 4) |
284 		BIT(IEEE80211_STYPE_DISASSOC >> 4) |
285 		BIT(IEEE80211_STYPE_AUTH >> 4) |
286 		BIT(IEEE80211_STYPE_REASSOC_RESP >> 4),
287 		.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
288 		BIT(IEEE80211_STYPE_PROBE_REQ >> 4) |
289 		BIT(IEEE80211_STYPE_ASSOC_REQ >> 4) |
290 		BIT(IEEE80211_STYPE_DISASSOC >> 4) |
291 		BIT(IEEE80211_STYPE_AUTH >> 4) |
292 		BIT(IEEE80211_STYPE_DEAUTH >> 4) |
293 		BIT(IEEE80211_STYPE_REASSOC_REQ >> 4)
294 	},
295 	[NL80211_IFTYPE_P2P_CLIENT] = {
296 		.tx = BIT(IEEE80211_STYPE_ACTION >> 4) |
297 		BIT(IEEE80211_STYPE_PROBE_RESP >> 4),
298 		.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
299 		BIT(IEEE80211_STYPE_PROBE_REQ >> 4)
300 	},
301 	[NL80211_IFTYPE_P2P_GO] = {
302 		.tx = BIT(IEEE80211_STYPE_ACTION >> 4) |
303 		BIT(IEEE80211_STYPE_PROBE_RESP >> 4),
304 		.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
305 		BIT(IEEE80211_STYPE_PROBE_REQ >> 4)
306 	},
307 	[NL80211_IFTYPE_P2P_DEVICE] = {
308 		.tx = BIT(IEEE80211_STYPE_ACTION >> 4) |
309 		BIT(IEEE80211_STYPE_PROBE_RESP >> 4),
310 		.rx = BIT(IEEE80211_STYPE_ACTION >> 4) |
311 		BIT(IEEE80211_STYPE_PROBE_REQ >> 4)
312 	},
313 };
314 
315 static const u32 wil_cipher_suites[] = {
316 	WLAN_CIPHER_SUITE_GCMP,
317 };
318 
319 static const char * const key_usage_str[] = {
320 	[WMI_KEY_USE_PAIRWISE]	= "PTK",
321 	[WMI_KEY_USE_RX_GROUP]	= "RX_GTK",
322 	[WMI_KEY_USE_TX_GROUP]	= "TX_GTK",
323 	[WMI_KEY_USE_STORE_PTK]	= "STORE_PTK",
324 	[WMI_KEY_USE_APPLY_PTK]	= "APPLY_PTK",
325 };
326 
327 int wil_iftype_nl2wmi(enum nl80211_iftype type)
328 {
329 	static const struct {
330 		enum nl80211_iftype nl;
331 		enum wmi_network_type wmi;
332 	} __nl2wmi[] = {
333 		{NL80211_IFTYPE_ADHOC,		WMI_NETTYPE_ADHOC},
334 		{NL80211_IFTYPE_STATION,	WMI_NETTYPE_INFRA},
335 		{NL80211_IFTYPE_AP,		WMI_NETTYPE_AP},
336 		{NL80211_IFTYPE_P2P_CLIENT,	WMI_NETTYPE_P2P},
337 		{NL80211_IFTYPE_P2P_GO,		WMI_NETTYPE_P2P},
338 		{NL80211_IFTYPE_MONITOR,	WMI_NETTYPE_ADHOC}, /* FIXME */
339 	};
340 	uint i;
341 
342 	for (i = 0; i < ARRAY_SIZE(__nl2wmi); i++) {
343 		if (__nl2wmi[i].nl == type)
344 			return __nl2wmi[i].wmi;
345 	}
346 
347 	return -EOPNOTSUPP;
348 }
349 
350 int wil_spec2wmi_ch(u8 spec_ch, u8 *wmi_ch)
351 {
352 	switch (spec_ch) {
353 	case 1:
354 		*wmi_ch = WMI_CHANNEL_1;
355 		break;
356 	case 2:
357 		*wmi_ch = WMI_CHANNEL_2;
358 		break;
359 	case 3:
360 		*wmi_ch = WMI_CHANNEL_3;
361 		break;
362 	case 4:
363 		*wmi_ch = WMI_CHANNEL_4;
364 		break;
365 	case 5:
366 		*wmi_ch = WMI_CHANNEL_5;
367 		break;
368 	case 6:
369 		*wmi_ch = WMI_CHANNEL_6;
370 		break;
371 	case 9:
372 		*wmi_ch = WMI_CHANNEL_9;
373 		break;
374 	case 10:
375 		*wmi_ch = WMI_CHANNEL_10;
376 		break;
377 	case 11:
378 		*wmi_ch = WMI_CHANNEL_11;
379 		break;
380 	case 12:
381 		*wmi_ch = WMI_CHANNEL_12;
382 		break;
383 	default:
384 		return -EINVAL;
385 	}
386 
387 	return 0;
388 }
389 
390 int wil_wmi2spec_ch(u8 wmi_ch, u8 *spec_ch)
391 {
392 	switch (wmi_ch) {
393 	case WMI_CHANNEL_1:
394 		*spec_ch = 1;
395 		break;
396 	case WMI_CHANNEL_2:
397 		*spec_ch = 2;
398 		break;
399 	case WMI_CHANNEL_3:
400 		*spec_ch = 3;
401 		break;
402 	case WMI_CHANNEL_4:
403 		*spec_ch = 4;
404 		break;
405 	case WMI_CHANNEL_5:
406 		*spec_ch = 5;
407 		break;
408 	case WMI_CHANNEL_6:
409 		*spec_ch = 6;
410 		break;
411 	case WMI_CHANNEL_9:
412 		*spec_ch = 9;
413 		break;
414 	case WMI_CHANNEL_10:
415 		*spec_ch = 10;
416 		break;
417 	case WMI_CHANNEL_11:
418 		*spec_ch = 11;
419 		break;
420 	case WMI_CHANNEL_12:
421 		*spec_ch = 12;
422 		break;
423 	default:
424 		return -EINVAL;
425 	}
426 
427 	return 0;
428 }
429 
430 int wil_cid_fill_sinfo(struct wil6210_vif *vif, int cid,
431 		       struct station_info *sinfo)
432 {
433 	struct wil6210_priv *wil = vif_to_wil(vif);
434 	struct wmi_notify_req_cmd cmd = {
435 		.cid = cid,
436 		.interval_usec = 0,
437 	};
438 	struct {
439 		struct wmi_cmd_hdr wmi;
440 		struct wmi_notify_req_done_event evt;
441 	} __packed reply;
442 	struct wil_net_stats *stats = &wil->sta[cid].stats;
443 	int rc;
444 	u8 tx_mcs, rx_mcs;
445 	u8 tx_rate_flag = RATE_INFO_FLAGS_DMG;
446 	u8 rx_rate_flag = RATE_INFO_FLAGS_DMG;
447 
448 	memset(&reply, 0, sizeof(reply));
449 
450 	rc = wmi_call(wil, WMI_NOTIFY_REQ_CMDID, vif->mid, &cmd, sizeof(cmd),
451 		      WMI_NOTIFY_REQ_DONE_EVENTID, &reply, sizeof(reply),
452 		      WIL_WMI_CALL_GENERAL_TO_MS);
453 	if (rc)
454 		return rc;
455 
456 	tx_mcs = le16_to_cpu(reply.evt.bf_mcs);
457 
458 	wil_dbg_wmi(wil, "Link status for CID %d MID %d: {\n"
459 		    "  MCS %s TSF 0x%016llx\n"
460 		    "  BF status 0x%08x RSSI %d SQI %d%%\n"
461 		    "  Tx Tpt %d goodput %d Rx goodput %d\n"
462 		    "  Sectors(rx:tx) my %d:%d peer %d:%d\n"
463 		    "  Tx mode %d}\n",
464 		    cid, vif->mid, WIL_EXTENDED_MCS_CHECK(tx_mcs),
465 		    le64_to_cpu(reply.evt.tsf), reply.evt.status,
466 		    reply.evt.rssi,
467 		    reply.evt.sqi,
468 		    le32_to_cpu(reply.evt.tx_tpt),
469 		    le32_to_cpu(reply.evt.tx_goodput),
470 		    le32_to_cpu(reply.evt.rx_goodput),
471 		    le16_to_cpu(reply.evt.my_rx_sector),
472 		    le16_to_cpu(reply.evt.my_tx_sector),
473 		    le16_to_cpu(reply.evt.other_rx_sector),
474 		    le16_to_cpu(reply.evt.other_tx_sector),
475 		    reply.evt.tx_mode);
476 
477 	sinfo->generation = wil->sinfo_gen;
478 
479 	sinfo->filled = BIT_ULL(NL80211_STA_INFO_RX_BYTES) |
480 			BIT_ULL(NL80211_STA_INFO_TX_BYTES) |
481 			BIT_ULL(NL80211_STA_INFO_RX_PACKETS) |
482 			BIT_ULL(NL80211_STA_INFO_TX_PACKETS) |
483 			BIT_ULL(NL80211_STA_INFO_RX_BITRATE) |
484 			BIT_ULL(NL80211_STA_INFO_TX_BITRATE) |
485 			BIT_ULL(NL80211_STA_INFO_RX_DROP_MISC) |
486 			BIT_ULL(NL80211_STA_INFO_TX_FAILED);
487 
488 	if (wil->use_enhanced_dma_hw && reply.evt.tx_mode != WMI_TX_MODE_DMG) {
489 		tx_rate_flag = RATE_INFO_FLAGS_EDMG;
490 		rx_rate_flag = RATE_INFO_FLAGS_EDMG;
491 	}
492 
493 	rx_mcs = stats->last_mcs_rx;
494 
495 	/* check extended MCS (12.1) and convert it into
496 	 * base MCS (7) + EXTENDED_SC_DMG flag
497 	 */
498 	if (tx_mcs == WIL_EXTENDED_MCS_26) {
499 		tx_rate_flag = RATE_INFO_FLAGS_EXTENDED_SC_DMG;
500 		tx_mcs = WIL_BASE_MCS_FOR_EXTENDED_26;
501 	}
502 	if (rx_mcs == WIL_EXTENDED_MCS_26) {
503 		rx_rate_flag = RATE_INFO_FLAGS_EXTENDED_SC_DMG;
504 		rx_mcs = WIL_BASE_MCS_FOR_EXTENDED_26;
505 	}
506 
507 	sinfo->txrate.flags = tx_rate_flag;
508 	sinfo->rxrate.flags = rx_rate_flag;
509 	sinfo->txrate.mcs = tx_mcs;
510 	sinfo->rxrate.mcs = rx_mcs;
511 
512 	sinfo->txrate.n_bonded_ch =
513 				  wil_tx_cb_mode_to_n_bonded(reply.evt.tx_mode);
514 	sinfo->rxrate.n_bonded_ch =
515 			     wil_rx_cb_mode_to_n_bonded(stats->last_cb_mode_rx);
516 	sinfo->rx_bytes = stats->rx_bytes;
517 	sinfo->rx_packets = stats->rx_packets;
518 	sinfo->rx_dropped_misc = stats->rx_dropped;
519 	sinfo->tx_bytes = stats->tx_bytes;
520 	sinfo->tx_packets = stats->tx_packets;
521 	sinfo->tx_failed = stats->tx_errors;
522 
523 	if (test_bit(wil_vif_fwconnected, vif->status)) {
524 		sinfo->filled |= BIT_ULL(NL80211_STA_INFO_SIGNAL);
525 		if (test_bit(WMI_FW_CAPABILITY_RSSI_REPORTING,
526 			     wil->fw_capabilities))
527 			sinfo->signal = reply.evt.rssi;
528 		else
529 			sinfo->signal = reply.evt.sqi;
530 	}
531 
532 	return rc;
533 }
534 
535 static int wil_cfg80211_get_station(struct wiphy *wiphy,
536 				    struct net_device *ndev,
537 				    const u8 *mac, struct station_info *sinfo)
538 {
539 	struct wil6210_vif *vif = ndev_to_vif(ndev);
540 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
541 	int rc;
542 
543 	int cid = wil_find_cid(wil, vif->mid, mac);
544 
545 	wil_dbg_misc(wil, "get_station: %pM CID %d MID %d\n", mac, cid,
546 		     vif->mid);
547 	if (!wil_cid_valid(wil, cid))
548 		return -ENOENT;
549 
550 	rc = wil_cid_fill_sinfo(vif, cid, sinfo);
551 
552 	return rc;
553 }
554 
555 /*
556  * Find @idx-th active STA for specific MID for station dump.
557  */
558 int wil_find_cid_by_idx(struct wil6210_priv *wil, u8 mid, int idx)
559 {
560 	int i;
561 
562 	for (i = 0; i < wil->max_assoc_sta; i++) {
563 		if (wil->sta[i].status == wil_sta_unused)
564 			continue;
565 		if (wil->sta[i].mid != mid)
566 			continue;
567 		if (idx == 0)
568 			return i;
569 		idx--;
570 	}
571 
572 	return -ENOENT;
573 }
574 
575 static int wil_cfg80211_dump_station(struct wiphy *wiphy,
576 				     struct net_device *dev, int idx,
577 				     u8 *mac, struct station_info *sinfo)
578 {
579 	struct wil6210_vif *vif = ndev_to_vif(dev);
580 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
581 	int rc;
582 	int cid = wil_find_cid_by_idx(wil, vif->mid, idx);
583 
584 	if (!wil_cid_valid(wil, cid))
585 		return -ENOENT;
586 
587 	ether_addr_copy(mac, wil->sta[cid].addr);
588 	wil_dbg_misc(wil, "dump_station: %pM CID %d MID %d\n", mac, cid,
589 		     vif->mid);
590 
591 	rc = wil_cid_fill_sinfo(vif, cid, sinfo);
592 
593 	return rc;
594 }
595 
596 static int wil_cfg80211_start_p2p_device(struct wiphy *wiphy,
597 					 struct wireless_dev *wdev)
598 {
599 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
600 
601 	wil_dbg_misc(wil, "start_p2p_device: entered\n");
602 	wil->p2p_dev_started = 1;
603 	return 0;
604 }
605 
606 static void wil_cfg80211_stop_p2p_device(struct wiphy *wiphy,
607 					 struct wireless_dev *wdev)
608 {
609 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
610 
611 	if (!wil->p2p_dev_started)
612 		return;
613 
614 	wil_dbg_misc(wil, "stop_p2p_device: entered\n");
615 	mutex_lock(&wil->mutex);
616 	mutex_lock(&wil->vif_mutex);
617 	wil_p2p_stop_radio_operations(wil);
618 	wil->p2p_dev_started = 0;
619 	mutex_unlock(&wil->vif_mutex);
620 	mutex_unlock(&wil->mutex);
621 }
622 
623 static int wil_cfg80211_validate_add_iface(struct wil6210_priv *wil,
624 					   enum nl80211_iftype new_type)
625 {
626 	int i;
627 	struct wireless_dev *wdev;
628 	struct iface_combination_params params = {
629 		.num_different_channels = 1,
630 	};
631 
632 	for (i = 0; i < GET_MAX_VIFS(wil); i++) {
633 		if (wil->vifs[i]) {
634 			wdev = vif_to_wdev(wil->vifs[i]);
635 			params.iftype_num[wdev->iftype]++;
636 		}
637 	}
638 	params.iftype_num[new_type]++;
639 	return cfg80211_check_combinations(wil->wiphy, &params);
640 }
641 
642 static int wil_cfg80211_validate_change_iface(struct wil6210_priv *wil,
643 					      struct wil6210_vif *vif,
644 					      enum nl80211_iftype new_type)
645 {
646 	int i, ret = 0;
647 	struct wireless_dev *wdev;
648 	struct iface_combination_params params = {
649 		.num_different_channels = 1,
650 	};
651 	bool check_combos = false;
652 
653 	for (i = 0; i < GET_MAX_VIFS(wil); i++) {
654 		struct wil6210_vif *vif_pos = wil->vifs[i];
655 
656 		if (vif_pos && vif != vif_pos) {
657 			wdev = vif_to_wdev(vif_pos);
658 			params.iftype_num[wdev->iftype]++;
659 			check_combos = true;
660 		}
661 	}
662 
663 	if (check_combos) {
664 		params.iftype_num[new_type]++;
665 		ret = cfg80211_check_combinations(wil->wiphy, &params);
666 	}
667 	return ret;
668 }
669 
670 static struct wireless_dev *
671 wil_cfg80211_add_iface(struct wiphy *wiphy, const char *name,
672 		       unsigned char name_assign_type,
673 		       enum nl80211_iftype type,
674 		       struct vif_params *params)
675 {
676 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
677 	struct net_device *ndev_main = wil->main_ndev, *ndev;
678 	struct wil6210_vif *vif;
679 	struct wireless_dev *p2p_wdev, *wdev;
680 	int rc;
681 
682 	wil_dbg_misc(wil, "add_iface, type %d\n", type);
683 
684 	/* P2P device is not a real virtual interface, it is a management-only
685 	 * interface that shares the main interface.
686 	 * Skip concurrency checks here.
687 	 */
688 	if (type == NL80211_IFTYPE_P2P_DEVICE) {
689 		if (wil->p2p_wdev) {
690 			wil_err(wil, "P2P_DEVICE interface already created\n");
691 			return ERR_PTR(-EINVAL);
692 		}
693 
694 		p2p_wdev = kzalloc(sizeof(*p2p_wdev), GFP_KERNEL);
695 		if (!p2p_wdev)
696 			return ERR_PTR(-ENOMEM);
697 
698 		p2p_wdev->iftype = type;
699 		p2p_wdev->wiphy = wiphy;
700 		/* use our primary ethernet address */
701 		ether_addr_copy(p2p_wdev->address, ndev_main->perm_addr);
702 
703 		wil->p2p_wdev = p2p_wdev;
704 
705 		return p2p_wdev;
706 	}
707 
708 	if (!wil->wiphy->n_iface_combinations) {
709 		wil_err(wil, "virtual interfaces not supported\n");
710 		return ERR_PTR(-EINVAL);
711 	}
712 
713 	rc = wil_cfg80211_validate_add_iface(wil, type);
714 	if (rc) {
715 		wil_err(wil, "iface validation failed, err=%d\n", rc);
716 		return ERR_PTR(rc);
717 	}
718 
719 	vif = wil_vif_alloc(wil, name, name_assign_type, type);
720 	if (IS_ERR(vif))
721 		return ERR_CAST(vif);
722 
723 	ndev = vif_to_ndev(vif);
724 	ether_addr_copy(ndev->perm_addr, ndev_main->perm_addr);
725 	if (is_valid_ether_addr(params->macaddr)) {
726 		eth_hw_addr_set(ndev, params->macaddr);
727 	} else {
728 		u8 addr[ETH_ALEN];
729 
730 		ether_addr_copy(addr, ndev_main->perm_addr);
731 		addr[0] = (addr[0] ^ (1 << vif->mid)) |	0x2; /* locally administered */
732 		eth_hw_addr_set(ndev, addr);
733 	}
734 	wdev = vif_to_wdev(vif);
735 	ether_addr_copy(wdev->address, ndev->dev_addr);
736 
737 	rc = wil_vif_add(wil, vif);
738 	if (rc)
739 		goto out;
740 
741 	wil_info(wil, "added VIF, mid %d iftype %d MAC %pM\n",
742 		 vif->mid, type, wdev->address);
743 	return wdev;
744 out:
745 	wil_vif_free(vif);
746 	return ERR_PTR(rc);
747 }
748 
749 int wil_vif_prepare_stop(struct wil6210_vif *vif)
750 {
751 	struct wil6210_priv *wil = vif_to_wil(vif);
752 	struct wireless_dev *wdev = vif_to_wdev(vif);
753 	struct net_device *ndev;
754 	int rc;
755 
756 	if (wdev->iftype != NL80211_IFTYPE_AP)
757 		return 0;
758 
759 	ndev = vif_to_ndev(vif);
760 	if (netif_carrier_ok(ndev)) {
761 		rc = wmi_pcp_stop(vif);
762 		if (rc) {
763 			wil_info(wil, "failed to stop AP, status %d\n",
764 				 rc);
765 			/* continue */
766 		}
767 		wil_bcast_fini(vif);
768 		netif_carrier_off(ndev);
769 	}
770 
771 	return 0;
772 }
773 
774 static int wil_cfg80211_del_iface(struct wiphy *wiphy,
775 				  struct wireless_dev *wdev)
776 {
777 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
778 	struct wil6210_vif *vif = wdev_to_vif(wil, wdev);
779 	int rc;
780 
781 	wil_dbg_misc(wil, "del_iface\n");
782 
783 	if (wdev->iftype == NL80211_IFTYPE_P2P_DEVICE) {
784 		if (wdev != wil->p2p_wdev) {
785 			wil_err(wil, "delete of incorrect interface 0x%p\n",
786 				wdev);
787 			return -EINVAL;
788 		}
789 
790 		wil_cfg80211_stop_p2p_device(wiphy, wdev);
791 		wil_p2p_wdev_free(wil);
792 		return 0;
793 	}
794 
795 	if (vif->mid == 0) {
796 		wil_err(wil, "cannot remove the main interface\n");
797 		return -EINVAL;
798 	}
799 
800 	rc = wil_vif_prepare_stop(vif);
801 	if (rc)
802 		goto out;
803 
804 	wil_info(wil, "deleted VIF, mid %d iftype %d MAC %pM\n",
805 		 vif->mid, wdev->iftype, wdev->address);
806 
807 	wil_vif_remove(wil, vif->mid);
808 out:
809 	return rc;
810 }
811 
812 static bool wil_is_safe_switch(enum nl80211_iftype from,
813 			       enum nl80211_iftype to)
814 {
815 	if (from == NL80211_IFTYPE_STATION &&
816 	    to == NL80211_IFTYPE_P2P_CLIENT)
817 		return true;
818 
819 	return false;
820 }
821 
822 static int wil_cfg80211_change_iface(struct wiphy *wiphy,
823 				     struct net_device *ndev,
824 				     enum nl80211_iftype type,
825 				     struct vif_params *params)
826 {
827 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
828 	struct wil6210_vif *vif = ndev_to_vif(ndev);
829 	struct wireless_dev *wdev = vif_to_wdev(vif);
830 	int rc;
831 	bool fw_reset = false;
832 
833 	wil_dbg_misc(wil, "change_iface: type=%d\n", type);
834 
835 	if (wiphy->n_iface_combinations) {
836 		rc = wil_cfg80211_validate_change_iface(wil, vif, type);
837 		if (rc) {
838 			wil_err(wil, "iface validation failed, err=%d\n", rc);
839 			return rc;
840 		}
841 	}
842 
843 	/* do not reset FW when there are active VIFs,
844 	 * because it can cause significant disruption
845 	 */
846 	if (!wil_has_other_active_ifaces(wil, ndev, true, false) &&
847 	    netif_running(ndev) && !wil_is_recovery_blocked(wil) &&
848 	    !wil_is_safe_switch(wdev->iftype, type)) {
849 		wil_dbg_misc(wil, "interface is up. resetting...\n");
850 		mutex_lock(&wil->mutex);
851 		__wil_down(wil);
852 		rc = __wil_up(wil);
853 		mutex_unlock(&wil->mutex);
854 
855 		if (rc)
856 			return rc;
857 		fw_reset = true;
858 	}
859 
860 	switch (type) {
861 	case NL80211_IFTYPE_STATION:
862 	case NL80211_IFTYPE_AP:
863 	case NL80211_IFTYPE_P2P_CLIENT:
864 	case NL80211_IFTYPE_P2P_GO:
865 		break;
866 	case NL80211_IFTYPE_MONITOR:
867 		if (params->flags)
868 			wil->monitor_flags = params->flags;
869 		break;
870 	default:
871 		return -EOPNOTSUPP;
872 	}
873 
874 	if (vif->mid != 0 && wil_has_active_ifaces(wil, true, false)) {
875 		if (!fw_reset)
876 			wil_vif_prepare_stop(vif);
877 		rc = wmi_port_delete(wil, vif->mid);
878 		if (rc)
879 			return rc;
880 		rc = wmi_port_allocate(wil, vif->mid, ndev->dev_addr, type);
881 		if (rc)
882 			return rc;
883 	}
884 
885 	wdev->iftype = type;
886 	return 0;
887 }
888 
889 static int wil_cfg80211_scan(struct wiphy *wiphy,
890 			     struct cfg80211_scan_request *request)
891 {
892 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
893 	struct wireless_dev *wdev = request->wdev;
894 	struct wil6210_vif *vif = wdev_to_vif(wil, wdev);
895 	DEFINE_FLEX(struct wmi_start_scan_cmd, cmd,
896 		    channel_list, num_channels, 4);
897 	uint i, n;
898 	int rc;
899 
900 	wil_dbg_misc(wil, "scan: wdev=0x%p iftype=%d\n", wdev, wdev->iftype);
901 
902 	/* scan is supported on client interfaces and on AP interface */
903 	switch (wdev->iftype) {
904 	case NL80211_IFTYPE_STATION:
905 	case NL80211_IFTYPE_P2P_CLIENT:
906 	case NL80211_IFTYPE_P2P_DEVICE:
907 	case NL80211_IFTYPE_AP:
908 		break;
909 	default:
910 		return -EOPNOTSUPP;
911 	}
912 
913 	/* FW don't support scan after connection attempt */
914 	if (test_bit(wil_status_dontscan, wil->status)) {
915 		wil_err(wil, "Can't scan now\n");
916 		return -EBUSY;
917 	}
918 
919 	mutex_lock(&wil->mutex);
920 
921 	mutex_lock(&wil->vif_mutex);
922 	if (vif->scan_request || vif->p2p.discovery_started) {
923 		wil_err(wil, "Already scanning\n");
924 		mutex_unlock(&wil->vif_mutex);
925 		rc = -EAGAIN;
926 		goto out;
927 	}
928 	mutex_unlock(&wil->vif_mutex);
929 
930 	if (wdev->iftype == NL80211_IFTYPE_P2P_DEVICE) {
931 		if (!wil->p2p_dev_started) {
932 			wil_err(wil, "P2P search requested on stopped P2P device\n");
933 			rc = -EIO;
934 			goto out;
935 		}
936 		/* social scan on P2P_DEVICE is handled as p2p search */
937 		if (wil_p2p_is_social_scan(request)) {
938 			vif->scan_request = request;
939 			if (vif->mid == 0)
940 				wil->radio_wdev = wdev;
941 			rc = wil_p2p_search(vif, request);
942 			if (rc) {
943 				if (vif->mid == 0)
944 					wil->radio_wdev =
945 						wil->main_ndev->ieee80211_ptr;
946 				vif->scan_request = NULL;
947 			}
948 			goto out;
949 		}
950 	}
951 
952 	(void)wil_p2p_stop_discovery(vif);
953 
954 	wil_dbg_misc(wil, "Start scan_request 0x%p\n", request);
955 	wil_dbg_misc(wil, "SSID count: %d", request->n_ssids);
956 
957 	for (i = 0; i < request->n_ssids; i++) {
958 		wil_dbg_misc(wil, "SSID[%d]", i);
959 		wil_hex_dump_misc("SSID ", DUMP_PREFIX_OFFSET, 16, 1,
960 				  request->ssids[i].ssid,
961 				  request->ssids[i].ssid_len, true);
962 	}
963 
964 	if (request->n_ssids)
965 		rc = wmi_set_ssid(vif, request->ssids[0].ssid_len,
966 				  request->ssids[0].ssid);
967 	else
968 		rc = wmi_set_ssid(vif, 0, NULL);
969 
970 	if (rc) {
971 		wil_err(wil, "set SSID for scan request failed: %d\n", rc);
972 		goto out;
973 	}
974 
975 	vif->scan_request = request;
976 	mod_timer(&vif->scan_timer, jiffies + WIL6210_SCAN_TO);
977 
978 	cmd->scan_type = WMI_ACTIVE_SCAN;
979 	cmd->num_channels = 0;
980 	n = min(request->n_channels, 4U);
981 	for (i = 0; i < n; i++) {
982 		int ch = request->channels[i]->hw_value;
983 
984 		if (ch == 0) {
985 			wil_err(wil,
986 				"Scan requested for unknown frequency %dMhz\n",
987 				request->channels[i]->center_freq);
988 			continue;
989 		}
990 		/* 0-based channel indexes */
991 		cmd->num_channels++;
992 		cmd->channel_list[cmd->num_channels - 1].channel = ch - 1;
993 		wil_dbg_misc(wil, "Scan for ch %d  : %d MHz\n", ch,
994 			     request->channels[i]->center_freq);
995 	}
996 
997 	if (request->ie_len)
998 		wil_hex_dump_misc("Scan IE ", DUMP_PREFIX_OFFSET, 16, 1,
999 				  request->ie, request->ie_len, true);
1000 	else
1001 		wil_dbg_misc(wil, "Scan has no IE's\n");
1002 
1003 	rc = wmi_set_ie(vif, WMI_FRAME_PROBE_REQ,
1004 			request->ie_len, request->ie);
1005 	if (rc)
1006 		goto out_restore;
1007 
1008 	if (wil->discovery_mode && cmd->scan_type == WMI_ACTIVE_SCAN) {
1009 		cmd->discovery_mode = 1;
1010 		wil_dbg_misc(wil, "active scan with discovery_mode=1\n");
1011 	}
1012 
1013 	if (vif->mid == 0)
1014 		wil->radio_wdev = wdev;
1015 	rc = wmi_send(wil, WMI_START_SCAN_CMDID, vif->mid,
1016 		      cmd, struct_size(cmd, channel_list, cmd->num_channels));
1017 
1018 out_restore:
1019 	if (rc) {
1020 		del_timer_sync(&vif->scan_timer);
1021 		if (vif->mid == 0)
1022 			wil->radio_wdev = wil->main_ndev->ieee80211_ptr;
1023 		vif->scan_request = NULL;
1024 	}
1025 out:
1026 	mutex_unlock(&wil->mutex);
1027 	return rc;
1028 }
1029 
1030 static void wil_cfg80211_abort_scan(struct wiphy *wiphy,
1031 				    struct wireless_dev *wdev)
1032 {
1033 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
1034 	struct wil6210_vif *vif = wdev_to_vif(wil, wdev);
1035 
1036 	wil_dbg_misc(wil, "wdev=0x%p iftype=%d\n", wdev, wdev->iftype);
1037 
1038 	mutex_lock(&wil->mutex);
1039 	mutex_lock(&wil->vif_mutex);
1040 
1041 	if (!vif->scan_request)
1042 		goto out;
1043 
1044 	if (wdev != vif->scan_request->wdev) {
1045 		wil_dbg_misc(wil, "abort scan was called on the wrong iface\n");
1046 		goto out;
1047 	}
1048 
1049 	if (wdev == wil->p2p_wdev && wil->radio_wdev == wil->p2p_wdev)
1050 		wil_p2p_stop_radio_operations(wil);
1051 	else
1052 		wil_abort_scan(vif, true);
1053 
1054 out:
1055 	mutex_unlock(&wil->vif_mutex);
1056 	mutex_unlock(&wil->mutex);
1057 }
1058 
1059 static void wil_print_crypto(struct wil6210_priv *wil,
1060 			     struct cfg80211_crypto_settings *c)
1061 {
1062 	int i, n;
1063 
1064 	wil_dbg_misc(wil, "WPA versions: 0x%08x cipher group 0x%08x\n",
1065 		     c->wpa_versions, c->cipher_group);
1066 	wil_dbg_misc(wil, "Pairwise ciphers [%d] {\n", c->n_ciphers_pairwise);
1067 	n = min_t(int, c->n_ciphers_pairwise, ARRAY_SIZE(c->ciphers_pairwise));
1068 	for (i = 0; i < n; i++)
1069 		wil_dbg_misc(wil, "  [%d] = 0x%08x\n", i,
1070 			     c->ciphers_pairwise[i]);
1071 	wil_dbg_misc(wil, "}\n");
1072 	wil_dbg_misc(wil, "AKM suites [%d] {\n", c->n_akm_suites);
1073 	n = min_t(int, c->n_akm_suites, ARRAY_SIZE(c->akm_suites));
1074 	for (i = 0; i < n; i++)
1075 		wil_dbg_misc(wil, "  [%d] = 0x%08x\n", i,
1076 			     c->akm_suites[i]);
1077 	wil_dbg_misc(wil, "}\n");
1078 	wil_dbg_misc(wil, "Control port : %d, eth_type 0x%04x no_encrypt %d\n",
1079 		     c->control_port, be16_to_cpu(c->control_port_ethertype),
1080 		     c->control_port_no_encrypt);
1081 }
1082 
1083 static const char *
1084 wil_get_auth_type_name(enum nl80211_auth_type auth_type)
1085 {
1086 	switch (auth_type) {
1087 	case NL80211_AUTHTYPE_OPEN_SYSTEM:
1088 		return "OPEN_SYSTEM";
1089 	case NL80211_AUTHTYPE_SHARED_KEY:
1090 		return "SHARED_KEY";
1091 	case NL80211_AUTHTYPE_FT:
1092 		return "FT";
1093 	case NL80211_AUTHTYPE_NETWORK_EAP:
1094 		return "NETWORK_EAP";
1095 	case NL80211_AUTHTYPE_SAE:
1096 		return "SAE";
1097 	case NL80211_AUTHTYPE_AUTOMATIC:
1098 		return "AUTOMATIC";
1099 	default:
1100 		return "unknown";
1101 	}
1102 }
1103 static void wil_print_connect_params(struct wil6210_priv *wil,
1104 				     struct cfg80211_connect_params *sme)
1105 {
1106 	wil_info(wil, "Connecting to:\n");
1107 	if (sme->channel) {
1108 		wil_info(wil, "  Channel: %d freq %d\n",
1109 			 sme->channel->hw_value, sme->channel->center_freq);
1110 	}
1111 	if (sme->bssid)
1112 		wil_info(wil, "  BSSID: %pM\n", sme->bssid);
1113 	if (sme->ssid)
1114 		print_hex_dump(KERN_INFO, "  SSID: ", DUMP_PREFIX_OFFSET,
1115 			       16, 1, sme->ssid, sme->ssid_len, true);
1116 	if (sme->prev_bssid)
1117 		wil_info(wil, "  Previous BSSID=%pM\n", sme->prev_bssid);
1118 	wil_info(wil, "  Auth Type: %s\n",
1119 		 wil_get_auth_type_name(sme->auth_type));
1120 	wil_info(wil, "  Privacy: %s\n", sme->privacy ? "secure" : "open");
1121 	wil_info(wil, "  PBSS: %d\n", sme->pbss);
1122 	wil_print_crypto(wil, &sme->crypto);
1123 }
1124 
1125 static int wil_ft_connect(struct wiphy *wiphy,
1126 			  struct net_device *ndev,
1127 			  struct cfg80211_connect_params *sme)
1128 {
1129 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
1130 	struct wil6210_vif *vif = ndev_to_vif(ndev);
1131 	struct wmi_ft_auth_cmd auth_cmd;
1132 	int rc;
1133 
1134 	if (!test_bit(WMI_FW_CAPABILITY_FT_ROAMING, wil->fw_capabilities)) {
1135 		wil_err(wil, "FT: FW does not support FT roaming\n");
1136 		return -EOPNOTSUPP;
1137 	}
1138 
1139 	if (!sme->prev_bssid) {
1140 		wil_err(wil, "FT: prev_bssid was not set\n");
1141 		return -EINVAL;
1142 	}
1143 
1144 	if (ether_addr_equal(sme->prev_bssid, sme->bssid)) {
1145 		wil_err(wil, "FT: can not roam to same AP\n");
1146 		return -EINVAL;
1147 	}
1148 
1149 	if (!test_bit(wil_vif_fwconnected, vif->status)) {
1150 		wil_err(wil, "FT: roam while not connected\n");
1151 		return -EINVAL;
1152 	}
1153 
1154 	if (vif->privacy != sme->privacy) {
1155 		wil_err(wil, "FT: privacy mismatch, current (%d) roam (%d)\n",
1156 			vif->privacy, sme->privacy);
1157 		return -EINVAL;
1158 	}
1159 
1160 	if (sme->pbss) {
1161 		wil_err(wil, "FT: roam is not valid for PBSS\n");
1162 		return -EINVAL;
1163 	}
1164 
1165 	memset(&auth_cmd, 0, sizeof(auth_cmd));
1166 	auth_cmd.channel = sme->channel->hw_value - 1;
1167 	ether_addr_copy(auth_cmd.bssid, sme->bssid);
1168 
1169 	wil_info(wil, "FT: roaming\n");
1170 
1171 	set_bit(wil_vif_ft_roam, vif->status);
1172 	rc = wmi_send(wil, WMI_FT_AUTH_CMDID, vif->mid,
1173 		      &auth_cmd, sizeof(auth_cmd));
1174 	if (rc == 0)
1175 		mod_timer(&vif->connect_timer,
1176 			  jiffies + msecs_to_jiffies(5000));
1177 	else
1178 		clear_bit(wil_vif_ft_roam, vif->status);
1179 
1180 	return rc;
1181 }
1182 
1183 static int wil_get_wmi_edmg_channel(struct wil6210_priv *wil, u8 edmg_bw_config,
1184 				    u8 edmg_channels, u8 *wmi_ch)
1185 {
1186 	if (!edmg_bw_config) {
1187 		*wmi_ch = 0;
1188 		return 0;
1189 	} else if (edmg_bw_config == WIL_EDMG_BW_CONFIGURATION) {
1190 		/* convert from edmg channel bitmap into edmg channel number */
1191 		switch (edmg_channels) {
1192 		case WIL_EDMG_CHANNEL_9_SUBCHANNELS:
1193 			return wil_spec2wmi_ch(9, wmi_ch);
1194 		case WIL_EDMG_CHANNEL_10_SUBCHANNELS:
1195 			return wil_spec2wmi_ch(10, wmi_ch);
1196 		case WIL_EDMG_CHANNEL_11_SUBCHANNELS:
1197 			return wil_spec2wmi_ch(11, wmi_ch);
1198 		default:
1199 			wil_err(wil, "Unsupported edmg channel bitmap 0x%x\n",
1200 				edmg_channels);
1201 			return -EINVAL;
1202 		}
1203 	} else {
1204 		wil_err(wil, "Unsupported EDMG BW configuration %d\n",
1205 			edmg_bw_config);
1206 		return -EINVAL;
1207 	}
1208 }
1209 
1210 static int wil_cfg80211_connect(struct wiphy *wiphy,
1211 				struct net_device *ndev,
1212 				struct cfg80211_connect_params *sme)
1213 {
1214 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
1215 	struct wil6210_vif *vif = ndev_to_vif(ndev);
1216 	struct cfg80211_bss *bss;
1217 	struct wmi_connect_cmd conn;
1218 	const u8 *ssid_eid;
1219 	const u8 *rsn_eid;
1220 	int ch;
1221 	int rc = 0;
1222 	bool is_ft_roam = false;
1223 	u8 network_type;
1224 	enum ieee80211_bss_type bss_type = IEEE80211_BSS_TYPE_ESS;
1225 
1226 	wil_dbg_misc(wil, "connect, mid=%d\n", vif->mid);
1227 	wil_print_connect_params(wil, sme);
1228 
1229 	if (sme->auth_type == NL80211_AUTHTYPE_FT)
1230 		is_ft_roam = true;
1231 	if (sme->auth_type == NL80211_AUTHTYPE_AUTOMATIC &&
1232 	    test_bit(wil_vif_fwconnected, vif->status))
1233 		is_ft_roam = true;
1234 
1235 	if (!is_ft_roam)
1236 		if (test_bit(wil_vif_fwconnecting, vif->status) ||
1237 		    test_bit(wil_vif_fwconnected, vif->status))
1238 			return -EALREADY;
1239 
1240 	if (sme->ie_len > WMI_MAX_IE_LEN) {
1241 		wil_err(wil, "IE too large (%td bytes)\n", sme->ie_len);
1242 		return -ERANGE;
1243 	}
1244 
1245 	rsn_eid = sme->ie ?
1246 			cfg80211_find_ie(WLAN_EID_RSN, sme->ie, sme->ie_len) :
1247 			NULL;
1248 	if (sme->privacy && !rsn_eid) {
1249 		wil_info(wil, "WSC connection\n");
1250 		if (is_ft_roam) {
1251 			wil_err(wil, "No WSC with FT roam\n");
1252 			return -EINVAL;
1253 		}
1254 	}
1255 
1256 	if (sme->pbss)
1257 		bss_type = IEEE80211_BSS_TYPE_PBSS;
1258 
1259 	bss = cfg80211_get_bss(wiphy, sme->channel, sme->bssid,
1260 			       sme->ssid, sme->ssid_len,
1261 			       bss_type, IEEE80211_PRIVACY_ANY);
1262 	if (!bss) {
1263 		wil_err(wil, "Unable to find BSS\n");
1264 		return -ENOENT;
1265 	}
1266 
1267 	ssid_eid = ieee80211_bss_get_ie(bss, WLAN_EID_SSID);
1268 	if (!ssid_eid) {
1269 		wil_err(wil, "No SSID\n");
1270 		rc = -ENOENT;
1271 		goto out;
1272 	}
1273 	vif->privacy = sme->privacy;
1274 	vif->pbss = sme->pbss;
1275 
1276 	rc = wmi_set_ie(vif, WMI_FRAME_ASSOC_REQ, sme->ie_len, sme->ie);
1277 	if (rc)
1278 		goto out;
1279 
1280 	switch (bss->capability & WLAN_CAPABILITY_DMG_TYPE_MASK) {
1281 	case WLAN_CAPABILITY_DMG_TYPE_AP:
1282 		network_type = WMI_NETTYPE_INFRA;
1283 		break;
1284 	case WLAN_CAPABILITY_DMG_TYPE_PBSS:
1285 		network_type = WMI_NETTYPE_P2P;
1286 		break;
1287 	default:
1288 		wil_err(wil, "Unsupported BSS type, capability= 0x%04x\n",
1289 			bss->capability);
1290 		rc = -EINVAL;
1291 		goto out;
1292 	}
1293 
1294 	ch = bss->channel->hw_value;
1295 	if (ch == 0) {
1296 		wil_err(wil, "BSS at unknown frequency %dMhz\n",
1297 			bss->channel->center_freq);
1298 		rc = -EOPNOTSUPP;
1299 		goto out;
1300 	}
1301 
1302 	if (is_ft_roam) {
1303 		if (network_type != WMI_NETTYPE_INFRA) {
1304 			wil_err(wil, "FT: Unsupported BSS type, capability= 0x%04x\n",
1305 				bss->capability);
1306 			rc = -EINVAL;
1307 			goto out;
1308 		}
1309 		rc = wil_ft_connect(wiphy, ndev, sme);
1310 		if (rc == 0)
1311 			vif->bss = bss;
1312 		goto out;
1313 	}
1314 
1315 	if (vif->privacy) {
1316 		/* For secure assoc, remove old keys */
1317 		rc = wmi_del_cipher_key(vif, 0, bss->bssid,
1318 					WMI_KEY_USE_PAIRWISE);
1319 		if (rc) {
1320 			wil_err(wil, "WMI_DELETE_CIPHER_KEY_CMD(PTK) failed\n");
1321 			goto out;
1322 		}
1323 		rc = wmi_del_cipher_key(vif, 0, bss->bssid,
1324 					WMI_KEY_USE_RX_GROUP);
1325 		if (rc) {
1326 			wil_err(wil, "WMI_DELETE_CIPHER_KEY_CMD(GTK) failed\n");
1327 			goto out;
1328 		}
1329 	}
1330 
1331 	/* WMI_CONNECT_CMD */
1332 	memset(&conn, 0, sizeof(conn));
1333 	conn.network_type = network_type;
1334 	if (vif->privacy) {
1335 		if (rsn_eid) { /* regular secure connection */
1336 			conn.dot11_auth_mode = WMI_AUTH11_SHARED;
1337 			conn.auth_mode = WMI_AUTH_WPA2_PSK;
1338 			conn.pairwise_crypto_type = WMI_CRYPT_AES_GCMP;
1339 			conn.pairwise_crypto_len = 16;
1340 			conn.group_crypto_type = WMI_CRYPT_AES_GCMP;
1341 			conn.group_crypto_len = 16;
1342 		} else { /* WSC */
1343 			conn.dot11_auth_mode = WMI_AUTH11_WSC;
1344 			conn.auth_mode = WMI_AUTH_NONE;
1345 		}
1346 	} else { /* insecure connection */
1347 		conn.dot11_auth_mode = WMI_AUTH11_OPEN;
1348 		conn.auth_mode = WMI_AUTH_NONE;
1349 	}
1350 
1351 	conn.ssid_len = min_t(u8, ssid_eid[1], 32);
1352 	memcpy(conn.ssid, ssid_eid+2, conn.ssid_len);
1353 	conn.channel = ch - 1;
1354 
1355 	rc = wil_get_wmi_edmg_channel(wil, sme->edmg.bw_config,
1356 				      sme->edmg.channels, &conn.edmg_channel);
1357 	if (rc < 0)
1358 		return rc;
1359 
1360 	ether_addr_copy(conn.bssid, bss->bssid);
1361 	ether_addr_copy(conn.dst_mac, bss->bssid);
1362 
1363 	set_bit(wil_vif_fwconnecting, vif->status);
1364 
1365 	rc = wmi_send(wil, WMI_CONNECT_CMDID, vif->mid, &conn, sizeof(conn));
1366 	if (rc == 0) {
1367 		netif_carrier_on(ndev);
1368 		if (!wil_has_other_active_ifaces(wil, ndev, false, true))
1369 			wil6210_bus_request(wil, WIL_MAX_BUS_REQUEST_KBPS);
1370 		vif->bss = bss;
1371 		/* Connect can take lots of time */
1372 		mod_timer(&vif->connect_timer,
1373 			  jiffies + msecs_to_jiffies(5000));
1374 	} else {
1375 		clear_bit(wil_vif_fwconnecting, vif->status);
1376 	}
1377 
1378  out:
1379 	cfg80211_put_bss(wiphy, bss);
1380 
1381 	return rc;
1382 }
1383 
1384 static int wil_cfg80211_disconnect(struct wiphy *wiphy,
1385 				   struct net_device *ndev,
1386 				   u16 reason_code)
1387 {
1388 	int rc;
1389 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
1390 	struct wil6210_vif *vif = ndev_to_vif(ndev);
1391 
1392 	wil_dbg_misc(wil, "disconnect: reason=%d, mid=%d\n",
1393 		     reason_code, vif->mid);
1394 
1395 	if (!(test_bit(wil_vif_fwconnecting, vif->status) ||
1396 	      test_bit(wil_vif_fwconnected, vif->status))) {
1397 		wil_err(wil, "Disconnect was called while disconnected\n");
1398 		return 0;
1399 	}
1400 
1401 	vif->locally_generated_disc = true;
1402 	rc = wmi_call(wil, WMI_DISCONNECT_CMDID, vif->mid, NULL, 0,
1403 		      WMI_DISCONNECT_EVENTID, NULL, 0,
1404 		      WIL6210_DISCONNECT_TO_MS);
1405 	if (rc)
1406 		wil_err(wil, "disconnect error %d\n", rc);
1407 
1408 	return rc;
1409 }
1410 
1411 static int wil_cfg80211_set_wiphy_params(struct wiphy *wiphy, u32 changed)
1412 {
1413 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
1414 	int rc;
1415 
1416 	/* these parameters are explicitly not supported */
1417 	if (changed & (WIPHY_PARAM_RETRY_LONG |
1418 		       WIPHY_PARAM_FRAG_THRESHOLD |
1419 		       WIPHY_PARAM_RTS_THRESHOLD))
1420 		return -ENOTSUPP;
1421 
1422 	if (changed & WIPHY_PARAM_RETRY_SHORT) {
1423 		rc = wmi_set_mgmt_retry(wil, wiphy->retry_short);
1424 		if (rc)
1425 			return rc;
1426 	}
1427 
1428 	return 0;
1429 }
1430 
1431 int wil_cfg80211_mgmt_tx(struct wiphy *wiphy, struct wireless_dev *wdev,
1432 			 struct cfg80211_mgmt_tx_params *params,
1433 			 u64 *cookie)
1434 {
1435 	const u8 *buf = params->buf;
1436 	size_t len = params->len;
1437 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
1438 	struct wil6210_vif *vif = wdev_to_vif(wil, wdev);
1439 	int rc;
1440 	bool tx_status;
1441 
1442 	wil_dbg_misc(wil, "mgmt_tx: channel %d offchan %d, wait %d\n",
1443 		     params->chan ? params->chan->hw_value : -1,
1444 		     params->offchan,
1445 		     params->wait);
1446 
1447 	/* Note, currently we support the "wait" parameter only on AP mode.
1448 	 * In other modes, user-space must call remain_on_channel before
1449 	 * mgmt_tx or listen on a channel other than active one.
1450 	 */
1451 
1452 	if (params->chan && params->chan->hw_value == 0) {
1453 		wil_err(wil, "invalid channel\n");
1454 		return -EINVAL;
1455 	}
1456 
1457 	if (wdev->iftype != NL80211_IFTYPE_AP) {
1458 		wil_dbg_misc(wil,
1459 			     "send WMI_SW_TX_REQ_CMDID on non-AP interfaces\n");
1460 		rc = wmi_mgmt_tx(vif, buf, len);
1461 		goto out;
1462 	}
1463 
1464 	if (!params->chan || params->chan->hw_value == vif->channel) {
1465 		wil_dbg_misc(wil,
1466 			     "send WMI_SW_TX_REQ_CMDID for on-channel\n");
1467 		rc = wmi_mgmt_tx(vif, buf, len);
1468 		goto out;
1469 	}
1470 
1471 	if (params->offchan == 0) {
1472 		wil_err(wil,
1473 			"invalid channel params: current %d requested %d, off-channel not allowed\n",
1474 			vif->channel, params->chan->hw_value);
1475 		return -EBUSY;
1476 	}
1477 
1478 	/* use the wmi_mgmt_tx_ext only on AP mode and off-channel */
1479 	rc = wmi_mgmt_tx_ext(vif, buf, len, params->chan->hw_value,
1480 			     params->wait);
1481 
1482 out:
1483 	/* when the sent packet was not acked by receiver(ACK=0), rc will
1484 	 * be -EAGAIN. In this case this function needs to return success,
1485 	 * the ACK=0 will be reflected in tx_status.
1486 	 */
1487 	tx_status = (rc == 0);
1488 	rc = (rc == -EAGAIN) ? 0 : rc;
1489 	cfg80211_mgmt_tx_status(wdev, cookie ? *cookie : 0, buf, len,
1490 				tx_status, GFP_KERNEL);
1491 
1492 	return rc;
1493 }
1494 
1495 static int wil_cfg80211_set_channel(struct wiphy *wiphy,
1496 				    struct net_device *dev,
1497 				    struct cfg80211_chan_def *chandef)
1498 {
1499 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
1500 
1501 	wil->monitor_chandef = *chandef;
1502 
1503 	return 0;
1504 }
1505 
1506 static enum wmi_key_usage wil_detect_key_usage(struct wireless_dev *wdev,
1507 					       bool pairwise)
1508 {
1509 	struct wil6210_priv *wil = wdev_to_wil(wdev);
1510 	enum wmi_key_usage rc;
1511 
1512 	if (pairwise) {
1513 		rc = WMI_KEY_USE_PAIRWISE;
1514 	} else {
1515 		switch (wdev->iftype) {
1516 		case NL80211_IFTYPE_STATION:
1517 		case NL80211_IFTYPE_P2P_CLIENT:
1518 			rc = WMI_KEY_USE_RX_GROUP;
1519 			break;
1520 		case NL80211_IFTYPE_AP:
1521 		case NL80211_IFTYPE_P2P_GO:
1522 			rc = WMI_KEY_USE_TX_GROUP;
1523 			break;
1524 		default:
1525 			/* TODO: Rx GTK or Tx GTK? */
1526 			wil_err(wil, "Can't determine GTK type\n");
1527 			rc = WMI_KEY_USE_RX_GROUP;
1528 			break;
1529 		}
1530 	}
1531 	wil_dbg_misc(wil, "detect_key_usage: -> %s\n", key_usage_str[rc]);
1532 
1533 	return rc;
1534 }
1535 
1536 static struct wil_sta_info *
1537 wil_find_sta_by_key_usage(struct wil6210_priv *wil, u8 mid,
1538 			  enum wmi_key_usage key_usage, const u8 *mac_addr)
1539 {
1540 	int cid = -EINVAL;
1541 
1542 	if (key_usage == WMI_KEY_USE_TX_GROUP)
1543 		return NULL; /* not needed */
1544 
1545 	/* supplicant provides Rx group key in STA mode with NULL MAC address */
1546 	if (mac_addr)
1547 		cid = wil_find_cid(wil, mid, mac_addr);
1548 	else if (key_usage == WMI_KEY_USE_RX_GROUP)
1549 		cid = wil_find_cid_by_idx(wil, mid, 0);
1550 	if (cid < 0) {
1551 		wil_err(wil, "No CID for %pM %s\n", mac_addr,
1552 			key_usage_str[key_usage]);
1553 		return ERR_PTR(cid);
1554 	}
1555 
1556 	return &wil->sta[cid];
1557 }
1558 
1559 void wil_set_crypto_rx(u8 key_index, enum wmi_key_usage key_usage,
1560 		       struct wil_sta_info *cs,
1561 		       struct key_params *params)
1562 {
1563 	struct wil_tid_crypto_rx_single *cc;
1564 	int tid;
1565 
1566 	if (!cs)
1567 		return;
1568 
1569 	switch (key_usage) {
1570 	case WMI_KEY_USE_STORE_PTK:
1571 	case WMI_KEY_USE_PAIRWISE:
1572 		for (tid = 0; tid < WIL_STA_TID_NUM; tid++) {
1573 			cc = &cs->tid_crypto_rx[tid].key_id[key_index];
1574 			if (params->seq)
1575 				memcpy(cc->pn, params->seq,
1576 				       IEEE80211_GCMP_PN_LEN);
1577 			else
1578 				memset(cc->pn, 0, IEEE80211_GCMP_PN_LEN);
1579 			cc->key_set = true;
1580 		}
1581 		break;
1582 	case WMI_KEY_USE_RX_GROUP:
1583 		cc = &cs->group_crypto_rx.key_id[key_index];
1584 		if (params->seq)
1585 			memcpy(cc->pn, params->seq, IEEE80211_GCMP_PN_LEN);
1586 		else
1587 			memset(cc->pn, 0, IEEE80211_GCMP_PN_LEN);
1588 		cc->key_set = true;
1589 		break;
1590 	default:
1591 		break;
1592 	}
1593 }
1594 
1595 static void wil_del_rx_key(u8 key_index, enum wmi_key_usage key_usage,
1596 			   struct wil_sta_info *cs)
1597 {
1598 	struct wil_tid_crypto_rx_single *cc;
1599 	int tid;
1600 
1601 	if (!cs)
1602 		return;
1603 
1604 	switch (key_usage) {
1605 	case WMI_KEY_USE_PAIRWISE:
1606 		for (tid = 0; tid < WIL_STA_TID_NUM; tid++) {
1607 			cc = &cs->tid_crypto_rx[tid].key_id[key_index];
1608 			cc->key_set = false;
1609 		}
1610 		break;
1611 	case WMI_KEY_USE_RX_GROUP:
1612 		cc = &cs->group_crypto_rx.key_id[key_index];
1613 		cc->key_set = false;
1614 		break;
1615 	default:
1616 		break;
1617 	}
1618 }
1619 
1620 static int wil_cfg80211_add_key(struct wiphy *wiphy,
1621 				struct net_device *ndev, int link_id,
1622 				u8 key_index, bool pairwise,
1623 				const u8 *mac_addr,
1624 				struct key_params *params)
1625 {
1626 	int rc;
1627 	struct wil6210_vif *vif = ndev_to_vif(ndev);
1628 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
1629 	struct wireless_dev *wdev = vif_to_wdev(vif);
1630 	enum wmi_key_usage key_usage = wil_detect_key_usage(wdev, pairwise);
1631 	struct wil_sta_info *cs = wil_find_sta_by_key_usage(wil, vif->mid,
1632 							    key_usage,
1633 							    mac_addr);
1634 
1635 	if (!params) {
1636 		wil_err(wil, "NULL params\n");
1637 		return -EINVAL;
1638 	}
1639 
1640 	wil_dbg_misc(wil, "add_key: %pM %s[%d] PN %*phN\n",
1641 		     mac_addr, key_usage_str[key_usage], key_index,
1642 		     params->seq_len, params->seq);
1643 
1644 	if (IS_ERR(cs)) {
1645 		/* in FT, sta info may not be available as add_key may be
1646 		 * sent by host before FW sends WMI_CONNECT_EVENT
1647 		 */
1648 		if (!test_bit(wil_vif_ft_roam, vif->status)) {
1649 			wil_err(wil, "Not connected, %pM %s[%d] PN %*phN\n",
1650 				mac_addr, key_usage_str[key_usage], key_index,
1651 				params->seq_len, params->seq);
1652 			return -EINVAL;
1653 		}
1654 	} else {
1655 		wil_del_rx_key(key_index, key_usage, cs);
1656 	}
1657 
1658 	if (params->seq && params->seq_len != IEEE80211_GCMP_PN_LEN) {
1659 		wil_err(wil,
1660 			"Wrong PN len %d, %pM %s[%d] PN %*phN\n",
1661 			params->seq_len, mac_addr,
1662 			key_usage_str[key_usage], key_index,
1663 			params->seq_len, params->seq);
1664 		return -EINVAL;
1665 	}
1666 
1667 	spin_lock_bh(&wil->eap_lock);
1668 	if (pairwise && wdev->iftype == NL80211_IFTYPE_STATION &&
1669 	    (vif->ptk_rekey_state == WIL_REKEY_M3_RECEIVED ||
1670 	     vif->ptk_rekey_state == WIL_REKEY_WAIT_M4_SENT)) {
1671 		key_usage = WMI_KEY_USE_STORE_PTK;
1672 		vif->ptk_rekey_state = WIL_REKEY_WAIT_M4_SENT;
1673 		wil_dbg_misc(wil, "Store EAPOL key\n");
1674 	}
1675 	spin_unlock_bh(&wil->eap_lock);
1676 
1677 	rc = wmi_add_cipher_key(vif, key_index, mac_addr, params->key_len,
1678 				params->key, key_usage);
1679 	if (!rc && !IS_ERR(cs)) {
1680 		/* update local storage used for AP recovery */
1681 		if (key_usage == WMI_KEY_USE_TX_GROUP && params->key &&
1682 		    params->key_len <= WMI_MAX_KEY_LEN) {
1683 			vif->gtk_index = key_index;
1684 			memcpy(vif->gtk, params->key, params->key_len);
1685 			vif->gtk_len = params->key_len;
1686 		}
1687 		/* in FT set crypto will take place upon receiving
1688 		 * WMI_RING_EN_EVENTID event
1689 		 */
1690 		wil_set_crypto_rx(key_index, key_usage, cs, params);
1691 	}
1692 
1693 	return rc;
1694 }
1695 
1696 static int wil_cfg80211_del_key(struct wiphy *wiphy,
1697 				struct net_device *ndev, int link_id,
1698 				u8 key_index, bool pairwise,
1699 				const u8 *mac_addr)
1700 {
1701 	struct wil6210_vif *vif = ndev_to_vif(ndev);
1702 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
1703 	struct wireless_dev *wdev = vif_to_wdev(vif);
1704 	enum wmi_key_usage key_usage = wil_detect_key_usage(wdev, pairwise);
1705 	struct wil_sta_info *cs = wil_find_sta_by_key_usage(wil, vif->mid,
1706 							    key_usage,
1707 							    mac_addr);
1708 
1709 	wil_dbg_misc(wil, "del_key: %pM %s[%d]\n", mac_addr,
1710 		     key_usage_str[key_usage], key_index);
1711 
1712 	if (IS_ERR(cs))
1713 		wil_info(wil, "Not connected, %pM %s[%d]\n",
1714 			 mac_addr, key_usage_str[key_usage], key_index);
1715 
1716 	if (!IS_ERR_OR_NULL(cs))
1717 		wil_del_rx_key(key_index, key_usage, cs);
1718 
1719 	return wmi_del_cipher_key(vif, key_index, mac_addr, key_usage);
1720 }
1721 
1722 /* Need to be present or wiphy_new() will WARN */
1723 static int wil_cfg80211_set_default_key(struct wiphy *wiphy,
1724 					struct net_device *ndev, int link_id,
1725 					u8 key_index, bool unicast,
1726 					bool multicast)
1727 {
1728 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
1729 
1730 	wil_dbg_misc(wil, "set_default_key: entered\n");
1731 	return 0;
1732 }
1733 
1734 static int wil_remain_on_channel(struct wiphy *wiphy,
1735 				 struct wireless_dev *wdev,
1736 				 struct ieee80211_channel *chan,
1737 				 unsigned int duration,
1738 				 u64 *cookie)
1739 {
1740 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
1741 	int rc;
1742 
1743 	wil_dbg_misc(wil,
1744 		     "remain_on_channel: center_freq=%d, duration=%d iftype=%d\n",
1745 		     chan->center_freq, duration, wdev->iftype);
1746 
1747 	rc = wil_p2p_listen(wil, wdev, duration, chan, cookie);
1748 	return rc;
1749 }
1750 
1751 static int wil_cancel_remain_on_channel(struct wiphy *wiphy,
1752 					struct wireless_dev *wdev,
1753 					u64 cookie)
1754 {
1755 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
1756 	struct wil6210_vif *vif = wdev_to_vif(wil, wdev);
1757 
1758 	wil_dbg_misc(wil, "cancel_remain_on_channel\n");
1759 
1760 	return wil_p2p_cancel_listen(vif, cookie);
1761 }
1762 
1763 /*
1764  * find a specific IE in a list of IEs
1765  * return a pointer to the beginning of IE in the list
1766  * or NULL if not found
1767  */
1768 static const u8 *_wil_cfg80211_find_ie(const u8 *ies, u16 ies_len, const u8 *ie,
1769 				       u16 ie_len)
1770 {
1771 	struct ieee80211_vendor_ie *vie;
1772 	u32 oui;
1773 
1774 	/* IE tag at offset 0, length at offset 1 */
1775 	if (ie_len < 2 || 2 + ie[1] > ie_len)
1776 		return NULL;
1777 
1778 	if (ie[0] != WLAN_EID_VENDOR_SPECIFIC)
1779 		return cfg80211_find_ie(ie[0], ies, ies_len);
1780 
1781 	/* make sure there is room for 3 bytes OUI + 1 byte OUI type */
1782 	if (ie[1] < 4)
1783 		return NULL;
1784 	vie = (struct ieee80211_vendor_ie *)ie;
1785 	oui = vie->oui[0] << 16 | vie->oui[1] << 8 | vie->oui[2];
1786 	return cfg80211_find_vendor_ie(oui, vie->oui_type, ies,
1787 				       ies_len);
1788 }
1789 
1790 /*
1791  * merge the IEs in two lists into a single list.
1792  * do not include IEs from the second list which exist in the first list.
1793  * add only vendor specific IEs from second list to keep
1794  * the merged list sorted (since vendor-specific IE has the
1795  * highest tag number)
1796  * caller must free the allocated memory for merged IEs
1797  */
1798 static int _wil_cfg80211_merge_extra_ies(const u8 *ies1, u16 ies1_len,
1799 					 const u8 *ies2, u16 ies2_len,
1800 					 u8 **merged_ies, u16 *merged_len)
1801 {
1802 	u8 *buf, *dpos;
1803 	const u8 *spos;
1804 
1805 	if (!ies1)
1806 		ies1_len = 0;
1807 
1808 	if (!ies2)
1809 		ies2_len = 0;
1810 
1811 	if (ies1_len == 0 && ies2_len == 0) {
1812 		*merged_ies = NULL;
1813 		*merged_len = 0;
1814 		return 0;
1815 	}
1816 
1817 	buf = kmalloc(ies1_len + ies2_len, GFP_KERNEL);
1818 	if (!buf)
1819 		return -ENOMEM;
1820 	if (ies1)
1821 		memcpy(buf, ies1, ies1_len);
1822 	dpos = buf + ies1_len;
1823 	spos = ies2;
1824 	while (spos && (spos + 1 < ies2 + ies2_len)) {
1825 		/* IE tag at offset 0, length at offset 1 */
1826 		u16 ielen = 2 + spos[1];
1827 
1828 		if (spos + ielen > ies2 + ies2_len)
1829 			break;
1830 		if (spos[0] == WLAN_EID_VENDOR_SPECIFIC &&
1831 		    (!ies1 || !_wil_cfg80211_find_ie(ies1, ies1_len,
1832 						     spos, ielen))) {
1833 			memcpy(dpos, spos, ielen);
1834 			dpos += ielen;
1835 		}
1836 		spos += ielen;
1837 	}
1838 
1839 	*merged_ies = buf;
1840 	*merged_len = dpos - buf;
1841 	return 0;
1842 }
1843 
1844 static void wil_print_bcon_data(struct cfg80211_beacon_data *b)
1845 {
1846 	wil_hex_dump_misc("head     ", DUMP_PREFIX_OFFSET, 16, 1,
1847 			  b->head, b->head_len, true);
1848 	wil_hex_dump_misc("tail     ", DUMP_PREFIX_OFFSET, 16, 1,
1849 			  b->tail, b->tail_len, true);
1850 	wil_hex_dump_misc("BCON IE  ", DUMP_PREFIX_OFFSET, 16, 1,
1851 			  b->beacon_ies, b->beacon_ies_len, true);
1852 	wil_hex_dump_misc("PROBE    ", DUMP_PREFIX_OFFSET, 16, 1,
1853 			  b->probe_resp, b->probe_resp_len, true);
1854 	wil_hex_dump_misc("PROBE IE ", DUMP_PREFIX_OFFSET, 16, 1,
1855 			  b->proberesp_ies, b->proberesp_ies_len, true);
1856 	wil_hex_dump_misc("ASSOC IE ", DUMP_PREFIX_OFFSET, 16, 1,
1857 			  b->assocresp_ies, b->assocresp_ies_len, true);
1858 }
1859 
1860 /* internal functions for device reset and starting AP */
1861 static u8 *
1862 _wil_cfg80211_get_proberesp_ies(const u8 *proberesp, u16 proberesp_len,
1863 				u16 *ies_len)
1864 {
1865 	u8 *ies = NULL;
1866 
1867 	if (proberesp) {
1868 		struct ieee80211_mgmt *f =
1869 			(struct ieee80211_mgmt *)proberesp;
1870 		size_t hlen = offsetof(struct ieee80211_mgmt,
1871 				       u.probe_resp.variable);
1872 
1873 		ies = f->u.probe_resp.variable;
1874 		if (ies_len)
1875 			*ies_len = proberesp_len - hlen;
1876 	}
1877 
1878 	return ies;
1879 }
1880 
1881 static int _wil_cfg80211_set_ies(struct wil6210_vif *vif,
1882 				 struct cfg80211_beacon_data *bcon)
1883 {
1884 	int rc;
1885 	u16 len = 0, proberesp_len = 0;
1886 	u8 *ies = NULL, *proberesp;
1887 
1888 	/* update local storage used for AP recovery */
1889 	wil_memdup_ie(&vif->proberesp, &vif->proberesp_len, bcon->probe_resp,
1890 		      bcon->probe_resp_len);
1891 	wil_memdup_ie(&vif->proberesp_ies, &vif->proberesp_ies_len,
1892 		      bcon->proberesp_ies, bcon->proberesp_ies_len);
1893 	wil_memdup_ie(&vif->assocresp_ies, &vif->assocresp_ies_len,
1894 		      bcon->assocresp_ies, bcon->assocresp_ies_len);
1895 
1896 	proberesp = _wil_cfg80211_get_proberesp_ies(bcon->probe_resp,
1897 						    bcon->probe_resp_len,
1898 						    &proberesp_len);
1899 	rc = _wil_cfg80211_merge_extra_ies(proberesp,
1900 					   proberesp_len,
1901 					   bcon->proberesp_ies,
1902 					   bcon->proberesp_ies_len,
1903 					   &ies, &len);
1904 
1905 	if (rc)
1906 		goto out;
1907 
1908 	rc = wmi_set_ie(vif, WMI_FRAME_PROBE_RESP, len, ies);
1909 	if (rc)
1910 		goto out;
1911 
1912 	if (bcon->assocresp_ies)
1913 		rc = wmi_set_ie(vif, WMI_FRAME_ASSOC_RESP,
1914 				bcon->assocresp_ies_len, bcon->assocresp_ies);
1915 	else
1916 		rc = wmi_set_ie(vif, WMI_FRAME_ASSOC_RESP, len, ies);
1917 #if 0 /* to use beacon IE's, remove this #if 0 */
1918 	if (rc)
1919 		goto out;
1920 
1921 	rc = wmi_set_ie(vif, WMI_FRAME_BEACON,
1922 			bcon->tail_len, bcon->tail);
1923 #endif
1924 out:
1925 	kfree(ies);
1926 	return rc;
1927 }
1928 
1929 static int _wil_cfg80211_start_ap(struct wiphy *wiphy,
1930 				  struct net_device *ndev,
1931 				  const u8 *ssid, size_t ssid_len, u32 privacy,
1932 				  int bi, u8 chan, u8 wmi_edmg_channel,
1933 				  struct cfg80211_beacon_data *bcon,
1934 				  u8 hidden_ssid, u32 pbss)
1935 {
1936 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
1937 	struct wil6210_vif *vif = ndev_to_vif(ndev);
1938 	int rc;
1939 	struct wireless_dev *wdev = ndev->ieee80211_ptr;
1940 	u8 wmi_nettype = wil_iftype_nl2wmi(wdev->iftype);
1941 	u8 is_go = (wdev->iftype == NL80211_IFTYPE_P2P_GO);
1942 	u16 proberesp_len = 0;
1943 	u8 *proberesp;
1944 	bool ft = false;
1945 
1946 	if (pbss)
1947 		wmi_nettype = WMI_NETTYPE_P2P;
1948 
1949 	wil_dbg_misc(wil, "start_ap: mid=%d, is_go=%d\n", vif->mid, is_go);
1950 	if (is_go && !pbss) {
1951 		wil_err(wil, "P2P GO must be in PBSS\n");
1952 		return -ENOTSUPP;
1953 	}
1954 
1955 	wil_set_recovery_state(wil, fw_recovery_idle);
1956 
1957 	proberesp = _wil_cfg80211_get_proberesp_ies(bcon->probe_resp,
1958 						    bcon->probe_resp_len,
1959 						    &proberesp_len);
1960 	/* check that the probe response IEs has a MDE */
1961 	if ((proberesp && proberesp_len > 0 &&
1962 	     cfg80211_find_ie(WLAN_EID_MOBILITY_DOMAIN,
1963 			      proberesp,
1964 			      proberesp_len)))
1965 		ft = true;
1966 
1967 	if (ft) {
1968 		if (!test_bit(WMI_FW_CAPABILITY_FT_ROAMING,
1969 			      wil->fw_capabilities)) {
1970 			wil_err(wil, "FW does not support FT roaming\n");
1971 			return -ENOTSUPP;
1972 		}
1973 		set_bit(wil_vif_ft_roam, vif->status);
1974 	}
1975 
1976 	mutex_lock(&wil->mutex);
1977 
1978 	if (!wil_has_other_active_ifaces(wil, ndev, true, false)) {
1979 		__wil_down(wil);
1980 		rc = __wil_up(wil);
1981 		if (rc)
1982 			goto out;
1983 	}
1984 
1985 	rc = wmi_set_ssid(vif, ssid_len, ssid);
1986 	if (rc)
1987 		goto out;
1988 
1989 	rc = _wil_cfg80211_set_ies(vif, bcon);
1990 	if (rc)
1991 		goto out;
1992 
1993 	vif->privacy = privacy;
1994 	vif->channel = chan;
1995 	vif->wmi_edmg_channel = wmi_edmg_channel;
1996 	vif->hidden_ssid = hidden_ssid;
1997 	vif->pbss = pbss;
1998 	vif->bi = bi;
1999 	memcpy(vif->ssid, ssid, ssid_len);
2000 	vif->ssid_len = ssid_len;
2001 
2002 	netif_carrier_on(ndev);
2003 	if (!wil_has_other_active_ifaces(wil, ndev, false, true))
2004 		wil6210_bus_request(wil, WIL_MAX_BUS_REQUEST_KBPS);
2005 
2006 	rc = wmi_pcp_start(vif, bi, wmi_nettype, chan, wmi_edmg_channel,
2007 			   hidden_ssid, is_go);
2008 	if (rc)
2009 		goto err_pcp_start;
2010 
2011 	rc = wil_bcast_init(vif);
2012 	if (rc)
2013 		goto err_bcast;
2014 
2015 	goto out; /* success */
2016 
2017 err_bcast:
2018 	wmi_pcp_stop(vif);
2019 err_pcp_start:
2020 	netif_carrier_off(ndev);
2021 	if (!wil_has_other_active_ifaces(wil, ndev, false, true))
2022 		wil6210_bus_request(wil, WIL_DEFAULT_BUS_REQUEST_KBPS);
2023 out:
2024 	mutex_unlock(&wil->mutex);
2025 	return rc;
2026 }
2027 
2028 void wil_cfg80211_ap_recovery(struct wil6210_priv *wil)
2029 {
2030 	int rc, i;
2031 	struct wiphy *wiphy = wil_to_wiphy(wil);
2032 
2033 	for (i = 0; i < GET_MAX_VIFS(wil); i++) {
2034 		struct wil6210_vif *vif = wil->vifs[i];
2035 		struct net_device *ndev;
2036 		struct cfg80211_beacon_data bcon = {};
2037 		struct key_params key_params = {};
2038 
2039 		if (!vif || vif->ssid_len == 0)
2040 			continue;
2041 
2042 		ndev = vif_to_ndev(vif);
2043 		bcon.proberesp_ies = vif->proberesp_ies;
2044 		bcon.assocresp_ies = vif->assocresp_ies;
2045 		bcon.probe_resp = vif->proberesp;
2046 		bcon.proberesp_ies_len = vif->proberesp_ies_len;
2047 		bcon.assocresp_ies_len = vif->assocresp_ies_len;
2048 		bcon.probe_resp_len = vif->proberesp_len;
2049 
2050 		wil_info(wil,
2051 			 "AP (vif %d) recovery: privacy %d, bi %d, channel %d, hidden %d, pbss %d\n",
2052 			 i, vif->privacy, vif->bi, vif->channel,
2053 			 vif->hidden_ssid, vif->pbss);
2054 		wil_hex_dump_misc("SSID ", DUMP_PREFIX_OFFSET, 16, 1,
2055 				  vif->ssid, vif->ssid_len, true);
2056 		rc = _wil_cfg80211_start_ap(wiphy, ndev,
2057 					    vif->ssid, vif->ssid_len,
2058 					    vif->privacy, vif->bi,
2059 					    vif->channel,
2060 					    vif->wmi_edmg_channel, &bcon,
2061 					    vif->hidden_ssid, vif->pbss);
2062 		if (rc) {
2063 			wil_err(wil, "vif %d recovery failed (%d)\n", i, rc);
2064 			continue;
2065 		}
2066 
2067 		if (!vif->privacy || vif->gtk_len == 0)
2068 			continue;
2069 
2070 		key_params.key = vif->gtk;
2071 		key_params.key_len = vif->gtk_len;
2072 		key_params.seq_len = IEEE80211_GCMP_PN_LEN;
2073 		rc = wil_cfg80211_add_key(wiphy, ndev, -1, vif->gtk_index,
2074 					  false, NULL, &key_params);
2075 		if (rc)
2076 			wil_err(wil, "vif %d recovery add key failed (%d)\n",
2077 				i, rc);
2078 	}
2079 }
2080 
2081 static int wil_cfg80211_change_beacon(struct wiphy *wiphy,
2082 				      struct net_device *ndev,
2083 				      struct cfg80211_ap_update *params)
2084 {
2085 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2086 	struct wireless_dev *wdev = ndev->ieee80211_ptr;
2087 	struct wil6210_vif *vif = ndev_to_vif(ndev);
2088 	struct cfg80211_beacon_data *bcon = &params->beacon;
2089 	int rc;
2090 	u32 privacy = 0;
2091 
2092 	wil_dbg_misc(wil, "change_beacon, mid=%d\n", vif->mid);
2093 	wil_print_bcon_data(bcon);
2094 
2095 	if (bcon->tail &&
2096 	    cfg80211_find_ie(WLAN_EID_RSN, bcon->tail,
2097 			     bcon->tail_len))
2098 		privacy = 1;
2099 
2100 	memcpy(vif->ssid, wdev->u.ap.ssid, wdev->u.ap.ssid_len);
2101 	vif->ssid_len = wdev->u.ap.ssid_len;
2102 
2103 	/* in case privacy has changed, need to restart the AP */
2104 	if (vif->privacy != privacy) {
2105 		wil_dbg_misc(wil, "privacy changed %d=>%d. Restarting AP\n",
2106 			     vif->privacy, privacy);
2107 
2108 		rc = _wil_cfg80211_start_ap(wiphy, ndev, vif->ssid,
2109 					    vif->ssid_len, privacy,
2110 					    wdev->links[0].ap.beacon_interval,
2111 					    vif->channel,
2112 					    vif->wmi_edmg_channel, bcon,
2113 					    vif->hidden_ssid,
2114 					    vif->pbss);
2115 	} else {
2116 		rc = _wil_cfg80211_set_ies(vif, bcon);
2117 	}
2118 
2119 	return rc;
2120 }
2121 
2122 static int wil_cfg80211_start_ap(struct wiphy *wiphy,
2123 				 struct net_device *ndev,
2124 				 struct cfg80211_ap_settings *info)
2125 {
2126 	int rc;
2127 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2128 	struct ieee80211_channel *channel = info->chandef.chan;
2129 	struct cfg80211_beacon_data *bcon = &info->beacon;
2130 	struct cfg80211_crypto_settings *crypto = &info->crypto;
2131 	u8 wmi_edmg_channel;
2132 	u8 hidden_ssid;
2133 
2134 	wil_dbg_misc(wil, "start_ap\n");
2135 
2136 	rc = wil_get_wmi_edmg_channel(wil, info->chandef.edmg.bw_config,
2137 				      info->chandef.edmg.channels,
2138 				      &wmi_edmg_channel);
2139 	if (rc < 0)
2140 		return rc;
2141 
2142 	if (!channel) {
2143 		wil_err(wil, "AP: No channel???\n");
2144 		return -EINVAL;
2145 	}
2146 
2147 	switch (info->hidden_ssid) {
2148 	case NL80211_HIDDEN_SSID_NOT_IN_USE:
2149 		hidden_ssid = WMI_HIDDEN_SSID_DISABLED;
2150 		break;
2151 
2152 	case NL80211_HIDDEN_SSID_ZERO_LEN:
2153 		hidden_ssid = WMI_HIDDEN_SSID_SEND_EMPTY;
2154 		break;
2155 
2156 	case NL80211_HIDDEN_SSID_ZERO_CONTENTS:
2157 		hidden_ssid = WMI_HIDDEN_SSID_CLEAR;
2158 		break;
2159 
2160 	default:
2161 		wil_err(wil, "AP: Invalid hidden SSID %d\n", info->hidden_ssid);
2162 		return -EOPNOTSUPP;
2163 	}
2164 	wil_dbg_misc(wil, "AP on Channel %d %d MHz, %s\n", channel->hw_value,
2165 		     channel->center_freq, info->privacy ? "secure" : "open");
2166 	wil_dbg_misc(wil, "Privacy: %d auth_type %d\n",
2167 		     info->privacy, info->auth_type);
2168 	wil_dbg_misc(wil, "Hidden SSID mode: %d\n",
2169 		     info->hidden_ssid);
2170 	wil_dbg_misc(wil, "BI %d DTIM %d\n", info->beacon_interval,
2171 		     info->dtim_period);
2172 	wil_dbg_misc(wil, "PBSS %d\n", info->pbss);
2173 	wil_hex_dump_misc("SSID ", DUMP_PREFIX_OFFSET, 16, 1,
2174 			  info->ssid, info->ssid_len, true);
2175 	wil_print_bcon_data(bcon);
2176 	wil_print_crypto(wil, crypto);
2177 
2178 	rc = _wil_cfg80211_start_ap(wiphy, ndev,
2179 				    info->ssid, info->ssid_len, info->privacy,
2180 				    info->beacon_interval, channel->hw_value,
2181 				    wmi_edmg_channel, bcon, hidden_ssid,
2182 				    info->pbss);
2183 
2184 	return rc;
2185 }
2186 
2187 static int wil_cfg80211_stop_ap(struct wiphy *wiphy,
2188 				struct net_device *ndev,
2189 				unsigned int link_id)
2190 {
2191 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2192 	struct wil6210_vif *vif = ndev_to_vif(ndev);
2193 	bool last;
2194 
2195 	wil_dbg_misc(wil, "stop_ap, mid=%d\n", vif->mid);
2196 
2197 	netif_carrier_off(ndev);
2198 	last = !wil_has_other_active_ifaces(wil, ndev, false, true);
2199 	if (last) {
2200 		wil6210_bus_request(wil, WIL_DEFAULT_BUS_REQUEST_KBPS);
2201 		wil_set_recovery_state(wil, fw_recovery_idle);
2202 		set_bit(wil_status_resetting, wil->status);
2203 	}
2204 
2205 	mutex_lock(&wil->mutex);
2206 
2207 	wmi_pcp_stop(vif);
2208 	clear_bit(wil_vif_ft_roam, vif->status);
2209 	vif->ssid_len = 0;
2210 	wil_memdup_ie(&vif->proberesp, &vif->proberesp_len, NULL, 0);
2211 	wil_memdup_ie(&vif->proberesp_ies, &vif->proberesp_ies_len, NULL, 0);
2212 	wil_memdup_ie(&vif->assocresp_ies, &vif->assocresp_ies_len, NULL, 0);
2213 	memset(vif->gtk, 0, WMI_MAX_KEY_LEN);
2214 	vif->gtk_len = 0;
2215 
2216 	if (last)
2217 		__wil_down(wil);
2218 	else
2219 		wil_bcast_fini(vif);
2220 
2221 	mutex_unlock(&wil->mutex);
2222 
2223 	return 0;
2224 }
2225 
2226 static int wil_cfg80211_add_station(struct wiphy *wiphy,
2227 				    struct net_device *dev,
2228 				    const u8 *mac,
2229 				    struct station_parameters *params)
2230 {
2231 	struct wil6210_vif *vif = ndev_to_vif(dev);
2232 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2233 
2234 	wil_dbg_misc(wil, "add station %pM aid %d mid %d mask 0x%x set 0x%x\n",
2235 		     mac, params->aid, vif->mid,
2236 		     params->sta_flags_mask, params->sta_flags_set);
2237 
2238 	if (!disable_ap_sme) {
2239 		wil_err(wil, "not supported with AP SME enabled\n");
2240 		return -EOPNOTSUPP;
2241 	}
2242 
2243 	if (params->aid > WIL_MAX_DMG_AID) {
2244 		wil_err(wil, "invalid aid\n");
2245 		return -EINVAL;
2246 	}
2247 
2248 	return wmi_new_sta(vif, mac, params->aid);
2249 }
2250 
2251 static int wil_cfg80211_del_station(struct wiphy *wiphy,
2252 				    struct net_device *dev,
2253 				    struct station_del_parameters *params)
2254 {
2255 	struct wil6210_vif *vif = ndev_to_vif(dev);
2256 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2257 
2258 	wil_dbg_misc(wil, "del_station: %pM, reason=%d mid=%d\n",
2259 		     params->mac, params->reason_code, vif->mid);
2260 
2261 	mutex_lock(&wil->mutex);
2262 	wil6210_disconnect(vif, params->mac, params->reason_code);
2263 	mutex_unlock(&wil->mutex);
2264 
2265 	return 0;
2266 }
2267 
2268 static int wil_cfg80211_change_station(struct wiphy *wiphy,
2269 				       struct net_device *dev,
2270 				       const u8 *mac,
2271 				       struct station_parameters *params)
2272 {
2273 	struct wil6210_vif *vif = ndev_to_vif(dev);
2274 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2275 	int authorize;
2276 	int cid, i;
2277 	struct wil_ring_tx_data *txdata = NULL;
2278 
2279 	wil_dbg_misc(wil, "change station %pM mask 0x%x set 0x%x mid %d\n",
2280 		     mac, params->sta_flags_mask, params->sta_flags_set,
2281 		     vif->mid);
2282 
2283 	if (!disable_ap_sme) {
2284 		wil_dbg_misc(wil, "not supported with AP SME enabled\n");
2285 		return -EOPNOTSUPP;
2286 	}
2287 
2288 	if (!(params->sta_flags_mask & BIT(NL80211_STA_FLAG_AUTHORIZED)))
2289 		return 0;
2290 
2291 	cid = wil_find_cid(wil, vif->mid, mac);
2292 	if (cid < 0) {
2293 		wil_err(wil, "station not found\n");
2294 		return -ENOLINK;
2295 	}
2296 
2297 	for (i = 0; i < ARRAY_SIZE(wil->ring2cid_tid); i++)
2298 		if (wil->ring2cid_tid[i][0] == cid) {
2299 			txdata = &wil->ring_tx_data[i];
2300 			break;
2301 		}
2302 
2303 	if (!txdata) {
2304 		wil_err(wil, "ring data not found\n");
2305 		return -ENOLINK;
2306 	}
2307 
2308 	authorize = params->sta_flags_set & BIT(NL80211_STA_FLAG_AUTHORIZED);
2309 	txdata->dot1x_open = authorize ? 1 : 0;
2310 	wil_dbg_misc(wil, "cid %d ring %d authorize %d\n", cid, i,
2311 		     txdata->dot1x_open);
2312 
2313 	return 0;
2314 }
2315 
2316 /* probe_client handling */
2317 static void wil_probe_client_handle(struct wil6210_priv *wil,
2318 				    struct wil6210_vif *vif,
2319 				    struct wil_probe_client_req *req)
2320 {
2321 	struct net_device *ndev = vif_to_ndev(vif);
2322 	struct wil_sta_info *sta = &wil->sta[req->cid];
2323 	/* assume STA is alive if it is still connected,
2324 	 * else FW will disconnect it
2325 	 */
2326 	bool alive = (sta->status == wil_sta_connected);
2327 
2328 	cfg80211_probe_status(ndev, sta->addr, req->cookie, alive,
2329 			      0, false, GFP_KERNEL);
2330 }
2331 
2332 static struct list_head *next_probe_client(struct wil6210_vif *vif)
2333 {
2334 	struct list_head *ret = NULL;
2335 
2336 	mutex_lock(&vif->probe_client_mutex);
2337 
2338 	if (!list_empty(&vif->probe_client_pending)) {
2339 		ret = vif->probe_client_pending.next;
2340 		list_del(ret);
2341 	}
2342 
2343 	mutex_unlock(&vif->probe_client_mutex);
2344 
2345 	return ret;
2346 }
2347 
2348 void wil_probe_client_worker(struct work_struct *work)
2349 {
2350 	struct wil6210_vif *vif = container_of(work, struct wil6210_vif,
2351 					       probe_client_worker);
2352 	struct wil6210_priv *wil = vif_to_wil(vif);
2353 	struct wil_probe_client_req *req;
2354 	struct list_head *lh;
2355 
2356 	while ((lh = next_probe_client(vif)) != NULL) {
2357 		req = list_entry(lh, struct wil_probe_client_req, list);
2358 
2359 		wil_probe_client_handle(wil, vif, req);
2360 		kfree(req);
2361 	}
2362 }
2363 
2364 void wil_probe_client_flush(struct wil6210_vif *vif)
2365 {
2366 	struct wil_probe_client_req *req, *t;
2367 	struct wil6210_priv *wil = vif_to_wil(vif);
2368 
2369 	wil_dbg_misc(wil, "probe_client_flush\n");
2370 
2371 	mutex_lock(&vif->probe_client_mutex);
2372 
2373 	list_for_each_entry_safe(req, t, &vif->probe_client_pending, list) {
2374 		list_del(&req->list);
2375 		kfree(req);
2376 	}
2377 
2378 	mutex_unlock(&vif->probe_client_mutex);
2379 }
2380 
2381 static int wil_cfg80211_probe_client(struct wiphy *wiphy,
2382 				     struct net_device *dev,
2383 				     const u8 *peer, u64 *cookie)
2384 {
2385 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2386 	struct wil6210_vif *vif = ndev_to_vif(dev);
2387 	struct wil_probe_client_req *req;
2388 	int cid = wil_find_cid(wil, vif->mid, peer);
2389 
2390 	wil_dbg_misc(wil, "probe_client: %pM => CID %d MID %d\n",
2391 		     peer, cid, vif->mid);
2392 
2393 	if (cid < 0)
2394 		return -ENOLINK;
2395 
2396 	req = kzalloc(sizeof(*req), GFP_KERNEL);
2397 	if (!req)
2398 		return -ENOMEM;
2399 
2400 	req->cid = cid;
2401 	req->cookie = cid;
2402 
2403 	mutex_lock(&vif->probe_client_mutex);
2404 	list_add_tail(&req->list, &vif->probe_client_pending);
2405 	mutex_unlock(&vif->probe_client_mutex);
2406 
2407 	*cookie = req->cookie;
2408 	queue_work(wil->wq_service, &vif->probe_client_worker);
2409 	return 0;
2410 }
2411 
2412 static int wil_cfg80211_change_bss(struct wiphy *wiphy,
2413 				   struct net_device *dev,
2414 				   struct bss_parameters *params)
2415 {
2416 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2417 	struct wil6210_vif *vif = ndev_to_vif(dev);
2418 
2419 	if (params->ap_isolate >= 0) {
2420 		wil_dbg_misc(wil, "change_bss: ap_isolate MID %d, %d => %d\n",
2421 			     vif->mid, vif->ap_isolate, params->ap_isolate);
2422 		vif->ap_isolate = params->ap_isolate;
2423 	}
2424 
2425 	return 0;
2426 }
2427 
2428 static int wil_cfg80211_set_power_mgmt(struct wiphy *wiphy,
2429 				       struct net_device *dev,
2430 				       bool enabled, int timeout)
2431 {
2432 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2433 	enum wmi_ps_profile_type ps_profile;
2434 
2435 	wil_dbg_misc(wil, "enabled=%d, timeout=%d\n",
2436 		     enabled, timeout);
2437 
2438 	if (enabled)
2439 		ps_profile = WMI_PS_PROFILE_TYPE_DEFAULT;
2440 	else
2441 		ps_profile = WMI_PS_PROFILE_TYPE_PS_DISABLED;
2442 
2443 	return wil_ps_update(wil, ps_profile);
2444 }
2445 
2446 static int wil_cfg80211_suspend(struct wiphy *wiphy,
2447 				struct cfg80211_wowlan *wow)
2448 {
2449 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2450 	int rc;
2451 
2452 	/* Setting the wakeup trigger based on wow is TBD */
2453 
2454 	if (test_bit(wil_status_suspended, wil->status)) {
2455 		wil_dbg_pm(wil, "trying to suspend while suspended\n");
2456 		return 0;
2457 	}
2458 
2459 	rc = wil_can_suspend(wil, false);
2460 	if (rc)
2461 		goto out;
2462 
2463 	wil_dbg_pm(wil, "suspending\n");
2464 
2465 	mutex_lock(&wil->mutex);
2466 	mutex_lock(&wil->vif_mutex);
2467 	wil_p2p_stop_radio_operations(wil);
2468 	wil_abort_scan_all_vifs(wil, true);
2469 	mutex_unlock(&wil->vif_mutex);
2470 	mutex_unlock(&wil->mutex);
2471 
2472 out:
2473 	return rc;
2474 }
2475 
2476 static int wil_cfg80211_resume(struct wiphy *wiphy)
2477 {
2478 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2479 
2480 	wil_dbg_pm(wil, "resuming\n");
2481 
2482 	return 0;
2483 }
2484 
2485 static int
2486 wil_cfg80211_sched_scan_start(struct wiphy *wiphy,
2487 			      struct net_device *dev,
2488 			      struct cfg80211_sched_scan_request *request)
2489 {
2490 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2491 	struct wil6210_vif *vif = ndev_to_vif(dev);
2492 	int i, rc;
2493 
2494 	if (vif->mid != 0)
2495 		return -EOPNOTSUPP;
2496 
2497 	wil_dbg_misc(wil,
2498 		     "sched scan start: n_ssids %d, ie_len %zu, flags 0x%x\n",
2499 		     request->n_ssids, request->ie_len, request->flags);
2500 	for (i = 0; i < request->n_ssids; i++) {
2501 		wil_dbg_misc(wil, "SSID[%d]:", i);
2502 		wil_hex_dump_misc("SSID ", DUMP_PREFIX_OFFSET, 16, 1,
2503 				  request->ssids[i].ssid,
2504 				  request->ssids[i].ssid_len, true);
2505 	}
2506 	wil_dbg_misc(wil, "channels:");
2507 	for (i = 0; i < request->n_channels; i++)
2508 		wil_dbg_misc(wil, " %d%s", request->channels[i]->hw_value,
2509 			     i == request->n_channels - 1 ? "\n" : "");
2510 	wil_dbg_misc(wil, "n_match_sets %d, min_rssi_thold %d, delay %d\n",
2511 		     request->n_match_sets, request->min_rssi_thold,
2512 		     request->delay);
2513 	for (i = 0; i < request->n_match_sets; i++) {
2514 		struct cfg80211_match_set *ms = &request->match_sets[i];
2515 
2516 		wil_dbg_misc(wil, "MATCHSET[%d]: rssi_thold %d\n",
2517 			     i, ms->rssi_thold);
2518 		wil_hex_dump_misc("SSID ", DUMP_PREFIX_OFFSET, 16, 1,
2519 				  ms->ssid.ssid,
2520 				  ms->ssid.ssid_len, true);
2521 	}
2522 	wil_dbg_misc(wil, "n_scan_plans %d\n", request->n_scan_plans);
2523 	for (i = 0; i < request->n_scan_plans; i++) {
2524 		struct cfg80211_sched_scan_plan *sp = &request->scan_plans[i];
2525 
2526 		wil_dbg_misc(wil, "SCAN PLAN[%d]: interval %d iterations %d\n",
2527 			     i, sp->interval, sp->iterations);
2528 	}
2529 
2530 	rc = wmi_set_ie(vif, WMI_FRAME_PROBE_REQ,
2531 			request->ie_len, request->ie);
2532 	if (rc)
2533 		return rc;
2534 	return wmi_start_sched_scan(wil, request);
2535 }
2536 
2537 static int
2538 wil_cfg80211_sched_scan_stop(struct wiphy *wiphy, struct net_device *dev,
2539 			     u64 reqid)
2540 {
2541 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2542 	struct wil6210_vif *vif = ndev_to_vif(dev);
2543 	int rc;
2544 
2545 	if (vif->mid != 0)
2546 		return -EOPNOTSUPP;
2547 
2548 	rc = wmi_stop_sched_scan(wil);
2549 	/* device would return error if it thinks PNO is already stopped.
2550 	 * ignore the return code so user space and driver gets back in-sync
2551 	 */
2552 	wil_dbg_misc(wil, "sched scan stopped (%d)\n", rc);
2553 
2554 	return 0;
2555 }
2556 
2557 static int
2558 wil_cfg80211_update_ft_ies(struct wiphy *wiphy, struct net_device *dev,
2559 			   struct cfg80211_update_ft_ies_params *ftie)
2560 {
2561 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2562 	struct wil6210_vif *vif = ndev_to_vif(dev);
2563 	struct cfg80211_bss *bss;
2564 	struct wmi_ft_reassoc_cmd reassoc;
2565 	int rc = 0;
2566 
2567 	wil_dbg_misc(wil, "update ft ies, mid=%d\n", vif->mid);
2568 	wil_hex_dump_misc("FT IE ", DUMP_PREFIX_OFFSET, 16, 1,
2569 			  ftie->ie, ftie->ie_len, true);
2570 
2571 	if (!test_bit(WMI_FW_CAPABILITY_FT_ROAMING, wil->fw_capabilities)) {
2572 		wil_err(wil, "FW does not support FT roaming\n");
2573 		return -EOPNOTSUPP;
2574 	}
2575 
2576 	rc = wmi_update_ft_ies(vif, ftie->ie_len, ftie->ie);
2577 	if (rc)
2578 		return rc;
2579 
2580 	if (!test_bit(wil_vif_ft_roam, vif->status))
2581 		/* vif is not roaming */
2582 		return 0;
2583 
2584 	/* wil_vif_ft_roam is set. wil_cfg80211_update_ft_ies is used as
2585 	 * a trigger for reassoc
2586 	 */
2587 
2588 	bss = vif->bss;
2589 	if (!bss) {
2590 		wil_err(wil, "FT: bss is NULL\n");
2591 		return -EINVAL;
2592 	}
2593 
2594 	memset(&reassoc, 0, sizeof(reassoc));
2595 	ether_addr_copy(reassoc.bssid, bss->bssid);
2596 
2597 	rc = wmi_send(wil, WMI_FT_REASSOC_CMDID, vif->mid,
2598 		      &reassoc, sizeof(reassoc));
2599 	if (rc)
2600 		wil_err(wil, "FT: reassoc failed (%d)\n", rc);
2601 
2602 	return rc;
2603 }
2604 
2605 static int wil_cfg80211_set_multicast_to_unicast(struct wiphy *wiphy,
2606 						 struct net_device *dev,
2607 						 const bool enabled)
2608 {
2609 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2610 
2611 	if (wil->multicast_to_unicast == enabled)
2612 		return 0;
2613 
2614 	wil_info(wil, "set multicast to unicast, enabled=%d\n", enabled);
2615 	wil->multicast_to_unicast = enabled;
2616 
2617 	return 0;
2618 }
2619 
2620 static int wil_cfg80211_set_cqm_rssi_config(struct wiphy *wiphy,
2621 					    struct net_device *dev,
2622 					    s32 rssi_thold, u32 rssi_hyst)
2623 {
2624 	struct wil6210_priv *wil = wiphy_to_wil(wiphy);
2625 	int rc;
2626 
2627 	wil->cqm_rssi_thold = rssi_thold;
2628 
2629 	rc = wmi_set_cqm_rssi_config(wil, rssi_thold, rssi_hyst);
2630 	if (rc)
2631 		/* reset stored value upon failure */
2632 		wil->cqm_rssi_thold = 0;
2633 
2634 	return rc;
2635 }
2636 
2637 static const struct cfg80211_ops wil_cfg80211_ops = {
2638 	.add_virtual_intf = wil_cfg80211_add_iface,
2639 	.del_virtual_intf = wil_cfg80211_del_iface,
2640 	.scan = wil_cfg80211_scan,
2641 	.abort_scan = wil_cfg80211_abort_scan,
2642 	.connect = wil_cfg80211_connect,
2643 	.disconnect = wil_cfg80211_disconnect,
2644 	.set_wiphy_params = wil_cfg80211_set_wiphy_params,
2645 	.change_virtual_intf = wil_cfg80211_change_iface,
2646 	.get_station = wil_cfg80211_get_station,
2647 	.dump_station = wil_cfg80211_dump_station,
2648 	.remain_on_channel = wil_remain_on_channel,
2649 	.cancel_remain_on_channel = wil_cancel_remain_on_channel,
2650 	.mgmt_tx = wil_cfg80211_mgmt_tx,
2651 	.set_monitor_channel = wil_cfg80211_set_channel,
2652 	.add_key = wil_cfg80211_add_key,
2653 	.del_key = wil_cfg80211_del_key,
2654 	.set_default_key = wil_cfg80211_set_default_key,
2655 	/* AP mode */
2656 	.change_beacon = wil_cfg80211_change_beacon,
2657 	.start_ap = wil_cfg80211_start_ap,
2658 	.stop_ap = wil_cfg80211_stop_ap,
2659 	.add_station = wil_cfg80211_add_station,
2660 	.del_station = wil_cfg80211_del_station,
2661 	.change_station = wil_cfg80211_change_station,
2662 	.probe_client = wil_cfg80211_probe_client,
2663 	.change_bss = wil_cfg80211_change_bss,
2664 	/* P2P device */
2665 	.start_p2p_device = wil_cfg80211_start_p2p_device,
2666 	.stop_p2p_device = wil_cfg80211_stop_p2p_device,
2667 	.set_power_mgmt = wil_cfg80211_set_power_mgmt,
2668 	.set_cqm_rssi_config = wil_cfg80211_set_cqm_rssi_config,
2669 	.suspend = wil_cfg80211_suspend,
2670 	.resume = wil_cfg80211_resume,
2671 	.sched_scan_start = wil_cfg80211_sched_scan_start,
2672 	.sched_scan_stop = wil_cfg80211_sched_scan_stop,
2673 	.update_ft_ies = wil_cfg80211_update_ft_ies,
2674 	.set_multicast_to_unicast = wil_cfg80211_set_multicast_to_unicast,
2675 };
2676 
2677 static void wil_wiphy_init(struct wiphy *wiphy)
2678 {
2679 	wiphy->max_scan_ssids = 1;
2680 	wiphy->max_scan_ie_len = WMI_MAX_IE_LEN;
2681 	wiphy->max_remain_on_channel_duration = WIL_MAX_ROC_DURATION_MS;
2682 	wiphy->max_num_pmkids = 0 /* TODO: */;
2683 	wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) |
2684 				 BIT(NL80211_IFTYPE_AP) |
2685 				 BIT(NL80211_IFTYPE_P2P_CLIENT) |
2686 				 BIT(NL80211_IFTYPE_P2P_GO) |
2687 				 BIT(NL80211_IFTYPE_P2P_DEVICE) |
2688 				 BIT(NL80211_IFTYPE_MONITOR);
2689 	wiphy->flags |= WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL |
2690 			WIPHY_FLAG_AP_PROBE_RESP_OFFLOAD |
2691 			WIPHY_FLAG_PS_ON_BY_DEFAULT;
2692 	if (!disable_ap_sme)
2693 		wiphy->flags |= WIPHY_FLAG_HAVE_AP_SME;
2694 	dev_dbg(wiphy_dev(wiphy), "%s : flags = 0x%08x\n",
2695 		__func__, wiphy->flags);
2696 	wiphy->probe_resp_offload =
2697 		NL80211_PROBE_RESP_OFFLOAD_SUPPORT_WPS |
2698 		NL80211_PROBE_RESP_OFFLOAD_SUPPORT_WPS2 |
2699 		NL80211_PROBE_RESP_OFFLOAD_SUPPORT_P2P;
2700 
2701 	wiphy->bands[NL80211_BAND_60GHZ] = &wil_band_60ghz;
2702 
2703 	/* may change after reading FW capabilities */
2704 	wiphy->signal_type = CFG80211_SIGNAL_TYPE_UNSPEC;
2705 
2706 	wiphy->cipher_suites = wil_cipher_suites;
2707 	wiphy->n_cipher_suites = ARRAY_SIZE(wil_cipher_suites);
2708 	wiphy->mgmt_stypes = wil_mgmt_stypes;
2709 	wiphy->features |= NL80211_FEATURE_SK_TX_STATUS;
2710 
2711 	wiphy->n_vendor_commands = ARRAY_SIZE(wil_nl80211_vendor_commands);
2712 	wiphy->vendor_commands = wil_nl80211_vendor_commands;
2713 
2714 #ifdef CONFIG_PM
2715 	wiphy->wowlan = &wil_wowlan_support;
2716 #endif
2717 }
2718 
2719 int wil_cfg80211_iface_combinations_from_fw(
2720 	struct wil6210_priv *wil, const struct wil_fw_record_concurrency *conc)
2721 {
2722 	struct wiphy *wiphy = wil_to_wiphy(wil);
2723 	u32 total_limits = 0;
2724 	u16 n_combos;
2725 	const struct wil_fw_concurrency_combo *combo;
2726 	const struct wil_fw_concurrency_limit *limit;
2727 	struct ieee80211_iface_combination *iface_combinations;
2728 	struct ieee80211_iface_limit *iface_limit;
2729 	int i, j;
2730 
2731 	if (wiphy->iface_combinations) {
2732 		wil_dbg_misc(wil, "iface_combinations already set, skipping\n");
2733 		return 0;
2734 	}
2735 
2736 	combo = (const struct wil_fw_concurrency_combo *)(conc + 1);
2737 	n_combos = le16_to_cpu(conc->n_combos);
2738 	for (i = 0; i < n_combos; i++) {
2739 		total_limits += combo->n_limits;
2740 		limit = combo->limits + combo->n_limits;
2741 		combo = (struct wil_fw_concurrency_combo *)limit;
2742 	}
2743 
2744 	iface_combinations =
2745 		kzalloc(n_combos * sizeof(struct ieee80211_iface_combination) +
2746 			total_limits * sizeof(struct ieee80211_iface_limit),
2747 			GFP_KERNEL);
2748 	if (!iface_combinations)
2749 		return -ENOMEM;
2750 	iface_limit = (struct ieee80211_iface_limit *)(iface_combinations +
2751 						       n_combos);
2752 	combo = (const struct wil_fw_concurrency_combo *)(conc + 1);
2753 	for (i = 0; i < n_combos; i++) {
2754 		iface_combinations[i].max_interfaces = combo->max_interfaces;
2755 		iface_combinations[i].num_different_channels =
2756 			combo->n_diff_channels;
2757 		iface_combinations[i].beacon_int_infra_match =
2758 			combo->same_bi;
2759 		iface_combinations[i].n_limits = combo->n_limits;
2760 		wil_dbg_misc(wil,
2761 			     "iface_combination %d: max_if %d, num_ch %d, bi_match %d\n",
2762 			     i, iface_combinations[i].max_interfaces,
2763 			     iface_combinations[i].num_different_channels,
2764 			     iface_combinations[i].beacon_int_infra_match);
2765 		limit = combo->limits;
2766 		for (j = 0; j < combo->n_limits; j++) {
2767 			iface_limit[j].max = le16_to_cpu(limit[j].max);
2768 			iface_limit[j].types = le16_to_cpu(limit[j].types);
2769 			wil_dbg_misc(wil,
2770 				     "limit %d: max %d types 0x%x\n", j,
2771 				     iface_limit[j].max, iface_limit[j].types);
2772 		}
2773 		iface_combinations[i].limits = iface_limit;
2774 		iface_limit += combo->n_limits;
2775 		limit += combo->n_limits;
2776 		combo = (struct wil_fw_concurrency_combo *)limit;
2777 	}
2778 
2779 	wil_dbg_misc(wil, "multiple VIFs supported, n_mids %d\n", conc->n_mids);
2780 	wil->max_vifs = conc->n_mids + 1; /* including main interface */
2781 	if (wil->max_vifs > WIL_MAX_VIFS) {
2782 		wil_info(wil, "limited number of VIFs supported(%d, FW %d)\n",
2783 			 WIL_MAX_VIFS, wil->max_vifs);
2784 		wil->max_vifs = WIL_MAX_VIFS;
2785 	}
2786 	wiphy->n_iface_combinations = n_combos;
2787 	wiphy->iface_combinations = iface_combinations;
2788 	return 0;
2789 }
2790 
2791 struct wil6210_priv *wil_cfg80211_init(struct device *dev)
2792 {
2793 	struct wiphy *wiphy;
2794 	struct wil6210_priv *wil;
2795 	struct ieee80211_channel *ch;
2796 
2797 	dev_dbg(dev, "%s()\n", __func__);
2798 
2799 	/* Note: the wireless_dev structure is no longer allocated here.
2800 	 * Instead, it is allocated as part of the net_device structure
2801 	 * for main interface and each VIF.
2802 	 */
2803 	wiphy = wiphy_new(&wil_cfg80211_ops, sizeof(struct wil6210_priv));
2804 	if (!wiphy)
2805 		return ERR_PTR(-ENOMEM);
2806 
2807 	set_wiphy_dev(wiphy, dev);
2808 	wil_wiphy_init(wiphy);
2809 
2810 	wil = wiphy_to_wil(wiphy);
2811 	wil->wiphy = wiphy;
2812 
2813 	/* default monitor channel */
2814 	ch = wiphy->bands[NL80211_BAND_60GHZ]->channels;
2815 	cfg80211_chandef_create(&wil->monitor_chandef, ch, NL80211_CHAN_NO_HT);
2816 
2817 	return wil;
2818 }
2819 
2820 void wil_cfg80211_deinit(struct wil6210_priv *wil)
2821 {
2822 	struct wiphy *wiphy = wil_to_wiphy(wil);
2823 
2824 	dev_dbg(wil_to_dev(wil), "%s()\n", __func__);
2825 
2826 	if (!wiphy)
2827 		return;
2828 
2829 	kfree(wiphy->iface_combinations);
2830 	wiphy->iface_combinations = NULL;
2831 
2832 	wiphy_free(wiphy);
2833 	/* do not access wil6210_priv after returning from here */
2834 }
2835 
2836 void wil_p2p_wdev_free(struct wil6210_priv *wil)
2837 {
2838 	struct wireless_dev *p2p_wdev;
2839 
2840 	mutex_lock(&wil->vif_mutex);
2841 	p2p_wdev = wil->p2p_wdev;
2842 	wil->p2p_wdev = NULL;
2843 	wil->radio_wdev = wil->main_ndev->ieee80211_ptr;
2844 	mutex_unlock(&wil->vif_mutex);
2845 	if (p2p_wdev) {
2846 		cfg80211_unregister_wdev(p2p_wdev);
2847 		kfree(p2p_wdev);
2848 	}
2849 }
2850 
2851 static int wil_rf_sector_status_to_rc(u8 status)
2852 {
2853 	switch (status) {
2854 	case WMI_RF_SECTOR_STATUS_SUCCESS:
2855 		return 0;
2856 	case WMI_RF_SECTOR_STATUS_BAD_PARAMETERS_ERROR:
2857 		return -EINVAL;
2858 	case WMI_RF_SECTOR_STATUS_BUSY_ERROR:
2859 		return -EAGAIN;
2860 	case WMI_RF_SECTOR_STATUS_NOT_SUPPORTED_ERROR:
2861 		return -EOPNOTSUPP;
2862 	default:
2863 		return -EINVAL;
2864 	}
2865 }
2866 
2867 static int wil_rf_sector_get_cfg(struct wiphy *wiphy,
2868 				 struct wireless_dev *wdev,
2869 				 const void *data, int data_len)
2870 {
2871 	struct wil6210_priv *wil = wdev_to_wil(wdev);
2872 	struct wil6210_vif *vif = wdev_to_vif(wil, wdev);
2873 	int rc;
2874 	struct nlattr *tb[QCA_ATTR_DMG_RF_SECTOR_MAX + 1];
2875 	u16 sector_index;
2876 	u8 sector_type;
2877 	u32 rf_modules_vec;
2878 	struct wmi_get_rf_sector_params_cmd cmd;
2879 	struct {
2880 		struct wmi_cmd_hdr wmi;
2881 		struct wmi_get_rf_sector_params_done_event evt;
2882 	} __packed reply = {
2883 		.evt = {.status = WMI_RF_SECTOR_STATUS_NOT_SUPPORTED_ERROR},
2884 	};
2885 	struct sk_buff *msg;
2886 	struct nlattr *nl_cfgs, *nl_cfg;
2887 	u32 i;
2888 	struct wmi_rf_sector_info *si;
2889 
2890 	if (!test_bit(WMI_FW_CAPABILITY_RF_SECTORS, wil->fw_capabilities))
2891 		return -EOPNOTSUPP;
2892 
2893 	rc = nla_parse_deprecated(tb, QCA_ATTR_DMG_RF_SECTOR_MAX, data,
2894 				  data_len, wil_rf_sector_policy, NULL);
2895 	if (rc) {
2896 		wil_err(wil, "Invalid rf sector ATTR\n");
2897 		return rc;
2898 	}
2899 
2900 	if (!tb[QCA_ATTR_DMG_RF_SECTOR_INDEX] ||
2901 	    !tb[QCA_ATTR_DMG_RF_SECTOR_TYPE] ||
2902 	    !tb[QCA_ATTR_DMG_RF_MODULE_MASK]) {
2903 		wil_err(wil, "Invalid rf sector spec\n");
2904 		return -EINVAL;
2905 	}
2906 
2907 	sector_index = nla_get_u16(
2908 		tb[QCA_ATTR_DMG_RF_SECTOR_INDEX]);
2909 	if (sector_index >= WIL_MAX_RF_SECTORS) {
2910 		wil_err(wil, "Invalid sector index %d\n", sector_index);
2911 		return -EINVAL;
2912 	}
2913 
2914 	sector_type = nla_get_u8(tb[QCA_ATTR_DMG_RF_SECTOR_TYPE]);
2915 	if (sector_type >= QCA_ATTR_DMG_RF_SECTOR_TYPE_MAX) {
2916 		wil_err(wil, "Invalid sector type %d\n", sector_type);
2917 		return -EINVAL;
2918 	}
2919 
2920 	rf_modules_vec = nla_get_u32(
2921 		tb[QCA_ATTR_DMG_RF_MODULE_MASK]);
2922 	if (rf_modules_vec >= BIT(WMI_MAX_RF_MODULES_NUM)) {
2923 		wil_err(wil, "Invalid rf module mask 0x%x\n", rf_modules_vec);
2924 		return -EINVAL;
2925 	}
2926 
2927 	cmd.sector_idx = cpu_to_le16(sector_index);
2928 	cmd.sector_type = sector_type;
2929 	cmd.rf_modules_vec = rf_modules_vec & 0xFF;
2930 	rc = wmi_call(wil, WMI_GET_RF_SECTOR_PARAMS_CMDID, vif->mid,
2931 		      &cmd, sizeof(cmd), WMI_GET_RF_SECTOR_PARAMS_DONE_EVENTID,
2932 		      &reply, sizeof(reply),
2933 		      500);
2934 	if (rc)
2935 		return rc;
2936 	if (reply.evt.status) {
2937 		wil_err(wil, "get rf sector cfg failed with status %d\n",
2938 			reply.evt.status);
2939 		return wil_rf_sector_status_to_rc(reply.evt.status);
2940 	}
2941 
2942 	msg = cfg80211_vendor_cmd_alloc_reply_skb(
2943 		wiphy, 64 * WMI_MAX_RF_MODULES_NUM);
2944 	if (!msg)
2945 		return -ENOMEM;
2946 
2947 	if (nla_put_u64_64bit(msg, QCA_ATTR_TSF,
2948 			      le64_to_cpu(reply.evt.tsf),
2949 			      QCA_ATTR_PAD))
2950 		goto nla_put_failure;
2951 
2952 	nl_cfgs = nla_nest_start_noflag(msg, QCA_ATTR_DMG_RF_SECTOR_CFG);
2953 	if (!nl_cfgs)
2954 		goto nla_put_failure;
2955 	for (i = 0; i < WMI_MAX_RF_MODULES_NUM; i++) {
2956 		if (!(rf_modules_vec & BIT(i)))
2957 			continue;
2958 		nl_cfg = nla_nest_start_noflag(msg, i);
2959 		if (!nl_cfg)
2960 			goto nla_put_failure;
2961 		si = &reply.evt.sectors_info[i];
2962 		if (nla_put_u8(msg, QCA_ATTR_DMG_RF_SECTOR_CFG_MODULE_INDEX,
2963 			       i) ||
2964 		    nla_put_u32(msg, QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE0,
2965 				le32_to_cpu(si->etype0)) ||
2966 		    nla_put_u32(msg, QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE1,
2967 				le32_to_cpu(si->etype1)) ||
2968 		    nla_put_u32(msg, QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE2,
2969 				le32_to_cpu(si->etype2)) ||
2970 		    nla_put_u32(msg, QCA_ATTR_DMG_RF_SECTOR_CFG_PSH_HI,
2971 				le32_to_cpu(si->psh_hi)) ||
2972 		    nla_put_u32(msg, QCA_ATTR_DMG_RF_SECTOR_CFG_PSH_LO,
2973 				le32_to_cpu(si->psh_lo)) ||
2974 		    nla_put_u32(msg, QCA_ATTR_DMG_RF_SECTOR_CFG_DTYPE_X16,
2975 				le32_to_cpu(si->dtype_swch_off)))
2976 			goto nla_put_failure;
2977 		nla_nest_end(msg, nl_cfg);
2978 	}
2979 
2980 	nla_nest_end(msg, nl_cfgs);
2981 	rc = cfg80211_vendor_cmd_reply(msg);
2982 	return rc;
2983 nla_put_failure:
2984 	kfree_skb(msg);
2985 	return -ENOBUFS;
2986 }
2987 
2988 static int wil_rf_sector_set_cfg(struct wiphy *wiphy,
2989 				 struct wireless_dev *wdev,
2990 				 const void *data, int data_len)
2991 {
2992 	struct wil6210_priv *wil = wdev_to_wil(wdev);
2993 	struct wil6210_vif *vif = wdev_to_vif(wil, wdev);
2994 	int rc, tmp;
2995 	struct nlattr *tb[QCA_ATTR_DMG_RF_SECTOR_MAX + 1];
2996 	struct nlattr *tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_MAX + 1];
2997 	u16 sector_index, rf_module_index;
2998 	u8 sector_type;
2999 	u32 rf_modules_vec = 0;
3000 	struct wmi_set_rf_sector_params_cmd cmd;
3001 	struct {
3002 		struct wmi_cmd_hdr wmi;
3003 		struct wmi_set_rf_sector_params_done_event evt;
3004 	} __packed reply = {
3005 		.evt = {.status = WMI_RF_SECTOR_STATUS_NOT_SUPPORTED_ERROR},
3006 	};
3007 	struct nlattr *nl_cfg;
3008 	struct wmi_rf_sector_info *si;
3009 
3010 	if (!test_bit(WMI_FW_CAPABILITY_RF_SECTORS, wil->fw_capabilities))
3011 		return -EOPNOTSUPP;
3012 
3013 	rc = nla_parse_deprecated(tb, QCA_ATTR_DMG_RF_SECTOR_MAX, data,
3014 				  data_len, wil_rf_sector_policy, NULL);
3015 	if (rc) {
3016 		wil_err(wil, "Invalid rf sector ATTR\n");
3017 		return rc;
3018 	}
3019 
3020 	if (!tb[QCA_ATTR_DMG_RF_SECTOR_INDEX] ||
3021 	    !tb[QCA_ATTR_DMG_RF_SECTOR_TYPE] ||
3022 	    !tb[QCA_ATTR_DMG_RF_SECTOR_CFG]) {
3023 		wil_err(wil, "Invalid rf sector spec\n");
3024 		return -EINVAL;
3025 	}
3026 
3027 	sector_index = nla_get_u16(
3028 		tb[QCA_ATTR_DMG_RF_SECTOR_INDEX]);
3029 	if (sector_index >= WIL_MAX_RF_SECTORS) {
3030 		wil_err(wil, "Invalid sector index %d\n", sector_index);
3031 		return -EINVAL;
3032 	}
3033 
3034 	sector_type = nla_get_u8(tb[QCA_ATTR_DMG_RF_SECTOR_TYPE]);
3035 	if (sector_type >= QCA_ATTR_DMG_RF_SECTOR_TYPE_MAX) {
3036 		wil_err(wil, "Invalid sector type %d\n", sector_type);
3037 		return -EINVAL;
3038 	}
3039 
3040 	memset(&cmd, 0, sizeof(cmd));
3041 
3042 	cmd.sector_idx = cpu_to_le16(sector_index);
3043 	cmd.sector_type = sector_type;
3044 	nla_for_each_nested(nl_cfg, tb[QCA_ATTR_DMG_RF_SECTOR_CFG],
3045 			    tmp) {
3046 		rc = nla_parse_nested_deprecated(tb2,
3047 						 QCA_ATTR_DMG_RF_SECTOR_CFG_MAX,
3048 						 nl_cfg,
3049 						 wil_rf_sector_cfg_policy,
3050 						 NULL);
3051 		if (rc) {
3052 			wil_err(wil, "invalid sector cfg\n");
3053 			return -EINVAL;
3054 		}
3055 
3056 		if (!tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_MODULE_INDEX] ||
3057 		    !tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE0] ||
3058 		    !tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE1] ||
3059 		    !tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE2] ||
3060 		    !tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_PSH_HI] ||
3061 		    !tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_PSH_LO] ||
3062 		    !tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_DTYPE_X16]) {
3063 			wil_err(wil, "missing cfg params\n");
3064 			return -EINVAL;
3065 		}
3066 
3067 		rf_module_index = nla_get_u8(
3068 			tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_MODULE_INDEX]);
3069 		if (rf_module_index >= WMI_MAX_RF_MODULES_NUM) {
3070 			wil_err(wil, "invalid RF module index %d\n",
3071 				rf_module_index);
3072 			return -EINVAL;
3073 		}
3074 		rf_modules_vec |= BIT(rf_module_index);
3075 		si = &cmd.sectors_info[rf_module_index];
3076 		si->etype0 = cpu_to_le32(nla_get_u32(
3077 			tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE0]));
3078 		si->etype1 = cpu_to_le32(nla_get_u32(
3079 			tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE1]));
3080 		si->etype2 = cpu_to_le32(nla_get_u32(
3081 			tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_ETYPE2]));
3082 		si->psh_hi = cpu_to_le32(nla_get_u32(
3083 			tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_PSH_HI]));
3084 		si->psh_lo = cpu_to_le32(nla_get_u32(
3085 			tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_PSH_LO]));
3086 		si->dtype_swch_off = cpu_to_le32(nla_get_u32(
3087 			tb2[QCA_ATTR_DMG_RF_SECTOR_CFG_DTYPE_X16]));
3088 	}
3089 
3090 	cmd.rf_modules_vec = rf_modules_vec & 0xFF;
3091 	rc = wmi_call(wil, WMI_SET_RF_SECTOR_PARAMS_CMDID, vif->mid,
3092 		      &cmd, sizeof(cmd), WMI_SET_RF_SECTOR_PARAMS_DONE_EVENTID,
3093 		      &reply, sizeof(reply),
3094 		      500);
3095 	if (rc)
3096 		return rc;
3097 	return wil_rf_sector_status_to_rc(reply.evt.status);
3098 }
3099 
3100 static int wil_rf_sector_get_selected(struct wiphy *wiphy,
3101 				      struct wireless_dev *wdev,
3102 				      const void *data, int data_len)
3103 {
3104 	struct wil6210_priv *wil = wdev_to_wil(wdev);
3105 	struct wil6210_vif *vif = wdev_to_vif(wil, wdev);
3106 	int rc;
3107 	struct nlattr *tb[QCA_ATTR_DMG_RF_SECTOR_MAX + 1];
3108 	u8 sector_type, mac_addr[ETH_ALEN];
3109 	int cid = 0;
3110 	struct wmi_get_selected_rf_sector_index_cmd cmd;
3111 	struct {
3112 		struct wmi_cmd_hdr wmi;
3113 		struct wmi_get_selected_rf_sector_index_done_event evt;
3114 	} __packed reply = {
3115 		.evt = {.status = WMI_RF_SECTOR_STATUS_NOT_SUPPORTED_ERROR},
3116 	};
3117 	struct sk_buff *msg;
3118 
3119 	if (!test_bit(WMI_FW_CAPABILITY_RF_SECTORS, wil->fw_capabilities))
3120 		return -EOPNOTSUPP;
3121 
3122 	rc = nla_parse_deprecated(tb, QCA_ATTR_DMG_RF_SECTOR_MAX, data,
3123 				  data_len, wil_rf_sector_policy, NULL);
3124 	if (rc) {
3125 		wil_err(wil, "Invalid rf sector ATTR\n");
3126 		return rc;
3127 	}
3128 
3129 	if (!tb[QCA_ATTR_DMG_RF_SECTOR_TYPE]) {
3130 		wil_err(wil, "Invalid rf sector spec\n");
3131 		return -EINVAL;
3132 	}
3133 	sector_type = nla_get_u8(tb[QCA_ATTR_DMG_RF_SECTOR_TYPE]);
3134 	if (sector_type >= QCA_ATTR_DMG_RF_SECTOR_TYPE_MAX) {
3135 		wil_err(wil, "Invalid sector type %d\n", sector_type);
3136 		return -EINVAL;
3137 	}
3138 
3139 	if (tb[QCA_ATTR_MAC_ADDR]) {
3140 		ether_addr_copy(mac_addr, nla_data(tb[QCA_ATTR_MAC_ADDR]));
3141 		cid = wil_find_cid(wil, vif->mid, mac_addr);
3142 		if (cid < 0) {
3143 			wil_err(wil, "invalid MAC address %pM\n", mac_addr);
3144 			return -ENOENT;
3145 		}
3146 	} else {
3147 		if (test_bit(wil_vif_fwconnected, vif->status)) {
3148 			wil_err(wil, "must specify MAC address when connected\n");
3149 			return -EINVAL;
3150 		}
3151 	}
3152 
3153 	memset(&cmd, 0, sizeof(cmd));
3154 	cmd.cid = (u8)cid;
3155 	cmd.sector_type = sector_type;
3156 	rc = wmi_call(wil, WMI_GET_SELECTED_RF_SECTOR_INDEX_CMDID, vif->mid,
3157 		      &cmd, sizeof(cmd),
3158 		      WMI_GET_SELECTED_RF_SECTOR_INDEX_DONE_EVENTID,
3159 		      &reply, sizeof(reply),
3160 		      500);
3161 	if (rc)
3162 		return rc;
3163 	if (reply.evt.status) {
3164 		wil_err(wil, "get rf selected sector cfg failed with status %d\n",
3165 			reply.evt.status);
3166 		return wil_rf_sector_status_to_rc(reply.evt.status);
3167 	}
3168 
3169 	msg = cfg80211_vendor_cmd_alloc_reply_skb(
3170 		wiphy, 64 * WMI_MAX_RF_MODULES_NUM);
3171 	if (!msg)
3172 		return -ENOMEM;
3173 
3174 	if (nla_put_u64_64bit(msg, QCA_ATTR_TSF,
3175 			      le64_to_cpu(reply.evt.tsf),
3176 			      QCA_ATTR_PAD) ||
3177 	    nla_put_u16(msg, QCA_ATTR_DMG_RF_SECTOR_INDEX,
3178 			le16_to_cpu(reply.evt.sector_idx)))
3179 		goto nla_put_failure;
3180 
3181 	rc = cfg80211_vendor_cmd_reply(msg);
3182 	return rc;
3183 nla_put_failure:
3184 	kfree_skb(msg);
3185 	return -ENOBUFS;
3186 }
3187 
3188 static int wil_rf_sector_wmi_set_selected(struct wil6210_priv *wil,
3189 					  u8 mid, u16 sector_index,
3190 					  u8 sector_type, u8 cid)
3191 {
3192 	struct wmi_set_selected_rf_sector_index_cmd cmd;
3193 	struct {
3194 		struct wmi_cmd_hdr wmi;
3195 		struct wmi_set_selected_rf_sector_index_done_event evt;
3196 	} __packed reply = {
3197 		.evt = {.status = WMI_RF_SECTOR_STATUS_NOT_SUPPORTED_ERROR},
3198 	};
3199 	int rc;
3200 
3201 	memset(&cmd, 0, sizeof(cmd));
3202 	cmd.sector_idx = cpu_to_le16(sector_index);
3203 	cmd.sector_type = sector_type;
3204 	cmd.cid = (u8)cid;
3205 	rc = wmi_call(wil, WMI_SET_SELECTED_RF_SECTOR_INDEX_CMDID, mid,
3206 		      &cmd, sizeof(cmd),
3207 		      WMI_SET_SELECTED_RF_SECTOR_INDEX_DONE_EVENTID,
3208 		      &reply, sizeof(reply),
3209 		      500);
3210 	if (rc)
3211 		return rc;
3212 	return wil_rf_sector_status_to_rc(reply.evt.status);
3213 }
3214 
3215 static int wil_rf_sector_set_selected(struct wiphy *wiphy,
3216 				      struct wireless_dev *wdev,
3217 				      const void *data, int data_len)
3218 {
3219 	struct wil6210_priv *wil = wdev_to_wil(wdev);
3220 	struct wil6210_vif *vif = wdev_to_vif(wil, wdev);
3221 	int rc;
3222 	struct nlattr *tb[QCA_ATTR_DMG_RF_SECTOR_MAX + 1];
3223 	u16 sector_index;
3224 	u8 sector_type, mac_addr[ETH_ALEN], i;
3225 	int cid = 0;
3226 
3227 	if (!test_bit(WMI_FW_CAPABILITY_RF_SECTORS, wil->fw_capabilities))
3228 		return -EOPNOTSUPP;
3229 
3230 	rc = nla_parse_deprecated(tb, QCA_ATTR_DMG_RF_SECTOR_MAX, data,
3231 				  data_len, wil_rf_sector_policy, NULL);
3232 	if (rc) {
3233 		wil_err(wil, "Invalid rf sector ATTR\n");
3234 		return rc;
3235 	}
3236 
3237 	if (!tb[QCA_ATTR_DMG_RF_SECTOR_INDEX] ||
3238 	    !tb[QCA_ATTR_DMG_RF_SECTOR_TYPE]) {
3239 		wil_err(wil, "Invalid rf sector spec\n");
3240 		return -EINVAL;
3241 	}
3242 
3243 	sector_index = nla_get_u16(
3244 		tb[QCA_ATTR_DMG_RF_SECTOR_INDEX]);
3245 	if (sector_index >= WIL_MAX_RF_SECTORS &&
3246 	    sector_index != WMI_INVALID_RF_SECTOR_INDEX) {
3247 		wil_err(wil, "Invalid sector index %d\n", sector_index);
3248 		return -EINVAL;
3249 	}
3250 
3251 	sector_type = nla_get_u8(tb[QCA_ATTR_DMG_RF_SECTOR_TYPE]);
3252 	if (sector_type >= QCA_ATTR_DMG_RF_SECTOR_TYPE_MAX) {
3253 		wil_err(wil, "Invalid sector type %d\n", sector_type);
3254 		return -EINVAL;
3255 	}
3256 
3257 	if (tb[QCA_ATTR_MAC_ADDR]) {
3258 		ether_addr_copy(mac_addr, nla_data(tb[QCA_ATTR_MAC_ADDR]));
3259 		if (!is_broadcast_ether_addr(mac_addr)) {
3260 			cid = wil_find_cid(wil, vif->mid, mac_addr);
3261 			if (cid < 0) {
3262 				wil_err(wil, "invalid MAC address %pM\n",
3263 					mac_addr);
3264 				return -ENOENT;
3265 			}
3266 		} else {
3267 			if (sector_index != WMI_INVALID_RF_SECTOR_INDEX) {
3268 				wil_err(wil, "broadcast MAC valid only with unlocking\n");
3269 				return -EINVAL;
3270 			}
3271 			cid = -1;
3272 		}
3273 	} else {
3274 		if (test_bit(wil_vif_fwconnected, vif->status)) {
3275 			wil_err(wil, "must specify MAC address when connected\n");
3276 			return -EINVAL;
3277 		}
3278 		/* otherwise, using cid=0 for unassociated station */
3279 	}
3280 
3281 	if (cid >= 0) {
3282 		rc = wil_rf_sector_wmi_set_selected(wil, vif->mid, sector_index,
3283 						    sector_type, cid);
3284 	} else {
3285 		/* unlock all cids */
3286 		rc = wil_rf_sector_wmi_set_selected(
3287 			wil, vif->mid, WMI_INVALID_RF_SECTOR_INDEX,
3288 			sector_type, WIL_CID_ALL);
3289 		if (rc == -EINVAL) {
3290 			for (i = 0; i < wil->max_assoc_sta; i++) {
3291 				if (wil->sta[i].mid != vif->mid)
3292 					continue;
3293 				rc = wil_rf_sector_wmi_set_selected(
3294 					wil, vif->mid,
3295 					WMI_INVALID_RF_SECTOR_INDEX,
3296 					sector_type, i);
3297 				/* the FW will silently ignore and return
3298 				 * success for unused cid, so abort the loop
3299 				 * on any other error
3300 				 */
3301 				if (rc) {
3302 					wil_err(wil, "unlock cid %d failed with status %d\n",
3303 						i, rc);
3304 					break;
3305 				}
3306 			}
3307 		}
3308 	}
3309 
3310 	return rc;
3311 }
3312