xref: /linux/drivers/mfd/twl4030-irq.c (revision df10d6465f135b1e240ca7eb9565a492cf58be7c)
1a30d46c0SDavid Brownell /*
2a30d46c0SDavid Brownell  * twl4030-irq.c - TWL4030/TPS659x0 irq support
3a30d46c0SDavid Brownell  *
4a30d46c0SDavid Brownell  * Copyright (C) 2005-2006 Texas Instruments, Inc.
5a30d46c0SDavid Brownell  *
6a30d46c0SDavid Brownell  * Modifications to defer interrupt handling to a kernel thread:
7a30d46c0SDavid Brownell  * Copyright (C) 2006 MontaVista Software, Inc.
8a30d46c0SDavid Brownell  *
9a30d46c0SDavid Brownell  * Based on tlv320aic23.c:
10a30d46c0SDavid Brownell  * Copyright (c) by Kai Svahn <kai.svahn@nokia.com>
11a30d46c0SDavid Brownell  *
12a30d46c0SDavid Brownell  * Code cleanup and modifications to IRQ handler.
13a30d46c0SDavid Brownell  * by syed khasim <x0khasim@ti.com>
14a30d46c0SDavid Brownell  *
15a30d46c0SDavid Brownell  * This program is free software; you can redistribute it and/or modify
16a30d46c0SDavid Brownell  * it under the terms of the GNU General Public License as published by
17a30d46c0SDavid Brownell  * the Free Software Foundation; either version 2 of the License, or
18a30d46c0SDavid Brownell  * (at your option) any later version.
19a30d46c0SDavid Brownell  *
20a30d46c0SDavid Brownell  * This program is distributed in the hope that it will be useful,
21a30d46c0SDavid Brownell  * but WITHOUT ANY WARRANTY; without even the implied warranty of
22a30d46c0SDavid Brownell  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
23a30d46c0SDavid Brownell  * GNU General Public License for more details.
24a30d46c0SDavid Brownell  *
25a30d46c0SDavid Brownell  * You should have received a copy of the GNU General Public License
26a30d46c0SDavid Brownell  * along with this program; if not, write to the Free Software
27a30d46c0SDavid Brownell  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA
28a30d46c0SDavid Brownell  */
29a30d46c0SDavid Brownell 
30a30d46c0SDavid Brownell #include <linux/init.h>
31a30d46c0SDavid Brownell #include <linux/interrupt.h>
32a30d46c0SDavid Brownell #include <linux/irq.h>
33a30d46c0SDavid Brownell #include <linux/kthread.h>
34a30d46c0SDavid Brownell 
35a30d46c0SDavid Brownell #include <linux/i2c/twl4030.h>
36a30d46c0SDavid Brownell 
37a30d46c0SDavid Brownell 
38a30d46c0SDavid Brownell /*
39a30d46c0SDavid Brownell  * TWL4030 IRQ handling has two stages in hardware, and thus in software.
40a30d46c0SDavid Brownell  * The Primary Interrupt Handler (PIH) stage exposes status bits saying
41a30d46c0SDavid Brownell  * which Secondary Interrupt Handler (SIH) stage is raising an interrupt.
42a30d46c0SDavid Brownell  * SIH modules are more traditional IRQ components, which support per-IRQ
43a30d46c0SDavid Brownell  * enable/disable and trigger controls; they do most of the work.
44a30d46c0SDavid Brownell  *
45a30d46c0SDavid Brownell  * These chips are designed to support IRQ handling from two different
46a30d46c0SDavid Brownell  * I2C masters.  Each has a dedicated IRQ line, and dedicated IRQ status
47a30d46c0SDavid Brownell  * and mask registers in the PIH and SIH modules.
48a30d46c0SDavid Brownell  *
49a30d46c0SDavid Brownell  * We set up IRQs starting at a platform-specified base, always starting
50a30d46c0SDavid Brownell  * with PIH and the SIH for PWR_INT and then usually adding GPIO:
51a30d46c0SDavid Brownell  *	base + 0  .. base + 7	PIH
52a30d46c0SDavid Brownell  *	base + 8  .. base + 15	SIH for PWR_INT
53a30d46c0SDavid Brownell  *	base + 16 .. base + 33	SIH for GPIO
54a30d46c0SDavid Brownell  */
55a30d46c0SDavid Brownell 
56a30d46c0SDavid Brownell /* PIH register offsets */
57a30d46c0SDavid Brownell #define REG_PIH_ISR_P1			0x01
58a30d46c0SDavid Brownell #define REG_PIH_ISR_P2			0x02
59a30d46c0SDavid Brownell #define REG_PIH_SIR			0x03	/* for testing */
60a30d46c0SDavid Brownell 
61a30d46c0SDavid Brownell 
62a30d46c0SDavid Brownell /* Linux could (eventually) use either IRQ line */
63a30d46c0SDavid Brownell static int irq_line;
64a30d46c0SDavid Brownell 
65a30d46c0SDavid Brownell struct sih {
66a30d46c0SDavid Brownell 	char	name[8];
67a30d46c0SDavid Brownell 	u8	module;			/* module id */
68a30d46c0SDavid Brownell 	u8	control_offset;		/* for SIH_CTRL */
69a30d46c0SDavid Brownell 	bool	set_cor;
70a30d46c0SDavid Brownell 
71a30d46c0SDavid Brownell 	u8	bits;			/* valid in isr/imr */
72a30d46c0SDavid Brownell 	u8	bytes_ixr;		/* bytelen of ISR/IMR/SIR */
73a30d46c0SDavid Brownell 
74a30d46c0SDavid Brownell 	u8	edr_offset;
75a30d46c0SDavid Brownell 	u8	bytes_edr;		/* bytelen of EDR */
76a30d46c0SDavid Brownell 
77a30d46c0SDavid Brownell 	/* SIR ignored -- set interrupt, for testing only */
78a30d46c0SDavid Brownell 	struct irq_data {
79a30d46c0SDavid Brownell 		u8	isr_offset;
80a30d46c0SDavid Brownell 		u8	imr_offset;
81a30d46c0SDavid Brownell 	} mask[2];
82a30d46c0SDavid Brownell 	/* + 2 bytes padding */
83a30d46c0SDavid Brownell };
84a30d46c0SDavid Brownell 
85a30d46c0SDavid Brownell #define SIH_INITIALIZER(modname, nbits) \
86a30d46c0SDavid Brownell 	.module		= TWL4030_MODULE_ ## modname, \
87a30d46c0SDavid Brownell 	.control_offset = TWL4030_ ## modname ## _SIH_CTRL, \
88a30d46c0SDavid Brownell 	.bits		= nbits, \
89a30d46c0SDavid Brownell 	.bytes_ixr	= DIV_ROUND_UP(nbits, 8), \
90a30d46c0SDavid Brownell 	.edr_offset	= TWL4030_ ## modname ## _EDR, \
91a30d46c0SDavid Brownell 	.bytes_edr	= DIV_ROUND_UP((2*(nbits)), 8), \
92a30d46c0SDavid Brownell 	.mask = { { \
93a30d46c0SDavid Brownell 		.isr_offset	= TWL4030_ ## modname ## _ISR1, \
94a30d46c0SDavid Brownell 		.imr_offset	= TWL4030_ ## modname ## _IMR1, \
95a30d46c0SDavid Brownell 	}, \
96a30d46c0SDavid Brownell 	{ \
97a30d46c0SDavid Brownell 		.isr_offset	= TWL4030_ ## modname ## _ISR2, \
98a30d46c0SDavid Brownell 		.imr_offset	= TWL4030_ ## modname ## _IMR2, \
99a30d46c0SDavid Brownell 	}, },
100a30d46c0SDavid Brownell 
101a30d46c0SDavid Brownell /* register naming policies are inconsistent ... */
102a30d46c0SDavid Brownell #define TWL4030_INT_PWR_EDR		TWL4030_INT_PWR_EDR1
103a30d46c0SDavid Brownell #define TWL4030_MODULE_KEYPAD_KEYP	TWL4030_MODULE_KEYPAD
104a30d46c0SDavid Brownell #define TWL4030_MODULE_INT_PWR		TWL4030_MODULE_INT
105a30d46c0SDavid Brownell 
106a30d46c0SDavid Brownell 
107a30d46c0SDavid Brownell /* Order in this table matches order in PIH_ISR.  That is,
108a30d46c0SDavid Brownell  * BIT(n) in PIH_ISR is sih_modules[n].
109a30d46c0SDavid Brownell  */
110a30d46c0SDavid Brownell static const struct sih sih_modules[6] = {
111a30d46c0SDavid Brownell 	[0] = {
112a30d46c0SDavid Brownell 		.name		= "gpio",
113a30d46c0SDavid Brownell 		.module		= TWL4030_MODULE_GPIO,
114a30d46c0SDavid Brownell 		.control_offset	= REG_GPIO_SIH_CTRL,
115a30d46c0SDavid Brownell 		.set_cor	= true,
116a30d46c0SDavid Brownell 		.bits		= TWL4030_GPIO_MAX,
117a30d46c0SDavid Brownell 		.bytes_ixr	= 3,
118a30d46c0SDavid Brownell 		/* Note: *all* of these IRQs default to no-trigger */
119a30d46c0SDavid Brownell 		.edr_offset	= REG_GPIO_EDR1,
120a30d46c0SDavid Brownell 		.bytes_edr	= 5,
121a30d46c0SDavid Brownell 		.mask = { {
122a30d46c0SDavid Brownell 			.isr_offset	= REG_GPIO_ISR1A,
123a30d46c0SDavid Brownell 			.imr_offset	= REG_GPIO_IMR1A,
124a30d46c0SDavid Brownell 		}, {
125a30d46c0SDavid Brownell 			.isr_offset	= REG_GPIO_ISR1B,
126a30d46c0SDavid Brownell 			.imr_offset	= REG_GPIO_IMR1B,
127a30d46c0SDavid Brownell 		}, },
128a30d46c0SDavid Brownell 	},
129a30d46c0SDavid Brownell 	[1] = {
130a30d46c0SDavid Brownell 		.name		= "keypad",
131a30d46c0SDavid Brownell 		.set_cor	= true,
132a30d46c0SDavid Brownell 		SIH_INITIALIZER(KEYPAD_KEYP, 4)
133a30d46c0SDavid Brownell 	},
134a30d46c0SDavid Brownell 	[2] = {
135a30d46c0SDavid Brownell 		.name		= "bci",
136a30d46c0SDavid Brownell 		.module		= TWL4030_MODULE_INTERRUPTS,
137a30d46c0SDavid Brownell 		.control_offset	= TWL4030_INTERRUPTS_BCISIHCTRL,
138a30d46c0SDavid Brownell 		.bits		= 12,
139a30d46c0SDavid Brownell 		.bytes_ixr	= 2,
140a30d46c0SDavid Brownell 		.edr_offset	= TWL4030_INTERRUPTS_BCIEDR1,
141a30d46c0SDavid Brownell 		/* Note: most of these IRQs default to no-trigger */
142a30d46c0SDavid Brownell 		.bytes_edr	= 3,
143a30d46c0SDavid Brownell 		.mask = { {
144a30d46c0SDavid Brownell 			.isr_offset	= TWL4030_INTERRUPTS_BCIISR1A,
145a30d46c0SDavid Brownell 			.imr_offset	= TWL4030_INTERRUPTS_BCIIMR1A,
146a30d46c0SDavid Brownell 		}, {
147a30d46c0SDavid Brownell 			.isr_offset	= TWL4030_INTERRUPTS_BCIISR1B,
148a30d46c0SDavid Brownell 			.imr_offset	= TWL4030_INTERRUPTS_BCIIMR1B,
149a30d46c0SDavid Brownell 		}, },
150a30d46c0SDavid Brownell 	},
151a30d46c0SDavid Brownell 	[3] = {
152a30d46c0SDavid Brownell 		.name		= "madc",
153a30d46c0SDavid Brownell 		SIH_INITIALIZER(MADC, 4)
154a30d46c0SDavid Brownell 	},
155a30d46c0SDavid Brownell 	[4] = {
156a30d46c0SDavid Brownell 		/* USB doesn't use the same SIH organization */
157a30d46c0SDavid Brownell 		.name		= "usb",
158a30d46c0SDavid Brownell 	},
159a30d46c0SDavid Brownell 	[5] = {
160a30d46c0SDavid Brownell 		.name		= "power",
161a30d46c0SDavid Brownell 		.set_cor	= true,
162a30d46c0SDavid Brownell 		SIH_INITIALIZER(INT_PWR, 8)
163a30d46c0SDavid Brownell 	},
164a30d46c0SDavid Brownell 		/* there are no SIH modules #6 or #7 ... */
165a30d46c0SDavid Brownell };
166a30d46c0SDavid Brownell 
167a30d46c0SDavid Brownell #undef TWL4030_MODULE_KEYPAD_KEYP
168a30d46c0SDavid Brownell #undef TWL4030_MODULE_INT_PWR
169a30d46c0SDavid Brownell #undef TWL4030_INT_PWR_EDR
170a30d46c0SDavid Brownell 
171a30d46c0SDavid Brownell /*----------------------------------------------------------------------*/
172a30d46c0SDavid Brownell 
173a30d46c0SDavid Brownell static unsigned twl4030_irq_base;
174a30d46c0SDavid Brownell 
175a30d46c0SDavid Brownell static struct completion irq_event;
176a30d46c0SDavid Brownell 
177a30d46c0SDavid Brownell /*
178a30d46c0SDavid Brownell  * This thread processes interrupts reported by the Primary Interrupt Handler.
179a30d46c0SDavid Brownell  */
180a30d46c0SDavid Brownell static int twl4030_irq_thread(void *data)
181a30d46c0SDavid Brownell {
182a30d46c0SDavid Brownell 	long irq = (long)data;
183a30d46c0SDavid Brownell 	static unsigned i2c_errors;
1843446d4bbSTobias Klauser 	static const unsigned max_i2c_errors = 100;
185a30d46c0SDavid Brownell 
18694964f96SSamuel Ortiz 
187a30d46c0SDavid Brownell 	current->flags |= PF_NOFREEZE;
188a30d46c0SDavid Brownell 
189a30d46c0SDavid Brownell 	while (!kthread_should_stop()) {
190a30d46c0SDavid Brownell 		int ret;
191a30d46c0SDavid Brownell 		int module_irq;
192a30d46c0SDavid Brownell 		u8 pih_isr;
193a30d46c0SDavid Brownell 
194a30d46c0SDavid Brownell 		/* Wait for IRQ, then read PIH irq status (also blocking) */
195a30d46c0SDavid Brownell 		wait_for_completion_interruptible(&irq_event);
196a30d46c0SDavid Brownell 
197a30d46c0SDavid Brownell 		ret = twl4030_i2c_read_u8(TWL4030_MODULE_PIH, &pih_isr,
198a30d46c0SDavid Brownell 					  REG_PIH_ISR_P1);
199a30d46c0SDavid Brownell 		if (ret) {
200a30d46c0SDavid Brownell 			pr_warning("twl4030: I2C error %d reading PIH ISR\n",
201a30d46c0SDavid Brownell 					ret);
202a30d46c0SDavid Brownell 			if (++i2c_errors >= max_i2c_errors) {
203a30d46c0SDavid Brownell 				printk(KERN_ERR "Maximum I2C error count"
204a30d46c0SDavid Brownell 						" exceeded.  Terminating %s.\n",
205a30d46c0SDavid Brownell 						__func__);
206a30d46c0SDavid Brownell 				break;
207a30d46c0SDavid Brownell 			}
208a30d46c0SDavid Brownell 			complete(&irq_event);
209a30d46c0SDavid Brownell 			continue;
210a30d46c0SDavid Brownell 		}
211a30d46c0SDavid Brownell 
212a30d46c0SDavid Brownell 		/* these handlers deal with the relevant SIH irq status */
213a30d46c0SDavid Brownell 		local_irq_disable();
214a30d46c0SDavid Brownell 		for (module_irq = twl4030_irq_base;
215a30d46c0SDavid Brownell 				pih_isr;
216a30d46c0SDavid Brownell 				pih_isr >>= 1, module_irq++) {
217a30d46c0SDavid Brownell 			if (pih_isr & 0x1) {
21894964f96SSamuel Ortiz 				struct irq_desc *d = irq_to_desc(module_irq);
21994964f96SSamuel Ortiz 
22094964f96SSamuel Ortiz 				if (!d) {
22194964f96SSamuel Ortiz 					pr_err("twl4030: Invalid SIH IRQ: %d\n",
22294964f96SSamuel Ortiz 					       module_irq);
22394964f96SSamuel Ortiz 					return -EINVAL;
22494964f96SSamuel Ortiz 				}
225a30d46c0SDavid Brownell 
226a30d46c0SDavid Brownell 				/* These can't be masked ... always warn
227a30d46c0SDavid Brownell 				 * if we get any surprises.
228a30d46c0SDavid Brownell 				 */
229a30d46c0SDavid Brownell 				if (d->status & IRQ_DISABLED)
230a30d46c0SDavid Brownell 					note_interrupt(module_irq, d,
231a30d46c0SDavid Brownell 							IRQ_NONE);
232a30d46c0SDavid Brownell 				else
233a30d46c0SDavid Brownell 					d->handle_irq(module_irq, d);
234a30d46c0SDavid Brownell 			}
235a30d46c0SDavid Brownell 		}
236a30d46c0SDavid Brownell 		local_irq_enable();
237a30d46c0SDavid Brownell 
2381cef8e41SRussell King 		enable_irq(irq);
239a30d46c0SDavid Brownell 	}
240a30d46c0SDavid Brownell 
241a30d46c0SDavid Brownell 	return 0;
242a30d46c0SDavid Brownell }
243a30d46c0SDavid Brownell 
244a30d46c0SDavid Brownell /*
245a30d46c0SDavid Brownell  * handle_twl4030_pih() is the desc->handle method for the twl4030 interrupt.
246a30d46c0SDavid Brownell  * This is a chained interrupt, so there is no desc->action method for it.
247a30d46c0SDavid Brownell  * Now we need to query the interrupt controller in the twl4030 to determine
248a30d46c0SDavid Brownell  * which module is generating the interrupt request.  However, we can't do i2c
249a30d46c0SDavid Brownell  * transactions in interrupt context, so we must defer that work to a kernel
250a30d46c0SDavid Brownell  * thread.  All we do here is acknowledge and mask the interrupt and wakeup
251a30d46c0SDavid Brownell  * the kernel thread.
252a30d46c0SDavid Brownell  */
2531cef8e41SRussell King static irqreturn_t handle_twl4030_pih(int irq, void *devid)
254a30d46c0SDavid Brownell {
255a30d46c0SDavid Brownell 	/* Acknowledge, clear *AND* mask the interrupt... */
2561cef8e41SRussell King 	disable_irq_nosync(irq);
2571cef8e41SRussell King 	complete(devid);
2581cef8e41SRussell King 	return IRQ_HANDLED;
259a30d46c0SDavid Brownell }
260a30d46c0SDavid Brownell /*----------------------------------------------------------------------*/
261a30d46c0SDavid Brownell 
262a30d46c0SDavid Brownell /*
263a30d46c0SDavid Brownell  * twl4030_init_sih_modules() ... start from a known state where no
264a30d46c0SDavid Brownell  * IRQs will be coming in, and where we can quickly enable them then
265a30d46c0SDavid Brownell  * handle them as they arrive.  Mask all IRQs: maybe init SIH_CTRL.
266a30d46c0SDavid Brownell  *
267a30d46c0SDavid Brownell  * NOTE:  we don't touch EDR registers here; they stay with hardware
268a30d46c0SDavid Brownell  * defaults or whatever the last value was.  Note that when both EDR
269a30d46c0SDavid Brownell  * bits for an IRQ are clear, that's as if its IMR bit is set...
270a30d46c0SDavid Brownell  */
271a30d46c0SDavid Brownell static int twl4030_init_sih_modules(unsigned line)
272a30d46c0SDavid Brownell {
273a30d46c0SDavid Brownell 	const struct sih *sih;
274a30d46c0SDavid Brownell 	u8 buf[4];
275a30d46c0SDavid Brownell 	int i;
276a30d46c0SDavid Brownell 	int status;
277a30d46c0SDavid Brownell 
278a30d46c0SDavid Brownell 	/* line 0 == int1_n signal; line 1 == int2_n signal */
279a30d46c0SDavid Brownell 	if (line > 1)
280a30d46c0SDavid Brownell 		return -EINVAL;
281a30d46c0SDavid Brownell 
282a30d46c0SDavid Brownell 	irq_line = line;
283a30d46c0SDavid Brownell 
284a30d46c0SDavid Brownell 	/* disable all interrupts on our line */
285a30d46c0SDavid Brownell 	memset(buf, 0xff, sizeof buf);
286a30d46c0SDavid Brownell 	sih = sih_modules;
287a30d46c0SDavid Brownell 	for (i = 0; i < ARRAY_SIZE(sih_modules); i++, sih++) {
288a30d46c0SDavid Brownell 
289a30d46c0SDavid Brownell 		/* skip USB -- it's funky */
290a30d46c0SDavid Brownell 		if (!sih->bytes_ixr)
291a30d46c0SDavid Brownell 			continue;
292a30d46c0SDavid Brownell 
293a30d46c0SDavid Brownell 		status = twl4030_i2c_write(sih->module, buf,
294a30d46c0SDavid Brownell 				sih->mask[line].imr_offset, sih->bytes_ixr);
295a30d46c0SDavid Brownell 		if (status < 0)
296a30d46c0SDavid Brownell 			pr_err("twl4030: err %d initializing %s %s\n",
297a30d46c0SDavid Brownell 					status, sih->name, "IMR");
298a30d46c0SDavid Brownell 
299a30d46c0SDavid Brownell 		/* Maybe disable "exclusive" mode; buffer second pending irq;
300a30d46c0SDavid Brownell 		 * set Clear-On-Read (COR) bit.
301a30d46c0SDavid Brownell 		 *
302a30d46c0SDavid Brownell 		 * NOTE that sometimes COR polarity is documented as being
303a30d46c0SDavid Brownell 		 * inverted:  for MADC and BCI, COR=1 means "clear on write".
304a30d46c0SDavid Brownell 		 * And for PWR_INT it's not documented...
305a30d46c0SDavid Brownell 		 */
306a30d46c0SDavid Brownell 		if (sih->set_cor) {
307a30d46c0SDavid Brownell 			status = twl4030_i2c_write_u8(sih->module,
308a30d46c0SDavid Brownell 					TWL4030_SIH_CTRL_COR_MASK,
309a30d46c0SDavid Brownell 					sih->control_offset);
310a30d46c0SDavid Brownell 			if (status < 0)
311a30d46c0SDavid Brownell 				pr_err("twl4030: err %d initializing %s %s\n",
312a30d46c0SDavid Brownell 						status, sih->name, "SIH_CTRL");
313a30d46c0SDavid Brownell 		}
314a30d46c0SDavid Brownell 	}
315a30d46c0SDavid Brownell 
316a30d46c0SDavid Brownell 	sih = sih_modules;
317a30d46c0SDavid Brownell 	for (i = 0; i < ARRAY_SIZE(sih_modules); i++, sih++) {
318a30d46c0SDavid Brownell 		u8 rxbuf[4];
319a30d46c0SDavid Brownell 		int j;
320a30d46c0SDavid Brownell 
321a30d46c0SDavid Brownell 		/* skip USB */
322a30d46c0SDavid Brownell 		if (!sih->bytes_ixr)
323a30d46c0SDavid Brownell 			continue;
324a30d46c0SDavid Brownell 
325a30d46c0SDavid Brownell 		/* Clear pending interrupt status.  Either the read was
326a30d46c0SDavid Brownell 		 * enough, or we need to write those bits.  Repeat, in
327a30d46c0SDavid Brownell 		 * case an IRQ is pending (PENDDIS=0) ... that's not
328a30d46c0SDavid Brownell 		 * uncommon with PWR_INT.PWRON.
329a30d46c0SDavid Brownell 		 */
330a30d46c0SDavid Brownell 		for (j = 0; j < 2; j++) {
331a30d46c0SDavid Brownell 			status = twl4030_i2c_read(sih->module, rxbuf,
332a30d46c0SDavid Brownell 				sih->mask[line].isr_offset, sih->bytes_ixr);
333a30d46c0SDavid Brownell 			if (status < 0)
334a30d46c0SDavid Brownell 				pr_err("twl4030: err %d initializing %s %s\n",
335a30d46c0SDavid Brownell 					status, sih->name, "ISR");
336a30d46c0SDavid Brownell 
337a30d46c0SDavid Brownell 			if (!sih->set_cor)
338a30d46c0SDavid Brownell 				status = twl4030_i2c_write(sih->module, buf,
339a30d46c0SDavid Brownell 					sih->mask[line].isr_offset,
340a30d46c0SDavid Brownell 					sih->bytes_ixr);
341a30d46c0SDavid Brownell 			/* else COR=1 means read sufficed.
342a30d46c0SDavid Brownell 			 * (for most SIH modules...)
343a30d46c0SDavid Brownell 			 */
344a30d46c0SDavid Brownell 		}
345a30d46c0SDavid Brownell 	}
346a30d46c0SDavid Brownell 
347a30d46c0SDavid Brownell 	return 0;
348a30d46c0SDavid Brownell }
349a30d46c0SDavid Brownell 
350a30d46c0SDavid Brownell static inline void activate_irq(int irq)
351a30d46c0SDavid Brownell {
352a30d46c0SDavid Brownell #ifdef CONFIG_ARM
353a30d46c0SDavid Brownell 	/* ARM requires an extra step to clear IRQ_NOREQUEST, which it
354a30d46c0SDavid Brownell 	 * sets on behalf of every irq_chip.  Also sets IRQ_NOPROBE.
355a30d46c0SDavid Brownell 	 */
356a30d46c0SDavid Brownell 	set_irq_flags(irq, IRQF_VALID);
357a30d46c0SDavid Brownell #else
358a30d46c0SDavid Brownell 	/* same effect on other architectures */
359a30d46c0SDavid Brownell 	set_irq_noprobe(irq);
360a30d46c0SDavid Brownell #endif
361a30d46c0SDavid Brownell }
362a30d46c0SDavid Brownell 
363a30d46c0SDavid Brownell /*----------------------------------------------------------------------*/
364a30d46c0SDavid Brownell 
365a30d46c0SDavid Brownell static DEFINE_SPINLOCK(sih_agent_lock);
366a30d46c0SDavid Brownell 
367a30d46c0SDavid Brownell static struct workqueue_struct *wq;
368a30d46c0SDavid Brownell 
369a30d46c0SDavid Brownell struct sih_agent {
370a30d46c0SDavid Brownell 	int			irq_base;
371a30d46c0SDavid Brownell 	const struct sih	*sih;
372a30d46c0SDavid Brownell 
373a30d46c0SDavid Brownell 	u32			imr;
374a30d46c0SDavid Brownell 	bool			imr_change_pending;
375a30d46c0SDavid Brownell 	struct work_struct	mask_work;
376a30d46c0SDavid Brownell 
377a30d46c0SDavid Brownell 	u32			edge_change;
378a30d46c0SDavid Brownell 	struct work_struct	edge_work;
379a30d46c0SDavid Brownell };
380a30d46c0SDavid Brownell 
381a30d46c0SDavid Brownell static void twl4030_sih_do_mask(struct work_struct *work)
382a30d46c0SDavid Brownell {
383a30d46c0SDavid Brownell 	struct sih_agent	*agent;
384a30d46c0SDavid Brownell 	const struct sih	*sih;
385a30d46c0SDavid Brownell 	union {
386a30d46c0SDavid Brownell 		u8	bytes[4];
387a30d46c0SDavid Brownell 		u32	word;
388a30d46c0SDavid Brownell 	}			imr;
389a30d46c0SDavid Brownell 	int			status;
390a30d46c0SDavid Brownell 
391a30d46c0SDavid Brownell 	agent = container_of(work, struct sih_agent, mask_work);
392a30d46c0SDavid Brownell 
393a30d46c0SDavid Brownell 	/* see what work we have */
394a30d46c0SDavid Brownell 	spin_lock_irq(&sih_agent_lock);
395a30d46c0SDavid Brownell 	if (agent->imr_change_pending) {
396a30d46c0SDavid Brownell 		sih = agent->sih;
397a30d46c0SDavid Brownell 		/* byte[0] gets overwritten as we write ... */
398a30d46c0SDavid Brownell 		imr.word = cpu_to_le32(agent->imr << 8);
399a30d46c0SDavid Brownell 		agent->imr_change_pending = false;
400a30d46c0SDavid Brownell 	} else
401a30d46c0SDavid Brownell 		sih = NULL;
402a30d46c0SDavid Brownell 	spin_unlock_irq(&sih_agent_lock);
403a30d46c0SDavid Brownell 	if (!sih)
404a30d46c0SDavid Brownell 		return;
405a30d46c0SDavid Brownell 
406a30d46c0SDavid Brownell 	/* write the whole mask ... simpler than subsetting it */
407a30d46c0SDavid Brownell 	status = twl4030_i2c_write(sih->module, imr.bytes,
408a30d46c0SDavid Brownell 			sih->mask[irq_line].imr_offset, sih->bytes_ixr);
409a30d46c0SDavid Brownell 	if (status)
410a30d46c0SDavid Brownell 		pr_err("twl4030: %s, %s --> %d\n", __func__,
411a30d46c0SDavid Brownell 				"write", status);
412a30d46c0SDavid Brownell }
413a30d46c0SDavid Brownell 
414a30d46c0SDavid Brownell static void twl4030_sih_do_edge(struct work_struct *work)
415a30d46c0SDavid Brownell {
416a30d46c0SDavid Brownell 	struct sih_agent	*agent;
417a30d46c0SDavid Brownell 	const struct sih	*sih;
418a30d46c0SDavid Brownell 	u8			bytes[6];
419a30d46c0SDavid Brownell 	u32			edge_change;
420a30d46c0SDavid Brownell 	int			status;
421a30d46c0SDavid Brownell 
422a30d46c0SDavid Brownell 	agent = container_of(work, struct sih_agent, edge_work);
423a30d46c0SDavid Brownell 
424a30d46c0SDavid Brownell 	/* see what work we have */
425a30d46c0SDavid Brownell 	spin_lock_irq(&sih_agent_lock);
426a30d46c0SDavid Brownell 	edge_change = agent->edge_change;
427*df10d646SJoe Perches 	agent->edge_change = 0;
428a30d46c0SDavid Brownell 	sih = edge_change ? agent->sih : NULL;
429a30d46c0SDavid Brownell 	spin_unlock_irq(&sih_agent_lock);
430a30d46c0SDavid Brownell 	if (!sih)
431a30d46c0SDavid Brownell 		return;
432a30d46c0SDavid Brownell 
433a30d46c0SDavid Brownell 	/* Read, reserving first byte for write scratch.  Yes, this
434a30d46c0SDavid Brownell 	 * could be cached for some speedup ... but be careful about
435a30d46c0SDavid Brownell 	 * any processor on the other IRQ line, EDR registers are
436a30d46c0SDavid Brownell 	 * shared.
437a30d46c0SDavid Brownell 	 */
438a30d46c0SDavid Brownell 	status = twl4030_i2c_read(sih->module, bytes + 1,
439a30d46c0SDavid Brownell 			sih->edr_offset, sih->bytes_edr);
440a30d46c0SDavid Brownell 	if (status) {
441a30d46c0SDavid Brownell 		pr_err("twl4030: %s, %s --> %d\n", __func__,
442a30d46c0SDavid Brownell 				"read", status);
443a30d46c0SDavid Brownell 		return;
444a30d46c0SDavid Brownell 	}
445a30d46c0SDavid Brownell 
446a30d46c0SDavid Brownell 	/* Modify only the bits we know must change */
447a30d46c0SDavid Brownell 	while (edge_change) {
448a30d46c0SDavid Brownell 		int		i = fls(edge_change) - 1;
44994964f96SSamuel Ortiz 		struct irq_desc	*d = irq_to_desc(i + agent->irq_base);
450a30d46c0SDavid Brownell 		int		byte = 1 + (i >> 2);
451a30d46c0SDavid Brownell 		int		off = (i & 0x3) * 2;
452a30d46c0SDavid Brownell 
45394964f96SSamuel Ortiz 		if (!d) {
45494964f96SSamuel Ortiz 			pr_err("twl4030: Invalid IRQ: %d\n",
45594964f96SSamuel Ortiz 			       i + agent->irq_base);
45694964f96SSamuel Ortiz 			return;
45794964f96SSamuel Ortiz 		}
45894964f96SSamuel Ortiz 
459a30d46c0SDavid Brownell 		bytes[byte] &= ~(0x03 << off);
460a30d46c0SDavid Brownell 
461a30d46c0SDavid Brownell 		spin_lock_irq(&d->lock);
462a30d46c0SDavid Brownell 		if (d->status & IRQ_TYPE_EDGE_RISING)
463a30d46c0SDavid Brownell 			bytes[byte] |= BIT(off + 1);
464a30d46c0SDavid Brownell 		if (d->status & IRQ_TYPE_EDGE_FALLING)
465a30d46c0SDavid Brownell 			bytes[byte] |= BIT(off + 0);
466a30d46c0SDavid Brownell 		spin_unlock_irq(&d->lock);
467a30d46c0SDavid Brownell 
468a30d46c0SDavid Brownell 		edge_change &= ~BIT(i);
469a30d46c0SDavid Brownell 	}
470a30d46c0SDavid Brownell 
471a30d46c0SDavid Brownell 	/* Write */
472a30d46c0SDavid Brownell 	status = twl4030_i2c_write(sih->module, bytes,
473a30d46c0SDavid Brownell 			sih->edr_offset, sih->bytes_edr);
474a30d46c0SDavid Brownell 	if (status)
475a30d46c0SDavid Brownell 		pr_err("twl4030: %s, %s --> %d\n", __func__,
476a30d46c0SDavid Brownell 				"write", status);
477a30d46c0SDavid Brownell }
478a30d46c0SDavid Brownell 
479a30d46c0SDavid Brownell /*----------------------------------------------------------------------*/
480a30d46c0SDavid Brownell 
481a30d46c0SDavid Brownell /*
482a30d46c0SDavid Brownell  * All irq_chip methods get issued from code holding irq_desc[irq].lock,
483a30d46c0SDavid Brownell  * which can't perform the underlying I2C operations (because they sleep).
484a30d46c0SDavid Brownell  * So we must hand them off to a thread (workqueue) and cope with asynch
485a30d46c0SDavid Brownell  * completion, potentially including some re-ordering, of these requests.
486a30d46c0SDavid Brownell  */
487a30d46c0SDavid Brownell 
488a30d46c0SDavid Brownell static void twl4030_sih_mask(unsigned irq)
489a30d46c0SDavid Brownell {
490a30d46c0SDavid Brownell 	struct sih_agent *sih = get_irq_chip_data(irq);
491a30d46c0SDavid Brownell 	unsigned long flags;
492a30d46c0SDavid Brownell 
493a30d46c0SDavid Brownell 	spin_lock_irqsave(&sih_agent_lock, flags);
494a30d46c0SDavid Brownell 	sih->imr |= BIT(irq - sih->irq_base);
495a30d46c0SDavid Brownell 	sih->imr_change_pending = true;
496a30d46c0SDavid Brownell 	queue_work(wq, &sih->mask_work);
497a30d46c0SDavid Brownell 	spin_unlock_irqrestore(&sih_agent_lock, flags);
498a30d46c0SDavid Brownell }
499a30d46c0SDavid Brownell 
500a30d46c0SDavid Brownell static void twl4030_sih_unmask(unsigned irq)
501a30d46c0SDavid Brownell {
502a30d46c0SDavid Brownell 	struct sih_agent *sih = get_irq_chip_data(irq);
503a30d46c0SDavid Brownell 	unsigned long flags;
504a30d46c0SDavid Brownell 
505a30d46c0SDavid Brownell 	spin_lock_irqsave(&sih_agent_lock, flags);
506a30d46c0SDavid Brownell 	sih->imr &= ~BIT(irq - sih->irq_base);
507a30d46c0SDavid Brownell 	sih->imr_change_pending = true;
508a30d46c0SDavid Brownell 	queue_work(wq, &sih->mask_work);
509a30d46c0SDavid Brownell 	spin_unlock_irqrestore(&sih_agent_lock, flags);
510a30d46c0SDavid Brownell }
511a30d46c0SDavid Brownell 
512a30d46c0SDavid Brownell static int twl4030_sih_set_type(unsigned irq, unsigned trigger)
513a30d46c0SDavid Brownell {
514a30d46c0SDavid Brownell 	struct sih_agent *sih = get_irq_chip_data(irq);
51594964f96SSamuel Ortiz 	struct irq_desc *desc = irq_to_desc(irq);
516a30d46c0SDavid Brownell 	unsigned long flags;
517a30d46c0SDavid Brownell 
51894964f96SSamuel Ortiz 	if (!desc) {
51994964f96SSamuel Ortiz 		pr_err("twl4030: Invalid IRQ: %d\n", irq);
52094964f96SSamuel Ortiz 		return -EINVAL;
52194964f96SSamuel Ortiz 	}
52294964f96SSamuel Ortiz 
523a30d46c0SDavid Brownell 	if (trigger & ~(IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))
524a30d46c0SDavid Brownell 		return -EINVAL;
525a30d46c0SDavid Brownell 
526a30d46c0SDavid Brownell 	spin_lock_irqsave(&sih_agent_lock, flags);
527a30d46c0SDavid Brownell 	if ((desc->status & IRQ_TYPE_SENSE_MASK) != trigger) {
528a30d46c0SDavid Brownell 		desc->status &= ~IRQ_TYPE_SENSE_MASK;
529a30d46c0SDavid Brownell 		desc->status |= trigger;
530a30d46c0SDavid Brownell 		sih->edge_change |= BIT(irq - sih->irq_base);
531a30d46c0SDavid Brownell 		queue_work(wq, &sih->edge_work);
532a30d46c0SDavid Brownell 	}
533a30d46c0SDavid Brownell 	spin_unlock_irqrestore(&sih_agent_lock, flags);
534a30d46c0SDavid Brownell 	return 0;
535a30d46c0SDavid Brownell }
536a30d46c0SDavid Brownell 
537a30d46c0SDavid Brownell static struct irq_chip twl4030_sih_irq_chip = {
538a30d46c0SDavid Brownell 	.name		= "twl4030",
539a30d46c0SDavid Brownell 	.mask		= twl4030_sih_mask,
540a30d46c0SDavid Brownell 	.unmask		= twl4030_sih_unmask,
541a30d46c0SDavid Brownell 	.set_type	= twl4030_sih_set_type,
542a30d46c0SDavid Brownell };
543a30d46c0SDavid Brownell 
544a30d46c0SDavid Brownell /*----------------------------------------------------------------------*/
545a30d46c0SDavid Brownell 
546a30d46c0SDavid Brownell static inline int sih_read_isr(const struct sih *sih)
547a30d46c0SDavid Brownell {
548a30d46c0SDavid Brownell 	int status;
549a30d46c0SDavid Brownell 	union {
550a30d46c0SDavid Brownell 		u8 bytes[4];
551a30d46c0SDavid Brownell 		u32 word;
552a30d46c0SDavid Brownell 	} isr;
553a30d46c0SDavid Brownell 
554a30d46c0SDavid Brownell 	/* FIXME need retry-on-error ... */
555a30d46c0SDavid Brownell 
556a30d46c0SDavid Brownell 	isr.word = 0;
557a30d46c0SDavid Brownell 	status = twl4030_i2c_read(sih->module, isr.bytes,
558a30d46c0SDavid Brownell 			sih->mask[irq_line].isr_offset, sih->bytes_ixr);
559a30d46c0SDavid Brownell 
560a30d46c0SDavid Brownell 	return (status < 0) ? status : le32_to_cpu(isr.word);
561a30d46c0SDavid Brownell }
562a30d46c0SDavid Brownell 
563a30d46c0SDavid Brownell /*
564a30d46c0SDavid Brownell  * Generic handler for SIH interrupts ... we "know" this is called
565a30d46c0SDavid Brownell  * in task context, with IRQs enabled.
566a30d46c0SDavid Brownell  */
567a30d46c0SDavid Brownell static void handle_twl4030_sih(unsigned irq, struct irq_desc *desc)
568a30d46c0SDavid Brownell {
569a30d46c0SDavid Brownell 	struct sih_agent *agent = get_irq_data(irq);
570a30d46c0SDavid Brownell 	const struct sih *sih = agent->sih;
571a30d46c0SDavid Brownell 	int isr;
572a30d46c0SDavid Brownell 
573a30d46c0SDavid Brownell 	/* reading ISR acks the IRQs, using clear-on-read mode */
574a30d46c0SDavid Brownell 	local_irq_enable();
575a30d46c0SDavid Brownell 	isr = sih_read_isr(sih);
576a30d46c0SDavid Brownell 	local_irq_disable();
577a30d46c0SDavid Brownell 
578a30d46c0SDavid Brownell 	if (isr < 0) {
579a30d46c0SDavid Brownell 		pr_err("twl4030: %s SIH, read ISR error %d\n",
580a30d46c0SDavid Brownell 			sih->name, isr);
581a30d46c0SDavid Brownell 		/* REVISIT:  recover; eventually mask it all, etc */
582a30d46c0SDavid Brownell 		return;
583a30d46c0SDavid Brownell 	}
584a30d46c0SDavid Brownell 
585a30d46c0SDavid Brownell 	while (isr) {
586a30d46c0SDavid Brownell 		irq = fls(isr);
587a30d46c0SDavid Brownell 		irq--;
588a30d46c0SDavid Brownell 		isr &= ~BIT(irq);
589a30d46c0SDavid Brownell 
590a30d46c0SDavid Brownell 		if (irq < sih->bits)
591a30d46c0SDavid Brownell 			generic_handle_irq(agent->irq_base + irq);
592a30d46c0SDavid Brownell 		else
593a30d46c0SDavid Brownell 			pr_err("twl4030: %s SIH, invalid ISR bit %d\n",
594a30d46c0SDavid Brownell 				sih->name, irq);
595a30d46c0SDavid Brownell 	}
596a30d46c0SDavid Brownell }
597a30d46c0SDavid Brownell 
598a30d46c0SDavid Brownell static unsigned twl4030_irq_next;
599a30d46c0SDavid Brownell 
600a30d46c0SDavid Brownell /* returns the first IRQ used by this SIH bank,
601a30d46c0SDavid Brownell  * or negative errno
602a30d46c0SDavid Brownell  */
603a30d46c0SDavid Brownell int twl4030_sih_setup(int module)
604a30d46c0SDavid Brownell {
605a30d46c0SDavid Brownell 	int			sih_mod;
606a30d46c0SDavid Brownell 	const struct sih	*sih = NULL;
607a30d46c0SDavid Brownell 	struct sih_agent	*agent;
608a30d46c0SDavid Brownell 	int			i, irq;
609a30d46c0SDavid Brownell 	int			status = -EINVAL;
610a30d46c0SDavid Brownell 	unsigned		irq_base = twl4030_irq_next;
611a30d46c0SDavid Brownell 
612a30d46c0SDavid Brownell 	/* only support modules with standard clear-on-read for now */
613a30d46c0SDavid Brownell 	for (sih_mod = 0, sih = sih_modules;
614a30d46c0SDavid Brownell 			sih_mod < ARRAY_SIZE(sih_modules);
615a30d46c0SDavid Brownell 			sih_mod++, sih++) {
616a30d46c0SDavid Brownell 		if (sih->module == module && sih->set_cor) {
617a30d46c0SDavid Brownell 			if (!WARN((irq_base + sih->bits) > NR_IRQS,
618a30d46c0SDavid Brownell 					"irq %d for %s too big\n",
619a30d46c0SDavid Brownell 					irq_base + sih->bits,
620a30d46c0SDavid Brownell 					sih->name))
621a30d46c0SDavid Brownell 				status = 0;
622a30d46c0SDavid Brownell 			break;
623a30d46c0SDavid Brownell 		}
624a30d46c0SDavid Brownell 	}
625a30d46c0SDavid Brownell 	if (status < 0)
626a30d46c0SDavid Brownell 		return status;
627a30d46c0SDavid Brownell 
628a30d46c0SDavid Brownell 	agent = kzalloc(sizeof *agent, GFP_KERNEL);
629a30d46c0SDavid Brownell 	if (!agent)
630a30d46c0SDavid Brownell 		return -ENOMEM;
631a30d46c0SDavid Brownell 
632a30d46c0SDavid Brownell 	status = 0;
633a30d46c0SDavid Brownell 
634a30d46c0SDavid Brownell 	agent->irq_base = irq_base;
635a30d46c0SDavid Brownell 	agent->sih = sih;
636a30d46c0SDavid Brownell 	agent->imr = ~0;
637a30d46c0SDavid Brownell 	INIT_WORK(&agent->mask_work, twl4030_sih_do_mask);
638a30d46c0SDavid Brownell 	INIT_WORK(&agent->edge_work, twl4030_sih_do_edge);
639a30d46c0SDavid Brownell 
640a30d46c0SDavid Brownell 	for (i = 0; i < sih->bits; i++) {
641a30d46c0SDavid Brownell 		irq = irq_base + i;
642a30d46c0SDavid Brownell 
643a30d46c0SDavid Brownell 		set_irq_chip_and_handler(irq, &twl4030_sih_irq_chip,
644a30d46c0SDavid Brownell 				handle_edge_irq);
645a30d46c0SDavid Brownell 		set_irq_chip_data(irq, agent);
646a30d46c0SDavid Brownell 		activate_irq(irq);
647a30d46c0SDavid Brownell 	}
648a30d46c0SDavid Brownell 
649a30d46c0SDavid Brownell 	status = irq_base;
650a30d46c0SDavid Brownell 	twl4030_irq_next += i;
651a30d46c0SDavid Brownell 
652a30d46c0SDavid Brownell 	/* replace generic PIH handler (handle_simple_irq) */
653a30d46c0SDavid Brownell 	irq = sih_mod + twl4030_irq_base;
654a30d46c0SDavid Brownell 	set_irq_data(irq, agent);
655a30d46c0SDavid Brownell 	set_irq_chained_handler(irq, handle_twl4030_sih);
656a30d46c0SDavid Brownell 
657a30d46c0SDavid Brownell 	pr_info("twl4030: %s (irq %d) chaining IRQs %d..%d\n", sih->name,
658a30d46c0SDavid Brownell 			irq, irq_base, twl4030_irq_next - 1);
659a30d46c0SDavid Brownell 
660a30d46c0SDavid Brownell 	return status;
661a30d46c0SDavid Brownell }
662a30d46c0SDavid Brownell 
663a30d46c0SDavid Brownell /* FIXME need a call to reverse twl4030_sih_setup() ... */
664a30d46c0SDavid Brownell 
665a30d46c0SDavid Brownell 
666a30d46c0SDavid Brownell /*----------------------------------------------------------------------*/
667a30d46c0SDavid Brownell 
668a30d46c0SDavid Brownell /* FIXME pass in which interrupt line we'll use ... */
669a30d46c0SDavid Brownell #define twl_irq_line	0
670a30d46c0SDavid Brownell 
671a30d46c0SDavid Brownell int twl_init_irq(int irq_num, unsigned irq_base, unsigned irq_end)
672a30d46c0SDavid Brownell {
673a30d46c0SDavid Brownell 	static struct irq_chip	twl4030_irq_chip;
674a30d46c0SDavid Brownell 
675a30d46c0SDavid Brownell 	int			status;
676a30d46c0SDavid Brownell 	int			i;
677a30d46c0SDavid Brownell 	struct task_struct	*task;
678a30d46c0SDavid Brownell 
679a30d46c0SDavid Brownell 	/*
680a30d46c0SDavid Brownell 	 * Mask and clear all TWL4030 interrupts since initially we do
681a30d46c0SDavid Brownell 	 * not have any TWL4030 module interrupt handlers present
682a30d46c0SDavid Brownell 	 */
683a30d46c0SDavid Brownell 	status = twl4030_init_sih_modules(twl_irq_line);
684a30d46c0SDavid Brownell 	if (status < 0)
685a30d46c0SDavid Brownell 		return status;
686a30d46c0SDavid Brownell 
687a30d46c0SDavid Brownell 	wq = create_singlethread_workqueue("twl4030-irqchip");
688a30d46c0SDavid Brownell 	if (!wq) {
689a30d46c0SDavid Brownell 		pr_err("twl4030: workqueue FAIL\n");
690a30d46c0SDavid Brownell 		return -ESRCH;
691a30d46c0SDavid Brownell 	}
692a30d46c0SDavid Brownell 
693a30d46c0SDavid Brownell 	twl4030_irq_base = irq_base;
694a30d46c0SDavid Brownell 
695a30d46c0SDavid Brownell 	/* install an irq handler for each of the SIH modules;
696a30d46c0SDavid Brownell 	 * clone dummy irq_chip since PIH can't *do* anything
697a30d46c0SDavid Brownell 	 */
698a30d46c0SDavid Brownell 	twl4030_irq_chip = dummy_irq_chip;
699a30d46c0SDavid Brownell 	twl4030_irq_chip.name = "twl4030";
700a30d46c0SDavid Brownell 
701a30d46c0SDavid Brownell 	twl4030_sih_irq_chip.ack = dummy_irq_chip.ack;
702a30d46c0SDavid Brownell 
703a30d46c0SDavid Brownell 	for (i = irq_base; i < irq_end; i++) {
704a30d46c0SDavid Brownell 		set_irq_chip_and_handler(i, &twl4030_irq_chip,
705a30d46c0SDavid Brownell 				handle_simple_irq);
706a30d46c0SDavid Brownell 		activate_irq(i);
707a30d46c0SDavid Brownell 	}
708a30d46c0SDavid Brownell 	twl4030_irq_next = i;
709a30d46c0SDavid Brownell 	pr_info("twl4030: %s (irq %d) chaining IRQs %d..%d\n", "PIH",
710a30d46c0SDavid Brownell 			irq_num, irq_base, twl4030_irq_next - 1);
711a30d46c0SDavid Brownell 
712a30d46c0SDavid Brownell 	/* ... and the PWR_INT module ... */
713a30d46c0SDavid Brownell 	status = twl4030_sih_setup(TWL4030_MODULE_INT);
714a30d46c0SDavid Brownell 	if (status < 0) {
715a30d46c0SDavid Brownell 		pr_err("twl4030: sih_setup PWR INT --> %d\n", status);
716a30d46c0SDavid Brownell 		goto fail;
717a30d46c0SDavid Brownell 	}
718a30d46c0SDavid Brownell 
719a30d46c0SDavid Brownell 	/* install an irq handler to demultiplex the TWL4030 interrupt */
7201cef8e41SRussell King 
7211cef8e41SRussell King 
7221cef8e41SRussell King 	init_completion(&irq_event);
7231cef8e41SRussell King 
7241cef8e41SRussell King 	status = request_irq(irq_num, handle_twl4030_pih, IRQF_DISABLED,
7251cef8e41SRussell King 				"TWL4030-PIH", &irq_event);
7261cef8e41SRussell King 	if (status < 0) {
7271cef8e41SRussell King 		pr_err("twl4030: could not claim irq%d: %d\n", irq_num, status);
7281cef8e41SRussell King 		goto fail_rqirq;
729a30d46c0SDavid Brownell 	}
730a30d46c0SDavid Brownell 
7311cef8e41SRussell King 	task = kthread_run(twl4030_irq_thread, (void *)irq_num, "twl4030-irq");
7321cef8e41SRussell King 	if (IS_ERR(task)) {
7331cef8e41SRussell King 		pr_err("twl4030: could not create irq %d thread!\n", irq_num);
7341cef8e41SRussell King 		status = PTR_ERR(task);
7351cef8e41SRussell King 		goto fail_kthread;
7361cef8e41SRussell King 	}
737a30d46c0SDavid Brownell 	return status;
7381cef8e41SRussell King fail_kthread:
7391cef8e41SRussell King 	free_irq(irq_num, &irq_event);
7401cef8e41SRussell King fail_rqirq:
7411cef8e41SRussell King 	/* clean up twl4030_sih_setup */
742a30d46c0SDavid Brownell fail:
743a30d46c0SDavid Brownell 	for (i = irq_base; i < irq_end; i++)
744a30d46c0SDavid Brownell 		set_irq_chip_and_handler(i, NULL, NULL);
745a30d46c0SDavid Brownell 	destroy_workqueue(wq);
746a30d46c0SDavid Brownell 	wq = NULL;
747a30d46c0SDavid Brownell 	return status;
748a30d46c0SDavid Brownell }
749a30d46c0SDavid Brownell 
750a30d46c0SDavid Brownell int twl_exit_irq(void)
751a30d46c0SDavid Brownell {
752a30d46c0SDavid Brownell 	/* FIXME undo twl_init_irq() */
753a30d46c0SDavid Brownell 	if (twl4030_irq_base) {
754a30d46c0SDavid Brownell 		pr_err("twl4030: can't yet clean up IRQs?\n");
755a30d46c0SDavid Brownell 		return -ENOSYS;
756a30d46c0SDavid Brownell 	}
757a30d46c0SDavid Brownell 	return 0;
758a30d46c0SDavid Brownell }
759