xref: /linux/drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c (revision 0d21364c6e8dc1f62c34bbc49d49935c8b01844c)
1 // SPDX-License-Identifier: (GPL-2.0+ OR MIT)
2 /*
3  * Rockchip ISP1 Driver - ISP Subdevice
4  *
5  * Copyright (C) 2019 Collabora, Ltd.
6  *
7  * Based on Rockchip ISP1 driver by Rockchip Electronics Co., Ltd.
8  * Copyright (C) 2017 Rockchip Electronics Co., Ltd.
9  */
10 
11 #include <linux/iopoll.h>
12 #include <linux/pm_runtime.h>
13 #include <linux/regmap.h>
14 #include <linux/videodev2.h>
15 #include <linux/vmalloc.h>
16 
17 #include <media/v4l2-event.h>
18 
19 #include "rkisp1-common.h"
20 
21 #define RKISP1_DEF_SINK_PAD_FMT MEDIA_BUS_FMT_SRGGB10_1X10
22 #define RKISP1_DEF_SRC_PAD_FMT MEDIA_BUS_FMT_YUYV8_2X8
23 
24 #define RKISP1_ISP_DEV_NAME	RKISP1_DRIVER_NAME "_isp"
25 
26 /*
27  * NOTE: MIPI controller and input MUX are also configured in this file.
28  * This is because ISP Subdev describes not only ISP submodule (input size,
29  * format, output size, format), but also a virtual route device.
30  */
31 
32 /*
33  * There are many variables named with format/frame in below code,
34  * please see here for their meaning.
35  * Cropping in the sink pad defines the image region from the sensor.
36  * Cropping in the source pad defines the region for the Image Stabilizer (IS)
37  *
38  * Cropping regions of ISP
39  *
40  * +---------------------------------------------------------+
41  * | Sensor image                                            |
42  * | +---------------------------------------------------+   |
43  * | | CIF_ISP_ACQ (for black level)                     |   |
44  * | | sink pad format                                   |   |
45  * | | +--------------------------------------------+    |   |
46  * | | |    CIF_ISP_OUT                             |    |   |
47  * | | |    sink pad crop                           |    |   |
48  * | | |    +---------------------------------+     |    |   |
49  * | | |    |   CIF_ISP_IS                    |     |    |   |
50  * | | |    |   source pad crop and format    |     |    |   |
51  * | | |    +---------------------------------+     |    |   |
52  * | | +--------------------------------------------+    |   |
53  * | +---------------------------------------------------+   |
54  * +---------------------------------------------------------+
55  */
56 
57 /* -----------------------------------------------------------------------------
58  * Media block control (i.MX8MP only)
59  */
60 
61 #define ISP_DEWARP_CONTROL				0x0138
62 
63 #define ISP_DEWARP_CONTROL_MIPI_CSI2_HS_POLARITY	BIT(22)
64 #define ISP_DEWARP_CONTROL_MIPI_CSI2_VS_SEL_RISING	(0 << 20)
65 #define ISP_DEWARP_CONTROL_MIPI_CSI2_VS_SEL_NEGATIVE	(1 << 20)
66 #define ISP_DEWARP_CONTROL_MIPI_CSI2_VS_SEL_POSITIVE	(2 << 20)
67 #define ISP_DEWARP_CONTROL_MIPI_CSI2_VS_SEL_FALLING	(3 << 20)
68 #define ISP_DEWARP_CONTROL_MIPI_CSI2_VS_SEL_MASK	GENMASK(21, 20)
69 #define ISP_DEWARP_CONTROL_MIPI_ISP2_LEFT_JUST_MODE	BIT(19)
70 #define ISP_DEWARP_CONTROL_MIPI_ISP2_DATA_TYPE(dt)	((dt) << 13)
71 #define ISP_DEWARP_CONTROL_MIPI_ISP2_DATA_TYPE_MASK	GENMASK(18, 13)
72 
73 #define ISP_DEWARP_CONTROL_MIPI_CSI1_HS_POLARITY	BIT(12)
74 #define ISP_DEWARP_CONTROL_MIPI_CSI1_VS_SEL_RISING	(0 << 10)
75 #define ISP_DEWARP_CONTROL_MIPI_CSI1_VS_SEL_NEGATIVE	(1 << 10)
76 #define ISP_DEWARP_CONTROL_MIPI_CSI1_VS_SEL_POSITIVE	(2 << 10)
77 #define ISP_DEWARP_CONTROL_MIPI_CSI1_VS_SEL_FALLING	(3 << 10)
78 #define ISP_DEWARP_CONTROL_MIPI_CSI1_VS_SEL_MASK	GENMASK(11, 10)
79 #define ISP_DEWARP_CONTROL_MIPI_ISP1_LEFT_JUST_MODE	BIT(9)
80 #define ISP_DEWARP_CONTROL_MIPI_ISP1_DATA_TYPE(dt)	((dt) << 3)
81 #define ISP_DEWARP_CONTROL_MIPI_ISP1_DATA_TYPE_MASK	GENMASK(8, 3)
82 
83 #define ISP_DEWARP_CONTROL_GPR_ISP_1_DISABLE		BIT(1)
84 #define ISP_DEWARP_CONTROL_GPR_ISP_0_DISABLE		BIT(0)
85 
86 static int rkisp1_gasket_enable(struct rkisp1_device *rkisp1,
87 				struct media_pad *source)
88 {
89 	struct v4l2_subdev *source_sd;
90 	struct v4l2_mbus_frame_desc fd;
91 	unsigned int dt;
92 	u32 mask;
93 	u32 val;
94 	int ret;
95 
96 	/*
97 	 * Configure and enable the gasket with the CSI-2 data type. Set the
98 	 * vsync polarity as active high, as that is what the ISP is configured
99 	 * to expect in ISP_ACQ_PROP. Enable left justification, as the i.MX8MP
100 	 * ISP has a 16-bit wide input and expects data to be left-aligned.
101 	 */
102 
103 	source_sd = media_entity_to_v4l2_subdev(source->entity);
104 	ret = v4l2_subdev_call(source_sd, pad, get_frame_desc,
105 			       source->index, &fd);
106 	if (ret) {
107 		dev_err(rkisp1->dev,
108 			"failed to get frame descriptor from '%s':%u: %d\n",
109 			source_sd->name, 0, ret);
110 		return ret;
111 	}
112 
113 	if (fd.num_entries != 1) {
114 		dev_err(rkisp1->dev, "invalid frame descriptor for '%s':%u\n",
115 			source_sd->name, 0);
116 		return -EINVAL;
117 	}
118 
119 	dt = fd.entry[0].bus.csi2.dt;
120 
121 	if (rkisp1->gasket_id == 0) {
122 		mask = ISP_DEWARP_CONTROL_MIPI_CSI1_HS_POLARITY
123 		     | ISP_DEWARP_CONTROL_MIPI_CSI1_VS_SEL_MASK
124 		     | ISP_DEWARP_CONTROL_MIPI_ISP1_LEFT_JUST_MODE
125 		     | ISP_DEWARP_CONTROL_MIPI_ISP1_DATA_TYPE_MASK
126 		     | ISP_DEWARP_CONTROL_GPR_ISP_0_DISABLE;
127 		val = ISP_DEWARP_CONTROL_MIPI_CSI1_VS_SEL_POSITIVE
128 		    | ISP_DEWARP_CONTROL_MIPI_ISP1_LEFT_JUST_MODE
129 		    | ISP_DEWARP_CONTROL_MIPI_ISP1_DATA_TYPE(dt);
130 	} else {
131 		mask = ISP_DEWARP_CONTROL_MIPI_CSI2_HS_POLARITY
132 		     | ISP_DEWARP_CONTROL_MIPI_CSI2_VS_SEL_MASK
133 		     | ISP_DEWARP_CONTROL_MIPI_ISP2_LEFT_JUST_MODE
134 		     | ISP_DEWARP_CONTROL_MIPI_ISP2_DATA_TYPE_MASK
135 		     | ISP_DEWARP_CONTROL_GPR_ISP_1_DISABLE;
136 		val = ISP_DEWARP_CONTROL_MIPI_CSI2_VS_SEL_POSITIVE
137 		    | ISP_DEWARP_CONTROL_MIPI_ISP2_LEFT_JUST_MODE
138 		    | ISP_DEWARP_CONTROL_MIPI_ISP2_DATA_TYPE(dt);
139 	}
140 
141 	regmap_update_bits(rkisp1->gasket, ISP_DEWARP_CONTROL, mask, val);
142 
143 	return 0;
144 }
145 
146 static void rkisp1_gasket_disable(struct rkisp1_device *rkisp1)
147 {
148 	u32 mask;
149 	u32 val;
150 
151 	if (rkisp1->gasket_id == 1) {
152 		mask = ISP_DEWARP_CONTROL_MIPI_ISP2_LEFT_JUST_MODE
153 		     | ISP_DEWARP_CONTROL_MIPI_ISP2_DATA_TYPE_MASK
154 		     | ISP_DEWARP_CONTROL_GPR_ISP_1_DISABLE;
155 		val = ISP_DEWARP_CONTROL_GPR_ISP_1_DISABLE;
156 	} else {
157 		mask = ISP_DEWARP_CONTROL_MIPI_ISP1_LEFT_JUST_MODE
158 		     | ISP_DEWARP_CONTROL_MIPI_ISP1_DATA_TYPE_MASK
159 		     | ISP_DEWARP_CONTROL_GPR_ISP_0_DISABLE;
160 		val = ISP_DEWARP_CONTROL_GPR_ISP_0_DISABLE;
161 	}
162 
163 	regmap_update_bits(rkisp1->gasket, ISP_DEWARP_CONTROL, mask, val);
164 }
165 
166 /* ----------------------------------------------------------------------------
167  * Camera Interface registers configurations
168  */
169 
170 /*
171  * Image Stabilization.
172  * This should only be called when configuring CIF
173  * or at the frame end interrupt
174  */
175 static void rkisp1_config_ism(struct rkisp1_isp *isp,
176 			      struct v4l2_subdev_state *sd_state)
177 {
178 	const struct v4l2_rect *src_crop =
179 		v4l2_subdev_state_get_crop(sd_state,
180 					   RKISP1_ISP_PAD_SOURCE_VIDEO);
181 	struct rkisp1_device *rkisp1 = isp->rkisp1;
182 	u32 val;
183 
184 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_RECENTER, 0);
185 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_MAX_DX, 0);
186 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_MAX_DY, 0);
187 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_DISPLACE, 0);
188 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_H_OFFS, src_crop->left);
189 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_V_OFFS, src_crop->top);
190 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_H_SIZE, src_crop->width);
191 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_V_SIZE, src_crop->height);
192 
193 	/* IS(Image Stabilization) is always on, working as output crop */
194 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_IS_CTRL, 1);
195 	val = rkisp1_read(rkisp1, RKISP1_CIF_ISP_CTRL);
196 	val |= RKISP1_CIF_ISP_CTRL_ISP_CFG_UPD;
197 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_CTRL, val);
198 }
199 
200 /*
201  * configure ISP blocks with input format, size......
202  */
203 static int rkisp1_config_isp(struct rkisp1_isp *isp,
204 			     struct v4l2_subdev_state *sd_state,
205 			     enum v4l2_mbus_type mbus_type, u32 mbus_flags)
206 {
207 	struct rkisp1_device *rkisp1 = isp->rkisp1;
208 	u32 isp_ctrl = 0, irq_mask = 0, acq_mult = 0, acq_prop = 0;
209 	const struct rkisp1_mbus_info *sink_fmt;
210 	const struct rkisp1_mbus_info *src_fmt;
211 	const struct v4l2_mbus_framefmt *src_frm;
212 	const struct v4l2_mbus_framefmt *sink_frm;
213 	const struct v4l2_rect *sink_crop;
214 
215 	sink_frm = v4l2_subdev_state_get_format(sd_state,
216 						RKISP1_ISP_PAD_SINK_VIDEO);
217 	sink_crop = v4l2_subdev_state_get_crop(sd_state,
218 					       RKISP1_ISP_PAD_SINK_VIDEO);
219 	src_frm = v4l2_subdev_state_get_format(sd_state,
220 					       RKISP1_ISP_PAD_SOURCE_VIDEO);
221 
222 	sink_fmt = rkisp1_mbus_info_get_by_code(sink_frm->code);
223 	src_fmt = rkisp1_mbus_info_get_by_code(src_frm->code);
224 
225 	if (sink_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) {
226 		acq_mult = 1;
227 		if (src_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) {
228 			if (mbus_type == V4L2_MBUS_BT656)
229 				isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_RAW_PICT_ITU656;
230 			else
231 				isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_RAW_PICT;
232 		} else {
233 			rkisp1_write(rkisp1, RKISP1_CIF_ISP_DEMOSAIC,
234 				     RKISP1_CIF_ISP_DEMOSAIC_TH(0xc));
235 
236 			if (mbus_type == V4L2_MBUS_BT656)
237 				isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_BAYER_ITU656;
238 			else
239 				isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_BAYER_ITU601;
240 		}
241 	} else if (sink_fmt->pixel_enc == V4L2_PIXEL_ENC_YUV) {
242 		acq_mult = 2;
243 		if (mbus_type == V4L2_MBUS_CSI2_DPHY) {
244 			isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_ITU601;
245 		} else {
246 			if (mbus_type == V4L2_MBUS_BT656)
247 				isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_ITU656;
248 			else
249 				isp_ctrl = RKISP1_CIF_ISP_CTRL_ISP_MODE_ITU601;
250 		}
251 
252 		irq_mask |= RKISP1_CIF_ISP_DATA_LOSS;
253 	}
254 
255 	/* Set up input acquisition properties */
256 	if (mbus_type == V4L2_MBUS_BT656 || mbus_type == V4L2_MBUS_PARALLEL) {
257 		if (mbus_flags & V4L2_MBUS_PCLK_SAMPLE_RISING)
258 			acq_prop |= RKISP1_CIF_ISP_ACQ_PROP_POS_EDGE;
259 
260 		switch (sink_fmt->bus_width) {
261 		case 8:
262 			acq_prop |= RKISP1_CIF_ISP_ACQ_PROP_IN_SEL_8B_ZERO;
263 			break;
264 		case 10:
265 			acq_prop |= RKISP1_CIF_ISP_ACQ_PROP_IN_SEL_10B_ZERO;
266 			break;
267 		case 12:
268 			acq_prop |= RKISP1_CIF_ISP_ACQ_PROP_IN_SEL_12B;
269 			break;
270 		default:
271 			dev_err(rkisp1->dev, "Invalid bus width %u\n",
272 				sink_fmt->bus_width);
273 			return -EINVAL;
274 		}
275 	}
276 
277 	if (mbus_type == V4L2_MBUS_PARALLEL) {
278 		if (mbus_flags & V4L2_MBUS_VSYNC_ACTIVE_LOW)
279 			acq_prop |= RKISP1_CIF_ISP_ACQ_PROP_VSYNC_LOW;
280 
281 		if (mbus_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW)
282 			acq_prop |= RKISP1_CIF_ISP_ACQ_PROP_HSYNC_LOW;
283 	}
284 
285 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_CTRL, isp_ctrl);
286 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_ACQ_PROP,
287 		     acq_prop | sink_fmt->yuv_seq |
288 		     RKISP1_CIF_ISP_ACQ_PROP_BAYER_PAT(sink_fmt->bayer_pat) |
289 		     RKISP1_CIF_ISP_ACQ_PROP_FIELD_SEL_ALL);
290 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_ACQ_NR_FRAMES, 0);
291 
292 	/* Acquisition Size */
293 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_ACQ_H_OFFS, 0);
294 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_ACQ_V_OFFS, 0);
295 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_ACQ_H_SIZE,
296 		     acq_mult * sink_frm->width);
297 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_ACQ_V_SIZE, sink_frm->height);
298 
299 	/* ISP Out Area */
300 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_OUT_H_OFFS, sink_crop->left);
301 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_OUT_V_OFFS, sink_crop->top);
302 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_OUT_H_SIZE, sink_crop->width);
303 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_OUT_V_SIZE, sink_crop->height);
304 
305 	irq_mask |= RKISP1_CIF_ISP_FRAME | RKISP1_CIF_ISP_V_START |
306 		    RKISP1_CIF_ISP_PIC_SIZE_ERROR;
307 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_IMSC, irq_mask);
308 
309 	if (src_fmt->pixel_enc == V4L2_PIXEL_ENC_BAYER) {
310 		rkisp1_params_disable(&rkisp1->params);
311 	} else {
312 		struct v4l2_mbus_framefmt *src_frm;
313 
314 		src_frm = v4l2_subdev_state_get_format(sd_state,
315 						       RKISP1_ISP_PAD_SOURCE_VIDEO);
316 		rkisp1_params_pre_configure(&rkisp1->params, sink_fmt->bayer_pat,
317 					    src_frm->quantization,
318 					    src_frm->ycbcr_enc);
319 	}
320 
321 	isp->sink_fmt = sink_fmt;
322 
323 	return 0;
324 }
325 
326 /* Configure MUX */
327 static void rkisp1_config_path(struct rkisp1_isp *isp,
328 			       enum v4l2_mbus_type mbus_type)
329 {
330 	struct rkisp1_device *rkisp1 = isp->rkisp1;
331 	u32 dpcl = rkisp1_read(rkisp1, RKISP1_CIF_VI_DPCL);
332 
333 	if (mbus_type == V4L2_MBUS_BT656 || mbus_type == V4L2_MBUS_PARALLEL)
334 		dpcl |= RKISP1_CIF_VI_DPCL_IF_SEL_PARALLEL;
335 	else if (mbus_type == V4L2_MBUS_CSI2_DPHY)
336 		dpcl |= RKISP1_CIF_VI_DPCL_IF_SEL_MIPI;
337 
338 	rkisp1_write(rkisp1, RKISP1_CIF_VI_DPCL, dpcl);
339 }
340 
341 /* Hardware configure Entry */
342 static int rkisp1_config_cif(struct rkisp1_isp *isp,
343 			     struct v4l2_subdev_state *sd_state,
344 			     enum v4l2_mbus_type mbus_type, u32 mbus_flags)
345 {
346 	int ret;
347 
348 	ret = rkisp1_config_isp(isp, sd_state, mbus_type, mbus_flags);
349 	if (ret)
350 		return ret;
351 
352 	rkisp1_config_path(isp, mbus_type);
353 	rkisp1_config_ism(isp, sd_state);
354 
355 	return 0;
356 }
357 
358 static void rkisp1_isp_stop(struct rkisp1_isp *isp)
359 {
360 	struct rkisp1_device *rkisp1 = isp->rkisp1;
361 	u32 val;
362 
363 	/*
364 	 * ISP(mi) stop in mi frame end -> Stop ISP(mipi) ->
365 	 * Stop ISP(isp) ->wait for ISP isp off
366 	 */
367 
368 	/* Mask MI and ISP interrupts */
369 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_IMSC, 0);
370 	rkisp1_write(rkisp1, RKISP1_CIF_MI_IMSC, 0);
371 
372 	/* Flush posted writes */
373 	rkisp1_read(rkisp1, RKISP1_CIF_MI_IMSC);
374 
375 	/*
376 	 * Wait until the IRQ handler has ended. The IRQ handler may get called
377 	 * even after this, but it will return immediately as the MI and ISP
378 	 * interrupts have been masked.
379 	 */
380 	synchronize_irq(rkisp1->irqs[RKISP1_IRQ_ISP]);
381 	if (rkisp1->irqs[RKISP1_IRQ_ISP] != rkisp1->irqs[RKISP1_IRQ_MI])
382 		synchronize_irq(rkisp1->irqs[RKISP1_IRQ_MI]);
383 
384 	/* Clear MI and ISP interrupt status */
385 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_ICR, ~0);
386 	rkisp1_write(rkisp1, RKISP1_CIF_MI_ICR, ~0);
387 
388 	/* stop ISP */
389 	val = rkisp1_read(rkisp1, RKISP1_CIF_ISP_CTRL);
390 	val &= ~(RKISP1_CIF_ISP_CTRL_ISP_INFORM_ENABLE |
391 		 RKISP1_CIF_ISP_CTRL_ISP_ENABLE);
392 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_CTRL, val);
393 
394 	val = rkisp1_read(rkisp1,	RKISP1_CIF_ISP_CTRL);
395 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_CTRL,
396 		     val | RKISP1_CIF_ISP_CTRL_ISP_CFG_UPD);
397 
398 	readx_poll_timeout(readl, rkisp1->base_addr + RKISP1_CIF_ISP_RIS,
399 			   val, val & RKISP1_CIF_ISP_OFF, 20, 100);
400 	rkisp1_write(rkisp1, RKISP1_CIF_VI_IRCL,
401 		     RKISP1_CIF_VI_IRCL_MIPI_SW_RST |
402 		     RKISP1_CIF_VI_IRCL_ISP_SW_RST);
403 	rkisp1_write(rkisp1, RKISP1_CIF_VI_IRCL, 0x0);
404 
405 	if (rkisp1->info->isp_ver == RKISP1_V_IMX8MP)
406 		rkisp1_gasket_disable(rkisp1);
407 }
408 
409 static void rkisp1_config_clk(struct rkisp1_isp *isp)
410 {
411 	struct rkisp1_device *rkisp1 = isp->rkisp1;
412 
413 	u32 val = RKISP1_CIF_VI_ICCL_ISP_CLK | RKISP1_CIF_VI_ICCL_CP_CLK |
414 		  RKISP1_CIF_VI_ICCL_MRSZ_CLK | RKISP1_CIF_VI_ICCL_SRSZ_CLK |
415 		  RKISP1_CIF_VI_ICCL_JPEG_CLK | RKISP1_CIF_VI_ICCL_MI_CLK |
416 		  RKISP1_CIF_VI_ICCL_IE_CLK | RKISP1_CIF_VI_ICCL_MIPI_CLK |
417 		  RKISP1_CIF_VI_ICCL_DCROP_CLK;
418 
419 	rkisp1_write(rkisp1, RKISP1_CIF_VI_ICCL, val);
420 
421 	/* ensure sp and mp can run at the same time in V12 */
422 	if (rkisp1->info->isp_ver == RKISP1_V12) {
423 		val = RKISP1_CIF_CLK_CTRL_MI_Y12 | RKISP1_CIF_CLK_CTRL_MI_SP |
424 		      RKISP1_CIF_CLK_CTRL_MI_RAW0 | RKISP1_CIF_CLK_CTRL_MI_RAW1 |
425 		      RKISP1_CIF_CLK_CTRL_MI_READ | RKISP1_CIF_CLK_CTRL_MI_RAWRD |
426 		      RKISP1_CIF_CLK_CTRL_CP | RKISP1_CIF_CLK_CTRL_IE;
427 		rkisp1_write(rkisp1, RKISP1_CIF_VI_ISP_CLK_CTRL_V12, val);
428 	}
429 }
430 
431 static int rkisp1_isp_start(struct rkisp1_isp *isp,
432 			    struct v4l2_subdev_state *sd_state,
433 			    struct media_pad *source)
434 {
435 	struct rkisp1_device *rkisp1 = isp->rkisp1;
436 	const struct v4l2_mbus_framefmt *src_fmt;
437 	const struct rkisp1_mbus_info *src_info;
438 	u32 val;
439 	int ret;
440 
441 	rkisp1_config_clk(isp);
442 
443 	if (rkisp1->info->isp_ver == RKISP1_V_IMX8MP) {
444 		ret = rkisp1_gasket_enable(rkisp1, source);
445 		if (ret)
446 			return ret;
447 	}
448 
449 	/* Activate ISP */
450 	val = rkisp1_read(rkisp1, RKISP1_CIF_ISP_CTRL);
451 	val |= RKISP1_CIF_ISP_CTRL_ISP_CFG_UPD |
452 	       RKISP1_CIF_ISP_CTRL_ISP_ENABLE |
453 	       RKISP1_CIF_ISP_CTRL_ISP_INFORM_ENABLE;
454 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_CTRL, val);
455 
456 	src_fmt = v4l2_subdev_state_get_format(sd_state,
457 					       RKISP1_ISP_PAD_SOURCE_VIDEO);
458 	src_info = rkisp1_mbus_info_get_by_code(src_fmt->code);
459 
460 	if (src_info->pixel_enc != V4L2_PIXEL_ENC_BAYER)
461 		rkisp1_params_post_configure(&rkisp1->params);
462 
463 	return 0;
464 }
465 
466 /* ----------------------------------------------------------------------------
467  * Subdev pad operations
468  */
469 
470 static inline struct rkisp1_isp *to_rkisp1_isp(struct v4l2_subdev *sd)
471 {
472 	return container_of(sd, struct rkisp1_isp, sd);
473 }
474 
475 static int rkisp1_isp_enum_mbus_code(struct v4l2_subdev *sd,
476 				     struct v4l2_subdev_state *sd_state,
477 				     struct v4l2_subdev_mbus_code_enum *code)
478 {
479 	unsigned int i, dir;
480 	int pos = 0;
481 
482 	if (code->pad == RKISP1_ISP_PAD_SINK_VIDEO) {
483 		dir = RKISP1_ISP_SD_SINK;
484 	} else if (code->pad == RKISP1_ISP_PAD_SOURCE_VIDEO) {
485 		dir = RKISP1_ISP_SD_SRC;
486 	} else {
487 		if (code->index > 0)
488 			return -EINVAL;
489 		code->code = MEDIA_BUS_FMT_METADATA_FIXED;
490 		return 0;
491 	}
492 
493 	for (i = 0; ; i++) {
494 		const struct rkisp1_mbus_info *fmt =
495 			rkisp1_mbus_info_get_by_index(i);
496 
497 		if (!fmt)
498 			return -EINVAL;
499 
500 		if (fmt->direction & dir)
501 			pos++;
502 
503 		if (code->index == pos - 1) {
504 			code->code = fmt->mbus_code;
505 			if (fmt->pixel_enc == V4L2_PIXEL_ENC_YUV &&
506 			    dir == RKISP1_ISP_SD_SRC)
507 				code->flags =
508 					V4L2_SUBDEV_MBUS_CODE_CSC_QUANTIZATION;
509 			return 0;
510 		}
511 	}
512 
513 	return -EINVAL;
514 }
515 
516 static int rkisp1_isp_enum_frame_size(struct v4l2_subdev *sd,
517 				      struct v4l2_subdev_state *sd_state,
518 				      struct v4l2_subdev_frame_size_enum *fse)
519 {
520 	const struct rkisp1_mbus_info *mbus_info;
521 
522 	if (fse->pad == RKISP1_ISP_PAD_SINK_PARAMS ||
523 	    fse->pad == RKISP1_ISP_PAD_SOURCE_STATS)
524 		return -ENOTTY;
525 
526 	if (fse->index > 0)
527 		return -EINVAL;
528 
529 	mbus_info = rkisp1_mbus_info_get_by_code(fse->code);
530 	if (!mbus_info)
531 		return -EINVAL;
532 
533 	if (!(mbus_info->direction & RKISP1_ISP_SD_SINK) &&
534 	    fse->pad == RKISP1_ISP_PAD_SINK_VIDEO)
535 		return -EINVAL;
536 
537 	if (!(mbus_info->direction & RKISP1_ISP_SD_SRC) &&
538 	    fse->pad == RKISP1_ISP_PAD_SOURCE_VIDEO)
539 		return -EINVAL;
540 
541 	fse->min_width = RKISP1_ISP_MIN_WIDTH;
542 	fse->max_width = RKISP1_ISP_MAX_WIDTH;
543 	fse->min_height = RKISP1_ISP_MIN_HEIGHT;
544 	fse->max_height = RKISP1_ISP_MAX_HEIGHT;
545 
546 	return 0;
547 }
548 
549 static int rkisp1_isp_init_state(struct v4l2_subdev *sd,
550 				 struct v4l2_subdev_state *sd_state)
551 {
552 	struct v4l2_mbus_framefmt *sink_fmt, *src_fmt;
553 	struct v4l2_rect *sink_crop, *src_crop;
554 
555 	/* Video. */
556 	sink_fmt = v4l2_subdev_state_get_format(sd_state,
557 						RKISP1_ISP_PAD_SINK_VIDEO);
558 	sink_fmt->width = RKISP1_DEFAULT_WIDTH;
559 	sink_fmt->height = RKISP1_DEFAULT_HEIGHT;
560 	sink_fmt->field = V4L2_FIELD_NONE;
561 	sink_fmt->code = RKISP1_DEF_SINK_PAD_FMT;
562 	sink_fmt->colorspace = V4L2_COLORSPACE_RAW;
563 	sink_fmt->xfer_func = V4L2_XFER_FUNC_NONE;
564 	sink_fmt->ycbcr_enc = V4L2_YCBCR_ENC_601;
565 	sink_fmt->quantization = V4L2_QUANTIZATION_FULL_RANGE;
566 
567 	sink_crop = v4l2_subdev_state_get_crop(sd_state,
568 					       RKISP1_ISP_PAD_SINK_VIDEO);
569 	sink_crop->width = RKISP1_DEFAULT_WIDTH;
570 	sink_crop->height = RKISP1_DEFAULT_HEIGHT;
571 	sink_crop->left = 0;
572 	sink_crop->top = 0;
573 
574 	src_fmt = v4l2_subdev_state_get_format(sd_state,
575 					       RKISP1_ISP_PAD_SOURCE_VIDEO);
576 	*src_fmt = *sink_fmt;
577 	src_fmt->code = RKISP1_DEF_SRC_PAD_FMT;
578 	src_fmt->colorspace = V4L2_COLORSPACE_SRGB;
579 	src_fmt->xfer_func = V4L2_XFER_FUNC_SRGB;
580 	src_fmt->ycbcr_enc = V4L2_YCBCR_ENC_601;
581 	src_fmt->quantization = V4L2_QUANTIZATION_LIM_RANGE;
582 
583 	src_crop = v4l2_subdev_state_get_crop(sd_state,
584 					      RKISP1_ISP_PAD_SOURCE_VIDEO);
585 	*src_crop = *sink_crop;
586 
587 	/* Parameters and statistics. */
588 	sink_fmt = v4l2_subdev_state_get_format(sd_state,
589 						RKISP1_ISP_PAD_SINK_PARAMS);
590 	src_fmt = v4l2_subdev_state_get_format(sd_state,
591 					       RKISP1_ISP_PAD_SOURCE_STATS);
592 	sink_fmt->width = 0;
593 	sink_fmt->height = 0;
594 	sink_fmt->field = V4L2_FIELD_NONE;
595 	sink_fmt->code = MEDIA_BUS_FMT_METADATA_FIXED;
596 	*src_fmt = *sink_fmt;
597 
598 	return 0;
599 }
600 
601 static void rkisp1_isp_set_src_fmt(struct rkisp1_isp *isp,
602 				   struct v4l2_subdev_state *sd_state,
603 				   struct v4l2_mbus_framefmt *format)
604 {
605 	const struct rkisp1_mbus_info *sink_info;
606 	const struct rkisp1_mbus_info *src_info;
607 	struct v4l2_mbus_framefmt *sink_fmt;
608 	struct v4l2_mbus_framefmt *src_fmt;
609 	const struct v4l2_rect *src_crop;
610 	bool set_csc;
611 
612 	sink_fmt = v4l2_subdev_state_get_format(sd_state,
613 						RKISP1_ISP_PAD_SINK_VIDEO);
614 	src_fmt = v4l2_subdev_state_get_format(sd_state,
615 					       RKISP1_ISP_PAD_SOURCE_VIDEO);
616 	src_crop = v4l2_subdev_state_get_crop(sd_state,
617 					      RKISP1_ISP_PAD_SOURCE_VIDEO);
618 
619 	/*
620 	 * Media bus code. The ISP can operate in pass-through mode (Bayer in,
621 	 * Bayer out or YUV in, YUV out) or process Bayer data to YUV, but
622 	 * can't convert from YUV to Bayer.
623 	 */
624 	sink_info = rkisp1_mbus_info_get_by_code(sink_fmt->code);
625 
626 	src_fmt->code = format->code;
627 	src_info = rkisp1_mbus_info_get_by_code(src_fmt->code);
628 	if (!src_info || !(src_info->direction & RKISP1_ISP_SD_SRC)) {
629 		src_fmt->code = RKISP1_DEF_SRC_PAD_FMT;
630 		src_info = rkisp1_mbus_info_get_by_code(src_fmt->code);
631 	}
632 
633 	if (sink_info->pixel_enc == V4L2_PIXEL_ENC_YUV &&
634 	    src_info->pixel_enc == V4L2_PIXEL_ENC_BAYER) {
635 		src_fmt->code = sink_fmt->code;
636 		src_info = sink_info;
637 	}
638 
639 	/*
640 	 * The source width and height must be identical to the source crop
641 	 * size.
642 	 */
643 	src_fmt->width  = src_crop->width;
644 	src_fmt->height = src_crop->height;
645 
646 	/*
647 	 * Copy the color space for the sink pad. When converting from Bayer to
648 	 * YUV, default to a limited quantization range.
649 	 */
650 	src_fmt->colorspace = sink_fmt->colorspace;
651 	src_fmt->xfer_func = sink_fmt->xfer_func;
652 	src_fmt->ycbcr_enc = sink_fmt->ycbcr_enc;
653 
654 	if (sink_info->pixel_enc == V4L2_PIXEL_ENC_BAYER &&
655 	    src_info->pixel_enc == V4L2_PIXEL_ENC_YUV)
656 		src_fmt->quantization = V4L2_QUANTIZATION_LIM_RANGE;
657 	else
658 		src_fmt->quantization = sink_fmt->quantization;
659 
660 	/*
661 	 * Allow setting the source color space fields when the SET_CSC flag is
662 	 * set and the source format is YUV. If the sink format is YUV, don't
663 	 * set the color primaries, transfer function or YCbCr encoding as the
664 	 * ISP is bypassed in that case and passes YUV data through without
665 	 * modifications.
666 	 *
667 	 * The color primaries and transfer function are configured through the
668 	 * cross-talk matrix and tone curve respectively. Settings for those
669 	 * hardware blocks are conveyed through the ISP parameters buffer, as
670 	 * they need to combine color space information with other image tuning
671 	 * characteristics and can't thus be computed by the kernel based on the
672 	 * color space. The source pad colorspace and xfer_func fields are thus
673 	 * ignored by the driver, but can be set by userspace to propagate
674 	 * accurate color space information down the pipeline.
675 	 */
676 	set_csc = format->flags & V4L2_MBUS_FRAMEFMT_SET_CSC;
677 
678 	if (set_csc && src_info->pixel_enc == V4L2_PIXEL_ENC_YUV) {
679 		if (sink_info->pixel_enc == V4L2_PIXEL_ENC_BAYER) {
680 			if (format->colorspace != V4L2_COLORSPACE_DEFAULT)
681 				src_fmt->colorspace = format->colorspace;
682 			if (format->xfer_func != V4L2_XFER_FUNC_DEFAULT)
683 				src_fmt->xfer_func = format->xfer_func;
684 			if (format->ycbcr_enc != V4L2_YCBCR_ENC_DEFAULT)
685 				src_fmt->ycbcr_enc = format->ycbcr_enc;
686 		}
687 
688 		if (format->quantization != V4L2_QUANTIZATION_DEFAULT)
689 			src_fmt->quantization = format->quantization;
690 	}
691 
692 	*format = *src_fmt;
693 
694 	/*
695 	 * Restore the SET_CSC flag if it was set to indicate support for the
696 	 * CSC setting API.
697 	 */
698 	if (set_csc)
699 		format->flags |= V4L2_MBUS_FRAMEFMT_SET_CSC;
700 }
701 
702 static void rkisp1_isp_set_src_crop(struct rkisp1_isp *isp,
703 				    struct v4l2_subdev_state *sd_state,
704 				    struct v4l2_rect *r)
705 {
706 	struct v4l2_mbus_framefmt *src_fmt;
707 	const struct v4l2_rect *sink_crop;
708 	struct v4l2_rect *src_crop;
709 
710 	src_crop = v4l2_subdev_state_get_crop(sd_state,
711 					      RKISP1_ISP_PAD_SOURCE_VIDEO);
712 	sink_crop = v4l2_subdev_state_get_crop(sd_state,
713 					       RKISP1_ISP_PAD_SINK_VIDEO);
714 
715 	src_crop->left = ALIGN(r->left, 2);
716 	src_crop->width = ALIGN(r->width, 2);
717 	src_crop->top = r->top;
718 	src_crop->height = r->height;
719 	rkisp1_sd_adjust_crop_rect(src_crop, sink_crop);
720 
721 	*r = *src_crop;
722 
723 	/* Propagate to out format */
724 	src_fmt = v4l2_subdev_state_get_format(sd_state,
725 					       RKISP1_ISP_PAD_SOURCE_VIDEO);
726 	rkisp1_isp_set_src_fmt(isp, sd_state, src_fmt);
727 }
728 
729 static void rkisp1_isp_set_sink_crop(struct rkisp1_isp *isp,
730 				     struct v4l2_subdev_state *sd_state,
731 				     struct v4l2_rect *r)
732 {
733 	struct v4l2_rect *sink_crop, *src_crop;
734 	const struct v4l2_mbus_framefmt *sink_fmt;
735 
736 	sink_crop = v4l2_subdev_state_get_crop(sd_state,
737 					       RKISP1_ISP_PAD_SINK_VIDEO);
738 	sink_fmt = v4l2_subdev_state_get_format(sd_state,
739 						RKISP1_ISP_PAD_SINK_VIDEO);
740 
741 	sink_crop->left = ALIGN(r->left, 2);
742 	sink_crop->width = ALIGN(r->width, 2);
743 	sink_crop->top = r->top;
744 	sink_crop->height = r->height;
745 	rkisp1_sd_adjust_crop(sink_crop, sink_fmt);
746 
747 	*r = *sink_crop;
748 
749 	/* Propagate to out crop */
750 	src_crop = v4l2_subdev_state_get_crop(sd_state,
751 					      RKISP1_ISP_PAD_SOURCE_VIDEO);
752 	rkisp1_isp_set_src_crop(isp, sd_state, src_crop);
753 }
754 
755 static void rkisp1_isp_set_sink_fmt(struct rkisp1_isp *isp,
756 				    struct v4l2_subdev_state *sd_state,
757 				    struct v4l2_mbus_framefmt *format)
758 {
759 	const struct rkisp1_mbus_info *mbus_info;
760 	struct v4l2_mbus_framefmt *sink_fmt;
761 	struct v4l2_rect *sink_crop;
762 	bool is_yuv;
763 
764 	sink_fmt = v4l2_subdev_state_get_format(sd_state,
765 						RKISP1_ISP_PAD_SINK_VIDEO);
766 	sink_fmt->code = format->code;
767 	mbus_info = rkisp1_mbus_info_get_by_code(sink_fmt->code);
768 	if (!mbus_info || !(mbus_info->direction & RKISP1_ISP_SD_SINK)) {
769 		sink_fmt->code = RKISP1_DEF_SINK_PAD_FMT;
770 		mbus_info = rkisp1_mbus_info_get_by_code(sink_fmt->code);
771 	}
772 
773 	sink_fmt->width = clamp_t(u32, format->width,
774 				  RKISP1_ISP_MIN_WIDTH,
775 				  RKISP1_ISP_MAX_WIDTH);
776 	sink_fmt->height = clamp_t(u32, format->height,
777 				   RKISP1_ISP_MIN_HEIGHT,
778 				   RKISP1_ISP_MAX_HEIGHT);
779 
780 	/*
781 	 * Adjust the color space fields. Accept any color primaries and
782 	 * transfer function for both YUV and Bayer. For YUV any YCbCr encoding
783 	 * and quantization range is also accepted. For Bayer formats, the YCbCr
784 	 * encoding isn't applicable, and the quantization range can only be
785 	 * full.
786 	 */
787 	is_yuv = mbus_info->pixel_enc == V4L2_PIXEL_ENC_YUV;
788 
789 	sink_fmt->colorspace = format->colorspace ? :
790 			       (is_yuv ? V4L2_COLORSPACE_SRGB :
791 				V4L2_COLORSPACE_RAW);
792 	sink_fmt->xfer_func = format->xfer_func ? :
793 			      V4L2_MAP_XFER_FUNC_DEFAULT(sink_fmt->colorspace);
794 	if (is_yuv) {
795 		sink_fmt->ycbcr_enc = format->ycbcr_enc ? :
796 			V4L2_MAP_YCBCR_ENC_DEFAULT(sink_fmt->colorspace);
797 		sink_fmt->quantization = format->quantization ? :
798 			V4L2_MAP_QUANTIZATION_DEFAULT(false, sink_fmt->colorspace,
799 						      sink_fmt->ycbcr_enc);
800 	} else {
801 		/*
802 		 * The YCbCr encoding isn't applicable for non-YUV formats, but
803 		 * V4L2 has no "no encoding" value. Hardcode it to Rec. 601, it
804 		 * should be ignored by userspace.
805 		 */
806 		sink_fmt->ycbcr_enc = V4L2_YCBCR_ENC_601;
807 		sink_fmt->quantization = V4L2_QUANTIZATION_FULL_RANGE;
808 	}
809 
810 	*format = *sink_fmt;
811 
812 	/* Propagate to in crop */
813 	sink_crop = v4l2_subdev_state_get_crop(sd_state,
814 					       RKISP1_ISP_PAD_SINK_VIDEO);
815 	rkisp1_isp_set_sink_crop(isp, sd_state, sink_crop);
816 }
817 
818 static int rkisp1_isp_set_fmt(struct v4l2_subdev *sd,
819 			      struct v4l2_subdev_state *sd_state,
820 			      struct v4l2_subdev_format *fmt)
821 {
822 	struct rkisp1_isp *isp = to_rkisp1_isp(sd);
823 
824 	if (fmt->pad == RKISP1_ISP_PAD_SINK_VIDEO)
825 		rkisp1_isp_set_sink_fmt(isp, sd_state, &fmt->format);
826 	else if (fmt->pad == RKISP1_ISP_PAD_SOURCE_VIDEO)
827 		rkisp1_isp_set_src_fmt(isp, sd_state, &fmt->format);
828 	else
829 		fmt->format = *v4l2_subdev_state_get_format(sd_state,
830 							    fmt->pad);
831 
832 	return 0;
833 }
834 
835 static int rkisp1_isp_get_selection(struct v4l2_subdev *sd,
836 				    struct v4l2_subdev_state *sd_state,
837 				    struct v4l2_subdev_selection *sel)
838 {
839 	int ret = 0;
840 
841 	if (sel->pad != RKISP1_ISP_PAD_SOURCE_VIDEO &&
842 	    sel->pad != RKISP1_ISP_PAD_SINK_VIDEO)
843 		return -EINVAL;
844 
845 	switch (sel->target) {
846 	case V4L2_SEL_TGT_CROP_BOUNDS:
847 		if (sel->pad == RKISP1_ISP_PAD_SINK_VIDEO) {
848 			struct v4l2_mbus_framefmt *fmt;
849 
850 			fmt = v4l2_subdev_state_get_format(sd_state, sel->pad);
851 			sel->r.height = fmt->height;
852 			sel->r.width = fmt->width;
853 			sel->r.left = 0;
854 			sel->r.top = 0;
855 		} else {
856 			sel->r = *v4l2_subdev_state_get_crop(sd_state,
857 							     RKISP1_ISP_PAD_SINK_VIDEO);
858 		}
859 		break;
860 
861 	case V4L2_SEL_TGT_CROP:
862 		sel->r = *v4l2_subdev_state_get_crop(sd_state, sel->pad);
863 		break;
864 
865 	default:
866 		ret = -EINVAL;
867 		break;
868 	}
869 
870 	return ret;
871 }
872 
873 static int rkisp1_isp_set_selection(struct v4l2_subdev *sd,
874 				    struct v4l2_subdev_state *sd_state,
875 				    struct v4l2_subdev_selection *sel)
876 {
877 	struct rkisp1_isp *isp = to_rkisp1_isp(sd);
878 	int ret = 0;
879 
880 	if (sel->target != V4L2_SEL_TGT_CROP)
881 		return -EINVAL;
882 
883 	dev_dbg(isp->rkisp1->dev, "%s: pad: %d sel(%d,%d)/%dx%d\n", __func__,
884 		sel->pad, sel->r.left, sel->r.top, sel->r.width, sel->r.height);
885 
886 	if (sel->pad == RKISP1_ISP_PAD_SINK_VIDEO)
887 		rkisp1_isp_set_sink_crop(isp, sd_state, &sel->r);
888 	else if (sel->pad == RKISP1_ISP_PAD_SOURCE_VIDEO)
889 		rkisp1_isp_set_src_crop(isp, sd_state, &sel->r);
890 	else
891 		ret = -EINVAL;
892 
893 	return ret;
894 }
895 
896 static int rkisp1_subdev_link_validate(struct media_link *link)
897 {
898 	if (link->sink->index == RKISP1_ISP_PAD_SINK_PARAMS)
899 		return 0;
900 
901 	return v4l2_subdev_link_validate(link);
902 }
903 
904 static const struct v4l2_subdev_pad_ops rkisp1_isp_pad_ops = {
905 	.enum_mbus_code = rkisp1_isp_enum_mbus_code,
906 	.enum_frame_size = rkisp1_isp_enum_frame_size,
907 	.get_selection = rkisp1_isp_get_selection,
908 	.set_selection = rkisp1_isp_set_selection,
909 	.get_fmt = v4l2_subdev_get_fmt,
910 	.set_fmt = rkisp1_isp_set_fmt,
911 	.link_validate = v4l2_subdev_link_validate_default,
912 };
913 
914 /* ----------------------------------------------------------------------------
915  * Stream operations
916  */
917 
918 static int rkisp1_isp_s_stream(struct v4l2_subdev *sd, int enable)
919 {
920 	struct rkisp1_isp *isp = to_rkisp1_isp(sd);
921 	struct rkisp1_device *rkisp1 = isp->rkisp1;
922 	struct v4l2_subdev_state *sd_state;
923 	struct media_pad *source_pad;
924 	struct media_pad *sink_pad;
925 	enum v4l2_mbus_type mbus_type;
926 	u32 mbus_flags;
927 	int ret;
928 
929 	if (!enable) {
930 		v4l2_subdev_call(rkisp1->source, video, s_stream, false);
931 		rkisp1_isp_stop(isp);
932 		return 0;
933 	}
934 
935 	sink_pad = &isp->pads[RKISP1_ISP_PAD_SINK_VIDEO];
936 	source_pad = media_pad_remote_pad_unique(sink_pad);
937 	if (IS_ERR(source_pad)) {
938 		dev_dbg(rkisp1->dev, "Failed to get source for ISP: %ld\n",
939 			PTR_ERR(source_pad));
940 		return -EPIPE;
941 	}
942 
943 	rkisp1->source = media_entity_to_v4l2_subdev(source_pad->entity);
944 	if (!rkisp1->source) {
945 		/* This should really not happen, so is not worth a message. */
946 		return -EPIPE;
947 	}
948 
949 	if (rkisp1->source == &rkisp1->csi.sd) {
950 		mbus_type = V4L2_MBUS_CSI2_DPHY;
951 		mbus_flags = 0;
952 	} else {
953 		const struct rkisp1_sensor_async *asd;
954 		struct v4l2_async_connection *asc;
955 
956 		asc = v4l2_async_connection_unique(rkisp1->source);
957 		if (!asc)
958 			return -EPIPE;
959 
960 		asd = container_of(asc, struct rkisp1_sensor_async, asd);
961 
962 		mbus_type = asd->mbus_type;
963 		mbus_flags = asd->mbus_flags;
964 	}
965 
966 	isp->frame_sequence = -1;
967 
968 	sd_state = v4l2_subdev_lock_and_get_active_state(sd);
969 
970 	ret = rkisp1_config_cif(isp, sd_state, mbus_type, mbus_flags);
971 	if (ret)
972 		goto out_unlock;
973 
974 	ret = rkisp1_isp_start(isp, sd_state, source_pad);
975 	if (ret)
976 		goto out_unlock;
977 
978 	ret = v4l2_subdev_call(rkisp1->source, video, s_stream, true);
979 	if (ret) {
980 		rkisp1_isp_stop(isp);
981 		goto out_unlock;
982 	}
983 
984 out_unlock:
985 	v4l2_subdev_unlock_state(sd_state);
986 	return ret;
987 }
988 
989 static int rkisp1_isp_subs_evt(struct v4l2_subdev *sd, struct v4l2_fh *fh,
990 			       struct v4l2_event_subscription *sub)
991 {
992 	if (sub->type != V4L2_EVENT_FRAME_SYNC)
993 		return -EINVAL;
994 
995 	/* V4L2_EVENT_FRAME_SYNC doesn't require an id, so zero should be set */
996 	if (sub->id != 0)
997 		return -EINVAL;
998 
999 	return v4l2_event_subscribe(fh, sub, 0, NULL);
1000 }
1001 
1002 static const struct media_entity_operations rkisp1_isp_media_ops = {
1003 	.link_validate = rkisp1_subdev_link_validate,
1004 };
1005 
1006 static const struct v4l2_subdev_video_ops rkisp1_isp_video_ops = {
1007 	.s_stream = rkisp1_isp_s_stream,
1008 };
1009 
1010 static const struct v4l2_subdev_core_ops rkisp1_isp_core_ops = {
1011 	.subscribe_event = rkisp1_isp_subs_evt,
1012 	.unsubscribe_event = v4l2_event_subdev_unsubscribe,
1013 };
1014 
1015 static const struct v4l2_subdev_ops rkisp1_isp_ops = {
1016 	.core = &rkisp1_isp_core_ops,
1017 	.video = &rkisp1_isp_video_ops,
1018 	.pad = &rkisp1_isp_pad_ops,
1019 };
1020 
1021 static const struct v4l2_subdev_internal_ops rkisp1_isp_internal_ops = {
1022 	.init_state = rkisp1_isp_init_state,
1023 };
1024 
1025 int rkisp1_isp_register(struct rkisp1_device *rkisp1)
1026 {
1027 	struct rkisp1_isp *isp = &rkisp1->isp;
1028 	struct media_pad *pads = isp->pads;
1029 	struct v4l2_subdev *sd = &isp->sd;
1030 	int ret;
1031 
1032 	isp->rkisp1 = rkisp1;
1033 
1034 	v4l2_subdev_init(sd, &rkisp1_isp_ops);
1035 	sd->internal_ops = &rkisp1_isp_internal_ops;
1036 	sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS;
1037 	sd->entity.ops = &rkisp1_isp_media_ops;
1038 	sd->entity.function = MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER;
1039 	sd->owner = THIS_MODULE;
1040 	strscpy(sd->name, RKISP1_ISP_DEV_NAME, sizeof(sd->name));
1041 
1042 	pads[RKISP1_ISP_PAD_SINK_VIDEO].flags = MEDIA_PAD_FL_SINK |
1043 						MEDIA_PAD_FL_MUST_CONNECT;
1044 	pads[RKISP1_ISP_PAD_SINK_PARAMS].flags = MEDIA_PAD_FL_SINK;
1045 	pads[RKISP1_ISP_PAD_SOURCE_VIDEO].flags = MEDIA_PAD_FL_SOURCE;
1046 	pads[RKISP1_ISP_PAD_SOURCE_STATS].flags = MEDIA_PAD_FL_SOURCE;
1047 
1048 	ret = media_entity_pads_init(&sd->entity, RKISP1_ISP_PAD_MAX, pads);
1049 	if (ret)
1050 		goto err_entity_cleanup;
1051 
1052 	ret = v4l2_subdev_init_finalize(sd);
1053 	if (ret)
1054 		goto err_subdev_cleanup;
1055 
1056 	ret = v4l2_device_register_subdev(&rkisp1->v4l2_dev, sd);
1057 	if (ret) {
1058 		dev_err(rkisp1->dev, "Failed to register isp subdev\n");
1059 		goto err_subdev_cleanup;
1060 	}
1061 
1062 	return 0;
1063 
1064 err_subdev_cleanup:
1065 	v4l2_subdev_cleanup(sd);
1066 err_entity_cleanup:
1067 	media_entity_cleanup(&sd->entity);
1068 	isp->sd.v4l2_dev = NULL;
1069 	return ret;
1070 }
1071 
1072 void rkisp1_isp_unregister(struct rkisp1_device *rkisp1)
1073 {
1074 	struct rkisp1_isp *isp = &rkisp1->isp;
1075 
1076 	if (!isp->sd.v4l2_dev)
1077 		return;
1078 
1079 	v4l2_device_unregister_subdev(&isp->sd);
1080 	v4l2_subdev_cleanup(&isp->sd);
1081 	media_entity_cleanup(&isp->sd.entity);
1082 }
1083 
1084 /* ----------------------------------------------------------------------------
1085  * Interrupt handlers
1086  */
1087 
1088 static void rkisp1_isp_queue_event_sof(struct rkisp1_isp *isp)
1089 {
1090 	struct v4l2_event event = {
1091 		.type = V4L2_EVENT_FRAME_SYNC,
1092 	};
1093 
1094 	event.u.frame_sync.frame_sequence = isp->frame_sequence;
1095 	v4l2_event_queue(isp->sd.devnode, &event);
1096 }
1097 
1098 irqreturn_t rkisp1_isp_isr(int irq, void *ctx)
1099 {
1100 	struct device *dev = ctx;
1101 	struct rkisp1_device *rkisp1 = dev_get_drvdata(dev);
1102 	u32 status, isp_err;
1103 
1104 	if (!rkisp1->irqs_enabled)
1105 		return IRQ_NONE;
1106 
1107 	status = rkisp1_read(rkisp1, RKISP1_CIF_ISP_MIS);
1108 	if (!status)
1109 		return IRQ_NONE;
1110 
1111 	rkisp1_write(rkisp1, RKISP1_CIF_ISP_ICR, status);
1112 
1113 	/* Vertical sync signal, starting generating new frame */
1114 	if (status & RKISP1_CIF_ISP_V_START) {
1115 		rkisp1->isp.frame_sequence++;
1116 		rkisp1_isp_queue_event_sof(&rkisp1->isp);
1117 		if (status & RKISP1_CIF_ISP_FRAME) {
1118 			WARN_ONCE(1, "irq delay is too long, buffers might not be in sync\n");
1119 			rkisp1->debug.irq_delay++;
1120 		}
1121 	}
1122 	if (status & RKISP1_CIF_ISP_PIC_SIZE_ERROR) {
1123 		/* Clear pic_size_error */
1124 		isp_err = rkisp1_read(rkisp1, RKISP1_CIF_ISP_ERR);
1125 		if (isp_err & RKISP1_CIF_ISP_ERR_INFORM_SIZE)
1126 			rkisp1->debug.inform_size_error++;
1127 		if (isp_err & RKISP1_CIF_ISP_ERR_IS_SIZE)
1128 			rkisp1->debug.img_stabilization_size_error++;
1129 		if (isp_err & RKISP1_CIF_ISP_ERR_OUTFORM_SIZE)
1130 			rkisp1->debug.outform_size_error++;
1131 		rkisp1_write(rkisp1, RKISP1_CIF_ISP_ERR_CLR, isp_err);
1132 	} else if (status & RKISP1_CIF_ISP_DATA_LOSS) {
1133 		/* keep track of data_loss in debugfs */
1134 		rkisp1->debug.data_loss++;
1135 	}
1136 
1137 	if (status & RKISP1_CIF_ISP_FRAME) {
1138 		u32 isp_ris;
1139 
1140 		rkisp1->debug.complete_frames++;
1141 
1142 		/* New frame from the sensor received */
1143 		isp_ris = rkisp1_read(rkisp1, RKISP1_CIF_ISP_RIS);
1144 		if (isp_ris & RKISP1_STATS_MEAS_MASK)
1145 			rkisp1_stats_isr(&rkisp1->stats, isp_ris);
1146 		/*
1147 		 * Then update changed configs. Some of them involve
1148 		 * lot of register writes. Do those only one per frame.
1149 		 * Do the updates in the order of the processing flow.
1150 		 */
1151 		rkisp1_params_isr(rkisp1);
1152 	}
1153 
1154 	return IRQ_HANDLED;
1155 }
1156