xref: /linux/drivers/gpu/drm/vc4/vc4_hdmi.c (revision f2527d8f566a45fa00ee5abd04d1c9476d4d704f)
1 // SPDX-License-Identifier: GPL-2.0-only
2 /*
3  * Copyright (C) 2015 Broadcom
4  * Copyright (c) 2014 The Linux Foundation. All rights reserved.
5  * Copyright (C) 2013 Red Hat
6  * Author: Rob Clark <robdclark@gmail.com>
7  */
8 
9 /**
10  * DOC: VC4 Falcon HDMI module
11  *
12  * The HDMI core has a state machine and a PHY.  On BCM2835, most of
13  * the unit operates off of the HSM clock from CPRMAN.  It also
14  * internally uses the PLLH_PIX clock for the PHY.
15  *
16  * HDMI infoframes are kept within a small packet ram, where each
17  * packet can be individually enabled for including in a frame.
18  *
19  * HDMI audio is implemented entirely within the HDMI IP block.  A
20  * register in the HDMI encoder takes SPDIF frames from the DMA engine
21  * and transfers them over an internal MAI (multi-channel audio
22  * interconnect) bus to the encoder side for insertion into the video
23  * blank regions.
24  *
25  * The driver's HDMI encoder does not yet support power management.
26  * The HDMI encoder's power domain and the HSM/pixel clocks are kept
27  * continuously running, and only the HDMI logic and packet ram are
28  * powered off/on at disable/enable time.
29  *
30  * The driver does not yet support CEC control, though the HDMI
31  * encoder block has CEC support.
32  */
33 
34 #include <drm/display/drm_hdmi_helper.h>
35 #include <drm/display/drm_scdc_helper.h>
36 #include <drm/drm_atomic_helper.h>
37 #include <drm/drm_drv.h>
38 #include <drm/drm_probe_helper.h>
39 #include <drm/drm_simple_kms_helper.h>
40 #include <linux/clk.h>
41 #include <linux/component.h>
42 #include <linux/gpio/consumer.h>
43 #include <linux/i2c.h>
44 #include <linux/of_address.h>
45 #include <linux/of_platform.h>
46 #include <linux/pm_runtime.h>
47 #include <linux/rational.h>
48 #include <linux/reset.h>
49 #include <sound/dmaengine_pcm.h>
50 #include <sound/hdmi-codec.h>
51 #include <sound/pcm_drm_eld.h>
52 #include <sound/pcm_params.h>
53 #include <sound/soc.h>
54 #include "media/cec.h"
55 #include "vc4_drv.h"
56 #include "vc4_hdmi.h"
57 #include "vc4_hdmi_regs.h"
58 #include "vc4_regs.h"
59 
60 #define VC5_HDMI_HORZA_HFP_SHIFT		16
61 #define VC5_HDMI_HORZA_HFP_MASK			VC4_MASK(28, 16)
62 #define VC5_HDMI_HORZA_VPOS			BIT(15)
63 #define VC5_HDMI_HORZA_HPOS			BIT(14)
64 #define VC5_HDMI_HORZA_HAP_SHIFT		0
65 #define VC5_HDMI_HORZA_HAP_MASK			VC4_MASK(13, 0)
66 
67 #define VC5_HDMI_HORZB_HBP_SHIFT		16
68 #define VC5_HDMI_HORZB_HBP_MASK			VC4_MASK(26, 16)
69 #define VC5_HDMI_HORZB_HSP_SHIFT		0
70 #define VC5_HDMI_HORZB_HSP_MASK			VC4_MASK(10, 0)
71 
72 #define VC5_HDMI_VERTA_VSP_SHIFT		24
73 #define VC5_HDMI_VERTA_VSP_MASK			VC4_MASK(28, 24)
74 #define VC5_HDMI_VERTA_VFP_SHIFT		16
75 #define VC5_HDMI_VERTA_VFP_MASK			VC4_MASK(22, 16)
76 #define VC5_HDMI_VERTA_VAL_SHIFT		0
77 #define VC5_HDMI_VERTA_VAL_MASK			VC4_MASK(12, 0)
78 
79 #define VC5_HDMI_VERTB_VSPO_SHIFT		16
80 #define VC5_HDMI_VERTB_VSPO_MASK		VC4_MASK(29, 16)
81 
82 #define VC4_HDMI_MISC_CONTROL_PIXEL_REP_SHIFT	0
83 #define VC4_HDMI_MISC_CONTROL_PIXEL_REP_MASK	VC4_MASK(3, 0)
84 #define VC5_HDMI_MISC_CONTROL_PIXEL_REP_SHIFT	0
85 #define VC5_HDMI_MISC_CONTROL_PIXEL_REP_MASK	VC4_MASK(3, 0)
86 
87 #define VC5_HDMI_SCRAMBLER_CTL_ENABLE		BIT(0)
88 
89 #define VC5_HDMI_DEEP_COLOR_CONFIG_1_INIT_PACK_PHASE_SHIFT	8
90 #define VC5_HDMI_DEEP_COLOR_CONFIG_1_INIT_PACK_PHASE_MASK	VC4_MASK(10, 8)
91 
92 #define VC5_HDMI_DEEP_COLOR_CONFIG_1_COLOR_DEPTH_SHIFT		0
93 #define VC5_HDMI_DEEP_COLOR_CONFIG_1_COLOR_DEPTH_MASK		VC4_MASK(3, 0)
94 
95 #define VC5_HDMI_GCP_CONFIG_GCP_ENABLE		BIT(31)
96 
97 #define VC5_HDMI_GCP_WORD_1_GCP_SUBPACKET_BYTE_1_SHIFT	8
98 #define VC5_HDMI_GCP_WORD_1_GCP_SUBPACKET_BYTE_1_MASK	VC4_MASK(15, 8)
99 
100 # define VC4_HD_M_SW_RST			BIT(2)
101 # define VC4_HD_M_ENABLE			BIT(0)
102 
103 #define HSM_MIN_CLOCK_FREQ	120000000
104 #define CEC_CLOCK_FREQ 40000
105 
106 #define HDMI_14_MAX_TMDS_CLK   (340 * 1000 * 1000)
107 
108 static const char * const output_format_str[] = {
109 	[VC4_HDMI_OUTPUT_RGB]		= "RGB",
110 	[VC4_HDMI_OUTPUT_YUV420]	= "YUV 4:2:0",
111 	[VC4_HDMI_OUTPUT_YUV422]	= "YUV 4:2:2",
112 	[VC4_HDMI_OUTPUT_YUV444]	= "YUV 4:4:4",
113 };
114 
115 static const char *vc4_hdmi_output_fmt_str(enum vc4_hdmi_output_format fmt)
116 {
117 	if (fmt >= ARRAY_SIZE(output_format_str))
118 		return "invalid";
119 
120 	return output_format_str[fmt];
121 }
122 
123 static unsigned long long
124 vc4_hdmi_encoder_compute_mode_clock(const struct drm_display_mode *mode,
125 				    unsigned int bpc, enum vc4_hdmi_output_format fmt);
126 
127 static bool vc4_hdmi_supports_scrambling(struct vc4_hdmi *vc4_hdmi)
128 {
129 	struct drm_display_info *display = &vc4_hdmi->connector.display_info;
130 
131 	lockdep_assert_held(&vc4_hdmi->mutex);
132 
133 	if (!display->is_hdmi)
134 		return false;
135 
136 	if (!display->hdmi.scdc.supported ||
137 	    !display->hdmi.scdc.scrambling.supported)
138 		return false;
139 
140 	return true;
141 }
142 
143 static bool vc4_hdmi_mode_needs_scrambling(const struct drm_display_mode *mode,
144 					   unsigned int bpc,
145 					   enum vc4_hdmi_output_format fmt)
146 {
147 	unsigned long long clock = vc4_hdmi_encoder_compute_mode_clock(mode, bpc, fmt);
148 
149 	return clock > HDMI_14_MAX_TMDS_CLK;
150 }
151 
152 static bool vc4_hdmi_is_full_range_rgb(struct vc4_hdmi *vc4_hdmi,
153 				       const struct drm_display_mode *mode)
154 {
155 	struct drm_display_info *display = &vc4_hdmi->connector.display_info;
156 
157 	return !display->is_hdmi ||
158 		drm_default_rgb_quant_range(mode) == HDMI_QUANTIZATION_RANGE_FULL;
159 }
160 
161 static int vc4_hdmi_debugfs_regs(struct seq_file *m, void *unused)
162 {
163 	struct drm_info_node *node = (struct drm_info_node *)m->private;
164 	struct vc4_hdmi *vc4_hdmi = node->info_ent->data;
165 	struct drm_device *drm = vc4_hdmi->connector.dev;
166 	struct drm_printer p = drm_seq_file_printer(m);
167 	int idx;
168 
169 	if (!drm_dev_enter(drm, &idx))
170 		return -ENODEV;
171 
172 	drm_print_regset32(&p, &vc4_hdmi->hdmi_regset);
173 	drm_print_regset32(&p, &vc4_hdmi->hd_regset);
174 	drm_print_regset32(&p, &vc4_hdmi->cec_regset);
175 	drm_print_regset32(&p, &vc4_hdmi->csc_regset);
176 	drm_print_regset32(&p, &vc4_hdmi->dvp_regset);
177 	drm_print_regset32(&p, &vc4_hdmi->phy_regset);
178 	drm_print_regset32(&p, &vc4_hdmi->ram_regset);
179 	drm_print_regset32(&p, &vc4_hdmi->rm_regset);
180 
181 	drm_dev_exit(idx);
182 
183 	return 0;
184 }
185 
186 static void vc4_hdmi_reset(struct vc4_hdmi *vc4_hdmi)
187 {
188 	struct drm_device *drm = vc4_hdmi->connector.dev;
189 	unsigned long flags;
190 	int idx;
191 
192 	/*
193 	 * We can be called by our bind callback, when the
194 	 * connector->dev pointer might not be initialised yet.
195 	 */
196 	if (drm && !drm_dev_enter(drm, &idx))
197 		return;
198 
199 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
200 
201 	HDMI_WRITE(HDMI_M_CTL, VC4_HD_M_SW_RST);
202 	udelay(1);
203 	HDMI_WRITE(HDMI_M_CTL, 0);
204 
205 	HDMI_WRITE(HDMI_M_CTL, VC4_HD_M_ENABLE);
206 
207 	HDMI_WRITE(HDMI_SW_RESET_CONTROL,
208 		   VC4_HDMI_SW_RESET_HDMI |
209 		   VC4_HDMI_SW_RESET_FORMAT_DETECT);
210 
211 	HDMI_WRITE(HDMI_SW_RESET_CONTROL, 0);
212 
213 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
214 
215 	if (drm)
216 		drm_dev_exit(idx);
217 }
218 
219 static void vc5_hdmi_reset(struct vc4_hdmi *vc4_hdmi)
220 {
221 	struct drm_device *drm = vc4_hdmi->connector.dev;
222 	unsigned long flags;
223 	int idx;
224 
225 	/*
226 	 * We can be called by our bind callback, when the
227 	 * connector->dev pointer might not be initialised yet.
228 	 */
229 	if (drm && !drm_dev_enter(drm, &idx))
230 		return;
231 
232 	reset_control_reset(vc4_hdmi->reset);
233 
234 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
235 
236 	HDMI_WRITE(HDMI_DVP_CTL, 0);
237 
238 	HDMI_WRITE(HDMI_CLOCK_STOP,
239 		   HDMI_READ(HDMI_CLOCK_STOP) | VC4_DVP_HT_CLOCK_STOP_PIXEL);
240 
241 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
242 
243 	if (drm)
244 		drm_dev_exit(idx);
245 }
246 
247 #ifdef CONFIG_DRM_VC4_HDMI_CEC
248 static void vc4_hdmi_cec_update_clk_div(struct vc4_hdmi *vc4_hdmi)
249 {
250 	struct drm_device *drm = vc4_hdmi->connector.dev;
251 	unsigned long cec_rate;
252 	unsigned long flags;
253 	u16 clk_cnt;
254 	u32 value;
255 	int idx;
256 
257 	/*
258 	 * This function is called by our runtime_resume implementation
259 	 * and thus at bind time, when we haven't registered our
260 	 * connector yet and thus don't have a pointer to the DRM
261 	 * device.
262 	 */
263 	if (drm && !drm_dev_enter(drm, &idx))
264 		return;
265 
266 	cec_rate = clk_get_rate(vc4_hdmi->cec_clock);
267 
268 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
269 
270 	value = HDMI_READ(HDMI_CEC_CNTRL_1);
271 	value &= ~VC4_HDMI_CEC_DIV_CLK_CNT_MASK;
272 
273 	/*
274 	 * Set the clock divider: the hsm_clock rate and this divider
275 	 * setting will give a 40 kHz CEC clock.
276 	 */
277 	clk_cnt = cec_rate / CEC_CLOCK_FREQ;
278 	value |= clk_cnt << VC4_HDMI_CEC_DIV_CLK_CNT_SHIFT;
279 	HDMI_WRITE(HDMI_CEC_CNTRL_1, value);
280 
281 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
282 
283 	if (drm)
284 		drm_dev_exit(idx);
285 }
286 #else
287 static void vc4_hdmi_cec_update_clk_div(struct vc4_hdmi *vc4_hdmi) {}
288 #endif
289 
290 static int reset_pipe(struct drm_crtc *crtc,
291 			struct drm_modeset_acquire_ctx *ctx)
292 {
293 	struct drm_atomic_state *state;
294 	struct drm_crtc_state *crtc_state;
295 	int ret;
296 
297 	state = drm_atomic_state_alloc(crtc->dev);
298 	if (!state)
299 		return -ENOMEM;
300 
301 	state->acquire_ctx = ctx;
302 
303 	crtc_state = drm_atomic_get_crtc_state(state, crtc);
304 	if (IS_ERR(crtc_state)) {
305 		ret = PTR_ERR(crtc_state);
306 		goto out;
307 	}
308 
309 	crtc_state->connectors_changed = true;
310 
311 	ret = drm_atomic_commit(state);
312 out:
313 	drm_atomic_state_put(state);
314 
315 	return ret;
316 }
317 
318 static int vc4_hdmi_reset_link(struct drm_connector *connector,
319 			       struct drm_modeset_acquire_ctx *ctx)
320 {
321 	struct drm_device *drm;
322 	struct vc4_hdmi *vc4_hdmi;
323 	struct drm_connector_state *conn_state;
324 	struct drm_crtc_state *crtc_state;
325 	struct drm_crtc *crtc;
326 	bool scrambling_needed;
327 	u8 config;
328 	int ret;
329 
330 	if (!connector)
331 		return 0;
332 
333 	drm = connector->dev;
334 	ret = drm_modeset_lock(&drm->mode_config.connection_mutex, ctx);
335 	if (ret)
336 		return ret;
337 
338 	conn_state = connector->state;
339 	crtc = conn_state->crtc;
340 	if (!crtc)
341 		return 0;
342 
343 	ret = drm_modeset_lock(&crtc->mutex, ctx);
344 	if (ret)
345 		return ret;
346 
347 	crtc_state = crtc->state;
348 	if (!crtc_state->active)
349 		return 0;
350 
351 	vc4_hdmi = connector_to_vc4_hdmi(connector);
352 	mutex_lock(&vc4_hdmi->mutex);
353 
354 	if (!vc4_hdmi_supports_scrambling(vc4_hdmi)) {
355 		mutex_unlock(&vc4_hdmi->mutex);
356 		return 0;
357 	}
358 
359 	scrambling_needed = vc4_hdmi_mode_needs_scrambling(&vc4_hdmi->saved_adjusted_mode,
360 							   vc4_hdmi->output_bpc,
361 							   vc4_hdmi->output_format);
362 	if (!scrambling_needed) {
363 		mutex_unlock(&vc4_hdmi->mutex);
364 		return 0;
365 	}
366 
367 	if (conn_state->commit &&
368 	    !try_wait_for_completion(&conn_state->commit->hw_done)) {
369 		mutex_unlock(&vc4_hdmi->mutex);
370 		return 0;
371 	}
372 
373 	ret = drm_scdc_readb(connector->ddc, SCDC_TMDS_CONFIG, &config);
374 	if (ret < 0) {
375 		drm_err(drm, "Failed to read TMDS config: %d\n", ret);
376 		mutex_unlock(&vc4_hdmi->mutex);
377 		return 0;
378 	}
379 
380 	if (!!(config & SCDC_SCRAMBLING_ENABLE) == scrambling_needed) {
381 		mutex_unlock(&vc4_hdmi->mutex);
382 		return 0;
383 	}
384 
385 	mutex_unlock(&vc4_hdmi->mutex);
386 
387 	/*
388 	 * HDMI 2.0 says that one should not send scrambled data
389 	 * prior to configuring the sink scrambling, and that
390 	 * TMDS clock/data transmission should be suspended when
391 	 * changing the TMDS clock rate in the sink. So let's
392 	 * just do a full modeset here, even though some sinks
393 	 * would be perfectly happy if were to just reconfigure
394 	 * the SCDC settings on the fly.
395 	 */
396 	return reset_pipe(crtc, ctx);
397 }
398 
399 static void vc4_hdmi_handle_hotplug(struct vc4_hdmi *vc4_hdmi,
400 				    struct drm_modeset_acquire_ctx *ctx,
401 				    enum drm_connector_status status)
402 {
403 	struct drm_connector *connector = &vc4_hdmi->connector;
404 	struct edid *edid;
405 
406 	/*
407 	 * NOTE: This function should really be called with
408 	 * vc4_hdmi->mutex held, but doing so results in reentrancy
409 	 * issues since cec_s_phys_addr_from_edid might call
410 	 * .adap_enable, which leads to that funtion being called with
411 	 * our mutex held.
412 	 *
413 	 * A similar situation occurs with vc4_hdmi_reset_link() that
414 	 * will call into our KMS hooks if the scrambling was enabled.
415 	 *
416 	 * Concurrency isn't an issue at the moment since we don't share
417 	 * any state with any of the other frameworks so we can ignore
418 	 * the lock for now.
419 	 */
420 
421 	if (status == connector_status_disconnected) {
422 		cec_phys_addr_invalidate(vc4_hdmi->cec_adap);
423 		return;
424 	}
425 
426 	edid = drm_get_edid(connector, vc4_hdmi->ddc);
427 	if (!edid)
428 		return;
429 
430 	cec_s_phys_addr_from_edid(vc4_hdmi->cec_adap, edid);
431 	kfree(edid);
432 
433 	vc4_hdmi_reset_link(connector, ctx);
434 }
435 
436 static int vc4_hdmi_connector_detect_ctx(struct drm_connector *connector,
437 					 struct drm_modeset_acquire_ctx *ctx,
438 					 bool force)
439 {
440 	struct vc4_hdmi *vc4_hdmi = connector_to_vc4_hdmi(connector);
441 	enum drm_connector_status status = connector_status_disconnected;
442 
443 	/*
444 	 * NOTE: This function should really take vc4_hdmi->mutex, but
445 	 * doing so results in reentrancy issues since
446 	 * vc4_hdmi_handle_hotplug() can call into other functions that
447 	 * would take the mutex while it's held here.
448 	 *
449 	 * Concurrency isn't an issue at the moment since we don't share
450 	 * any state with any of the other frameworks so we can ignore
451 	 * the lock for now.
452 	 */
453 
454 	WARN_ON(pm_runtime_resume_and_get(&vc4_hdmi->pdev->dev));
455 
456 	if (vc4_hdmi->hpd_gpio) {
457 		if (gpiod_get_value_cansleep(vc4_hdmi->hpd_gpio))
458 			status = connector_status_connected;
459 	} else {
460 		if (vc4_hdmi->variant->hp_detect &&
461 		    vc4_hdmi->variant->hp_detect(vc4_hdmi))
462 			status = connector_status_connected;
463 	}
464 
465 	vc4_hdmi_handle_hotplug(vc4_hdmi, ctx, status);
466 	pm_runtime_put(&vc4_hdmi->pdev->dev);
467 
468 	return status;
469 }
470 
471 static int vc4_hdmi_connector_get_modes(struct drm_connector *connector)
472 {
473 	struct vc4_hdmi *vc4_hdmi = connector_to_vc4_hdmi(connector);
474 	struct vc4_dev *vc4 = to_vc4_dev(connector->dev);
475 	int ret = 0;
476 	struct edid *edid;
477 
478 	/*
479 	 * NOTE: This function should really take vc4_hdmi->mutex, but
480 	 * doing so results in reentrancy issues since
481 	 * cec_s_phys_addr_from_edid might call .adap_enable, which
482 	 * leads to that funtion being called with our mutex held.
483 	 *
484 	 * Concurrency isn't an issue at the moment since we don't share
485 	 * any state with any of the other frameworks so we can ignore
486 	 * the lock for now.
487 	 */
488 
489 	edid = drm_get_edid(connector, vc4_hdmi->ddc);
490 	cec_s_phys_addr_from_edid(vc4_hdmi->cec_adap, edid);
491 	if (!edid)
492 		return -ENODEV;
493 
494 	drm_connector_update_edid_property(connector, edid);
495 	ret = drm_add_edid_modes(connector, edid);
496 	kfree(edid);
497 
498 	if (!vc4->hvs->vc5_hdmi_enable_hdmi_20) {
499 		struct drm_device *drm = connector->dev;
500 		const struct drm_display_mode *mode;
501 
502 		list_for_each_entry(mode, &connector->probed_modes, head) {
503 			if (vc4_hdmi_mode_needs_scrambling(mode, 8, VC4_HDMI_OUTPUT_RGB)) {
504 				drm_warn_once(drm, "The core clock cannot reach frequencies high enough to support 4k @ 60Hz.");
505 				drm_warn_once(drm, "Please change your config.txt file to add hdmi_enable_4kp60.");
506 			}
507 		}
508 	}
509 
510 	return ret;
511 }
512 
513 static int vc4_hdmi_connector_atomic_check(struct drm_connector *connector,
514 					   struct drm_atomic_state *state)
515 {
516 	struct drm_connector_state *old_state =
517 		drm_atomic_get_old_connector_state(state, connector);
518 	struct drm_connector_state *new_state =
519 		drm_atomic_get_new_connector_state(state, connector);
520 	struct drm_crtc *crtc = new_state->crtc;
521 
522 	if (!crtc)
523 		return 0;
524 
525 	if (old_state->colorspace != new_state->colorspace ||
526 	    !drm_connector_atomic_hdr_metadata_equal(old_state, new_state)) {
527 		struct drm_crtc_state *crtc_state;
528 
529 		crtc_state = drm_atomic_get_crtc_state(state, crtc);
530 		if (IS_ERR(crtc_state))
531 			return PTR_ERR(crtc_state);
532 
533 		crtc_state->mode_changed = true;
534 	}
535 
536 	return 0;
537 }
538 
539 static void vc4_hdmi_connector_reset(struct drm_connector *connector)
540 {
541 	struct vc4_hdmi_connector_state *old_state =
542 		conn_state_to_vc4_hdmi_conn_state(connector->state);
543 	struct vc4_hdmi_connector_state *new_state =
544 		kzalloc(sizeof(*new_state), GFP_KERNEL);
545 
546 	if (connector->state)
547 		__drm_atomic_helper_connector_destroy_state(connector->state);
548 
549 	kfree(old_state);
550 	__drm_atomic_helper_connector_reset(connector, &new_state->base);
551 
552 	if (!new_state)
553 		return;
554 
555 	new_state->base.max_bpc = 8;
556 	new_state->base.max_requested_bpc = 8;
557 	new_state->output_format = VC4_HDMI_OUTPUT_RGB;
558 	drm_atomic_helper_connector_tv_margins_reset(connector);
559 }
560 
561 static struct drm_connector_state *
562 vc4_hdmi_connector_duplicate_state(struct drm_connector *connector)
563 {
564 	struct drm_connector_state *conn_state = connector->state;
565 	struct vc4_hdmi_connector_state *vc4_state = conn_state_to_vc4_hdmi_conn_state(conn_state);
566 	struct vc4_hdmi_connector_state *new_state;
567 
568 	new_state = kzalloc(sizeof(*new_state), GFP_KERNEL);
569 	if (!new_state)
570 		return NULL;
571 
572 	new_state->tmds_char_rate = vc4_state->tmds_char_rate;
573 	new_state->output_bpc = vc4_state->output_bpc;
574 	new_state->output_format = vc4_state->output_format;
575 	__drm_atomic_helper_connector_duplicate_state(connector, &new_state->base);
576 
577 	return &new_state->base;
578 }
579 
580 static const struct drm_connector_funcs vc4_hdmi_connector_funcs = {
581 	.fill_modes = drm_helper_probe_single_connector_modes,
582 	.reset = vc4_hdmi_connector_reset,
583 	.atomic_duplicate_state = vc4_hdmi_connector_duplicate_state,
584 	.atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
585 };
586 
587 static const struct drm_connector_helper_funcs vc4_hdmi_connector_helper_funcs = {
588 	.detect_ctx = vc4_hdmi_connector_detect_ctx,
589 	.get_modes = vc4_hdmi_connector_get_modes,
590 	.atomic_check = vc4_hdmi_connector_atomic_check,
591 };
592 
593 static int vc4_hdmi_connector_init(struct drm_device *dev,
594 				   struct vc4_hdmi *vc4_hdmi)
595 {
596 	struct drm_connector *connector = &vc4_hdmi->connector;
597 	struct drm_encoder *encoder = &vc4_hdmi->encoder.base;
598 	int ret;
599 
600 	ret = drmm_connector_init(dev, connector,
601 				  &vc4_hdmi_connector_funcs,
602 				  DRM_MODE_CONNECTOR_HDMIA,
603 				  vc4_hdmi->ddc);
604 	if (ret)
605 		return ret;
606 
607 	drm_connector_helper_add(connector, &vc4_hdmi_connector_helper_funcs);
608 
609 	/*
610 	 * Some of the properties below require access to state, like bpc.
611 	 * Allocate some default initial connector state with our reset helper.
612 	 */
613 	if (connector->funcs->reset)
614 		connector->funcs->reset(connector);
615 
616 	/* Create and attach TV margin props to this connector. */
617 	ret = drm_mode_create_tv_margin_properties(dev);
618 	if (ret)
619 		return ret;
620 
621 	ret = drm_mode_create_hdmi_colorspace_property(connector);
622 	if (ret)
623 		return ret;
624 
625 	drm_connector_attach_colorspace_property(connector);
626 	drm_connector_attach_tv_margin_properties(connector);
627 	drm_connector_attach_max_bpc_property(connector, 8, 12);
628 
629 	connector->polled = (DRM_CONNECTOR_POLL_CONNECT |
630 			     DRM_CONNECTOR_POLL_DISCONNECT);
631 
632 	connector->interlace_allowed = 1;
633 	connector->doublescan_allowed = 0;
634 	connector->stereo_allowed = 1;
635 
636 	if (vc4_hdmi->variant->supports_hdr)
637 		drm_connector_attach_hdr_output_metadata_property(connector);
638 
639 	drm_connector_attach_encoder(connector, encoder);
640 
641 	return 0;
642 }
643 
644 static int vc4_hdmi_stop_packet(struct drm_encoder *encoder,
645 				enum hdmi_infoframe_type type,
646 				bool poll)
647 {
648 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
649 	struct drm_device *drm = vc4_hdmi->connector.dev;
650 	u32 packet_id = type - 0x80;
651 	unsigned long flags;
652 	int ret = 0;
653 	int idx;
654 
655 	if (!drm_dev_enter(drm, &idx))
656 		return -ENODEV;
657 
658 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
659 	HDMI_WRITE(HDMI_RAM_PACKET_CONFIG,
660 		   HDMI_READ(HDMI_RAM_PACKET_CONFIG) & ~BIT(packet_id));
661 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
662 
663 	if (poll) {
664 		ret = wait_for(!(HDMI_READ(HDMI_RAM_PACKET_STATUS) &
665 				 BIT(packet_id)), 100);
666 	}
667 
668 	drm_dev_exit(idx);
669 	return ret;
670 }
671 
672 static void vc4_hdmi_write_infoframe(struct drm_encoder *encoder,
673 				     union hdmi_infoframe *frame)
674 {
675 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
676 	struct drm_device *drm = vc4_hdmi->connector.dev;
677 	u32 packet_id = frame->any.type - 0x80;
678 	const struct vc4_hdmi_register *ram_packet_start =
679 		&vc4_hdmi->variant->registers[HDMI_RAM_PACKET_START];
680 	u32 packet_reg = ram_packet_start->offset + VC4_HDMI_PACKET_STRIDE * packet_id;
681 	u32 packet_reg_next = ram_packet_start->offset +
682 		VC4_HDMI_PACKET_STRIDE * (packet_id + 1);
683 	void __iomem *base = __vc4_hdmi_get_field_base(vc4_hdmi,
684 						       ram_packet_start->reg);
685 	uint8_t buffer[VC4_HDMI_PACKET_STRIDE] = {};
686 	unsigned long flags;
687 	ssize_t len, i;
688 	int ret;
689 	int idx;
690 
691 	if (!drm_dev_enter(drm, &idx))
692 		return;
693 
694 	WARN_ONCE(!(HDMI_READ(HDMI_RAM_PACKET_CONFIG) &
695 		    VC4_HDMI_RAM_PACKET_ENABLE),
696 		  "Packet RAM has to be on to store the packet.");
697 
698 	len = hdmi_infoframe_pack(frame, buffer, sizeof(buffer));
699 	if (len < 0)
700 		goto out;
701 
702 	ret = vc4_hdmi_stop_packet(encoder, frame->any.type, true);
703 	if (ret) {
704 		DRM_ERROR("Failed to wait for infoframe to go idle: %d\n", ret);
705 		goto out;
706 	}
707 
708 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
709 
710 	for (i = 0; i < len; i += 7) {
711 		writel(buffer[i + 0] << 0 |
712 		       buffer[i + 1] << 8 |
713 		       buffer[i + 2] << 16,
714 		       base + packet_reg);
715 		packet_reg += 4;
716 
717 		writel(buffer[i + 3] << 0 |
718 		       buffer[i + 4] << 8 |
719 		       buffer[i + 5] << 16 |
720 		       buffer[i + 6] << 24,
721 		       base + packet_reg);
722 		packet_reg += 4;
723 	}
724 
725 	/*
726 	 * clear remainder of packet ram as it's included in the
727 	 * infoframe and triggers a checksum error on hdmi analyser
728 	 */
729 	for (; packet_reg < packet_reg_next; packet_reg += 4)
730 		writel(0, base + packet_reg);
731 
732 	HDMI_WRITE(HDMI_RAM_PACKET_CONFIG,
733 		   HDMI_READ(HDMI_RAM_PACKET_CONFIG) | BIT(packet_id));
734 
735 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
736 
737 	ret = wait_for((HDMI_READ(HDMI_RAM_PACKET_STATUS) &
738 			BIT(packet_id)), 100);
739 	if (ret)
740 		DRM_ERROR("Failed to wait for infoframe to start: %d\n", ret);
741 
742 out:
743 	drm_dev_exit(idx);
744 }
745 
746 static void vc4_hdmi_avi_infoframe_colorspace(struct hdmi_avi_infoframe *frame,
747 					      enum vc4_hdmi_output_format fmt)
748 {
749 	switch (fmt) {
750 	case VC4_HDMI_OUTPUT_RGB:
751 		frame->colorspace = HDMI_COLORSPACE_RGB;
752 		break;
753 
754 	case VC4_HDMI_OUTPUT_YUV420:
755 		frame->colorspace = HDMI_COLORSPACE_YUV420;
756 		break;
757 
758 	case VC4_HDMI_OUTPUT_YUV422:
759 		frame->colorspace = HDMI_COLORSPACE_YUV422;
760 		break;
761 
762 	case VC4_HDMI_OUTPUT_YUV444:
763 		frame->colorspace = HDMI_COLORSPACE_YUV444;
764 		break;
765 
766 	default:
767 		break;
768 	}
769 }
770 
771 static void vc4_hdmi_set_avi_infoframe(struct drm_encoder *encoder)
772 {
773 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
774 	struct drm_connector *connector = &vc4_hdmi->connector;
775 	struct drm_connector_state *cstate = connector->state;
776 	struct vc4_hdmi_connector_state *vc4_state =
777 		conn_state_to_vc4_hdmi_conn_state(cstate);
778 	const struct drm_display_mode *mode = &vc4_hdmi->saved_adjusted_mode;
779 	union hdmi_infoframe frame;
780 	int ret;
781 
782 	lockdep_assert_held(&vc4_hdmi->mutex);
783 
784 	ret = drm_hdmi_avi_infoframe_from_display_mode(&frame.avi,
785 						       connector, mode);
786 	if (ret < 0) {
787 		DRM_ERROR("couldn't fill AVI infoframe\n");
788 		return;
789 	}
790 
791 	drm_hdmi_avi_infoframe_quant_range(&frame.avi,
792 					   connector, mode,
793 					   vc4_hdmi_is_full_range_rgb(vc4_hdmi, mode) ?
794 					   HDMI_QUANTIZATION_RANGE_FULL :
795 					   HDMI_QUANTIZATION_RANGE_LIMITED);
796 	drm_hdmi_avi_infoframe_colorimetry(&frame.avi, cstate);
797 	vc4_hdmi_avi_infoframe_colorspace(&frame.avi, vc4_state->output_format);
798 	drm_hdmi_avi_infoframe_bars(&frame.avi, cstate);
799 
800 	vc4_hdmi_write_infoframe(encoder, &frame);
801 }
802 
803 static void vc4_hdmi_set_spd_infoframe(struct drm_encoder *encoder)
804 {
805 	union hdmi_infoframe frame;
806 	int ret;
807 
808 	ret = hdmi_spd_infoframe_init(&frame.spd, "Broadcom", "Videocore");
809 	if (ret < 0) {
810 		DRM_ERROR("couldn't fill SPD infoframe\n");
811 		return;
812 	}
813 
814 	frame.spd.sdi = HDMI_SPD_SDI_PC;
815 
816 	vc4_hdmi_write_infoframe(encoder, &frame);
817 }
818 
819 static void vc4_hdmi_set_audio_infoframe(struct drm_encoder *encoder)
820 {
821 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
822 	struct hdmi_audio_infoframe *audio = &vc4_hdmi->audio.infoframe;
823 	union hdmi_infoframe frame;
824 
825 	memcpy(&frame.audio, audio, sizeof(*audio));
826 
827 	if (vc4_hdmi->packet_ram_enabled)
828 		vc4_hdmi_write_infoframe(encoder, &frame);
829 }
830 
831 static void vc4_hdmi_set_hdr_infoframe(struct drm_encoder *encoder)
832 {
833 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
834 	struct drm_connector *connector = &vc4_hdmi->connector;
835 	struct drm_connector_state *conn_state = connector->state;
836 	union hdmi_infoframe frame;
837 
838 	lockdep_assert_held(&vc4_hdmi->mutex);
839 
840 	if (!vc4_hdmi->variant->supports_hdr)
841 		return;
842 
843 	if (!conn_state->hdr_output_metadata)
844 		return;
845 
846 	if (drm_hdmi_infoframe_set_hdr_metadata(&frame.drm, conn_state))
847 		return;
848 
849 	vc4_hdmi_write_infoframe(encoder, &frame);
850 }
851 
852 static void vc4_hdmi_set_infoframes(struct drm_encoder *encoder)
853 {
854 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
855 
856 	lockdep_assert_held(&vc4_hdmi->mutex);
857 
858 	vc4_hdmi_set_avi_infoframe(encoder);
859 	vc4_hdmi_set_spd_infoframe(encoder);
860 	/*
861 	 * If audio was streaming, then we need to reenabled the audio
862 	 * infoframe here during encoder_enable.
863 	 */
864 	if (vc4_hdmi->audio.streaming)
865 		vc4_hdmi_set_audio_infoframe(encoder);
866 
867 	vc4_hdmi_set_hdr_infoframe(encoder);
868 }
869 
870 #define SCRAMBLING_POLLING_DELAY_MS	1000
871 
872 static void vc4_hdmi_enable_scrambling(struct drm_encoder *encoder)
873 {
874 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
875 	struct drm_device *drm = vc4_hdmi->connector.dev;
876 	const struct drm_display_mode *mode = &vc4_hdmi->saved_adjusted_mode;
877 	unsigned long flags;
878 	int idx;
879 
880 	lockdep_assert_held(&vc4_hdmi->mutex);
881 
882 	if (!vc4_hdmi_supports_scrambling(vc4_hdmi))
883 		return;
884 
885 	if (!vc4_hdmi_mode_needs_scrambling(mode,
886 					    vc4_hdmi->output_bpc,
887 					    vc4_hdmi->output_format))
888 		return;
889 
890 	if (!drm_dev_enter(drm, &idx))
891 		return;
892 
893 	drm_scdc_set_high_tmds_clock_ratio(vc4_hdmi->ddc, true);
894 	drm_scdc_set_scrambling(vc4_hdmi->ddc, true);
895 
896 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
897 	HDMI_WRITE(HDMI_SCRAMBLER_CTL, HDMI_READ(HDMI_SCRAMBLER_CTL) |
898 		   VC5_HDMI_SCRAMBLER_CTL_ENABLE);
899 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
900 
901 	drm_dev_exit(idx);
902 
903 	vc4_hdmi->scdc_enabled = true;
904 
905 	queue_delayed_work(system_wq, &vc4_hdmi->scrambling_work,
906 			   msecs_to_jiffies(SCRAMBLING_POLLING_DELAY_MS));
907 }
908 
909 static void vc4_hdmi_disable_scrambling(struct drm_encoder *encoder)
910 {
911 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
912 	struct drm_device *drm = vc4_hdmi->connector.dev;
913 	unsigned long flags;
914 	int idx;
915 
916 	lockdep_assert_held(&vc4_hdmi->mutex);
917 
918 	if (!vc4_hdmi->scdc_enabled)
919 		return;
920 
921 	vc4_hdmi->scdc_enabled = false;
922 
923 	if (delayed_work_pending(&vc4_hdmi->scrambling_work))
924 		cancel_delayed_work_sync(&vc4_hdmi->scrambling_work);
925 
926 	if (!drm_dev_enter(drm, &idx))
927 		return;
928 
929 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
930 	HDMI_WRITE(HDMI_SCRAMBLER_CTL, HDMI_READ(HDMI_SCRAMBLER_CTL) &
931 		   ~VC5_HDMI_SCRAMBLER_CTL_ENABLE);
932 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
933 
934 	drm_scdc_set_scrambling(vc4_hdmi->ddc, false);
935 	drm_scdc_set_high_tmds_clock_ratio(vc4_hdmi->ddc, false);
936 
937 	drm_dev_exit(idx);
938 }
939 
940 static void vc4_hdmi_scrambling_wq(struct work_struct *work)
941 {
942 	struct vc4_hdmi *vc4_hdmi = container_of(to_delayed_work(work),
943 						 struct vc4_hdmi,
944 						 scrambling_work);
945 
946 	if (drm_scdc_get_scrambling_status(vc4_hdmi->ddc))
947 		return;
948 
949 	drm_scdc_set_high_tmds_clock_ratio(vc4_hdmi->ddc, true);
950 	drm_scdc_set_scrambling(vc4_hdmi->ddc, true);
951 
952 	queue_delayed_work(system_wq, &vc4_hdmi->scrambling_work,
953 			   msecs_to_jiffies(SCRAMBLING_POLLING_DELAY_MS));
954 }
955 
956 static void vc4_hdmi_encoder_post_crtc_disable(struct drm_encoder *encoder,
957 					       struct drm_atomic_state *state)
958 {
959 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
960 	struct drm_device *drm = vc4_hdmi->connector.dev;
961 	unsigned long flags;
962 	int idx;
963 
964 	mutex_lock(&vc4_hdmi->mutex);
965 
966 	vc4_hdmi->packet_ram_enabled = false;
967 
968 	if (!drm_dev_enter(drm, &idx))
969 		goto out;
970 
971 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
972 
973 	HDMI_WRITE(HDMI_RAM_PACKET_CONFIG, 0);
974 
975 	HDMI_WRITE(HDMI_VID_CTL, HDMI_READ(HDMI_VID_CTL) | VC4_HD_VID_CTL_CLRRGB);
976 
977 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
978 
979 	mdelay(1);
980 
981 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
982 	HDMI_WRITE(HDMI_VID_CTL,
983 		   HDMI_READ(HDMI_VID_CTL) & ~VC4_HD_VID_CTL_ENABLE);
984 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
985 
986 	vc4_hdmi_disable_scrambling(encoder);
987 
988 	drm_dev_exit(idx);
989 
990 out:
991 	mutex_unlock(&vc4_hdmi->mutex);
992 }
993 
994 static void vc4_hdmi_encoder_post_crtc_powerdown(struct drm_encoder *encoder,
995 						 struct drm_atomic_state *state)
996 {
997 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
998 	struct drm_device *drm = vc4_hdmi->connector.dev;
999 	unsigned long flags;
1000 	int ret;
1001 	int idx;
1002 
1003 	mutex_lock(&vc4_hdmi->mutex);
1004 
1005 	if (!drm_dev_enter(drm, &idx))
1006 		goto out;
1007 
1008 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
1009 	HDMI_WRITE(HDMI_VID_CTL,
1010 		   HDMI_READ(HDMI_VID_CTL) | VC4_HD_VID_CTL_BLANKPIX);
1011 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
1012 
1013 	if (vc4_hdmi->variant->phy_disable)
1014 		vc4_hdmi->variant->phy_disable(vc4_hdmi);
1015 
1016 	clk_disable_unprepare(vc4_hdmi->pixel_bvb_clock);
1017 	clk_disable_unprepare(vc4_hdmi->pixel_clock);
1018 
1019 	ret = pm_runtime_put(&vc4_hdmi->pdev->dev);
1020 	if (ret < 0)
1021 		DRM_ERROR("Failed to release power domain: %d\n", ret);
1022 
1023 	drm_dev_exit(idx);
1024 
1025 out:
1026 	mutex_unlock(&vc4_hdmi->mutex);
1027 }
1028 
1029 static void vc4_hdmi_csc_setup(struct vc4_hdmi *vc4_hdmi,
1030 			       struct drm_connector_state *state,
1031 			       const struct drm_display_mode *mode)
1032 {
1033 	struct drm_device *drm = vc4_hdmi->connector.dev;
1034 	unsigned long flags;
1035 	u32 csc_ctl;
1036 	int idx;
1037 
1038 	if (!drm_dev_enter(drm, &idx))
1039 		return;
1040 
1041 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
1042 
1043 	csc_ctl = VC4_SET_FIELD(VC4_HD_CSC_CTL_ORDER_BGR,
1044 				VC4_HD_CSC_CTL_ORDER);
1045 
1046 	if (!vc4_hdmi_is_full_range_rgb(vc4_hdmi, mode)) {
1047 		/* CEA VICs other than #1 requre limited range RGB
1048 		 * output unless overridden by an AVI infoframe.
1049 		 * Apply a colorspace conversion to squash 0-255 down
1050 		 * to 16-235.  The matrix here is:
1051 		 *
1052 		 * [ 0      0      0.8594 16]
1053 		 * [ 0      0.8594 0      16]
1054 		 * [ 0.8594 0      0      16]
1055 		 * [ 0      0      0       1]
1056 		 */
1057 		csc_ctl |= VC4_HD_CSC_CTL_ENABLE;
1058 		csc_ctl |= VC4_HD_CSC_CTL_RGB2YCC;
1059 		csc_ctl |= VC4_SET_FIELD(VC4_HD_CSC_CTL_MODE_CUSTOM,
1060 					 VC4_HD_CSC_CTL_MODE);
1061 
1062 		HDMI_WRITE(HDMI_CSC_12_11, (0x000 << 16) | 0x000);
1063 		HDMI_WRITE(HDMI_CSC_14_13, (0x100 << 16) | 0x6e0);
1064 		HDMI_WRITE(HDMI_CSC_22_21, (0x6e0 << 16) | 0x000);
1065 		HDMI_WRITE(HDMI_CSC_24_23, (0x100 << 16) | 0x000);
1066 		HDMI_WRITE(HDMI_CSC_32_31, (0x000 << 16) | 0x6e0);
1067 		HDMI_WRITE(HDMI_CSC_34_33, (0x100 << 16) | 0x000);
1068 	}
1069 
1070 	/* The RGB order applies even when CSC is disabled. */
1071 	HDMI_WRITE(HDMI_CSC_CTL, csc_ctl);
1072 
1073 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
1074 
1075 	drm_dev_exit(idx);
1076 }
1077 
1078 /*
1079  * If we need to output Full Range RGB, then use the unity matrix
1080  *
1081  * [ 1      0      0      0]
1082  * [ 0      1      0      0]
1083  * [ 0      0      1      0]
1084  *
1085  * Matrix is signed 2p13 fixed point, with signed 9p6 offsets
1086  */
1087 static const u16 vc5_hdmi_csc_full_rgb_unity[3][4] = {
1088 	{ 0x2000, 0x0000, 0x0000, 0x0000 },
1089 	{ 0x0000, 0x2000, 0x0000, 0x0000 },
1090 	{ 0x0000, 0x0000, 0x2000, 0x0000 },
1091 };
1092 
1093 /*
1094  * CEA VICs other than #1 require limited range RGB output unless
1095  * overridden by an AVI infoframe. Apply a colorspace conversion to
1096  * squash 0-255 down to 16-235. The matrix here is:
1097  *
1098  * [ 0.8594 0      0      16]
1099  * [ 0      0.8594 0      16]
1100  * [ 0      0      0.8594 16]
1101  *
1102  * Matrix is signed 2p13 fixed point, with signed 9p6 offsets
1103  */
1104 static const u16 vc5_hdmi_csc_full_rgb_to_limited_rgb[3][4] = {
1105 	{ 0x1b80, 0x0000, 0x0000, 0x0400 },
1106 	{ 0x0000, 0x1b80, 0x0000, 0x0400 },
1107 	{ 0x0000, 0x0000, 0x1b80, 0x0400 },
1108 };
1109 
1110 /*
1111  * Conversion between Full Range RGB and Full Range YUV422 using the
1112  * BT.709 Colorspace
1113  *
1114  *
1115  * [  0.181906  0.611804  0.061758  16  ]
1116  * [ -0.100268 -0.337232  0.437500  128 ]
1117  * [  0.437500 -0.397386 -0.040114  128 ]
1118  *
1119  * Matrix is signed 2p13 fixed point, with signed 9p6 offsets
1120  */
1121 static const u16 vc5_hdmi_csc_full_rgb_to_limited_yuv422_bt709[3][4] = {
1122 	{ 0x05d2, 0x1394, 0x01fa, 0x0400 },
1123 	{ 0xfccc, 0xf536, 0x0e00, 0x2000 },
1124 	{ 0x0e00, 0xf34a, 0xfeb8, 0x2000 },
1125 };
1126 
1127 /*
1128  * Conversion between Full Range RGB and Full Range YUV444 using the
1129  * BT.709 Colorspace
1130  *
1131  * [ -0.100268 -0.337232  0.437500  128 ]
1132  * [  0.437500 -0.397386 -0.040114  128 ]
1133  * [  0.181906  0.611804  0.061758  16  ]
1134  *
1135  * Matrix is signed 2p13 fixed point, with signed 9p6 offsets
1136  */
1137 static const u16 vc5_hdmi_csc_full_rgb_to_limited_yuv444_bt709[3][4] = {
1138 	{ 0xfccc, 0xf536, 0x0e00, 0x2000 },
1139 	{ 0x0e00, 0xf34a, 0xfeb8, 0x2000 },
1140 	{ 0x05d2, 0x1394, 0x01fa, 0x0400 },
1141 };
1142 
1143 static void vc5_hdmi_set_csc_coeffs(struct vc4_hdmi *vc4_hdmi,
1144 				    const u16 coeffs[3][4])
1145 {
1146 	lockdep_assert_held(&vc4_hdmi->hw_lock);
1147 
1148 	HDMI_WRITE(HDMI_CSC_12_11, (coeffs[0][1] << 16) | coeffs[0][0]);
1149 	HDMI_WRITE(HDMI_CSC_14_13, (coeffs[0][3] << 16) | coeffs[0][2]);
1150 	HDMI_WRITE(HDMI_CSC_22_21, (coeffs[1][1] << 16) | coeffs[1][0]);
1151 	HDMI_WRITE(HDMI_CSC_24_23, (coeffs[1][3] << 16) | coeffs[1][2]);
1152 	HDMI_WRITE(HDMI_CSC_32_31, (coeffs[2][1] << 16) | coeffs[2][0]);
1153 	HDMI_WRITE(HDMI_CSC_34_33, (coeffs[2][3] << 16) | coeffs[2][2]);
1154 }
1155 
1156 static void vc5_hdmi_csc_setup(struct vc4_hdmi *vc4_hdmi,
1157 			       struct drm_connector_state *state,
1158 			       const struct drm_display_mode *mode)
1159 {
1160 	struct drm_device *drm = vc4_hdmi->connector.dev;
1161 	struct vc4_hdmi_connector_state *vc4_state =
1162 		conn_state_to_vc4_hdmi_conn_state(state);
1163 	unsigned long flags;
1164 	u32 if_cfg = 0;
1165 	u32 if_xbar = 0x543210;
1166 	u32 csc_chan_ctl = 0;
1167 	u32 csc_ctl = VC5_MT_CP_CSC_CTL_ENABLE | VC4_SET_FIELD(VC4_HD_CSC_CTL_MODE_CUSTOM,
1168 							       VC5_MT_CP_CSC_CTL_MODE);
1169 	int idx;
1170 
1171 	if (!drm_dev_enter(drm, &idx))
1172 		return;
1173 
1174 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
1175 
1176 	switch (vc4_state->output_format) {
1177 	case VC4_HDMI_OUTPUT_YUV444:
1178 		vc5_hdmi_set_csc_coeffs(vc4_hdmi, vc5_hdmi_csc_full_rgb_to_limited_yuv444_bt709);
1179 		break;
1180 
1181 	case VC4_HDMI_OUTPUT_YUV422:
1182 		csc_ctl |= VC4_SET_FIELD(VC5_MT_CP_CSC_CTL_FILTER_MODE_444_TO_422_STANDARD,
1183 					 VC5_MT_CP_CSC_CTL_FILTER_MODE_444_TO_422) |
1184 			VC5_MT_CP_CSC_CTL_USE_444_TO_422 |
1185 			VC5_MT_CP_CSC_CTL_USE_RNG_SUPPRESSION;
1186 
1187 		csc_chan_ctl |= VC4_SET_FIELD(VC5_MT_CP_CHANNEL_CTL_OUTPUT_REMAP_LEGACY_STYLE,
1188 					      VC5_MT_CP_CHANNEL_CTL_OUTPUT_REMAP);
1189 
1190 		if_cfg |= VC4_SET_FIELD(VC5_DVP_HT_VEC_INTERFACE_CFG_SEL_422_FORMAT_422_LEGACY,
1191 					VC5_DVP_HT_VEC_INTERFACE_CFG_SEL_422);
1192 
1193 		vc5_hdmi_set_csc_coeffs(vc4_hdmi, vc5_hdmi_csc_full_rgb_to_limited_yuv422_bt709);
1194 		break;
1195 
1196 	case VC4_HDMI_OUTPUT_RGB:
1197 		if_xbar = 0x354021;
1198 
1199 		if (!vc4_hdmi_is_full_range_rgb(vc4_hdmi, mode))
1200 			vc5_hdmi_set_csc_coeffs(vc4_hdmi, vc5_hdmi_csc_full_rgb_to_limited_rgb);
1201 		else
1202 			vc5_hdmi_set_csc_coeffs(vc4_hdmi, vc5_hdmi_csc_full_rgb_unity);
1203 		break;
1204 
1205 	default:
1206 		break;
1207 	}
1208 
1209 	HDMI_WRITE(HDMI_VEC_INTERFACE_CFG, if_cfg);
1210 	HDMI_WRITE(HDMI_VEC_INTERFACE_XBAR, if_xbar);
1211 	HDMI_WRITE(HDMI_CSC_CHANNEL_CTL, csc_chan_ctl);
1212 	HDMI_WRITE(HDMI_CSC_CTL, csc_ctl);
1213 
1214 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
1215 
1216 	drm_dev_exit(idx);
1217 }
1218 
1219 static void vc4_hdmi_set_timings(struct vc4_hdmi *vc4_hdmi,
1220 				 struct drm_connector_state *state,
1221 				 const struct drm_display_mode *mode)
1222 {
1223 	struct drm_device *drm = vc4_hdmi->connector.dev;
1224 	bool hsync_pos = mode->flags & DRM_MODE_FLAG_PHSYNC;
1225 	bool vsync_pos = mode->flags & DRM_MODE_FLAG_PVSYNC;
1226 	bool interlaced = mode->flags & DRM_MODE_FLAG_INTERLACE;
1227 	u32 pixel_rep = (mode->flags & DRM_MODE_FLAG_DBLCLK) ? 2 : 1;
1228 	u32 verta = (VC4_SET_FIELD(mode->crtc_vsync_end - mode->crtc_vsync_start,
1229 				   VC4_HDMI_VERTA_VSP) |
1230 		     VC4_SET_FIELD(mode->crtc_vsync_start - mode->crtc_vdisplay,
1231 				   VC4_HDMI_VERTA_VFP) |
1232 		     VC4_SET_FIELD(mode->crtc_vdisplay, VC4_HDMI_VERTA_VAL));
1233 	u32 vertb = (VC4_SET_FIELD(0, VC4_HDMI_VERTB_VSPO) |
1234 		     VC4_SET_FIELD(mode->crtc_vtotal - mode->crtc_vsync_end +
1235 				   interlaced,
1236 				   VC4_HDMI_VERTB_VBP));
1237 	u32 vertb_even = (VC4_SET_FIELD(0, VC4_HDMI_VERTB_VSPO) |
1238 			  VC4_SET_FIELD(mode->crtc_vtotal -
1239 					mode->crtc_vsync_end,
1240 					VC4_HDMI_VERTB_VBP));
1241 	unsigned long flags;
1242 	u32 reg;
1243 	int idx;
1244 
1245 	if (!drm_dev_enter(drm, &idx))
1246 		return;
1247 
1248 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
1249 
1250 	HDMI_WRITE(HDMI_HORZA,
1251 		   (vsync_pos ? VC4_HDMI_HORZA_VPOS : 0) |
1252 		   (hsync_pos ? VC4_HDMI_HORZA_HPOS : 0) |
1253 		   VC4_SET_FIELD(mode->hdisplay * pixel_rep,
1254 				 VC4_HDMI_HORZA_HAP));
1255 
1256 	HDMI_WRITE(HDMI_HORZB,
1257 		   VC4_SET_FIELD((mode->htotal -
1258 				  mode->hsync_end) * pixel_rep,
1259 				 VC4_HDMI_HORZB_HBP) |
1260 		   VC4_SET_FIELD((mode->hsync_end -
1261 				  mode->hsync_start) * pixel_rep,
1262 				 VC4_HDMI_HORZB_HSP) |
1263 		   VC4_SET_FIELD((mode->hsync_start -
1264 				  mode->hdisplay) * pixel_rep,
1265 				 VC4_HDMI_HORZB_HFP));
1266 
1267 	HDMI_WRITE(HDMI_VERTA0, verta);
1268 	HDMI_WRITE(HDMI_VERTA1, verta);
1269 
1270 	HDMI_WRITE(HDMI_VERTB0, vertb_even);
1271 	HDMI_WRITE(HDMI_VERTB1, vertb);
1272 
1273 	reg = HDMI_READ(HDMI_MISC_CONTROL);
1274 	reg &= ~VC4_HDMI_MISC_CONTROL_PIXEL_REP_MASK;
1275 	reg |= VC4_SET_FIELD(pixel_rep - 1, VC4_HDMI_MISC_CONTROL_PIXEL_REP);
1276 	HDMI_WRITE(HDMI_MISC_CONTROL, reg);
1277 
1278 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
1279 
1280 	drm_dev_exit(idx);
1281 }
1282 
1283 static void vc5_hdmi_set_timings(struct vc4_hdmi *vc4_hdmi,
1284 				 struct drm_connector_state *state,
1285 				 const struct drm_display_mode *mode)
1286 {
1287 	struct drm_device *drm = vc4_hdmi->connector.dev;
1288 	const struct vc4_hdmi_connector_state *vc4_state =
1289 		conn_state_to_vc4_hdmi_conn_state(state);
1290 	bool hsync_pos = mode->flags & DRM_MODE_FLAG_PHSYNC;
1291 	bool vsync_pos = mode->flags & DRM_MODE_FLAG_PVSYNC;
1292 	bool interlaced = mode->flags & DRM_MODE_FLAG_INTERLACE;
1293 	u32 pixel_rep = (mode->flags & DRM_MODE_FLAG_DBLCLK) ? 2 : 1;
1294 	u32 verta = (VC4_SET_FIELD(mode->crtc_vsync_end - mode->crtc_vsync_start,
1295 				   VC5_HDMI_VERTA_VSP) |
1296 		     VC4_SET_FIELD(mode->crtc_vsync_start - mode->crtc_vdisplay,
1297 				   VC5_HDMI_VERTA_VFP) |
1298 		     VC4_SET_FIELD(mode->crtc_vdisplay, VC5_HDMI_VERTA_VAL));
1299 	u32 vertb = (VC4_SET_FIELD(mode->htotal >> (2 - pixel_rep),
1300 				   VC5_HDMI_VERTB_VSPO) |
1301 		     VC4_SET_FIELD(mode->crtc_vtotal - mode->crtc_vsync_end,
1302 				   VC4_HDMI_VERTB_VBP));
1303 	u32 vertb_even = (VC4_SET_FIELD(0, VC5_HDMI_VERTB_VSPO) |
1304 			  VC4_SET_FIELD(mode->crtc_vtotal -
1305 					mode->crtc_vsync_end - interlaced,
1306 					VC4_HDMI_VERTB_VBP));
1307 	unsigned long flags;
1308 	unsigned char gcp;
1309 	bool gcp_en;
1310 	u32 reg;
1311 	int idx;
1312 
1313 	if (!drm_dev_enter(drm, &idx))
1314 		return;
1315 
1316 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
1317 
1318 	HDMI_WRITE(HDMI_HORZA,
1319 		   (vsync_pos ? VC5_HDMI_HORZA_VPOS : 0) |
1320 		   (hsync_pos ? VC5_HDMI_HORZA_HPOS : 0) |
1321 		   VC4_SET_FIELD(mode->hdisplay * pixel_rep,
1322 				 VC5_HDMI_HORZA_HAP) |
1323 		   VC4_SET_FIELD((mode->hsync_start -
1324 				  mode->hdisplay) * pixel_rep,
1325 				 VC5_HDMI_HORZA_HFP));
1326 
1327 	HDMI_WRITE(HDMI_HORZB,
1328 		   VC4_SET_FIELD((mode->htotal -
1329 				  mode->hsync_end) * pixel_rep,
1330 				 VC5_HDMI_HORZB_HBP) |
1331 		   VC4_SET_FIELD((mode->hsync_end -
1332 				  mode->hsync_start) * pixel_rep,
1333 				 VC5_HDMI_HORZB_HSP));
1334 
1335 	HDMI_WRITE(HDMI_VERTA0, verta);
1336 	HDMI_WRITE(HDMI_VERTA1, verta);
1337 
1338 	HDMI_WRITE(HDMI_VERTB0, vertb_even);
1339 	HDMI_WRITE(HDMI_VERTB1, vertb);
1340 
1341 	switch (vc4_state->output_bpc) {
1342 	case 12:
1343 		gcp = 6;
1344 		gcp_en = true;
1345 		break;
1346 	case 10:
1347 		gcp = 5;
1348 		gcp_en = true;
1349 		break;
1350 	case 8:
1351 	default:
1352 		gcp = 4;
1353 		gcp_en = false;
1354 		break;
1355 	}
1356 
1357 	/*
1358 	 * YCC422 is always 36-bit and not considered deep colour so
1359 	 * doesn't signal in GCP.
1360 	 */
1361 	if (vc4_state->output_format == VC4_HDMI_OUTPUT_YUV422) {
1362 		gcp = 4;
1363 		gcp_en = false;
1364 	}
1365 
1366 	reg = HDMI_READ(HDMI_DEEP_COLOR_CONFIG_1);
1367 	reg &= ~(VC5_HDMI_DEEP_COLOR_CONFIG_1_INIT_PACK_PHASE_MASK |
1368 		 VC5_HDMI_DEEP_COLOR_CONFIG_1_COLOR_DEPTH_MASK);
1369 	reg |= VC4_SET_FIELD(2, VC5_HDMI_DEEP_COLOR_CONFIG_1_INIT_PACK_PHASE) |
1370 	       VC4_SET_FIELD(gcp, VC5_HDMI_DEEP_COLOR_CONFIG_1_COLOR_DEPTH);
1371 	HDMI_WRITE(HDMI_DEEP_COLOR_CONFIG_1, reg);
1372 
1373 	reg = HDMI_READ(HDMI_GCP_WORD_1);
1374 	reg &= ~VC5_HDMI_GCP_WORD_1_GCP_SUBPACKET_BYTE_1_MASK;
1375 	reg |= VC4_SET_FIELD(gcp, VC5_HDMI_GCP_WORD_1_GCP_SUBPACKET_BYTE_1);
1376 	HDMI_WRITE(HDMI_GCP_WORD_1, reg);
1377 
1378 	reg = HDMI_READ(HDMI_GCP_CONFIG);
1379 	reg &= ~VC5_HDMI_GCP_CONFIG_GCP_ENABLE;
1380 	reg |= gcp_en ? VC5_HDMI_GCP_CONFIG_GCP_ENABLE : 0;
1381 	HDMI_WRITE(HDMI_GCP_CONFIG, reg);
1382 
1383 	reg = HDMI_READ(HDMI_MISC_CONTROL);
1384 	reg &= ~VC5_HDMI_MISC_CONTROL_PIXEL_REP_MASK;
1385 	reg |= VC4_SET_FIELD(pixel_rep - 1, VC5_HDMI_MISC_CONTROL_PIXEL_REP);
1386 	HDMI_WRITE(HDMI_MISC_CONTROL, reg);
1387 
1388 	HDMI_WRITE(HDMI_CLOCK_STOP, 0);
1389 
1390 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
1391 
1392 	drm_dev_exit(idx);
1393 }
1394 
1395 static void vc4_hdmi_recenter_fifo(struct vc4_hdmi *vc4_hdmi)
1396 {
1397 	struct drm_device *drm = vc4_hdmi->connector.dev;
1398 	unsigned long flags;
1399 	u32 drift;
1400 	int ret;
1401 	int idx;
1402 
1403 	if (!drm_dev_enter(drm, &idx))
1404 		return;
1405 
1406 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
1407 
1408 	drift = HDMI_READ(HDMI_FIFO_CTL);
1409 	drift &= VC4_HDMI_FIFO_VALID_WRITE_MASK;
1410 
1411 	HDMI_WRITE(HDMI_FIFO_CTL,
1412 		   drift & ~VC4_HDMI_FIFO_CTL_RECENTER);
1413 	HDMI_WRITE(HDMI_FIFO_CTL,
1414 		   drift | VC4_HDMI_FIFO_CTL_RECENTER);
1415 
1416 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
1417 
1418 	usleep_range(1000, 1100);
1419 
1420 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
1421 
1422 	HDMI_WRITE(HDMI_FIFO_CTL,
1423 		   drift & ~VC4_HDMI_FIFO_CTL_RECENTER);
1424 	HDMI_WRITE(HDMI_FIFO_CTL,
1425 		   drift | VC4_HDMI_FIFO_CTL_RECENTER);
1426 
1427 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
1428 
1429 	ret = wait_for(HDMI_READ(HDMI_FIFO_CTL) &
1430 		       VC4_HDMI_FIFO_CTL_RECENTER_DONE, 1);
1431 	WARN_ONCE(ret, "Timeout waiting for "
1432 		  "VC4_HDMI_FIFO_CTL_RECENTER_DONE");
1433 
1434 	drm_dev_exit(idx);
1435 }
1436 
1437 static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder,
1438 						struct drm_atomic_state *state)
1439 {
1440 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
1441 	struct drm_device *drm = vc4_hdmi->connector.dev;
1442 	struct drm_connector *connector = &vc4_hdmi->connector;
1443 	struct drm_connector_state *conn_state =
1444 		drm_atomic_get_new_connector_state(state, connector);
1445 	struct vc4_hdmi_connector_state *vc4_conn_state =
1446 		conn_state_to_vc4_hdmi_conn_state(conn_state);
1447 	const struct drm_display_mode *mode = &vc4_hdmi->saved_adjusted_mode;
1448 	unsigned long tmds_char_rate = vc4_conn_state->tmds_char_rate;
1449 	unsigned long bvb_rate, hsm_rate;
1450 	unsigned long flags;
1451 	int ret;
1452 	int idx;
1453 
1454 	mutex_lock(&vc4_hdmi->mutex);
1455 
1456 	if (!drm_dev_enter(drm, &idx))
1457 		goto out;
1458 
1459 	/*
1460 	 * As stated in RPi's vc4 firmware "HDMI state machine (HSM) clock must
1461 	 * be faster than pixel clock, infinitesimally faster, tested in
1462 	 * simulation. Otherwise, exact value is unimportant for HDMI
1463 	 * operation." This conflicts with bcm2835's vc4 documentation, which
1464 	 * states HSM's clock has to be at least 108% of the pixel clock.
1465 	 *
1466 	 * Real life tests reveal that vc4's firmware statement holds up, and
1467 	 * users are able to use pixel clocks closer to HSM's, namely for
1468 	 * 1920x1200@60Hz. So it was decided to have leave a 1% margin between
1469 	 * both clocks. Which, for RPi0-3 implies a maximum pixel clock of
1470 	 * 162MHz.
1471 	 *
1472 	 * Additionally, the AXI clock needs to be at least 25% of
1473 	 * pixel clock, but HSM ends up being the limiting factor.
1474 	 */
1475 	hsm_rate = max_t(unsigned long, 120000000, (tmds_char_rate / 100) * 101);
1476 	ret = clk_set_min_rate(vc4_hdmi->hsm_clock, hsm_rate);
1477 	if (ret) {
1478 		DRM_ERROR("Failed to set HSM clock rate: %d\n", ret);
1479 		goto err_dev_exit;
1480 	}
1481 
1482 	ret = pm_runtime_resume_and_get(&vc4_hdmi->pdev->dev);
1483 	if (ret < 0) {
1484 		DRM_ERROR("Failed to retain power domain: %d\n", ret);
1485 		goto err_dev_exit;
1486 	}
1487 
1488 	ret = clk_set_rate(vc4_hdmi->pixel_clock, tmds_char_rate);
1489 	if (ret) {
1490 		DRM_ERROR("Failed to set pixel clock rate: %d\n", ret);
1491 		goto err_put_runtime_pm;
1492 	}
1493 
1494 	ret = clk_prepare_enable(vc4_hdmi->pixel_clock);
1495 	if (ret) {
1496 		DRM_ERROR("Failed to turn on pixel clock: %d\n", ret);
1497 		goto err_put_runtime_pm;
1498 	}
1499 
1500 
1501 	vc4_hdmi_cec_update_clk_div(vc4_hdmi);
1502 
1503 	if (tmds_char_rate > 297000000)
1504 		bvb_rate = 300000000;
1505 	else if (tmds_char_rate > 148500000)
1506 		bvb_rate = 150000000;
1507 	else
1508 		bvb_rate = 75000000;
1509 
1510 	ret = clk_set_min_rate(vc4_hdmi->pixel_bvb_clock, bvb_rate);
1511 	if (ret) {
1512 		DRM_ERROR("Failed to set pixel bvb clock rate: %d\n", ret);
1513 		goto err_disable_pixel_clock;
1514 	}
1515 
1516 	ret = clk_prepare_enable(vc4_hdmi->pixel_bvb_clock);
1517 	if (ret) {
1518 		DRM_ERROR("Failed to turn on pixel bvb clock: %d\n", ret);
1519 		goto err_disable_pixel_clock;
1520 	}
1521 
1522 	if (vc4_hdmi->variant->phy_init)
1523 		vc4_hdmi->variant->phy_init(vc4_hdmi, vc4_conn_state);
1524 
1525 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
1526 
1527 	HDMI_WRITE(HDMI_SCHEDULER_CONTROL,
1528 		   HDMI_READ(HDMI_SCHEDULER_CONTROL) |
1529 		   VC4_HDMI_SCHEDULER_CONTROL_MANUAL_FORMAT |
1530 		   VC4_HDMI_SCHEDULER_CONTROL_IGNORE_VSYNC_PREDICTS);
1531 
1532 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
1533 
1534 	if (vc4_hdmi->variant->set_timings)
1535 		vc4_hdmi->variant->set_timings(vc4_hdmi, conn_state, mode);
1536 
1537 	drm_dev_exit(idx);
1538 
1539 	mutex_unlock(&vc4_hdmi->mutex);
1540 
1541 	return;
1542 
1543 err_disable_pixel_clock:
1544 	clk_disable_unprepare(vc4_hdmi->pixel_clock);
1545 err_put_runtime_pm:
1546 	pm_runtime_put(&vc4_hdmi->pdev->dev);
1547 err_dev_exit:
1548 	drm_dev_exit(idx);
1549 out:
1550 	mutex_unlock(&vc4_hdmi->mutex);
1551 	return;
1552 }
1553 
1554 static void vc4_hdmi_encoder_pre_crtc_enable(struct drm_encoder *encoder,
1555 					     struct drm_atomic_state *state)
1556 {
1557 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
1558 	struct drm_device *drm = vc4_hdmi->connector.dev;
1559 	struct drm_connector *connector = &vc4_hdmi->connector;
1560 	const struct drm_display_mode *mode = &vc4_hdmi->saved_adjusted_mode;
1561 	struct drm_connector_state *conn_state =
1562 		drm_atomic_get_new_connector_state(state, connector);
1563 	unsigned long flags;
1564 	int idx;
1565 
1566 	mutex_lock(&vc4_hdmi->mutex);
1567 
1568 	if (!drm_dev_enter(drm, &idx))
1569 		goto out;
1570 
1571 	if (vc4_hdmi->variant->csc_setup)
1572 		vc4_hdmi->variant->csc_setup(vc4_hdmi, conn_state, mode);
1573 
1574 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
1575 	HDMI_WRITE(HDMI_FIFO_CTL, VC4_HDMI_FIFO_CTL_MASTER_SLAVE_N);
1576 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
1577 
1578 	drm_dev_exit(idx);
1579 
1580 out:
1581 	mutex_unlock(&vc4_hdmi->mutex);
1582 }
1583 
1584 static void vc4_hdmi_encoder_post_crtc_enable(struct drm_encoder *encoder,
1585 					      struct drm_atomic_state *state)
1586 {
1587 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
1588 	struct drm_device *drm = vc4_hdmi->connector.dev;
1589 	const struct drm_display_mode *mode = &vc4_hdmi->saved_adjusted_mode;
1590 	struct drm_display_info *display = &vc4_hdmi->connector.display_info;
1591 	bool hsync_pos = mode->flags & DRM_MODE_FLAG_PHSYNC;
1592 	bool vsync_pos = mode->flags & DRM_MODE_FLAG_PVSYNC;
1593 	unsigned long flags;
1594 	int ret;
1595 	int idx;
1596 
1597 	mutex_lock(&vc4_hdmi->mutex);
1598 
1599 	if (!drm_dev_enter(drm, &idx))
1600 		goto out;
1601 
1602 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
1603 
1604 	HDMI_WRITE(HDMI_VID_CTL,
1605 		   VC4_HD_VID_CTL_ENABLE |
1606 		   VC4_HD_VID_CTL_CLRRGB |
1607 		   VC4_HD_VID_CTL_UNDERFLOW_ENABLE |
1608 		   VC4_HD_VID_CTL_FRAME_COUNTER_RESET |
1609 		   (vsync_pos ? 0 : VC4_HD_VID_CTL_VSYNC_LOW) |
1610 		   (hsync_pos ? 0 : VC4_HD_VID_CTL_HSYNC_LOW));
1611 
1612 	HDMI_WRITE(HDMI_VID_CTL,
1613 		   HDMI_READ(HDMI_VID_CTL) & ~VC4_HD_VID_CTL_BLANKPIX);
1614 
1615 	if (display->is_hdmi) {
1616 		HDMI_WRITE(HDMI_SCHEDULER_CONTROL,
1617 			   HDMI_READ(HDMI_SCHEDULER_CONTROL) |
1618 			   VC4_HDMI_SCHEDULER_CONTROL_MODE_HDMI);
1619 
1620 		spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
1621 
1622 		ret = wait_for(HDMI_READ(HDMI_SCHEDULER_CONTROL) &
1623 			       VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE, 1000);
1624 		WARN_ONCE(ret, "Timeout waiting for "
1625 			  "VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE\n");
1626 	} else {
1627 		HDMI_WRITE(HDMI_RAM_PACKET_CONFIG,
1628 			   HDMI_READ(HDMI_RAM_PACKET_CONFIG) &
1629 			   ~(VC4_HDMI_RAM_PACKET_ENABLE));
1630 		HDMI_WRITE(HDMI_SCHEDULER_CONTROL,
1631 			   HDMI_READ(HDMI_SCHEDULER_CONTROL) &
1632 			   ~VC4_HDMI_SCHEDULER_CONTROL_MODE_HDMI);
1633 
1634 		spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
1635 
1636 		ret = wait_for(!(HDMI_READ(HDMI_SCHEDULER_CONTROL) &
1637 				 VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE), 1000);
1638 		WARN_ONCE(ret, "Timeout waiting for "
1639 			  "!VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE\n");
1640 	}
1641 
1642 	if (display->is_hdmi) {
1643 		spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
1644 
1645 		WARN_ON(!(HDMI_READ(HDMI_SCHEDULER_CONTROL) &
1646 			  VC4_HDMI_SCHEDULER_CONTROL_HDMI_ACTIVE));
1647 
1648 		HDMI_WRITE(HDMI_RAM_PACKET_CONFIG,
1649 			   VC4_HDMI_RAM_PACKET_ENABLE);
1650 
1651 		spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
1652 		vc4_hdmi->packet_ram_enabled = true;
1653 
1654 		vc4_hdmi_set_infoframes(encoder);
1655 	}
1656 
1657 	vc4_hdmi_recenter_fifo(vc4_hdmi);
1658 	vc4_hdmi_enable_scrambling(encoder);
1659 
1660 	drm_dev_exit(idx);
1661 
1662 out:
1663 	mutex_unlock(&vc4_hdmi->mutex);
1664 }
1665 
1666 static void vc4_hdmi_encoder_atomic_mode_set(struct drm_encoder *encoder,
1667 					     struct drm_crtc_state *crtc_state,
1668 					     struct drm_connector_state *conn_state)
1669 {
1670 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
1671 	struct vc4_hdmi_connector_state *vc4_state =
1672 		conn_state_to_vc4_hdmi_conn_state(conn_state);
1673 
1674 	mutex_lock(&vc4_hdmi->mutex);
1675 	drm_mode_copy(&vc4_hdmi->saved_adjusted_mode,
1676 		      &crtc_state->adjusted_mode);
1677 	vc4_hdmi->output_bpc = vc4_state->output_bpc;
1678 	vc4_hdmi->output_format = vc4_state->output_format;
1679 	mutex_unlock(&vc4_hdmi->mutex);
1680 }
1681 
1682 static bool
1683 vc4_hdmi_sink_supports_format_bpc(const struct vc4_hdmi *vc4_hdmi,
1684 				  const struct drm_display_info *info,
1685 				  const struct drm_display_mode *mode,
1686 				  unsigned int format, unsigned int bpc)
1687 {
1688 	struct drm_device *dev = vc4_hdmi->connector.dev;
1689 	u8 vic = drm_match_cea_mode(mode);
1690 
1691 	if (vic == 1 && bpc != 8) {
1692 		drm_dbg(dev, "VIC1 requires a bpc of 8, got %u\n", bpc);
1693 		return false;
1694 	}
1695 
1696 	if (!info->is_hdmi &&
1697 	    (format != VC4_HDMI_OUTPUT_RGB || bpc != 8)) {
1698 		drm_dbg(dev, "DVI Monitors require an RGB output at 8 bpc\n");
1699 		return false;
1700 	}
1701 
1702 	switch (format) {
1703 	case VC4_HDMI_OUTPUT_RGB:
1704 		drm_dbg(dev, "RGB Format, checking the constraints.\n");
1705 
1706 		if (!(info->color_formats & DRM_COLOR_FORMAT_RGB444))
1707 			return false;
1708 
1709 		if (bpc == 10 && !(info->edid_hdmi_rgb444_dc_modes & DRM_EDID_HDMI_DC_30)) {
1710 			drm_dbg(dev, "10 BPC but sink doesn't support Deep Color 30.\n");
1711 			return false;
1712 		}
1713 
1714 		if (bpc == 12 && !(info->edid_hdmi_rgb444_dc_modes & DRM_EDID_HDMI_DC_36)) {
1715 			drm_dbg(dev, "12 BPC but sink doesn't support Deep Color 36.\n");
1716 			return false;
1717 		}
1718 
1719 		drm_dbg(dev, "RGB format supported in that configuration.\n");
1720 
1721 		return true;
1722 
1723 	case VC4_HDMI_OUTPUT_YUV422:
1724 		drm_dbg(dev, "YUV422 format, checking the constraints.\n");
1725 
1726 		if (!(info->color_formats & DRM_COLOR_FORMAT_YCBCR422)) {
1727 			drm_dbg(dev, "Sink doesn't support YUV422.\n");
1728 			return false;
1729 		}
1730 
1731 		if (bpc != 12) {
1732 			drm_dbg(dev, "YUV422 only supports 12 bpc.\n");
1733 			return false;
1734 		}
1735 
1736 		drm_dbg(dev, "YUV422 format supported in that configuration.\n");
1737 
1738 		return true;
1739 
1740 	case VC4_HDMI_OUTPUT_YUV444:
1741 		drm_dbg(dev, "YUV444 format, checking the constraints.\n");
1742 
1743 		if (!(info->color_formats & DRM_COLOR_FORMAT_YCBCR444)) {
1744 			drm_dbg(dev, "Sink doesn't support YUV444.\n");
1745 			return false;
1746 		}
1747 
1748 		if (bpc == 10 && !(info->edid_hdmi_ycbcr444_dc_modes & DRM_EDID_HDMI_DC_30)) {
1749 			drm_dbg(dev, "10 BPC but sink doesn't support Deep Color 30.\n");
1750 			return false;
1751 		}
1752 
1753 		if (bpc == 12 && !(info->edid_hdmi_ycbcr444_dc_modes & DRM_EDID_HDMI_DC_36)) {
1754 			drm_dbg(dev, "12 BPC but sink doesn't support Deep Color 36.\n");
1755 			return false;
1756 		}
1757 
1758 		drm_dbg(dev, "YUV444 format supported in that configuration.\n");
1759 
1760 		return true;
1761 	}
1762 
1763 	return false;
1764 }
1765 
1766 static enum drm_mode_status
1767 vc4_hdmi_encoder_clock_valid(const struct vc4_hdmi *vc4_hdmi,
1768 			     const struct drm_display_mode *mode,
1769 			     unsigned long long clock)
1770 {
1771 	const struct drm_connector *connector = &vc4_hdmi->connector;
1772 	const struct drm_display_info *info = &connector->display_info;
1773 	struct vc4_dev *vc4 = to_vc4_dev(connector->dev);
1774 
1775 	if (clock > vc4_hdmi->variant->max_pixel_clock)
1776 		return MODE_CLOCK_HIGH;
1777 
1778 	if (!vc4->hvs->vc5_hdmi_enable_hdmi_20 && clock > HDMI_14_MAX_TMDS_CLK)
1779 		return MODE_CLOCK_HIGH;
1780 
1781 	/* 4096x2160@60 is not reliable without overclocking core */
1782 	if (!vc4->hvs->vc5_hdmi_enable_4096by2160 &&
1783 	    mode->hdisplay > 3840 && mode->vdisplay >= 2160 &&
1784 	    drm_mode_vrefresh(mode) >= 50)
1785 		return MODE_CLOCK_HIGH;
1786 
1787 	if (info->max_tmds_clock && clock > (info->max_tmds_clock * 1000))
1788 		return MODE_CLOCK_HIGH;
1789 
1790 	return MODE_OK;
1791 }
1792 
1793 static unsigned long long
1794 vc4_hdmi_encoder_compute_mode_clock(const struct drm_display_mode *mode,
1795 				    unsigned int bpc,
1796 				    enum vc4_hdmi_output_format fmt)
1797 {
1798 	unsigned long long clock = mode->clock * 1000ULL;
1799 
1800 	if (mode->flags & DRM_MODE_FLAG_DBLCLK)
1801 		clock = clock * 2;
1802 
1803 	if (fmt == VC4_HDMI_OUTPUT_YUV422)
1804 		bpc = 8;
1805 
1806 	clock = clock * bpc;
1807 	do_div(clock, 8);
1808 
1809 	return clock;
1810 }
1811 
1812 static int
1813 vc4_hdmi_encoder_compute_clock(const struct vc4_hdmi *vc4_hdmi,
1814 			       struct vc4_hdmi_connector_state *vc4_state,
1815 			       const struct drm_display_mode *mode,
1816 			       unsigned int bpc, unsigned int fmt)
1817 {
1818 	unsigned long long clock;
1819 
1820 	clock = vc4_hdmi_encoder_compute_mode_clock(mode, bpc, fmt);
1821 	if (vc4_hdmi_encoder_clock_valid(vc4_hdmi, mode, clock) != MODE_OK)
1822 		return -EINVAL;
1823 
1824 	vc4_state->tmds_char_rate = clock;
1825 
1826 	return 0;
1827 }
1828 
1829 static int
1830 vc4_hdmi_encoder_compute_format(const struct vc4_hdmi *vc4_hdmi,
1831 				struct vc4_hdmi_connector_state *vc4_state,
1832 				const struct drm_display_mode *mode,
1833 				unsigned int bpc)
1834 {
1835 	struct drm_device *dev = vc4_hdmi->connector.dev;
1836 	const struct drm_connector *connector = &vc4_hdmi->connector;
1837 	const struct drm_display_info *info = &connector->display_info;
1838 	unsigned int format;
1839 
1840 	drm_dbg(dev, "Trying with an RGB output\n");
1841 
1842 	format = VC4_HDMI_OUTPUT_RGB;
1843 	if (vc4_hdmi_sink_supports_format_bpc(vc4_hdmi, info, mode, format, bpc)) {
1844 		int ret;
1845 
1846 		ret = vc4_hdmi_encoder_compute_clock(vc4_hdmi, vc4_state,
1847 						     mode, bpc, format);
1848 		if (!ret) {
1849 			vc4_state->output_format = format;
1850 			return 0;
1851 		}
1852 	}
1853 
1854 	drm_dbg(dev, "Failed, Trying with an YUV422 output\n");
1855 
1856 	format = VC4_HDMI_OUTPUT_YUV422;
1857 	if (vc4_hdmi_sink_supports_format_bpc(vc4_hdmi, info, mode, format, bpc)) {
1858 		int ret;
1859 
1860 		ret = vc4_hdmi_encoder_compute_clock(vc4_hdmi, vc4_state,
1861 						     mode, bpc, format);
1862 		if (!ret) {
1863 			vc4_state->output_format = format;
1864 			return 0;
1865 		}
1866 	}
1867 
1868 	drm_dbg(dev, "Failed. No Format Supported for that bpc count.\n");
1869 
1870 	return -EINVAL;
1871 }
1872 
1873 static int
1874 vc4_hdmi_encoder_compute_config(const struct vc4_hdmi *vc4_hdmi,
1875 				struct vc4_hdmi_connector_state *vc4_state,
1876 				const struct drm_display_mode *mode)
1877 {
1878 	struct drm_device *dev = vc4_hdmi->connector.dev;
1879 	struct drm_connector_state *conn_state = &vc4_state->base;
1880 	unsigned int max_bpc = clamp_t(unsigned int, conn_state->max_bpc, 8, 12);
1881 	unsigned int bpc;
1882 	int ret;
1883 
1884 	for (bpc = max_bpc; bpc >= 8; bpc -= 2) {
1885 		drm_dbg(dev, "Trying with a %d bpc output\n", bpc);
1886 
1887 		ret = vc4_hdmi_encoder_compute_format(vc4_hdmi, vc4_state,
1888 						      mode, bpc);
1889 		if (ret)
1890 			continue;
1891 
1892 		vc4_state->output_bpc = bpc;
1893 
1894 		drm_dbg(dev,
1895 			"Mode %ux%u @ %uHz: Found configuration: bpc: %u, fmt: %s, clock: %llu\n",
1896 			mode->hdisplay, mode->vdisplay, drm_mode_vrefresh(mode),
1897 			vc4_state->output_bpc,
1898 			vc4_hdmi_output_fmt_str(vc4_state->output_format),
1899 			vc4_state->tmds_char_rate);
1900 
1901 		break;
1902 	}
1903 
1904 	return ret;
1905 }
1906 
1907 #define WIFI_2_4GHz_CH1_MIN_FREQ	2400000000ULL
1908 #define WIFI_2_4GHz_CH1_MAX_FREQ	2422000000ULL
1909 
1910 static int vc4_hdmi_encoder_atomic_check(struct drm_encoder *encoder,
1911 					 struct drm_crtc_state *crtc_state,
1912 					 struct drm_connector_state *conn_state)
1913 {
1914 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
1915 	struct drm_connector *connector = &vc4_hdmi->connector;
1916 	struct drm_connector_state *old_conn_state =
1917 		drm_atomic_get_old_connector_state(conn_state->state, connector);
1918 	struct vc4_hdmi_connector_state *old_vc4_state =
1919 		conn_state_to_vc4_hdmi_conn_state(old_conn_state);
1920 	struct vc4_hdmi_connector_state *vc4_state = conn_state_to_vc4_hdmi_conn_state(conn_state);
1921 	struct drm_display_mode *mode = &crtc_state->adjusted_mode;
1922 	unsigned long long tmds_char_rate = mode->clock * 1000;
1923 	unsigned long long tmds_bit_rate;
1924 	int ret;
1925 
1926 	if (vc4_hdmi->variant->unsupported_odd_h_timings) {
1927 		if (mode->flags & DRM_MODE_FLAG_DBLCLK) {
1928 			/* Only try to fixup DBLCLK modes to get 480i and 576i
1929 			 * working.
1930 			 * A generic solution for all modes with odd horizontal
1931 			 * timing values seems impossible based on trying to
1932 			 * solve it for 1366x768 monitors.
1933 			 */
1934 			if ((mode->hsync_start - mode->hdisplay) & 1)
1935 				mode->hsync_start--;
1936 			if ((mode->hsync_end - mode->hsync_start) & 1)
1937 				mode->hsync_end--;
1938 		}
1939 
1940 		/* Now check whether we still have odd values remaining */
1941 		if ((mode->hdisplay % 2) || (mode->hsync_start % 2) ||
1942 		    (mode->hsync_end % 2) || (mode->htotal % 2))
1943 			return -EINVAL;
1944 	}
1945 
1946 	/*
1947 	 * The 1440p@60 pixel rate is in the same range than the first
1948 	 * WiFi channel (between 2.4GHz and 2.422GHz with 22MHz
1949 	 * bandwidth). Slightly lower the frequency to bring it out of
1950 	 * the WiFi range.
1951 	 */
1952 	tmds_bit_rate = tmds_char_rate * 10;
1953 	if (vc4_hdmi->disable_wifi_frequencies &&
1954 	    (tmds_bit_rate >= WIFI_2_4GHz_CH1_MIN_FREQ &&
1955 	     tmds_bit_rate <= WIFI_2_4GHz_CH1_MAX_FREQ)) {
1956 		mode->clock = 238560;
1957 		tmds_char_rate = mode->clock * 1000;
1958 	}
1959 
1960 	ret = vc4_hdmi_encoder_compute_config(vc4_hdmi, vc4_state, mode);
1961 	if (ret)
1962 		return ret;
1963 
1964 	/* vc4_hdmi_encoder_compute_config may have changed output_bpc and/or output_format */
1965 	if (vc4_state->output_bpc != old_vc4_state->output_bpc ||
1966 	    vc4_state->output_format != old_vc4_state->output_format)
1967 		crtc_state->mode_changed = true;
1968 
1969 	return 0;
1970 }
1971 
1972 static enum drm_mode_status
1973 vc4_hdmi_encoder_mode_valid(struct drm_encoder *encoder,
1974 			    const struct drm_display_mode *mode)
1975 {
1976 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
1977 
1978 	if (vc4_hdmi->variant->unsupported_odd_h_timings &&
1979 	    !(mode->flags & DRM_MODE_FLAG_DBLCLK) &&
1980 	    ((mode->hdisplay % 2) || (mode->hsync_start % 2) ||
1981 	     (mode->hsync_end % 2) || (mode->htotal % 2)))
1982 		return MODE_H_ILLEGAL;
1983 
1984 	return vc4_hdmi_encoder_clock_valid(vc4_hdmi, mode, mode->clock * 1000);
1985 }
1986 
1987 static const struct drm_encoder_helper_funcs vc4_hdmi_encoder_helper_funcs = {
1988 	.atomic_check = vc4_hdmi_encoder_atomic_check,
1989 	.atomic_mode_set = vc4_hdmi_encoder_atomic_mode_set,
1990 	.mode_valid = vc4_hdmi_encoder_mode_valid,
1991 };
1992 
1993 static int vc4_hdmi_late_register(struct drm_encoder *encoder)
1994 {
1995 	struct drm_device *drm = encoder->dev;
1996 	struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
1997 	const struct vc4_hdmi_variant *variant = vc4_hdmi->variant;
1998 	int ret;
1999 
2000 	ret = vc4_debugfs_add_file(drm->primary, variant->debugfs_name,
2001 				   vc4_hdmi_debugfs_regs,
2002 				   vc4_hdmi);
2003 	if (ret)
2004 		return ret;
2005 
2006 	return 0;
2007 }
2008 
2009 static const struct drm_encoder_funcs vc4_hdmi_encoder_funcs = {
2010 	.late_register = vc4_hdmi_late_register,
2011 };
2012 
2013 static u32 vc4_hdmi_channel_map(struct vc4_hdmi *vc4_hdmi, u32 channel_mask)
2014 {
2015 	int i;
2016 	u32 channel_map = 0;
2017 
2018 	for (i = 0; i < 8; i++) {
2019 		if (channel_mask & BIT(i))
2020 			channel_map |= i << (3 * i);
2021 	}
2022 	return channel_map;
2023 }
2024 
2025 static u32 vc5_hdmi_channel_map(struct vc4_hdmi *vc4_hdmi, u32 channel_mask)
2026 {
2027 	int i;
2028 	u32 channel_map = 0;
2029 
2030 	for (i = 0; i < 8; i++) {
2031 		if (channel_mask & BIT(i))
2032 			channel_map |= i << (4 * i);
2033 	}
2034 	return channel_map;
2035 }
2036 
2037 static bool vc5_hdmi_hp_detect(struct vc4_hdmi *vc4_hdmi)
2038 {
2039 	struct drm_device *drm = vc4_hdmi->connector.dev;
2040 	unsigned long flags;
2041 	u32 hotplug;
2042 	int idx;
2043 
2044 	if (!drm_dev_enter(drm, &idx))
2045 		return false;
2046 
2047 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
2048 	hotplug = HDMI_READ(HDMI_HOTPLUG);
2049 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
2050 
2051 	drm_dev_exit(idx);
2052 
2053 	return !!(hotplug & VC4_HDMI_HOTPLUG_CONNECTED);
2054 }
2055 
2056 /* HDMI audio codec callbacks */
2057 static void vc4_hdmi_audio_set_mai_clock(struct vc4_hdmi *vc4_hdmi,
2058 					 unsigned int samplerate)
2059 {
2060 	struct drm_device *drm = vc4_hdmi->connector.dev;
2061 	u32 hsm_clock;
2062 	unsigned long flags;
2063 	unsigned long n, m;
2064 	int idx;
2065 
2066 	if (!drm_dev_enter(drm, &idx))
2067 		return;
2068 
2069 	hsm_clock = clk_get_rate(vc4_hdmi->audio_clock);
2070 	rational_best_approximation(hsm_clock, samplerate,
2071 				    VC4_HD_MAI_SMP_N_MASK >>
2072 				    VC4_HD_MAI_SMP_N_SHIFT,
2073 				    (VC4_HD_MAI_SMP_M_MASK >>
2074 				     VC4_HD_MAI_SMP_M_SHIFT) + 1,
2075 				    &n, &m);
2076 
2077 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
2078 	HDMI_WRITE(HDMI_MAI_SMP,
2079 		   VC4_SET_FIELD(n, VC4_HD_MAI_SMP_N) |
2080 		   VC4_SET_FIELD(m - 1, VC4_HD_MAI_SMP_M));
2081 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
2082 
2083 	drm_dev_exit(idx);
2084 }
2085 
2086 static void vc4_hdmi_set_n_cts(struct vc4_hdmi *vc4_hdmi, unsigned int samplerate)
2087 {
2088 	const struct drm_display_mode *mode = &vc4_hdmi->saved_adjusted_mode;
2089 	u32 n, cts;
2090 	u64 tmp;
2091 
2092 	lockdep_assert_held(&vc4_hdmi->mutex);
2093 	lockdep_assert_held(&vc4_hdmi->hw_lock);
2094 
2095 	n = 128 * samplerate / 1000;
2096 	tmp = (u64)(mode->clock * 1000) * n;
2097 	do_div(tmp, 128 * samplerate);
2098 	cts = tmp;
2099 
2100 	HDMI_WRITE(HDMI_CRP_CFG,
2101 		   VC4_HDMI_CRP_CFG_EXTERNAL_CTS_EN |
2102 		   VC4_SET_FIELD(n, VC4_HDMI_CRP_CFG_N));
2103 
2104 	/*
2105 	 * We could get slightly more accurate clocks in some cases by
2106 	 * providing a CTS_1 value.  The two CTS values are alternated
2107 	 * between based on the period fields
2108 	 */
2109 	HDMI_WRITE(HDMI_CTS_0, cts);
2110 	HDMI_WRITE(HDMI_CTS_1, cts);
2111 }
2112 
2113 static inline struct vc4_hdmi *dai_to_hdmi(struct snd_soc_dai *dai)
2114 {
2115 	struct snd_soc_card *card = snd_soc_dai_get_drvdata(dai);
2116 
2117 	return snd_soc_card_get_drvdata(card);
2118 }
2119 
2120 static bool vc4_hdmi_audio_can_stream(struct vc4_hdmi *vc4_hdmi)
2121 {
2122 	struct drm_display_info *display = &vc4_hdmi->connector.display_info;
2123 
2124 	lockdep_assert_held(&vc4_hdmi->mutex);
2125 
2126 	/*
2127 	 * If the encoder is currently in DVI mode, treat the codec DAI
2128 	 * as missing.
2129 	 */
2130 	if (!display->is_hdmi)
2131 		return false;
2132 
2133 	return true;
2134 }
2135 
2136 static int vc4_hdmi_audio_startup(struct device *dev, void *data)
2137 {
2138 	struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);
2139 	struct drm_device *drm = vc4_hdmi->connector.dev;
2140 	unsigned long flags;
2141 	int ret = 0;
2142 	int idx;
2143 
2144 	mutex_lock(&vc4_hdmi->mutex);
2145 
2146 	if (!drm_dev_enter(drm, &idx)) {
2147 		ret = -ENODEV;
2148 		goto out;
2149 	}
2150 
2151 	if (!vc4_hdmi_audio_can_stream(vc4_hdmi)) {
2152 		ret = -ENODEV;
2153 		goto out_dev_exit;
2154 	}
2155 
2156 	vc4_hdmi->audio.streaming = true;
2157 
2158 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
2159 	HDMI_WRITE(HDMI_MAI_CTL,
2160 		   VC4_HD_MAI_CTL_RESET |
2161 		   VC4_HD_MAI_CTL_FLUSH |
2162 		   VC4_HD_MAI_CTL_DLATE |
2163 		   VC4_HD_MAI_CTL_ERRORE |
2164 		   VC4_HD_MAI_CTL_ERRORF);
2165 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
2166 
2167 	if (vc4_hdmi->variant->phy_rng_enable)
2168 		vc4_hdmi->variant->phy_rng_enable(vc4_hdmi);
2169 
2170 out_dev_exit:
2171 	drm_dev_exit(idx);
2172 out:
2173 	mutex_unlock(&vc4_hdmi->mutex);
2174 
2175 	return ret;
2176 }
2177 
2178 static void vc4_hdmi_audio_reset(struct vc4_hdmi *vc4_hdmi)
2179 {
2180 	struct drm_encoder *encoder = &vc4_hdmi->encoder.base;
2181 	struct device *dev = &vc4_hdmi->pdev->dev;
2182 	unsigned long flags;
2183 	int ret;
2184 
2185 	lockdep_assert_held(&vc4_hdmi->mutex);
2186 
2187 	vc4_hdmi->audio.streaming = false;
2188 	ret = vc4_hdmi_stop_packet(encoder, HDMI_INFOFRAME_TYPE_AUDIO, false);
2189 	if (ret)
2190 		dev_err(dev, "Failed to stop audio infoframe: %d\n", ret);
2191 
2192 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
2193 
2194 	HDMI_WRITE(HDMI_MAI_CTL, VC4_HD_MAI_CTL_RESET);
2195 	HDMI_WRITE(HDMI_MAI_CTL, VC4_HD_MAI_CTL_ERRORF);
2196 	HDMI_WRITE(HDMI_MAI_CTL, VC4_HD_MAI_CTL_FLUSH);
2197 
2198 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
2199 }
2200 
2201 static void vc4_hdmi_audio_shutdown(struct device *dev, void *data)
2202 {
2203 	struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);
2204 	struct drm_device *drm = vc4_hdmi->connector.dev;
2205 	unsigned long flags;
2206 	int idx;
2207 
2208 	mutex_lock(&vc4_hdmi->mutex);
2209 
2210 	if (!drm_dev_enter(drm, &idx))
2211 		goto out;
2212 
2213 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
2214 
2215 	HDMI_WRITE(HDMI_MAI_CTL,
2216 		   VC4_HD_MAI_CTL_DLATE |
2217 		   VC4_HD_MAI_CTL_ERRORE |
2218 		   VC4_HD_MAI_CTL_ERRORF);
2219 
2220 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
2221 
2222 	if (vc4_hdmi->variant->phy_rng_disable)
2223 		vc4_hdmi->variant->phy_rng_disable(vc4_hdmi);
2224 
2225 	vc4_hdmi->audio.streaming = false;
2226 	vc4_hdmi_audio_reset(vc4_hdmi);
2227 
2228 	drm_dev_exit(idx);
2229 
2230 out:
2231 	mutex_unlock(&vc4_hdmi->mutex);
2232 }
2233 
2234 static int sample_rate_to_mai_fmt(int samplerate)
2235 {
2236 	switch (samplerate) {
2237 	case 8000:
2238 		return VC4_HDMI_MAI_SAMPLE_RATE_8000;
2239 	case 11025:
2240 		return VC4_HDMI_MAI_SAMPLE_RATE_11025;
2241 	case 12000:
2242 		return VC4_HDMI_MAI_SAMPLE_RATE_12000;
2243 	case 16000:
2244 		return VC4_HDMI_MAI_SAMPLE_RATE_16000;
2245 	case 22050:
2246 		return VC4_HDMI_MAI_SAMPLE_RATE_22050;
2247 	case 24000:
2248 		return VC4_HDMI_MAI_SAMPLE_RATE_24000;
2249 	case 32000:
2250 		return VC4_HDMI_MAI_SAMPLE_RATE_32000;
2251 	case 44100:
2252 		return VC4_HDMI_MAI_SAMPLE_RATE_44100;
2253 	case 48000:
2254 		return VC4_HDMI_MAI_SAMPLE_RATE_48000;
2255 	case 64000:
2256 		return VC4_HDMI_MAI_SAMPLE_RATE_64000;
2257 	case 88200:
2258 		return VC4_HDMI_MAI_SAMPLE_RATE_88200;
2259 	case 96000:
2260 		return VC4_HDMI_MAI_SAMPLE_RATE_96000;
2261 	case 128000:
2262 		return VC4_HDMI_MAI_SAMPLE_RATE_128000;
2263 	case 176400:
2264 		return VC4_HDMI_MAI_SAMPLE_RATE_176400;
2265 	case 192000:
2266 		return VC4_HDMI_MAI_SAMPLE_RATE_192000;
2267 	default:
2268 		return VC4_HDMI_MAI_SAMPLE_RATE_NOT_INDICATED;
2269 	}
2270 }
2271 
2272 /* HDMI audio codec callbacks */
2273 static int vc4_hdmi_audio_prepare(struct device *dev, void *data,
2274 				  struct hdmi_codec_daifmt *daifmt,
2275 				  struct hdmi_codec_params *params)
2276 {
2277 	struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);
2278 	struct drm_device *drm = vc4_hdmi->connector.dev;
2279 	struct drm_encoder *encoder = &vc4_hdmi->encoder.base;
2280 	unsigned int sample_rate = params->sample_rate;
2281 	unsigned int channels = params->channels;
2282 	unsigned long flags;
2283 	u32 audio_packet_config, channel_mask;
2284 	u32 channel_map;
2285 	u32 mai_audio_format;
2286 	u32 mai_sample_rate;
2287 	int ret = 0;
2288 	int idx;
2289 
2290 	dev_dbg(dev, "%s: %u Hz, %d bit, %d channels\n", __func__,
2291 		sample_rate, params->sample_width, channels);
2292 
2293 	mutex_lock(&vc4_hdmi->mutex);
2294 
2295 	if (!drm_dev_enter(drm, &idx)) {
2296 		ret = -ENODEV;
2297 		goto out;
2298 	}
2299 
2300 	if (!vc4_hdmi_audio_can_stream(vc4_hdmi)) {
2301 		ret = -EINVAL;
2302 		goto out_dev_exit;
2303 	}
2304 
2305 	vc4_hdmi_audio_set_mai_clock(vc4_hdmi, sample_rate);
2306 
2307 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
2308 	HDMI_WRITE(HDMI_MAI_CTL,
2309 		   VC4_SET_FIELD(channels, VC4_HD_MAI_CTL_CHNUM) |
2310 		   VC4_HD_MAI_CTL_WHOLSMP |
2311 		   VC4_HD_MAI_CTL_CHALIGN |
2312 		   VC4_HD_MAI_CTL_ENABLE);
2313 
2314 	mai_sample_rate = sample_rate_to_mai_fmt(sample_rate);
2315 	if (params->iec.status[0] & IEC958_AES0_NONAUDIO &&
2316 	    params->channels == 8)
2317 		mai_audio_format = VC4_HDMI_MAI_FORMAT_HBR;
2318 	else
2319 		mai_audio_format = VC4_HDMI_MAI_FORMAT_PCM;
2320 	HDMI_WRITE(HDMI_MAI_FMT,
2321 		   VC4_SET_FIELD(mai_sample_rate,
2322 				 VC4_HDMI_MAI_FORMAT_SAMPLE_RATE) |
2323 		   VC4_SET_FIELD(mai_audio_format,
2324 				 VC4_HDMI_MAI_FORMAT_AUDIO_FORMAT));
2325 
2326 	/* The B frame identifier should match the value used by alsa-lib (8) */
2327 	audio_packet_config =
2328 		VC4_HDMI_AUDIO_PACKET_ZERO_DATA_ON_SAMPLE_FLAT |
2329 		VC4_HDMI_AUDIO_PACKET_ZERO_DATA_ON_INACTIVE_CHANNELS |
2330 		VC4_SET_FIELD(0x8, VC4_HDMI_AUDIO_PACKET_B_FRAME_IDENTIFIER);
2331 
2332 	channel_mask = GENMASK(channels - 1, 0);
2333 	audio_packet_config |= VC4_SET_FIELD(channel_mask,
2334 					     VC4_HDMI_AUDIO_PACKET_CEA_MASK);
2335 
2336 	/* Set the MAI threshold */
2337 	HDMI_WRITE(HDMI_MAI_THR,
2338 		   VC4_SET_FIELD(0x08, VC4_HD_MAI_THR_PANICHIGH) |
2339 		   VC4_SET_FIELD(0x08, VC4_HD_MAI_THR_PANICLOW) |
2340 		   VC4_SET_FIELD(0x06, VC4_HD_MAI_THR_DREQHIGH) |
2341 		   VC4_SET_FIELD(0x08, VC4_HD_MAI_THR_DREQLOW));
2342 
2343 	HDMI_WRITE(HDMI_MAI_CONFIG,
2344 		   VC4_HDMI_MAI_CONFIG_BIT_REVERSE |
2345 		   VC4_HDMI_MAI_CONFIG_FORMAT_REVERSE |
2346 		   VC4_SET_FIELD(channel_mask, VC4_HDMI_MAI_CHANNEL_MASK));
2347 
2348 	channel_map = vc4_hdmi->variant->channel_map(vc4_hdmi, channel_mask);
2349 	HDMI_WRITE(HDMI_MAI_CHANNEL_MAP, channel_map);
2350 	HDMI_WRITE(HDMI_AUDIO_PACKET_CONFIG, audio_packet_config);
2351 
2352 	vc4_hdmi_set_n_cts(vc4_hdmi, sample_rate);
2353 
2354 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
2355 
2356 	memcpy(&vc4_hdmi->audio.infoframe, &params->cea, sizeof(params->cea));
2357 	vc4_hdmi_set_audio_infoframe(encoder);
2358 
2359 out_dev_exit:
2360 	drm_dev_exit(idx);
2361 out:
2362 	mutex_unlock(&vc4_hdmi->mutex);
2363 
2364 	return ret;
2365 }
2366 
2367 static const struct snd_soc_component_driver vc4_hdmi_audio_cpu_dai_comp = {
2368 	.name = "vc4-hdmi-cpu-dai-component",
2369 	.legacy_dai_naming = 1,
2370 };
2371 
2372 static int vc4_hdmi_audio_cpu_dai_probe(struct snd_soc_dai *dai)
2373 {
2374 	struct vc4_hdmi *vc4_hdmi = dai_to_hdmi(dai);
2375 
2376 	snd_soc_dai_init_dma_data(dai, &vc4_hdmi->audio.dma_data, NULL);
2377 
2378 	return 0;
2379 }
2380 
2381 static struct snd_soc_dai_driver vc4_hdmi_audio_cpu_dai_drv = {
2382 	.name = "vc4-hdmi-cpu-dai",
2383 	.probe  = vc4_hdmi_audio_cpu_dai_probe,
2384 	.playback = {
2385 		.stream_name = "Playback",
2386 		.channels_min = 1,
2387 		.channels_max = 8,
2388 		.rates = SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 |
2389 			 SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 |
2390 			 SNDRV_PCM_RATE_96000 | SNDRV_PCM_RATE_176400 |
2391 			 SNDRV_PCM_RATE_192000,
2392 		.formats = SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE,
2393 	},
2394 };
2395 
2396 static const struct snd_dmaengine_pcm_config pcm_conf = {
2397 	.chan_names[SNDRV_PCM_STREAM_PLAYBACK] = "audio-rx",
2398 	.prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config,
2399 };
2400 
2401 static int vc4_hdmi_audio_get_eld(struct device *dev, void *data,
2402 				  uint8_t *buf, size_t len)
2403 {
2404 	struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);
2405 	struct drm_connector *connector = &vc4_hdmi->connector;
2406 
2407 	mutex_lock(&vc4_hdmi->mutex);
2408 	memcpy(buf, connector->eld, min(sizeof(connector->eld), len));
2409 	mutex_unlock(&vc4_hdmi->mutex);
2410 
2411 	return 0;
2412 }
2413 
2414 static const struct hdmi_codec_ops vc4_hdmi_codec_ops = {
2415 	.get_eld = vc4_hdmi_audio_get_eld,
2416 	.prepare = vc4_hdmi_audio_prepare,
2417 	.audio_shutdown = vc4_hdmi_audio_shutdown,
2418 	.audio_startup = vc4_hdmi_audio_startup,
2419 };
2420 
2421 static struct hdmi_codec_pdata vc4_hdmi_codec_pdata = {
2422 	.ops = &vc4_hdmi_codec_ops,
2423 	.max_i2s_channels = 8,
2424 	.i2s = 1,
2425 };
2426 
2427 static void vc4_hdmi_audio_codec_release(void *ptr)
2428 {
2429 	struct vc4_hdmi *vc4_hdmi = ptr;
2430 
2431 	platform_device_unregister(vc4_hdmi->audio.codec_pdev);
2432 	vc4_hdmi->audio.codec_pdev = NULL;
2433 }
2434 
2435 static int vc4_hdmi_audio_init(struct vc4_hdmi *vc4_hdmi)
2436 {
2437 	const struct vc4_hdmi_register *mai_data =
2438 		&vc4_hdmi->variant->registers[HDMI_MAI_DATA];
2439 	struct snd_soc_dai_link *dai_link = &vc4_hdmi->audio.link;
2440 	struct snd_soc_card *card = &vc4_hdmi->audio.card;
2441 	struct device *dev = &vc4_hdmi->pdev->dev;
2442 	struct platform_device *codec_pdev;
2443 	const __be32 *addr;
2444 	int index, len;
2445 	int ret;
2446 
2447 	/*
2448 	 * ASoC makes it a bit hard to retrieve a pointer to the
2449 	 * vc4_hdmi structure. Registering the card will overwrite our
2450 	 * device drvdata with a pointer to the snd_soc_card structure,
2451 	 * which can then be used to retrieve whatever drvdata we want
2452 	 * to associate.
2453 	 *
2454 	 * However, that doesn't fly in the case where we wouldn't
2455 	 * register an ASoC card (because of an old DT that is missing
2456 	 * the dmas properties for example), then the card isn't
2457 	 * registered and the device drvdata wouldn't be set.
2458 	 *
2459 	 * We can deal with both cases by making sure a snd_soc_card
2460 	 * pointer and a vc4_hdmi structure are pointing to the same
2461 	 * memory address, so we can treat them indistinctly without any
2462 	 * issue.
2463 	 */
2464 	BUILD_BUG_ON(offsetof(struct vc4_hdmi_audio, card) != 0);
2465 	BUILD_BUG_ON(offsetof(struct vc4_hdmi, audio) != 0);
2466 
2467 	if (!of_find_property(dev->of_node, "dmas", &len) || !len) {
2468 		dev_warn(dev,
2469 			 "'dmas' DT property is missing or empty, no HDMI audio\n");
2470 		return 0;
2471 	}
2472 
2473 	if (mai_data->reg != VC4_HD) {
2474 		WARN_ONCE(true, "MAI isn't in the HD block\n");
2475 		return -EINVAL;
2476 	}
2477 
2478 	/*
2479 	 * Get the physical address of VC4_HD_MAI_DATA. We need to retrieve
2480 	 * the bus address specified in the DT, because the physical address
2481 	 * (the one returned by platform_get_resource()) is not appropriate
2482 	 * for DMA transfers.
2483 	 * This VC/MMU should probably be exposed to avoid this kind of hacks.
2484 	 */
2485 	index = of_property_match_string(dev->of_node, "reg-names", "hd");
2486 	/* Before BCM2711, we don't have a named register range */
2487 	if (index < 0)
2488 		index = 1;
2489 
2490 	addr = of_get_address(dev->of_node, index, NULL, NULL);
2491 
2492 	vc4_hdmi->audio.dma_data.addr = be32_to_cpup(addr) + mai_data->offset;
2493 	vc4_hdmi->audio.dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
2494 	vc4_hdmi->audio.dma_data.maxburst = 2;
2495 
2496 	/*
2497 	 * NOTE: Strictly speaking, we should probably use a DRM-managed
2498 	 * registration there to avoid removing all the audio components
2499 	 * by the time the driver doesn't have any user anymore.
2500 	 *
2501 	 * However, the ASoC core uses a number of devm_kzalloc calls
2502 	 * when registering, even when using non-device-managed
2503 	 * functions (such as in snd_soc_register_component()).
2504 	 *
2505 	 * If we call snd_soc_unregister_component() in a DRM-managed
2506 	 * action, the device-managed actions have already been executed
2507 	 * and thus we would access memory that has been freed.
2508 	 *
2509 	 * Using device-managed hooks here probably leaves us open to a
2510 	 * bunch of issues if userspace still has a handle on the ALSA
2511 	 * device when the device is removed. However, this is mitigated
2512 	 * by the use of drm_dev_enter()/drm_dev_exit() in the audio
2513 	 * path to prevent the access to the device resources if it
2514 	 * isn't there anymore.
2515 	 *
2516 	 * Then, the vc4_hdmi structure is DRM-managed and thus only
2517 	 * freed whenever the last user has closed the DRM device file.
2518 	 * It should thus outlive ALSA in most situations.
2519 	 */
2520 	ret = devm_snd_dmaengine_pcm_register(dev, &pcm_conf, 0);
2521 	if (ret) {
2522 		dev_err(dev, "Could not register PCM component: %d\n", ret);
2523 		return ret;
2524 	}
2525 
2526 	ret = devm_snd_soc_register_component(dev, &vc4_hdmi_audio_cpu_dai_comp,
2527 					      &vc4_hdmi_audio_cpu_dai_drv, 1);
2528 	if (ret) {
2529 		dev_err(dev, "Could not register CPU DAI: %d\n", ret);
2530 		return ret;
2531 	}
2532 
2533 	codec_pdev = platform_device_register_data(dev, HDMI_CODEC_DRV_NAME,
2534 						   PLATFORM_DEVID_AUTO,
2535 						   &vc4_hdmi_codec_pdata,
2536 						   sizeof(vc4_hdmi_codec_pdata));
2537 	if (IS_ERR(codec_pdev)) {
2538 		dev_err(dev, "Couldn't register the HDMI codec: %ld\n", PTR_ERR(codec_pdev));
2539 		return PTR_ERR(codec_pdev);
2540 	}
2541 	vc4_hdmi->audio.codec_pdev = codec_pdev;
2542 
2543 	ret = devm_add_action_or_reset(dev, vc4_hdmi_audio_codec_release, vc4_hdmi);
2544 	if (ret)
2545 		return ret;
2546 
2547 	dai_link->cpus		= &vc4_hdmi->audio.cpu;
2548 	dai_link->codecs	= &vc4_hdmi->audio.codec;
2549 	dai_link->platforms	= &vc4_hdmi->audio.platform;
2550 
2551 	dai_link->num_cpus	= 1;
2552 	dai_link->num_codecs	= 1;
2553 	dai_link->num_platforms	= 1;
2554 
2555 	dai_link->name = "MAI";
2556 	dai_link->stream_name = "MAI PCM";
2557 	dai_link->codecs->dai_name = "i2s-hifi";
2558 	dai_link->cpus->dai_name = dev_name(dev);
2559 	dai_link->codecs->name = dev_name(&codec_pdev->dev);
2560 	dai_link->platforms->name = dev_name(dev);
2561 
2562 	card->dai_link = dai_link;
2563 	card->num_links = 1;
2564 	card->name = vc4_hdmi->variant->card_name;
2565 	card->driver_name = "vc4-hdmi";
2566 	card->dev = dev;
2567 	card->owner = THIS_MODULE;
2568 
2569 	/*
2570 	 * Be careful, snd_soc_register_card() calls dev_set_drvdata() and
2571 	 * stores a pointer to the snd card object in dev->driver_data. This
2572 	 * means we cannot use it for something else. The hdmi back-pointer is
2573 	 * now stored in card->drvdata and should be retrieved with
2574 	 * snd_soc_card_get_drvdata() if needed.
2575 	 */
2576 	snd_soc_card_set_drvdata(card, vc4_hdmi);
2577 	ret = devm_snd_soc_register_card(dev, card);
2578 	if (ret)
2579 		dev_err_probe(dev, ret, "Could not register sound card\n");
2580 
2581 	return ret;
2582 
2583 }
2584 
2585 static irqreturn_t vc4_hdmi_hpd_irq_thread(int irq, void *priv)
2586 {
2587 	struct vc4_hdmi *vc4_hdmi = priv;
2588 	struct drm_connector *connector = &vc4_hdmi->connector;
2589 	struct drm_device *dev = connector->dev;
2590 
2591 	if (dev && dev->registered)
2592 		drm_connector_helper_hpd_irq_event(connector);
2593 
2594 	return IRQ_HANDLED;
2595 }
2596 
2597 static int vc4_hdmi_hotplug_init(struct vc4_hdmi *vc4_hdmi)
2598 {
2599 	struct drm_connector *connector = &vc4_hdmi->connector;
2600 	struct platform_device *pdev = vc4_hdmi->pdev;
2601 	int ret;
2602 
2603 	if (vc4_hdmi->variant->external_irq_controller) {
2604 		unsigned int hpd_con = platform_get_irq_byname(pdev, "hpd-connected");
2605 		unsigned int hpd_rm = platform_get_irq_byname(pdev, "hpd-removed");
2606 
2607 		ret = devm_request_threaded_irq(&pdev->dev, hpd_con,
2608 						NULL,
2609 						vc4_hdmi_hpd_irq_thread, IRQF_ONESHOT,
2610 						"vc4 hdmi hpd connected", vc4_hdmi);
2611 		if (ret)
2612 			return ret;
2613 
2614 		ret = devm_request_threaded_irq(&pdev->dev, hpd_rm,
2615 						NULL,
2616 						vc4_hdmi_hpd_irq_thread, IRQF_ONESHOT,
2617 						"vc4 hdmi hpd disconnected", vc4_hdmi);
2618 		if (ret)
2619 			return ret;
2620 
2621 		connector->polled = DRM_CONNECTOR_POLL_HPD;
2622 	}
2623 
2624 	return 0;
2625 }
2626 
2627 #ifdef CONFIG_DRM_VC4_HDMI_CEC
2628 static irqreturn_t vc4_cec_irq_handler_rx_thread(int irq, void *priv)
2629 {
2630 	struct vc4_hdmi *vc4_hdmi = priv;
2631 
2632 	if (vc4_hdmi->cec_rx_msg.len)
2633 		cec_received_msg(vc4_hdmi->cec_adap,
2634 				 &vc4_hdmi->cec_rx_msg);
2635 
2636 	return IRQ_HANDLED;
2637 }
2638 
2639 static irqreturn_t vc4_cec_irq_handler_tx_thread(int irq, void *priv)
2640 {
2641 	struct vc4_hdmi *vc4_hdmi = priv;
2642 
2643 	if (vc4_hdmi->cec_tx_ok) {
2644 		cec_transmit_done(vc4_hdmi->cec_adap, CEC_TX_STATUS_OK,
2645 				  0, 0, 0, 0);
2646 	} else {
2647 		/*
2648 		 * This CEC implementation makes 1 retry, so if we
2649 		 * get a NACK, then that means it made 2 attempts.
2650 		 */
2651 		cec_transmit_done(vc4_hdmi->cec_adap, CEC_TX_STATUS_NACK,
2652 				  0, 2, 0, 0);
2653 	}
2654 	return IRQ_HANDLED;
2655 }
2656 
2657 static irqreturn_t vc4_cec_irq_handler_thread(int irq, void *priv)
2658 {
2659 	struct vc4_hdmi *vc4_hdmi = priv;
2660 	irqreturn_t ret;
2661 
2662 	if (vc4_hdmi->cec_irq_was_rx)
2663 		ret = vc4_cec_irq_handler_rx_thread(irq, priv);
2664 	else
2665 		ret = vc4_cec_irq_handler_tx_thread(irq, priv);
2666 
2667 	return ret;
2668 }
2669 
2670 static void vc4_cec_read_msg(struct vc4_hdmi *vc4_hdmi, u32 cntrl1)
2671 {
2672 	struct drm_device *dev = vc4_hdmi->connector.dev;
2673 	struct cec_msg *msg = &vc4_hdmi->cec_rx_msg;
2674 	unsigned int i;
2675 
2676 	lockdep_assert_held(&vc4_hdmi->hw_lock);
2677 
2678 	msg->len = 1 + ((cntrl1 & VC4_HDMI_CEC_REC_WRD_CNT_MASK) >>
2679 					VC4_HDMI_CEC_REC_WRD_CNT_SHIFT);
2680 
2681 	if (msg->len > 16) {
2682 		drm_err(dev, "Attempting to read too much data (%d)\n", msg->len);
2683 		return;
2684 	}
2685 
2686 	for (i = 0; i < msg->len; i += 4) {
2687 		u32 val = HDMI_READ(HDMI_CEC_RX_DATA_1 + (i >> 2));
2688 
2689 		msg->msg[i] = val & 0xff;
2690 		msg->msg[i + 1] = (val >> 8) & 0xff;
2691 		msg->msg[i + 2] = (val >> 16) & 0xff;
2692 		msg->msg[i + 3] = (val >> 24) & 0xff;
2693 	}
2694 }
2695 
2696 static irqreturn_t vc4_cec_irq_handler_tx_bare_locked(struct vc4_hdmi *vc4_hdmi)
2697 {
2698 	u32 cntrl1;
2699 
2700 	/*
2701 	 * We don't need to protect the register access using
2702 	 * drm_dev_enter() there because the interrupt handler lifetime
2703 	 * is tied to the device itself, and not to the DRM device.
2704 	 *
2705 	 * So when the device will be gone, one of the first thing we
2706 	 * will be doing will be to unregister the interrupt handler,
2707 	 * and then unregister the DRM device. drm_dev_enter() would
2708 	 * thus always succeed if we are here.
2709 	 */
2710 
2711 	lockdep_assert_held(&vc4_hdmi->hw_lock);
2712 
2713 	cntrl1 = HDMI_READ(HDMI_CEC_CNTRL_1);
2714 	vc4_hdmi->cec_tx_ok = cntrl1 & VC4_HDMI_CEC_TX_STATUS_GOOD;
2715 	cntrl1 &= ~VC4_HDMI_CEC_START_XMIT_BEGIN;
2716 	HDMI_WRITE(HDMI_CEC_CNTRL_1, cntrl1);
2717 
2718 	return IRQ_WAKE_THREAD;
2719 }
2720 
2721 static irqreturn_t vc4_cec_irq_handler_tx_bare(int irq, void *priv)
2722 {
2723 	struct vc4_hdmi *vc4_hdmi = priv;
2724 	irqreturn_t ret;
2725 
2726 	spin_lock(&vc4_hdmi->hw_lock);
2727 	ret = vc4_cec_irq_handler_tx_bare_locked(vc4_hdmi);
2728 	spin_unlock(&vc4_hdmi->hw_lock);
2729 
2730 	return ret;
2731 }
2732 
2733 static irqreturn_t vc4_cec_irq_handler_rx_bare_locked(struct vc4_hdmi *vc4_hdmi)
2734 {
2735 	u32 cntrl1;
2736 
2737 	lockdep_assert_held(&vc4_hdmi->hw_lock);
2738 
2739 	/*
2740 	 * We don't need to protect the register access using
2741 	 * drm_dev_enter() there because the interrupt handler lifetime
2742 	 * is tied to the device itself, and not to the DRM device.
2743 	 *
2744 	 * So when the device will be gone, one of the first thing we
2745 	 * will be doing will be to unregister the interrupt handler,
2746 	 * and then unregister the DRM device. drm_dev_enter() would
2747 	 * thus always succeed if we are here.
2748 	 */
2749 
2750 	vc4_hdmi->cec_rx_msg.len = 0;
2751 	cntrl1 = HDMI_READ(HDMI_CEC_CNTRL_1);
2752 	vc4_cec_read_msg(vc4_hdmi, cntrl1);
2753 	cntrl1 |= VC4_HDMI_CEC_CLEAR_RECEIVE_OFF;
2754 	HDMI_WRITE(HDMI_CEC_CNTRL_1, cntrl1);
2755 	cntrl1 &= ~VC4_HDMI_CEC_CLEAR_RECEIVE_OFF;
2756 
2757 	HDMI_WRITE(HDMI_CEC_CNTRL_1, cntrl1);
2758 
2759 	return IRQ_WAKE_THREAD;
2760 }
2761 
2762 static irqreturn_t vc4_cec_irq_handler_rx_bare(int irq, void *priv)
2763 {
2764 	struct vc4_hdmi *vc4_hdmi = priv;
2765 	irqreturn_t ret;
2766 
2767 	spin_lock(&vc4_hdmi->hw_lock);
2768 	ret = vc4_cec_irq_handler_rx_bare_locked(vc4_hdmi);
2769 	spin_unlock(&vc4_hdmi->hw_lock);
2770 
2771 	return ret;
2772 }
2773 
2774 static irqreturn_t vc4_cec_irq_handler(int irq, void *priv)
2775 {
2776 	struct vc4_hdmi *vc4_hdmi = priv;
2777 	u32 stat = HDMI_READ(HDMI_CEC_CPU_STATUS);
2778 	irqreturn_t ret;
2779 	u32 cntrl5;
2780 
2781 	/*
2782 	 * We don't need to protect the register access using
2783 	 * drm_dev_enter() there because the interrupt handler lifetime
2784 	 * is tied to the device itself, and not to the DRM device.
2785 	 *
2786 	 * So when the device will be gone, one of the first thing we
2787 	 * will be doing will be to unregister the interrupt handler,
2788 	 * and then unregister the DRM device. drm_dev_enter() would
2789 	 * thus always succeed if we are here.
2790 	 */
2791 
2792 	if (!(stat & VC4_HDMI_CPU_CEC))
2793 		return IRQ_NONE;
2794 
2795 	spin_lock(&vc4_hdmi->hw_lock);
2796 	cntrl5 = HDMI_READ(HDMI_CEC_CNTRL_5);
2797 	vc4_hdmi->cec_irq_was_rx = cntrl5 & VC4_HDMI_CEC_RX_CEC_INT;
2798 	if (vc4_hdmi->cec_irq_was_rx)
2799 		ret = vc4_cec_irq_handler_rx_bare_locked(vc4_hdmi);
2800 	else
2801 		ret = vc4_cec_irq_handler_tx_bare_locked(vc4_hdmi);
2802 
2803 	HDMI_WRITE(HDMI_CEC_CPU_CLEAR, VC4_HDMI_CPU_CEC);
2804 	spin_unlock(&vc4_hdmi->hw_lock);
2805 
2806 	return ret;
2807 }
2808 
2809 static int vc4_hdmi_cec_enable(struct cec_adapter *adap)
2810 {
2811 	struct vc4_hdmi *vc4_hdmi = cec_get_drvdata(adap);
2812 	struct drm_device *drm = vc4_hdmi->connector.dev;
2813 	/* clock period in microseconds */
2814 	const u32 usecs = 1000000 / CEC_CLOCK_FREQ;
2815 	unsigned long flags;
2816 	u32 val;
2817 	int ret;
2818 	int idx;
2819 
2820 	if (!drm_dev_enter(drm, &idx))
2821 		/*
2822 		 * We can't return an error code, because the CEC
2823 		 * framework will emit WARN_ON messages at unbind
2824 		 * otherwise.
2825 		 */
2826 		return 0;
2827 
2828 	ret = pm_runtime_resume_and_get(&vc4_hdmi->pdev->dev);
2829 	if (ret) {
2830 		drm_dev_exit(idx);
2831 		return ret;
2832 	}
2833 
2834 	mutex_lock(&vc4_hdmi->mutex);
2835 
2836 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
2837 
2838 	val = HDMI_READ(HDMI_CEC_CNTRL_5);
2839 	val &= ~(VC4_HDMI_CEC_TX_SW_RESET | VC4_HDMI_CEC_RX_SW_RESET |
2840 		 VC4_HDMI_CEC_CNT_TO_4700_US_MASK |
2841 		 VC4_HDMI_CEC_CNT_TO_4500_US_MASK);
2842 	val |= ((4700 / usecs) << VC4_HDMI_CEC_CNT_TO_4700_US_SHIFT) |
2843 	       ((4500 / usecs) << VC4_HDMI_CEC_CNT_TO_4500_US_SHIFT);
2844 
2845 	HDMI_WRITE(HDMI_CEC_CNTRL_5, val |
2846 		   VC4_HDMI_CEC_TX_SW_RESET | VC4_HDMI_CEC_RX_SW_RESET);
2847 	HDMI_WRITE(HDMI_CEC_CNTRL_5, val);
2848 	HDMI_WRITE(HDMI_CEC_CNTRL_2,
2849 		   ((1500 / usecs) << VC4_HDMI_CEC_CNT_TO_1500_US_SHIFT) |
2850 		   ((1300 / usecs) << VC4_HDMI_CEC_CNT_TO_1300_US_SHIFT) |
2851 		   ((800 / usecs) << VC4_HDMI_CEC_CNT_TO_800_US_SHIFT) |
2852 		   ((600 / usecs) << VC4_HDMI_CEC_CNT_TO_600_US_SHIFT) |
2853 		   ((400 / usecs) << VC4_HDMI_CEC_CNT_TO_400_US_SHIFT));
2854 	HDMI_WRITE(HDMI_CEC_CNTRL_3,
2855 		   ((2750 / usecs) << VC4_HDMI_CEC_CNT_TO_2750_US_SHIFT) |
2856 		   ((2400 / usecs) << VC4_HDMI_CEC_CNT_TO_2400_US_SHIFT) |
2857 		   ((2050 / usecs) << VC4_HDMI_CEC_CNT_TO_2050_US_SHIFT) |
2858 		   ((1700 / usecs) << VC4_HDMI_CEC_CNT_TO_1700_US_SHIFT));
2859 	HDMI_WRITE(HDMI_CEC_CNTRL_4,
2860 		   ((4300 / usecs) << VC4_HDMI_CEC_CNT_TO_4300_US_SHIFT) |
2861 		   ((3900 / usecs) << VC4_HDMI_CEC_CNT_TO_3900_US_SHIFT) |
2862 		   ((3600 / usecs) << VC4_HDMI_CEC_CNT_TO_3600_US_SHIFT) |
2863 		   ((3500 / usecs) << VC4_HDMI_CEC_CNT_TO_3500_US_SHIFT));
2864 
2865 	if (!vc4_hdmi->variant->external_irq_controller)
2866 		HDMI_WRITE(HDMI_CEC_CPU_MASK_CLEAR, VC4_HDMI_CPU_CEC);
2867 
2868 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
2869 
2870 	mutex_unlock(&vc4_hdmi->mutex);
2871 	drm_dev_exit(idx);
2872 
2873 	return 0;
2874 }
2875 
2876 static int vc4_hdmi_cec_disable(struct cec_adapter *adap)
2877 {
2878 	struct vc4_hdmi *vc4_hdmi = cec_get_drvdata(adap);
2879 	struct drm_device *drm = vc4_hdmi->connector.dev;
2880 	unsigned long flags;
2881 	int idx;
2882 
2883 	if (!drm_dev_enter(drm, &idx))
2884 		/*
2885 		 * We can't return an error code, because the CEC
2886 		 * framework will emit WARN_ON messages at unbind
2887 		 * otherwise.
2888 		 */
2889 		return 0;
2890 
2891 	mutex_lock(&vc4_hdmi->mutex);
2892 
2893 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
2894 
2895 	if (!vc4_hdmi->variant->external_irq_controller)
2896 		HDMI_WRITE(HDMI_CEC_CPU_MASK_SET, VC4_HDMI_CPU_CEC);
2897 
2898 	HDMI_WRITE(HDMI_CEC_CNTRL_5, HDMI_READ(HDMI_CEC_CNTRL_5) |
2899 		   VC4_HDMI_CEC_TX_SW_RESET | VC4_HDMI_CEC_RX_SW_RESET);
2900 
2901 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
2902 
2903 	mutex_unlock(&vc4_hdmi->mutex);
2904 
2905 	pm_runtime_put(&vc4_hdmi->pdev->dev);
2906 
2907 	drm_dev_exit(idx);
2908 
2909 	return 0;
2910 }
2911 
2912 static int vc4_hdmi_cec_adap_enable(struct cec_adapter *adap, bool enable)
2913 {
2914 	if (enable)
2915 		return vc4_hdmi_cec_enable(adap);
2916 	else
2917 		return vc4_hdmi_cec_disable(adap);
2918 }
2919 
2920 static int vc4_hdmi_cec_adap_log_addr(struct cec_adapter *adap, u8 log_addr)
2921 {
2922 	struct vc4_hdmi *vc4_hdmi = cec_get_drvdata(adap);
2923 	struct drm_device *drm = vc4_hdmi->connector.dev;
2924 	unsigned long flags;
2925 	int idx;
2926 
2927 	if (!drm_dev_enter(drm, &idx))
2928 		/*
2929 		 * We can't return an error code, because the CEC
2930 		 * framework will emit WARN_ON messages at unbind
2931 		 * otherwise.
2932 		 */
2933 		return 0;
2934 
2935 	mutex_lock(&vc4_hdmi->mutex);
2936 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
2937 	HDMI_WRITE(HDMI_CEC_CNTRL_1,
2938 		   (HDMI_READ(HDMI_CEC_CNTRL_1) & ~VC4_HDMI_CEC_ADDR_MASK) |
2939 		   (log_addr & 0xf) << VC4_HDMI_CEC_ADDR_SHIFT);
2940 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
2941 	mutex_unlock(&vc4_hdmi->mutex);
2942 
2943 	drm_dev_exit(idx);
2944 
2945 	return 0;
2946 }
2947 
2948 static int vc4_hdmi_cec_adap_transmit(struct cec_adapter *adap, u8 attempts,
2949 				      u32 signal_free_time, struct cec_msg *msg)
2950 {
2951 	struct vc4_hdmi *vc4_hdmi = cec_get_drvdata(adap);
2952 	struct drm_device *dev = vc4_hdmi->connector.dev;
2953 	unsigned long flags;
2954 	u32 val;
2955 	unsigned int i;
2956 	int idx;
2957 
2958 	if (!drm_dev_enter(dev, &idx))
2959 		return -ENODEV;
2960 
2961 	if (msg->len > 16) {
2962 		drm_err(dev, "Attempting to transmit too much data (%d)\n", msg->len);
2963 		drm_dev_exit(idx);
2964 		return -ENOMEM;
2965 	}
2966 
2967 	mutex_lock(&vc4_hdmi->mutex);
2968 
2969 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
2970 
2971 	for (i = 0; i < msg->len; i += 4)
2972 		HDMI_WRITE(HDMI_CEC_TX_DATA_1 + (i >> 2),
2973 			   (msg->msg[i]) |
2974 			   (msg->msg[i + 1] << 8) |
2975 			   (msg->msg[i + 2] << 16) |
2976 			   (msg->msg[i + 3] << 24));
2977 
2978 	val = HDMI_READ(HDMI_CEC_CNTRL_1);
2979 	val &= ~VC4_HDMI_CEC_START_XMIT_BEGIN;
2980 	HDMI_WRITE(HDMI_CEC_CNTRL_1, val);
2981 	val &= ~VC4_HDMI_CEC_MESSAGE_LENGTH_MASK;
2982 	val |= (msg->len - 1) << VC4_HDMI_CEC_MESSAGE_LENGTH_SHIFT;
2983 	val |= VC4_HDMI_CEC_START_XMIT_BEGIN;
2984 
2985 	HDMI_WRITE(HDMI_CEC_CNTRL_1, val);
2986 
2987 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
2988 	mutex_unlock(&vc4_hdmi->mutex);
2989 	drm_dev_exit(idx);
2990 
2991 	return 0;
2992 }
2993 
2994 static const struct cec_adap_ops vc4_hdmi_cec_adap_ops = {
2995 	.adap_enable = vc4_hdmi_cec_adap_enable,
2996 	.adap_log_addr = vc4_hdmi_cec_adap_log_addr,
2997 	.adap_transmit = vc4_hdmi_cec_adap_transmit,
2998 };
2999 
3000 static void vc4_hdmi_cec_release(void *ptr)
3001 {
3002 	struct vc4_hdmi *vc4_hdmi = ptr;
3003 
3004 	cec_unregister_adapter(vc4_hdmi->cec_adap);
3005 	vc4_hdmi->cec_adap = NULL;
3006 }
3007 
3008 static int vc4_hdmi_cec_init(struct vc4_hdmi *vc4_hdmi)
3009 {
3010 	struct cec_connector_info conn_info;
3011 	struct platform_device *pdev = vc4_hdmi->pdev;
3012 	struct device *dev = &pdev->dev;
3013 	int ret;
3014 
3015 	if (!of_find_property(dev->of_node, "interrupts", NULL)) {
3016 		dev_warn(dev, "'interrupts' DT property is missing, no CEC\n");
3017 		return 0;
3018 	}
3019 
3020 	vc4_hdmi->cec_adap = cec_allocate_adapter(&vc4_hdmi_cec_adap_ops,
3021 						  vc4_hdmi, "vc4",
3022 						  CEC_CAP_DEFAULTS |
3023 						  CEC_CAP_CONNECTOR_INFO, 1);
3024 	ret = PTR_ERR_OR_ZERO(vc4_hdmi->cec_adap);
3025 	if (ret < 0)
3026 		return ret;
3027 
3028 	cec_fill_conn_info_from_drm(&conn_info, &vc4_hdmi->connector);
3029 	cec_s_conn_info(vc4_hdmi->cec_adap, &conn_info);
3030 
3031 	if (vc4_hdmi->variant->external_irq_controller) {
3032 		ret = devm_request_threaded_irq(dev, platform_get_irq_byname(pdev, "cec-rx"),
3033 						vc4_cec_irq_handler_rx_bare,
3034 						vc4_cec_irq_handler_rx_thread, 0,
3035 						"vc4 hdmi cec rx", vc4_hdmi);
3036 		if (ret)
3037 			goto err_delete_cec_adap;
3038 
3039 		ret = devm_request_threaded_irq(dev, platform_get_irq_byname(pdev, "cec-tx"),
3040 						vc4_cec_irq_handler_tx_bare,
3041 						vc4_cec_irq_handler_tx_thread, 0,
3042 						"vc4 hdmi cec tx", vc4_hdmi);
3043 		if (ret)
3044 			goto err_delete_cec_adap;
3045 	} else {
3046 		ret = devm_request_threaded_irq(dev, platform_get_irq(pdev, 0),
3047 						vc4_cec_irq_handler,
3048 						vc4_cec_irq_handler_thread, 0,
3049 						"vc4 hdmi cec", vc4_hdmi);
3050 		if (ret)
3051 			goto err_delete_cec_adap;
3052 	}
3053 
3054 	ret = cec_register_adapter(vc4_hdmi->cec_adap, &pdev->dev);
3055 	if (ret < 0)
3056 		goto err_delete_cec_adap;
3057 
3058 	/*
3059 	 * NOTE: Strictly speaking, we should probably use a DRM-managed
3060 	 * registration there to avoid removing the CEC adapter by the
3061 	 * time the DRM driver doesn't have any user anymore.
3062 	 *
3063 	 * However, the CEC framework already cleans up the CEC adapter
3064 	 * only when the last user has closed its file descriptor, so we
3065 	 * don't need to handle it in DRM.
3066 	 *
3067 	 * By the time the device-managed hook is executed, we will give
3068 	 * up our reference to the CEC adapter and therefore don't
3069 	 * really care when it's actually freed.
3070 	 *
3071 	 * There's still a problematic sequence: if we unregister our
3072 	 * CEC adapter, but the userspace keeps a handle on the CEC
3073 	 * adapter but not the DRM device for some reason. In such a
3074 	 * case, our vc4_hdmi structure will be freed, but the
3075 	 * cec_adapter structure will have a dangling pointer to what
3076 	 * used to be our HDMI controller. If we get a CEC call at that
3077 	 * moment, we could end up with a use-after-free. Fortunately,
3078 	 * the CEC framework already handles this too, by calling
3079 	 * cec_is_registered() in cec_ioctl() and cec_poll().
3080 	 */
3081 	ret = devm_add_action_or_reset(dev, vc4_hdmi_cec_release, vc4_hdmi);
3082 	if (ret)
3083 		return ret;
3084 
3085 	return 0;
3086 
3087 err_delete_cec_adap:
3088 	cec_delete_adapter(vc4_hdmi->cec_adap);
3089 
3090 	return ret;
3091 }
3092 #else
3093 static int vc4_hdmi_cec_init(struct vc4_hdmi *vc4_hdmi)
3094 {
3095 	return 0;
3096 }
3097 #endif
3098 
3099 static void vc4_hdmi_free_regset(struct drm_device *drm, void *ptr)
3100 {
3101 	struct debugfs_reg32 *regs = ptr;
3102 
3103 	kfree(regs);
3104 }
3105 
3106 static int vc4_hdmi_build_regset(struct drm_device *drm,
3107 				 struct vc4_hdmi *vc4_hdmi,
3108 				 struct debugfs_regset32 *regset,
3109 				 enum vc4_hdmi_regs reg)
3110 {
3111 	const struct vc4_hdmi_variant *variant = vc4_hdmi->variant;
3112 	struct debugfs_reg32 *regs, *new_regs;
3113 	unsigned int count = 0;
3114 	unsigned int i;
3115 	int ret;
3116 
3117 	regs = kcalloc(variant->num_registers, sizeof(*regs),
3118 		       GFP_KERNEL);
3119 	if (!regs)
3120 		return -ENOMEM;
3121 
3122 	for (i = 0; i < variant->num_registers; i++) {
3123 		const struct vc4_hdmi_register *field =	&variant->registers[i];
3124 
3125 		if (field->reg != reg)
3126 			continue;
3127 
3128 		regs[count].name = field->name;
3129 		regs[count].offset = field->offset;
3130 		count++;
3131 	}
3132 
3133 	new_regs = krealloc(regs, count * sizeof(*regs), GFP_KERNEL);
3134 	if (!new_regs)
3135 		return -ENOMEM;
3136 
3137 	regset->base = __vc4_hdmi_get_field_base(vc4_hdmi, reg);
3138 	regset->regs = new_regs;
3139 	regset->nregs = count;
3140 
3141 	ret = drmm_add_action_or_reset(drm, vc4_hdmi_free_regset, new_regs);
3142 	if (ret)
3143 		return ret;
3144 
3145 	return 0;
3146 }
3147 
3148 static int vc4_hdmi_init_resources(struct drm_device *drm,
3149 				   struct vc4_hdmi *vc4_hdmi)
3150 {
3151 	struct platform_device *pdev = vc4_hdmi->pdev;
3152 	struct device *dev = &pdev->dev;
3153 	int ret;
3154 
3155 	vc4_hdmi->hdmicore_regs = vc4_ioremap_regs(pdev, 0);
3156 	if (IS_ERR(vc4_hdmi->hdmicore_regs))
3157 		return PTR_ERR(vc4_hdmi->hdmicore_regs);
3158 
3159 	vc4_hdmi->hd_regs = vc4_ioremap_regs(pdev, 1);
3160 	if (IS_ERR(vc4_hdmi->hd_regs))
3161 		return PTR_ERR(vc4_hdmi->hd_regs);
3162 
3163 	ret = vc4_hdmi_build_regset(drm, vc4_hdmi, &vc4_hdmi->hd_regset, VC4_HD);
3164 	if (ret)
3165 		return ret;
3166 
3167 	ret = vc4_hdmi_build_regset(drm, vc4_hdmi, &vc4_hdmi->hdmi_regset, VC4_HDMI);
3168 	if (ret)
3169 		return ret;
3170 
3171 	vc4_hdmi->pixel_clock = devm_clk_get(dev, "pixel");
3172 	if (IS_ERR(vc4_hdmi->pixel_clock)) {
3173 		ret = PTR_ERR(vc4_hdmi->pixel_clock);
3174 		if (ret != -EPROBE_DEFER)
3175 			DRM_ERROR("Failed to get pixel clock\n");
3176 		return ret;
3177 	}
3178 
3179 	vc4_hdmi->hsm_clock = devm_clk_get(dev, "hdmi");
3180 	if (IS_ERR(vc4_hdmi->hsm_clock)) {
3181 		DRM_ERROR("Failed to get HDMI state machine clock\n");
3182 		return PTR_ERR(vc4_hdmi->hsm_clock);
3183 	}
3184 
3185 	vc4_hdmi->audio_clock = vc4_hdmi->hsm_clock;
3186 	vc4_hdmi->cec_clock = vc4_hdmi->hsm_clock;
3187 
3188 	vc4_hdmi->hsm_rpm_clock = devm_clk_get(dev, "hdmi");
3189 	if (IS_ERR(vc4_hdmi->hsm_rpm_clock)) {
3190 		DRM_ERROR("Failed to get HDMI state machine clock\n");
3191 		return PTR_ERR(vc4_hdmi->hsm_rpm_clock);
3192 	}
3193 
3194 	return 0;
3195 }
3196 
3197 static int vc5_hdmi_init_resources(struct drm_device *drm,
3198 				   struct vc4_hdmi *vc4_hdmi)
3199 {
3200 	struct platform_device *pdev = vc4_hdmi->pdev;
3201 	struct device *dev = &pdev->dev;
3202 	struct resource *res;
3203 	int ret;
3204 
3205 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hdmi");
3206 	if (!res)
3207 		return -ENODEV;
3208 
3209 	vc4_hdmi->hdmicore_regs = devm_ioremap(dev, res->start,
3210 					       resource_size(res));
3211 	if (!vc4_hdmi->hdmicore_regs)
3212 		return -ENOMEM;
3213 
3214 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hd");
3215 	if (!res)
3216 		return -ENODEV;
3217 
3218 	vc4_hdmi->hd_regs = devm_ioremap(dev, res->start, resource_size(res));
3219 	if (!vc4_hdmi->hd_regs)
3220 		return -ENOMEM;
3221 
3222 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "cec");
3223 	if (!res)
3224 		return -ENODEV;
3225 
3226 	vc4_hdmi->cec_regs = devm_ioremap(dev, res->start, resource_size(res));
3227 	if (!vc4_hdmi->cec_regs)
3228 		return -ENOMEM;
3229 
3230 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "csc");
3231 	if (!res)
3232 		return -ENODEV;
3233 
3234 	vc4_hdmi->csc_regs = devm_ioremap(dev, res->start, resource_size(res));
3235 	if (!vc4_hdmi->csc_regs)
3236 		return -ENOMEM;
3237 
3238 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dvp");
3239 	if (!res)
3240 		return -ENODEV;
3241 
3242 	vc4_hdmi->dvp_regs = devm_ioremap(dev, res->start, resource_size(res));
3243 	if (!vc4_hdmi->dvp_regs)
3244 		return -ENOMEM;
3245 
3246 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "phy");
3247 	if (!res)
3248 		return -ENODEV;
3249 
3250 	vc4_hdmi->phy_regs = devm_ioremap(dev, res->start, resource_size(res));
3251 	if (!vc4_hdmi->phy_regs)
3252 		return -ENOMEM;
3253 
3254 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "packet");
3255 	if (!res)
3256 		return -ENODEV;
3257 
3258 	vc4_hdmi->ram_regs = devm_ioremap(dev, res->start, resource_size(res));
3259 	if (!vc4_hdmi->ram_regs)
3260 		return -ENOMEM;
3261 
3262 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rm");
3263 	if (!res)
3264 		return -ENODEV;
3265 
3266 	vc4_hdmi->rm_regs = devm_ioremap(dev, res->start, resource_size(res));
3267 	if (!vc4_hdmi->rm_regs)
3268 		return -ENOMEM;
3269 
3270 	vc4_hdmi->hsm_clock = devm_clk_get(dev, "hdmi");
3271 	if (IS_ERR(vc4_hdmi->hsm_clock)) {
3272 		DRM_ERROR("Failed to get HDMI state machine clock\n");
3273 		return PTR_ERR(vc4_hdmi->hsm_clock);
3274 	}
3275 
3276 	vc4_hdmi->hsm_rpm_clock = devm_clk_get(dev, "hdmi");
3277 	if (IS_ERR(vc4_hdmi->hsm_rpm_clock)) {
3278 		DRM_ERROR("Failed to get HDMI state machine clock\n");
3279 		return PTR_ERR(vc4_hdmi->hsm_rpm_clock);
3280 	}
3281 
3282 	vc4_hdmi->pixel_bvb_clock = devm_clk_get(dev, "bvb");
3283 	if (IS_ERR(vc4_hdmi->pixel_bvb_clock)) {
3284 		DRM_ERROR("Failed to get pixel bvb clock\n");
3285 		return PTR_ERR(vc4_hdmi->pixel_bvb_clock);
3286 	}
3287 
3288 	vc4_hdmi->audio_clock = devm_clk_get(dev, "audio");
3289 	if (IS_ERR(vc4_hdmi->audio_clock)) {
3290 		DRM_ERROR("Failed to get audio clock\n");
3291 		return PTR_ERR(vc4_hdmi->audio_clock);
3292 	}
3293 
3294 	vc4_hdmi->cec_clock = devm_clk_get(dev, "cec");
3295 	if (IS_ERR(vc4_hdmi->cec_clock)) {
3296 		DRM_ERROR("Failed to get CEC clock\n");
3297 		return PTR_ERR(vc4_hdmi->cec_clock);
3298 	}
3299 
3300 	vc4_hdmi->reset = devm_reset_control_get(dev, NULL);
3301 	if (IS_ERR(vc4_hdmi->reset)) {
3302 		DRM_ERROR("Failed to get HDMI reset line\n");
3303 		return PTR_ERR(vc4_hdmi->reset);
3304 	}
3305 
3306 	ret = vc4_hdmi_build_regset(drm, vc4_hdmi, &vc4_hdmi->hdmi_regset, VC4_HDMI);
3307 	if (ret)
3308 		return ret;
3309 
3310 	ret = vc4_hdmi_build_regset(drm, vc4_hdmi, &vc4_hdmi->hd_regset, VC4_HD);
3311 	if (ret)
3312 		return ret;
3313 
3314 	ret = vc4_hdmi_build_regset(drm, vc4_hdmi, &vc4_hdmi->cec_regset, VC5_CEC);
3315 	if (ret)
3316 		return ret;
3317 
3318 	ret = vc4_hdmi_build_regset(drm, vc4_hdmi, &vc4_hdmi->csc_regset, VC5_CSC);
3319 	if (ret)
3320 		return ret;
3321 
3322 	ret = vc4_hdmi_build_regset(drm, vc4_hdmi, &vc4_hdmi->dvp_regset, VC5_DVP);
3323 	if (ret)
3324 		return ret;
3325 
3326 	ret = vc4_hdmi_build_regset(drm, vc4_hdmi, &vc4_hdmi->phy_regset, VC5_PHY);
3327 	if (ret)
3328 		return ret;
3329 
3330 	ret = vc4_hdmi_build_regset(drm, vc4_hdmi, &vc4_hdmi->ram_regset, VC5_RAM);
3331 	if (ret)
3332 		return ret;
3333 
3334 	ret = vc4_hdmi_build_regset(drm, vc4_hdmi, &vc4_hdmi->rm_regset, VC5_RM);
3335 	if (ret)
3336 		return ret;
3337 
3338 	return 0;
3339 }
3340 
3341 static int vc4_hdmi_runtime_suspend(struct device *dev)
3342 {
3343 	struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);
3344 
3345 	clk_disable_unprepare(vc4_hdmi->hsm_rpm_clock);
3346 
3347 	return 0;
3348 }
3349 
3350 static int vc4_hdmi_runtime_resume(struct device *dev)
3351 {
3352 	struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);
3353 	unsigned long __maybe_unused flags;
3354 	u32 __maybe_unused value;
3355 	unsigned long rate;
3356 	int ret;
3357 
3358 	/*
3359 	 * The HSM clock is in the HDMI power domain, so we need to set
3360 	 * its frequency while the power domain is active so that it
3361 	 * keeps its rate.
3362 	 */
3363 	ret = clk_set_min_rate(vc4_hdmi->hsm_rpm_clock, HSM_MIN_CLOCK_FREQ);
3364 	if (ret)
3365 		return ret;
3366 
3367 	ret = clk_prepare_enable(vc4_hdmi->hsm_rpm_clock);
3368 	if (ret)
3369 		return ret;
3370 
3371 	/*
3372 	 * Whenever the RaspberryPi boots without an HDMI monitor
3373 	 * plugged in, the firmware won't have initialized the HSM clock
3374 	 * rate and it will be reported as 0.
3375 	 *
3376 	 * If we try to access a register of the controller in such a
3377 	 * case, it will lead to a silent CPU stall. Let's make sure we
3378 	 * prevent such a case.
3379 	 */
3380 	rate = clk_get_rate(vc4_hdmi->hsm_rpm_clock);
3381 	if (!rate) {
3382 		ret = -EINVAL;
3383 		goto err_disable_clk;
3384 	}
3385 
3386 	if (vc4_hdmi->variant->reset)
3387 		vc4_hdmi->variant->reset(vc4_hdmi);
3388 
3389 #ifdef CONFIG_DRM_VC4_HDMI_CEC
3390 	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
3391 	value = HDMI_READ(HDMI_CEC_CNTRL_1);
3392 	/* Set the logical address to Unregistered */
3393 	value |= VC4_HDMI_CEC_ADDR_MASK;
3394 	HDMI_WRITE(HDMI_CEC_CNTRL_1, value);
3395 	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
3396 
3397 	vc4_hdmi_cec_update_clk_div(vc4_hdmi);
3398 
3399 	if (!vc4_hdmi->variant->external_irq_controller) {
3400 		spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
3401 		HDMI_WRITE(HDMI_CEC_CPU_MASK_SET, 0xffffffff);
3402 		spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
3403 	}
3404 #endif
3405 
3406 	return 0;
3407 
3408 err_disable_clk:
3409 	clk_disable_unprepare(vc4_hdmi->hsm_clock);
3410 	return ret;
3411 }
3412 
3413 static void vc4_hdmi_put_ddc_device(void *ptr)
3414 {
3415 	struct vc4_hdmi *vc4_hdmi = ptr;
3416 
3417 	put_device(&vc4_hdmi->ddc->dev);
3418 }
3419 
3420 static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
3421 {
3422 	const struct vc4_hdmi_variant *variant = of_device_get_match_data(dev);
3423 	struct platform_device *pdev = to_platform_device(dev);
3424 	struct drm_device *drm = dev_get_drvdata(master);
3425 	struct vc4_hdmi *vc4_hdmi;
3426 	struct drm_encoder *encoder;
3427 	struct device_node *ddc_node;
3428 	int ret;
3429 
3430 	vc4_hdmi = drmm_kzalloc(drm, sizeof(*vc4_hdmi), GFP_KERNEL);
3431 	if (!vc4_hdmi)
3432 		return -ENOMEM;
3433 
3434 	ret = drmm_mutex_init(drm, &vc4_hdmi->mutex);
3435 	if (ret)
3436 		return ret;
3437 
3438 	spin_lock_init(&vc4_hdmi->hw_lock);
3439 	INIT_DELAYED_WORK(&vc4_hdmi->scrambling_work, vc4_hdmi_scrambling_wq);
3440 
3441 	dev_set_drvdata(dev, vc4_hdmi);
3442 	encoder = &vc4_hdmi->encoder.base;
3443 	vc4_hdmi->encoder.type = variant->encoder_type;
3444 	vc4_hdmi->encoder.pre_crtc_configure = vc4_hdmi_encoder_pre_crtc_configure;
3445 	vc4_hdmi->encoder.pre_crtc_enable = vc4_hdmi_encoder_pre_crtc_enable;
3446 	vc4_hdmi->encoder.post_crtc_enable = vc4_hdmi_encoder_post_crtc_enable;
3447 	vc4_hdmi->encoder.post_crtc_disable = vc4_hdmi_encoder_post_crtc_disable;
3448 	vc4_hdmi->encoder.post_crtc_powerdown = vc4_hdmi_encoder_post_crtc_powerdown;
3449 	vc4_hdmi->pdev = pdev;
3450 	vc4_hdmi->variant = variant;
3451 
3452 	/*
3453 	 * Since we don't know the state of the controller and its
3454 	 * display (if any), let's assume it's always enabled.
3455 	 * vc4_hdmi_disable_scrambling() will thus run at boot, make
3456 	 * sure it's disabled, and avoid any inconsistency.
3457 	 */
3458 	if (variant->max_pixel_clock > HDMI_14_MAX_TMDS_CLK)
3459 		vc4_hdmi->scdc_enabled = true;
3460 
3461 	ret = variant->init_resources(drm, vc4_hdmi);
3462 	if (ret)
3463 		return ret;
3464 
3465 	ddc_node = of_parse_phandle(dev->of_node, "ddc", 0);
3466 	if (!ddc_node) {
3467 		DRM_ERROR("Failed to find ddc node in device tree\n");
3468 		return -ENODEV;
3469 	}
3470 
3471 	vc4_hdmi->ddc = of_find_i2c_adapter_by_node(ddc_node);
3472 	of_node_put(ddc_node);
3473 	if (!vc4_hdmi->ddc) {
3474 		DRM_DEBUG("Failed to get ddc i2c adapter by node\n");
3475 		return -EPROBE_DEFER;
3476 	}
3477 
3478 	ret = devm_add_action_or_reset(dev, vc4_hdmi_put_ddc_device, vc4_hdmi);
3479 	if (ret)
3480 		return ret;
3481 
3482 	/* Only use the GPIO HPD pin if present in the DT, otherwise
3483 	 * we'll use the HDMI core's register.
3484 	 */
3485 	vc4_hdmi->hpd_gpio = devm_gpiod_get_optional(dev, "hpd", GPIOD_IN);
3486 	if (IS_ERR(vc4_hdmi->hpd_gpio)) {
3487 		return PTR_ERR(vc4_hdmi->hpd_gpio);
3488 	}
3489 
3490 	vc4_hdmi->disable_wifi_frequencies =
3491 		of_property_read_bool(dev->of_node, "wifi-2.4ghz-coexistence");
3492 
3493 	ret = devm_pm_runtime_enable(dev);
3494 	if (ret)
3495 		return ret;
3496 
3497 	/*
3498 	 *  We need to have the device powered up at this point to call
3499 	 *  our reset hook and for the CEC init.
3500 	 */
3501 	ret = pm_runtime_resume_and_get(dev);
3502 	if (ret)
3503 		return ret;
3504 
3505 	if ((of_device_is_compatible(dev->of_node, "brcm,bcm2711-hdmi0") ||
3506 	     of_device_is_compatible(dev->of_node, "brcm,bcm2711-hdmi1")) &&
3507 	    HDMI_READ(HDMI_VID_CTL) & VC4_HD_VID_CTL_ENABLE) {
3508 		clk_prepare_enable(vc4_hdmi->pixel_clock);
3509 		clk_prepare_enable(vc4_hdmi->hsm_clock);
3510 		clk_prepare_enable(vc4_hdmi->pixel_bvb_clock);
3511 	}
3512 
3513 	ret = drmm_encoder_init(drm, encoder,
3514 				&vc4_hdmi_encoder_funcs,
3515 				DRM_MODE_ENCODER_TMDS,
3516 				NULL);
3517 	if (ret)
3518 		goto err_put_runtime_pm;
3519 
3520 	drm_encoder_helper_add(encoder, &vc4_hdmi_encoder_helper_funcs);
3521 
3522 	ret = vc4_hdmi_connector_init(drm, vc4_hdmi);
3523 	if (ret)
3524 		goto err_put_runtime_pm;
3525 
3526 	ret = vc4_hdmi_hotplug_init(vc4_hdmi);
3527 	if (ret)
3528 		goto err_put_runtime_pm;
3529 
3530 	ret = vc4_hdmi_cec_init(vc4_hdmi);
3531 	if (ret)
3532 		goto err_put_runtime_pm;
3533 
3534 	ret = vc4_hdmi_audio_init(vc4_hdmi);
3535 	if (ret)
3536 		goto err_put_runtime_pm;
3537 
3538 	pm_runtime_put_sync(dev);
3539 
3540 	return 0;
3541 
3542 err_put_runtime_pm:
3543 	pm_runtime_put_sync(dev);
3544 
3545 	return ret;
3546 }
3547 
3548 static const struct component_ops vc4_hdmi_ops = {
3549 	.bind   = vc4_hdmi_bind,
3550 };
3551 
3552 static int vc4_hdmi_dev_probe(struct platform_device *pdev)
3553 {
3554 	return component_add(&pdev->dev, &vc4_hdmi_ops);
3555 }
3556 
3557 static int vc4_hdmi_dev_remove(struct platform_device *pdev)
3558 {
3559 	component_del(&pdev->dev, &vc4_hdmi_ops);
3560 	return 0;
3561 }
3562 
3563 static const struct vc4_hdmi_variant bcm2835_variant = {
3564 	.encoder_type		= VC4_ENCODER_TYPE_HDMI0,
3565 	.debugfs_name		= "hdmi_regs",
3566 	.card_name		= "vc4-hdmi",
3567 	.max_pixel_clock	= 162000000,
3568 	.registers		= vc4_hdmi_fields,
3569 	.num_registers		= ARRAY_SIZE(vc4_hdmi_fields),
3570 
3571 	.init_resources		= vc4_hdmi_init_resources,
3572 	.csc_setup		= vc4_hdmi_csc_setup,
3573 	.reset			= vc4_hdmi_reset,
3574 	.set_timings		= vc4_hdmi_set_timings,
3575 	.phy_init		= vc4_hdmi_phy_init,
3576 	.phy_disable		= vc4_hdmi_phy_disable,
3577 	.phy_rng_enable		= vc4_hdmi_phy_rng_enable,
3578 	.phy_rng_disable	= vc4_hdmi_phy_rng_disable,
3579 	.channel_map		= vc4_hdmi_channel_map,
3580 	.supports_hdr		= false,
3581 };
3582 
3583 static const struct vc4_hdmi_variant bcm2711_hdmi0_variant = {
3584 	.encoder_type		= VC4_ENCODER_TYPE_HDMI0,
3585 	.debugfs_name		= "hdmi0_regs",
3586 	.card_name		= "vc4-hdmi-0",
3587 	.max_pixel_clock	= 600000000,
3588 	.registers		= vc5_hdmi_hdmi0_fields,
3589 	.num_registers		= ARRAY_SIZE(vc5_hdmi_hdmi0_fields),
3590 	.phy_lane_mapping	= {
3591 		PHY_LANE_0,
3592 		PHY_LANE_1,
3593 		PHY_LANE_2,
3594 		PHY_LANE_CK,
3595 	},
3596 	.unsupported_odd_h_timings	= true,
3597 	.external_irq_controller	= true,
3598 
3599 	.init_resources		= vc5_hdmi_init_resources,
3600 	.csc_setup		= vc5_hdmi_csc_setup,
3601 	.reset			= vc5_hdmi_reset,
3602 	.set_timings		= vc5_hdmi_set_timings,
3603 	.phy_init		= vc5_hdmi_phy_init,
3604 	.phy_disable		= vc5_hdmi_phy_disable,
3605 	.phy_rng_enable		= vc5_hdmi_phy_rng_enable,
3606 	.phy_rng_disable	= vc5_hdmi_phy_rng_disable,
3607 	.channel_map		= vc5_hdmi_channel_map,
3608 	.supports_hdr		= true,
3609 	.hp_detect		= vc5_hdmi_hp_detect,
3610 };
3611 
3612 static const struct vc4_hdmi_variant bcm2711_hdmi1_variant = {
3613 	.encoder_type		= VC4_ENCODER_TYPE_HDMI1,
3614 	.debugfs_name		= "hdmi1_regs",
3615 	.card_name		= "vc4-hdmi-1",
3616 	.max_pixel_clock	= HDMI_14_MAX_TMDS_CLK,
3617 	.registers		= vc5_hdmi_hdmi1_fields,
3618 	.num_registers		= ARRAY_SIZE(vc5_hdmi_hdmi1_fields),
3619 	.phy_lane_mapping	= {
3620 		PHY_LANE_1,
3621 		PHY_LANE_0,
3622 		PHY_LANE_CK,
3623 		PHY_LANE_2,
3624 	},
3625 	.unsupported_odd_h_timings	= true,
3626 	.external_irq_controller	= true,
3627 
3628 	.init_resources		= vc5_hdmi_init_resources,
3629 	.csc_setup		= vc5_hdmi_csc_setup,
3630 	.reset			= vc5_hdmi_reset,
3631 	.set_timings		= vc5_hdmi_set_timings,
3632 	.phy_init		= vc5_hdmi_phy_init,
3633 	.phy_disable		= vc5_hdmi_phy_disable,
3634 	.phy_rng_enable		= vc5_hdmi_phy_rng_enable,
3635 	.phy_rng_disable	= vc5_hdmi_phy_rng_disable,
3636 	.channel_map		= vc5_hdmi_channel_map,
3637 	.supports_hdr		= true,
3638 	.hp_detect		= vc5_hdmi_hp_detect,
3639 };
3640 
3641 static const struct of_device_id vc4_hdmi_dt_match[] = {
3642 	{ .compatible = "brcm,bcm2835-hdmi", .data = &bcm2835_variant },
3643 	{ .compatible = "brcm,bcm2711-hdmi0", .data = &bcm2711_hdmi0_variant },
3644 	{ .compatible = "brcm,bcm2711-hdmi1", .data = &bcm2711_hdmi1_variant },
3645 	{}
3646 };
3647 
3648 static const struct dev_pm_ops vc4_hdmi_pm_ops = {
3649 	SET_RUNTIME_PM_OPS(vc4_hdmi_runtime_suspend,
3650 			   vc4_hdmi_runtime_resume,
3651 			   NULL)
3652 };
3653 
3654 struct platform_driver vc4_hdmi_driver = {
3655 	.probe = vc4_hdmi_dev_probe,
3656 	.remove = vc4_hdmi_dev_remove,
3657 	.driver = {
3658 		.name = "vc4_hdmi",
3659 		.of_match_table = vc4_hdmi_dt_match,
3660 		.pm = &vc4_hdmi_pm_ops,
3661 	},
3662 };
3663