xref: /linux/drivers/gpu/drm/vc4/vc4_dpi.c (revision 445b287e18ca374b5498e0f7cecb6c5f673c4edb)
1caab277bSThomas Gleixner // SPDX-License-Identifier: GPL-2.0-only
208302c35SEric Anholt /*
308302c35SEric Anholt  * Copyright (C) 2016 Broadcom Limited
408302c35SEric Anholt  */
508302c35SEric Anholt 
608302c35SEric Anholt /**
708302c35SEric Anholt  * DOC: VC4 DPI module
808302c35SEric Anholt  *
908302c35SEric Anholt  * The VC4 DPI hardware supports MIPI DPI type 4 and Nokia ViSSI
10f6c01530SEric Anholt  * signals.  On BCM2835, these can be routed out to GPIO0-27 with the
11f6c01530SEric Anholt  * ALT2 function.
1208302c35SEric Anholt  */
1308302c35SEric Anholt 
14b7e8e25bSMasahiro Yamada #include <drm/drm_atomic_helper.h>
157b1298e0SEric Anholt #include <drm/drm_bridge.h>
1671b1bd4cSMaxime Ripard #include <drm/drm_drv.h>
17b7e8e25bSMasahiro Yamada #include <drm/drm_edid.h>
187b1298e0SEric Anholt #include <drm/drm_of.h>
19b7e8e25bSMasahiro Yamada #include <drm/drm_panel.h>
20fcd70cd3SDaniel Vetter #include <drm/drm_probe_helper.h>
21f6ebc1b0SThomas Zimmermann #include <drm/drm_simple_kms_helper.h>
22b7e8e25bSMasahiro Yamada #include <linux/clk.h>
23b7e8e25bSMasahiro Yamada #include <linux/component.h>
2472bd9ea3SVille Syrjälä #include <linux/media-bus-format.h>
25b7e8e25bSMasahiro Yamada #include <linux/of_graph.h>
26b7e8e25bSMasahiro Yamada #include <linux/of_platform.h>
2708302c35SEric Anholt #include "vc4_drv.h"
2808302c35SEric Anholt #include "vc4_regs.h"
2908302c35SEric Anholt 
3008302c35SEric Anholt #define DPI_C			0x00
3108302c35SEric Anholt # define DPI_OUTPUT_ENABLE_MODE		BIT(16)
3208302c35SEric Anholt 
3308302c35SEric Anholt /* The order field takes the incoming 24 bit RGB from the pixel valve
3408302c35SEric Anholt  * and shuffles the 3 channels.
3508302c35SEric Anholt  */
3608302c35SEric Anholt # define DPI_ORDER_MASK			VC4_MASK(15, 14)
3708302c35SEric Anholt # define DPI_ORDER_SHIFT		14
3808302c35SEric Anholt # define DPI_ORDER_RGB			0
3908302c35SEric Anholt # define DPI_ORDER_BGR			1
4008302c35SEric Anholt # define DPI_ORDER_GRB			2
4108302c35SEric Anholt # define DPI_ORDER_BRG			3
4208302c35SEric Anholt 
4308302c35SEric Anholt /* The format field takes the ORDER-shuffled pixel valve data and
4408302c35SEric Anholt  * formats it onto the output lines.
4508302c35SEric Anholt  */
4608302c35SEric Anholt # define DPI_FORMAT_MASK		VC4_MASK(13, 11)
4708302c35SEric Anholt # define DPI_FORMAT_SHIFT		11
4808302c35SEric Anholt /* This define is named in the hardware, but actually just outputs 0. */
4908302c35SEric Anholt # define DPI_FORMAT_9BIT_666_RGB	0
5008302c35SEric Anholt /* Outputs 00000000rrrrrggggggbbbbb */
5108302c35SEric Anholt # define DPI_FORMAT_16BIT_565_RGB_1	1
5208302c35SEric Anholt /* Outputs 000rrrrr00gggggg000bbbbb */
5308302c35SEric Anholt # define DPI_FORMAT_16BIT_565_RGB_2	2
5408302c35SEric Anholt /* Outputs 00rrrrr000gggggg00bbbbb0 */
5508302c35SEric Anholt # define DPI_FORMAT_16BIT_565_RGB_3	3
5608302c35SEric Anholt /* Outputs 000000rrrrrrggggggbbbbbb */
5708302c35SEric Anholt # define DPI_FORMAT_18BIT_666_RGB_1	4
5808302c35SEric Anholt /* Outputs 00rrrrrr00gggggg00bbbbbb */
5908302c35SEric Anholt # define DPI_FORMAT_18BIT_666_RGB_2	5
6008302c35SEric Anholt /* Outputs rrrrrrrrggggggggbbbbbbbb */
6108302c35SEric Anholt # define DPI_FORMAT_24BIT_888_RGB	6
6208302c35SEric Anholt 
6308302c35SEric Anholt /* Reverses the polarity of the corresponding signal */
6408302c35SEric Anholt # define DPI_PIXEL_CLK_INVERT		BIT(10)
6508302c35SEric Anholt # define DPI_HSYNC_INVERT		BIT(9)
6608302c35SEric Anholt # define DPI_VSYNC_INVERT		BIT(8)
6708302c35SEric Anholt # define DPI_OUTPUT_ENABLE_INVERT	BIT(7)
6808302c35SEric Anholt 
6908302c35SEric Anholt /* Outputs the signal the falling clock edge instead of rising. */
7008302c35SEric Anholt # define DPI_HSYNC_NEGATE		BIT(6)
7108302c35SEric Anholt # define DPI_VSYNC_NEGATE		BIT(5)
7208302c35SEric Anholt # define DPI_OUTPUT_ENABLE_NEGATE	BIT(4)
7308302c35SEric Anholt 
7408302c35SEric Anholt /* Disables the signal */
7508302c35SEric Anholt # define DPI_HSYNC_DISABLE		BIT(3)
7608302c35SEric Anholt # define DPI_VSYNC_DISABLE		BIT(2)
7708302c35SEric Anholt # define DPI_OUTPUT_ENABLE_DISABLE	BIT(1)
7808302c35SEric Anholt 
7908302c35SEric Anholt /* Power gate to the device, full reset at 0 -> 1 transition */
8008302c35SEric Anholt # define DPI_ENABLE			BIT(0)
8108302c35SEric Anholt 
8208302c35SEric Anholt /* All other registers besides DPI_C return the ID */
8308302c35SEric Anholt #define DPI_ID			0x04
8408302c35SEric Anholt # define DPI_ID_VALUE		0x00647069
8508302c35SEric Anholt 
8608302c35SEric Anholt /* General DPI hardware state. */
8708302c35SEric Anholt struct vc4_dpi {
887c9a4babSMaxime Ripard 	struct vc4_encoder encoder;
8908302c35SEric Anholt 
907c9a4babSMaxime Ripard 	struct platform_device *pdev;
9108302c35SEric Anholt 
9208302c35SEric Anholt 	void __iomem *regs;
9308302c35SEric Anholt 
9408302c35SEric Anholt 	struct clk *pixel_clock;
9508302c35SEric Anholt 	struct clk *core_clock;
963051719aSEric Anholt 
973051719aSEric Anholt 	struct debugfs_regset32 regset;
9808302c35SEric Anholt };
9908302c35SEric Anholt 
1007c9a4babSMaxime Ripard static inline struct vc4_dpi *
1017c9a4babSMaxime Ripard to_vc4_dpi(struct drm_encoder *encoder)
1027c9a4babSMaxime Ripard {
1037c9a4babSMaxime Ripard 	return container_of(encoder, struct vc4_dpi, encoder.base);
1047c9a4babSMaxime Ripard }
1057c9a4babSMaxime Ripard 
10608302c35SEric Anholt #define DPI_READ(offset) readl(dpi->regs + (offset))
10708302c35SEric Anholt #define DPI_WRITE(offset, val) writel(val, dpi->regs + (offset))
10808302c35SEric Anholt 
1093051719aSEric Anholt static const struct debugfs_reg32 dpi_regs[] = {
1103051719aSEric Anholt 	VC4_REG32(DPI_C),
1113051719aSEric Anholt 	VC4_REG32(DPI_ID),
11208302c35SEric Anholt };
11308302c35SEric Anholt 
11408302c35SEric Anholt static void vc4_dpi_encoder_disable(struct drm_encoder *encoder)
11508302c35SEric Anholt {
11671b1bd4cSMaxime Ripard 	struct drm_device *dev = encoder->dev;
1177c9a4babSMaxime Ripard 	struct vc4_dpi *dpi = to_vc4_dpi(encoder);
11871b1bd4cSMaxime Ripard 	int idx;
11971b1bd4cSMaxime Ripard 
12071b1bd4cSMaxime Ripard 	if (!drm_dev_enter(dev, &idx))
12171b1bd4cSMaxime Ripard 		return;
12208302c35SEric Anholt 
12308302c35SEric Anholt 	clk_disable_unprepare(dpi->pixel_clock);
12471b1bd4cSMaxime Ripard 
12571b1bd4cSMaxime Ripard 	drm_dev_exit(idx);
12608302c35SEric Anholt }
12708302c35SEric Anholt 
12808302c35SEric Anholt static void vc4_dpi_encoder_enable(struct drm_encoder *encoder)
12908302c35SEric Anholt {
130164c2416SEric Anholt 	struct drm_device *dev = encoder->dev;
13108302c35SEric Anholt 	struct drm_display_mode *mode = &encoder->crtc->mode;
1327c9a4babSMaxime Ripard 	struct vc4_dpi *dpi = to_vc4_dpi(encoder);
133164c2416SEric Anholt 	struct drm_connector_list_iter conn_iter;
134164c2416SEric Anholt 	struct drm_connector *connector = NULL, *connector_scan;
1357fea3c23SDave Stevenson 	u32 dpi_c = DPI_ENABLE;
13671b1bd4cSMaxime Ripard 	int idx;
13708302c35SEric Anholt 	int ret;
13808302c35SEric Anholt 
139164c2416SEric Anholt 	/* Look up the connector attached to DPI so we can get the
140164c2416SEric Anholt 	 * bus_format.  Ideally the bridge would tell us the
141164c2416SEric Anholt 	 * bus_format we want, but it doesn't yet, so assume that it's
142164c2416SEric Anholt 	 * uniform throughout the bridge chain.
143164c2416SEric Anholt 	 */
144164c2416SEric Anholt 	drm_connector_list_iter_begin(dev, &conn_iter);
145164c2416SEric Anholt 	drm_for_each_connector_iter(connector_scan, &conn_iter) {
146164c2416SEric Anholt 		if (connector_scan->encoder == encoder) {
147164c2416SEric Anholt 			connector = connector_scan;
148164c2416SEric Anholt 			break;
149164c2416SEric Anholt 		}
150164c2416SEric Anholt 	}
151164c2416SEric Anholt 	drm_connector_list_iter_end(&conn_iter);
152164c2416SEric Anholt 
1537a70b0b9SDave Stevenson 	/* Default to 24bit if no connector or format found. */
1547a70b0b9SDave Stevenson 	dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB, DPI_FORMAT);
1557a70b0b9SDave Stevenson 
1563c270763SDave Stevenson 	if (connector) {
1573c270763SDave Stevenson 		if (connector->display_info.num_bus_formats) {
158164c2416SEric Anholt 			u32 bus_format = connector->display_info.bus_formats[0];
15908302c35SEric Anholt 
1607a70b0b9SDave Stevenson 			dpi_c &= ~DPI_FORMAT_MASK;
1617a70b0b9SDave Stevenson 
16208302c35SEric Anholt 			switch (bus_format) {
16308302c35SEric Anholt 			case MEDIA_BUS_FMT_RGB888_1X24:
16408302c35SEric Anholt 				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB,
16508302c35SEric Anholt 						       DPI_FORMAT);
16608302c35SEric Anholt 				break;
16708302c35SEric Anholt 			case MEDIA_BUS_FMT_BGR888_1X24:
16808302c35SEric Anholt 				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB,
16908302c35SEric Anholt 						       DPI_FORMAT);
1703c270763SDave Stevenson 				dpi_c |= VC4_SET_FIELD(DPI_ORDER_BGR,
1713c270763SDave Stevenson 						       DPI_ORDER);
17208302c35SEric Anholt 				break;
17308302c35SEric Anholt 			case MEDIA_BUS_FMT_RGB666_1X24_CPADHI:
17408302c35SEric Anholt 				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_2,
17508302c35SEric Anholt 						       DPI_FORMAT);
17608302c35SEric Anholt 				break;
17708302c35SEric Anholt 			case MEDIA_BUS_FMT_RGB666_1X18:
17808302c35SEric Anholt 				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1,
17908302c35SEric Anholt 						       DPI_FORMAT);
18008302c35SEric Anholt 				break;
18108302c35SEric Anholt 			case MEDIA_BUS_FMT_RGB565_1X16:
18208302c35SEric Anholt 				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3,
18308302c35SEric Anholt 						       DPI_FORMAT);
18408302c35SEric Anholt 				break;
18508302c35SEric Anholt 			default:
1863c270763SDave Stevenson 				DRM_ERROR("Unknown media bus format %d\n",
1873c270763SDave Stevenson 					  bus_format);
18808302c35SEric Anholt 				break;
18908302c35SEric Anholt 			}
1903c270763SDave Stevenson 		}
1913c270763SDave Stevenson 
1923c270763SDave Stevenson 		if (connector->display_info.bus_flags & DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE)
1933c270763SDave Stevenson 			dpi_c |= DPI_PIXEL_CLK_INVERT;
1943c270763SDave Stevenson 
1953c270763SDave Stevenson 		if (connector->display_info.bus_flags & DRM_BUS_FLAG_DE_LOW)
1963c270763SDave Stevenson 			dpi_c |= DPI_OUTPUT_ENABLE_INVERT;
19708302c35SEric Anholt 	}
19808302c35SEric Anholt 
1997fea3c23SDave Stevenson 	if (mode->flags & DRM_MODE_FLAG_CSYNC) {
2007fea3c23SDave Stevenson 		if (mode->flags & DRM_MODE_FLAG_NCSYNC)
2017fea3c23SDave Stevenson 			dpi_c |= DPI_OUTPUT_ENABLE_INVERT;
2027fea3c23SDave Stevenson 	} else {
2037fea3c23SDave Stevenson 		dpi_c |= DPI_OUTPUT_ENABLE_MODE;
2047fea3c23SDave Stevenson 
20508302c35SEric Anholt 		if (mode->flags & DRM_MODE_FLAG_NHSYNC)
20608302c35SEric Anholt 			dpi_c |= DPI_HSYNC_INVERT;
20708302c35SEric Anholt 		else if (!(mode->flags & DRM_MODE_FLAG_PHSYNC))
20808302c35SEric Anholt 			dpi_c |= DPI_HSYNC_DISABLE;
20908302c35SEric Anholt 
21008302c35SEric Anholt 		if (mode->flags & DRM_MODE_FLAG_NVSYNC)
21108302c35SEric Anholt 			dpi_c |= DPI_VSYNC_INVERT;
21208302c35SEric Anholt 		else if (!(mode->flags & DRM_MODE_FLAG_PVSYNC))
21308302c35SEric Anholt 			dpi_c |= DPI_VSYNC_DISABLE;
2147fea3c23SDave Stevenson 	}
21508302c35SEric Anholt 
21671b1bd4cSMaxime Ripard 	if (!drm_dev_enter(dev, &idx))
21771b1bd4cSMaxime Ripard 		return;
21871b1bd4cSMaxime Ripard 
21908302c35SEric Anholt 	DPI_WRITE(DPI_C, dpi_c);
22008302c35SEric Anholt 
22108302c35SEric Anholt 	ret = clk_set_rate(dpi->pixel_clock, mode->clock * 1000);
22208302c35SEric Anholt 	if (ret)
22308302c35SEric Anholt 		DRM_ERROR("Failed to set clock rate: %d\n", ret);
22408302c35SEric Anholt 
22508302c35SEric Anholt 	ret = clk_prepare_enable(dpi->pixel_clock);
22608302c35SEric Anholt 	if (ret)
22708302c35SEric Anholt 		DRM_ERROR("Failed to set clock rate: %d\n", ret);
22871b1bd4cSMaxime Ripard 
22971b1bd4cSMaxime Ripard 	drm_dev_exit(idx);
23008302c35SEric Anholt }
23108302c35SEric Anholt 
232c50a115bSJose Abreu static enum drm_mode_status vc4_dpi_encoder_mode_valid(struct drm_encoder *encoder,
233c50a115bSJose Abreu 						       const struct drm_display_mode *mode)
234e2298350SMario Kleiner {
235c50a115bSJose Abreu 	if (mode->flags & DRM_MODE_FLAG_INTERLACE)
236c50a115bSJose Abreu 		return MODE_NO_INTERLACE;
237e2298350SMario Kleiner 
238c50a115bSJose Abreu 	return MODE_OK;
239e2298350SMario Kleiner }
240e2298350SMario Kleiner 
24108302c35SEric Anholt static const struct drm_encoder_helper_funcs vc4_dpi_encoder_helper_funcs = {
24208302c35SEric Anholt 	.disable = vc4_dpi_encoder_disable,
24308302c35SEric Anholt 	.enable = vc4_dpi_encoder_enable,
244c50a115bSJose Abreu 	.mode_valid = vc4_dpi_encoder_mode_valid,
24508302c35SEric Anholt };
24608302c35SEric Anholt 
247*445b287eSMaxime Ripard static int vc4_dpi_late_register(struct drm_encoder *encoder)
248*445b287eSMaxime Ripard {
249*445b287eSMaxime Ripard 	struct drm_device *drm = encoder->dev;
250*445b287eSMaxime Ripard 	struct vc4_dpi *dpi = to_vc4_dpi(encoder);
251*445b287eSMaxime Ripard 	int ret;
252*445b287eSMaxime Ripard 
253*445b287eSMaxime Ripard 	ret = vc4_debugfs_add_regset32(drm->primary, "dpi_regs", &dpi->regset);
254*445b287eSMaxime Ripard 	if (ret)
255*445b287eSMaxime Ripard 		return ret;
256*445b287eSMaxime Ripard 
257*445b287eSMaxime Ripard 	return 0;
258*445b287eSMaxime Ripard }
259*445b287eSMaxime Ripard 
260*445b287eSMaxime Ripard static const struct drm_encoder_funcs vc4_dpi_encoder_funcs = {
261*445b287eSMaxime Ripard 	.late_register = vc4_dpi_late_register,
262*445b287eSMaxime Ripard };
263*445b287eSMaxime Ripard 
26408302c35SEric Anholt static const struct of_device_id vc4_dpi_dt_match[] = {
26508302c35SEric Anholt 	{ .compatible = "brcm,bcm2835-dpi", .data = NULL },
26608302c35SEric Anholt 	{}
26708302c35SEric Anholt };
26808302c35SEric Anholt 
2697b1298e0SEric Anholt /* Sets up the next link in the display chain, whether it's a panel or
2707b1298e0SEric Anholt  * a bridge.
27108302c35SEric Anholt  */
2727b1298e0SEric Anholt static int vc4_dpi_init_bridge(struct vc4_dpi *dpi)
27308302c35SEric Anholt {
274055af023SMaxime Ripard 	struct drm_device *drm = dpi->encoder.base.dev;
2757b1298e0SEric Anholt 	struct device *dev = &dpi->pdev->dev;
2768f6b06c1Sbenjamin.gaignard@linaro.org 	struct drm_bridge *bridge;
27708302c35SEric Anholt 
278055af023SMaxime Ripard 	bridge = drmm_of_get_bridge(drm, dev->of_node, 0, 0);
2790caddbbfSMaxime Ripard 	if (IS_ERR(bridge)) {
2807b1298e0SEric Anholt 		/* If nothing was connected in the DT, that's not an
2817b1298e0SEric Anholt 		 * error.
2827b1298e0SEric Anholt 		 */
2830caddbbfSMaxime Ripard 		if (PTR_ERR(bridge) == -ENODEV)
2847b1298e0SEric Anholt 			return 0;
2857b1298e0SEric Anholt 		else
2860caddbbfSMaxime Ripard 			return PTR_ERR(bridge);
2877b1298e0SEric Anholt 	}
28808302c35SEric Anholt 
2897c9a4babSMaxime Ripard 	return drm_bridge_attach(&dpi->encoder.base, bridge, NULL, 0);
29008302c35SEric Anholt }
29108302c35SEric Anholt 
29277932adfSMaxime Ripard static void vc4_dpi_disable_clock(void *ptr)
29377932adfSMaxime Ripard {
29477932adfSMaxime Ripard 	struct vc4_dpi *dpi = ptr;
29577932adfSMaxime Ripard 
29677932adfSMaxime Ripard 	clk_disable_unprepare(dpi->core_clock);
29777932adfSMaxime Ripard }
29877932adfSMaxime Ripard 
29908302c35SEric Anholt static int vc4_dpi_bind(struct device *dev, struct device *master, void *data)
30008302c35SEric Anholt {
30108302c35SEric Anholt 	struct platform_device *pdev = to_platform_device(dev);
30208302c35SEric Anholt 	struct drm_device *drm = dev_get_drvdata(master);
30308302c35SEric Anholt 	struct vc4_dpi *dpi;
30408302c35SEric Anholt 	int ret;
30508302c35SEric Anholt 
3067f0ba8f9SMaxime Ripard 	dpi = drmm_kzalloc(drm, sizeof(*dpi), GFP_KERNEL);
30708302c35SEric Anholt 	if (!dpi)
30808302c35SEric Anholt 		return -ENOMEM;
3097f0ba8f9SMaxime Ripard 
3107c9a4babSMaxime Ripard 	dpi->encoder.type = VC4_ENCODER_TYPE_DPI;
31108302c35SEric Anholt 	dpi->pdev = pdev;
31208302c35SEric Anholt 	dpi->regs = vc4_ioremap_regs(pdev, 0);
31308302c35SEric Anholt 	if (IS_ERR(dpi->regs))
31408302c35SEric Anholt 		return PTR_ERR(dpi->regs);
3153051719aSEric Anholt 	dpi->regset.base = dpi->regs;
3163051719aSEric Anholt 	dpi->regset.regs = dpi_regs;
3173051719aSEric Anholt 	dpi->regset.nregs = ARRAY_SIZE(dpi_regs);
31808302c35SEric Anholt 
31908302c35SEric Anholt 	if (DPI_READ(DPI_ID) != DPI_ID_VALUE) {
32008302c35SEric Anholt 		dev_err(dev, "Port returned 0x%08x for ID instead of 0x%08x\n",
32108302c35SEric Anholt 			DPI_READ(DPI_ID), DPI_ID_VALUE);
32208302c35SEric Anholt 		return -ENODEV;
32308302c35SEric Anholt 	}
32408302c35SEric Anholt 
32508302c35SEric Anholt 	dpi->core_clock = devm_clk_get(dev, "core");
32608302c35SEric Anholt 	if (IS_ERR(dpi->core_clock)) {
32708302c35SEric Anholt 		ret = PTR_ERR(dpi->core_clock);
32808302c35SEric Anholt 		if (ret != -EPROBE_DEFER)
32908302c35SEric Anholt 			DRM_ERROR("Failed to get core clock: %d\n", ret);
33008302c35SEric Anholt 		return ret;
33108302c35SEric Anholt 	}
332ff5b18ceSMaxime Ripard 
33308302c35SEric Anholt 	dpi->pixel_clock = devm_clk_get(dev, "pixel");
33408302c35SEric Anholt 	if (IS_ERR(dpi->pixel_clock)) {
33508302c35SEric Anholt 		ret = PTR_ERR(dpi->pixel_clock);
33608302c35SEric Anholt 		if (ret != -EPROBE_DEFER)
33708302c35SEric Anholt 			DRM_ERROR("Failed to get pixel clock: %d\n", ret);
33808302c35SEric Anholt 		return ret;
33908302c35SEric Anholt 	}
34008302c35SEric Anholt 
34108302c35SEric Anholt 	ret = clk_prepare_enable(dpi->core_clock);
342ff5b18ceSMaxime Ripard 	if (ret) {
34308302c35SEric Anholt 		DRM_ERROR("Failed to turn on core clock: %d\n", ret);
344ff5b18ceSMaxime Ripard 		return ret;
345ff5b18ceSMaxime Ripard 	}
34608302c35SEric Anholt 
34777932adfSMaxime Ripard 	ret = devm_add_action_or_reset(dev, vc4_dpi_disable_clock, dpi);
34877932adfSMaxime Ripard 	if (ret)
34977932adfSMaxime Ripard 		return ret;
35077932adfSMaxime Ripard 
351e126d318SMaxime Ripard 	ret = drmm_encoder_init(drm, &dpi->encoder.base,
352*445b287eSMaxime Ripard 				&vc4_dpi_encoder_funcs,
353e126d318SMaxime Ripard 				DRM_MODE_ENCODER_DPI,
354e126d318SMaxime Ripard 				NULL);
355e126d318SMaxime Ripard 	if (ret)
356e126d318SMaxime Ripard 		return ret;
357e126d318SMaxime Ripard 
3587c9a4babSMaxime Ripard 	drm_encoder_helper_add(&dpi->encoder.base, &vc4_dpi_encoder_helper_funcs);
35908302c35SEric Anholt 
3607b1298e0SEric Anholt 	ret = vc4_dpi_init_bridge(dpi);
3617b1298e0SEric Anholt 	if (ret)
362e126d318SMaxime Ripard 		return ret;
36308302c35SEric Anholt 
36408302c35SEric Anholt 	dev_set_drvdata(dev, dpi);
36508302c35SEric Anholt 
36608302c35SEric Anholt 	return 0;
36708302c35SEric Anholt }
36808302c35SEric Anholt 
36908302c35SEric Anholt static const struct component_ops vc4_dpi_ops = {
37008302c35SEric Anholt 	.bind   = vc4_dpi_bind,
37108302c35SEric Anholt };
37208302c35SEric Anholt 
37308302c35SEric Anholt static int vc4_dpi_dev_probe(struct platform_device *pdev)
37408302c35SEric Anholt {
37508302c35SEric Anholt 	return component_add(&pdev->dev, &vc4_dpi_ops);
37608302c35SEric Anholt }
37708302c35SEric Anholt 
37808302c35SEric Anholt static int vc4_dpi_dev_remove(struct platform_device *pdev)
37908302c35SEric Anholt {
38008302c35SEric Anholt 	component_del(&pdev->dev, &vc4_dpi_ops);
38108302c35SEric Anholt 	return 0;
38208302c35SEric Anholt }
38308302c35SEric Anholt 
38408302c35SEric Anholt struct platform_driver vc4_dpi_driver = {
38508302c35SEric Anholt 	.probe = vc4_dpi_dev_probe,
38608302c35SEric Anholt 	.remove = vc4_dpi_dev_remove,
38708302c35SEric Anholt 	.driver = {
38808302c35SEric Anholt 		.name = "vc4_dpi",
38908302c35SEric Anholt 		.of_match_table = vc4_dpi_dt_match,
39008302c35SEric Anholt 	},
39108302c35SEric Anholt };
392