xref: /linux/drivers/gpu/drm/vc4/vc4_dpi.c (revision 055af0235aef8110a1c44f5fc04c5c206e9e58fb)
1caab277bSThomas Gleixner // SPDX-License-Identifier: GPL-2.0-only
208302c35SEric Anholt /*
308302c35SEric Anholt  * Copyright (C) 2016 Broadcom Limited
408302c35SEric Anholt  */
508302c35SEric Anholt 
608302c35SEric Anholt /**
708302c35SEric Anholt  * DOC: VC4 DPI module
808302c35SEric Anholt  *
908302c35SEric Anholt  * The VC4 DPI hardware supports MIPI DPI type 4 and Nokia ViSSI
10f6c01530SEric Anholt  * signals.  On BCM2835, these can be routed out to GPIO0-27 with the
11f6c01530SEric Anholt  * ALT2 function.
1208302c35SEric Anholt  */
1308302c35SEric Anholt 
14b7e8e25bSMasahiro Yamada #include <drm/drm_atomic_helper.h>
157b1298e0SEric Anholt #include <drm/drm_bridge.h>
16b7e8e25bSMasahiro Yamada #include <drm/drm_edid.h>
177b1298e0SEric Anholt #include <drm/drm_of.h>
18b7e8e25bSMasahiro Yamada #include <drm/drm_panel.h>
19fcd70cd3SDaniel Vetter #include <drm/drm_probe_helper.h>
20f6ebc1b0SThomas Zimmermann #include <drm/drm_simple_kms_helper.h>
21b7e8e25bSMasahiro Yamada #include <linux/clk.h>
22b7e8e25bSMasahiro Yamada #include <linux/component.h>
2372bd9ea3SVille Syrjälä #include <linux/media-bus-format.h>
24b7e8e25bSMasahiro Yamada #include <linux/of_graph.h>
25b7e8e25bSMasahiro Yamada #include <linux/of_platform.h>
2608302c35SEric Anholt #include "vc4_drv.h"
2708302c35SEric Anholt #include "vc4_regs.h"
2808302c35SEric Anholt 
2908302c35SEric Anholt #define DPI_C			0x00
3008302c35SEric Anholt # define DPI_OUTPUT_ENABLE_MODE		BIT(16)
3108302c35SEric Anholt 
3208302c35SEric Anholt /* The order field takes the incoming 24 bit RGB from the pixel valve
3308302c35SEric Anholt  * and shuffles the 3 channels.
3408302c35SEric Anholt  */
3508302c35SEric Anholt # define DPI_ORDER_MASK			VC4_MASK(15, 14)
3608302c35SEric Anholt # define DPI_ORDER_SHIFT		14
3708302c35SEric Anholt # define DPI_ORDER_RGB			0
3808302c35SEric Anholt # define DPI_ORDER_BGR			1
3908302c35SEric Anholt # define DPI_ORDER_GRB			2
4008302c35SEric Anholt # define DPI_ORDER_BRG			3
4108302c35SEric Anholt 
4208302c35SEric Anholt /* The format field takes the ORDER-shuffled pixel valve data and
4308302c35SEric Anholt  * formats it onto the output lines.
4408302c35SEric Anholt  */
4508302c35SEric Anholt # define DPI_FORMAT_MASK		VC4_MASK(13, 11)
4608302c35SEric Anholt # define DPI_FORMAT_SHIFT		11
4708302c35SEric Anholt /* This define is named in the hardware, but actually just outputs 0. */
4808302c35SEric Anholt # define DPI_FORMAT_9BIT_666_RGB	0
4908302c35SEric Anholt /* Outputs 00000000rrrrrggggggbbbbb */
5008302c35SEric Anholt # define DPI_FORMAT_16BIT_565_RGB_1	1
5108302c35SEric Anholt /* Outputs 000rrrrr00gggggg000bbbbb */
5208302c35SEric Anholt # define DPI_FORMAT_16BIT_565_RGB_2	2
5308302c35SEric Anholt /* Outputs 00rrrrr000gggggg00bbbbb0 */
5408302c35SEric Anholt # define DPI_FORMAT_16BIT_565_RGB_3	3
5508302c35SEric Anholt /* Outputs 000000rrrrrrggggggbbbbbb */
5608302c35SEric Anholt # define DPI_FORMAT_18BIT_666_RGB_1	4
5708302c35SEric Anholt /* Outputs 00rrrrrr00gggggg00bbbbbb */
5808302c35SEric Anholt # define DPI_FORMAT_18BIT_666_RGB_2	5
5908302c35SEric Anholt /* Outputs rrrrrrrrggggggggbbbbbbbb */
6008302c35SEric Anholt # define DPI_FORMAT_24BIT_888_RGB	6
6108302c35SEric Anholt 
6208302c35SEric Anholt /* Reverses the polarity of the corresponding signal */
6308302c35SEric Anholt # define DPI_PIXEL_CLK_INVERT		BIT(10)
6408302c35SEric Anholt # define DPI_HSYNC_INVERT		BIT(9)
6508302c35SEric Anholt # define DPI_VSYNC_INVERT		BIT(8)
6608302c35SEric Anholt # define DPI_OUTPUT_ENABLE_INVERT	BIT(7)
6708302c35SEric Anholt 
6808302c35SEric Anholt /* Outputs the signal the falling clock edge instead of rising. */
6908302c35SEric Anholt # define DPI_HSYNC_NEGATE		BIT(6)
7008302c35SEric Anholt # define DPI_VSYNC_NEGATE		BIT(5)
7108302c35SEric Anholt # define DPI_OUTPUT_ENABLE_NEGATE	BIT(4)
7208302c35SEric Anholt 
7308302c35SEric Anholt /* Disables the signal */
7408302c35SEric Anholt # define DPI_HSYNC_DISABLE		BIT(3)
7508302c35SEric Anholt # define DPI_VSYNC_DISABLE		BIT(2)
7608302c35SEric Anholt # define DPI_OUTPUT_ENABLE_DISABLE	BIT(1)
7708302c35SEric Anholt 
7808302c35SEric Anholt /* Power gate to the device, full reset at 0 -> 1 transition */
7908302c35SEric Anholt # define DPI_ENABLE			BIT(0)
8008302c35SEric Anholt 
8108302c35SEric Anholt /* All other registers besides DPI_C return the ID */
8208302c35SEric Anholt #define DPI_ID			0x04
8308302c35SEric Anholt # define DPI_ID_VALUE		0x00647069
8408302c35SEric Anholt 
8508302c35SEric Anholt /* General DPI hardware state. */
8608302c35SEric Anholt struct vc4_dpi {
877c9a4babSMaxime Ripard 	struct vc4_encoder encoder;
8808302c35SEric Anholt 
897c9a4babSMaxime Ripard 	struct platform_device *pdev;
9008302c35SEric Anholt 
9108302c35SEric Anholt 	void __iomem *regs;
9208302c35SEric Anholt 
9308302c35SEric Anholt 	struct clk *pixel_clock;
9408302c35SEric Anholt 	struct clk *core_clock;
953051719aSEric Anholt 
963051719aSEric Anholt 	struct debugfs_regset32 regset;
9708302c35SEric Anholt };
9808302c35SEric Anholt 
997c9a4babSMaxime Ripard static inline struct vc4_dpi *
1007c9a4babSMaxime Ripard to_vc4_dpi(struct drm_encoder *encoder)
1017c9a4babSMaxime Ripard {
1027c9a4babSMaxime Ripard 	return container_of(encoder, struct vc4_dpi, encoder.base);
1037c9a4babSMaxime Ripard }
1047c9a4babSMaxime Ripard 
10508302c35SEric Anholt #define DPI_READ(offset) readl(dpi->regs + (offset))
10608302c35SEric Anholt #define DPI_WRITE(offset, val) writel(val, dpi->regs + (offset))
10708302c35SEric Anholt 
1083051719aSEric Anholt static const struct debugfs_reg32 dpi_regs[] = {
1093051719aSEric Anholt 	VC4_REG32(DPI_C),
1103051719aSEric Anholt 	VC4_REG32(DPI_ID),
11108302c35SEric Anholt };
11208302c35SEric Anholt 
11308302c35SEric Anholt static void vc4_dpi_encoder_disable(struct drm_encoder *encoder)
11408302c35SEric Anholt {
1157c9a4babSMaxime Ripard 	struct vc4_dpi *dpi = to_vc4_dpi(encoder);
11608302c35SEric Anholt 
11708302c35SEric Anholt 	clk_disable_unprepare(dpi->pixel_clock);
11808302c35SEric Anholt }
11908302c35SEric Anholt 
12008302c35SEric Anholt static void vc4_dpi_encoder_enable(struct drm_encoder *encoder)
12108302c35SEric Anholt {
122164c2416SEric Anholt 	struct drm_device *dev = encoder->dev;
12308302c35SEric Anholt 	struct drm_display_mode *mode = &encoder->crtc->mode;
1247c9a4babSMaxime Ripard 	struct vc4_dpi *dpi = to_vc4_dpi(encoder);
125164c2416SEric Anholt 	struct drm_connector_list_iter conn_iter;
126164c2416SEric Anholt 	struct drm_connector *connector = NULL, *connector_scan;
1277fea3c23SDave Stevenson 	u32 dpi_c = DPI_ENABLE;
12808302c35SEric Anholt 	int ret;
12908302c35SEric Anholt 
130164c2416SEric Anholt 	/* Look up the connector attached to DPI so we can get the
131164c2416SEric Anholt 	 * bus_format.  Ideally the bridge would tell us the
132164c2416SEric Anholt 	 * bus_format we want, but it doesn't yet, so assume that it's
133164c2416SEric Anholt 	 * uniform throughout the bridge chain.
134164c2416SEric Anholt 	 */
135164c2416SEric Anholt 	drm_connector_list_iter_begin(dev, &conn_iter);
136164c2416SEric Anholt 	drm_for_each_connector_iter(connector_scan, &conn_iter) {
137164c2416SEric Anholt 		if (connector_scan->encoder == encoder) {
138164c2416SEric Anholt 			connector = connector_scan;
139164c2416SEric Anholt 			break;
140164c2416SEric Anholt 		}
141164c2416SEric Anholt 	}
142164c2416SEric Anholt 	drm_connector_list_iter_end(&conn_iter);
143164c2416SEric Anholt 
1447a70b0b9SDave Stevenson 	/* Default to 24bit if no connector or format found. */
1457a70b0b9SDave Stevenson 	dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB, DPI_FORMAT);
1467a70b0b9SDave Stevenson 
1473c270763SDave Stevenson 	if (connector) {
1483c270763SDave Stevenson 		if (connector->display_info.num_bus_formats) {
149164c2416SEric Anholt 			u32 bus_format = connector->display_info.bus_formats[0];
15008302c35SEric Anholt 
1517a70b0b9SDave Stevenson 			dpi_c &= ~DPI_FORMAT_MASK;
1527a70b0b9SDave Stevenson 
15308302c35SEric Anholt 			switch (bus_format) {
15408302c35SEric Anholt 			case MEDIA_BUS_FMT_RGB888_1X24:
15508302c35SEric Anholt 				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB,
15608302c35SEric Anholt 						       DPI_FORMAT);
15708302c35SEric Anholt 				break;
15808302c35SEric Anholt 			case MEDIA_BUS_FMT_BGR888_1X24:
15908302c35SEric Anholt 				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_24BIT_888_RGB,
16008302c35SEric Anholt 						       DPI_FORMAT);
1613c270763SDave Stevenson 				dpi_c |= VC4_SET_FIELD(DPI_ORDER_BGR,
1623c270763SDave Stevenson 						       DPI_ORDER);
16308302c35SEric Anholt 				break;
16408302c35SEric Anholt 			case MEDIA_BUS_FMT_RGB666_1X24_CPADHI:
16508302c35SEric Anholt 				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_2,
16608302c35SEric Anholt 						       DPI_FORMAT);
16708302c35SEric Anholt 				break;
16808302c35SEric Anholt 			case MEDIA_BUS_FMT_RGB666_1X18:
16908302c35SEric Anholt 				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_18BIT_666_RGB_1,
17008302c35SEric Anholt 						       DPI_FORMAT);
17108302c35SEric Anholt 				break;
17208302c35SEric Anholt 			case MEDIA_BUS_FMT_RGB565_1X16:
17308302c35SEric Anholt 				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3,
17408302c35SEric Anholt 						       DPI_FORMAT);
17508302c35SEric Anholt 				break;
17608302c35SEric Anholt 			default:
1773c270763SDave Stevenson 				DRM_ERROR("Unknown media bus format %d\n",
1783c270763SDave Stevenson 					  bus_format);
17908302c35SEric Anholt 				break;
18008302c35SEric Anholt 			}
1813c270763SDave Stevenson 		}
1823c270763SDave Stevenson 
1833c270763SDave Stevenson 		if (connector->display_info.bus_flags & DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE)
1843c270763SDave Stevenson 			dpi_c |= DPI_PIXEL_CLK_INVERT;
1853c270763SDave Stevenson 
1863c270763SDave Stevenson 		if (connector->display_info.bus_flags & DRM_BUS_FLAG_DE_LOW)
1873c270763SDave Stevenson 			dpi_c |= DPI_OUTPUT_ENABLE_INVERT;
18808302c35SEric Anholt 	}
18908302c35SEric Anholt 
1907fea3c23SDave Stevenson 	if (mode->flags & DRM_MODE_FLAG_CSYNC) {
1917fea3c23SDave Stevenson 		if (mode->flags & DRM_MODE_FLAG_NCSYNC)
1927fea3c23SDave Stevenson 			dpi_c |= DPI_OUTPUT_ENABLE_INVERT;
1937fea3c23SDave Stevenson 	} else {
1947fea3c23SDave Stevenson 		dpi_c |= DPI_OUTPUT_ENABLE_MODE;
1957fea3c23SDave Stevenson 
19608302c35SEric Anholt 		if (mode->flags & DRM_MODE_FLAG_NHSYNC)
19708302c35SEric Anholt 			dpi_c |= DPI_HSYNC_INVERT;
19808302c35SEric Anholt 		else if (!(mode->flags & DRM_MODE_FLAG_PHSYNC))
19908302c35SEric Anholt 			dpi_c |= DPI_HSYNC_DISABLE;
20008302c35SEric Anholt 
20108302c35SEric Anholt 		if (mode->flags & DRM_MODE_FLAG_NVSYNC)
20208302c35SEric Anholt 			dpi_c |= DPI_VSYNC_INVERT;
20308302c35SEric Anholt 		else if (!(mode->flags & DRM_MODE_FLAG_PVSYNC))
20408302c35SEric Anholt 			dpi_c |= DPI_VSYNC_DISABLE;
2057fea3c23SDave Stevenson 	}
20608302c35SEric Anholt 
20708302c35SEric Anholt 	DPI_WRITE(DPI_C, dpi_c);
20808302c35SEric Anholt 
20908302c35SEric Anholt 	ret = clk_set_rate(dpi->pixel_clock, mode->clock * 1000);
21008302c35SEric Anholt 	if (ret)
21108302c35SEric Anholt 		DRM_ERROR("Failed to set clock rate: %d\n", ret);
21208302c35SEric Anholt 
21308302c35SEric Anholt 	ret = clk_prepare_enable(dpi->pixel_clock);
21408302c35SEric Anholt 	if (ret)
21508302c35SEric Anholt 		DRM_ERROR("Failed to set clock rate: %d\n", ret);
21608302c35SEric Anholt }
21708302c35SEric Anholt 
218c50a115bSJose Abreu static enum drm_mode_status vc4_dpi_encoder_mode_valid(struct drm_encoder *encoder,
219c50a115bSJose Abreu 						       const struct drm_display_mode *mode)
220e2298350SMario Kleiner {
221c50a115bSJose Abreu 	if (mode->flags & DRM_MODE_FLAG_INTERLACE)
222c50a115bSJose Abreu 		return MODE_NO_INTERLACE;
223e2298350SMario Kleiner 
224c50a115bSJose Abreu 	return MODE_OK;
225e2298350SMario Kleiner }
226e2298350SMario Kleiner 
22708302c35SEric Anholt static const struct drm_encoder_helper_funcs vc4_dpi_encoder_helper_funcs = {
22808302c35SEric Anholt 	.disable = vc4_dpi_encoder_disable,
22908302c35SEric Anholt 	.enable = vc4_dpi_encoder_enable,
230c50a115bSJose Abreu 	.mode_valid = vc4_dpi_encoder_mode_valid,
23108302c35SEric Anholt };
23208302c35SEric Anholt 
23308302c35SEric Anholt static const struct of_device_id vc4_dpi_dt_match[] = {
23408302c35SEric Anholt 	{ .compatible = "brcm,bcm2835-dpi", .data = NULL },
23508302c35SEric Anholt 	{}
23608302c35SEric Anholt };
23708302c35SEric Anholt 
2387b1298e0SEric Anholt /* Sets up the next link in the display chain, whether it's a panel or
2397b1298e0SEric Anholt  * a bridge.
24008302c35SEric Anholt  */
2417b1298e0SEric Anholt static int vc4_dpi_init_bridge(struct vc4_dpi *dpi)
24208302c35SEric Anholt {
243*055af023SMaxime Ripard 	struct drm_device *drm = dpi->encoder.base.dev;
2447b1298e0SEric Anholt 	struct device *dev = &dpi->pdev->dev;
2458f6b06c1Sbenjamin.gaignard@linaro.org 	struct drm_bridge *bridge;
24608302c35SEric Anholt 
247*055af023SMaxime Ripard 	bridge = drmm_of_get_bridge(drm, dev->of_node, 0, 0);
2480caddbbfSMaxime Ripard 	if (IS_ERR(bridge)) {
2497b1298e0SEric Anholt 		/* If nothing was connected in the DT, that's not an
2507b1298e0SEric Anholt 		 * error.
2517b1298e0SEric Anholt 		 */
2520caddbbfSMaxime Ripard 		if (PTR_ERR(bridge) == -ENODEV)
2537b1298e0SEric Anholt 			return 0;
2547b1298e0SEric Anholt 		else
2550caddbbfSMaxime Ripard 			return PTR_ERR(bridge);
2567b1298e0SEric Anholt 	}
25708302c35SEric Anholt 
2587c9a4babSMaxime Ripard 	return drm_bridge_attach(&dpi->encoder.base, bridge, NULL, 0);
25908302c35SEric Anholt }
26008302c35SEric Anholt 
26177932adfSMaxime Ripard static void vc4_dpi_disable_clock(void *ptr)
26277932adfSMaxime Ripard {
26377932adfSMaxime Ripard 	struct vc4_dpi *dpi = ptr;
26477932adfSMaxime Ripard 
26577932adfSMaxime Ripard 	clk_disable_unprepare(dpi->core_clock);
26677932adfSMaxime Ripard }
26777932adfSMaxime Ripard 
26808302c35SEric Anholt static int vc4_dpi_bind(struct device *dev, struct device *master, void *data)
26908302c35SEric Anholt {
27008302c35SEric Anholt 	struct platform_device *pdev = to_platform_device(dev);
27108302c35SEric Anholt 	struct drm_device *drm = dev_get_drvdata(master);
27208302c35SEric Anholt 	struct vc4_dpi *dpi;
27308302c35SEric Anholt 	int ret;
27408302c35SEric Anholt 
2757f0ba8f9SMaxime Ripard 	dpi = drmm_kzalloc(drm, sizeof(*dpi), GFP_KERNEL);
27608302c35SEric Anholt 	if (!dpi)
27708302c35SEric Anholt 		return -ENOMEM;
2787f0ba8f9SMaxime Ripard 
2797c9a4babSMaxime Ripard 	dpi->encoder.type = VC4_ENCODER_TYPE_DPI;
28008302c35SEric Anholt 	dpi->pdev = pdev;
28108302c35SEric Anholt 	dpi->regs = vc4_ioremap_regs(pdev, 0);
28208302c35SEric Anholt 	if (IS_ERR(dpi->regs))
28308302c35SEric Anholt 		return PTR_ERR(dpi->regs);
2843051719aSEric Anholt 	dpi->regset.base = dpi->regs;
2853051719aSEric Anholt 	dpi->regset.regs = dpi_regs;
2863051719aSEric Anholt 	dpi->regset.nregs = ARRAY_SIZE(dpi_regs);
28708302c35SEric Anholt 
28808302c35SEric Anholt 	if (DPI_READ(DPI_ID) != DPI_ID_VALUE) {
28908302c35SEric Anholt 		dev_err(dev, "Port returned 0x%08x for ID instead of 0x%08x\n",
29008302c35SEric Anholt 			DPI_READ(DPI_ID), DPI_ID_VALUE);
29108302c35SEric Anholt 		return -ENODEV;
29208302c35SEric Anholt 	}
29308302c35SEric Anholt 
29408302c35SEric Anholt 	dpi->core_clock = devm_clk_get(dev, "core");
29508302c35SEric Anholt 	if (IS_ERR(dpi->core_clock)) {
29608302c35SEric Anholt 		ret = PTR_ERR(dpi->core_clock);
29708302c35SEric Anholt 		if (ret != -EPROBE_DEFER)
29808302c35SEric Anholt 			DRM_ERROR("Failed to get core clock: %d\n", ret);
29908302c35SEric Anholt 		return ret;
30008302c35SEric Anholt 	}
301ff5b18ceSMaxime Ripard 
30208302c35SEric Anholt 	dpi->pixel_clock = devm_clk_get(dev, "pixel");
30308302c35SEric Anholt 	if (IS_ERR(dpi->pixel_clock)) {
30408302c35SEric Anholt 		ret = PTR_ERR(dpi->pixel_clock);
30508302c35SEric Anholt 		if (ret != -EPROBE_DEFER)
30608302c35SEric Anholt 			DRM_ERROR("Failed to get pixel clock: %d\n", ret);
30708302c35SEric Anholt 		return ret;
30808302c35SEric Anholt 	}
30908302c35SEric Anholt 
31008302c35SEric Anholt 	ret = clk_prepare_enable(dpi->core_clock);
311ff5b18ceSMaxime Ripard 	if (ret) {
31208302c35SEric Anholt 		DRM_ERROR("Failed to turn on core clock: %d\n", ret);
313ff5b18ceSMaxime Ripard 		return ret;
314ff5b18ceSMaxime Ripard 	}
31508302c35SEric Anholt 
31677932adfSMaxime Ripard 	ret = devm_add_action_or_reset(dev, vc4_dpi_disable_clock, dpi);
31777932adfSMaxime Ripard 	if (ret)
31877932adfSMaxime Ripard 		return ret;
31977932adfSMaxime Ripard 
320e126d318SMaxime Ripard 	ret = drmm_encoder_init(drm, &dpi->encoder.base,
321e126d318SMaxime Ripard 				NULL,
322e126d318SMaxime Ripard 				DRM_MODE_ENCODER_DPI,
323e126d318SMaxime Ripard 				NULL);
324e126d318SMaxime Ripard 	if (ret)
325e126d318SMaxime Ripard 		return ret;
326e126d318SMaxime Ripard 
3277c9a4babSMaxime Ripard 	drm_encoder_helper_add(&dpi->encoder.base, &vc4_dpi_encoder_helper_funcs);
32808302c35SEric Anholt 
3297b1298e0SEric Anholt 	ret = vc4_dpi_init_bridge(dpi);
3307b1298e0SEric Anholt 	if (ret)
331e126d318SMaxime Ripard 		return ret;
33208302c35SEric Anholt 
33308302c35SEric Anholt 	dev_set_drvdata(dev, dpi);
33408302c35SEric Anholt 
335c9be804cSEric Anholt 	vc4_debugfs_add_regset32(drm, "dpi_regs", &dpi->regset);
336c9be804cSEric Anholt 
33708302c35SEric Anholt 	return 0;
33808302c35SEric Anholt }
33908302c35SEric Anholt 
34008302c35SEric Anholt static const struct component_ops vc4_dpi_ops = {
34108302c35SEric Anholt 	.bind   = vc4_dpi_bind,
34208302c35SEric Anholt };
34308302c35SEric Anholt 
34408302c35SEric Anholt static int vc4_dpi_dev_probe(struct platform_device *pdev)
34508302c35SEric Anholt {
34608302c35SEric Anholt 	return component_add(&pdev->dev, &vc4_dpi_ops);
34708302c35SEric Anholt }
34808302c35SEric Anholt 
34908302c35SEric Anholt static int vc4_dpi_dev_remove(struct platform_device *pdev)
35008302c35SEric Anholt {
35108302c35SEric Anholt 	component_del(&pdev->dev, &vc4_dpi_ops);
35208302c35SEric Anholt 	return 0;
35308302c35SEric Anholt }
35408302c35SEric Anholt 
35508302c35SEric Anholt struct platform_driver vc4_dpi_driver = {
35608302c35SEric Anholt 	.probe = vc4_dpi_dev_probe,
35708302c35SEric Anholt 	.remove = vc4_dpi_dev_remove,
35808302c35SEric Anholt 	.driver = {
35908302c35SEric Anholt 		.name = "vc4_dpi",
36008302c35SEric Anholt 		.of_match_table = vc4_dpi_dt_match,
36108302c35SEric Anholt 	},
36208302c35SEric Anholt };
363