1 // SPDX-License-Identifier: GPL-2.0+ 2 /* 3 * Copyright (C) 2020 Linaro Ltd 4 * Author: Sumit Semwal <sumit.semwal@linaro.org> 5 * 6 * This driver is for the DSI interface to panels using the NT36672A display driver IC 7 * from Novatek. 8 * Currently supported are the Tianma FHD+ panels found in some Xiaomi phones, including 9 * some variants of the Poco F1 phone. 10 * 11 * Panels using the Novatek NT37762A IC should add appropriate configuration per-panel and 12 * use this driver. 13 */ 14 15 #include <linux/delay.h> 16 #include <linux/kernel.h> 17 #include <linux/module.h> 18 #include <linux/of.h> 19 20 #include <linux/gpio/consumer.h> 21 #include <linux/pinctrl/consumer.h> 22 #include <linux/regulator/consumer.h> 23 24 #include <drm/drm_device.h> 25 #include <drm/drm_mipi_dsi.h> 26 #include <drm/drm_modes.h> 27 #include <drm/drm_panel.h> 28 29 #include <video/mipi_display.h> 30 31 struct nt36672a_panel_cmd { 32 const char data[2]; 33 }; 34 35 static const char * const nt36672a_regulator_names[] = { 36 "vddio", 37 "vddpos", 38 "vddneg", 39 }; 40 41 static unsigned long const nt36672a_regulator_enable_loads[] = { 42 62000, 43 100000, 44 100000 45 }; 46 47 struct nt36672a_panel_desc { 48 const struct drm_display_mode *display_mode; 49 const char *panel_name; 50 51 unsigned int width_mm; 52 unsigned int height_mm; 53 54 unsigned long mode_flags; 55 enum mipi_dsi_pixel_format format; 56 unsigned int lanes; 57 58 unsigned int num_on_cmds_1; 59 const struct nt36672a_panel_cmd *on_cmds_1; 60 unsigned int num_on_cmds_2; 61 const struct nt36672a_panel_cmd *on_cmds_2; 62 63 unsigned int num_off_cmds; 64 const struct nt36672a_panel_cmd *off_cmds; 65 }; 66 67 struct nt36672a_panel { 68 struct drm_panel base; 69 struct mipi_dsi_device *link; 70 const struct nt36672a_panel_desc *desc; 71 72 struct regulator_bulk_data supplies[ARRAY_SIZE(nt36672a_regulator_names)]; 73 74 struct gpio_desc *reset_gpio; 75 }; 76 77 static inline struct nt36672a_panel *to_nt36672a_panel(struct drm_panel *panel) 78 { 79 return container_of(panel, struct nt36672a_panel, base); 80 } 81 82 static void nt36672a_send_cmds(struct mipi_dsi_multi_context *dsi_ctx, 83 const struct nt36672a_panel_cmd *cmds, int num) 84 { 85 unsigned int i; 86 87 for (i = 0; i < num; i++) { 88 const struct nt36672a_panel_cmd *cmd = &cmds[i]; 89 90 /* cmd->data[0] is the DCS command, cmd->data[1] is the parameter */ 91 mipi_dsi_dcs_write_buffer_multi(dsi_ctx, cmd->data, sizeof(cmd->data)); 92 } 93 } 94 95 static void nt36672a_panel_power_off(struct drm_panel *panel) 96 { 97 struct nt36672a_panel *pinfo = to_nt36672a_panel(panel); 98 int ret; 99 100 gpiod_set_value(pinfo->reset_gpio, 1); 101 102 ret = regulator_bulk_disable(ARRAY_SIZE(pinfo->supplies), pinfo->supplies); 103 if (ret) 104 dev_err(panel->dev, "regulator_bulk_disable failed %d\n", ret); 105 } 106 107 static int nt36672a_panel_unprepare(struct drm_panel *panel) 108 { 109 struct nt36672a_panel *pinfo = to_nt36672a_panel(panel); 110 struct mipi_dsi_multi_context dsi_ctx = { .dsi = pinfo->link }; 111 112 /* send off cmds */ 113 nt36672a_send_cmds(&dsi_ctx, pinfo->desc->off_cmds, 114 pinfo->desc->num_off_cmds); 115 116 /* Reset error to continue with display off even if send_cmds failed */ 117 dsi_ctx.accum_err = 0; 118 mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); 119 /* Reset error to continue power-down even if display off failed */ 120 dsi_ctx.accum_err = 0; 121 122 /* 120ms delay required here as per DCS spec */ 123 msleep(120); 124 125 mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); 126 127 /* 0x3C = 60ms delay */ 128 msleep(60); 129 130 nt36672a_panel_power_off(panel); 131 132 return 0; 133 } 134 135 static int nt36672a_panel_power_on(struct nt36672a_panel *pinfo) 136 { 137 int ret; 138 139 ret = regulator_bulk_enable(ARRAY_SIZE(pinfo->supplies), pinfo->supplies); 140 if (ret < 0) 141 return ret; 142 143 /* 144 * As per downstream kernel, Reset sequence of Tianma FHD panel requires the panel to 145 * be out of reset for 10ms, followed by being held in reset for 10ms. But for Android 146 * AOSP, we needed to bump it upto 200ms otherwise we get white screen sometimes. 147 * FIXME: Try to reduce this 200ms to a lesser value. 148 */ 149 gpiod_set_value(pinfo->reset_gpio, 1); 150 msleep(200); 151 gpiod_set_value(pinfo->reset_gpio, 0); 152 msleep(200); 153 154 return 0; 155 } 156 157 static int nt36672a_panel_prepare(struct drm_panel *panel) 158 { 159 struct nt36672a_panel *pinfo = to_nt36672a_panel(panel); 160 struct mipi_dsi_multi_context dsi_ctx = { .dsi = pinfo->link }; 161 162 dsi_ctx.accum_err = nt36672a_panel_power_on(pinfo); 163 164 /* send first part of init cmds */ 165 nt36672a_send_cmds(&dsi_ctx, pinfo->desc->on_cmds_1, 166 pinfo->desc->num_on_cmds_1); 167 168 mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); 169 170 /* 0x46 = 70 ms delay */ 171 mipi_dsi_msleep(&dsi_ctx, 70); 172 173 mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); 174 175 /* Send rest of the init cmds */ 176 nt36672a_send_cmds(&dsi_ctx, pinfo->desc->on_cmds_2, 177 pinfo->desc->num_on_cmds_2); 178 179 mipi_dsi_msleep(&dsi_ctx, 120); 180 181 if (dsi_ctx.accum_err < 0) 182 gpiod_set_value(pinfo->reset_gpio, 0); 183 184 return dsi_ctx.accum_err; 185 } 186 187 static int nt36672a_panel_get_modes(struct drm_panel *panel, 188 struct drm_connector *connector) 189 { 190 struct nt36672a_panel *pinfo = to_nt36672a_panel(panel); 191 const struct drm_display_mode *m = pinfo->desc->display_mode; 192 struct drm_display_mode *mode; 193 194 mode = drm_mode_duplicate(connector->dev, m); 195 if (!mode) { 196 dev_err(panel->dev, "failed to add mode %ux%u@%u\n", m->hdisplay, 197 m->vdisplay, drm_mode_vrefresh(m)); 198 return -ENOMEM; 199 } 200 201 connector->display_info.width_mm = pinfo->desc->width_mm; 202 connector->display_info.height_mm = pinfo->desc->height_mm; 203 204 drm_mode_set_name(mode); 205 drm_mode_probed_add(connector, mode); 206 207 return 1; 208 } 209 210 static const struct drm_panel_funcs panel_funcs = { 211 .unprepare = nt36672a_panel_unprepare, 212 .prepare = nt36672a_panel_prepare, 213 .get_modes = nt36672a_panel_get_modes, 214 }; 215 216 static const struct nt36672a_panel_cmd tianma_fhd_video_on_cmds_1[] = { 217 /* skin enhancement mode */ 218 { .data = {0xFF, 0x22} }, 219 { .data = {0x00, 0x40} }, 220 { .data = {0x01, 0xC0} }, 221 { .data = {0x02, 0x40} }, 222 { .data = {0x03, 0x40} }, 223 { .data = {0x04, 0x40} }, 224 { .data = {0x05, 0x40} }, 225 { .data = {0x06, 0x40} }, 226 { .data = {0x07, 0x40} }, 227 { .data = {0x08, 0x40} }, 228 { .data = {0x09, 0x40} }, 229 { .data = {0x0A, 0x40} }, 230 { .data = {0x0B, 0x40} }, 231 { .data = {0x0C, 0x40} }, 232 { .data = {0x0D, 0x40} }, 233 { .data = {0x0E, 0x40} }, 234 { .data = {0x0F, 0x40} }, 235 { .data = {0x10, 0x40} }, 236 { .data = {0x11, 0x50} }, 237 { .data = {0x12, 0x60} }, 238 { .data = {0x13, 0x70} }, 239 { .data = {0x14, 0x58} }, 240 { .data = {0x15, 0x68} }, 241 { .data = {0x16, 0x78} }, 242 { .data = {0x17, 0x77} }, 243 { .data = {0x18, 0x39} }, 244 { .data = {0x19, 0x2D} }, 245 { .data = {0x1A, 0x2E} }, 246 { .data = {0x1B, 0x32} }, 247 { .data = {0x1C, 0x37} }, 248 { .data = {0x1D, 0x3A} }, 249 { .data = {0x1E, 0x40} }, 250 { .data = {0x1F, 0x40} }, 251 { .data = {0x20, 0x40} }, 252 { .data = {0x21, 0x40} }, 253 { .data = {0x22, 0x40} }, 254 { .data = {0x23, 0x40} }, 255 { .data = {0x24, 0x40} }, 256 { .data = {0x25, 0x40} }, 257 { .data = {0x26, 0x40} }, 258 { .data = {0x27, 0x40} }, 259 { .data = {0x28, 0x40} }, 260 { .data = {0x2D, 0x00} }, 261 { .data = {0x2F, 0x40} }, 262 { .data = {0x30, 0x40} }, 263 { .data = {0x31, 0x40} }, 264 { .data = {0x32, 0x40} }, 265 { .data = {0x33, 0x40} }, 266 { .data = {0x34, 0x40} }, 267 { .data = {0x35, 0x40} }, 268 { .data = {0x36, 0x40} }, 269 { .data = {0x37, 0x40} }, 270 { .data = {0x38, 0x40} }, 271 { .data = {0x39, 0x40} }, 272 { .data = {0x3A, 0x40} }, 273 { .data = {0x3B, 0x40} }, 274 { .data = {0x3D, 0x40} }, 275 { .data = {0x3F, 0x40} }, 276 { .data = {0x40, 0x40} }, 277 { .data = {0x41, 0x40} }, 278 { .data = {0x42, 0x40} }, 279 { .data = {0x43, 0x40} }, 280 { .data = {0x44, 0x40} }, 281 { .data = {0x45, 0x40} }, 282 { .data = {0x46, 0x40} }, 283 { .data = {0x47, 0x40} }, 284 { .data = {0x48, 0x40} }, 285 { .data = {0x49, 0x40} }, 286 { .data = {0x4A, 0x40} }, 287 { .data = {0x4B, 0x40} }, 288 { .data = {0x4C, 0x40} }, 289 { .data = {0x4D, 0x40} }, 290 { .data = {0x4E, 0x40} }, 291 { .data = {0x4F, 0x40} }, 292 { .data = {0x50, 0x40} }, 293 { .data = {0x51, 0x40} }, 294 { .data = {0x52, 0x40} }, 295 { .data = {0x53, 0x01} }, 296 { .data = {0x54, 0x01} }, 297 { .data = {0x55, 0xFE} }, 298 { .data = {0x56, 0x77} }, 299 { .data = {0x58, 0xCD} }, 300 { .data = {0x59, 0xD0} }, 301 { .data = {0x5A, 0xD0} }, 302 { .data = {0x5B, 0x50} }, 303 { .data = {0x5C, 0x50} }, 304 { .data = {0x5D, 0x50} }, 305 { .data = {0x5E, 0x50} }, 306 { .data = {0x5F, 0x50} }, 307 { .data = {0x60, 0x50} }, 308 { .data = {0x61, 0x50} }, 309 { .data = {0x62, 0x50} }, 310 { .data = {0x63, 0x50} }, 311 { .data = {0x64, 0x50} }, 312 { .data = {0x65, 0x50} }, 313 { .data = {0x66, 0x50} }, 314 { .data = {0x67, 0x50} }, 315 { .data = {0x68, 0x50} }, 316 { .data = {0x69, 0x50} }, 317 { .data = {0x6A, 0x50} }, 318 { .data = {0x6B, 0x50} }, 319 { .data = {0x6C, 0x50} }, 320 { .data = {0x6D, 0x50} }, 321 { .data = {0x6E, 0x50} }, 322 { .data = {0x6F, 0x50} }, 323 { .data = {0x70, 0x07} }, 324 { .data = {0x71, 0x00} }, 325 { .data = {0x72, 0x00} }, 326 { .data = {0x73, 0x00} }, 327 { .data = {0x74, 0x06} }, 328 { .data = {0x75, 0x0C} }, 329 { .data = {0x76, 0x03} }, 330 { .data = {0x77, 0x09} }, 331 { .data = {0x78, 0x0F} }, 332 { .data = {0x79, 0x68} }, 333 { .data = {0x7A, 0x88} }, 334 { .data = {0x7C, 0x80} }, 335 { .data = {0x7D, 0x80} }, 336 { .data = {0x7E, 0x80} }, 337 { .data = {0x7F, 0x00} }, 338 { .data = {0x80, 0x00} }, 339 { .data = {0x81, 0x00} }, 340 { .data = {0x83, 0x01} }, 341 { .data = {0x84, 0x00} }, 342 { .data = {0x85, 0x80} }, 343 { .data = {0x86, 0x80} }, 344 { .data = {0x87, 0x80} }, 345 { .data = {0x88, 0x40} }, 346 { .data = {0x89, 0x91} }, 347 { .data = {0x8A, 0x98} }, 348 { .data = {0x8B, 0x80} }, 349 { .data = {0x8C, 0x80} }, 350 { .data = {0x8D, 0x80} }, 351 { .data = {0x8E, 0x80} }, 352 { .data = {0x8F, 0x80} }, 353 { .data = {0x90, 0x80} }, 354 { .data = {0x91, 0x80} }, 355 { .data = {0x92, 0x80} }, 356 { .data = {0x93, 0x80} }, 357 { .data = {0x94, 0x80} }, 358 { .data = {0x95, 0x80} }, 359 { .data = {0x96, 0x80} }, 360 { .data = {0x97, 0x80} }, 361 { .data = {0x98, 0x80} }, 362 { .data = {0x99, 0x80} }, 363 { .data = {0x9A, 0x80} }, 364 { .data = {0x9B, 0x80} }, 365 { .data = {0x9C, 0x80} }, 366 { .data = {0x9D, 0x80} }, 367 { .data = {0x9E, 0x80} }, 368 { .data = {0x9F, 0x80} }, 369 { .data = {0xA0, 0x8A} }, 370 { .data = {0xA2, 0x80} }, 371 { .data = {0xA6, 0x80} }, 372 { .data = {0xA7, 0x80} }, 373 { .data = {0xA9, 0x80} }, 374 { .data = {0xAA, 0x80} }, 375 { .data = {0xAB, 0x80} }, 376 { .data = {0xAC, 0x80} }, 377 { .data = {0xAD, 0x80} }, 378 { .data = {0xAE, 0x80} }, 379 { .data = {0xAF, 0x80} }, 380 { .data = {0xB7, 0x76} }, 381 { .data = {0xB8, 0x76} }, 382 { .data = {0xB9, 0x05} }, 383 { .data = {0xBA, 0x0D} }, 384 { .data = {0xBB, 0x14} }, 385 { .data = {0xBC, 0x0F} }, 386 { .data = {0xBD, 0x18} }, 387 { .data = {0xBE, 0x1F} }, 388 { .data = {0xBF, 0x05} }, 389 { .data = {0xC0, 0x0D} }, 390 { .data = {0xC1, 0x14} }, 391 { .data = {0xC2, 0x03} }, 392 { .data = {0xC3, 0x07} }, 393 { .data = {0xC4, 0x0A} }, 394 { .data = {0xC5, 0xA0} }, 395 { .data = {0xC6, 0x55} }, 396 { .data = {0xC7, 0xFF} }, 397 { .data = {0xC8, 0x39} }, 398 { .data = {0xC9, 0x44} }, 399 { .data = {0xCA, 0x12} }, 400 { .data = {0xCD, 0x80} }, 401 { .data = {0xDB, 0x80} }, 402 { .data = {0xDC, 0x80} }, 403 { .data = {0xDD, 0x80} }, 404 { .data = {0xE0, 0x80} }, 405 { .data = {0xE1, 0x80} }, 406 { .data = {0xE2, 0x80} }, 407 { .data = {0xE3, 0x80} }, 408 { .data = {0xE4, 0x80} }, 409 { .data = {0xE5, 0x40} }, 410 { .data = {0xE6, 0x40} }, 411 { .data = {0xE7, 0x40} }, 412 { .data = {0xE8, 0x40} }, 413 { .data = {0xE9, 0x40} }, 414 { .data = {0xEA, 0x40} }, 415 { .data = {0xEB, 0x40} }, 416 { .data = {0xEC, 0x40} }, 417 { .data = {0xED, 0x40} }, 418 { .data = {0xEE, 0x40} }, 419 { .data = {0xEF, 0x40} }, 420 { .data = {0xF0, 0x40} }, 421 { .data = {0xF1, 0x40} }, 422 { .data = {0xF2, 0x40} }, 423 { .data = {0xF3, 0x40} }, 424 { .data = {0xF4, 0x40} }, 425 { .data = {0xF5, 0x40} }, 426 { .data = {0xF6, 0x40} }, 427 { .data = {0xFB, 0x1} }, 428 { .data = {0xFF, 0x23} }, 429 { .data = {0xFB, 0x01} }, 430 /* dimming enable */ 431 { .data = {0x01, 0x84} }, 432 { .data = {0x05, 0x2D} }, 433 { .data = {0x06, 0x00} }, 434 /* resolution 1080*2246 */ 435 { .data = {0x11, 0x01} }, 436 { .data = {0x12, 0x7B} }, 437 { .data = {0x15, 0x6F} }, 438 { .data = {0x16, 0x0B} }, 439 /* UI mode */ 440 { .data = {0x29, 0x0A} }, 441 { .data = {0x30, 0xFF} }, 442 { .data = {0x31, 0xFF} }, 443 { .data = {0x32, 0xFF} }, 444 { .data = {0x33, 0xFF} }, 445 { .data = {0x34, 0xFF} }, 446 { .data = {0x35, 0xFF} }, 447 { .data = {0x36, 0xFF} }, 448 { .data = {0x37, 0xFF} }, 449 { .data = {0x38, 0xFC} }, 450 { .data = {0x39, 0xF8} }, 451 { .data = {0x3A, 0xF4} }, 452 { .data = {0x3B, 0xF1} }, 453 { .data = {0x3D, 0xEE} }, 454 { .data = {0x3F, 0xEB} }, 455 { .data = {0x40, 0xE8} }, 456 { .data = {0x41, 0xE5} }, 457 /* STILL mode */ 458 { .data = {0x2A, 0x13} }, 459 { .data = {0x45, 0xFF} }, 460 { .data = {0x46, 0xFF} }, 461 { .data = {0x47, 0xFF} }, 462 { .data = {0x48, 0xFF} }, 463 { .data = {0x49, 0xFF} }, 464 { .data = {0x4A, 0xFF} }, 465 { .data = {0x4B, 0xFF} }, 466 { .data = {0x4C, 0xFF} }, 467 { .data = {0x4D, 0xED} }, 468 { .data = {0x4E, 0xD5} }, 469 { .data = {0x4F, 0xBF} }, 470 { .data = {0x50, 0xA6} }, 471 { .data = {0x51, 0x96} }, 472 { .data = {0x52, 0x86} }, 473 { .data = {0x53, 0x76} }, 474 { .data = {0x54, 0x66} }, 475 /* MOVING mode */ 476 { .data = {0x2B, 0x0E} }, 477 { .data = {0x58, 0xFF} }, 478 { .data = {0x59, 0xFF} }, 479 { .data = {0x5A, 0xFF} }, 480 { .data = {0x5B, 0xFF} }, 481 { .data = {0x5C, 0xFF} }, 482 { .data = {0x5D, 0xFF} }, 483 { .data = {0x5E, 0xFF} }, 484 { .data = {0x5F, 0xFF} }, 485 { .data = {0x60, 0xF6} }, 486 { .data = {0x61, 0xEA} }, 487 { .data = {0x62, 0xE1} }, 488 { .data = {0x63, 0xD8} }, 489 { .data = {0x64, 0xCE} }, 490 { .data = {0x65, 0xC3} }, 491 { .data = {0x66, 0xBA} }, 492 { .data = {0x67, 0xB3} }, 493 { .data = {0xFF, 0x25} }, 494 { .data = {0xFB, 0x01} }, 495 { .data = {0x05, 0x04} }, 496 { .data = {0xFF, 0x26} }, 497 { .data = {0xFB, 0x01} }, 498 { .data = {0x1C, 0xAF} }, 499 { .data = {0xFF, 0x10} }, 500 { .data = {0xFB, 0x01} }, 501 { .data = {0x51, 0xFF} }, 502 { .data = {0x53, 0x24} }, 503 { .data = {0x55, 0x00} }, 504 }; 505 506 static const struct nt36672a_panel_cmd tianma_fhd_video_on_cmds_2[] = { 507 { .data = {0xFF, 0x24} }, 508 { .data = {0xFB, 0x01} }, 509 { .data = {0xC3, 0x01} }, 510 { .data = {0xC4, 0x54} }, 511 { .data = {0xFF, 0x10} }, 512 }; 513 514 static const struct nt36672a_panel_cmd tianma_fhd_video_off_cmds[] = { 515 { .data = {0xFF, 0x24} }, 516 { .data = {0xFB, 0x01} }, 517 { .data = {0xC3, 0x01} }, 518 { .data = {0xFF, 0x10} }, 519 }; 520 521 static const struct drm_display_mode tianma_fhd_video_panel_default_mode = { 522 .clock = 161331, 523 524 .hdisplay = 1080, 525 .hsync_start = 1080 + 40, 526 .hsync_end = 1080 + 40 + 20, 527 .htotal = 1080 + 40 + 20 + 44, 528 529 .vdisplay = 2246, 530 .vsync_start = 2246 + 15, 531 .vsync_end = 2246 + 15 + 2, 532 .vtotal = 2246 + 15 + 2 + 8, 533 534 .type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED, 535 }; 536 537 static const struct nt36672a_panel_desc tianma_fhd_video_panel_desc = { 538 .display_mode = &tianma_fhd_video_panel_default_mode, 539 540 .width_mm = 68, 541 .height_mm = 136, 542 543 .mode_flags = MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_VIDEO 544 | MIPI_DSI_MODE_VIDEO_HSE 545 | MIPI_DSI_CLOCK_NON_CONTINUOUS 546 | MIPI_DSI_MODE_VIDEO_BURST, 547 .format = MIPI_DSI_FMT_RGB888, 548 .lanes = 4, 549 .on_cmds_1 = tianma_fhd_video_on_cmds_1, 550 .num_on_cmds_1 = ARRAY_SIZE(tianma_fhd_video_on_cmds_1), 551 .on_cmds_2 = tianma_fhd_video_on_cmds_2, 552 .num_on_cmds_2 = ARRAY_SIZE(tianma_fhd_video_on_cmds_2), 553 .off_cmds = tianma_fhd_video_off_cmds, 554 .num_off_cmds = ARRAY_SIZE(tianma_fhd_video_off_cmds), 555 }; 556 557 static int nt36672a_panel_add(struct nt36672a_panel *pinfo) 558 { 559 struct device *dev = &pinfo->link->dev; 560 int i, ret; 561 562 for (i = 0; i < ARRAY_SIZE(pinfo->supplies); i++) { 563 pinfo->supplies[i].supply = nt36672a_regulator_names[i]; 564 pinfo->supplies[i].init_load_uA = nt36672a_regulator_enable_loads[i]; 565 } 566 567 ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(pinfo->supplies), 568 pinfo->supplies); 569 if (ret < 0) 570 return dev_err_probe(dev, ret, "failed to get regulators\n"); 571 572 pinfo->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); 573 if (IS_ERR(pinfo->reset_gpio)) 574 return dev_err_probe(dev, PTR_ERR(pinfo->reset_gpio), 575 "failed to get reset gpio from DT\n"); 576 577 ret = drm_panel_of_backlight(&pinfo->base); 578 if (ret) 579 return dev_err_probe(dev, ret, "Failed to get backlight\n"); 580 581 drm_panel_add(&pinfo->base); 582 583 return 0; 584 } 585 586 static int nt36672a_panel_probe(struct mipi_dsi_device *dsi) 587 { 588 struct nt36672a_panel *pinfo; 589 const struct nt36672a_panel_desc *desc; 590 int err; 591 592 pinfo = devm_drm_panel_alloc(&dsi->dev, __typeof(*pinfo), base, 593 &panel_funcs, DRM_MODE_CONNECTOR_DSI); 594 595 if (IS_ERR(pinfo)) 596 return PTR_ERR(pinfo); 597 598 desc = of_device_get_match_data(&dsi->dev); 599 dsi->mode_flags = desc->mode_flags; 600 dsi->format = desc->format; 601 dsi->lanes = desc->lanes; 602 pinfo->desc = desc; 603 pinfo->link = dsi; 604 605 mipi_dsi_set_drvdata(dsi, pinfo); 606 607 err = nt36672a_panel_add(pinfo); 608 if (err < 0) 609 return err; 610 611 err = mipi_dsi_attach(dsi); 612 if (err < 0) { 613 drm_panel_remove(&pinfo->base); 614 return err; 615 } 616 617 return 0; 618 } 619 620 static void nt36672a_panel_remove(struct mipi_dsi_device *dsi) 621 { 622 struct nt36672a_panel *pinfo = mipi_dsi_get_drvdata(dsi); 623 int err; 624 625 err = mipi_dsi_detach(dsi); 626 if (err < 0) 627 dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err); 628 629 drm_panel_remove(&pinfo->base); 630 } 631 632 static const struct of_device_id tianma_fhd_video_of_match[] = { 633 { .compatible = "tianma,fhd-video", .data = &tianma_fhd_video_panel_desc }, 634 { }, 635 }; 636 MODULE_DEVICE_TABLE(of, tianma_fhd_video_of_match); 637 638 static struct mipi_dsi_driver nt36672a_panel_driver = { 639 .driver = { 640 .name = "panel-tianma-nt36672a", 641 .of_match_table = tianma_fhd_video_of_match, 642 }, 643 .probe = nt36672a_panel_probe, 644 .remove = nt36672a_panel_remove, 645 }; 646 module_mipi_dsi_driver(nt36672a_panel_driver); 647 648 MODULE_AUTHOR("Sumit Semwal <sumit.semwal@linaro.org>"); 649 MODULE_DESCRIPTION("NOVATEK NT36672A based MIPI-DSI LCD panel driver"); 650 MODULE_LICENSE("GPL"); 651