xref: /linux/drivers/gpu/drm/i915/display/intel_display_driver.c (revision fd5a9b950ea8ba2c08ce07418b36b296a04d712b)
1 // SPDX-License-Identifier: MIT
2 /*
3  * Copyright © 2022-2023 Intel Corporation
4  *
5  * High level display driver entry points. This is a layer between top level
6  * driver code and low level display functionality; no low level display code or
7  * details here.
8  */
9 
10 #include <linux/vga_switcheroo.h>
11 #include <acpi/video.h>
12 #include <drm/display/drm_dp_mst_helper.h>
13 #include <drm/drm_atomic_helper.h>
14 #include <drm/drm_client.h>
15 #include <drm/drm_mode_config.h>
16 #include <drm/drm_privacy_screen_consumer.h>
17 #include <drm/drm_probe_helper.h>
18 #include <drm/drm_vblank.h>
19 
20 #include "i915_drv.h"
21 #include "i9xx_wm.h"
22 #include "intel_acpi.h"
23 #include "intel_atomic.h"
24 #include "intel_audio.h"
25 #include "intel_bios.h"
26 #include "intel_bw.h"
27 #include "intel_cdclk.h"
28 #include "intel_color.h"
29 #include "intel_crtc.h"
30 #include "intel_display_debugfs.h"
31 #include "intel_display_driver.h"
32 #include "intel_display_irq.h"
33 #include "intel_display_power.h"
34 #include "intel_display_types.h"
35 #include "intel_display_wa.h"
36 #include "intel_dkl_phy.h"
37 #include "intel_dmc.h"
38 #include "intel_dp.h"
39 #include "intel_dp_tunnel.h"
40 #include "intel_dpll.h"
41 #include "intel_dpll_mgr.h"
42 #include "intel_fb.h"
43 #include "intel_fbc.h"
44 #include "intel_fbdev.h"
45 #include "intel_fdi.h"
46 #include "intel_gmbus.h"
47 #include "intel_hdcp.h"
48 #include "intel_hotplug.h"
49 #include "intel_hti.h"
50 #include "intel_modeset_lock.h"
51 #include "intel_modeset_setup.h"
52 #include "intel_opregion.h"
53 #include "intel_overlay.h"
54 #include "intel_plane_initial.h"
55 #include "intel_pmdemand.h"
56 #include "intel_pps.h"
57 #include "intel_quirks.h"
58 #include "intel_vga.h"
59 #include "intel_wm.h"
60 #include "skl_watermark.h"
61 
62 bool intel_display_driver_probe_defer(struct pci_dev *pdev)
63 {
64 	struct drm_privacy_screen *privacy_screen;
65 
66 	/*
67 	 * apple-gmux is needed on dual GPU MacBook Pro
68 	 * to probe the panel if we're the inactive GPU.
69 	 */
70 	if (vga_switcheroo_client_probe_defer(pdev))
71 		return true;
72 
73 	/* If the LCD panel has a privacy-screen, wait for it */
74 	privacy_screen = drm_privacy_screen_get(&pdev->dev, NULL);
75 	if (IS_ERR(privacy_screen) && PTR_ERR(privacy_screen) == -EPROBE_DEFER)
76 		return true;
77 
78 	drm_privacy_screen_put(privacy_screen);
79 
80 	return false;
81 }
82 
83 void intel_display_driver_init_hw(struct drm_i915_private *i915)
84 {
85 	struct intel_cdclk_state *cdclk_state;
86 
87 	if (!HAS_DISPLAY(i915))
88 		return;
89 
90 	cdclk_state = to_intel_cdclk_state(i915->display.cdclk.obj.state);
91 
92 	intel_update_cdclk(i915);
93 	intel_cdclk_dump_config(i915, &i915->display.cdclk.hw, "Current CDCLK");
94 	cdclk_state->logical = cdclk_state->actual = i915->display.cdclk.hw;
95 
96 	intel_display_wa_apply(i915);
97 }
98 
99 static const struct drm_mode_config_funcs intel_mode_funcs = {
100 	.fb_create = intel_user_framebuffer_create,
101 	.get_format_info = intel_fb_get_format_info,
102 	.mode_valid = intel_mode_valid,
103 	.atomic_check = intel_atomic_check,
104 	.atomic_commit = intel_atomic_commit,
105 	.atomic_state_alloc = intel_atomic_state_alloc,
106 	.atomic_state_clear = intel_atomic_state_clear,
107 	.atomic_state_free = intel_atomic_state_free,
108 };
109 
110 static const struct drm_mode_config_helper_funcs intel_mode_config_funcs = {
111 	.atomic_commit_setup = drm_dp_mst_atomic_setup_commit,
112 };
113 
114 static void intel_mode_config_init(struct drm_i915_private *i915)
115 {
116 	struct drm_mode_config *mode_config = &i915->drm.mode_config;
117 
118 	drm_mode_config_init(&i915->drm);
119 	INIT_LIST_HEAD(&i915->display.global.obj_list);
120 
121 	mode_config->min_width = 0;
122 	mode_config->min_height = 0;
123 
124 	mode_config->preferred_depth = 24;
125 	mode_config->prefer_shadow = 1;
126 
127 	mode_config->funcs = &intel_mode_funcs;
128 	mode_config->helper_private = &intel_mode_config_funcs;
129 
130 	mode_config->async_page_flip = HAS_ASYNC_FLIPS(i915);
131 
132 	/*
133 	 * Maximum framebuffer dimensions, chosen to match
134 	 * the maximum render engine surface size on gen4+.
135 	 */
136 	if (DISPLAY_VER(i915) >= 7) {
137 		mode_config->max_width = 16384;
138 		mode_config->max_height = 16384;
139 	} else if (DISPLAY_VER(i915) >= 4) {
140 		mode_config->max_width = 8192;
141 		mode_config->max_height = 8192;
142 	} else if (DISPLAY_VER(i915) == 3) {
143 		mode_config->max_width = 4096;
144 		mode_config->max_height = 4096;
145 	} else {
146 		mode_config->max_width = 2048;
147 		mode_config->max_height = 2048;
148 	}
149 
150 	if (IS_I845G(i915) || IS_I865G(i915)) {
151 		mode_config->cursor_width = IS_I845G(i915) ? 64 : 512;
152 		mode_config->cursor_height = 1023;
153 	} else if (IS_I830(i915) || IS_I85X(i915) ||
154 		   IS_I915G(i915) || IS_I915GM(i915)) {
155 		mode_config->cursor_width = 64;
156 		mode_config->cursor_height = 64;
157 	} else {
158 		mode_config->cursor_width = 256;
159 		mode_config->cursor_height = 256;
160 	}
161 }
162 
163 static void intel_mode_config_cleanup(struct drm_i915_private *i915)
164 {
165 	intel_atomic_global_obj_cleanup(i915);
166 	drm_mode_config_cleanup(&i915->drm);
167 }
168 
169 static void intel_plane_possible_crtcs_init(struct drm_i915_private *dev_priv)
170 {
171 	struct intel_plane *plane;
172 
173 	for_each_intel_plane(&dev_priv->drm, plane) {
174 		struct intel_crtc *crtc = intel_crtc_for_pipe(dev_priv,
175 							      plane->pipe);
176 
177 		plane->base.possible_crtcs = drm_crtc_mask(&crtc->base);
178 	}
179 }
180 
181 void intel_display_driver_early_probe(struct drm_i915_private *i915)
182 {
183 	if (!HAS_DISPLAY(i915))
184 		return;
185 
186 	spin_lock_init(&i915->display.fb_tracking.lock);
187 	mutex_init(&i915->display.backlight.lock);
188 	mutex_init(&i915->display.audio.mutex);
189 	mutex_init(&i915->display.wm.wm_mutex);
190 	mutex_init(&i915->display.pps.mutex);
191 	mutex_init(&i915->display.hdcp.hdcp_mutex);
192 
193 	intel_display_irq_init(i915);
194 	intel_dkl_phy_init(i915);
195 	intel_color_init_hooks(i915);
196 	intel_init_cdclk_hooks(i915);
197 	intel_audio_hooks_init(i915);
198 	intel_dpll_init_clock_hook(i915);
199 	intel_init_display_hooks(i915);
200 	intel_fdi_init_hook(i915);
201 	intel_dmc_wl_init(&i915->display);
202 }
203 
204 /* part #1: call before irq install */
205 int intel_display_driver_probe_noirq(struct drm_i915_private *i915)
206 {
207 	struct intel_display *display = &i915->display;
208 	int ret;
209 
210 	if (i915_inject_probe_failure(i915))
211 		return -ENODEV;
212 
213 	if (HAS_DISPLAY(i915)) {
214 		ret = drm_vblank_init(&i915->drm,
215 				      INTEL_NUM_PIPES(i915));
216 		if (ret)
217 			return ret;
218 	}
219 
220 	intel_bios_init(i915);
221 
222 	ret = intel_vga_register(i915);
223 	if (ret)
224 		goto cleanup_bios;
225 
226 	/* FIXME: completely on the wrong abstraction layer */
227 	ret = intel_power_domains_init(i915);
228 	if (ret < 0)
229 		goto cleanup_vga;
230 
231 	intel_pmdemand_init_early(i915);
232 
233 	intel_power_domains_init_hw(i915, false);
234 
235 	if (!HAS_DISPLAY(i915))
236 		return 0;
237 
238 	intel_dmc_init(i915);
239 
240 	i915->display.wq.modeset = alloc_ordered_workqueue("i915_modeset", 0);
241 	i915->display.wq.flip = alloc_workqueue("i915_flip", WQ_HIGHPRI |
242 						WQ_UNBOUND, WQ_UNBOUND_MAX_ACTIVE);
243 
244 	intel_mode_config_init(i915);
245 
246 	ret = intel_cdclk_init(i915);
247 	if (ret)
248 		goto cleanup_vga_client_pw_domain_dmc;
249 
250 	ret = intel_color_init(i915);
251 	if (ret)
252 		goto cleanup_vga_client_pw_domain_dmc;
253 
254 	ret = intel_dbuf_init(i915);
255 	if (ret)
256 		goto cleanup_vga_client_pw_domain_dmc;
257 
258 	ret = intel_bw_init(i915);
259 	if (ret)
260 		goto cleanup_vga_client_pw_domain_dmc;
261 
262 	ret = intel_pmdemand_init(i915);
263 	if (ret)
264 		goto cleanup_vga_client_pw_domain_dmc;
265 
266 	intel_init_quirks(display);
267 
268 	intel_fbc_init(display);
269 
270 	return 0;
271 
272 cleanup_vga_client_pw_domain_dmc:
273 	intel_dmc_fini(i915);
274 	intel_power_domains_driver_remove(i915);
275 cleanup_vga:
276 	intel_vga_unregister(i915);
277 cleanup_bios:
278 	intel_bios_driver_remove(i915);
279 
280 	return ret;
281 }
282 
283 static void set_display_access(struct drm_i915_private *i915,
284 			       bool any_task_allowed,
285 			       struct task_struct *allowed_task)
286 {
287 	struct drm_modeset_acquire_ctx ctx;
288 	int err;
289 
290 	intel_modeset_lock_ctx_retry(&ctx, NULL, 0, err) {
291 		err = drm_modeset_lock_all_ctx(&i915->drm, &ctx);
292 		if (err)
293 			continue;
294 
295 		i915->display.access.any_task_allowed = any_task_allowed;
296 		i915->display.access.allowed_task = allowed_task;
297 	}
298 
299 	drm_WARN_ON(&i915->drm, err);
300 }
301 
302 /**
303  * intel_display_driver_enable_user_access - Enable display HW access for all threads
304  * @i915: i915 device instance
305  *
306  * Enable the display HW access for all threads. Examples for such accesses
307  * are modeset commits and connector probing.
308  *
309  * This function should be called during driver loading and system resume once
310  * all the HW initialization steps are done.
311  */
312 void intel_display_driver_enable_user_access(struct drm_i915_private *i915)
313 {
314 	set_display_access(i915, true, NULL);
315 
316 	intel_hpd_enable_detection_work(i915);
317 }
318 
319 /**
320  * intel_display_driver_disable_user_access - Disable display HW access for user threads
321  * @i915: i915 device instance
322  *
323  * Disable the display HW access for user threads. Examples for such accesses
324  * are modeset commits and connector probing. For the current thread the
325  * access is still enabled, which should only perform HW init/deinit
326  * programming (as the initial modeset during driver loading or the disabling
327  * modeset during driver unloading and system suspend/shutdown). This function
328  * should be followed by calling either intel_display_driver_enable_user_access()
329  * after completing the HW init programming or
330  * intel_display_driver_suspend_access() after completing the HW deinit
331  * programming.
332  *
333  * This function should be called during driver loading/unloading and system
334  * suspend/shutdown before starting the HW init/deinit programming.
335  */
336 void intel_display_driver_disable_user_access(struct drm_i915_private *i915)
337 {
338 	intel_hpd_disable_detection_work(i915);
339 
340 	set_display_access(i915, false, current);
341 }
342 
343 /**
344  * intel_display_driver_suspend_access - Suspend display HW access for all threads
345  * @i915: i915 device instance
346  *
347  * Disable the display HW access for all threads. Examples for such accesses
348  * are modeset commits and connector probing. This call should be either
349  * followed by calling intel_display_driver_resume_access(), or the driver
350  * should be unloaded/shutdown.
351  *
352  * This function should be called during driver unloading and system
353  * suspend/shutdown after completing the HW deinit programming.
354  */
355 void intel_display_driver_suspend_access(struct drm_i915_private *i915)
356 {
357 	set_display_access(i915, false, NULL);
358 }
359 
360 /**
361  * intel_display_driver_resume_access - Resume display HW access for the resume thread
362  * @i915: i915 device instance
363  *
364  * Enable the display HW access for the current resume thread, keeping the
365  * access disabled for all other (user) threads. Examples for such accesses
366  * are modeset commits and connector probing. The resume thread should only
367  * perform HW init programming (as the restoring modeset). This function
368  * should be followed by calling intel_display_driver_enable_user_access(),
369  * after completing the HW init programming steps.
370  *
371  * This function should be called during system resume before starting the HW
372  * init steps.
373  */
374 void intel_display_driver_resume_access(struct drm_i915_private *i915)
375 {
376 	set_display_access(i915, false, current);
377 }
378 
379 /**
380  * intel_display_driver_check_access - Check if the current thread has disaplay HW access
381  * @i915: i915 device instance
382  *
383  * Check whether the current thread has display HW access, print a debug
384  * message if it doesn't. Such accesses are modeset commits and connector
385  * probing. If the function returns %false any HW access should be prevented.
386  *
387  * Returns %true if the current thread has display HW access, %false
388  * otherwise.
389  */
390 bool intel_display_driver_check_access(struct drm_i915_private *i915)
391 {
392 	char comm[TASK_COMM_LEN];
393 	char current_task[TASK_COMM_LEN + 16];
394 	char allowed_task[TASK_COMM_LEN + 16] = "none";
395 
396 	if (i915->display.access.any_task_allowed ||
397 	    i915->display.access.allowed_task == current)
398 		return true;
399 
400 	snprintf(current_task, sizeof(current_task), "%s[%d]",
401 		 get_task_comm(comm, current),
402 		 task_pid_vnr(current));
403 
404 	if (i915->display.access.allowed_task)
405 		snprintf(allowed_task, sizeof(allowed_task), "%s[%d]",
406 			 get_task_comm(comm, i915->display.access.allowed_task),
407 			 task_pid_vnr(i915->display.access.allowed_task));
408 
409 	drm_dbg_kms(&i915->drm,
410 		    "Reject display access from task %s (allowed to %s)\n",
411 		    current_task, allowed_task);
412 
413 	return false;
414 }
415 
416 /* part #2: call after irq install, but before gem init */
417 int intel_display_driver_probe_nogem(struct drm_i915_private *i915)
418 {
419 	struct drm_device *dev = &i915->drm;
420 	enum pipe pipe;
421 	int ret;
422 
423 	if (!HAS_DISPLAY(i915))
424 		return 0;
425 
426 	intel_wm_init(i915);
427 
428 	intel_panel_sanitize_ssc(i915);
429 
430 	intel_pps_setup(i915);
431 
432 	intel_gmbus_setup(i915);
433 
434 	drm_dbg_kms(&i915->drm, "%d display pipe%s available.\n",
435 		    INTEL_NUM_PIPES(i915),
436 		    INTEL_NUM_PIPES(i915) > 1 ? "s" : "");
437 
438 	for_each_pipe(i915, pipe) {
439 		ret = intel_crtc_init(i915, pipe);
440 		if (ret)
441 			goto err_mode_config;
442 	}
443 
444 	intel_plane_possible_crtcs_init(i915);
445 	intel_shared_dpll_init(i915);
446 	intel_fdi_pll_freq_update(i915);
447 
448 	intel_update_czclk(i915);
449 	intel_display_driver_init_hw(i915);
450 	intel_dpll_update_ref_clks(i915);
451 
452 	if (i915->display.cdclk.max_cdclk_freq == 0)
453 		intel_update_max_cdclk(i915);
454 
455 	intel_hti_init(i915);
456 
457 	/* Just disable it once at startup */
458 	intel_vga_disable(i915);
459 	intel_setup_outputs(i915);
460 
461 	ret = intel_dp_tunnel_mgr_init(i915);
462 	if (ret)
463 		goto err_hdcp;
464 
465 	intel_display_driver_disable_user_access(i915);
466 
467 	drm_modeset_lock_all(dev);
468 	intel_modeset_setup_hw_state(i915, dev->mode_config.acquire_ctx);
469 	intel_acpi_assign_connector_fwnodes(i915);
470 	drm_modeset_unlock_all(dev);
471 
472 	intel_initial_plane_config(i915);
473 
474 	/*
475 	 * Make sure hardware watermarks really match the state we read out.
476 	 * Note that we need to do this after reconstructing the BIOS fb's
477 	 * since the watermark calculation done here will use pstate->fb.
478 	 */
479 	if (!HAS_GMCH(i915))
480 		ilk_wm_sanitize(i915);
481 
482 	return 0;
483 
484 err_hdcp:
485 	intel_hdcp_component_fini(i915);
486 err_mode_config:
487 	intel_mode_config_cleanup(i915);
488 
489 	return ret;
490 }
491 
492 /* part #3: call after gem init */
493 int intel_display_driver_probe(struct drm_i915_private *i915)
494 {
495 	int ret;
496 
497 	if (!HAS_DISPLAY(i915))
498 		return 0;
499 
500 	/*
501 	 * This will bind stuff into ggtt, so it needs to be done after
502 	 * the BIOS fb takeover and whatever else magic ggtt reservations
503 	 * happen during gem/ggtt init.
504 	 */
505 	intel_hdcp_component_init(i915);
506 
507 	/*
508 	 * Force all active planes to recompute their states. So that on
509 	 * mode_setcrtc after probe, all the intel_plane_state variables
510 	 * are already calculated and there is no assert_plane warnings
511 	 * during bootup.
512 	 */
513 	ret = intel_initial_commit(&i915->drm);
514 	if (ret)
515 		drm_dbg_kms(&i915->drm, "Initial modeset failed, %d\n", ret);
516 
517 	intel_overlay_setup(i915);
518 
519 	/* Only enable hotplug handling once the fbdev is fully set up. */
520 	intel_hpd_init(i915);
521 
522 	skl_watermark_ipc_init(i915);
523 
524 	return 0;
525 }
526 
527 void intel_display_driver_register(struct drm_i915_private *i915)
528 {
529 	struct drm_printer p = drm_dbg_printer(&i915->drm, DRM_UT_KMS,
530 					       "i915 display info:");
531 
532 	if (!HAS_DISPLAY(i915))
533 		return;
534 
535 	/* Must be done after probing outputs */
536 	intel_opregion_register(i915);
537 	intel_acpi_video_register(i915);
538 
539 	intel_audio_init(i915);
540 
541 	intel_display_driver_enable_user_access(i915);
542 
543 	intel_audio_register(i915);
544 
545 	intel_display_debugfs_register(i915);
546 
547 	/*
548 	 * We need to coordinate the hotplugs with the asynchronous
549 	 * fbdev configuration, for which we use the
550 	 * fbdev->async_cookie.
551 	 */
552 	drm_kms_helper_poll_init(&i915->drm);
553 	intel_hpd_poll_disable(i915);
554 
555 	intel_fbdev_setup(i915);
556 
557 	intel_display_device_info_print(DISPLAY_INFO(i915),
558 					DISPLAY_RUNTIME_INFO(i915), &p);
559 }
560 
561 /* part #1: call before irq uninstall */
562 void intel_display_driver_remove(struct drm_i915_private *i915)
563 {
564 	if (!HAS_DISPLAY(i915))
565 		return;
566 
567 	flush_workqueue(i915->display.wq.flip);
568 	flush_workqueue(i915->display.wq.modeset);
569 
570 	/*
571 	 * MST topology needs to be suspended so we don't have any calls to
572 	 * fbdev after it's finalized. MST will be destroyed later as part of
573 	 * drm_mode_config_cleanup()
574 	 */
575 	intel_dp_mst_suspend(i915);
576 }
577 
578 /* part #2: call after irq uninstall */
579 void intel_display_driver_remove_noirq(struct drm_i915_private *i915)
580 {
581 	if (!HAS_DISPLAY(i915))
582 		return;
583 
584 	intel_display_driver_suspend_access(i915);
585 
586 	/*
587 	 * Due to the hpd irq storm handling the hotplug work can re-arm the
588 	 * poll handlers. Hence disable polling after hpd handling is shut down.
589 	 */
590 	intel_hpd_poll_fini(i915);
591 
592 	intel_unregister_dsm_handler();
593 
594 	/* flush any delayed tasks or pending work */
595 	flush_workqueue(i915->unordered_wq);
596 
597 	intel_hdcp_component_fini(i915);
598 
599 	intel_mode_config_cleanup(i915);
600 
601 	intel_dp_tunnel_mgr_cleanup(i915);
602 
603 	intel_overlay_cleanup(i915);
604 
605 	intel_gmbus_teardown(i915);
606 
607 	destroy_workqueue(i915->display.wq.flip);
608 	destroy_workqueue(i915->display.wq.modeset);
609 
610 	intel_fbc_cleanup(&i915->display);
611 }
612 
613 /* part #3: call after gem init */
614 void intel_display_driver_remove_nogem(struct drm_i915_private *i915)
615 {
616 	intel_dmc_fini(i915);
617 
618 	intel_power_domains_driver_remove(i915);
619 
620 	intel_vga_unregister(i915);
621 
622 	intel_bios_driver_remove(i915);
623 }
624 
625 void intel_display_driver_unregister(struct drm_i915_private *i915)
626 {
627 	if (!HAS_DISPLAY(i915))
628 		return;
629 
630 	drm_client_dev_unregister(&i915->drm);
631 
632 	/*
633 	 * After flushing the fbdev (incl. a late async config which
634 	 * will have delayed queuing of a hotplug event), then flush
635 	 * the hotplug events.
636 	 */
637 	drm_kms_helper_poll_fini(&i915->drm);
638 
639 	intel_display_driver_disable_user_access(i915);
640 
641 	intel_audio_deinit(i915);
642 
643 	drm_atomic_helper_shutdown(&i915->drm);
644 
645 	acpi_video_unregister();
646 	intel_opregion_unregister(i915);
647 }
648 
649 /*
650  * turn all crtc's off, but do not adjust state
651  * This has to be paired with a call to intel_modeset_setup_hw_state.
652  */
653 int intel_display_driver_suspend(struct drm_i915_private *i915)
654 {
655 	struct drm_atomic_state *state;
656 	int ret;
657 
658 	if (!HAS_DISPLAY(i915))
659 		return 0;
660 
661 	state = drm_atomic_helper_suspend(&i915->drm);
662 	ret = PTR_ERR_OR_ZERO(state);
663 	if (ret)
664 		drm_err(&i915->drm, "Suspending crtc's failed with %i\n",
665 			ret);
666 	else
667 		i915->display.restore.modeset_state = state;
668 	return ret;
669 }
670 
671 int
672 __intel_display_driver_resume(struct drm_i915_private *i915,
673 			      struct drm_atomic_state *state,
674 			      struct drm_modeset_acquire_ctx *ctx)
675 {
676 	struct drm_crtc_state *crtc_state;
677 	struct drm_crtc *crtc;
678 	int ret, i;
679 
680 	intel_modeset_setup_hw_state(i915, ctx);
681 	intel_vga_redisable(i915);
682 
683 	if (!state)
684 		return 0;
685 
686 	/*
687 	 * We've duplicated the state, pointers to the old state are invalid.
688 	 *
689 	 * Don't attempt to use the old state until we commit the duplicated state.
690 	 */
691 	for_each_new_crtc_in_state(state, crtc, crtc_state, i) {
692 		/*
693 		 * Force recalculation even if we restore
694 		 * current state. With fast modeset this may not result
695 		 * in a modeset when the state is compatible.
696 		 */
697 		crtc_state->mode_changed = true;
698 	}
699 
700 	/* ignore any reset values/BIOS leftovers in the WM registers */
701 	if (!HAS_GMCH(i915))
702 		to_intel_atomic_state(state)->skip_intermediate_wm = true;
703 
704 	ret = drm_atomic_helper_commit_duplicated_state(state, ctx);
705 
706 	drm_WARN_ON(&i915->drm, ret == -EDEADLK);
707 
708 	return ret;
709 }
710 
711 void intel_display_driver_resume(struct drm_i915_private *i915)
712 {
713 	struct drm_atomic_state *state = i915->display.restore.modeset_state;
714 	struct drm_modeset_acquire_ctx ctx;
715 	int ret;
716 
717 	if (!HAS_DISPLAY(i915))
718 		return;
719 
720 	i915->display.restore.modeset_state = NULL;
721 	if (state)
722 		state->acquire_ctx = &ctx;
723 
724 	drm_modeset_acquire_init(&ctx, 0);
725 
726 	while (1) {
727 		ret = drm_modeset_lock_all_ctx(&i915->drm, &ctx);
728 		if (ret != -EDEADLK)
729 			break;
730 
731 		drm_modeset_backoff(&ctx);
732 	}
733 
734 	if (!ret)
735 		ret = __intel_display_driver_resume(i915, state, &ctx);
736 
737 	skl_watermark_ipc_update(i915);
738 	drm_modeset_drop_locks(&ctx);
739 	drm_modeset_acquire_fini(&ctx);
740 
741 	if (ret)
742 		drm_err(&i915->drm,
743 			"Restoring old state failed with %i\n", ret);
744 	if (state)
745 		drm_atomic_state_put(state);
746 }
747