1 /* 2 * Copyright (c) 2014 Samsung Electronics Co., Ltd 3 * 4 * Permission is hereby granted, free of charge, to any person obtaining a 5 * copy of this software and associated documentation files (the "Software"), 6 * to deal in the Software without restriction, including without limitation 7 * the rights to use, copy, modify, merge, publish, distribute, sub license, 8 * and/or sell copies of the Software, and to permit persons to whom the 9 * Software is furnished to do so, subject to the following conditions: 10 * 11 * The above copyright notice and this permission notice (including the 12 * next paragraph) shall be included in all copies or substantial portions 13 * of the Software. 14 * 15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 17 * FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL 18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER 19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 20 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER 21 * DEALINGS IN THE SOFTWARE. 22 */ 23 24 #include <linux/debugfs.h> 25 #include <linux/err.h> 26 #include <linux/export.h> 27 #include <linux/media-bus-format.h> 28 #include <linux/module.h> 29 #include <linux/mutex.h> 30 #include <linux/srcu.h> 31 32 #include <drm/drm_atomic_state_helper.h> 33 #include <drm/drm_bridge.h> 34 #include <drm/drm_debugfs.h> 35 #include <drm/drm_edid.h> 36 #include <drm/drm_encoder.h> 37 #include <drm/drm_file.h> 38 #include <drm/drm_of.h> 39 #include <drm/drm_print.h> 40 41 #include "drm_crtc_internal.h" 42 43 /** 44 * DOC: overview 45 * 46 * &struct drm_bridge represents a device that hangs on to an encoder. These are 47 * handy when a regular &drm_encoder entity isn't enough to represent the entire 48 * encoder chain. 49 * 50 * A bridge is always attached to a single &drm_encoder at a time, but can be 51 * either connected to it directly, or through a chain of bridges:: 52 * 53 * [ CRTC ---> ] Encoder ---> Bridge A ---> Bridge B 54 * 55 * Here, the output of the encoder feeds to bridge A, and that furthers feeds to 56 * bridge B. Bridge chains can be arbitrarily long, and shall be fully linear: 57 * Chaining multiple bridges to the output of a bridge, or the same bridge to 58 * the output of different bridges, is not supported. 59 * 60 * &drm_bridge, like &drm_panel, aren't &drm_mode_object entities like planes, 61 * CRTCs, encoders or connectors and hence are not visible to userspace. They 62 * just provide additional hooks to get the desired output at the end of the 63 * encoder chain. 64 */ 65 66 /** 67 * DOC: display driver integration 68 * 69 * Display drivers are responsible for linking encoders with the first bridge 70 * in the chains. This is done by acquiring the appropriate bridge with 71 * devm_drm_of_get_bridge(). Once acquired, the bridge shall be attached to the 72 * encoder with a call to drm_bridge_attach(). 73 * 74 * Bridges are responsible for linking themselves with the next bridge in the 75 * chain, if any. This is done the same way as for encoders, with the call to 76 * drm_bridge_attach() occurring in the &drm_bridge_funcs.attach operation. 77 * 78 * Once these links are created, the bridges can participate along with encoder 79 * functions to perform mode validation and fixup (through 80 * drm_bridge_chain_mode_valid() and drm_atomic_bridge_chain_check()), mode 81 * setting (through drm_bridge_chain_mode_set()), enable (through 82 * drm_atomic_bridge_chain_pre_enable() and drm_atomic_bridge_chain_enable()) 83 * and disable (through drm_atomic_bridge_chain_disable() and 84 * drm_atomic_bridge_chain_post_disable()). Those functions call the 85 * corresponding operations provided in &drm_bridge_funcs in sequence for all 86 * bridges in the chain. 87 * 88 * For display drivers that use the atomic helpers 89 * drm_atomic_helper_check_modeset(), 90 * drm_atomic_helper_commit_modeset_enables() and 91 * drm_atomic_helper_commit_modeset_disables() (either directly in hand-rolled 92 * commit check and commit tail handlers, or through the higher-level 93 * drm_atomic_helper_check() and drm_atomic_helper_commit_tail() or 94 * drm_atomic_helper_commit_tail_rpm() helpers), this is done transparently and 95 * requires no intervention from the driver. For other drivers, the relevant 96 * DRM bridge chain functions shall be called manually. 97 * 98 * Bridges also participate in implementing the &drm_connector at the end of 99 * the bridge chain. Display drivers may use the drm_bridge_connector_init() 100 * helper to create the &drm_connector, or implement it manually on top of the 101 * connector-related operations exposed by the bridge (see the overview 102 * documentation of bridge operations for more details). 103 */ 104 105 /** 106 * DOC: special care dsi 107 * 108 * The interaction between the bridges and other frameworks involved in 109 * the probing of the upstream driver and the bridge driver can be 110 * challenging. Indeed, there's multiple cases that needs to be 111 * considered: 112 * 113 * - The upstream driver doesn't use the component framework and isn't a 114 * MIPI-DSI host. In this case, the bridge driver will probe at some 115 * point and the upstream driver should try to probe again by returning 116 * EPROBE_DEFER as long as the bridge driver hasn't probed. 117 * 118 * - The upstream driver doesn't use the component framework, but is a 119 * MIPI-DSI host. The bridge device uses the MIPI-DCS commands to be 120 * controlled. In this case, the bridge device is a child of the 121 * display device and when it will probe it's assured that the display 122 * device (and MIPI-DSI host) is present. The upstream driver will be 123 * assured that the bridge driver is connected between the 124 * &mipi_dsi_host_ops.attach and &mipi_dsi_host_ops.detach operations. 125 * Therefore, it must run mipi_dsi_host_register() in its probe 126 * function, and then run drm_bridge_attach() in its 127 * &mipi_dsi_host_ops.attach hook. 128 * 129 * - The upstream driver uses the component framework and is a MIPI-DSI 130 * host. The bridge device uses the MIPI-DCS commands to be 131 * controlled. This is the same situation than above, and can run 132 * mipi_dsi_host_register() in either its probe or bind hooks. 133 * 134 * - The upstream driver uses the component framework and is a MIPI-DSI 135 * host. The bridge device uses a separate bus (such as I2C) to be 136 * controlled. In this case, there's no correlation between the probe 137 * of the bridge and upstream drivers, so care must be taken to avoid 138 * an endless EPROBE_DEFER loop, with each driver waiting for the 139 * other to probe. 140 * 141 * The ideal pattern to cover the last item (and all the others in the 142 * MIPI-DSI host driver case) is to split the operations like this: 143 * 144 * - The MIPI-DSI host driver must run mipi_dsi_host_register() in its 145 * probe hook. It will make sure that the MIPI-DSI host sticks around, 146 * and that the driver's bind can be called. 147 * 148 * - In its probe hook, the bridge driver must try to find its MIPI-DSI 149 * host, register as a MIPI-DSI device and attach the MIPI-DSI device 150 * to its host. The bridge driver is now functional. 151 * 152 * - In its &struct mipi_dsi_host_ops.attach hook, the MIPI-DSI host can 153 * now add its component. Its bind hook will now be called and since 154 * the bridge driver is attached and registered, we can now look for 155 * and attach it. 156 * 157 * At this point, we're now certain that both the upstream driver and 158 * the bridge driver are functional and we can't have a deadlock-like 159 * situation when probing. 160 */ 161 162 /** 163 * DOC: dsi bridge operations 164 * 165 * DSI host interfaces are expected to be implemented as bridges rather than 166 * encoders, however there are a few aspects of their operation that need to 167 * be defined in order to provide a consistent interface. 168 * 169 * A DSI host should keep the PHY powered down until the pre_enable operation is 170 * called. All lanes are in an undefined idle state up to this point, and it 171 * must not be assumed that it is LP-11. 172 * pre_enable should initialise the PHY, set the data lanes to LP-11, and the 173 * clock lane to either LP-11 or HS depending on the mode_flag 174 * %MIPI_DSI_CLOCK_NON_CONTINUOUS. 175 * 176 * Ordinarily the downstream bridge DSI peripheral pre_enable will have been 177 * called before the DSI host. If the DSI peripheral requires LP-11 and/or 178 * the clock lane to be in HS mode prior to pre_enable, then it can set the 179 * &pre_enable_prev_first flag to request the pre_enable (and 180 * post_disable) order to be altered to enable the DSI host first. 181 * 182 * Either the CRTC being enabled, or the DSI host enable operation should switch 183 * the host to actively transmitting video on the data lanes. 184 * 185 * The reverse also applies. The DSI host disable operation or stopping the CRTC 186 * should stop transmitting video, and the data lanes should return to the LP-11 187 * state. The DSI host &post_disable operation should disable the PHY. 188 * If the &pre_enable_prev_first flag is set, then the DSI peripheral's 189 * bridge &post_disable will be called before the DSI host's post_disable. 190 * 191 * Whilst it is valid to call &host_transfer prior to pre_enable or after 192 * post_disable, the exact state of the lanes is undefined at this point. The 193 * DSI host should initialise the interface, transmit the data, and then disable 194 * the interface again. 195 * 196 * Ultra Low Power State (ULPS) is not explicitly supported by DRM. If 197 * implemented, it therefore needs to be handled entirely within the DSI Host 198 * driver. 199 */ 200 201 /** 202 * DOC: bridge chain format selection 203 * 204 * A bridge chain, from display output processor to connector, may contain 205 * bridges capable of converting between bus formats on their inputs, and 206 * output formats on their outputs. For example, a bridge may be able to convert 207 * from RGB to YCbCr 4:4:4, and pass through YCbCr 4:2:0 as-is, but not convert 208 * from RGB to YCbCr 4:2:0. This means not all input formats map to all output 209 * formats. 210 * 211 * Further adding to this, a desired output color format, as specified with the 212 * "color format" DRM property, might not correspond 1:1 to what the display 213 * driver should set at its output. The bridge chain it feeds into may only be 214 * able to reach the desired output format, if a conversion from a different 215 * starting format is performed. 216 * 217 * To deal with this complexity, the recursive bridge chain bus format selection 218 * logic starts with the last bridge in the chain, usually the connector, and 219 * then recursively walks the chain of bridges backwards to the first bridge, 220 * trying to find a path. 221 * 222 * For a display driver to work in such a scenario, it should read the first 223 * bridge's bridge state to figure out which bus format the chain resolved to. 224 * If the first bridge's input format resolved to %MEDIA_BUS_FMT_FIXED, then its 225 * output format should be used. 226 * 227 * Special handling is done for HDMI as it relates to format selection. Instead 228 * of directly using the "color format" DRM property for bridge chains that end 229 * in HDMI bridges, the bridge chain format selection logic will trust the logic 230 * that set the HDMI output format. For the common HDMI state helper 231 * functionality, this means that %DRM_CONNECTOR_COLOR_FORMAT_AUTO will allow 232 * fallbacks to YCBCr 4:2:0 if the bandwidth requirements would otherwise be too 233 * high but the mode and connector allow it. 234 * 235 * For bridge chains that do not end in an HDMI bridge, 236 * %DRM_CONNECTOR_COLOR_FORMAT_AUTO will be satisfied with the first output 237 * format on the last bridge for which it can find a path back to the first 238 * bridge. 239 */ 240 241 /* Protect bridge_list and bridge_lingering_list */ 242 static DEFINE_MUTEX(bridge_lock); 243 static LIST_HEAD(bridge_list); 244 static LIST_HEAD(bridge_lingering_list); 245 246 DEFINE_STATIC_SRCU(drm_bridge_unplug_srcu); 247 248 /** 249 * drm_bridge_enter - Enter DRM bridge critical section 250 * @bridge: DRM bridge 251 * @idx: Pointer to index that will be passed to the matching drm_bridge_exit() 252 * 253 * This function marks and protects the beginning of a section that should not 254 * be entered after the bridge has been unplugged. The section end is marked 255 * with drm_bridge_exit(). Calls to this function can be nested. 256 * 257 * Returns: 258 * True if it is OK to enter the section, false otherwise. 259 */ 260 bool drm_bridge_enter(struct drm_bridge *bridge, int *idx) 261 { 262 *idx = srcu_read_lock(&drm_bridge_unplug_srcu); 263 264 if (bridge->unplugged) { 265 srcu_read_unlock(&drm_bridge_unplug_srcu, *idx); 266 return false; 267 } 268 269 return true; 270 } 271 EXPORT_SYMBOL(drm_bridge_enter); 272 273 /** 274 * drm_bridge_exit - Exit DRM bridge critical section 275 * @idx: index returned by drm_bridge_enter() 276 * 277 * This function marks the end of a section that should not be entered after 278 * the bridge has been unplugged. 279 */ 280 void drm_bridge_exit(int idx) 281 { 282 srcu_read_unlock(&drm_bridge_unplug_srcu, idx); 283 } 284 EXPORT_SYMBOL(drm_bridge_exit); 285 286 /** 287 * drm_bridge_unplug - declare a DRM bridge was unplugged and remove it 288 * @bridge: DRM bridge 289 * 290 * This tells the bridge has been physically unplugged and no operations on 291 * device resources must be done anymore. Entry-points can use 292 * drm_bridge_enter() and drm_bridge_exit() to protect device resources in 293 * a race free manner. 294 * 295 * Also unregisters the bridge. 296 */ 297 void drm_bridge_unplug(struct drm_bridge *bridge) 298 { 299 bridge->unplugged = true; 300 301 synchronize_srcu(&drm_bridge_unplug_srcu); 302 303 drm_bridge_remove(bridge); 304 } 305 EXPORT_SYMBOL(drm_bridge_unplug); 306 307 static void __drm_bridge_free(struct kref *kref) 308 { 309 struct drm_bridge *bridge = container_of(kref, struct drm_bridge, refcount); 310 311 mutex_lock(&bridge_lock); 312 list_del(&bridge->list); 313 mutex_unlock(&bridge_lock); 314 315 if (bridge->funcs->destroy) 316 bridge->funcs->destroy(bridge); 317 318 drm_bridge_put(bridge->next_bridge); 319 320 kfree(bridge->container); 321 } 322 323 /** 324 * drm_bridge_get - Acquire a bridge reference 325 * @bridge: DRM bridge; if NULL this function does nothing 326 * 327 * This function increments the bridge's refcount. 328 * 329 * Returns: 330 * Pointer to @bridge. 331 */ 332 struct drm_bridge *drm_bridge_get(struct drm_bridge *bridge) 333 { 334 if (bridge) 335 kref_get(&bridge->refcount); 336 337 return bridge; 338 } 339 EXPORT_SYMBOL(drm_bridge_get); 340 341 /** 342 * drm_bridge_put - Release a bridge reference 343 * @bridge: DRM bridge; if NULL or an ERR_PTR this function does nothing 344 * 345 * This function decrements the bridge's reference count and frees the 346 * object if the reference count drops to zero. 347 * 348 * See also drm_bridge_clear_and_put() if you also need to set the pointer 349 * to NULL 350 */ 351 void drm_bridge_put(struct drm_bridge *bridge) 352 { 353 if (!IS_ERR_OR_NULL(bridge)) 354 kref_put(&bridge->refcount, __drm_bridge_free); 355 } 356 EXPORT_SYMBOL(drm_bridge_put); 357 358 /** 359 * drm_bridge_clear_and_put - Given a bridge pointer, clear the pointer 360 * then put the bridge 361 * @bridge_pp: pointer to pointer to a struct drm_bridge; ``bridge_pp`` 362 * must be non-NULL; if ``*bridge_pp`` is NULL this function 363 * does nothing 364 * 365 * Helper to put a DRM bridge, but only after setting its pointer to 366 * NULL. Useful when a struct drm_bridge reference must be dropped without 367 * leaving a use-after-free window where the pointed bridge might have been 368 * freed while still holding a pointer to it. 369 * 370 * For struct ``drm_bridge *some_bridge``, this code:: 371 * 372 * drm_bridge_clear_and_put(&some_bridge); 373 * 374 * is equivalent to the more complex:: 375 * 376 * struct drm_bridge *temp = some_bridge; 377 * some_bridge = NULL; 378 * drm_bridge_put(temp); 379 */ 380 void drm_bridge_clear_and_put(struct drm_bridge **bridge_pp) 381 { 382 struct drm_bridge *bridge = *bridge_pp; 383 384 *bridge_pp = NULL; 385 drm_bridge_put(bridge); 386 } 387 EXPORT_SYMBOL(drm_bridge_clear_and_put); 388 389 /** 390 * drm_bridge_put_void - wrapper to drm_bridge_put() taking a void pointer 391 * 392 * @data: pointer to @struct drm_bridge, cast to a void pointer 393 * 394 * Wrapper of drm_bridge_put() to be used when a function taking a void 395 * pointer is needed, for example as a devm action. 396 */ 397 static void drm_bridge_put_void(void *data) 398 { 399 struct drm_bridge *bridge = (struct drm_bridge *)data; 400 401 drm_bridge_put(bridge); 402 } 403 404 void *__devm_drm_bridge_alloc(struct device *dev, size_t size, size_t offset, 405 const struct drm_bridge_funcs *funcs) 406 { 407 void *container; 408 struct drm_bridge *bridge; 409 int err; 410 411 if (!funcs) { 412 dev_warn(dev, "Missing funcs pointer\n"); 413 return ERR_PTR(-EINVAL); 414 } 415 416 container = kzalloc(size, GFP_KERNEL); 417 if (!container) 418 return ERR_PTR(-ENOMEM); 419 420 bridge = container + offset; 421 INIT_LIST_HEAD(&bridge->list); 422 bridge->container = container; 423 bridge->funcs = funcs; 424 kref_init(&bridge->refcount); 425 426 err = devm_add_action_or_reset(dev, drm_bridge_put_void, bridge); 427 if (err) 428 return ERR_PTR(err); 429 430 return container; 431 } 432 EXPORT_SYMBOL(__devm_drm_bridge_alloc); 433 434 /** 435 * drm_bridge_add - register a bridge 436 * 437 * @bridge: bridge control structure 438 * 439 * Add the given bridge to the global list of bridges, where they can be 440 * found by users via of_drm_find_and_get_bridge(). 441 * 442 * The bridge to be added must have been allocated by 443 * devm_drm_bridge_alloc(). 444 */ 445 void drm_bridge_add(struct drm_bridge *bridge) 446 { 447 if (!bridge->container) 448 DRM_WARN("DRM bridge corrupted or not allocated by devm_drm_bridge_alloc()\n"); 449 450 drm_bridge_get(bridge); 451 452 /* 453 * If the bridge was previously added and then removed, it is now 454 * in bridge_lingering_list. Remove it or bridge_lingering_list will be 455 * corrupted when adding this bridge to bridge_list below. 456 */ 457 if (!list_empty(&bridge->list)) 458 list_del_init(&bridge->list); 459 460 mutex_init(&bridge->hpd_state_mutex); 461 mutex_init(&bridge->hpd_mutex); 462 463 if (bridge->ops & DRM_BRIDGE_OP_HDMI) 464 bridge->ycbcr_420_allowed = !!(bridge->supported_formats & 465 BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR420)); 466 467 mutex_lock(&bridge_lock); 468 list_add_tail(&bridge->list, &bridge_list); 469 mutex_unlock(&bridge_lock); 470 } 471 EXPORT_SYMBOL(drm_bridge_add); 472 473 static void drm_bridge_remove_void(void *bridge) 474 { 475 drm_bridge_remove(bridge); 476 } 477 478 /** 479 * devm_drm_bridge_add - devm managed version of drm_bridge_add() 480 * 481 * @dev: device to tie the bridge lifetime to 482 * @bridge: bridge control structure 483 * 484 * This is the managed version of drm_bridge_add() which automatically 485 * calls drm_bridge_remove() when @dev is unbound. 486 * 487 * Return: 0 if no error or negative error code. 488 */ 489 int devm_drm_bridge_add(struct device *dev, struct drm_bridge *bridge) 490 { 491 drm_bridge_add(bridge); 492 return devm_add_action_or_reset(dev, drm_bridge_remove_void, bridge); 493 } 494 EXPORT_SYMBOL(devm_drm_bridge_add); 495 496 /** 497 * drm_bridge_remove - unregister a bridge 498 * 499 * @bridge: bridge control structure 500 * 501 * Remove the given bridge from the global list of registered bridges, so 502 * it won't be found by users via of_drm_find_and_get_bridge(), and add it 503 * to the lingering bridge list, to keep track of it until its allocated 504 * memory is eventually freed. 505 */ 506 void drm_bridge_remove(struct drm_bridge *bridge) 507 { 508 mutex_lock(&bridge_lock); 509 list_move_tail(&bridge->list, &bridge_lingering_list); 510 mutex_unlock(&bridge_lock); 511 512 mutex_destroy(&bridge->hpd_mutex); 513 mutex_destroy(&bridge->hpd_state_mutex); 514 515 drm_bridge_put(bridge); 516 } 517 EXPORT_SYMBOL(drm_bridge_remove); 518 519 static struct drm_private_state * 520 drm_bridge_atomic_duplicate_priv_state(struct drm_private_obj *obj) 521 { 522 struct drm_bridge *bridge = drm_priv_to_bridge(obj); 523 struct drm_bridge_state *state; 524 525 state = bridge->funcs->atomic_duplicate_state(bridge); 526 return state ? &state->base : NULL; 527 } 528 529 static void 530 drm_bridge_atomic_destroy_priv_state(struct drm_private_obj *obj, 531 struct drm_private_state *s) 532 { 533 struct drm_bridge_state *state = drm_priv_to_bridge_state(s); 534 struct drm_bridge *bridge = drm_priv_to_bridge(obj); 535 536 bridge->funcs->atomic_destroy_state(bridge, state); 537 } 538 539 static struct drm_private_state * 540 drm_bridge_atomic_create_priv_state(struct drm_private_obj *obj) 541 { 542 struct drm_bridge *bridge = drm_priv_to_bridge(obj); 543 struct drm_bridge_state *state; 544 545 state = bridge->funcs->atomic_create_state(bridge); 546 if (IS_ERR(state)) 547 return ERR_CAST(state); 548 549 return &state->base; 550 } 551 552 static const struct drm_private_state_funcs drm_bridge_priv_state_funcs = { 553 .atomic_create_state = drm_bridge_atomic_create_priv_state, 554 .atomic_duplicate_state = drm_bridge_atomic_duplicate_priv_state, 555 .atomic_destroy_state = drm_bridge_atomic_destroy_priv_state, 556 }; 557 558 /** 559 * drm_bridge_attach - attach the bridge to an encoder's chain 560 * 561 * @encoder: DRM encoder 562 * @bridge: bridge to attach 563 * @previous: previous bridge in the chain (optional) 564 * @flags: DRM_BRIDGE_ATTACH_* flags 565 * 566 * Called by a kms driver to link the bridge to an encoder's chain. The previous 567 * argument specifies the previous bridge in the chain. If NULL, the bridge is 568 * linked directly at the encoder's output. Otherwise it is linked at the 569 * previous bridge's output. 570 * 571 * If non-NULL the previous bridge must be already attached by a call to this 572 * function. 573 * 574 * The bridge to be attached must have been previously added by 575 * drm_bridge_add(). 576 * 577 * Note that bridges attached to encoders are auto-detached during encoder 578 * cleanup in drm_encoder_cleanup(), so drm_bridge_attach() should generally 579 * *not* be balanced with a drm_bridge_detach() in driver code. 580 * 581 * RETURNS: 582 * Zero on success, error code on failure 583 */ 584 int drm_bridge_attach(struct drm_encoder *encoder, struct drm_bridge *bridge, 585 struct drm_bridge *previous, 586 enum drm_bridge_attach_flags flags) 587 { 588 int ret; 589 590 if (!encoder || !bridge) 591 return -EINVAL; 592 593 if (!bridge->container) 594 DRM_WARN("DRM bridge corrupted or not allocated by devm_drm_bridge_alloc()\n"); 595 596 if (list_empty(&bridge->list)) 597 DRM_WARN("Missing drm_bridge_add() before attach\n"); 598 599 drm_bridge_get(bridge); 600 601 if (previous && (!previous->dev || previous->encoder != encoder)) { 602 ret = -EINVAL; 603 goto err_put_bridge; 604 } 605 606 if (bridge->dev) { 607 ret = -EBUSY; 608 goto err_put_bridge; 609 } 610 611 bridge->dev = encoder->dev; 612 bridge->encoder = encoder; 613 614 mutex_lock(&encoder->bridge_chain_mutex); 615 if (previous) 616 list_add(&bridge->chain_node, &previous->chain_node); 617 else 618 list_add(&bridge->chain_node, &encoder->bridge_chain); 619 mutex_unlock(&encoder->bridge_chain_mutex); 620 621 if (bridge->funcs->attach) { 622 ret = bridge->funcs->attach(bridge, encoder, flags); 623 if (ret < 0) 624 goto err_reset_bridge; 625 } 626 627 drm_atomic_private_obj_init(bridge->dev, &bridge->base, 628 &drm_bridge_priv_state_funcs); 629 630 return 0; 631 632 err_reset_bridge: 633 bridge->dev = NULL; 634 bridge->encoder = NULL; 635 mutex_lock(&encoder->bridge_chain_mutex); 636 list_del(&bridge->chain_node); 637 mutex_unlock(&encoder->bridge_chain_mutex); 638 639 if (ret != -EPROBE_DEFER) 640 DRM_ERROR("failed to attach bridge %pOF to encoder %s: %d\n", 641 bridge->of_node, encoder->name, ret); 642 else 643 dev_err_probe(encoder->dev->dev, -EPROBE_DEFER, 644 "failed to attach bridge %pOF to encoder %s\n", 645 bridge->of_node, encoder->name); 646 647 err_put_bridge: 648 drm_bridge_put(bridge); 649 return ret; 650 } 651 EXPORT_SYMBOL(drm_bridge_attach); 652 653 void drm_bridge_detach(struct drm_bridge *bridge) 654 { 655 if (WARN_ON(!bridge)) 656 return; 657 658 if (WARN_ON(!bridge->dev)) 659 return; 660 661 drm_atomic_private_obj_fini(&bridge->base); 662 663 if (bridge->funcs->detach) 664 bridge->funcs->detach(bridge); 665 666 list_del(&bridge->chain_node); 667 bridge->dev = NULL; 668 drm_bridge_put(bridge); 669 } 670 671 /** 672 * DOC: bridge operations 673 * 674 * Bridge drivers expose operations through the &drm_bridge_funcs structure. 675 * The DRM internals (atomic and CRTC helpers) use the helpers defined in 676 * drm_bridge.c to call bridge operations. Those operations are divided in 677 * three big categories to support different parts of the bridge usage. 678 * 679 * - The encoder-related operations support control of the bridges in the 680 * chain, and are roughly counterparts to the &drm_encoder_helper_funcs 681 * operations. They are used by the legacy CRTC and the atomic modeset 682 * helpers to perform mode validation, fixup and setting, and enable and 683 * disable the bridge automatically. 684 * 685 * The enable and disable operations are split in 686 * &drm_bridge_funcs.atomic_pre_enable, &drm_bridge_funcs.atomic_enable, 687 * &drm_bridge_funcs.atomic_disable and &drm_bridge_funcs.atomic_post_disable 688 * to provide finer-grained control. 689 * 690 * Bridge drivers may implement the legacy version of those operations, or 691 * the atomic version (prefixed with atomic\_), in which case they shall also 692 * implement the atomic state bookkeeping operations 693 * (&drm_bridge_funcs.atomic_duplicate_state, 694 * &drm_bridge_funcs.atomic_destroy_state and &drm_bridge_funcs.reset). 695 * Mixing atomic and non-atomic versions of the operations is not supported. 696 * 697 * - The bus format negotiation operations 698 * &drm_bridge_funcs.atomic_get_output_bus_fmts and 699 * &drm_bridge_funcs.atomic_get_input_bus_fmts allow bridge drivers to 700 * negotiate the formats transmitted between bridges in the chain when 701 * multiple formats are supported. Negotiation for formats is performed 702 * transparently for display drivers by the atomic modeset helpers. Only 703 * atomic versions of those operations exist, bridge drivers that need to 704 * implement them shall thus also implement the atomic version of the 705 * encoder-related operations. This feature is not supported by the legacy 706 * CRTC helpers. 707 * 708 * - The connector-related operations support implementing a &drm_connector 709 * based on a chain of bridges. DRM bridges traditionally create a 710 * &drm_connector for bridges meant to be used at the end of the chain. This 711 * puts additional burden on bridge drivers, especially for bridges that may 712 * be used in the middle of a chain or at the end of it. Furthermore, it 713 * requires all operations of the &drm_connector to be handled by a single 714 * bridge, which doesn't always match the hardware architecture. 715 * 716 * To simplify bridge drivers and make the connector implementation more 717 * flexible, a new model allows bridges to unconditionally skip creation of 718 * &drm_connector and instead expose &drm_bridge_funcs operations to support 719 * an externally-implemented &drm_connector. Those operations are 720 * &drm_bridge_funcs.detect, &drm_bridge_funcs.get_modes, 721 * &drm_bridge_funcs.get_edid, &drm_bridge_funcs.hpd_notify, 722 * &drm_bridge_funcs.hpd_enable and &drm_bridge_funcs.hpd_disable. When 723 * implemented, display drivers shall create a &drm_connector instance for 724 * each chain of bridges, and implement those connector instances based on 725 * the bridge connector operations. 726 * 727 * Bridge drivers shall implement the connector-related operations for all 728 * the features that the bridge hardware support. For instance, if a bridge 729 * supports reading EDID, the &drm_bridge_funcs.get_edid shall be 730 * implemented. This however doesn't mean that the DDC lines are wired to the 731 * bridge on a particular platform, as they could also be connected to an I2C 732 * controller of the SoC. Support for the connector-related operations on the 733 * running platform is reported through the &drm_bridge.ops flags. Bridge 734 * drivers shall detect which operations they can support on the platform 735 * (usually this information is provided by ACPI or DT), and set the 736 * &drm_bridge.ops flags for all supported operations. A flag shall only be 737 * set if the corresponding &drm_bridge_funcs operation is implemented, but 738 * an implemented operation doesn't necessarily imply that the corresponding 739 * flag will be set. Display drivers shall use the &drm_bridge.ops flags to 740 * decide which bridge to delegate a connector operation to. This mechanism 741 * allows providing a single static const &drm_bridge_funcs instance in 742 * bridge drivers, improving security by storing function pointers in 743 * read-only memory. 744 * 745 * In order to ease transition, bridge drivers may support both the old and 746 * new models by making connector creation optional and implementing the 747 * connected-related bridge operations. Connector creation is then controlled 748 * by the flags argument to the drm_bridge_attach() function. Display drivers 749 * that support the new model and create connectors themselves shall set the 750 * %DRM_BRIDGE_ATTACH_NO_CONNECTOR flag, and bridge drivers shall then skip 751 * connector creation. For intermediate bridges in the chain, the flag shall 752 * be passed to the drm_bridge_attach() call for the downstream bridge. 753 * Bridge drivers that implement the new model only shall return an error 754 * from their &drm_bridge_funcs.attach handler when the 755 * %DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is not set. New display drivers 756 * should use the new model, and convert the bridge drivers they use if 757 * needed, in order to gradually transition to the new model. 758 */ 759 760 /** 761 * drm_bridge_chain_mode_valid - validate the mode against all bridges in the 762 * encoder chain. 763 * @first_bridge: bridge control structure 764 * @info: display info against which the mode shall be validated 765 * @mode: desired mode to be validated 766 * 767 * Calls &drm_bridge_funcs.mode_valid for all the bridges in the encoder 768 * chain, starting from the first bridge to the last. If at least one bridge 769 * does not accept the mode the function returns the error code. 770 * 771 * Note: the bridge passed should be the one closest to the encoder. 772 * 773 * RETURNS: 774 * MODE_OK on success, drm_mode_status Enum error code on failure 775 */ 776 enum drm_mode_status 777 drm_bridge_chain_mode_valid(struct drm_bridge *first_bridge, 778 const struct drm_display_info *info, 779 const struct drm_display_mode *mode) 780 { 781 if (!first_bridge) 782 return MODE_OK; 783 784 drm_for_each_bridge_in_chain_from(first_bridge, bridge) { 785 enum drm_mode_status ret; 786 787 if (!bridge->funcs->mode_valid) 788 continue; 789 790 ret = bridge->funcs->mode_valid(bridge, info, mode); 791 if (ret != MODE_OK) 792 return ret; 793 } 794 795 return MODE_OK; 796 } 797 EXPORT_SYMBOL(drm_bridge_chain_mode_valid); 798 799 /** 800 * drm_bridge_chain_mode_set - set proposed mode for all bridges in the 801 * encoder chain 802 * @first_bridge: bridge control structure 803 * @mode: desired mode to be set for the encoder chain 804 * @adjusted_mode: updated mode that works for this encoder chain 805 * 806 * Calls &drm_bridge_funcs.mode_set op for all the bridges in the 807 * encoder chain, starting from the first bridge to the last. 808 * 809 * Note: the bridge passed should be the one closest to the encoder 810 */ 811 void drm_bridge_chain_mode_set(struct drm_bridge *first_bridge, 812 const struct drm_display_mode *mode, 813 const struct drm_display_mode *adjusted_mode) 814 { 815 if (!first_bridge) 816 return; 817 818 drm_for_each_bridge_in_chain_from(first_bridge, bridge) 819 if (bridge->funcs->mode_set) 820 bridge->funcs->mode_set(bridge, mode, adjusted_mode); 821 } 822 EXPORT_SYMBOL(drm_bridge_chain_mode_set); 823 824 /** 825 * drm_atomic_bridge_chain_disable - disables all bridges in the encoder chain 826 * @bridge: bridge control structure 827 * @state: atomic state being committed 828 * 829 * Calls &drm_bridge_funcs.atomic_disable op for all the bridges in the encoder 830 * chain, starting from the last bridge to the first. These are called before 831 * calling &drm_encoder_helper_funcs.atomic_disable 832 * 833 * Note: the bridge passed should be the one closest to the encoder 834 */ 835 void drm_atomic_bridge_chain_disable(struct drm_bridge *bridge, 836 struct drm_atomic_commit *state) 837 { 838 struct drm_encoder *encoder; 839 struct drm_bridge *iter; 840 841 if (!bridge) 842 return; 843 844 encoder = bridge->encoder; 845 mutex_lock(&encoder->bridge_chain_mutex); 846 list_for_each_entry_reverse(iter, &encoder->bridge_chain, chain_node) { 847 if (iter->funcs->atomic_disable) 848 iter->funcs->atomic_disable(iter, state); 849 850 if (iter == bridge) 851 break; 852 } 853 mutex_unlock(&encoder->bridge_chain_mutex); 854 } 855 EXPORT_SYMBOL(drm_atomic_bridge_chain_disable); 856 857 static void drm_atomic_bridge_call_post_disable(struct drm_bridge *bridge, 858 struct drm_atomic_commit *state) 859 { 860 if (state && bridge->funcs->atomic_post_disable) 861 bridge->funcs->atomic_post_disable(bridge, state); 862 } 863 864 /** 865 * drm_atomic_bridge_chain_post_disable - cleans up after disabling all bridges 866 * in the encoder chain 867 * @bridge: bridge control structure 868 * @state: atomic state being committed 869 * 870 * Calls &drm_bridge_funcs.atomic_post_disable op for all the bridges in the 871 * encoder chain, starting from the first bridge to the last. These are called 872 * after completing &drm_encoder_helper_funcs.atomic_disable 873 * 874 * If a bridge sets @pre_enable_prev_first, then the @post_disable for that 875 * bridge will be called before the previous one to reverse the @pre_enable 876 * calling direction. 877 * 878 * Example: 879 * Bridge A ---> Bridge B ---> Bridge C ---> Bridge D ---> Bridge E 880 * 881 * With pre_enable_prev_first flag enable in Bridge B, D, E then the resulting 882 * @post_disable order would be, 883 * Bridge B, Bridge A, Bridge E, Bridge D, Bridge C. 884 * 885 * Note: the bridge passed should be the one closest to the encoder 886 */ 887 void drm_atomic_bridge_chain_post_disable(struct drm_bridge *bridge, 888 struct drm_atomic_commit *state) 889 { 890 struct drm_encoder *encoder; 891 struct drm_bridge *next, *limit; 892 893 if (!bridge) 894 return; 895 896 encoder = bridge->encoder; 897 898 mutex_lock(&encoder->bridge_chain_mutex); 899 list_for_each_entry_from(bridge, &encoder->bridge_chain, chain_node) { 900 limit = NULL; 901 902 if (!list_is_last(&bridge->chain_node, &encoder->bridge_chain)) { 903 next = list_next_entry(bridge, chain_node); 904 905 if (next->pre_enable_prev_first) { 906 /* next bridge had requested that prev 907 * was enabled first, so disabled last 908 */ 909 limit = next; 910 911 /* Find the next bridge that has NOT requested 912 * prev to be enabled first / disabled last 913 */ 914 list_for_each_entry_from(next, &encoder->bridge_chain, 915 chain_node) { 916 if (!next->pre_enable_prev_first) { 917 next = list_prev_entry(next, chain_node); 918 limit = next; 919 break; 920 } 921 922 if (list_is_last(&next->chain_node, 923 &encoder->bridge_chain)) { 924 limit = next; 925 break; 926 } 927 } 928 929 /* Call these bridges in reverse order */ 930 list_for_each_entry_from_reverse(next, &encoder->bridge_chain, 931 chain_node) { 932 if (next == bridge) 933 break; 934 935 drm_atomic_bridge_call_post_disable(next, 936 state); 937 } 938 } 939 } 940 941 drm_atomic_bridge_call_post_disable(bridge, state); 942 943 if (limit) 944 /* Jump all bridges that we have already post_disabled */ 945 bridge = limit; 946 } 947 mutex_unlock(&encoder->bridge_chain_mutex); 948 } 949 EXPORT_SYMBOL(drm_atomic_bridge_chain_post_disable); 950 951 static void drm_atomic_bridge_call_pre_enable(struct drm_bridge *bridge, 952 struct drm_atomic_commit *state) 953 { 954 if (state && bridge->funcs->atomic_pre_enable) 955 bridge->funcs->atomic_pre_enable(bridge, state); 956 } 957 958 /** 959 * drm_atomic_bridge_chain_pre_enable - prepares for enabling all bridges in 960 * the encoder chain 961 * @bridge: bridge control structure 962 * @state: atomic state being committed 963 * 964 * Calls &drm_bridge_funcs.atomic_pre_enable op for all the bridges in the 965 * encoder chain, starting from the last bridge to the first. These are called 966 * before calling &drm_encoder_helper_funcs.atomic_enable 967 * 968 * If a bridge sets @pre_enable_prev_first, then the pre_enable for the 969 * prev bridge will be called before pre_enable of this bridge. 970 * 971 * Example: 972 * Bridge A ---> Bridge B ---> Bridge C ---> Bridge D ---> Bridge E 973 * 974 * With pre_enable_prev_first flag enable in Bridge B, D, E then the resulting 975 * @pre_enable order would be, 976 * Bridge C, Bridge D, Bridge E, Bridge A, Bridge B. 977 * 978 * Note: the bridge passed should be the one closest to the encoder 979 */ 980 void drm_atomic_bridge_chain_pre_enable(struct drm_bridge *bridge, 981 struct drm_atomic_commit *state) 982 { 983 struct drm_encoder *encoder; 984 struct drm_bridge *iter, *next, *limit; 985 986 if (!bridge) 987 return; 988 989 encoder = bridge->encoder; 990 991 mutex_lock(&encoder->bridge_chain_mutex); 992 list_for_each_entry_reverse(iter, &encoder->bridge_chain, chain_node) { 993 if (iter->pre_enable_prev_first) { 994 next = iter; 995 limit = bridge; 996 list_for_each_entry_from_reverse(next, 997 &encoder->bridge_chain, 998 chain_node) { 999 if (next == bridge) 1000 break; 1001 1002 if (!next->pre_enable_prev_first) { 1003 /* Found first bridge that does NOT 1004 * request prev to be enabled first 1005 */ 1006 limit = next; 1007 break; 1008 } 1009 } 1010 1011 list_for_each_entry_from(next, &encoder->bridge_chain, chain_node) { 1012 /* Call requested prev bridge pre_enable 1013 * in order. 1014 */ 1015 if (next == iter) 1016 /* At the first bridge to request prev 1017 * bridges called first. 1018 */ 1019 break; 1020 1021 drm_atomic_bridge_call_pre_enable(next, state); 1022 } 1023 } 1024 1025 drm_atomic_bridge_call_pre_enable(iter, state); 1026 1027 if (iter->pre_enable_prev_first) 1028 /* Jump all bridges that we have already pre_enabled */ 1029 iter = limit; 1030 1031 if (iter == bridge) 1032 break; 1033 } 1034 mutex_unlock(&encoder->bridge_chain_mutex); 1035 } 1036 EXPORT_SYMBOL(drm_atomic_bridge_chain_pre_enable); 1037 1038 /** 1039 * drm_atomic_bridge_chain_enable - enables all bridges in the encoder chain 1040 * @first_bridge: bridge control structure 1041 * @state: atomic state being committed 1042 * 1043 * Calls &drm_bridge_funcs.atomic_enable op for all the bridges in the encoder 1044 * chain, starting from the first bridge to the last. These are called after 1045 * completing &drm_encoder_helper_funcs.atomic_enable 1046 * 1047 * Note: the bridge passed should be the one closest to the encoder 1048 */ 1049 void drm_atomic_bridge_chain_enable(struct drm_bridge *first_bridge, 1050 struct drm_atomic_commit *state) 1051 { 1052 if (!first_bridge) 1053 return; 1054 1055 drm_for_each_bridge_in_chain_from(first_bridge, bridge) 1056 if (bridge->funcs->atomic_enable) 1057 bridge->funcs->atomic_enable(bridge, state); 1058 } 1059 EXPORT_SYMBOL(drm_atomic_bridge_chain_enable); 1060 1061 static int drm_atomic_bridge_check(struct drm_bridge *bridge, 1062 struct drm_crtc_state *crtc_state, 1063 struct drm_connector_state *conn_state) 1064 { 1065 if (bridge->funcs->atomic_check) { 1066 struct drm_bridge_state *bridge_state; 1067 int ret; 1068 1069 bridge_state = drm_atomic_get_new_bridge_state(crtc_state->state, 1070 bridge); 1071 if (WARN_ON(!bridge_state)) 1072 return -EINVAL; 1073 1074 ret = bridge->funcs->atomic_check(bridge, bridge_state, 1075 crtc_state, conn_state); 1076 if (ret) 1077 return ret; 1078 } else if (bridge->funcs->mode_fixup) { 1079 if (!bridge->funcs->mode_fixup(bridge, &crtc_state->mode, 1080 &crtc_state->adjusted_mode)) 1081 return -EINVAL; 1082 } 1083 1084 return 0; 1085 } 1086 1087 static int select_bus_fmt_recursive(struct drm_bridge *first_bridge, 1088 struct drm_bridge *cur_bridge, 1089 struct drm_crtc_state *crtc_state, 1090 struct drm_connector_state *conn_state, 1091 u32 out_bus_fmt) 1092 { 1093 unsigned int i, num_in_bus_fmts = 0; 1094 struct drm_bridge_state *cur_state; 1095 struct drm_bridge *prev_bridge __free(drm_bridge_put) = 1096 drm_bridge_get_prev_bridge(cur_bridge); 1097 u32 *in_bus_fmts; 1098 int ret; 1099 1100 cur_state = drm_atomic_get_new_bridge_state(crtc_state->state, 1101 cur_bridge); 1102 1103 /* 1104 * If bus format negotiation is not supported by this bridge, let's 1105 * pass MEDIA_BUS_FMT_FIXED to the previous bridge in the chain and 1106 * hope that it can handle this situation gracefully (by providing 1107 * appropriate default values). 1108 */ 1109 if (!cur_bridge->funcs->atomic_get_input_bus_fmts) { 1110 if (cur_bridge != first_bridge) { 1111 ret = select_bus_fmt_recursive(first_bridge, 1112 prev_bridge, crtc_state, 1113 conn_state, 1114 MEDIA_BUS_FMT_FIXED); 1115 if (ret) 1116 return ret; 1117 } 1118 1119 /* 1120 * Driver does not implement the atomic state hooks, but that's 1121 * fine, as long as it does not access the bridge state. 1122 */ 1123 if (cur_state) { 1124 cur_state->input_bus_cfg.format = MEDIA_BUS_FMT_FIXED; 1125 cur_state->output_bus_cfg.format = out_bus_fmt; 1126 } 1127 1128 return 0; 1129 } 1130 1131 /* 1132 * If the driver implements ->atomic_get_input_bus_fmts() it 1133 * should also implement the atomic state hooks. 1134 */ 1135 if (WARN_ON(!cur_state)) 1136 return -EINVAL; 1137 1138 in_bus_fmts = cur_bridge->funcs->atomic_get_input_bus_fmts(cur_bridge, 1139 cur_state, 1140 crtc_state, 1141 conn_state, 1142 out_bus_fmt, 1143 &num_in_bus_fmts); 1144 if (!num_in_bus_fmts) 1145 return -ENOTSUPP; 1146 else if (!in_bus_fmts) 1147 return -ENOMEM; 1148 1149 if (first_bridge == cur_bridge) { 1150 cur_state->input_bus_cfg.format = in_bus_fmts[0]; 1151 cur_state->output_bus_cfg.format = out_bus_fmt; 1152 kfree(in_bus_fmts); 1153 return 0; 1154 } 1155 1156 for (i = 0; i < num_in_bus_fmts; i++) { 1157 ret = select_bus_fmt_recursive(first_bridge, prev_bridge, 1158 crtc_state, conn_state, 1159 in_bus_fmts[i]); 1160 if (ret != -ENOTSUPP) 1161 break; 1162 } 1163 1164 if (!ret) { 1165 cur_state->input_bus_cfg.format = in_bus_fmts[i]; 1166 cur_state->output_bus_cfg.format = out_bus_fmt; 1167 } 1168 1169 kfree(in_bus_fmts); 1170 return ret; 1171 } 1172 1173 static bool __pure bus_format_is_color_fmt(u32 bus_fmt, enum drm_connector_color_format fmt) 1174 { 1175 if (fmt == DRM_CONNECTOR_COLOR_FORMAT_AUTO) 1176 return true; 1177 1178 switch (bus_fmt) { 1179 case MEDIA_BUS_FMT_FIXED: 1180 return true; 1181 case MEDIA_BUS_FMT_RGB888_1X24: 1182 case MEDIA_BUS_FMT_RGB101010_1X30: 1183 case MEDIA_BUS_FMT_RGB121212_1X36: 1184 case MEDIA_BUS_FMT_RGB161616_1X48: 1185 return fmt == DRM_CONNECTOR_COLOR_FORMAT_RGB444; 1186 case MEDIA_BUS_FMT_YUV8_1X24: 1187 case MEDIA_BUS_FMT_YUV10_1X30: 1188 case MEDIA_BUS_FMT_YUV12_1X36: 1189 case MEDIA_BUS_FMT_YUV16_1X48: 1190 return fmt == DRM_CONNECTOR_COLOR_FORMAT_YCBCR444; 1191 case MEDIA_BUS_FMT_UYVY8_1X16: 1192 case MEDIA_BUS_FMT_VYUY8_1X16: 1193 case MEDIA_BUS_FMT_YUYV8_1X16: 1194 case MEDIA_BUS_FMT_YVYU8_1X16: 1195 case MEDIA_BUS_FMT_UYVY10_1X20: 1196 case MEDIA_BUS_FMT_YUYV10_1X20: 1197 case MEDIA_BUS_FMT_VYUY10_1X20: 1198 case MEDIA_BUS_FMT_YVYU10_1X20: 1199 case MEDIA_BUS_FMT_UYVY12_1X24: 1200 case MEDIA_BUS_FMT_VYUY12_1X24: 1201 case MEDIA_BUS_FMT_YUYV12_1X24: 1202 case MEDIA_BUS_FMT_YVYU12_1X24: 1203 return fmt == DRM_CONNECTOR_COLOR_FORMAT_YCBCR422; 1204 case MEDIA_BUS_FMT_UYYVYY8_0_5X24: 1205 case MEDIA_BUS_FMT_UYYVYY10_0_5X30: 1206 case MEDIA_BUS_FMT_UYYVYY12_0_5X36: 1207 case MEDIA_BUS_FMT_UYYVYY16_0_5X48: 1208 return fmt == DRM_CONNECTOR_COLOR_FORMAT_YCBCR420; 1209 default: 1210 return false; 1211 } 1212 } 1213 1214 /* 1215 * This function is called by &drm_atomic_bridge_chain_check() just before 1216 * calling &drm_bridge_funcs.atomic_check() on all elements of the chain. 1217 * It performs bus format negotiation between bridge elements. The negotiation 1218 * happens in reverse order, starting from the last element in the chain up to 1219 * @bridge. 1220 * 1221 * Negotiation starts by retrieving supported output bus formats on the last 1222 * bridge element and testing them one by one. The test is recursive, meaning 1223 * that for each tested output format, the whole chain will be walked backward, 1224 * and each element will have to choose an input bus format that can be 1225 * transcoded to the requested output format. When a bridge element does not 1226 * support transcoding into a specific output format -ENOTSUPP is returned and 1227 * the next bridge element will have to try a different format. If none of the 1228 * combinations worked, -ENOTSUPP is returned and the atomic modeset will fail. 1229 * 1230 * This implementation is relying on 1231 * &drm_bridge_funcs.atomic_get_output_bus_fmts() and 1232 * &drm_bridge_funcs.atomic_get_input_bus_fmts() to gather supported 1233 * input/output formats. 1234 * 1235 * When &drm_bridge_funcs.atomic_get_output_bus_fmts() is not implemented by 1236 * the last element of the chain, &drm_atomic_bridge_chain_select_bus_fmts() 1237 * tries a single format: &drm_connector.display_info.bus_formats[0] if 1238 * available, MEDIA_BUS_FMT_FIXED otherwise. 1239 * 1240 * When &drm_bridge_funcs.atomic_get_input_bus_fmts() is not implemented, 1241 * &drm_atomic_bridge_chain_select_bus_fmts() skips the negotiation on the 1242 * bridge element that lacks this hook and asks the previous element in the 1243 * chain to try MEDIA_BUS_FMT_FIXED. It's up to bridge drivers to decide what 1244 * to do in that case (fail if they want to enforce bus format negotiation, or 1245 * provide a reasonable default if they need to support pipelines where not 1246 * all elements support bus format negotiation). 1247 */ 1248 static int 1249 drm_atomic_bridge_chain_select_bus_fmts(struct drm_bridge *bridge, 1250 struct drm_crtc_state *crtc_state, 1251 struct drm_connector_state *conn_state) 1252 { 1253 struct drm_connector *conn = conn_state->connector; 1254 struct drm_encoder *encoder = bridge->encoder; 1255 struct drm_bridge_state *last_bridge_state; 1256 unsigned int i, num_out_bus_fmts = 0; 1257 enum drm_connector_color_format fmt; 1258 u32 *out_bus_fmts; 1259 int ret = 0; 1260 1261 struct drm_bridge *last_bridge __free(drm_bridge_put) = 1262 drm_bridge_get(list_last_entry(&encoder->bridge_chain, 1263 struct drm_bridge, chain_node)); 1264 last_bridge_state = drm_atomic_get_new_bridge_state(crtc_state->state, 1265 last_bridge); 1266 1267 if (last_bridge->funcs->atomic_get_output_bus_fmts) { 1268 const struct drm_bridge_funcs *funcs = last_bridge->funcs; 1269 1270 /* 1271 * If the driver implements ->atomic_get_output_bus_fmts() it 1272 * should also implement the atomic state hooks. 1273 */ 1274 if (WARN_ON(!last_bridge_state)) 1275 return -EINVAL; 1276 1277 out_bus_fmts = funcs->atomic_get_output_bus_fmts(last_bridge, 1278 last_bridge_state, 1279 crtc_state, 1280 conn_state, 1281 &num_out_bus_fmts); 1282 if (!num_out_bus_fmts) 1283 return -ENOTSUPP; 1284 else if (!out_bus_fmts) 1285 return -ENOMEM; 1286 } else { 1287 num_out_bus_fmts = 1; 1288 out_bus_fmts = kmalloc_obj(*out_bus_fmts); 1289 if (!out_bus_fmts) 1290 return -ENOMEM; 1291 1292 if (conn->display_info.num_bus_formats && 1293 conn->display_info.bus_formats) 1294 out_bus_fmts[0] = conn->display_info.bus_formats[0]; 1295 else 1296 out_bus_fmts[0] = MEDIA_BUS_FMT_FIXED; 1297 } 1298 1299 /* 1300 * Instead of directly accessing conn_state.color_format, call into a 1301 * connector function that allows connector implementations (e.g. for 1302 * bridge connectors including HDMI bridges, where the HDMI helpers will 1303 * have already chosen an appropriate output format) to override the 1304 * selected format. 1305 */ 1306 fmt = drm_connector_get_color_format(conn_state); 1307 1308 for (i = 0; i < num_out_bus_fmts; i++) { 1309 if (!bus_format_is_color_fmt(out_bus_fmts[i], fmt)) { 1310 drm_dbg_kms(last_bridge->dev, 1311 "Skipping bus format 0x%04x as it doesn't match format %d\n", 1312 out_bus_fmts[i], fmt); 1313 ret = -ENOTSUPP; 1314 continue; 1315 } 1316 ret = select_bus_fmt_recursive(bridge, last_bridge, crtc_state, 1317 conn_state, out_bus_fmts[i]); 1318 if (ret != -ENOTSUPP) { 1319 drm_dbg_kms(last_bridge->dev, 1320 "Found bridge chain ending with bus format 0x%04x\n", 1321 out_bus_fmts[i]); 1322 break; 1323 } 1324 } 1325 1326 kfree(out_bus_fmts); 1327 1328 return ret; 1329 } 1330 1331 static void 1332 drm_atomic_bridge_propagate_bus_flags(struct drm_bridge *bridge, 1333 struct drm_connector *conn, 1334 struct drm_atomic_commit *state) 1335 { 1336 struct drm_bridge_state *bridge_state, *next_bridge_state; 1337 u32 output_flags = 0; 1338 1339 bridge_state = drm_atomic_get_new_bridge_state(state, bridge); 1340 1341 /* No bridge state attached to this bridge => nothing to propagate. */ 1342 if (!bridge_state) 1343 return; 1344 1345 struct drm_bridge *next_bridge __free(drm_bridge_put) = drm_bridge_get_next_bridge(bridge); 1346 1347 /* 1348 * Let's try to apply the most common case here, that is, propagate 1349 * display_info flags for the last bridge, and propagate the input 1350 * flags of the next bridge element to the output end of the current 1351 * bridge when the bridge is not the last one. 1352 * There are exceptions to this rule, like when signal inversion is 1353 * happening at the board level, but that's something drivers can deal 1354 * with from their &drm_bridge_funcs.atomic_check() implementation by 1355 * simply overriding the flags value we've set here. 1356 */ 1357 if (!next_bridge) { 1358 output_flags = conn->display_info.bus_flags; 1359 } else { 1360 next_bridge_state = drm_atomic_get_new_bridge_state(state, 1361 next_bridge); 1362 /* 1363 * No bridge state attached to the next bridge, just leave the 1364 * flags to 0. 1365 */ 1366 if (next_bridge_state) 1367 output_flags = next_bridge_state->input_bus_cfg.flags; 1368 } 1369 1370 bridge_state->output_bus_cfg.flags = output_flags; 1371 1372 /* 1373 * Propagate the output flags to the input end of the bridge. Again, it's 1374 * not necessarily what all bridges want, but that's what most of them 1375 * do, and by doing that by default we avoid forcing drivers to 1376 * duplicate the "dummy propagation" logic. 1377 */ 1378 bridge_state->input_bus_cfg.flags = output_flags; 1379 } 1380 1381 /** 1382 * drm_atomic_bridge_chain_check() - Do an atomic check on the bridge chain 1383 * @bridge: bridge control structure 1384 * @crtc_state: new CRTC state 1385 * @conn_state: new connector state 1386 * 1387 * First trigger a bus format negotiation before calling 1388 * &drm_bridge_funcs.atomic_check() (falls back on 1389 * &drm_bridge_funcs.mode_fixup()) op for all the bridges in the encoder chain, 1390 * starting from the last bridge to the first. These are called before calling 1391 * &drm_encoder_helper_funcs.atomic_check() 1392 * 1393 * RETURNS: 1394 * 0 on success, a negative error code on failure 1395 */ 1396 int drm_atomic_bridge_chain_check(struct drm_bridge *bridge, 1397 struct drm_crtc_state *crtc_state, 1398 struct drm_connector_state *conn_state) 1399 { 1400 struct drm_connector *conn = conn_state->connector; 1401 struct drm_encoder *encoder; 1402 struct drm_bridge *iter; 1403 int ret; 1404 1405 if (!bridge) 1406 return 0; 1407 1408 ret = drm_atomic_bridge_chain_select_bus_fmts(bridge, crtc_state, 1409 conn_state); 1410 if (ret) 1411 return ret; 1412 1413 encoder = bridge->encoder; 1414 scoped_guard(mutex, &encoder->bridge_chain_mutex) { 1415 list_for_each_entry_reverse(iter, &encoder->bridge_chain, chain_node) { 1416 int ret; 1417 1418 /* 1419 * Bus flags are propagated by default. If a bridge needs to 1420 * tweak the input bus flags for any reason, it should happen 1421 * in its &drm_bridge_funcs.atomic_check() implementation such 1422 * that preceding bridges in the chain can propagate the new 1423 * bus flags. 1424 */ 1425 drm_atomic_bridge_propagate_bus_flags(iter, conn, 1426 crtc_state->state); 1427 1428 ret = drm_atomic_bridge_check(iter, crtc_state, conn_state); 1429 if (ret) 1430 return ret; 1431 1432 if (iter == bridge) 1433 break; 1434 } 1435 } 1436 1437 return 0; 1438 } 1439 EXPORT_SYMBOL(drm_atomic_bridge_chain_check); 1440 1441 /** 1442 * drm_bridge_detect - check if anything is attached to the bridge output 1443 * @bridge: bridge control structure 1444 * @connector: attached connector 1445 * 1446 * If the bridge supports output detection, as reported by the 1447 * DRM_BRIDGE_OP_DETECT bridge ops flag, call &drm_bridge_funcs.detect for the 1448 * bridge and return the connection status. Otherwise return 1449 * connector_status_unknown. 1450 * 1451 * RETURNS: 1452 * The detection status on success, or connector_status_unknown if the bridge 1453 * doesn't support output detection. 1454 */ 1455 enum drm_connector_status 1456 drm_bridge_detect(struct drm_bridge *bridge, struct drm_connector *connector) 1457 { 1458 if (!(bridge->ops & DRM_BRIDGE_OP_DETECT)) 1459 return connector_status_unknown; 1460 1461 return bridge->funcs->detect(bridge, connector); 1462 } 1463 EXPORT_SYMBOL_GPL(drm_bridge_detect); 1464 1465 /** 1466 * drm_bridge_get_modes - fill all modes currently valid for the sink into the 1467 * @connector 1468 * @bridge: bridge control structure 1469 * @connector: the connector to fill with modes 1470 * 1471 * If the bridge supports output modes retrieval, as reported by the 1472 * DRM_BRIDGE_OP_MODES bridge ops flag, call &drm_bridge_funcs.get_modes to 1473 * fill the connector with all valid modes and return the number of modes 1474 * added. Otherwise return 0. 1475 * 1476 * RETURNS: 1477 * The number of modes added to the connector. 1478 */ 1479 int drm_bridge_get_modes(struct drm_bridge *bridge, 1480 struct drm_connector *connector) 1481 { 1482 if (!(bridge->ops & DRM_BRIDGE_OP_MODES)) 1483 return 0; 1484 1485 return bridge->funcs->get_modes(bridge, connector); 1486 } 1487 EXPORT_SYMBOL_GPL(drm_bridge_get_modes); 1488 1489 /** 1490 * drm_bridge_edid_read - read the EDID data of the connected display 1491 * @bridge: bridge control structure 1492 * @connector: the connector to read EDID for 1493 * 1494 * If the bridge supports output EDID retrieval, as reported by the 1495 * DRM_BRIDGE_OP_EDID bridge ops flag, call &drm_bridge_funcs.edid_read to get 1496 * the EDID and return it. Otherwise return NULL. 1497 * 1498 * RETURNS: 1499 * The retrieved EDID on success, or NULL otherwise. 1500 */ 1501 const struct drm_edid *drm_bridge_edid_read(struct drm_bridge *bridge, 1502 struct drm_connector *connector) 1503 { 1504 if (!(bridge->ops & DRM_BRIDGE_OP_EDID)) 1505 return NULL; 1506 1507 return bridge->funcs->edid_read(bridge, connector); 1508 } 1509 EXPORT_SYMBOL_GPL(drm_bridge_edid_read); 1510 1511 /** 1512 * drm_bridge_hpd_enable - enable hot plug detection for the bridge 1513 * @bridge: bridge control structure 1514 * @cb: hot-plug detection callback 1515 * @data: data to be passed to the hot-plug detection callback 1516 * 1517 * Call &drm_bridge_funcs.hpd_enable if implemented and register the given @cb 1518 * and @data as hot plug notification callback. From now on the @cb will be 1519 * called with @data when an output status change is detected by the bridge, 1520 * until hot plug notification gets disabled with drm_bridge_hpd_disable(). 1521 * 1522 * Hot plug detection is supported only if the DRM_BRIDGE_OP_HPD flag is set in 1523 * bridge->ops. This function shall not be called when the flag is not set. 1524 * 1525 * Only one hot plug detection callback can be registered at a time, it is an 1526 * error to call this function when hot plug detection is already enabled for 1527 * the bridge. 1528 */ 1529 void drm_bridge_hpd_enable(struct drm_bridge *bridge, 1530 void (*cb)(void *data, 1531 enum drm_connector_status status), 1532 void *data) 1533 { 1534 if (!(bridge->ops & DRM_BRIDGE_OP_HPD)) 1535 return; 1536 1537 mutex_lock(&bridge->hpd_state_mutex); 1538 1539 mutex_lock(&bridge->hpd_mutex); 1540 1541 if (WARN(bridge->hpd_cb, "Hot plug detection already enabled\n")) { 1542 mutex_unlock(&bridge->hpd_mutex); 1543 goto unlock; 1544 } 1545 1546 bridge->hpd_cb = cb; 1547 bridge->hpd_data = data; 1548 1549 mutex_unlock(&bridge->hpd_mutex); 1550 1551 if (bridge->funcs->hpd_enable) 1552 bridge->funcs->hpd_enable(bridge); 1553 1554 unlock: 1555 mutex_unlock(&bridge->hpd_state_mutex); 1556 } 1557 EXPORT_SYMBOL_GPL(drm_bridge_hpd_enable); 1558 1559 /** 1560 * drm_bridge_hpd_disable - disable hot plug detection for the bridge 1561 * @bridge: bridge control structure 1562 * 1563 * Call &drm_bridge_funcs.hpd_disable if implemented and unregister the hot 1564 * plug detection callback previously registered with drm_bridge_hpd_enable(). 1565 * Once this function returns the callback will not be called by the bridge 1566 * when an output status change occurs. 1567 * 1568 * Hot plug detection is supported only if the DRM_BRIDGE_OP_HPD flag is set in 1569 * bridge->ops. This function shall not be called when the flag is not set. 1570 */ 1571 void drm_bridge_hpd_disable(struct drm_bridge *bridge) 1572 { 1573 if (!(bridge->ops & DRM_BRIDGE_OP_HPD)) 1574 return; 1575 1576 mutex_lock(&bridge->hpd_state_mutex); 1577 if (bridge->funcs->hpd_disable) 1578 bridge->funcs->hpd_disable(bridge); 1579 1580 mutex_lock(&bridge->hpd_mutex); 1581 bridge->hpd_cb = NULL; 1582 bridge->hpd_data = NULL; 1583 mutex_unlock(&bridge->hpd_mutex); 1584 mutex_unlock(&bridge->hpd_state_mutex); 1585 } 1586 EXPORT_SYMBOL_GPL(drm_bridge_hpd_disable); 1587 1588 /** 1589 * drm_bridge_hpd_notify - notify hot plug detection events 1590 * @bridge: bridge control structure 1591 * @status: output connection status 1592 * 1593 * Bridge drivers shall call this function to report hot plug events when they 1594 * detect a change in the output status, when hot plug detection has been 1595 * enabled by drm_bridge_hpd_enable(). 1596 * 1597 * This function shall be called in a context that can sleep. 1598 */ 1599 void drm_bridge_hpd_notify(struct drm_bridge *bridge, 1600 enum drm_connector_status status) 1601 { 1602 mutex_lock(&bridge->hpd_mutex); 1603 if (bridge->hpd_cb) 1604 bridge->hpd_cb(bridge->hpd_data, status); 1605 mutex_unlock(&bridge->hpd_mutex); 1606 } 1607 EXPORT_SYMBOL_GPL(drm_bridge_hpd_notify); 1608 1609 #ifdef CONFIG_OF 1610 /** 1611 * of_drm_find_and_get_bridge - find the bridge corresponding to the device 1612 * node in the global bridge list 1613 * @np: device node 1614 * 1615 * The refcount of the returned bridge is incremented. Use drm_bridge_put() 1616 * when done with it. 1617 * 1618 * RETURNS: 1619 * drm_bridge control struct on success, NULL on failure 1620 */ 1621 struct drm_bridge *of_drm_find_and_get_bridge(struct device_node *np) 1622 { 1623 struct drm_bridge *bridge; 1624 1625 scoped_guard(mutex, &bridge_lock) { 1626 list_for_each_entry(bridge, &bridge_list, list) 1627 if (bridge->of_node == np) 1628 return drm_bridge_get(bridge); 1629 } 1630 1631 return NULL; 1632 } 1633 EXPORT_SYMBOL(of_drm_find_and_get_bridge); 1634 1635 /** 1636 * of_drm_find_bridge - find the bridge corresponding to the device node in 1637 * the global bridge list 1638 * 1639 * @np: device node 1640 * 1641 * This function is deprecated. Convert to of_drm_find_and_get_bridge() 1642 * instead for proper refcounting. 1643 * 1644 * The bridge returned by this function is not refcounted. This is 1645 * dangerous because the bridge might be deallocated even before the caller 1646 * has a chance to use it. To use this function you have to do one of: 1647 * 1648 * - get a reference with drm_bridge_get() as soon as possible to 1649 * minimize the race window, and then drm_bridge_put() when no longer 1650 * using the pointer 1651 * 1652 * - not call drm_bridge_get() or drm_bridge_put() at all, which used to 1653 * be the correct practice before dynamic bridge lifetime was introduced 1654 * 1655 * - again, convert to of_drm_find_and_get_bridge(), which is the only safe 1656 * thing to do 1657 * 1658 * RETURNS: 1659 * drm_bridge control struct on success, NULL on failure 1660 */ 1661 struct drm_bridge *of_drm_find_bridge(struct device_node *np) 1662 { 1663 struct drm_bridge *bridge = of_drm_find_and_get_bridge(np); 1664 1665 /* 1666 * We need to emulate the original semantics of 1667 * of_drm_find_bridge(), which was not getting any bridge 1668 * reference. Being now based on of_drm_find_and_get_bridge() which 1669 * gets a reference, put it before returning. 1670 */ 1671 drm_bridge_put(bridge); 1672 1673 return bridge; 1674 } 1675 EXPORT_SYMBOL(of_drm_find_bridge); 1676 1677 /** 1678 * of_drm_get_bridge_by_endpoint - return DRM bridge connected to a port/endpoint 1679 * @np: device tree node containing output ports 1680 * @port: port in the device tree node, or -1 for the first port found 1681 * @endpoint: endpoint in the device tree node, or -1 for the first endpoint found 1682 * 1683 * Given a DT node's port and endpoint number, find the connected node and 1684 * return the associated drm_bridge device. 1685 * 1686 * The refcount of the returned bridge is incremented. Use drm_bridge_put() 1687 * when done with it. 1688 * 1689 * Returns a pointer to the connected drm_bridge, or a negative error on failure 1690 */ 1691 struct drm_bridge *of_drm_get_bridge_by_endpoint(const struct device_node *np, 1692 int port, int endpoint) 1693 { 1694 struct drm_bridge *bridge; 1695 1696 /* 1697 * of_graph_get_remote_node() produces a noisy error message if port 1698 * node isn't found and the absence of the port is a legit case here, 1699 * so at first we silently check whether a graph is present in the 1700 * device-tree node. 1701 */ 1702 if (!of_graph_is_present(np)) 1703 return ERR_PTR(-ENODEV); 1704 1705 struct device_node *remote __free(device_node) = 1706 of_graph_get_remote_node(np, port, endpoint); 1707 if (!remote) 1708 return ERR_PTR(-ENODEV); 1709 1710 bridge = of_drm_find_and_get_bridge(remote); 1711 if (!bridge) 1712 return ERR_PTR(-EPROBE_DEFER); 1713 1714 return bridge; 1715 } 1716 EXPORT_SYMBOL_GPL(of_drm_get_bridge_by_endpoint); 1717 #endif 1718 1719 /** 1720 * devm_drm_put_bridge - Release a bridge reference obtained via devm 1721 * @dev: device that got the bridge via devm 1722 * @bridge: pointer to a struct drm_bridge obtained via devm 1723 * 1724 * Same as drm_bridge_put() for bridge pointers obtained via devm functions 1725 * such as devm_drm_bridge_alloc(). 1726 * 1727 * This function is a temporary workaround and MUST NOT be used. Manual 1728 * handling of bridge lifetime is inherently unsafe. 1729 */ 1730 void devm_drm_put_bridge(struct device *dev, struct drm_bridge *bridge) 1731 { 1732 devm_release_action(dev, drm_bridge_put_void, bridge); 1733 } 1734 EXPORT_SYMBOL(devm_drm_put_bridge); 1735 1736 static void drm_bridge_debugfs_show_bridge(struct drm_printer *p, 1737 struct drm_bridge *bridge, 1738 unsigned int idx, 1739 bool lingering, 1740 bool scoped) 1741 { 1742 unsigned int refcount = kref_read(&bridge->refcount); 1743 1744 if (scoped) 1745 refcount--; 1746 1747 drm_printf(p, "bridge[%u]: %ps\n", idx, bridge->funcs); 1748 1749 drm_printf_indent(p, 1, "refcount: %u%s\n", refcount, 1750 lingering ? " [lingering]" : ""); 1751 1752 drm_printf_indent(p, 1, "type: [%d] %s\n", bridge->type, 1753 drm_get_connector_type_name(bridge->type)); 1754 1755 /* The OF node could be freed after drm_bridge_remove() */ 1756 if (bridge->of_node && !lingering) 1757 drm_printf_indent(p, 1, "OF: %pOFfc\n", bridge->of_node); 1758 1759 drm_printf_indent(p, 1, "ops: [0x%x]", bridge->ops); 1760 if (bridge->ops & DRM_BRIDGE_OP_DETECT) 1761 drm_puts(p, " detect"); 1762 if (bridge->ops & DRM_BRIDGE_OP_EDID) 1763 drm_puts(p, " edid"); 1764 if (bridge->ops & DRM_BRIDGE_OP_HPD) 1765 drm_puts(p, " hpd"); 1766 if (bridge->ops & DRM_BRIDGE_OP_MODES) 1767 drm_puts(p, " modes"); 1768 if (bridge->ops & DRM_BRIDGE_OP_HDMI) 1769 drm_puts(p, " hdmi"); 1770 drm_puts(p, "\n"); 1771 } 1772 1773 static int allbridges_show(struct seq_file *m, void *data) 1774 { 1775 struct drm_printer p = drm_seq_file_printer(m); 1776 struct drm_bridge *bridge; 1777 unsigned int idx = 0; 1778 1779 mutex_lock(&bridge_lock); 1780 1781 list_for_each_entry(bridge, &bridge_list, list) 1782 drm_bridge_debugfs_show_bridge(&p, bridge, idx++, false, false); 1783 1784 list_for_each_entry(bridge, &bridge_lingering_list, list) 1785 drm_bridge_debugfs_show_bridge(&p, bridge, idx++, true, false); 1786 1787 mutex_unlock(&bridge_lock); 1788 1789 return 0; 1790 } 1791 DEFINE_SHOW_ATTRIBUTE(allbridges); 1792 1793 static int encoder_bridges_show(struct seq_file *m, void *data) 1794 { 1795 struct drm_encoder *encoder = m->private; 1796 struct drm_printer p = drm_seq_file_printer(m); 1797 unsigned int idx = 0; 1798 1799 drm_for_each_bridge_in_chain(encoder, bridge) 1800 drm_bridge_debugfs_show_bridge(&p, bridge, idx++, false, true); 1801 1802 return 0; 1803 } 1804 DEFINE_SHOW_ATTRIBUTE(encoder_bridges); 1805 1806 void drm_bridge_debugfs_params(struct dentry *root) 1807 { 1808 debugfs_create_file("bridges", 0444, root, NULL, &allbridges_fops); 1809 } 1810 1811 void drm_bridge_debugfs_encoder_params(struct dentry *root, 1812 struct drm_encoder *encoder) 1813 { 1814 /* bridges list */ 1815 debugfs_create_file("bridges", 0444, root, encoder, &encoder_bridges_fops); 1816 } 1817 1818 MODULE_AUTHOR("Ajay Kumar <ajaykumar.rs@samsung.com>"); 1819 MODULE_DESCRIPTION("DRM bridge infrastructure"); 1820 MODULE_LICENSE("GPL and additional rights"); 1821