xref: /linux/drivers/gpu/drm/bridge/ti-tfp410.c (revision 0eb2766dd6f366d42448121c383420bb0307bcc7)
1dc55ac3bSJyri Sarha /*
2dc55ac3bSJyri Sarha  * Copyright (C) 2016 Texas Instruments
3dc55ac3bSJyri Sarha  * Author: Jyri Sarha <jsarha@ti.com>
4dc55ac3bSJyri Sarha  *
5dc55ac3bSJyri Sarha  * This program is free software; you can redistribute it and/or modify it
6dc55ac3bSJyri Sarha  * under the terms of the GNU General Public License version 2 as published by
7dc55ac3bSJyri Sarha  * the Free Software Foundation.
8dc55ac3bSJyri Sarha  *
9dc55ac3bSJyri Sarha  */
10dc55ac3bSJyri Sarha 
11f56c9202SChristopher Spinrath #include <linux/delay.h>
12f56c9202SChristopher Spinrath #include <linux/fwnode.h>
13f56c9202SChristopher Spinrath #include <linux/gpio/consumer.h>
14f56c9202SChristopher Spinrath #include <linux/irq.h>
15dc55ac3bSJyri Sarha #include <linux/module.h>
16dc55ac3bSJyri Sarha #include <linux/of_graph.h>
17dc55ac3bSJyri Sarha #include <linux/platform_device.h>
18dc55ac3bSJyri Sarha #include <linux/i2c.h>
19dc55ac3bSJyri Sarha 
20dc55ac3bSJyri Sarha #include <drm/drmP.h>
21dc55ac3bSJyri Sarha #include <drm/drm_atomic_helper.h>
22dc55ac3bSJyri Sarha #include <drm/drm_crtc.h>
23fcd70cd3SDaniel Vetter #include <drm/drm_probe_helper.h>
24dc55ac3bSJyri Sarha 
25f56c9202SChristopher Spinrath #define HOTPLUG_DEBOUNCE_MS		1100
26f56c9202SChristopher Spinrath 
27dc55ac3bSJyri Sarha struct tfp410 {
28dc55ac3bSJyri Sarha 	struct drm_bridge	bridge;
29dc55ac3bSJyri Sarha 	struct drm_connector	connector;
3060b903c3SLaurent Pinchart 	unsigned int		connector_type;
31dc55ac3bSJyri Sarha 
32*0eb2766dSPeter Ujfalusi 	u32			bus_format;
33dc55ac3bSJyri Sarha 	struct i2c_adapter	*ddc;
34f56c9202SChristopher Spinrath 	struct gpio_desc	*hpd;
353d31e215SPeter Ujfalusi 	int			hpd_irq;
36f56c9202SChristopher Spinrath 	struct delayed_work	hpd_work;
3738c02db7SLaurent Pinchart 	struct gpio_desc	*powerdown;
38dc55ac3bSJyri Sarha 
39897dae56SLaurent Pinchart 	struct drm_bridge_timings timings;
40897dae56SLaurent Pinchart 
41dc55ac3bSJyri Sarha 	struct device *dev;
42dc55ac3bSJyri Sarha };
43dc55ac3bSJyri Sarha 
44dc55ac3bSJyri Sarha static inline struct tfp410 *
45dc55ac3bSJyri Sarha drm_bridge_to_tfp410(struct drm_bridge *bridge)
46dc55ac3bSJyri Sarha {
47dc55ac3bSJyri Sarha 	return container_of(bridge, struct tfp410, bridge);
48dc55ac3bSJyri Sarha }
49dc55ac3bSJyri Sarha 
50dc55ac3bSJyri Sarha static inline struct tfp410 *
51dc55ac3bSJyri Sarha drm_connector_to_tfp410(struct drm_connector *connector)
52dc55ac3bSJyri Sarha {
53dc55ac3bSJyri Sarha 	return container_of(connector, struct tfp410, connector);
54dc55ac3bSJyri Sarha }
55dc55ac3bSJyri Sarha 
56dc55ac3bSJyri Sarha static int tfp410_get_modes(struct drm_connector *connector)
57dc55ac3bSJyri Sarha {
58dc55ac3bSJyri Sarha 	struct tfp410 *dvi = drm_connector_to_tfp410(connector);
59dc55ac3bSJyri Sarha 	struct edid *edid;
60dc55ac3bSJyri Sarha 	int ret;
61dc55ac3bSJyri Sarha 
62dc55ac3bSJyri Sarha 	if (!dvi->ddc)
63dc55ac3bSJyri Sarha 		goto fallback;
64dc55ac3bSJyri Sarha 
65dc55ac3bSJyri Sarha 	edid = drm_get_edid(connector, dvi->ddc);
66dc55ac3bSJyri Sarha 	if (!edid) {
67dc55ac3bSJyri Sarha 		DRM_INFO("EDID read failed. Fallback to standard modes\n");
68dc55ac3bSJyri Sarha 		goto fallback;
69dc55ac3bSJyri Sarha 	}
70dc55ac3bSJyri Sarha 
71c555f023SDaniel Vetter 	drm_connector_update_edid_property(connector, edid);
72dc55ac3bSJyri Sarha 
73dc55ac3bSJyri Sarha 	return drm_add_edid_modes(connector, edid);
74dc55ac3bSJyri Sarha fallback:
75dc55ac3bSJyri Sarha 	/* No EDID, fallback on the XGA standard modes */
76dc55ac3bSJyri Sarha 	ret = drm_add_modes_noedid(connector, 1920, 1200);
77dc55ac3bSJyri Sarha 
78dc55ac3bSJyri Sarha 	/* And prefer a mode pretty much anything can handle */
79dc55ac3bSJyri Sarha 	drm_set_preferred_mode(connector, 1024, 768);
80dc55ac3bSJyri Sarha 
81dc55ac3bSJyri Sarha 	return ret;
82dc55ac3bSJyri Sarha }
83dc55ac3bSJyri Sarha 
84dc55ac3bSJyri Sarha static const struct drm_connector_helper_funcs tfp410_con_helper_funcs = {
85dc55ac3bSJyri Sarha 	.get_modes	= tfp410_get_modes,
86dc55ac3bSJyri Sarha };
87dc55ac3bSJyri Sarha 
88dc55ac3bSJyri Sarha static enum drm_connector_status
89dc55ac3bSJyri Sarha tfp410_connector_detect(struct drm_connector *connector, bool force)
90dc55ac3bSJyri Sarha {
91dc55ac3bSJyri Sarha 	struct tfp410 *dvi = drm_connector_to_tfp410(connector);
92dc55ac3bSJyri Sarha 
93f56c9202SChristopher Spinrath 	if (dvi->hpd) {
94f56c9202SChristopher Spinrath 		if (gpiod_get_value_cansleep(dvi->hpd))
95f56c9202SChristopher Spinrath 			return connector_status_connected;
96f56c9202SChristopher Spinrath 		else
97f56c9202SChristopher Spinrath 			return connector_status_disconnected;
98f56c9202SChristopher Spinrath 	}
99f56c9202SChristopher Spinrath 
100dc55ac3bSJyri Sarha 	if (dvi->ddc) {
101dc55ac3bSJyri Sarha 		if (drm_probe_ddc(dvi->ddc))
102dc55ac3bSJyri Sarha 			return connector_status_connected;
103dc55ac3bSJyri Sarha 		else
104dc55ac3bSJyri Sarha 			return connector_status_disconnected;
105dc55ac3bSJyri Sarha 	}
106dc55ac3bSJyri Sarha 
107dc55ac3bSJyri Sarha 	return connector_status_unknown;
108dc55ac3bSJyri Sarha }
109dc55ac3bSJyri Sarha 
110dc55ac3bSJyri Sarha static const struct drm_connector_funcs tfp410_con_funcs = {
111dc55ac3bSJyri Sarha 	.detect			= tfp410_connector_detect,
112dc55ac3bSJyri Sarha 	.fill_modes		= drm_helper_probe_single_connector_modes,
113dc55ac3bSJyri Sarha 	.destroy		= drm_connector_cleanup,
114dc55ac3bSJyri Sarha 	.reset			= drm_atomic_helper_connector_reset,
115dc55ac3bSJyri Sarha 	.atomic_duplicate_state	= drm_atomic_helper_connector_duplicate_state,
116dc55ac3bSJyri Sarha 	.atomic_destroy_state	= drm_atomic_helper_connector_destroy_state,
117dc55ac3bSJyri Sarha };
118dc55ac3bSJyri Sarha 
119dc55ac3bSJyri Sarha static int tfp410_attach(struct drm_bridge *bridge)
120dc55ac3bSJyri Sarha {
121dc55ac3bSJyri Sarha 	struct tfp410 *dvi = drm_bridge_to_tfp410(bridge);
122dc55ac3bSJyri Sarha 	int ret;
123dc55ac3bSJyri Sarha 
124dc55ac3bSJyri Sarha 	if (!bridge->encoder) {
125dc55ac3bSJyri Sarha 		dev_err(dvi->dev, "Missing encoder\n");
126dc55ac3bSJyri Sarha 		return -ENODEV;
127dc55ac3bSJyri Sarha 	}
128dc55ac3bSJyri Sarha 
1293d31e215SPeter Ujfalusi 	if (dvi->hpd_irq >= 0)
130f56c9202SChristopher Spinrath 		dvi->connector.polled = DRM_CONNECTOR_POLL_HPD;
1313d31e215SPeter Ujfalusi 	else
1323d31e215SPeter Ujfalusi 		dvi->connector.polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT;
133f56c9202SChristopher Spinrath 
134dc55ac3bSJyri Sarha 	drm_connector_helper_add(&dvi->connector,
135dc55ac3bSJyri Sarha 				 &tfp410_con_helper_funcs);
136dc55ac3bSJyri Sarha 	ret = drm_connector_init(bridge->dev, &dvi->connector,
13760b903c3SLaurent Pinchart 				 &tfp410_con_funcs, dvi->connector_type);
138dc55ac3bSJyri Sarha 	if (ret) {
139dc55ac3bSJyri Sarha 		dev_err(dvi->dev, "drm_connector_init() failed: %d\n", ret);
140dc55ac3bSJyri Sarha 		return ret;
141dc55ac3bSJyri Sarha 	}
142dc55ac3bSJyri Sarha 
143*0eb2766dSPeter Ujfalusi 	drm_display_info_set_bus_formats(&dvi->connector.display_info,
144*0eb2766dSPeter Ujfalusi 					 &dvi->bus_format, 1);
145*0eb2766dSPeter Ujfalusi 
146cde4c44dSDaniel Vetter 	drm_connector_attach_encoder(&dvi->connector,
147dc55ac3bSJyri Sarha 					  bridge->encoder);
148dc55ac3bSJyri Sarha 
149dc55ac3bSJyri Sarha 	return 0;
150dc55ac3bSJyri Sarha }
151dc55ac3bSJyri Sarha 
15238c02db7SLaurent Pinchart static void tfp410_enable(struct drm_bridge *bridge)
15338c02db7SLaurent Pinchart {
15438c02db7SLaurent Pinchart 	struct tfp410 *dvi = drm_bridge_to_tfp410(bridge);
15538c02db7SLaurent Pinchart 
15638c02db7SLaurent Pinchart 	gpiod_set_value_cansleep(dvi->powerdown, 0);
15738c02db7SLaurent Pinchart }
15838c02db7SLaurent Pinchart 
15938c02db7SLaurent Pinchart static void tfp410_disable(struct drm_bridge *bridge)
16038c02db7SLaurent Pinchart {
16138c02db7SLaurent Pinchart 	struct tfp410 *dvi = drm_bridge_to_tfp410(bridge);
16238c02db7SLaurent Pinchart 
16338c02db7SLaurent Pinchart 	gpiod_set_value_cansleep(dvi->powerdown, 1);
16438c02db7SLaurent Pinchart }
16538c02db7SLaurent Pinchart 
166dc55ac3bSJyri Sarha static const struct drm_bridge_funcs tfp410_bridge_funcs = {
167dc55ac3bSJyri Sarha 	.attach		= tfp410_attach,
16838c02db7SLaurent Pinchart 	.enable		= tfp410_enable,
16938c02db7SLaurent Pinchart 	.disable	= tfp410_disable,
170dc55ac3bSJyri Sarha };
171dc55ac3bSJyri Sarha 
172f56c9202SChristopher Spinrath static void tfp410_hpd_work_func(struct work_struct *work)
173f56c9202SChristopher Spinrath {
174f56c9202SChristopher Spinrath 	struct tfp410 *dvi;
175f56c9202SChristopher Spinrath 
176f56c9202SChristopher Spinrath 	dvi = container_of(work, struct tfp410, hpd_work.work);
177f56c9202SChristopher Spinrath 
178f56c9202SChristopher Spinrath 	if (dvi->bridge.dev)
179f56c9202SChristopher Spinrath 		drm_helper_hpd_irq_event(dvi->bridge.dev);
180f56c9202SChristopher Spinrath }
181f56c9202SChristopher Spinrath 
182f56c9202SChristopher Spinrath static irqreturn_t tfp410_hpd_irq_thread(int irq, void *arg)
183f56c9202SChristopher Spinrath {
184f56c9202SChristopher Spinrath 	struct tfp410 *dvi = arg;
185f56c9202SChristopher Spinrath 
186f56c9202SChristopher Spinrath 	mod_delayed_work(system_wq, &dvi->hpd_work,
187f56c9202SChristopher Spinrath 			msecs_to_jiffies(HOTPLUG_DEBOUNCE_MS));
188f56c9202SChristopher Spinrath 
189f56c9202SChristopher Spinrath 	return IRQ_HANDLED;
190f56c9202SChristopher Spinrath }
191f56c9202SChristopher Spinrath 
192897dae56SLaurent Pinchart static const struct drm_bridge_timings tfp410_default_timings = {
193897dae56SLaurent Pinchart 	.input_bus_flags = DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE
194897dae56SLaurent Pinchart 			 | DRM_BUS_FLAG_DE_HIGH,
195897dae56SLaurent Pinchart 	.setup_time_ps = 1200,
196897dae56SLaurent Pinchart 	.hold_time_ps = 1300,
197897dae56SLaurent Pinchart };
198897dae56SLaurent Pinchart 
199897dae56SLaurent Pinchart static int tfp410_parse_timings(struct tfp410 *dvi, bool i2c)
200897dae56SLaurent Pinchart {
201897dae56SLaurent Pinchart 	struct drm_bridge_timings *timings = &dvi->timings;
202897dae56SLaurent Pinchart 	struct device_node *ep;
203897dae56SLaurent Pinchart 	u32 pclk_sample = 0;
204*0eb2766dSPeter Ujfalusi 	u32 bus_width = 24;
205897dae56SLaurent Pinchart 	s32 deskew = 0;
206897dae56SLaurent Pinchart 
207897dae56SLaurent Pinchart 	/* Start with defaults. */
208897dae56SLaurent Pinchart 	*timings = tfp410_default_timings;
209897dae56SLaurent Pinchart 
210897dae56SLaurent Pinchart 	if (i2c)
211897dae56SLaurent Pinchart 		/*
212897dae56SLaurent Pinchart 		 * In I2C mode timings are configured through the I2C interface.
213897dae56SLaurent Pinchart 		 * As the driver doesn't support I2C configuration yet, we just
214897dae56SLaurent Pinchart 		 * go with the defaults (BSEL=1, DSEL=1, DKEN=0, EDGE=1).
215897dae56SLaurent Pinchart 		 */
216897dae56SLaurent Pinchart 		return 0;
217897dae56SLaurent Pinchart 
218897dae56SLaurent Pinchart 	/*
219897dae56SLaurent Pinchart 	 * In non-I2C mode, timings are configured through the BSEL, DSEL, DKEN
220897dae56SLaurent Pinchart 	 * and EDGE pins. They are specified in DT through endpoint properties
221897dae56SLaurent Pinchart 	 * and vendor-specific properties.
222897dae56SLaurent Pinchart 	 */
223897dae56SLaurent Pinchart 	ep = of_graph_get_endpoint_by_regs(dvi->dev->of_node, 0, 0);
224897dae56SLaurent Pinchart 	if (!ep)
225897dae56SLaurent Pinchart 		return -EINVAL;
226897dae56SLaurent Pinchart 
227897dae56SLaurent Pinchart 	/* Get the sampling edge from the endpoint. */
228897dae56SLaurent Pinchart 	of_property_read_u32(ep, "pclk-sample", &pclk_sample);
229*0eb2766dSPeter Ujfalusi 	of_property_read_u32(ep, "bus-width", &bus_width);
230897dae56SLaurent Pinchart 	of_node_put(ep);
231897dae56SLaurent Pinchart 
232897dae56SLaurent Pinchart 	timings->input_bus_flags = DRM_BUS_FLAG_DE_HIGH;
233897dae56SLaurent Pinchart 
234897dae56SLaurent Pinchart 	switch (pclk_sample) {
235897dae56SLaurent Pinchart 	case 0:
236897dae56SLaurent Pinchart 		timings->input_bus_flags |= DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE
237897dae56SLaurent Pinchart 					 |  DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE;
238897dae56SLaurent Pinchart 		break;
239897dae56SLaurent Pinchart 	case 1:
240897dae56SLaurent Pinchart 		timings->input_bus_flags |= DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE
241897dae56SLaurent Pinchart 					 |  DRM_BUS_FLAG_SYNC_SAMPLE_POSEDGE;
242897dae56SLaurent Pinchart 		break;
243897dae56SLaurent Pinchart 	default:
244897dae56SLaurent Pinchart 		return -EINVAL;
245897dae56SLaurent Pinchart 	}
246897dae56SLaurent Pinchart 
247*0eb2766dSPeter Ujfalusi 	switch (bus_width) {
248*0eb2766dSPeter Ujfalusi 	case 12:
249*0eb2766dSPeter Ujfalusi 		dvi->bus_format = MEDIA_BUS_FMT_RGB888_2X12_LE;
250*0eb2766dSPeter Ujfalusi 		break;
251*0eb2766dSPeter Ujfalusi 	case 24:
252*0eb2766dSPeter Ujfalusi 		dvi->bus_format = MEDIA_BUS_FMT_RGB888_1X24;
253*0eb2766dSPeter Ujfalusi 		break;
254*0eb2766dSPeter Ujfalusi 	default:
255*0eb2766dSPeter Ujfalusi 		return -EINVAL;
256*0eb2766dSPeter Ujfalusi 	}
257*0eb2766dSPeter Ujfalusi 
258897dae56SLaurent Pinchart 	/* Get the setup and hold time from vendor-specific properties. */
259897dae56SLaurent Pinchart 	of_property_read_u32(dvi->dev->of_node, "ti,deskew", (u32 *)&deskew);
260897dae56SLaurent Pinchart 	if (deskew < -4 || deskew > 3)
261897dae56SLaurent Pinchart 		return -EINVAL;
262897dae56SLaurent Pinchart 
263897dae56SLaurent Pinchart 	timings->setup_time_ps = min(0, 1200 - 350 * deskew);
264897dae56SLaurent Pinchart 	timings->hold_time_ps = min(0, 1300 + 350 * deskew);
265897dae56SLaurent Pinchart 
266897dae56SLaurent Pinchart 	return 0;
267897dae56SLaurent Pinchart }
268897dae56SLaurent Pinchart 
269f56c9202SChristopher Spinrath static int tfp410_get_connector_properties(struct tfp410 *dvi)
270dc55ac3bSJyri Sarha {
27186418f90SRob Herring 	struct device_node *connector_node, *ddc_phandle;
272dc55ac3bSJyri Sarha 	int ret = 0;
273dc55ac3bSJyri Sarha 
274dc55ac3bSJyri Sarha 	/* port@1 is the connector node */
27586418f90SRob Herring 	connector_node = of_graph_get_remote_node(dvi->dev->of_node, 1, -1);
276dc55ac3bSJyri Sarha 	if (!connector_node)
27786418f90SRob Herring 		return -ENODEV;
278dc55ac3bSJyri Sarha 
27960b903c3SLaurent Pinchart 	if (of_device_is_compatible(connector_node, "hdmi-connector"))
28060b903c3SLaurent Pinchart 		dvi->connector_type = DRM_MODE_CONNECTOR_HDMIA;
28160b903c3SLaurent Pinchart 	else
28260b903c3SLaurent Pinchart 		dvi->connector_type = DRM_MODE_CONNECTOR_DVID;
28360b903c3SLaurent Pinchart 
284f56c9202SChristopher Spinrath 	dvi->hpd = fwnode_get_named_gpiod(&connector_node->fwnode,
285f56c9202SChristopher Spinrath 					"hpd-gpios", 0, GPIOD_IN, "hpd");
286f56c9202SChristopher Spinrath 	if (IS_ERR(dvi->hpd)) {
287f56c9202SChristopher Spinrath 		ret = PTR_ERR(dvi->hpd);
288f56c9202SChristopher Spinrath 		dvi->hpd = NULL;
289f56c9202SChristopher Spinrath 		if (ret == -ENOENT)
290f56c9202SChristopher Spinrath 			ret = 0;
291f56c9202SChristopher Spinrath 		else
292f56c9202SChristopher Spinrath 			goto fail;
293f56c9202SChristopher Spinrath 	}
294f56c9202SChristopher Spinrath 
295dc55ac3bSJyri Sarha 	ddc_phandle = of_parse_phandle(connector_node, "ddc-i2c-bus", 0);
296dc55ac3bSJyri Sarha 	if (!ddc_phandle)
297dc55ac3bSJyri Sarha 		goto fail;
298dc55ac3bSJyri Sarha 
299dc55ac3bSJyri Sarha 	dvi->ddc = of_get_i2c_adapter_by_node(ddc_phandle);
300dc55ac3bSJyri Sarha 	if (dvi->ddc)
301dc55ac3bSJyri Sarha 		dev_info(dvi->dev, "Connector's ddc i2c bus found\n");
302dc55ac3bSJyri Sarha 	else
303dc55ac3bSJyri Sarha 		ret = -EPROBE_DEFER;
304dc55ac3bSJyri Sarha 
305dc55ac3bSJyri Sarha 	of_node_put(ddc_phandle);
30686418f90SRob Herring 
30786418f90SRob Herring fail:
30886418f90SRob Herring 	of_node_put(connector_node);
309dc55ac3bSJyri Sarha 	return ret;
310dc55ac3bSJyri Sarha }
311dc55ac3bSJyri Sarha 
312897dae56SLaurent Pinchart static int tfp410_init(struct device *dev, bool i2c)
313dc55ac3bSJyri Sarha {
314dc55ac3bSJyri Sarha 	struct tfp410 *dvi;
315dc55ac3bSJyri Sarha 	int ret;
316dc55ac3bSJyri Sarha 
317dc55ac3bSJyri Sarha 	if (!dev->of_node) {
318dc55ac3bSJyri Sarha 		dev_err(dev, "device-tree data is missing\n");
319dc55ac3bSJyri Sarha 		return -ENXIO;
320dc55ac3bSJyri Sarha 	}
321dc55ac3bSJyri Sarha 
322dc55ac3bSJyri Sarha 	dvi = devm_kzalloc(dev, sizeof(*dvi), GFP_KERNEL);
323dc55ac3bSJyri Sarha 	if (!dvi)
324dc55ac3bSJyri Sarha 		return -ENOMEM;
325dc55ac3bSJyri Sarha 	dev_set_drvdata(dev, dvi);
326dc55ac3bSJyri Sarha 
327dc55ac3bSJyri Sarha 	dvi->bridge.funcs = &tfp410_bridge_funcs;
328dc55ac3bSJyri Sarha 	dvi->bridge.of_node = dev->of_node;
329897dae56SLaurent Pinchart 	dvi->bridge.timings = &dvi->timings;
330dc55ac3bSJyri Sarha 	dvi->dev = dev;
331dc55ac3bSJyri Sarha 
332897dae56SLaurent Pinchart 	ret = tfp410_parse_timings(dvi, i2c);
333897dae56SLaurent Pinchart 	if (ret)
334897dae56SLaurent Pinchart 		goto fail;
335897dae56SLaurent Pinchart 
336f56c9202SChristopher Spinrath 	ret = tfp410_get_connector_properties(dvi);
337dc55ac3bSJyri Sarha 	if (ret)
338dc55ac3bSJyri Sarha 		goto fail;
339dc55ac3bSJyri Sarha 
34038c02db7SLaurent Pinchart 	dvi->powerdown = devm_gpiod_get_optional(dev, "powerdown",
34138c02db7SLaurent Pinchart 						 GPIOD_OUT_HIGH);
34238c02db7SLaurent Pinchart 	if (IS_ERR(dvi->powerdown)) {
34338c02db7SLaurent Pinchart 		dev_err(dev, "failed to parse powerdown gpio\n");
34438c02db7SLaurent Pinchart 		return PTR_ERR(dvi->powerdown);
34538c02db7SLaurent Pinchart 	}
34638c02db7SLaurent Pinchart 
3473d31e215SPeter Ujfalusi 	if (dvi->hpd)
3483d31e215SPeter Ujfalusi 		dvi->hpd_irq = gpiod_to_irq(dvi->hpd);
3493d31e215SPeter Ujfalusi 	else
3503d31e215SPeter Ujfalusi 		dvi->hpd_irq = -ENXIO;
3513d31e215SPeter Ujfalusi 
3523d31e215SPeter Ujfalusi 	if (dvi->hpd_irq >= 0) {
353f56c9202SChristopher Spinrath 		INIT_DELAYED_WORK(&dvi->hpd_work, tfp410_hpd_work_func);
354f56c9202SChristopher Spinrath 
3553d31e215SPeter Ujfalusi 		ret = devm_request_threaded_irq(dev, dvi->hpd_irq,
356f56c9202SChristopher Spinrath 			NULL, tfp410_hpd_irq_thread, IRQF_TRIGGER_RISING |
357f56c9202SChristopher Spinrath 			IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
358f56c9202SChristopher Spinrath 			"hdmi-hpd", dvi);
359f56c9202SChristopher Spinrath 		if (ret) {
360f56c9202SChristopher Spinrath 			DRM_ERROR("failed to register hpd interrupt\n");
361f56c9202SChristopher Spinrath 			goto fail;
362f56c9202SChristopher Spinrath 		}
363f56c9202SChristopher Spinrath 	}
364f56c9202SChristopher Spinrath 
365f74c5275SInki Dae 	drm_bridge_add(&dvi->bridge);
366dc55ac3bSJyri Sarha 
367dc55ac3bSJyri Sarha 	return 0;
368dc55ac3bSJyri Sarha fail:
369dc55ac3bSJyri Sarha 	i2c_put_adapter(dvi->ddc);
370f56c9202SChristopher Spinrath 	if (dvi->hpd)
371f56c9202SChristopher Spinrath 		gpiod_put(dvi->hpd);
372dc55ac3bSJyri Sarha 	return ret;
373dc55ac3bSJyri Sarha }
374dc55ac3bSJyri Sarha 
375dc55ac3bSJyri Sarha static int tfp410_fini(struct device *dev)
376dc55ac3bSJyri Sarha {
377dc55ac3bSJyri Sarha 	struct tfp410 *dvi = dev_get_drvdata(dev);
378dc55ac3bSJyri Sarha 
379f56c9202SChristopher Spinrath 	cancel_delayed_work_sync(&dvi->hpd_work);
380f56c9202SChristopher Spinrath 
381dc55ac3bSJyri Sarha 	drm_bridge_remove(&dvi->bridge);
382dc55ac3bSJyri Sarha 
383dc55ac3bSJyri Sarha 	if (dvi->ddc)
384dc55ac3bSJyri Sarha 		i2c_put_adapter(dvi->ddc);
385f56c9202SChristopher Spinrath 	if (dvi->hpd)
386f56c9202SChristopher Spinrath 		gpiod_put(dvi->hpd);
387dc55ac3bSJyri Sarha 
388dc55ac3bSJyri Sarha 	return 0;
389dc55ac3bSJyri Sarha }
390dc55ac3bSJyri Sarha 
391dc55ac3bSJyri Sarha static int tfp410_probe(struct platform_device *pdev)
392dc55ac3bSJyri Sarha {
393897dae56SLaurent Pinchart 	return tfp410_init(&pdev->dev, false);
394dc55ac3bSJyri Sarha }
395dc55ac3bSJyri Sarha 
396dc55ac3bSJyri Sarha static int tfp410_remove(struct platform_device *pdev)
397dc55ac3bSJyri Sarha {
398dc55ac3bSJyri Sarha 	return tfp410_fini(&pdev->dev);
399dc55ac3bSJyri Sarha }
400dc55ac3bSJyri Sarha 
401dc55ac3bSJyri Sarha static const struct of_device_id tfp410_match[] = {
402dc55ac3bSJyri Sarha 	{ .compatible = "ti,tfp410" },
403dc55ac3bSJyri Sarha 	{},
404dc55ac3bSJyri Sarha };
405dc55ac3bSJyri Sarha MODULE_DEVICE_TABLE(of, tfp410_match);
406dc55ac3bSJyri Sarha 
4075b47d089SWei Yongjun static struct platform_driver tfp410_platform_driver = {
408dc55ac3bSJyri Sarha 	.probe	= tfp410_probe,
409dc55ac3bSJyri Sarha 	.remove	= tfp410_remove,
410dc55ac3bSJyri Sarha 	.driver	= {
411dc55ac3bSJyri Sarha 		.name		= "tfp410-bridge",
412dc55ac3bSJyri Sarha 		.of_match_table	= tfp410_match,
413dc55ac3bSJyri Sarha 	},
414dc55ac3bSJyri Sarha };
415dc55ac3bSJyri Sarha 
416dc55ac3bSJyri Sarha #if IS_ENABLED(CONFIG_I2C)
417dc55ac3bSJyri Sarha /* There is currently no i2c functionality. */
418dc55ac3bSJyri Sarha static int tfp410_i2c_probe(struct i2c_client *client,
419dc55ac3bSJyri Sarha 			    const struct i2c_device_id *id)
420dc55ac3bSJyri Sarha {
421dc55ac3bSJyri Sarha 	int reg;
422dc55ac3bSJyri Sarha 
423dc55ac3bSJyri Sarha 	if (!client->dev.of_node ||
424dc55ac3bSJyri Sarha 	    of_property_read_u32(client->dev.of_node, "reg", &reg)) {
425dc55ac3bSJyri Sarha 		dev_err(&client->dev,
426dc55ac3bSJyri Sarha 			"Can't get i2c reg property from device-tree\n");
427dc55ac3bSJyri Sarha 		return -ENXIO;
428dc55ac3bSJyri Sarha 	}
429dc55ac3bSJyri Sarha 
430897dae56SLaurent Pinchart 	return tfp410_init(&client->dev, true);
431dc55ac3bSJyri Sarha }
432dc55ac3bSJyri Sarha 
433dc55ac3bSJyri Sarha static int tfp410_i2c_remove(struct i2c_client *client)
434dc55ac3bSJyri Sarha {
435dc55ac3bSJyri Sarha 	return tfp410_fini(&client->dev);
436dc55ac3bSJyri Sarha }
437dc55ac3bSJyri Sarha 
438dc55ac3bSJyri Sarha static const struct i2c_device_id tfp410_i2c_ids[] = {
439dc55ac3bSJyri Sarha 	{ "tfp410", 0 },
440dc55ac3bSJyri Sarha 	{ }
441dc55ac3bSJyri Sarha };
442dc55ac3bSJyri Sarha MODULE_DEVICE_TABLE(i2c, tfp410_i2c_ids);
443dc55ac3bSJyri Sarha 
444dc55ac3bSJyri Sarha static struct i2c_driver tfp410_i2c_driver = {
445dc55ac3bSJyri Sarha 	.driver = {
446dc55ac3bSJyri Sarha 		.name	= "tfp410",
447dc55ac3bSJyri Sarha 		.of_match_table = of_match_ptr(tfp410_match),
448dc55ac3bSJyri Sarha 	},
449dc55ac3bSJyri Sarha 	.id_table	= tfp410_i2c_ids,
450dc55ac3bSJyri Sarha 	.probe		= tfp410_i2c_probe,
451dc55ac3bSJyri Sarha 	.remove		= tfp410_i2c_remove,
452dc55ac3bSJyri Sarha };
453dc55ac3bSJyri Sarha #endif /* IS_ENABLED(CONFIG_I2C) */
454dc55ac3bSJyri Sarha 
455dc55ac3bSJyri Sarha static struct {
456dc55ac3bSJyri Sarha 	uint i2c:1;
457dc55ac3bSJyri Sarha 	uint platform:1;
458dc55ac3bSJyri Sarha }  tfp410_registered_driver;
459dc55ac3bSJyri Sarha 
460dc55ac3bSJyri Sarha static int __init tfp410_module_init(void)
461dc55ac3bSJyri Sarha {
462dc55ac3bSJyri Sarha 	int ret;
463dc55ac3bSJyri Sarha 
464dc55ac3bSJyri Sarha #if IS_ENABLED(CONFIG_I2C)
465dc55ac3bSJyri Sarha 	ret = i2c_add_driver(&tfp410_i2c_driver);
466dc55ac3bSJyri Sarha 	if (ret)
467dc55ac3bSJyri Sarha 		pr_err("%s: registering i2c driver failed: %d",
468dc55ac3bSJyri Sarha 		       __func__, ret);
469dc55ac3bSJyri Sarha 	else
470dc55ac3bSJyri Sarha 		tfp410_registered_driver.i2c = 1;
471dc55ac3bSJyri Sarha #endif
472dc55ac3bSJyri Sarha 
473dc55ac3bSJyri Sarha 	ret = platform_driver_register(&tfp410_platform_driver);
474dc55ac3bSJyri Sarha 	if (ret)
475dc55ac3bSJyri Sarha 		pr_err("%s: registering platform driver failed: %d",
476dc55ac3bSJyri Sarha 		       __func__, ret);
477dc55ac3bSJyri Sarha 	else
478dc55ac3bSJyri Sarha 		tfp410_registered_driver.platform = 1;
479dc55ac3bSJyri Sarha 
480dc55ac3bSJyri Sarha 	if (tfp410_registered_driver.i2c ||
481dc55ac3bSJyri Sarha 	    tfp410_registered_driver.platform)
482dc55ac3bSJyri Sarha 		return 0;
483dc55ac3bSJyri Sarha 
484dc55ac3bSJyri Sarha 	return ret;
485dc55ac3bSJyri Sarha }
486dc55ac3bSJyri Sarha module_init(tfp410_module_init);
487dc55ac3bSJyri Sarha 
488dc55ac3bSJyri Sarha static void __exit tfp410_module_exit(void)
489dc55ac3bSJyri Sarha {
490dc55ac3bSJyri Sarha #if IS_ENABLED(CONFIG_I2C)
491dc55ac3bSJyri Sarha 	if (tfp410_registered_driver.i2c)
492dc55ac3bSJyri Sarha 		i2c_del_driver(&tfp410_i2c_driver);
493dc55ac3bSJyri Sarha #endif
494dc55ac3bSJyri Sarha 	if (tfp410_registered_driver.platform)
495dc55ac3bSJyri Sarha 		platform_driver_unregister(&tfp410_platform_driver);
496dc55ac3bSJyri Sarha }
497dc55ac3bSJyri Sarha module_exit(tfp410_module_exit);
498dc55ac3bSJyri Sarha 
499dc55ac3bSJyri Sarha MODULE_AUTHOR("Jyri Sarha <jsarha@ti.com>");
500dc55ac3bSJyri Sarha MODULE_DESCRIPTION("TI TFP410 DVI bridge driver");
501dc55ac3bSJyri Sarha MODULE_LICENSE("GPL");
502