xref: /linux/drivers/gpu/drm/amd/amdkfd/kfd_topology.c (revision c909a49128a31bced8cfbd2dfb0a4fe56e01a6d0)
1 // SPDX-License-Identifier: GPL-2.0 OR MIT
2 /*
3  * Copyright 2014-2022 Advanced Micro Devices, Inc.
4  *
5  * Permission is hereby granted, free of charge, to any person obtaining a
6  * copy of this software and associated documentation files (the "Software"),
7  * to deal in the Software without restriction, including without limitation
8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9  * and/or sell copies of the Software, and to permit persons to whom the
10  * Software is furnished to do so, subject to the following conditions:
11  *
12  * The above copyright notice and this permission notice shall be included in
13  * all copies or substantial portions of the Software.
14  *
15  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
18  * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
19  * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
20  * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
21  * OTHER DEALINGS IN THE SOFTWARE.
22  */
23 
24 #include <linux/types.h>
25 #include <linux/kernel.h>
26 #include <linux/pci.h>
27 #include <linux/errno.h>
28 #include <linux/acpi.h>
29 #include <linux/hash.h>
30 #include <linux/cpufreq.h>
31 #include <linux/log2.h>
32 #include <linux/dmi.h>
33 #include <linux/atomic.h>
34 #include <linux/crc16.h>
35 
36 #include "kfd_priv.h"
37 #include "kfd_crat.h"
38 #include "kfd_topology.h"
39 #include "kfd_device_queue_manager.h"
40 #include "kfd_svm.h"
41 #include "kfd_debug.h"
42 #include "amdgpu_amdkfd.h"
43 #include "amdgpu_ras.h"
44 #include "amdgpu.h"
45 
46 /* topology_device_list - Master list of all topology devices */
47 static struct list_head topology_device_list;
48 static struct kfd_system_properties sys_props;
49 
50 static DECLARE_RWSEM(topology_lock);
51 static uint32_t topology_crat_proximity_domain;
52 
53 struct kfd_topology_device *kfd_topology_device_by_proximity_domain_no_lock(
54 						uint32_t proximity_domain)
55 {
56 	struct kfd_topology_device *top_dev;
57 	struct kfd_topology_device *device = NULL;
58 
59 	list_for_each_entry(top_dev, &topology_device_list, list)
60 		if (top_dev->proximity_domain == proximity_domain) {
61 			device = top_dev;
62 			break;
63 		}
64 
65 	return device;
66 }
67 
68 struct kfd_topology_device *kfd_topology_device_by_proximity_domain(
69 						uint32_t proximity_domain)
70 {
71 	struct kfd_topology_device *device = NULL;
72 
73 	down_read(&topology_lock);
74 
75 	device = kfd_topology_device_by_proximity_domain_no_lock(
76 							proximity_domain);
77 	up_read(&topology_lock);
78 
79 	return device;
80 }
81 
82 struct kfd_topology_device *kfd_topology_device_by_id(uint32_t gpu_id)
83 {
84 	struct kfd_topology_device *top_dev = NULL;
85 	struct kfd_topology_device *ret = NULL;
86 
87 	down_read(&topology_lock);
88 
89 	list_for_each_entry(top_dev, &topology_device_list, list)
90 		if (top_dev->gpu_id == gpu_id) {
91 			ret = top_dev;
92 			break;
93 		}
94 
95 	up_read(&topology_lock);
96 
97 	return ret;
98 }
99 
100 struct kfd_node *kfd_device_by_id(uint32_t gpu_id)
101 {
102 	struct kfd_topology_device *top_dev;
103 
104 	top_dev = kfd_topology_device_by_id(gpu_id);
105 	if (!top_dev)
106 		return NULL;
107 
108 	return top_dev->gpu;
109 }
110 
111 /* Called with write topology_lock acquired */
112 static void kfd_release_topology_device(struct kfd_topology_device *dev)
113 {
114 	struct kfd_mem_properties *mem;
115 	struct kfd_cache_properties *cache;
116 	struct kfd_iolink_properties *iolink;
117 	struct kfd_iolink_properties *p2plink;
118 	struct kfd_perf_properties *perf;
119 
120 	list_del(&dev->list);
121 
122 	while (dev->mem_props.next != &dev->mem_props) {
123 		mem = container_of(dev->mem_props.next,
124 				struct kfd_mem_properties, list);
125 		list_del(&mem->list);
126 		kfree(mem);
127 	}
128 
129 	while (dev->cache_props.next != &dev->cache_props) {
130 		cache = container_of(dev->cache_props.next,
131 				struct kfd_cache_properties, list);
132 		list_del(&cache->list);
133 		kfree(cache);
134 	}
135 
136 	while (dev->io_link_props.next != &dev->io_link_props) {
137 		iolink = container_of(dev->io_link_props.next,
138 				struct kfd_iolink_properties, list);
139 		list_del(&iolink->list);
140 		kfree(iolink);
141 	}
142 
143 	while (dev->p2p_link_props.next != &dev->p2p_link_props) {
144 		p2plink = container_of(dev->p2p_link_props.next,
145 				struct kfd_iolink_properties, list);
146 		list_del(&p2plink->list);
147 		kfree(p2plink);
148 	}
149 
150 	while (dev->perf_props.next != &dev->perf_props) {
151 		perf = container_of(dev->perf_props.next,
152 				struct kfd_perf_properties, list);
153 		list_del(&perf->list);
154 		kfree(perf);
155 	}
156 
157 	kfree(dev);
158 }
159 
160 void kfd_release_topology_device_list(struct list_head *device_list)
161 {
162 	struct kfd_topology_device *dev;
163 
164 	while (!list_empty(device_list)) {
165 		dev = list_first_entry(device_list,
166 				       struct kfd_topology_device, list);
167 		kfd_release_topology_device(dev);
168 	}
169 }
170 
171 static void kfd_release_live_view(void)
172 {
173 	kfd_release_topology_device_list(&topology_device_list);
174 	memset(&sys_props, 0, sizeof(sys_props));
175 }
176 
177 struct kfd_topology_device *kfd_create_topology_device(
178 				struct list_head *device_list)
179 {
180 	struct kfd_topology_device *dev;
181 
182 	dev = kfd_alloc_struct(dev);
183 	if (!dev) {
184 		pr_err("No memory to allocate a topology device");
185 		return NULL;
186 	}
187 
188 	INIT_LIST_HEAD(&dev->mem_props);
189 	INIT_LIST_HEAD(&dev->cache_props);
190 	INIT_LIST_HEAD(&dev->io_link_props);
191 	INIT_LIST_HEAD(&dev->p2p_link_props);
192 	INIT_LIST_HEAD(&dev->perf_props);
193 
194 	list_add_tail(&dev->list, device_list);
195 
196 	return dev;
197 }
198 
199 
200 #define sysfs_show_gen_prop(buffer, offs, fmt, ...)		\
201 		(offs += snprintf(buffer+offs, PAGE_SIZE-offs,	\
202 				  fmt, __VA_ARGS__))
203 #define sysfs_show_32bit_prop(buffer, offs, name, value) \
204 		sysfs_show_gen_prop(buffer, offs, "%s %u\n", name, value)
205 #define sysfs_show_64bit_prop(buffer, offs, name, value) \
206 		sysfs_show_gen_prop(buffer, offs, "%s %llu\n", name, value)
207 #define sysfs_show_32bit_val(buffer, offs, value) \
208 		sysfs_show_gen_prop(buffer, offs, "%u\n", value)
209 #define sysfs_show_str_val(buffer, offs, value) \
210 		sysfs_show_gen_prop(buffer, offs, "%s\n", value)
211 
212 static ssize_t sysprops_show(struct kobject *kobj, struct attribute *attr,
213 		char *buffer)
214 {
215 	int offs = 0;
216 
217 	/* Making sure that the buffer is an empty string */
218 	buffer[0] = 0;
219 
220 	if (attr == &sys_props.attr_genid) {
221 		sysfs_show_32bit_val(buffer, offs,
222 				     sys_props.generation_count);
223 	} else if (attr == &sys_props.attr_props) {
224 		sysfs_show_64bit_prop(buffer, offs, "platform_oem",
225 				      sys_props.platform_oem);
226 		sysfs_show_64bit_prop(buffer, offs, "platform_id",
227 				      sys_props.platform_id);
228 		sysfs_show_64bit_prop(buffer, offs, "platform_rev",
229 				      sys_props.platform_rev);
230 	} else {
231 		offs = -EINVAL;
232 	}
233 
234 	return offs;
235 }
236 
237 static void kfd_topology_kobj_release(struct kobject *kobj)
238 {
239 	kfree(kobj);
240 }
241 
242 static const struct sysfs_ops sysprops_ops = {
243 	.show = sysprops_show,
244 };
245 
246 static const struct kobj_type sysprops_type = {
247 	.release = kfd_topology_kobj_release,
248 	.sysfs_ops = &sysprops_ops,
249 };
250 
251 static ssize_t iolink_show(struct kobject *kobj, struct attribute *attr,
252 		char *buffer)
253 {
254 	int offs = 0;
255 	struct kfd_iolink_properties *iolink;
256 
257 	/* Making sure that the buffer is an empty string */
258 	buffer[0] = 0;
259 
260 	iolink = container_of(attr, struct kfd_iolink_properties, attr);
261 	if (iolink->gpu && kfd_devcgroup_check_permission(iolink->gpu))
262 		return -EPERM;
263 	sysfs_show_32bit_prop(buffer, offs, "type", iolink->iolink_type);
264 	sysfs_show_32bit_prop(buffer, offs, "version_major", iolink->ver_maj);
265 	sysfs_show_32bit_prop(buffer, offs, "version_minor", iolink->ver_min);
266 	sysfs_show_32bit_prop(buffer, offs, "node_from", iolink->node_from);
267 	sysfs_show_32bit_prop(buffer, offs, "node_to", iolink->node_to);
268 	sysfs_show_32bit_prop(buffer, offs, "weight", iolink->weight);
269 	sysfs_show_32bit_prop(buffer, offs, "min_latency", iolink->min_latency);
270 	sysfs_show_32bit_prop(buffer, offs, "max_latency", iolink->max_latency);
271 	sysfs_show_32bit_prop(buffer, offs, "min_bandwidth",
272 			      iolink->min_bandwidth);
273 	sysfs_show_32bit_prop(buffer, offs, "max_bandwidth",
274 			      iolink->max_bandwidth);
275 	sysfs_show_32bit_prop(buffer, offs, "recommended_transfer_size",
276 			      iolink->rec_transfer_size);
277 	sysfs_show_32bit_prop(buffer, offs, "recommended_sdma_engine_id_mask",
278 			      iolink->rec_sdma_eng_id_mask);
279 	sysfs_show_32bit_prop(buffer, offs, "flags", iolink->flags);
280 
281 	return offs;
282 }
283 
284 static const struct sysfs_ops iolink_ops = {
285 	.show = iolink_show,
286 };
287 
288 static const struct kobj_type iolink_type = {
289 	.release = kfd_topology_kobj_release,
290 	.sysfs_ops = &iolink_ops,
291 };
292 
293 static ssize_t mem_show(struct kobject *kobj, struct attribute *attr,
294 		char *buffer)
295 {
296 	int offs = 0;
297 	struct kfd_mem_properties *mem;
298 
299 	/* Making sure that the buffer is an empty string */
300 	buffer[0] = 0;
301 
302 	mem = container_of(attr, struct kfd_mem_properties, attr);
303 	if (mem->gpu && kfd_devcgroup_check_permission(mem->gpu))
304 		return -EPERM;
305 	sysfs_show_32bit_prop(buffer, offs, "heap_type", mem->heap_type);
306 	sysfs_show_64bit_prop(buffer, offs, "size_in_bytes",
307 			      mem->size_in_bytes);
308 	sysfs_show_32bit_prop(buffer, offs, "flags", mem->flags);
309 	sysfs_show_32bit_prop(buffer, offs, "width", mem->width);
310 	sysfs_show_32bit_prop(buffer, offs, "mem_clk_max",
311 			      mem->mem_clk_max);
312 
313 	return offs;
314 }
315 
316 static const struct sysfs_ops mem_ops = {
317 	.show = mem_show,
318 };
319 
320 static const struct kobj_type mem_type = {
321 	.release = kfd_topology_kobj_release,
322 	.sysfs_ops = &mem_ops,
323 };
324 
325 static ssize_t kfd_cache_show(struct kobject *kobj, struct attribute *attr,
326 		char *buffer)
327 {
328 	int offs = 0;
329 	uint32_t i, j;
330 	struct kfd_cache_properties *cache;
331 
332 	/* Making sure that the buffer is an empty string */
333 	buffer[0] = 0;
334 	cache = container_of(attr, struct kfd_cache_properties, attr);
335 	if (cache->gpu && kfd_devcgroup_check_permission(cache->gpu))
336 		return -EPERM;
337 	sysfs_show_32bit_prop(buffer, offs, "processor_id_low",
338 			cache->processor_id_low);
339 	sysfs_show_32bit_prop(buffer, offs, "level", cache->cache_level);
340 	sysfs_show_32bit_prop(buffer, offs, "size", cache->cache_size);
341 	sysfs_show_32bit_prop(buffer, offs, "cache_line_size",
342 			      cache->cacheline_size);
343 	sysfs_show_32bit_prop(buffer, offs, "cache_lines_per_tag",
344 			      cache->cachelines_per_tag);
345 	sysfs_show_32bit_prop(buffer, offs, "association", cache->cache_assoc);
346 	sysfs_show_32bit_prop(buffer, offs, "latency", cache->cache_latency);
347 	sysfs_show_32bit_prop(buffer, offs, "type", cache->cache_type);
348 
349 	offs += snprintf(buffer+offs, PAGE_SIZE-offs, "sibling_map ");
350 	for (i = 0; i < cache->sibling_map_size; i++)
351 		for (j = 0; j < sizeof(cache->sibling_map[0])*8; j++)
352 			/* Check each bit */
353 			offs += snprintf(buffer+offs, PAGE_SIZE-offs, "%d,",
354 						(cache->sibling_map[i] >> j) & 1);
355 
356 	/* Replace the last "," with end of line */
357 	buffer[offs-1] = '\n';
358 	return offs;
359 }
360 
361 static const struct sysfs_ops cache_ops = {
362 	.show = kfd_cache_show,
363 };
364 
365 static const struct kobj_type cache_type = {
366 	.release = kfd_topology_kobj_release,
367 	.sysfs_ops = &cache_ops,
368 };
369 
370 /****** Sysfs of Performance Counters ******/
371 
372 struct kfd_perf_attr {
373 	struct kobj_attribute attr;
374 	uint32_t data;
375 };
376 
377 static ssize_t perf_show(struct kobject *kobj, struct kobj_attribute *attrs,
378 			char *buf)
379 {
380 	int offs = 0;
381 	struct kfd_perf_attr *attr;
382 
383 	buf[0] = 0;
384 	attr = container_of(attrs, struct kfd_perf_attr, attr);
385 	if (!attr->data) /* invalid data for PMC */
386 		return 0;
387 	else
388 		return sysfs_show_32bit_val(buf, offs, attr->data);
389 }
390 
391 #define KFD_PERF_DESC(_name, _data)			\
392 {							\
393 	.attr  = __ATTR(_name, 0444, perf_show, NULL),	\
394 	.data = _data,					\
395 }
396 
397 static struct kfd_perf_attr perf_attr_iommu[] = {
398 	KFD_PERF_DESC(max_concurrent, 0),
399 	KFD_PERF_DESC(num_counters, 0),
400 	KFD_PERF_DESC(counter_ids, 0),
401 };
402 /****************************************/
403 
404 static ssize_t node_show(struct kobject *kobj, struct attribute *attr,
405 		char *buffer)
406 {
407 	int offs = 0;
408 	struct kfd_topology_device *dev;
409 	uint32_t log_max_watch_addr;
410 
411 	/* Making sure that the buffer is an empty string */
412 	buffer[0] = 0;
413 
414 	if (strcmp(attr->name, "gpu_id") == 0) {
415 		dev = container_of(attr, struct kfd_topology_device,
416 				attr_gpuid);
417 		if (dev->gpu && kfd_devcgroup_check_permission(dev->gpu))
418 			return -EPERM;
419 		return sysfs_show_32bit_val(buffer, offs, dev->gpu_id);
420 	}
421 
422 	if (strcmp(attr->name, "name") == 0) {
423 		dev = container_of(attr, struct kfd_topology_device,
424 				attr_name);
425 
426 		if (dev->gpu && kfd_devcgroup_check_permission(dev->gpu))
427 			return -EPERM;
428 		return sysfs_show_str_val(buffer, offs, dev->node_props.name);
429 	}
430 
431 	dev = container_of(attr, struct kfd_topology_device,
432 			attr_props);
433 	if (dev->gpu && kfd_devcgroup_check_permission(dev->gpu))
434 		return -EPERM;
435 	sysfs_show_32bit_prop(buffer, offs, "cpu_cores_count",
436 			      dev->node_props.cpu_cores_count);
437 	sysfs_show_32bit_prop(buffer, offs, "simd_count",
438 			      dev->gpu ? dev->node_props.simd_count : 0);
439 	sysfs_show_32bit_prop(buffer, offs, "mem_banks_count",
440 			      dev->node_props.mem_banks_count);
441 	sysfs_show_32bit_prop(buffer, offs, "caches_count",
442 			      dev->node_props.caches_count);
443 	sysfs_show_32bit_prop(buffer, offs, "io_links_count",
444 			      dev->node_props.io_links_count);
445 	sysfs_show_32bit_prop(buffer, offs, "p2p_links_count",
446 			      dev->node_props.p2p_links_count);
447 	sysfs_show_32bit_prop(buffer, offs, "cpu_core_id_base",
448 			      dev->node_props.cpu_core_id_base);
449 	sysfs_show_32bit_prop(buffer, offs, "simd_id_base",
450 			      dev->node_props.simd_id_base);
451 	sysfs_show_32bit_prop(buffer, offs, "max_waves_per_simd",
452 			      dev->node_props.max_waves_per_simd);
453 	sysfs_show_32bit_prop(buffer, offs, "lds_size_in_kb",
454 			      dev->node_props.lds_size_in_kb);
455 	sysfs_show_32bit_prop(buffer, offs, "gds_size_in_kb",
456 			      dev->node_props.gds_size_in_kb);
457 	sysfs_show_32bit_prop(buffer, offs, "num_gws",
458 			      dev->node_props.num_gws);
459 	sysfs_show_32bit_prop(buffer, offs, "wave_front_size",
460 			      dev->node_props.wave_front_size);
461 	sysfs_show_32bit_prop(buffer, offs, "array_count",
462 			      dev->gpu ? (dev->node_props.array_count *
463 					  NUM_XCC(dev->gpu->xcc_mask)) : 0);
464 	sysfs_show_32bit_prop(buffer, offs, "simd_arrays_per_engine",
465 			      dev->node_props.simd_arrays_per_engine);
466 	sysfs_show_32bit_prop(buffer, offs, "cu_per_simd_array",
467 			      dev->node_props.cu_per_simd_array);
468 	sysfs_show_32bit_prop(buffer, offs, "simd_per_cu",
469 			      dev->node_props.simd_per_cu);
470 	sysfs_show_32bit_prop(buffer, offs, "max_slots_scratch_cu",
471 			      dev->node_props.max_slots_scratch_cu);
472 	sysfs_show_32bit_prop(buffer, offs, "gfx_target_version",
473 			      dev->node_props.gfx_target_version);
474 	sysfs_show_32bit_prop(buffer, offs, "vendor_id",
475 			      dev->node_props.vendor_id);
476 	sysfs_show_32bit_prop(buffer, offs, "device_id",
477 			      dev->node_props.device_id);
478 	sysfs_show_32bit_prop(buffer, offs, "location_id",
479 			      dev->node_props.location_id);
480 	sysfs_show_32bit_prop(buffer, offs, "domain",
481 			      dev->node_props.domain);
482 	sysfs_show_32bit_prop(buffer, offs, "drm_render_minor",
483 			      dev->node_props.drm_render_minor);
484 	sysfs_show_64bit_prop(buffer, offs, "hive_id",
485 			      dev->node_props.hive_id);
486 	sysfs_show_32bit_prop(buffer, offs, "num_sdma_engines",
487 			      dev->node_props.num_sdma_engines);
488 	sysfs_show_32bit_prop(buffer, offs, "num_sdma_xgmi_engines",
489 			      dev->node_props.num_sdma_xgmi_engines);
490 	sysfs_show_32bit_prop(buffer, offs, "num_sdma_queues_per_engine",
491 			      dev->node_props.num_sdma_queues_per_engine);
492 	sysfs_show_32bit_prop(buffer, offs, "num_cp_queues",
493 			      dev->node_props.num_cp_queues);
494 
495 	if (dev->gpu) {
496 		log_max_watch_addr =
497 			__ilog2_u32(dev->gpu->kfd->device_info.num_of_watch_points);
498 
499 		if (log_max_watch_addr) {
500 			dev->node_props.capability |=
501 					HSA_CAP_WATCH_POINTS_SUPPORTED;
502 
503 			dev->node_props.capability |=
504 				((log_max_watch_addr <<
505 					HSA_CAP_WATCH_POINTS_TOTALBITS_SHIFT) &
506 				HSA_CAP_WATCH_POINTS_TOTALBITS_MASK);
507 		}
508 
509 		if (dev->gpu->adev->asic_type == CHIP_TONGA)
510 			dev->node_props.capability |=
511 					HSA_CAP_AQL_QUEUE_DOUBLE_MAP;
512 
513 		sysfs_show_32bit_prop(buffer, offs, "max_engine_clk_fcompute",
514 			dev->node_props.max_engine_clk_fcompute);
515 
516 		sysfs_show_64bit_prop(buffer, offs, "local_mem_size", 0ULL);
517 
518 		sysfs_show_32bit_prop(buffer, offs, "fw_version",
519 				      dev->gpu->kfd->mec_fw_version);
520 		sysfs_show_32bit_prop(buffer, offs, "capability",
521 				      dev->node_props.capability);
522 		sysfs_show_64bit_prop(buffer, offs, "debug_prop",
523 				      dev->node_props.debug_prop);
524 		sysfs_show_32bit_prop(buffer, offs, "sdma_fw_version",
525 				      dev->gpu->kfd->sdma_fw_version);
526 		sysfs_show_64bit_prop(buffer, offs, "unique_id",
527 				      dev->gpu->adev->unique_id);
528 		sysfs_show_32bit_prop(buffer, offs, "num_xcc",
529 				      NUM_XCC(dev->gpu->xcc_mask));
530 	}
531 
532 	return sysfs_show_32bit_prop(buffer, offs, "max_engine_clk_ccompute",
533 				     cpufreq_quick_get_max(0)/1000);
534 }
535 
536 static const struct sysfs_ops node_ops = {
537 	.show = node_show,
538 };
539 
540 static const struct kobj_type node_type = {
541 	.release = kfd_topology_kobj_release,
542 	.sysfs_ops = &node_ops,
543 };
544 
545 static void kfd_remove_sysfs_file(struct kobject *kobj, struct attribute *attr)
546 {
547 	sysfs_remove_file(kobj, attr);
548 	kobject_del(kobj);
549 	kobject_put(kobj);
550 }
551 
552 static void kfd_remove_sysfs_node_entry(struct kfd_topology_device *dev)
553 {
554 	struct kfd_iolink_properties *p2plink;
555 	struct kfd_iolink_properties *iolink;
556 	struct kfd_cache_properties *cache;
557 	struct kfd_mem_properties *mem;
558 	struct kfd_perf_properties *perf;
559 
560 	if (dev->kobj_iolink) {
561 		list_for_each_entry(iolink, &dev->io_link_props, list)
562 			if (iolink->kobj) {
563 				kfd_remove_sysfs_file(iolink->kobj,
564 							&iolink->attr);
565 				iolink->kobj = NULL;
566 			}
567 		kobject_del(dev->kobj_iolink);
568 		kobject_put(dev->kobj_iolink);
569 		dev->kobj_iolink = NULL;
570 	}
571 
572 	if (dev->kobj_p2plink) {
573 		list_for_each_entry(p2plink, &dev->p2p_link_props, list)
574 			if (p2plink->kobj) {
575 				kfd_remove_sysfs_file(p2plink->kobj,
576 							&p2plink->attr);
577 				p2plink->kobj = NULL;
578 			}
579 		kobject_del(dev->kobj_p2plink);
580 		kobject_put(dev->kobj_p2plink);
581 		dev->kobj_p2plink = NULL;
582 	}
583 
584 	if (dev->kobj_cache) {
585 		list_for_each_entry(cache, &dev->cache_props, list)
586 			if (cache->kobj) {
587 				kfd_remove_sysfs_file(cache->kobj,
588 							&cache->attr);
589 				cache->kobj = NULL;
590 			}
591 		kobject_del(dev->kobj_cache);
592 		kobject_put(dev->kobj_cache);
593 		dev->kobj_cache = NULL;
594 	}
595 
596 	if (dev->kobj_mem) {
597 		list_for_each_entry(mem, &dev->mem_props, list)
598 			if (mem->kobj) {
599 				kfd_remove_sysfs_file(mem->kobj, &mem->attr);
600 				mem->kobj = NULL;
601 			}
602 		kobject_del(dev->kobj_mem);
603 		kobject_put(dev->kobj_mem);
604 		dev->kobj_mem = NULL;
605 	}
606 
607 	if (dev->kobj_perf) {
608 		list_for_each_entry(perf, &dev->perf_props, list) {
609 			kfree(perf->attr_group);
610 			perf->attr_group = NULL;
611 		}
612 		kobject_del(dev->kobj_perf);
613 		kobject_put(dev->kobj_perf);
614 		dev->kobj_perf = NULL;
615 	}
616 
617 	if (dev->kobj_node) {
618 		sysfs_remove_file(dev->kobj_node, &dev->attr_gpuid);
619 		sysfs_remove_file(dev->kobj_node, &dev->attr_name);
620 		sysfs_remove_file(dev->kobj_node, &dev->attr_props);
621 		kobject_del(dev->kobj_node);
622 		kobject_put(dev->kobj_node);
623 		dev->kobj_node = NULL;
624 	}
625 }
626 
627 static int kfd_build_sysfs_node_entry(struct kfd_topology_device *dev,
628 		uint32_t id)
629 {
630 	struct kfd_iolink_properties *p2plink;
631 	struct kfd_iolink_properties *iolink;
632 	struct kfd_cache_properties *cache;
633 	struct kfd_mem_properties *mem;
634 	struct kfd_perf_properties *perf;
635 	int ret;
636 	uint32_t i, num_attrs;
637 	struct attribute **attrs;
638 
639 	if (WARN_ON(dev->kobj_node))
640 		return -EEXIST;
641 
642 	/*
643 	 * Creating the sysfs folders
644 	 */
645 	dev->kobj_node = kfd_alloc_struct(dev->kobj_node);
646 	if (!dev->kobj_node)
647 		return -ENOMEM;
648 
649 	ret = kobject_init_and_add(dev->kobj_node, &node_type,
650 			sys_props.kobj_nodes, "%d", id);
651 	if (ret < 0) {
652 		kobject_put(dev->kobj_node);
653 		return ret;
654 	}
655 
656 	dev->kobj_mem = kobject_create_and_add("mem_banks", dev->kobj_node);
657 	if (!dev->kobj_mem)
658 		return -ENOMEM;
659 
660 	dev->kobj_cache = kobject_create_and_add("caches", dev->kobj_node);
661 	if (!dev->kobj_cache)
662 		return -ENOMEM;
663 
664 	dev->kobj_iolink = kobject_create_and_add("io_links", dev->kobj_node);
665 	if (!dev->kobj_iolink)
666 		return -ENOMEM;
667 
668 	dev->kobj_p2plink = kobject_create_and_add("p2p_links", dev->kobj_node);
669 	if (!dev->kobj_p2plink)
670 		return -ENOMEM;
671 
672 	dev->kobj_perf = kobject_create_and_add("perf", dev->kobj_node);
673 	if (!dev->kobj_perf)
674 		return -ENOMEM;
675 
676 	/*
677 	 * Creating sysfs files for node properties
678 	 */
679 	dev->attr_gpuid.name = "gpu_id";
680 	dev->attr_gpuid.mode = KFD_SYSFS_FILE_MODE;
681 	sysfs_attr_init(&dev->attr_gpuid);
682 	dev->attr_name.name = "name";
683 	dev->attr_name.mode = KFD_SYSFS_FILE_MODE;
684 	sysfs_attr_init(&dev->attr_name);
685 	dev->attr_props.name = "properties";
686 	dev->attr_props.mode = KFD_SYSFS_FILE_MODE;
687 	sysfs_attr_init(&dev->attr_props);
688 	ret = sysfs_create_file(dev->kobj_node, &dev->attr_gpuid);
689 	if (ret < 0)
690 		return ret;
691 	ret = sysfs_create_file(dev->kobj_node, &dev->attr_name);
692 	if (ret < 0)
693 		return ret;
694 	ret = sysfs_create_file(dev->kobj_node, &dev->attr_props);
695 	if (ret < 0)
696 		return ret;
697 
698 	i = 0;
699 	list_for_each_entry(mem, &dev->mem_props, list) {
700 		mem->kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL);
701 		if (!mem->kobj)
702 			return -ENOMEM;
703 		ret = kobject_init_and_add(mem->kobj, &mem_type,
704 				dev->kobj_mem, "%d", i);
705 		if (ret < 0) {
706 			kobject_put(mem->kobj);
707 			return ret;
708 		}
709 
710 		mem->attr.name = "properties";
711 		mem->attr.mode = KFD_SYSFS_FILE_MODE;
712 		sysfs_attr_init(&mem->attr);
713 		ret = sysfs_create_file(mem->kobj, &mem->attr);
714 		if (ret < 0)
715 			return ret;
716 		i++;
717 	}
718 
719 	i = 0;
720 	list_for_each_entry(cache, &dev->cache_props, list) {
721 		cache->kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL);
722 		if (!cache->kobj)
723 			return -ENOMEM;
724 		ret = kobject_init_and_add(cache->kobj, &cache_type,
725 				dev->kobj_cache, "%d", i);
726 		if (ret < 0) {
727 			kobject_put(cache->kobj);
728 			return ret;
729 		}
730 
731 		cache->attr.name = "properties";
732 		cache->attr.mode = KFD_SYSFS_FILE_MODE;
733 		sysfs_attr_init(&cache->attr);
734 		ret = sysfs_create_file(cache->kobj, &cache->attr);
735 		if (ret < 0)
736 			return ret;
737 		i++;
738 	}
739 
740 	i = 0;
741 	list_for_each_entry(iolink, &dev->io_link_props, list) {
742 		iolink->kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL);
743 		if (!iolink->kobj)
744 			return -ENOMEM;
745 		ret = kobject_init_and_add(iolink->kobj, &iolink_type,
746 				dev->kobj_iolink, "%d", i);
747 		if (ret < 0) {
748 			kobject_put(iolink->kobj);
749 			return ret;
750 		}
751 
752 		iolink->attr.name = "properties";
753 		iolink->attr.mode = KFD_SYSFS_FILE_MODE;
754 		sysfs_attr_init(&iolink->attr);
755 		ret = sysfs_create_file(iolink->kobj, &iolink->attr);
756 		if (ret < 0)
757 			return ret;
758 		i++;
759 	}
760 
761 	i = 0;
762 	list_for_each_entry(p2plink, &dev->p2p_link_props, list) {
763 		p2plink->kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL);
764 		if (!p2plink->kobj)
765 			return -ENOMEM;
766 		ret = kobject_init_and_add(p2plink->kobj, &iolink_type,
767 				dev->kobj_p2plink, "%d", i);
768 		if (ret < 0) {
769 			kobject_put(p2plink->kobj);
770 			return ret;
771 		}
772 
773 		p2plink->attr.name = "properties";
774 		p2plink->attr.mode = KFD_SYSFS_FILE_MODE;
775 		sysfs_attr_init(&p2plink->attr);
776 		ret = sysfs_create_file(p2plink->kobj, &p2plink->attr);
777 		if (ret < 0)
778 			return ret;
779 		i++;
780 	}
781 
782 	/* All hardware blocks have the same number of attributes. */
783 	num_attrs = ARRAY_SIZE(perf_attr_iommu);
784 	list_for_each_entry(perf, &dev->perf_props, list) {
785 		perf->attr_group = kzalloc(sizeof(struct kfd_perf_attr)
786 			* num_attrs + sizeof(struct attribute_group),
787 			GFP_KERNEL);
788 		if (!perf->attr_group)
789 			return -ENOMEM;
790 
791 		attrs = (struct attribute **)(perf->attr_group + 1);
792 		if (!strcmp(perf->block_name, "iommu")) {
793 		/* Information of IOMMU's num_counters and counter_ids is shown
794 		 * under /sys/bus/event_source/devices/amd_iommu. We don't
795 		 * duplicate here.
796 		 */
797 			perf_attr_iommu[0].data = perf->max_concurrent;
798 			for (i = 0; i < num_attrs; i++)
799 				attrs[i] = &perf_attr_iommu[i].attr.attr;
800 		}
801 		perf->attr_group->name = perf->block_name;
802 		perf->attr_group->attrs = attrs;
803 		ret = sysfs_create_group(dev->kobj_perf, perf->attr_group);
804 		if (ret < 0)
805 			return ret;
806 	}
807 
808 	return 0;
809 }
810 
811 /* Called with write topology lock acquired */
812 static int kfd_build_sysfs_node_tree(void)
813 {
814 	struct kfd_topology_device *dev;
815 	int ret;
816 	uint32_t i = 0;
817 
818 	list_for_each_entry(dev, &topology_device_list, list) {
819 		ret = kfd_build_sysfs_node_entry(dev, i);
820 		if (ret < 0)
821 			return ret;
822 		i++;
823 	}
824 
825 	return 0;
826 }
827 
828 /* Called with write topology lock acquired */
829 static void kfd_remove_sysfs_node_tree(void)
830 {
831 	struct kfd_topology_device *dev;
832 
833 	list_for_each_entry(dev, &topology_device_list, list)
834 		kfd_remove_sysfs_node_entry(dev);
835 }
836 
837 static int kfd_topology_update_sysfs(void)
838 {
839 	int ret;
840 
841 	if (!sys_props.kobj_topology) {
842 		sys_props.kobj_topology =
843 				kfd_alloc_struct(sys_props.kobj_topology);
844 		if (!sys_props.kobj_topology)
845 			return -ENOMEM;
846 
847 		ret = kobject_init_and_add(sys_props.kobj_topology,
848 				&sysprops_type,  &kfd_device->kobj,
849 				"topology");
850 		if (ret < 0) {
851 			kobject_put(sys_props.kobj_topology);
852 			return ret;
853 		}
854 
855 		sys_props.kobj_nodes = kobject_create_and_add("nodes",
856 				sys_props.kobj_topology);
857 		if (!sys_props.kobj_nodes)
858 			return -ENOMEM;
859 
860 		sys_props.attr_genid.name = "generation_id";
861 		sys_props.attr_genid.mode = KFD_SYSFS_FILE_MODE;
862 		sysfs_attr_init(&sys_props.attr_genid);
863 		ret = sysfs_create_file(sys_props.kobj_topology,
864 				&sys_props.attr_genid);
865 		if (ret < 0)
866 			return ret;
867 
868 		sys_props.attr_props.name = "system_properties";
869 		sys_props.attr_props.mode = KFD_SYSFS_FILE_MODE;
870 		sysfs_attr_init(&sys_props.attr_props);
871 		ret = sysfs_create_file(sys_props.kobj_topology,
872 				&sys_props.attr_props);
873 		if (ret < 0)
874 			return ret;
875 	}
876 
877 	kfd_remove_sysfs_node_tree();
878 
879 	return kfd_build_sysfs_node_tree();
880 }
881 
882 static void kfd_topology_release_sysfs(void)
883 {
884 	kfd_remove_sysfs_node_tree();
885 	if (sys_props.kobj_topology) {
886 		sysfs_remove_file(sys_props.kobj_topology,
887 				&sys_props.attr_genid);
888 		sysfs_remove_file(sys_props.kobj_topology,
889 				&sys_props.attr_props);
890 		if (sys_props.kobj_nodes) {
891 			kobject_del(sys_props.kobj_nodes);
892 			kobject_put(sys_props.kobj_nodes);
893 			sys_props.kobj_nodes = NULL;
894 		}
895 		kobject_del(sys_props.kobj_topology);
896 		kobject_put(sys_props.kobj_topology);
897 		sys_props.kobj_topology = NULL;
898 	}
899 }
900 
901 /* Called with write topology_lock acquired */
902 static void kfd_topology_update_device_list(struct list_head *temp_list,
903 					struct list_head *master_list)
904 {
905 	while (!list_empty(temp_list)) {
906 		list_move_tail(temp_list->next, master_list);
907 		sys_props.num_devices++;
908 	}
909 }
910 
911 static void kfd_debug_print_topology(void)
912 {
913 	struct kfd_topology_device *dev;
914 
915 	down_read(&topology_lock);
916 
917 	dev = list_last_entry(&topology_device_list,
918 			struct kfd_topology_device, list);
919 	if (dev) {
920 		if (dev->node_props.cpu_cores_count &&
921 				dev->node_props.simd_count) {
922 			pr_info("Topology: Add APU node [0x%0x:0x%0x]\n",
923 				dev->node_props.device_id,
924 				dev->node_props.vendor_id);
925 		} else if (dev->node_props.cpu_cores_count)
926 			pr_info("Topology: Add CPU node\n");
927 		else if (dev->node_props.simd_count)
928 			pr_info("Topology: Add dGPU node [0x%0x:0x%0x]\n",
929 				dev->node_props.device_id,
930 				dev->node_props.vendor_id);
931 	}
932 	up_read(&topology_lock);
933 }
934 
935 /* Helper function for intializing platform_xx members of
936  * kfd_system_properties. Uses OEM info from the last CPU/APU node.
937  */
938 static void kfd_update_system_properties(void)
939 {
940 	struct kfd_topology_device *dev;
941 
942 	down_read(&topology_lock);
943 	dev = list_last_entry(&topology_device_list,
944 			struct kfd_topology_device, list);
945 	if (dev) {
946 		sys_props.platform_id = dev->oem_id64;
947 		sys_props.platform_oem = *((uint64_t *)dev->oem_table_id);
948 		sys_props.platform_rev = dev->oem_revision;
949 	}
950 	up_read(&topology_lock);
951 }
952 
953 static void find_system_memory(const struct dmi_header *dm,
954 	void *private)
955 {
956 	struct kfd_mem_properties *mem;
957 	u16 mem_width, mem_clock;
958 	struct kfd_topology_device *kdev =
959 		(struct kfd_topology_device *)private;
960 	const u8 *dmi_data = (const u8 *)(dm + 1);
961 
962 	if (dm->type == DMI_ENTRY_MEM_DEVICE && dm->length >= 0x15) {
963 		mem_width = (u16)(*(const u16 *)(dmi_data + 0x6));
964 		mem_clock = (u16)(*(const u16 *)(dmi_data + 0x11));
965 		list_for_each_entry(mem, &kdev->mem_props, list) {
966 			if (mem_width != 0xFFFF && mem_width != 0)
967 				mem->width = mem_width;
968 			if (mem_clock != 0)
969 				mem->mem_clk_max = mem_clock;
970 		}
971 	}
972 }
973 
974 /* kfd_add_non_crat_information - Add information that is not currently
975  *	defined in CRAT but is necessary for KFD topology
976  * @dev - topology device to which addition info is added
977  */
978 static void kfd_add_non_crat_information(struct kfd_topology_device *kdev)
979 {
980 	/* Check if CPU only node. */
981 	if (!kdev->gpu) {
982 		/* Add system memory information */
983 		dmi_walk(find_system_memory, kdev);
984 	}
985 	/* TODO: For GPU node, rearrange code from kfd_topology_add_device */
986 }
987 
988 int kfd_topology_init(void)
989 {
990 	void *crat_image = NULL;
991 	size_t image_size = 0;
992 	int ret;
993 	struct list_head temp_topology_device_list;
994 	int cpu_only_node = 0;
995 	struct kfd_topology_device *kdev;
996 	int proximity_domain;
997 
998 	/* topology_device_list - Master list of all topology devices
999 	 * temp_topology_device_list - temporary list created while parsing CRAT
1000 	 * or VCRAT. Once parsing is complete the contents of list is moved to
1001 	 * topology_device_list
1002 	 */
1003 
1004 	/* Initialize the head for the both the lists */
1005 	INIT_LIST_HEAD(&topology_device_list);
1006 	INIT_LIST_HEAD(&temp_topology_device_list);
1007 	init_rwsem(&topology_lock);
1008 
1009 	memset(&sys_props, 0, sizeof(sys_props));
1010 
1011 	/* Proximity domains in ACPI CRAT tables start counting at
1012 	 * 0. The same should be true for virtual CRAT tables created
1013 	 * at this stage. GPUs added later in kfd_topology_add_device
1014 	 * use a counter.
1015 	 */
1016 	proximity_domain = 0;
1017 
1018 	ret = kfd_create_crat_image_virtual(&crat_image, &image_size,
1019 					    COMPUTE_UNIT_CPU, NULL,
1020 					    proximity_domain);
1021 	cpu_only_node = 1;
1022 	if (ret) {
1023 		pr_err("Error creating VCRAT table for CPU\n");
1024 		return ret;
1025 	}
1026 
1027 	ret = kfd_parse_crat_table(crat_image,
1028 				   &temp_topology_device_list,
1029 				   proximity_domain);
1030 	if (ret) {
1031 		pr_err("Error parsing VCRAT table for CPU\n");
1032 		goto err;
1033 	}
1034 
1035 	kdev = list_first_entry(&temp_topology_device_list,
1036 				struct kfd_topology_device, list);
1037 
1038 	down_write(&topology_lock);
1039 	kfd_topology_update_device_list(&temp_topology_device_list,
1040 					&topology_device_list);
1041 	topology_crat_proximity_domain = sys_props.num_devices-1;
1042 	ret = kfd_topology_update_sysfs();
1043 	up_write(&topology_lock);
1044 
1045 	if (!ret) {
1046 		sys_props.generation_count++;
1047 		kfd_update_system_properties();
1048 		kfd_debug_print_topology();
1049 	} else
1050 		pr_err("Failed to update topology in sysfs ret=%d\n", ret);
1051 
1052 	/* For nodes with GPU, this information gets added
1053 	 * when GPU is detected (kfd_topology_add_device).
1054 	 */
1055 	if (cpu_only_node) {
1056 		/* Add additional information to CPU only node created above */
1057 		down_write(&topology_lock);
1058 		kdev = list_first_entry(&topology_device_list,
1059 				struct kfd_topology_device, list);
1060 		up_write(&topology_lock);
1061 		kfd_add_non_crat_information(kdev);
1062 	}
1063 
1064 err:
1065 	kfd_destroy_crat_image(crat_image);
1066 	return ret;
1067 }
1068 
1069 void kfd_topology_shutdown(void)
1070 {
1071 	down_write(&topology_lock);
1072 	kfd_topology_release_sysfs();
1073 	kfd_release_live_view();
1074 	up_write(&topology_lock);
1075 }
1076 
1077 static uint32_t kfd_generate_gpu_id(struct kfd_node *gpu)
1078 {
1079 	uint32_t gpu_id;
1080 	uint32_t buf[8];
1081 	uint64_t local_mem_size;
1082 	struct kfd_topology_device *dev;
1083 	bool is_unique;
1084 	uint8_t *crc_buf;
1085 
1086 	if (!gpu)
1087 		return 0;
1088 
1089 	crc_buf = (uint8_t *)&buf;
1090 	local_mem_size = gpu->local_mem_info.local_mem_size_private +
1091 			gpu->local_mem_info.local_mem_size_public;
1092 	buf[0] = gpu->adev->pdev->devfn;
1093 	buf[1] = gpu->adev->pdev->subsystem_vendor |
1094 		(gpu->adev->pdev->subsystem_device << 16);
1095 	buf[2] = pci_domain_nr(gpu->adev->pdev->bus);
1096 	buf[3] = gpu->adev->pdev->device;
1097 	buf[4] = gpu->adev->pdev->bus->number;
1098 	buf[5] = lower_32_bits(local_mem_size);
1099 	buf[6] = upper_32_bits(local_mem_size);
1100 	buf[7] = (ffs(gpu->xcc_mask) - 1) | (NUM_XCC(gpu->xcc_mask) << 16);
1101 
1102 	gpu_id = crc16(0, crc_buf, sizeof(buf)) &
1103 		 ((1 << KFD_GPU_ID_HASH_WIDTH) - 1);
1104 
1105 	/* There is a very small possibility when generating a
1106 	 * 16 (KFD_GPU_ID_HASH_WIDTH) bit value from 8 word buffer
1107 	 * that the value could be 0 or non-unique. So, check if
1108 	 * it is unique and non-zero. If not unique increment till
1109 	 * unique one is found. In case of overflow, restart from 1
1110 	 */
1111 
1112 	down_read(&topology_lock);
1113 	do {
1114 		is_unique = true;
1115 		if (!gpu_id)
1116 			gpu_id = 1;
1117 		list_for_each_entry(dev, &topology_device_list, list) {
1118 			if (dev->gpu && dev->gpu_id == gpu_id) {
1119 				is_unique = false;
1120 				break;
1121 			}
1122 		}
1123 		if (unlikely(!is_unique))
1124 			gpu_id = (gpu_id + 1) &
1125 				  ((1 << KFD_GPU_ID_HASH_WIDTH) - 1);
1126 	} while (!is_unique);
1127 	up_read(&topology_lock);
1128 
1129 	return gpu_id;
1130 }
1131 /* kfd_assign_gpu - Attach @gpu to the correct kfd topology device. If
1132  *		the GPU device is not already present in the topology device
1133  *		list then return NULL. This means a new topology device has to
1134  *		be created for this GPU.
1135  */
1136 static struct kfd_topology_device *kfd_assign_gpu(struct kfd_node *gpu)
1137 {
1138 	struct kfd_topology_device *dev;
1139 	struct kfd_topology_device *out_dev = NULL;
1140 	struct kfd_mem_properties *mem;
1141 	struct kfd_cache_properties *cache;
1142 	struct kfd_iolink_properties *iolink;
1143 	struct kfd_iolink_properties *p2plink;
1144 
1145 	list_for_each_entry(dev, &topology_device_list, list) {
1146 		/* Discrete GPUs need their own topology device list
1147 		 * entries. Don't assign them to CPU/APU nodes.
1148 		 */
1149 		if (dev->node_props.cpu_cores_count)
1150 			continue;
1151 
1152 		if (!dev->gpu && (dev->node_props.simd_count > 0)) {
1153 			dev->gpu = gpu;
1154 			out_dev = dev;
1155 
1156 			list_for_each_entry(mem, &dev->mem_props, list)
1157 				mem->gpu = dev->gpu;
1158 			list_for_each_entry(cache, &dev->cache_props, list)
1159 				cache->gpu = dev->gpu;
1160 			list_for_each_entry(iolink, &dev->io_link_props, list)
1161 				iolink->gpu = dev->gpu;
1162 			list_for_each_entry(p2plink, &dev->p2p_link_props, list)
1163 				p2plink->gpu = dev->gpu;
1164 			break;
1165 		}
1166 	}
1167 	return out_dev;
1168 }
1169 
1170 static void kfd_notify_gpu_change(uint32_t gpu_id, int arrival)
1171 {
1172 	/*
1173 	 * TODO: Generate an event for thunk about the arrival/removal
1174 	 * of the GPU
1175 	 */
1176 }
1177 
1178 /* kfd_fill_mem_clk_max_info - Since CRAT doesn't have memory clock info,
1179  *		patch this after CRAT parsing.
1180  */
1181 static void kfd_fill_mem_clk_max_info(struct kfd_topology_device *dev)
1182 {
1183 	struct kfd_mem_properties *mem;
1184 	struct kfd_local_mem_info local_mem_info;
1185 
1186 	if (!dev)
1187 		return;
1188 
1189 	/* Currently, amdgpu driver (amdgpu_mc) deals only with GPUs with
1190 	 * single bank of VRAM local memory.
1191 	 * for dGPUs - VCRAT reports only one bank of Local Memory
1192 	 * for APUs - If CRAT from ACPI reports more than one bank, then
1193 	 *	all the banks will report the same mem_clk_max information
1194 	 */
1195 	amdgpu_amdkfd_get_local_mem_info(dev->gpu->adev, &local_mem_info,
1196 					 dev->gpu->xcp);
1197 
1198 	list_for_each_entry(mem, &dev->mem_props, list)
1199 		mem->mem_clk_max = local_mem_info.mem_clk_max;
1200 }
1201 
1202 static void kfd_set_iolink_no_atomics(struct kfd_topology_device *dev,
1203 					struct kfd_topology_device *target_gpu_dev,
1204 					struct kfd_iolink_properties *link)
1205 {
1206 	/* xgmi always supports atomics between links. */
1207 	if (link->iolink_type == CRAT_IOLINK_TYPE_XGMI)
1208 		return;
1209 
1210 	/* check pcie support to set cpu(dev) flags for target_gpu_dev link. */
1211 	if (target_gpu_dev) {
1212 		uint32_t cap;
1213 
1214 		pcie_capability_read_dword(target_gpu_dev->gpu->adev->pdev,
1215 				PCI_EXP_DEVCAP2, &cap);
1216 
1217 		if (!(cap & (PCI_EXP_DEVCAP2_ATOMIC_COMP32 |
1218 			     PCI_EXP_DEVCAP2_ATOMIC_COMP64)))
1219 			link->flags |= CRAT_IOLINK_FLAGS_NO_ATOMICS_32_BIT |
1220 				CRAT_IOLINK_FLAGS_NO_ATOMICS_64_BIT;
1221 	/* set gpu (dev) flags. */
1222 	} else {
1223 		if (!dev->gpu->kfd->pci_atomic_requested ||
1224 				dev->gpu->adev->asic_type == CHIP_HAWAII)
1225 			link->flags |= CRAT_IOLINK_FLAGS_NO_ATOMICS_32_BIT |
1226 				CRAT_IOLINK_FLAGS_NO_ATOMICS_64_BIT;
1227 	}
1228 }
1229 
1230 static void kfd_set_iolink_non_coherent(struct kfd_topology_device *to_dev,
1231 		struct kfd_iolink_properties *outbound_link,
1232 		struct kfd_iolink_properties *inbound_link)
1233 {
1234 	/* CPU -> GPU with PCIe */
1235 	if (!to_dev->gpu &&
1236 	    inbound_link->iolink_type == CRAT_IOLINK_TYPE_PCIEXPRESS)
1237 		inbound_link->flags |= CRAT_IOLINK_FLAGS_NON_COHERENT;
1238 
1239 	if (to_dev->gpu) {
1240 		/* GPU <-> GPU with PCIe and
1241 		 * Vega20 with XGMI
1242 		 */
1243 		if (inbound_link->iolink_type == CRAT_IOLINK_TYPE_PCIEXPRESS ||
1244 		    (inbound_link->iolink_type == CRAT_IOLINK_TYPE_XGMI &&
1245 		    KFD_GC_VERSION(to_dev->gpu) == IP_VERSION(9, 4, 0))) {
1246 			outbound_link->flags |= CRAT_IOLINK_FLAGS_NON_COHERENT;
1247 			inbound_link->flags |= CRAT_IOLINK_FLAGS_NON_COHERENT;
1248 		}
1249 	}
1250 }
1251 
1252 #define REC_SDMA_NUM_GPU	8
1253 static const int rec_sdma_eng_map[REC_SDMA_NUM_GPU][REC_SDMA_NUM_GPU] = {
1254 							{ -1, 14, 12, 2, 4, 8, 10, 6 },
1255 							{ 14, -1, 2, 10, 8, 4, 6, 12 },
1256 							{ 10, 2, -1, 12, 14, 6, 4, 8 },
1257 							{ 2, 12, 10, -1, 6, 14, 8, 4 },
1258 							{ 4, 8, 14, 6, -1, 10, 12, 2 },
1259 							{ 8, 4, 6, 14, 12, -1, 2, 10 },
1260 							{ 10, 6, 4, 8, 12, 2, -1, 14 },
1261 							{ 6, 12, 8, 4, 2, 10, 14, -1 }};
1262 
1263 static void kfd_set_recommended_sdma_engines(struct kfd_topology_device *to_dev,
1264 					     struct kfd_iolink_properties *outbound_link,
1265 					     struct kfd_iolink_properties *inbound_link)
1266 {
1267 	struct kfd_node *gpu = outbound_link->gpu;
1268 	struct amdgpu_device *adev = gpu->adev;
1269 	int num_xgmi_nodes = adev->gmc.xgmi.num_physical_nodes;
1270 	bool support_rec_eng = !amdgpu_sriov_vf(adev) && to_dev->gpu &&
1271 		adev->aid_mask && num_xgmi_nodes && gpu->kfd->num_nodes == 1 &&
1272 		kfd_get_num_xgmi_sdma_engines(gpu) >= 14 &&
1273 		(!(adev->flags & AMD_IS_APU) && num_xgmi_nodes == 8);
1274 
1275 	if (support_rec_eng) {
1276 		int src_socket_id = adev->gmc.xgmi.physical_node_id;
1277 		int dst_socket_id = to_dev->gpu->adev->gmc.xgmi.physical_node_id;
1278 
1279 		outbound_link->rec_sdma_eng_id_mask =
1280 			1 << rec_sdma_eng_map[src_socket_id][dst_socket_id];
1281 		inbound_link->rec_sdma_eng_id_mask =
1282 			1 << rec_sdma_eng_map[dst_socket_id][src_socket_id];
1283 	} else {
1284 		int num_sdma_eng = kfd_get_num_sdma_engines(gpu);
1285 		int i, eng_offset = 0;
1286 
1287 		if (outbound_link->iolink_type == CRAT_IOLINK_TYPE_XGMI &&
1288 		    kfd_get_num_xgmi_sdma_engines(gpu) && to_dev->gpu) {
1289 			eng_offset = num_sdma_eng;
1290 			num_sdma_eng = kfd_get_num_xgmi_sdma_engines(gpu);
1291 		}
1292 
1293 		for (i = 0; i < num_sdma_eng; i++) {
1294 			outbound_link->rec_sdma_eng_id_mask |= (1 << (i + eng_offset));
1295 			inbound_link->rec_sdma_eng_id_mask |= (1 << (i + eng_offset));
1296 		}
1297 	}
1298 }
1299 
1300 static void kfd_fill_iolink_non_crat_info(struct kfd_topology_device *dev)
1301 {
1302 	struct kfd_iolink_properties *link, *inbound_link;
1303 	struct kfd_topology_device *peer_dev;
1304 
1305 	if (!dev || !dev->gpu)
1306 		return;
1307 
1308 	/* GPU only creates direct links so apply flags setting to all */
1309 	list_for_each_entry(link, &dev->io_link_props, list) {
1310 		link->flags = CRAT_IOLINK_FLAGS_ENABLED;
1311 		kfd_set_iolink_no_atomics(dev, NULL, link);
1312 		peer_dev = kfd_topology_device_by_proximity_domain(
1313 				link->node_to);
1314 
1315 		if (!peer_dev)
1316 			continue;
1317 
1318 		/* Include the CPU peer in GPU hive if connected over xGMI. */
1319 		if (!peer_dev->gpu &&
1320 		    link->iolink_type == CRAT_IOLINK_TYPE_XGMI) {
1321 			/*
1322 			 * If the GPU is not part of a GPU hive, use its pci
1323 			 * device location as the hive ID to bind with the CPU.
1324 			 */
1325 			if (!dev->node_props.hive_id)
1326 				dev->node_props.hive_id = pci_dev_id(dev->gpu->adev->pdev);
1327 			peer_dev->node_props.hive_id = dev->node_props.hive_id;
1328 		}
1329 
1330 		list_for_each_entry(inbound_link, &peer_dev->io_link_props,
1331 									list) {
1332 			if (inbound_link->node_to != link->node_from)
1333 				continue;
1334 
1335 			inbound_link->flags = CRAT_IOLINK_FLAGS_ENABLED;
1336 			kfd_set_iolink_no_atomics(peer_dev, dev, inbound_link);
1337 			kfd_set_iolink_non_coherent(peer_dev, link, inbound_link);
1338 			kfd_set_recommended_sdma_engines(peer_dev, link, inbound_link);
1339 		}
1340 	}
1341 
1342 	/* Create indirect links so apply flags setting to all */
1343 	list_for_each_entry(link, &dev->p2p_link_props, list) {
1344 		link->flags = CRAT_IOLINK_FLAGS_ENABLED;
1345 		kfd_set_iolink_no_atomics(dev, NULL, link);
1346 		peer_dev = kfd_topology_device_by_proximity_domain(
1347 				link->node_to);
1348 
1349 		if (!peer_dev)
1350 			continue;
1351 
1352 		list_for_each_entry(inbound_link, &peer_dev->p2p_link_props,
1353 									list) {
1354 			if (inbound_link->node_to != link->node_from)
1355 				continue;
1356 
1357 			inbound_link->flags = CRAT_IOLINK_FLAGS_ENABLED;
1358 			kfd_set_iolink_no_atomics(peer_dev, dev, inbound_link);
1359 			kfd_set_iolink_non_coherent(peer_dev, link, inbound_link);
1360 		}
1361 	}
1362 }
1363 
1364 static int kfd_build_p2p_node_entry(struct kfd_topology_device *dev,
1365 				struct kfd_iolink_properties *p2plink)
1366 {
1367 	int ret;
1368 
1369 	p2plink->kobj = kzalloc(sizeof(struct kobject), GFP_KERNEL);
1370 	if (!p2plink->kobj)
1371 		return -ENOMEM;
1372 
1373 	ret = kobject_init_and_add(p2plink->kobj, &iolink_type,
1374 			dev->kobj_p2plink, "%d", dev->node_props.p2p_links_count - 1);
1375 	if (ret < 0) {
1376 		kobject_put(p2plink->kobj);
1377 		return ret;
1378 	}
1379 
1380 	p2plink->attr.name = "properties";
1381 	p2plink->attr.mode = KFD_SYSFS_FILE_MODE;
1382 	sysfs_attr_init(&p2plink->attr);
1383 	ret = sysfs_create_file(p2plink->kobj, &p2plink->attr);
1384 	if (ret < 0)
1385 		return ret;
1386 
1387 	return 0;
1388 }
1389 
1390 static int kfd_create_indirect_link_prop(struct kfd_topology_device *kdev, int gpu_node)
1391 {
1392 	struct kfd_iolink_properties *gpu_link, *tmp_link, *cpu_link;
1393 	struct kfd_iolink_properties *props = NULL, *props2 = NULL;
1394 	struct kfd_topology_device *cpu_dev;
1395 	int ret = 0;
1396 	int i, num_cpu;
1397 
1398 	num_cpu = 0;
1399 	list_for_each_entry(cpu_dev, &topology_device_list, list) {
1400 		if (cpu_dev->gpu)
1401 			break;
1402 		num_cpu++;
1403 	}
1404 
1405 	if (list_empty(&kdev->io_link_props))
1406 		return -ENODATA;
1407 
1408 	gpu_link = list_first_entry(&kdev->io_link_props,
1409 				    struct kfd_iolink_properties, list);
1410 
1411 	for (i = 0; i < num_cpu; i++) {
1412 		/* CPU <--> GPU */
1413 		if (gpu_link->node_to == i)
1414 			continue;
1415 
1416 		/* find CPU <-->  CPU links */
1417 		cpu_link = NULL;
1418 		cpu_dev = kfd_topology_device_by_proximity_domain(i);
1419 		if (cpu_dev) {
1420 			list_for_each_entry(tmp_link,
1421 					&cpu_dev->io_link_props, list) {
1422 				if (tmp_link->node_to == gpu_link->node_to) {
1423 					cpu_link = tmp_link;
1424 					break;
1425 				}
1426 			}
1427 		}
1428 
1429 		if (!cpu_link)
1430 			return -ENOMEM;
1431 
1432 		/* CPU <--> CPU <--> GPU, GPU node*/
1433 		props = kfd_alloc_struct(props);
1434 		if (!props)
1435 			return -ENOMEM;
1436 
1437 		memcpy(props, gpu_link, sizeof(struct kfd_iolink_properties));
1438 		props->weight = gpu_link->weight + cpu_link->weight;
1439 		props->min_latency = gpu_link->min_latency + cpu_link->min_latency;
1440 		props->max_latency = gpu_link->max_latency + cpu_link->max_latency;
1441 		props->min_bandwidth = min(gpu_link->min_bandwidth, cpu_link->min_bandwidth);
1442 		props->max_bandwidth = min(gpu_link->max_bandwidth, cpu_link->max_bandwidth);
1443 
1444 		props->node_from = gpu_node;
1445 		props->node_to = i;
1446 		kdev->node_props.p2p_links_count++;
1447 		list_add_tail(&props->list, &kdev->p2p_link_props);
1448 		ret = kfd_build_p2p_node_entry(kdev, props);
1449 		if (ret < 0)
1450 			return ret;
1451 
1452 		/* for small Bar, no CPU --> GPU in-direct links */
1453 		if (kfd_dev_is_large_bar(kdev->gpu)) {
1454 			/* CPU <--> CPU <--> GPU, CPU node*/
1455 			props2 = kfd_alloc_struct(props2);
1456 			if (!props2)
1457 				return -ENOMEM;
1458 
1459 			memcpy(props2, props, sizeof(struct kfd_iolink_properties));
1460 			props2->node_from = i;
1461 			props2->node_to = gpu_node;
1462 			props2->kobj = NULL;
1463 			cpu_dev->node_props.p2p_links_count++;
1464 			list_add_tail(&props2->list, &cpu_dev->p2p_link_props);
1465 			ret = kfd_build_p2p_node_entry(cpu_dev, props2);
1466 			if (ret < 0)
1467 				return ret;
1468 		}
1469 	}
1470 	return ret;
1471 }
1472 
1473 #if defined(CONFIG_HSA_AMD_P2P)
1474 static int kfd_add_peer_prop(struct kfd_topology_device *kdev,
1475 		struct kfd_topology_device *peer, int from, int to)
1476 {
1477 	struct kfd_iolink_properties *props = NULL;
1478 	struct kfd_iolink_properties *iolink1, *iolink2, *iolink3;
1479 	struct kfd_topology_device *cpu_dev;
1480 	int ret = 0;
1481 
1482 	if (!amdgpu_device_is_peer_accessible(
1483 				kdev->gpu->adev,
1484 				peer->gpu->adev))
1485 		return ret;
1486 
1487 	if (list_empty(&kdev->io_link_props))
1488 		return -ENODATA;
1489 
1490 	iolink1 = list_first_entry(&kdev->io_link_props,
1491 				   struct kfd_iolink_properties, list);
1492 
1493 	if (list_empty(&peer->io_link_props))
1494 		return -ENODATA;
1495 
1496 	iolink2 = list_first_entry(&peer->io_link_props,
1497 				   struct kfd_iolink_properties, list);
1498 
1499 	props = kfd_alloc_struct(props);
1500 	if (!props)
1501 		return -ENOMEM;
1502 
1503 	memcpy(props, iolink1, sizeof(struct kfd_iolink_properties));
1504 
1505 	props->weight = iolink1->weight + iolink2->weight;
1506 	props->min_latency = iolink1->min_latency + iolink2->min_latency;
1507 	props->max_latency = iolink1->max_latency + iolink2->max_latency;
1508 	props->min_bandwidth = min(iolink1->min_bandwidth, iolink2->min_bandwidth);
1509 	props->max_bandwidth = min(iolink2->max_bandwidth, iolink2->max_bandwidth);
1510 
1511 	if (iolink1->node_to != iolink2->node_to) {
1512 		/* CPU->CPU  link*/
1513 		cpu_dev = kfd_topology_device_by_proximity_domain(iolink1->node_to);
1514 		if (cpu_dev) {
1515 			list_for_each_entry(iolink3, &cpu_dev->io_link_props, list) {
1516 				if (iolink3->node_to != iolink2->node_to)
1517 					continue;
1518 
1519 				props->weight += iolink3->weight;
1520 				props->min_latency += iolink3->min_latency;
1521 				props->max_latency += iolink3->max_latency;
1522 				props->min_bandwidth = min(props->min_bandwidth,
1523 							   iolink3->min_bandwidth);
1524 				props->max_bandwidth = min(props->max_bandwidth,
1525 							   iolink3->max_bandwidth);
1526 				break;
1527 			}
1528 		} else {
1529 			WARN(1, "CPU node not found");
1530 		}
1531 	}
1532 
1533 	props->node_from = from;
1534 	props->node_to = to;
1535 	peer->node_props.p2p_links_count++;
1536 	list_add_tail(&props->list, &peer->p2p_link_props);
1537 	ret = kfd_build_p2p_node_entry(peer, props);
1538 
1539 	return ret;
1540 }
1541 #endif
1542 
1543 static int kfd_dev_create_p2p_links(void)
1544 {
1545 	struct kfd_topology_device *dev;
1546 	struct kfd_topology_device *new_dev;
1547 #if defined(CONFIG_HSA_AMD_P2P)
1548 	uint32_t i;
1549 #endif
1550 	uint32_t k;
1551 	int ret = 0;
1552 
1553 	k = 0;
1554 	list_for_each_entry(dev, &topology_device_list, list)
1555 		k++;
1556 	if (k < 2)
1557 		return 0;
1558 
1559 	new_dev = list_last_entry(&topology_device_list, struct kfd_topology_device, list);
1560 	if (WARN_ON(!new_dev->gpu))
1561 		return 0;
1562 
1563 	k--;
1564 
1565 	/* create in-direct links */
1566 	ret = kfd_create_indirect_link_prop(new_dev, k);
1567 	if (ret < 0)
1568 		goto out;
1569 
1570 	/* create p2p links */
1571 #if defined(CONFIG_HSA_AMD_P2P)
1572 	i = 0;
1573 	list_for_each_entry(dev, &topology_device_list, list) {
1574 		if (dev == new_dev)
1575 			break;
1576 		if (!dev->gpu || !dev->gpu->adev ||
1577 		    (dev->gpu->kfd->hive_id &&
1578 		     dev->gpu->kfd->hive_id == new_dev->gpu->kfd->hive_id))
1579 			goto next;
1580 
1581 		/* check if node(s) is/are peer accessible in one direction or bi-direction */
1582 		ret = kfd_add_peer_prop(new_dev, dev, i, k);
1583 		if (ret < 0)
1584 			goto out;
1585 
1586 		ret = kfd_add_peer_prop(dev, new_dev, k, i);
1587 		if (ret < 0)
1588 			goto out;
1589 next:
1590 		i++;
1591 	}
1592 #endif
1593 
1594 out:
1595 	return ret;
1596 }
1597 
1598 /* Helper function. See kfd_fill_gpu_cache_info for parameter description */
1599 static int fill_in_l1_pcache(struct kfd_cache_properties **props_ext,
1600 				struct kfd_gpu_cache_info *pcache_info,
1601 				int cu_bitmask,
1602 				int cache_type, unsigned int cu_processor_id,
1603 				int cu_block)
1604 {
1605 	unsigned int cu_sibling_map_mask;
1606 	int first_active_cu;
1607 	struct kfd_cache_properties *pcache = NULL;
1608 
1609 	cu_sibling_map_mask = cu_bitmask;
1610 	cu_sibling_map_mask >>= cu_block;
1611 	cu_sibling_map_mask &= ((1 << pcache_info[cache_type].num_cu_shared) - 1);
1612 	first_active_cu = ffs(cu_sibling_map_mask);
1613 
1614 	/* CU could be inactive. In case of shared cache find the first active
1615 	 * CU. and incase of non-shared cache check if the CU is inactive. If
1616 	 * inactive active skip it
1617 	 */
1618 	if (first_active_cu) {
1619 		pcache = kfd_alloc_struct(pcache);
1620 		if (!pcache)
1621 			return -ENOMEM;
1622 
1623 		memset(pcache, 0, sizeof(struct kfd_cache_properties));
1624 		pcache->processor_id_low = cu_processor_id + (first_active_cu - 1);
1625 		pcache->cache_level = pcache_info[cache_type].cache_level;
1626 		pcache->cache_size = pcache_info[cache_type].cache_size;
1627 		pcache->cacheline_size = pcache_info[cache_type].cache_line_size;
1628 
1629 		if (pcache_info[cache_type].flags & CRAT_CACHE_FLAGS_DATA_CACHE)
1630 			pcache->cache_type |= HSA_CACHE_TYPE_DATA;
1631 		if (pcache_info[cache_type].flags & CRAT_CACHE_FLAGS_INST_CACHE)
1632 			pcache->cache_type |= HSA_CACHE_TYPE_INSTRUCTION;
1633 		if (pcache_info[cache_type].flags & CRAT_CACHE_FLAGS_CPU_CACHE)
1634 			pcache->cache_type |= HSA_CACHE_TYPE_CPU;
1635 		if (pcache_info[cache_type].flags & CRAT_CACHE_FLAGS_SIMD_CACHE)
1636 			pcache->cache_type |= HSA_CACHE_TYPE_HSACU;
1637 
1638 		/* Sibling map is w.r.t processor_id_low, so shift out
1639 		 * inactive CU
1640 		 */
1641 		cu_sibling_map_mask =
1642 			cu_sibling_map_mask >> (first_active_cu - 1);
1643 
1644 		pcache->sibling_map[0] = (uint8_t)(cu_sibling_map_mask & 0xFF);
1645 		pcache->sibling_map[1] =
1646 				(uint8_t)((cu_sibling_map_mask >> 8) & 0xFF);
1647 		pcache->sibling_map[2] =
1648 				(uint8_t)((cu_sibling_map_mask >> 16) & 0xFF);
1649 		pcache->sibling_map[3] =
1650 				(uint8_t)((cu_sibling_map_mask >> 24) & 0xFF);
1651 
1652 		pcache->sibling_map_size = 4;
1653 		*props_ext = pcache;
1654 
1655 		return 0;
1656 	}
1657 	return 1;
1658 }
1659 
1660 /* Helper function. See kfd_fill_gpu_cache_info for parameter description */
1661 static int fill_in_l2_l3_pcache(struct kfd_cache_properties **props_ext,
1662 				struct kfd_gpu_cache_info *pcache_info,
1663 				struct amdgpu_cu_info *cu_info,
1664 				struct amdgpu_gfx_config *gfx_info,
1665 				int cache_type, unsigned int cu_processor_id,
1666 				struct kfd_node *knode)
1667 {
1668 	unsigned int cu_sibling_map_mask;
1669 	int first_active_cu;
1670 	int i, j, k, xcc, start, end;
1671 	int num_xcc = NUM_XCC(knode->xcc_mask);
1672 	struct kfd_cache_properties *pcache = NULL;
1673 	enum amdgpu_memory_partition mode;
1674 	struct amdgpu_device *adev = knode->adev;
1675 
1676 	start = ffs(knode->xcc_mask) - 1;
1677 	end = start + num_xcc;
1678 	cu_sibling_map_mask = cu_info->bitmap[start][0][0];
1679 	cu_sibling_map_mask &=
1680 		((1 << pcache_info[cache_type].num_cu_shared) - 1);
1681 	first_active_cu = ffs(cu_sibling_map_mask);
1682 
1683 	/* CU could be inactive. In case of shared cache find the first active
1684 	 * CU. and incase of non-shared cache check if the CU is inactive. If
1685 	 * inactive active skip it
1686 	 */
1687 	if (first_active_cu) {
1688 		pcache = kfd_alloc_struct(pcache);
1689 		if (!pcache)
1690 			return -ENOMEM;
1691 
1692 		memset(pcache, 0, sizeof(struct kfd_cache_properties));
1693 		pcache->processor_id_low = cu_processor_id
1694 					+ (first_active_cu - 1);
1695 		pcache->cache_level = pcache_info[cache_type].cache_level;
1696 		pcache->cacheline_size = pcache_info[cache_type].cache_line_size;
1697 
1698 		if (KFD_GC_VERSION(knode) == IP_VERSION(9, 4, 3) ||
1699 		    KFD_GC_VERSION(knode) == IP_VERSION(9, 4, 4) ||
1700 		    KFD_GC_VERSION(knode) == IP_VERSION(9, 5, 0))
1701 			mode = adev->gmc.gmc_funcs->query_mem_partition_mode(adev);
1702 		else
1703 			mode = UNKNOWN_MEMORY_PARTITION_MODE;
1704 
1705 		pcache->cache_size = pcache_info[cache_type].cache_size;
1706 		/* Partition mode only affects L3 cache size */
1707 		if (mode && pcache->cache_level == 3)
1708 			pcache->cache_size /= mode;
1709 
1710 		if (pcache_info[cache_type].flags & CRAT_CACHE_FLAGS_DATA_CACHE)
1711 			pcache->cache_type |= HSA_CACHE_TYPE_DATA;
1712 		if (pcache_info[cache_type].flags & CRAT_CACHE_FLAGS_INST_CACHE)
1713 			pcache->cache_type |= HSA_CACHE_TYPE_INSTRUCTION;
1714 		if (pcache_info[cache_type].flags & CRAT_CACHE_FLAGS_CPU_CACHE)
1715 			pcache->cache_type |= HSA_CACHE_TYPE_CPU;
1716 		if (pcache_info[cache_type].flags & CRAT_CACHE_FLAGS_SIMD_CACHE)
1717 			pcache->cache_type |= HSA_CACHE_TYPE_HSACU;
1718 
1719 		/* Sibling map is w.r.t processor_id_low, so shift out
1720 		 * inactive CU
1721 		 */
1722 		cu_sibling_map_mask = cu_sibling_map_mask >> (first_active_cu - 1);
1723 		k = 0;
1724 
1725 		for (xcc = start; xcc < end; xcc++) {
1726 			for (i = 0; i < gfx_info->max_shader_engines; i++) {
1727 				for (j = 0; j < gfx_info->max_sh_per_se; j++) {
1728 					pcache->sibling_map[k] = (uint8_t)(cu_sibling_map_mask & 0xFF);
1729 					pcache->sibling_map[k+1] = (uint8_t)((cu_sibling_map_mask >> 8) & 0xFF);
1730 					pcache->sibling_map[k+2] = (uint8_t)((cu_sibling_map_mask >> 16) & 0xFF);
1731 					pcache->sibling_map[k+3] = (uint8_t)((cu_sibling_map_mask >> 24) & 0xFF);
1732 					k += 4;
1733 
1734 					cu_sibling_map_mask = cu_info->bitmap[xcc][i % 4][j + i / 4];
1735 					cu_sibling_map_mask &= ((1 << pcache_info[cache_type].num_cu_shared) - 1);
1736 				}
1737 			}
1738 		}
1739 		pcache->sibling_map_size = k;
1740 		*props_ext = pcache;
1741 		return 0;
1742 	}
1743 	return 1;
1744 }
1745 
1746 #define KFD_MAX_CACHE_TYPES 6
1747 
1748 /* kfd_fill_cache_non_crat_info - Fill GPU cache info using kfd_gpu_cache_info
1749  * tables
1750  */
1751 static void kfd_fill_cache_non_crat_info(struct kfd_topology_device *dev, struct kfd_node *kdev)
1752 {
1753 	struct kfd_gpu_cache_info *pcache_info = NULL;
1754 	int i, j, k, xcc, start, end;
1755 	int ct = 0;
1756 	unsigned int cu_processor_id;
1757 	int ret;
1758 	unsigned int num_cu_shared;
1759 	struct amdgpu_cu_info *cu_info = &kdev->adev->gfx.cu_info;
1760 	struct amdgpu_gfx_config *gfx_info = &kdev->adev->gfx.config;
1761 	int gpu_processor_id;
1762 	struct kfd_cache_properties *props_ext = NULL;
1763 	int num_of_entries = 0;
1764 	int num_of_cache_types = 0;
1765 	struct kfd_gpu_cache_info cache_info[KFD_MAX_CACHE_TYPES];
1766 
1767 
1768 	gpu_processor_id = dev->node_props.simd_id_base;
1769 
1770 	memset(cache_info, 0, sizeof(cache_info));
1771 	pcache_info = cache_info;
1772 	num_of_cache_types = kfd_get_gpu_cache_info(kdev, &pcache_info);
1773 	if (!num_of_cache_types) {
1774 		pr_warn("no cache info found\n");
1775 		return;
1776 	}
1777 
1778 	/* For each type of cache listed in the kfd_gpu_cache_info table,
1779 	 * go through all available Compute Units.
1780 	 * The [i,j,k] loop will
1781 	 *		if kfd_gpu_cache_info.num_cu_shared = 1
1782 	 *			will parse through all available CU
1783 	 *		If (kfd_gpu_cache_info.num_cu_shared != 1)
1784 	 *			then it will consider only one CU from
1785 	 *			the shared unit
1786 	 */
1787 	start = ffs(kdev->xcc_mask) - 1;
1788 	end = start + NUM_XCC(kdev->xcc_mask);
1789 
1790 	for (ct = 0; ct < num_of_cache_types; ct++) {
1791 		cu_processor_id = gpu_processor_id;
1792 		if (pcache_info[ct].cache_level == 1) {
1793 			for (xcc = start; xcc < end; xcc++) {
1794 				for (i = 0; i < gfx_info->max_shader_engines; i++) {
1795 					for (j = 0; j < gfx_info->max_sh_per_se; j++) {
1796 						for (k = 0; k < gfx_info->max_cu_per_sh; k += pcache_info[ct].num_cu_shared) {
1797 
1798 							ret = fill_in_l1_pcache(&props_ext, pcache_info,
1799 										cu_info->bitmap[xcc][i % 4][j + i / 4], ct,
1800 										cu_processor_id, k);
1801 
1802 							if (ret < 0)
1803 								break;
1804 
1805 							if (!ret) {
1806 								num_of_entries++;
1807 								list_add_tail(&props_ext->list, &dev->cache_props);
1808 							}
1809 
1810 							/* Move to next CU block */
1811 							num_cu_shared = ((k + pcache_info[ct].num_cu_shared) <=
1812 								gfx_info->max_cu_per_sh) ?
1813 								pcache_info[ct].num_cu_shared :
1814 								(gfx_info->max_cu_per_sh - k);
1815 							cu_processor_id += num_cu_shared;
1816 						}
1817 					}
1818 				}
1819 			}
1820 		} else {
1821 			ret = fill_in_l2_l3_pcache(&props_ext, pcache_info,
1822 						   cu_info, gfx_info, ct, cu_processor_id, kdev);
1823 
1824 			if (ret < 0)
1825 				break;
1826 
1827 			if (!ret) {
1828 				num_of_entries++;
1829 				list_add_tail(&props_ext->list, &dev->cache_props);
1830 			}
1831 		}
1832 	}
1833 	dev->node_props.caches_count += num_of_entries;
1834 	pr_debug("Added [%d] GPU cache entries\n", num_of_entries);
1835 }
1836 
1837 static int kfd_topology_add_device_locked(struct kfd_node *gpu,
1838 					  struct kfd_topology_device **dev)
1839 {
1840 	int proximity_domain = ++topology_crat_proximity_domain;
1841 	struct list_head temp_topology_device_list;
1842 	void *crat_image = NULL;
1843 	size_t image_size = 0;
1844 	int res;
1845 
1846 	res = kfd_create_crat_image_virtual(&crat_image, &image_size,
1847 					    COMPUTE_UNIT_GPU, gpu,
1848 					    proximity_domain);
1849 	if (res) {
1850 		dev_err(gpu->adev->dev, "Error creating VCRAT\n");
1851 		topology_crat_proximity_domain--;
1852 		goto err;
1853 	}
1854 
1855 	INIT_LIST_HEAD(&temp_topology_device_list);
1856 
1857 	res = kfd_parse_crat_table(crat_image,
1858 				   &temp_topology_device_list,
1859 				   proximity_domain);
1860 	if (res) {
1861 		dev_err(gpu->adev->dev, "Error parsing VCRAT\n");
1862 		topology_crat_proximity_domain--;
1863 		goto err;
1864 	}
1865 
1866 	kfd_topology_update_device_list(&temp_topology_device_list,
1867 					&topology_device_list);
1868 
1869 	*dev = kfd_assign_gpu(gpu);
1870 	if (WARN_ON(!*dev)) {
1871 		res = -ENODEV;
1872 		goto err;
1873 	}
1874 
1875 	/* Fill the cache affinity information here for the GPUs
1876 	 * using VCRAT
1877 	 */
1878 	kfd_fill_cache_non_crat_info(*dev, gpu);
1879 
1880 	/* Update the SYSFS tree, since we added another topology
1881 	 * device
1882 	 */
1883 	res = kfd_topology_update_sysfs();
1884 	if (!res)
1885 		sys_props.generation_count++;
1886 	else
1887 		dev_err(gpu->adev->dev, "Failed to update GPU to sysfs topology. res=%d\n",
1888 			res);
1889 
1890 err:
1891 	kfd_destroy_crat_image(crat_image);
1892 	return res;
1893 }
1894 
1895 static void kfd_topology_set_dbg_firmware_support(struct kfd_topology_device *dev)
1896 {
1897 	bool firmware_supported = true;
1898 
1899 	if (KFD_GC_VERSION(dev->gpu) >= IP_VERSION(11, 0, 0) &&
1900 			KFD_GC_VERSION(dev->gpu) < IP_VERSION(12, 0, 0)) {
1901 		uint32_t mes_api_rev = (dev->gpu->adev->mes.sched_version &
1902 						AMDGPU_MES_API_VERSION_MASK) >>
1903 						AMDGPU_MES_API_VERSION_SHIFT;
1904 		uint32_t mes_rev = dev->gpu->adev->mes.sched_version &
1905 						AMDGPU_MES_VERSION_MASK;
1906 
1907 		firmware_supported = (mes_api_rev >= 14) && (mes_rev >= 64);
1908 		goto out;
1909 	}
1910 
1911 	/*
1912 	 * Note: Any unlisted devices here are assumed to support exception handling.
1913 	 * Add additional checks here as needed.
1914 	 */
1915 	switch (KFD_GC_VERSION(dev->gpu)) {
1916 	case IP_VERSION(9, 0, 1):
1917 		firmware_supported = dev->gpu->kfd->mec_fw_version >= 459 + 32768;
1918 		break;
1919 	case IP_VERSION(9, 1, 0):
1920 	case IP_VERSION(9, 2, 1):
1921 	case IP_VERSION(9, 2, 2):
1922 	case IP_VERSION(9, 3, 0):
1923 	case IP_VERSION(9, 4, 0):
1924 		firmware_supported = dev->gpu->kfd->mec_fw_version >= 459;
1925 		break;
1926 	case IP_VERSION(9, 4, 1):
1927 		firmware_supported = dev->gpu->kfd->mec_fw_version >= 60;
1928 		break;
1929 	case IP_VERSION(9, 4, 2):
1930 		firmware_supported = dev->gpu->kfd->mec_fw_version >= 51;
1931 		break;
1932 	case IP_VERSION(10, 1, 10):
1933 	case IP_VERSION(10, 1, 2):
1934 	case IP_VERSION(10, 1, 1):
1935 		firmware_supported = dev->gpu->kfd->mec_fw_version >= 144;
1936 		break;
1937 	case IP_VERSION(10, 3, 0):
1938 	case IP_VERSION(10, 3, 2):
1939 	case IP_VERSION(10, 3, 1):
1940 	case IP_VERSION(10, 3, 4):
1941 	case IP_VERSION(10, 3, 5):
1942 		firmware_supported = dev->gpu->kfd->mec_fw_version >= 89;
1943 		break;
1944 	case IP_VERSION(10, 1, 3):
1945 	case IP_VERSION(10, 3, 3):
1946 		firmware_supported = false;
1947 		break;
1948 	default:
1949 		break;
1950 	}
1951 
1952 out:
1953 	if (firmware_supported)
1954 		dev->node_props.capability |= HSA_CAP_TRAP_DEBUG_FIRMWARE_SUPPORTED;
1955 }
1956 
1957 static void kfd_topology_set_capabilities(struct kfd_topology_device *dev)
1958 {
1959 	dev->node_props.capability |= ((HSA_CAP_DOORBELL_TYPE_2_0 <<
1960 				HSA_CAP_DOORBELL_TYPE_TOTALBITS_SHIFT) &
1961 				HSA_CAP_DOORBELL_TYPE_TOTALBITS_MASK);
1962 
1963 	dev->node_props.capability |= HSA_CAP_TRAP_DEBUG_SUPPORT |
1964 			HSA_CAP_TRAP_DEBUG_WAVE_LAUNCH_TRAP_OVERRIDE_SUPPORTED |
1965 			HSA_CAP_TRAP_DEBUG_WAVE_LAUNCH_MODE_SUPPORTED;
1966 
1967 	if (kfd_dbg_has_ttmps_always_setup(dev->gpu))
1968 		dev->node_props.debug_prop |= HSA_DBG_DISPATCH_INFO_ALWAYS_VALID;
1969 
1970 	if (KFD_GC_VERSION(dev->gpu) < IP_VERSION(10, 0, 0)) {
1971 		if (KFD_GC_VERSION(dev->gpu) == IP_VERSION(9, 4, 3) ||
1972 		    KFD_GC_VERSION(dev->gpu) == IP_VERSION(9, 4, 4))
1973 			dev->node_props.debug_prop |=
1974 				HSA_DBG_WATCH_ADDR_MASK_LO_BIT_GFX9_4_3 |
1975 				HSA_DBG_WATCH_ADDR_MASK_HI_BIT_GFX9_4_3;
1976 		else
1977 			dev->node_props.debug_prop |=
1978 				HSA_DBG_WATCH_ADDR_MASK_LO_BIT_GFX9 |
1979 				HSA_DBG_WATCH_ADDR_MASK_HI_BIT;
1980 
1981 		if (KFD_GC_VERSION(dev->gpu) >= IP_VERSION(9, 4, 2))
1982 			dev->node_props.capability |=
1983 				HSA_CAP_TRAP_DEBUG_PRECISE_MEMORY_OPERATIONS_SUPPORTED;
1984 
1985 		dev->node_props.capability |= HSA_CAP_PER_QUEUE_RESET_SUPPORTED;
1986 	} else {
1987 		dev->node_props.debug_prop |= HSA_DBG_WATCH_ADDR_MASK_LO_BIT_GFX10 |
1988 					HSA_DBG_WATCH_ADDR_MASK_HI_BIT;
1989 
1990 		if (KFD_GC_VERSION(dev->gpu) >= IP_VERSION(11, 0, 0))
1991 			dev->node_props.capability |=
1992 				HSA_CAP_TRAP_DEBUG_PRECISE_MEMORY_OPERATIONS_SUPPORTED;
1993 
1994 		if (KFD_GC_VERSION(dev->gpu) >= IP_VERSION(12, 0, 0))
1995 			dev->node_props.capability |=
1996 				HSA_CAP_TRAP_DEBUG_PRECISE_ALU_OPERATIONS_SUPPORTED;
1997 	}
1998 
1999 	kfd_topology_set_dbg_firmware_support(dev);
2000 }
2001 
2002 int kfd_topology_add_device(struct kfd_node *gpu)
2003 {
2004 	uint32_t gpu_id;
2005 	struct kfd_topology_device *dev;
2006 	int res = 0;
2007 	int i;
2008 	const char *asic_name = amdgpu_asic_name[gpu->adev->asic_type];
2009 	struct amdgpu_gfx_config *gfx_info = &gpu->adev->gfx.config;
2010 	struct amdgpu_cu_info *cu_info = &gpu->adev->gfx.cu_info;
2011 
2012 	if (gpu->xcp && !gpu->xcp->ddev) {
2013 		dev_warn(gpu->adev->dev,
2014 			 "Won't add GPU to topology since it has no drm node assigned.");
2015 		return 0;
2016 	} else {
2017 		dev_dbg(gpu->adev->dev, "Adding new GPU to topology\n");
2018 	}
2019 
2020 	/* Check to see if this gpu device exists in the topology_device_list.
2021 	 * If so, assign the gpu to that device,
2022 	 * else create a Virtual CRAT for this gpu device and then parse that
2023 	 * CRAT to create a new topology device. Once created assign the gpu to
2024 	 * that topology device
2025 	 */
2026 	down_write(&topology_lock);
2027 	dev = kfd_assign_gpu(gpu);
2028 	if (!dev)
2029 		res = kfd_topology_add_device_locked(gpu, &dev);
2030 	up_write(&topology_lock);
2031 	if (res)
2032 		return res;
2033 
2034 	gpu_id = kfd_generate_gpu_id(gpu);
2035 	dev->gpu_id = gpu_id;
2036 	gpu->id = gpu_id;
2037 
2038 	kfd_dev_create_p2p_links();
2039 
2040 	/* TODO: Move the following lines to function
2041 	 *	kfd_add_non_crat_information
2042 	 */
2043 
2044 	/* Fill-in additional information that is not available in CRAT but
2045 	 * needed for the topology
2046 	 */
2047 	for (i = 0; i < KFD_TOPOLOGY_PUBLIC_NAME_SIZE-1; i++) {
2048 		dev->node_props.name[i] = __tolower(asic_name[i]);
2049 		if (asic_name[i] == '\0')
2050 			break;
2051 	}
2052 	dev->node_props.name[i] = '\0';
2053 
2054 	dev->node_props.simd_arrays_per_engine =
2055 		gfx_info->max_sh_per_se;
2056 
2057 	dev->node_props.gfx_target_version =
2058 				gpu->kfd->device_info.gfx_target_version;
2059 	dev->node_props.vendor_id = gpu->adev->pdev->vendor;
2060 	dev->node_props.device_id = gpu->adev->pdev->device;
2061 	dev->node_props.capability |=
2062 		((dev->gpu->adev->rev_id << HSA_CAP_ASIC_REVISION_SHIFT) &
2063 			HSA_CAP_ASIC_REVISION_MASK);
2064 
2065 	dev->node_props.location_id = pci_dev_id(gpu->adev->pdev);
2066 	if (gpu->kfd->num_nodes > 1)
2067 		dev->node_props.location_id |= dev->gpu->node_id;
2068 
2069 	dev->node_props.domain = pci_domain_nr(gpu->adev->pdev->bus);
2070 	dev->node_props.max_engine_clk_fcompute =
2071 		amdgpu_amdkfd_get_max_engine_clock_in_mhz(dev->gpu->adev);
2072 	dev->node_props.max_engine_clk_ccompute =
2073 		cpufreq_quick_get_max(0) / 1000;
2074 
2075 	if (gpu->xcp)
2076 		dev->node_props.drm_render_minor = gpu->xcp->ddev->render->index;
2077 	else
2078 		dev->node_props.drm_render_minor =
2079 				gpu->kfd->shared_resources.drm_render_minor;
2080 
2081 	dev->node_props.hive_id = gpu->kfd->hive_id;
2082 	dev->node_props.num_sdma_engines = kfd_get_num_sdma_engines(gpu);
2083 	dev->node_props.num_sdma_xgmi_engines =
2084 					kfd_get_num_xgmi_sdma_engines(gpu);
2085 	dev->node_props.num_sdma_queues_per_engine =
2086 				gpu->kfd->device_info.num_sdma_queues_per_engine -
2087 				gpu->kfd->device_info.num_reserved_sdma_queues_per_engine;
2088 	dev->node_props.num_gws = (dev->gpu->gws &&
2089 		dev->gpu->dqm->sched_policy != KFD_SCHED_POLICY_NO_HWS) ?
2090 		dev->gpu->adev->gds.gws_size : 0;
2091 	dev->node_props.num_cp_queues = get_cp_queues_num(dev->gpu->dqm);
2092 
2093 	kfd_fill_mem_clk_max_info(dev);
2094 	kfd_fill_iolink_non_crat_info(dev);
2095 
2096 	switch (dev->gpu->adev->asic_type) {
2097 	case CHIP_KAVERI:
2098 	case CHIP_HAWAII:
2099 	case CHIP_TONGA:
2100 		dev->node_props.capability |= ((HSA_CAP_DOORBELL_TYPE_PRE_1_0 <<
2101 			HSA_CAP_DOORBELL_TYPE_TOTALBITS_SHIFT) &
2102 			HSA_CAP_DOORBELL_TYPE_TOTALBITS_MASK);
2103 		break;
2104 	case CHIP_CARRIZO:
2105 	case CHIP_FIJI:
2106 	case CHIP_POLARIS10:
2107 	case CHIP_POLARIS11:
2108 	case CHIP_POLARIS12:
2109 	case CHIP_VEGAM:
2110 		pr_debug("Adding doorbell packet type capability\n");
2111 		dev->node_props.capability |= ((HSA_CAP_DOORBELL_TYPE_1_0 <<
2112 			HSA_CAP_DOORBELL_TYPE_TOTALBITS_SHIFT) &
2113 			HSA_CAP_DOORBELL_TYPE_TOTALBITS_MASK);
2114 		break;
2115 	default:
2116 		if (KFD_GC_VERSION(dev->gpu) < IP_VERSION(9, 0, 1))
2117 			WARN(1, "Unexpected ASIC family %u",
2118 			     dev->gpu->adev->asic_type);
2119 		else
2120 			kfd_topology_set_capabilities(dev);
2121 	}
2122 
2123 	/*
2124 	 * Overwrite ATS capability according to needs_iommu_device to fix
2125 	 * potential missing corresponding bit in CRAT of BIOS.
2126 	 */
2127 	dev->node_props.capability &= ~HSA_CAP_ATS_PRESENT;
2128 
2129 	/* Fix errors in CZ CRAT.
2130 	 * simd_count: Carrizo CRAT reports wrong simd_count, probably
2131 	 *		because it doesn't consider masked out CUs
2132 	 * max_waves_per_simd: Carrizo reports wrong max_waves_per_simd
2133 	 */
2134 	if (dev->gpu->adev->asic_type == CHIP_CARRIZO) {
2135 		dev->node_props.simd_count =
2136 			cu_info->simd_per_cu * cu_info->number;
2137 		dev->node_props.max_waves_per_simd = 10;
2138 	}
2139 
2140 	/* kfd only concerns sram ecc on GFX and HBM ecc on UMC */
2141 	dev->node_props.capability |=
2142 		((dev->gpu->adev->ras_enabled & BIT(AMDGPU_RAS_BLOCK__GFX)) != 0) ?
2143 		HSA_CAP_SRAM_EDCSUPPORTED : 0;
2144 	dev->node_props.capability |=
2145 		((dev->gpu->adev->ras_enabled & BIT(AMDGPU_RAS_BLOCK__UMC)) != 0) ?
2146 		HSA_CAP_MEM_EDCSUPPORTED : 0;
2147 
2148 	if (KFD_GC_VERSION(dev->gpu) != IP_VERSION(9, 0, 1))
2149 		dev->node_props.capability |= (dev->gpu->adev->ras_enabled != 0) ?
2150 			HSA_CAP_RASEVENTNOTIFY : 0;
2151 
2152 	if (KFD_IS_SVM_API_SUPPORTED(dev->gpu->adev))
2153 		dev->node_props.capability |= HSA_CAP_SVMAPI_SUPPORTED;
2154 
2155 	if (dev->gpu->adev->gmc.is_app_apu ||
2156 		dev->gpu->adev->gmc.xgmi.connected_to_cpu)
2157 		dev->node_props.capability |= HSA_CAP_FLAGS_COHERENTHOSTACCESS;
2158 
2159 	kfd_queue_ctx_save_restore_size(dev);
2160 
2161 	kfd_debug_print_topology();
2162 
2163 	kfd_notify_gpu_change(gpu_id, 1);
2164 
2165 	return 0;
2166 }
2167 
2168 /**
2169  * kfd_topology_update_io_links() - Update IO links after device removal.
2170  * @proximity_domain: Proximity domain value of the dev being removed.
2171  *
2172  * The topology list currently is arranged in increasing order of
2173  * proximity domain.
2174  *
2175  * Two things need to be done when a device is removed:
2176  * 1. All the IO links to this device need to be removed.
2177  * 2. All nodes after the current device node need to move
2178  *    up once this device node is removed from the topology
2179  *    list. As a result, the proximity domain values for
2180  *    all nodes after the node being deleted reduce by 1.
2181  *    This would also cause the proximity domain values for
2182  *    io links to be updated based on new proximity domain
2183  *    values.
2184  *
2185  * Context: The caller must hold write topology_lock.
2186  */
2187 static void kfd_topology_update_io_links(int proximity_domain)
2188 {
2189 	struct kfd_topology_device *dev;
2190 	struct kfd_iolink_properties *iolink, *p2plink, *tmp;
2191 
2192 	list_for_each_entry(dev, &topology_device_list, list) {
2193 		if (dev->proximity_domain > proximity_domain)
2194 			dev->proximity_domain--;
2195 
2196 		list_for_each_entry_safe(iolink, tmp, &dev->io_link_props, list) {
2197 			/*
2198 			 * If there is an io link to the dev being deleted
2199 			 * then remove that IO link also.
2200 			 */
2201 			if (iolink->node_to == proximity_domain) {
2202 				list_del(&iolink->list);
2203 				dev->node_props.io_links_count--;
2204 			} else {
2205 				if (iolink->node_from > proximity_domain)
2206 					iolink->node_from--;
2207 				if (iolink->node_to > proximity_domain)
2208 					iolink->node_to--;
2209 			}
2210 		}
2211 
2212 		list_for_each_entry_safe(p2plink, tmp, &dev->p2p_link_props, list) {
2213 			/*
2214 			 * If there is a p2p link to the dev being deleted
2215 			 * then remove that p2p link also.
2216 			 */
2217 			if (p2plink->node_to == proximity_domain) {
2218 				list_del(&p2plink->list);
2219 				dev->node_props.p2p_links_count--;
2220 			} else {
2221 				if (p2plink->node_from > proximity_domain)
2222 					p2plink->node_from--;
2223 				if (p2plink->node_to > proximity_domain)
2224 					p2plink->node_to--;
2225 			}
2226 		}
2227 	}
2228 }
2229 
2230 int kfd_topology_remove_device(struct kfd_node *gpu)
2231 {
2232 	struct kfd_topology_device *dev, *tmp;
2233 	uint32_t gpu_id;
2234 	int res = -ENODEV;
2235 	int i = 0;
2236 
2237 	down_write(&topology_lock);
2238 
2239 	list_for_each_entry_safe(dev, tmp, &topology_device_list, list) {
2240 		if (dev->gpu == gpu) {
2241 			gpu_id = dev->gpu_id;
2242 			kfd_remove_sysfs_node_entry(dev);
2243 			kfd_release_topology_device(dev);
2244 			sys_props.num_devices--;
2245 			kfd_topology_update_io_links(i);
2246 			topology_crat_proximity_domain = sys_props.num_devices-1;
2247 			sys_props.generation_count++;
2248 			res = 0;
2249 			if (kfd_topology_update_sysfs() < 0)
2250 				kfd_topology_release_sysfs();
2251 			break;
2252 		}
2253 		i++;
2254 	}
2255 
2256 	up_write(&topology_lock);
2257 
2258 	if (!res)
2259 		kfd_notify_gpu_change(gpu_id, 0);
2260 
2261 	return res;
2262 }
2263 
2264 /* kfd_topology_enum_kfd_devices - Enumerate through all devices in KFD
2265  *	topology. If GPU device is found @idx, then valid kfd_dev pointer is
2266  *	returned through @kdev
2267  * Return -	0: On success (@kdev will be NULL for non GPU nodes)
2268  *		-1: If end of list
2269  */
2270 int kfd_topology_enum_kfd_devices(uint8_t idx, struct kfd_node **kdev)
2271 {
2272 
2273 	struct kfd_topology_device *top_dev;
2274 	uint8_t device_idx = 0;
2275 
2276 	*kdev = NULL;
2277 	down_read(&topology_lock);
2278 
2279 	list_for_each_entry(top_dev, &topology_device_list, list) {
2280 		if (device_idx == idx) {
2281 			*kdev = top_dev->gpu;
2282 			up_read(&topology_lock);
2283 			return 0;
2284 		}
2285 
2286 		device_idx++;
2287 	}
2288 
2289 	up_read(&topology_lock);
2290 
2291 	return -1;
2292 
2293 }
2294 
2295 static int kfd_cpumask_to_apic_id(const struct cpumask *cpumask)
2296 {
2297 	int first_cpu_of_numa_node;
2298 
2299 	if (!cpumask || cpumask == cpu_none_mask)
2300 		return -1;
2301 	first_cpu_of_numa_node = cpumask_first(cpumask);
2302 	if (first_cpu_of_numa_node >= nr_cpu_ids)
2303 		return -1;
2304 #ifdef CONFIG_X86_64
2305 	return cpu_data(first_cpu_of_numa_node).topo.apicid;
2306 #else
2307 	return first_cpu_of_numa_node;
2308 #endif
2309 }
2310 
2311 /* kfd_numa_node_to_apic_id - Returns the APIC ID of the first logical processor
2312  *	of the given NUMA node (numa_node_id)
2313  * Return -1 on failure
2314  */
2315 int kfd_numa_node_to_apic_id(int numa_node_id)
2316 {
2317 	if (numa_node_id == -1) {
2318 		pr_warn("Invalid NUMA Node. Use online CPU mask\n");
2319 		return kfd_cpumask_to_apic_id(cpu_online_mask);
2320 	}
2321 	return kfd_cpumask_to_apic_id(cpumask_of_node(numa_node_id));
2322 }
2323 
2324 #if defined(CONFIG_DEBUG_FS)
2325 
2326 int kfd_debugfs_hqds_by_device(struct seq_file *m, void *data)
2327 {
2328 	struct kfd_topology_device *dev;
2329 	unsigned int i = 0;
2330 	int r = 0;
2331 
2332 	down_read(&topology_lock);
2333 
2334 	list_for_each_entry(dev, &topology_device_list, list) {
2335 		if (!dev->gpu) {
2336 			i++;
2337 			continue;
2338 		}
2339 
2340 		seq_printf(m, "Node %u, gpu_id %x:\n", i++, dev->gpu->id);
2341 		r = dqm_debugfs_hqds(m, dev->gpu->dqm);
2342 		if (r)
2343 			break;
2344 	}
2345 
2346 	up_read(&topology_lock);
2347 
2348 	return r;
2349 }
2350 
2351 int kfd_debugfs_rls_by_device(struct seq_file *m, void *data)
2352 {
2353 	struct kfd_topology_device *dev;
2354 	unsigned int i = 0;
2355 	int r = 0;
2356 
2357 	down_read(&topology_lock);
2358 
2359 	list_for_each_entry(dev, &topology_device_list, list) {
2360 		if (!dev->gpu) {
2361 			i++;
2362 			continue;
2363 		}
2364 
2365 		seq_printf(m, "Node %u, gpu_id %x:\n", i++, dev->gpu->id);
2366 		r = pm_debugfs_runlist(m, &dev->gpu->dqm->packet_mgr);
2367 		if (r)
2368 			break;
2369 	}
2370 
2371 	up_read(&topology_lock);
2372 
2373 	return r;
2374 }
2375 
2376 #endif
2377