xref: /linux/drivers/dma/idxd/sysfs.c (revision 83c49f734463980802d6dba376f69e787fb07a8e)
1 // SPDX-License-Identifier: GPL-2.0
2 /* Copyright(c) 2019 Intel Corporation. All rights rsvd. */
3 #include <linux/init.h>
4 #include <linux/kernel.h>
5 #include <linux/module.h>
6 #include <linux/pci.h>
7 #include <linux/device.h>
8 #include <linux/io-64-nonatomic-lo-hi.h>
9 #include <uapi/linux/idxd.h>
10 #include "registers.h"
11 #include "idxd.h"
12 
13 static char *idxd_wq_type_names[] = {
14 	[IDXD_WQT_NONE]		= "none",
15 	[IDXD_WQT_KERNEL]	= "kernel",
16 	[IDXD_WQT_USER]		= "user",
17 };
18 
19 static void idxd_conf_device_release(struct device *dev)
20 {
21 	dev_dbg(dev, "%s for %s\n", __func__, dev_name(dev));
22 }
23 
24 static struct device_type idxd_group_device_type = {
25 	.name = "group",
26 	.release = idxd_conf_device_release,
27 };
28 
29 static struct device_type idxd_wq_device_type = {
30 	.name = "wq",
31 	.release = idxd_conf_device_release,
32 };
33 
34 static struct device_type idxd_engine_device_type = {
35 	.name = "engine",
36 	.release = idxd_conf_device_release,
37 };
38 
39 static struct device_type dsa_device_type = {
40 	.name = "dsa",
41 	.release = idxd_conf_device_release,
42 };
43 
44 static inline bool is_dsa_dev(struct device *dev)
45 {
46 	return dev ? dev->type == &dsa_device_type : false;
47 }
48 
49 static inline bool is_idxd_dev(struct device *dev)
50 {
51 	return is_dsa_dev(dev);
52 }
53 
54 static inline bool is_idxd_wq_dev(struct device *dev)
55 {
56 	return dev ? dev->type == &idxd_wq_device_type : false;
57 }
58 
59 static inline bool is_idxd_wq_dmaengine(struct idxd_wq *wq)
60 {
61 	if (wq->type == IDXD_WQT_KERNEL &&
62 	    strcmp(wq->name, "dmaengine") == 0)
63 		return true;
64 	return false;
65 }
66 
67 static inline bool is_idxd_wq_cdev(struct idxd_wq *wq)
68 {
69 	return wq->type == IDXD_WQT_USER;
70 }
71 
72 static int idxd_config_bus_match(struct device *dev,
73 				 struct device_driver *drv)
74 {
75 	int matched = 0;
76 
77 	if (is_idxd_dev(dev)) {
78 		struct idxd_device *idxd = confdev_to_idxd(dev);
79 
80 		if (idxd->state != IDXD_DEV_CONF_READY)
81 			return 0;
82 		matched = 1;
83 	} else if (is_idxd_wq_dev(dev)) {
84 		struct idxd_wq *wq = confdev_to_wq(dev);
85 		struct idxd_device *idxd = wq->idxd;
86 
87 		if (idxd->state < IDXD_DEV_CONF_READY)
88 			return 0;
89 
90 		if (wq->state != IDXD_WQ_DISABLED) {
91 			dev_dbg(dev, "%s not disabled\n", dev_name(dev));
92 			return 0;
93 		}
94 		matched = 1;
95 	}
96 
97 	if (matched)
98 		dev_dbg(dev, "%s matched\n", dev_name(dev));
99 
100 	return matched;
101 }
102 
103 static int idxd_config_bus_probe(struct device *dev)
104 {
105 	int rc;
106 	unsigned long flags;
107 
108 	dev_dbg(dev, "%s called\n", __func__);
109 
110 	if (is_idxd_dev(dev)) {
111 		struct idxd_device *idxd = confdev_to_idxd(dev);
112 
113 		if (idxd->state != IDXD_DEV_CONF_READY) {
114 			dev_warn(dev, "Device not ready for config\n");
115 			return -EBUSY;
116 		}
117 
118 		if (!try_module_get(THIS_MODULE))
119 			return -ENXIO;
120 
121 		spin_lock_irqsave(&idxd->dev_lock, flags);
122 
123 		/* Perform IDXD configuration and enabling */
124 		rc = idxd_device_config(idxd);
125 		if (rc < 0) {
126 			spin_unlock_irqrestore(&idxd->dev_lock, flags);
127 			module_put(THIS_MODULE);
128 			dev_warn(dev, "Device config failed: %d\n", rc);
129 			return rc;
130 		}
131 
132 		/* start device */
133 		rc = idxd_device_enable(idxd);
134 		if (rc < 0) {
135 			spin_unlock_irqrestore(&idxd->dev_lock, flags);
136 			module_put(THIS_MODULE);
137 			dev_warn(dev, "Device enable failed: %d\n", rc);
138 			return rc;
139 		}
140 
141 		spin_unlock_irqrestore(&idxd->dev_lock, flags);
142 		dev_info(dev, "Device %s enabled\n", dev_name(dev));
143 
144 		rc = idxd_register_dma_device(idxd);
145 		if (rc < 0) {
146 			spin_unlock_irqrestore(&idxd->dev_lock, flags);
147 			module_put(THIS_MODULE);
148 			dev_dbg(dev, "Failed to register dmaengine device\n");
149 			return rc;
150 		}
151 		return 0;
152 	} else if (is_idxd_wq_dev(dev)) {
153 		struct idxd_wq *wq = confdev_to_wq(dev);
154 		struct idxd_device *idxd = wq->idxd;
155 
156 		mutex_lock(&wq->wq_lock);
157 
158 		if (idxd->state != IDXD_DEV_ENABLED) {
159 			mutex_unlock(&wq->wq_lock);
160 			dev_warn(dev, "Enabling while device not enabled.\n");
161 			return -EPERM;
162 		}
163 
164 		if (wq->state != IDXD_WQ_DISABLED) {
165 			mutex_unlock(&wq->wq_lock);
166 			dev_warn(dev, "WQ %d already enabled.\n", wq->id);
167 			return -EBUSY;
168 		}
169 
170 		if (!wq->group) {
171 			mutex_unlock(&wq->wq_lock);
172 			dev_warn(dev, "WQ not attached to group.\n");
173 			return -EINVAL;
174 		}
175 
176 		if (strlen(wq->name) == 0) {
177 			mutex_unlock(&wq->wq_lock);
178 			dev_warn(dev, "WQ name not set.\n");
179 			return -EINVAL;
180 		}
181 
182 		rc = idxd_wq_alloc_resources(wq);
183 		if (rc < 0) {
184 			mutex_unlock(&wq->wq_lock);
185 			dev_warn(dev, "WQ resource alloc failed\n");
186 			return rc;
187 		}
188 
189 		spin_lock_irqsave(&idxd->dev_lock, flags);
190 		rc = idxd_device_config(idxd);
191 		if (rc < 0) {
192 			spin_unlock_irqrestore(&idxd->dev_lock, flags);
193 			mutex_unlock(&wq->wq_lock);
194 			dev_warn(dev, "Writing WQ %d config failed: %d\n",
195 				 wq->id, rc);
196 			return rc;
197 		}
198 
199 		rc = idxd_wq_enable(wq);
200 		if (rc < 0) {
201 			spin_unlock_irqrestore(&idxd->dev_lock, flags);
202 			mutex_unlock(&wq->wq_lock);
203 			dev_warn(dev, "WQ %d enabling failed: %d\n",
204 				 wq->id, rc);
205 			return rc;
206 		}
207 		spin_unlock_irqrestore(&idxd->dev_lock, flags);
208 
209 		rc = idxd_wq_map_portal(wq);
210 		if (rc < 0) {
211 			dev_warn(dev, "wq portal mapping failed: %d\n", rc);
212 			rc = idxd_wq_disable(wq);
213 			if (rc < 0)
214 				dev_warn(dev, "IDXD wq disable failed\n");
215 			spin_unlock_irqrestore(&idxd->dev_lock, flags);
216 			mutex_unlock(&wq->wq_lock);
217 			return rc;
218 		}
219 
220 		wq->client_count = 0;
221 
222 		dev_info(dev, "wq %s enabled\n", dev_name(&wq->conf_dev));
223 
224 		if (is_idxd_wq_dmaengine(wq)) {
225 			rc = idxd_register_dma_channel(wq);
226 			if (rc < 0) {
227 				dev_dbg(dev, "DMA channel register failed\n");
228 				mutex_unlock(&wq->wq_lock);
229 				return rc;
230 			}
231 		} else if (is_idxd_wq_cdev(wq)) {
232 			rc = idxd_wq_add_cdev(wq);
233 			if (rc < 0) {
234 				dev_dbg(dev, "Cdev creation failed\n");
235 				mutex_unlock(&wq->wq_lock);
236 				return rc;
237 			}
238 		}
239 
240 		mutex_unlock(&wq->wq_lock);
241 		return 0;
242 	}
243 
244 	return -ENODEV;
245 }
246 
247 static void disable_wq(struct idxd_wq *wq)
248 {
249 	struct idxd_device *idxd = wq->idxd;
250 	struct device *dev = &idxd->pdev->dev;
251 	unsigned long flags;
252 	int rc;
253 
254 	mutex_lock(&wq->wq_lock);
255 	dev_dbg(dev, "%s removing WQ %s\n", __func__, dev_name(&wq->conf_dev));
256 	if (wq->state == IDXD_WQ_DISABLED) {
257 		mutex_unlock(&wq->wq_lock);
258 		return;
259 	}
260 
261 	if (is_idxd_wq_dmaengine(wq))
262 		idxd_unregister_dma_channel(wq);
263 	else if (is_idxd_wq_cdev(wq))
264 		idxd_wq_del_cdev(wq);
265 
266 	if (idxd_wq_refcount(wq))
267 		dev_warn(dev, "Clients has claim on wq %d: %d\n",
268 			 wq->id, idxd_wq_refcount(wq));
269 
270 	idxd_wq_unmap_portal(wq);
271 
272 	spin_lock_irqsave(&idxd->dev_lock, flags);
273 	rc = idxd_wq_disable(wq);
274 	spin_unlock_irqrestore(&idxd->dev_lock, flags);
275 
276 	idxd_wq_free_resources(wq);
277 	wq->client_count = 0;
278 	mutex_unlock(&wq->wq_lock);
279 
280 	if (rc < 0)
281 		dev_warn(dev, "Failed to disable %s: %d\n",
282 			 dev_name(&wq->conf_dev), rc);
283 	else
284 		dev_info(dev, "wq %s disabled\n", dev_name(&wq->conf_dev));
285 }
286 
287 static int idxd_config_bus_remove(struct device *dev)
288 {
289 	int rc;
290 	unsigned long flags;
291 
292 	dev_dbg(dev, "%s called for %s\n", __func__, dev_name(dev));
293 
294 	/* disable workqueue here */
295 	if (is_idxd_wq_dev(dev)) {
296 		struct idxd_wq *wq = confdev_to_wq(dev);
297 
298 		disable_wq(wq);
299 	} else if (is_idxd_dev(dev)) {
300 		struct idxd_device *idxd = confdev_to_idxd(dev);
301 		int i;
302 
303 		dev_dbg(dev, "%s removing dev %s\n", __func__,
304 			dev_name(&idxd->conf_dev));
305 		for (i = 0; i < idxd->max_wqs; i++) {
306 			struct idxd_wq *wq = &idxd->wqs[i];
307 
308 			if (wq->state == IDXD_WQ_DISABLED)
309 				continue;
310 			dev_warn(dev, "Active wq %d on disable %s.\n", i,
311 				 dev_name(&idxd->conf_dev));
312 			device_release_driver(&wq->conf_dev);
313 		}
314 
315 		idxd_unregister_dma_device(idxd);
316 		spin_lock_irqsave(&idxd->dev_lock, flags);
317 		rc = idxd_device_disable(idxd);
318 		spin_unlock_irqrestore(&idxd->dev_lock, flags);
319 		module_put(THIS_MODULE);
320 		if (rc < 0)
321 			dev_warn(dev, "Device disable failed\n");
322 		else
323 			dev_info(dev, "Device %s disabled\n", dev_name(dev));
324 
325 	}
326 
327 	return 0;
328 }
329 
330 static void idxd_config_bus_shutdown(struct device *dev)
331 {
332 	dev_dbg(dev, "%s called\n", __func__);
333 }
334 
335 struct bus_type dsa_bus_type = {
336 	.name = "dsa",
337 	.match = idxd_config_bus_match,
338 	.probe = idxd_config_bus_probe,
339 	.remove = idxd_config_bus_remove,
340 	.shutdown = idxd_config_bus_shutdown,
341 };
342 
343 static struct bus_type *idxd_bus_types[] = {
344 	&dsa_bus_type
345 };
346 
347 static struct idxd_device_driver dsa_drv = {
348 	.drv = {
349 		.name = "dsa",
350 		.bus = &dsa_bus_type,
351 		.owner = THIS_MODULE,
352 		.mod_name = KBUILD_MODNAME,
353 	},
354 };
355 
356 static struct idxd_device_driver *idxd_drvs[] = {
357 	&dsa_drv
358 };
359 
360 struct bus_type *idxd_get_bus_type(struct idxd_device *idxd)
361 {
362 	return idxd_bus_types[idxd->type];
363 }
364 
365 static struct device_type *idxd_get_device_type(struct idxd_device *idxd)
366 {
367 	if (idxd->type == IDXD_TYPE_DSA)
368 		return &dsa_device_type;
369 	else
370 		return NULL;
371 }
372 
373 /* IDXD generic driver setup */
374 int idxd_register_driver(void)
375 {
376 	int i, rc;
377 
378 	for (i = 0; i < IDXD_TYPE_MAX; i++) {
379 		rc = driver_register(&idxd_drvs[i]->drv);
380 		if (rc < 0)
381 			goto drv_fail;
382 	}
383 
384 	return 0;
385 
386 drv_fail:
387 	for (; i > 0; i--)
388 		driver_unregister(&idxd_drvs[i]->drv);
389 	return rc;
390 }
391 
392 void idxd_unregister_driver(void)
393 {
394 	int i;
395 
396 	for (i = 0; i < IDXD_TYPE_MAX; i++)
397 		driver_unregister(&idxd_drvs[i]->drv);
398 }
399 
400 /* IDXD engine attributes */
401 static ssize_t engine_group_id_show(struct device *dev,
402 				    struct device_attribute *attr, char *buf)
403 {
404 	struct idxd_engine *engine =
405 		container_of(dev, struct idxd_engine, conf_dev);
406 
407 	if (engine->group)
408 		return sprintf(buf, "%d\n", engine->group->id);
409 	else
410 		return sprintf(buf, "%d\n", -1);
411 }
412 
413 static ssize_t engine_group_id_store(struct device *dev,
414 				     struct device_attribute *attr,
415 				     const char *buf, size_t count)
416 {
417 	struct idxd_engine *engine =
418 		container_of(dev, struct idxd_engine, conf_dev);
419 	struct idxd_device *idxd = engine->idxd;
420 	long id;
421 	int rc;
422 	struct idxd_group *prevg, *group;
423 
424 	rc = kstrtol(buf, 10, &id);
425 	if (rc < 0)
426 		return -EINVAL;
427 
428 	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
429 		return -EPERM;
430 
431 	if (id > idxd->max_groups - 1 || id < -1)
432 		return -EINVAL;
433 
434 	if (id == -1) {
435 		if (engine->group) {
436 			engine->group->num_engines--;
437 			engine->group = NULL;
438 		}
439 		return count;
440 	}
441 
442 	group = &idxd->groups[id];
443 	prevg = engine->group;
444 
445 	if (prevg)
446 		prevg->num_engines--;
447 	engine->group = &idxd->groups[id];
448 	engine->group->num_engines++;
449 
450 	return count;
451 }
452 
453 static struct device_attribute dev_attr_engine_group =
454 		__ATTR(group_id, 0644, engine_group_id_show,
455 		       engine_group_id_store);
456 
457 static struct attribute *idxd_engine_attributes[] = {
458 	&dev_attr_engine_group.attr,
459 	NULL,
460 };
461 
462 static const struct attribute_group idxd_engine_attribute_group = {
463 	.attrs = idxd_engine_attributes,
464 };
465 
466 static const struct attribute_group *idxd_engine_attribute_groups[] = {
467 	&idxd_engine_attribute_group,
468 	NULL,
469 };
470 
471 /* Group attributes */
472 
473 static void idxd_set_free_tokens(struct idxd_device *idxd)
474 {
475 	int i, tokens;
476 
477 	for (i = 0, tokens = 0; i < idxd->max_groups; i++) {
478 		struct idxd_group *g = &idxd->groups[i];
479 
480 		tokens += g->tokens_reserved;
481 	}
482 
483 	idxd->nr_tokens = idxd->max_tokens - tokens;
484 }
485 
486 static ssize_t group_tokens_reserved_show(struct device *dev,
487 					  struct device_attribute *attr,
488 					  char *buf)
489 {
490 	struct idxd_group *group =
491 		container_of(dev, struct idxd_group, conf_dev);
492 
493 	return sprintf(buf, "%u\n", group->tokens_reserved);
494 }
495 
496 static ssize_t group_tokens_reserved_store(struct device *dev,
497 					   struct device_attribute *attr,
498 					   const char *buf, size_t count)
499 {
500 	struct idxd_group *group =
501 		container_of(dev, struct idxd_group, conf_dev);
502 	struct idxd_device *idxd = group->idxd;
503 	unsigned long val;
504 	int rc;
505 
506 	rc = kstrtoul(buf, 10, &val);
507 	if (rc < 0)
508 		return -EINVAL;
509 
510 	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
511 		return -EPERM;
512 
513 	if (idxd->state == IDXD_DEV_ENABLED)
514 		return -EPERM;
515 
516 	if (idxd->token_limit == 0)
517 		return -EPERM;
518 
519 	if (val > idxd->max_tokens)
520 		return -EINVAL;
521 
522 	if (val > idxd->nr_tokens)
523 		return -EINVAL;
524 
525 	group->tokens_reserved = val;
526 	idxd_set_free_tokens(idxd);
527 	return count;
528 }
529 
530 static struct device_attribute dev_attr_group_tokens_reserved =
531 		__ATTR(tokens_reserved, 0644, group_tokens_reserved_show,
532 		       group_tokens_reserved_store);
533 
534 static ssize_t group_tokens_allowed_show(struct device *dev,
535 					 struct device_attribute *attr,
536 					 char *buf)
537 {
538 	struct idxd_group *group =
539 		container_of(dev, struct idxd_group, conf_dev);
540 
541 	return sprintf(buf, "%u\n", group->tokens_allowed);
542 }
543 
544 static ssize_t group_tokens_allowed_store(struct device *dev,
545 					  struct device_attribute *attr,
546 					  const char *buf, size_t count)
547 {
548 	struct idxd_group *group =
549 		container_of(dev, struct idxd_group, conf_dev);
550 	struct idxd_device *idxd = group->idxd;
551 	unsigned long val;
552 	int rc;
553 
554 	rc = kstrtoul(buf, 10, &val);
555 	if (rc < 0)
556 		return -EINVAL;
557 
558 	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
559 		return -EPERM;
560 
561 	if (idxd->state == IDXD_DEV_ENABLED)
562 		return -EPERM;
563 
564 	if (idxd->token_limit == 0)
565 		return -EPERM;
566 	if (val < 4 * group->num_engines ||
567 	    val > group->tokens_reserved + idxd->nr_tokens)
568 		return -EINVAL;
569 
570 	group->tokens_allowed = val;
571 	return count;
572 }
573 
574 static struct device_attribute dev_attr_group_tokens_allowed =
575 		__ATTR(tokens_allowed, 0644, group_tokens_allowed_show,
576 		       group_tokens_allowed_store);
577 
578 static ssize_t group_use_token_limit_show(struct device *dev,
579 					  struct device_attribute *attr,
580 					  char *buf)
581 {
582 	struct idxd_group *group =
583 		container_of(dev, struct idxd_group, conf_dev);
584 
585 	return sprintf(buf, "%u\n", group->use_token_limit);
586 }
587 
588 static ssize_t group_use_token_limit_store(struct device *dev,
589 					   struct device_attribute *attr,
590 					   const char *buf, size_t count)
591 {
592 	struct idxd_group *group =
593 		container_of(dev, struct idxd_group, conf_dev);
594 	struct idxd_device *idxd = group->idxd;
595 	unsigned long val;
596 	int rc;
597 
598 	rc = kstrtoul(buf, 10, &val);
599 	if (rc < 0)
600 		return -EINVAL;
601 
602 	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
603 		return -EPERM;
604 
605 	if (idxd->state == IDXD_DEV_ENABLED)
606 		return -EPERM;
607 
608 	if (idxd->token_limit == 0)
609 		return -EPERM;
610 
611 	group->use_token_limit = !!val;
612 	return count;
613 }
614 
615 static struct device_attribute dev_attr_group_use_token_limit =
616 		__ATTR(use_token_limit, 0644, group_use_token_limit_show,
617 		       group_use_token_limit_store);
618 
619 static ssize_t group_engines_show(struct device *dev,
620 				  struct device_attribute *attr, char *buf)
621 {
622 	struct idxd_group *group =
623 		container_of(dev, struct idxd_group, conf_dev);
624 	int i, rc = 0;
625 	char *tmp = buf;
626 	struct idxd_device *idxd = group->idxd;
627 
628 	for (i = 0; i < idxd->max_engines; i++) {
629 		struct idxd_engine *engine = &idxd->engines[i];
630 
631 		if (!engine->group)
632 			continue;
633 
634 		if (engine->group->id == group->id)
635 			rc += sprintf(tmp + rc, "engine%d.%d ",
636 					idxd->id, engine->id);
637 	}
638 
639 	rc--;
640 	rc += sprintf(tmp + rc, "\n");
641 
642 	return rc;
643 }
644 
645 static struct device_attribute dev_attr_group_engines =
646 		__ATTR(engines, 0444, group_engines_show, NULL);
647 
648 static ssize_t group_work_queues_show(struct device *dev,
649 				      struct device_attribute *attr, char *buf)
650 {
651 	struct idxd_group *group =
652 		container_of(dev, struct idxd_group, conf_dev);
653 	int i, rc = 0;
654 	char *tmp = buf;
655 	struct idxd_device *idxd = group->idxd;
656 
657 	for (i = 0; i < idxd->max_wqs; i++) {
658 		struct idxd_wq *wq = &idxd->wqs[i];
659 
660 		if (!wq->group)
661 			continue;
662 
663 		if (wq->group->id == group->id)
664 			rc += sprintf(tmp + rc, "wq%d.%d ",
665 					idxd->id, wq->id);
666 	}
667 
668 	rc--;
669 	rc += sprintf(tmp + rc, "\n");
670 
671 	return rc;
672 }
673 
674 static struct device_attribute dev_attr_group_work_queues =
675 		__ATTR(work_queues, 0444, group_work_queues_show, NULL);
676 
677 static ssize_t group_traffic_class_a_show(struct device *dev,
678 					  struct device_attribute *attr,
679 					  char *buf)
680 {
681 	struct idxd_group *group =
682 		container_of(dev, struct idxd_group, conf_dev);
683 
684 	return sprintf(buf, "%d\n", group->tc_a);
685 }
686 
687 static ssize_t group_traffic_class_a_store(struct device *dev,
688 					   struct device_attribute *attr,
689 					   const char *buf, size_t count)
690 {
691 	struct idxd_group *group =
692 		container_of(dev, struct idxd_group, conf_dev);
693 	struct idxd_device *idxd = group->idxd;
694 	long val;
695 	int rc;
696 
697 	rc = kstrtol(buf, 10, &val);
698 	if (rc < 0)
699 		return -EINVAL;
700 
701 	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
702 		return -EPERM;
703 
704 	if (idxd->state == IDXD_DEV_ENABLED)
705 		return -EPERM;
706 
707 	if (val < 0 || val > 7)
708 		return -EINVAL;
709 
710 	group->tc_a = val;
711 	return count;
712 }
713 
714 static struct device_attribute dev_attr_group_traffic_class_a =
715 		__ATTR(traffic_class_a, 0644, group_traffic_class_a_show,
716 		       group_traffic_class_a_store);
717 
718 static ssize_t group_traffic_class_b_show(struct device *dev,
719 					  struct device_attribute *attr,
720 					  char *buf)
721 {
722 	struct idxd_group *group =
723 		container_of(dev, struct idxd_group, conf_dev);
724 
725 	return sprintf(buf, "%d\n", group->tc_b);
726 }
727 
728 static ssize_t group_traffic_class_b_store(struct device *dev,
729 					   struct device_attribute *attr,
730 					   const char *buf, size_t count)
731 {
732 	struct idxd_group *group =
733 		container_of(dev, struct idxd_group, conf_dev);
734 	struct idxd_device *idxd = group->idxd;
735 	long val;
736 	int rc;
737 
738 	rc = kstrtol(buf, 10, &val);
739 	if (rc < 0)
740 		return -EINVAL;
741 
742 	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
743 		return -EPERM;
744 
745 	if (idxd->state == IDXD_DEV_ENABLED)
746 		return -EPERM;
747 
748 	if (val < 0 || val > 7)
749 		return -EINVAL;
750 
751 	group->tc_b = val;
752 	return count;
753 }
754 
755 static struct device_attribute dev_attr_group_traffic_class_b =
756 		__ATTR(traffic_class_b, 0644, group_traffic_class_b_show,
757 		       group_traffic_class_b_store);
758 
759 static struct attribute *idxd_group_attributes[] = {
760 	&dev_attr_group_work_queues.attr,
761 	&dev_attr_group_engines.attr,
762 	&dev_attr_group_use_token_limit.attr,
763 	&dev_attr_group_tokens_allowed.attr,
764 	&dev_attr_group_tokens_reserved.attr,
765 	&dev_attr_group_traffic_class_a.attr,
766 	&dev_attr_group_traffic_class_b.attr,
767 	NULL,
768 };
769 
770 static const struct attribute_group idxd_group_attribute_group = {
771 	.attrs = idxd_group_attributes,
772 };
773 
774 static const struct attribute_group *idxd_group_attribute_groups[] = {
775 	&idxd_group_attribute_group,
776 	NULL,
777 };
778 
779 /* IDXD work queue attribs */
780 static ssize_t wq_clients_show(struct device *dev,
781 			       struct device_attribute *attr, char *buf)
782 {
783 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
784 
785 	return sprintf(buf, "%d\n", wq->client_count);
786 }
787 
788 static struct device_attribute dev_attr_wq_clients =
789 		__ATTR(clients, 0444, wq_clients_show, NULL);
790 
791 static ssize_t wq_state_show(struct device *dev,
792 			     struct device_attribute *attr, char *buf)
793 {
794 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
795 
796 	switch (wq->state) {
797 	case IDXD_WQ_DISABLED:
798 		return sprintf(buf, "disabled\n");
799 	case IDXD_WQ_ENABLED:
800 		return sprintf(buf, "enabled\n");
801 	}
802 
803 	return sprintf(buf, "unknown\n");
804 }
805 
806 static struct device_attribute dev_attr_wq_state =
807 		__ATTR(state, 0444, wq_state_show, NULL);
808 
809 static ssize_t wq_group_id_show(struct device *dev,
810 				struct device_attribute *attr, char *buf)
811 {
812 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
813 
814 	if (wq->group)
815 		return sprintf(buf, "%u\n", wq->group->id);
816 	else
817 		return sprintf(buf, "-1\n");
818 }
819 
820 static ssize_t wq_group_id_store(struct device *dev,
821 				 struct device_attribute *attr,
822 				 const char *buf, size_t count)
823 {
824 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
825 	struct idxd_device *idxd = wq->idxd;
826 	long id;
827 	int rc;
828 	struct idxd_group *prevg, *group;
829 
830 	rc = kstrtol(buf, 10, &id);
831 	if (rc < 0)
832 		return -EINVAL;
833 
834 	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
835 		return -EPERM;
836 
837 	if (wq->state != IDXD_WQ_DISABLED)
838 		return -EPERM;
839 
840 	if (id > idxd->max_groups - 1 || id < -1)
841 		return -EINVAL;
842 
843 	if (id == -1) {
844 		if (wq->group) {
845 			wq->group->num_wqs--;
846 			wq->group = NULL;
847 		}
848 		return count;
849 	}
850 
851 	group = &idxd->groups[id];
852 	prevg = wq->group;
853 
854 	if (prevg)
855 		prevg->num_wqs--;
856 	wq->group = group;
857 	group->num_wqs++;
858 	return count;
859 }
860 
861 static struct device_attribute dev_attr_wq_group_id =
862 		__ATTR(group_id, 0644, wq_group_id_show, wq_group_id_store);
863 
864 static ssize_t wq_mode_show(struct device *dev, struct device_attribute *attr,
865 			    char *buf)
866 {
867 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
868 
869 	return sprintf(buf, "%s\n",
870 			wq_dedicated(wq) ? "dedicated" : "shared");
871 }
872 
873 static ssize_t wq_mode_store(struct device *dev,
874 			     struct device_attribute *attr, const char *buf,
875 			     size_t count)
876 {
877 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
878 	struct idxd_device *idxd = wq->idxd;
879 
880 	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
881 		return -EPERM;
882 
883 	if (wq->state != IDXD_WQ_DISABLED)
884 		return -EPERM;
885 
886 	if (sysfs_streq(buf, "dedicated")) {
887 		set_bit(WQ_FLAG_DEDICATED, &wq->flags);
888 		wq->threshold = 0;
889 	} else {
890 		return -EINVAL;
891 	}
892 
893 	return count;
894 }
895 
896 static struct device_attribute dev_attr_wq_mode =
897 		__ATTR(mode, 0644, wq_mode_show, wq_mode_store);
898 
899 static ssize_t wq_size_show(struct device *dev, struct device_attribute *attr,
900 			    char *buf)
901 {
902 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
903 
904 	return sprintf(buf, "%u\n", wq->size);
905 }
906 
907 static ssize_t wq_size_store(struct device *dev,
908 			     struct device_attribute *attr, const char *buf,
909 			     size_t count)
910 {
911 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
912 	unsigned long size;
913 	struct idxd_device *idxd = wq->idxd;
914 	int rc;
915 
916 	rc = kstrtoul(buf, 10, &size);
917 	if (rc < 0)
918 		return -EINVAL;
919 
920 	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
921 		return -EPERM;
922 
923 	if (wq->state != IDXD_WQ_DISABLED)
924 		return -EPERM;
925 
926 	if (size > idxd->max_wq_size)
927 		return -EINVAL;
928 
929 	wq->size = size;
930 	return count;
931 }
932 
933 static struct device_attribute dev_attr_wq_size =
934 		__ATTR(size, 0644, wq_size_show, wq_size_store);
935 
936 static ssize_t wq_priority_show(struct device *dev,
937 				struct device_attribute *attr, char *buf)
938 {
939 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
940 
941 	return sprintf(buf, "%u\n", wq->priority);
942 }
943 
944 static ssize_t wq_priority_store(struct device *dev,
945 				 struct device_attribute *attr,
946 				 const char *buf, size_t count)
947 {
948 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
949 	unsigned long prio;
950 	struct idxd_device *idxd = wq->idxd;
951 	int rc;
952 
953 	rc = kstrtoul(buf, 10, &prio);
954 	if (rc < 0)
955 		return -EINVAL;
956 
957 	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
958 		return -EPERM;
959 
960 	if (wq->state != IDXD_WQ_DISABLED)
961 		return -EPERM;
962 
963 	if (prio > IDXD_MAX_PRIORITY)
964 		return -EINVAL;
965 
966 	wq->priority = prio;
967 	return count;
968 }
969 
970 static struct device_attribute dev_attr_wq_priority =
971 		__ATTR(priority, 0644, wq_priority_show, wq_priority_store);
972 
973 static ssize_t wq_type_show(struct device *dev,
974 			    struct device_attribute *attr, char *buf)
975 {
976 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
977 
978 	switch (wq->type) {
979 	case IDXD_WQT_KERNEL:
980 		return sprintf(buf, "%s\n",
981 			       idxd_wq_type_names[IDXD_WQT_KERNEL]);
982 	case IDXD_WQT_USER:
983 		return sprintf(buf, "%s\n",
984 			       idxd_wq_type_names[IDXD_WQT_USER]);
985 	case IDXD_WQT_NONE:
986 	default:
987 		return sprintf(buf, "%s\n",
988 			       idxd_wq_type_names[IDXD_WQT_NONE]);
989 	}
990 
991 	return -EINVAL;
992 }
993 
994 static ssize_t wq_type_store(struct device *dev,
995 			     struct device_attribute *attr, const char *buf,
996 			     size_t count)
997 {
998 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
999 	enum idxd_wq_type old_type;
1000 
1001 	if (wq->state != IDXD_WQ_DISABLED)
1002 		return -EPERM;
1003 
1004 	old_type = wq->type;
1005 	if (sysfs_streq(buf, idxd_wq_type_names[IDXD_WQT_KERNEL]))
1006 		wq->type = IDXD_WQT_KERNEL;
1007 	else if (sysfs_streq(buf, idxd_wq_type_names[IDXD_WQT_USER]))
1008 		wq->type = IDXD_WQT_USER;
1009 	else
1010 		wq->type = IDXD_WQT_NONE;
1011 
1012 	/* If we are changing queue type, clear the name */
1013 	if (wq->type != old_type)
1014 		memset(wq->name, 0, WQ_NAME_SIZE + 1);
1015 
1016 	return count;
1017 }
1018 
1019 static struct device_attribute dev_attr_wq_type =
1020 		__ATTR(type, 0644, wq_type_show, wq_type_store);
1021 
1022 static ssize_t wq_name_show(struct device *dev,
1023 			    struct device_attribute *attr, char *buf)
1024 {
1025 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
1026 
1027 	return sprintf(buf, "%s\n", wq->name);
1028 }
1029 
1030 static ssize_t wq_name_store(struct device *dev,
1031 			     struct device_attribute *attr, const char *buf,
1032 			     size_t count)
1033 {
1034 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
1035 
1036 	if (wq->state != IDXD_WQ_DISABLED)
1037 		return -EPERM;
1038 
1039 	if (strlen(buf) > WQ_NAME_SIZE || strlen(buf) == 0)
1040 		return -EINVAL;
1041 
1042 	memset(wq->name, 0, WQ_NAME_SIZE + 1);
1043 	strncpy(wq->name, buf, WQ_NAME_SIZE);
1044 	strreplace(wq->name, '\n', '\0');
1045 	return count;
1046 }
1047 
1048 static struct device_attribute dev_attr_wq_name =
1049 		__ATTR(name, 0644, wq_name_show, wq_name_store);
1050 
1051 static ssize_t wq_cdev_minor_show(struct device *dev,
1052 				  struct device_attribute *attr, char *buf)
1053 {
1054 	struct idxd_wq *wq = container_of(dev, struct idxd_wq, conf_dev);
1055 
1056 	return sprintf(buf, "%d\n", wq->idxd_cdev.minor);
1057 }
1058 
1059 static struct device_attribute dev_attr_wq_cdev_minor =
1060 		__ATTR(cdev_minor, 0444, wq_cdev_minor_show, NULL);
1061 
1062 static struct attribute *idxd_wq_attributes[] = {
1063 	&dev_attr_wq_clients.attr,
1064 	&dev_attr_wq_state.attr,
1065 	&dev_attr_wq_group_id.attr,
1066 	&dev_attr_wq_mode.attr,
1067 	&dev_attr_wq_size.attr,
1068 	&dev_attr_wq_priority.attr,
1069 	&dev_attr_wq_type.attr,
1070 	&dev_attr_wq_name.attr,
1071 	&dev_attr_wq_cdev_minor.attr,
1072 	NULL,
1073 };
1074 
1075 static const struct attribute_group idxd_wq_attribute_group = {
1076 	.attrs = idxd_wq_attributes,
1077 };
1078 
1079 static const struct attribute_group *idxd_wq_attribute_groups[] = {
1080 	&idxd_wq_attribute_group,
1081 	NULL,
1082 };
1083 
1084 /* IDXD device attribs */
1085 static ssize_t max_work_queues_size_show(struct device *dev,
1086 					 struct device_attribute *attr,
1087 					 char *buf)
1088 {
1089 	struct idxd_device *idxd =
1090 		container_of(dev, struct idxd_device, conf_dev);
1091 
1092 	return sprintf(buf, "%u\n", idxd->max_wq_size);
1093 }
1094 static DEVICE_ATTR_RO(max_work_queues_size);
1095 
1096 static ssize_t max_groups_show(struct device *dev,
1097 			       struct device_attribute *attr, char *buf)
1098 {
1099 	struct idxd_device *idxd =
1100 		container_of(dev, struct idxd_device, conf_dev);
1101 
1102 	return sprintf(buf, "%u\n", idxd->max_groups);
1103 }
1104 static DEVICE_ATTR_RO(max_groups);
1105 
1106 static ssize_t max_work_queues_show(struct device *dev,
1107 				    struct device_attribute *attr, char *buf)
1108 {
1109 	struct idxd_device *idxd =
1110 		container_of(dev, struct idxd_device, conf_dev);
1111 
1112 	return sprintf(buf, "%u\n", idxd->max_wqs);
1113 }
1114 static DEVICE_ATTR_RO(max_work_queues);
1115 
1116 static ssize_t max_engines_show(struct device *dev,
1117 				struct device_attribute *attr, char *buf)
1118 {
1119 	struct idxd_device *idxd =
1120 		container_of(dev, struct idxd_device, conf_dev);
1121 
1122 	return sprintf(buf, "%u\n", idxd->max_engines);
1123 }
1124 static DEVICE_ATTR_RO(max_engines);
1125 
1126 static ssize_t numa_node_show(struct device *dev,
1127 			      struct device_attribute *attr, char *buf)
1128 {
1129 	struct idxd_device *idxd =
1130 		container_of(dev, struct idxd_device, conf_dev);
1131 
1132 	return sprintf(buf, "%d\n", dev_to_node(&idxd->pdev->dev));
1133 }
1134 static DEVICE_ATTR_RO(numa_node);
1135 
1136 static ssize_t max_batch_size_show(struct device *dev,
1137 				   struct device_attribute *attr, char *buf)
1138 {
1139 	struct idxd_device *idxd =
1140 		container_of(dev, struct idxd_device, conf_dev);
1141 
1142 	return sprintf(buf, "%u\n", idxd->max_batch_size);
1143 }
1144 static DEVICE_ATTR_RO(max_batch_size);
1145 
1146 static ssize_t max_transfer_size_show(struct device *dev,
1147 				      struct device_attribute *attr,
1148 				      char *buf)
1149 {
1150 	struct idxd_device *idxd =
1151 		container_of(dev, struct idxd_device, conf_dev);
1152 
1153 	return sprintf(buf, "%llu\n", idxd->max_xfer_bytes);
1154 }
1155 static DEVICE_ATTR_RO(max_transfer_size);
1156 
1157 static ssize_t op_cap_show(struct device *dev,
1158 			   struct device_attribute *attr, char *buf)
1159 {
1160 	struct idxd_device *idxd =
1161 		container_of(dev, struct idxd_device, conf_dev);
1162 
1163 	return sprintf(buf, "%#llx\n", idxd->hw.opcap.bits[0]);
1164 }
1165 static DEVICE_ATTR_RO(op_cap);
1166 
1167 static ssize_t configurable_show(struct device *dev,
1168 				 struct device_attribute *attr, char *buf)
1169 {
1170 	struct idxd_device *idxd =
1171 		container_of(dev, struct idxd_device, conf_dev);
1172 
1173 	return sprintf(buf, "%u\n",
1174 			test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags));
1175 }
1176 static DEVICE_ATTR_RO(configurable);
1177 
1178 static ssize_t clients_show(struct device *dev,
1179 			    struct device_attribute *attr, char *buf)
1180 {
1181 	struct idxd_device *idxd =
1182 		container_of(dev, struct idxd_device, conf_dev);
1183 	unsigned long flags;
1184 	int count = 0, i;
1185 
1186 	spin_lock_irqsave(&idxd->dev_lock, flags);
1187 	for (i = 0; i < idxd->max_wqs; i++) {
1188 		struct idxd_wq *wq = &idxd->wqs[i];
1189 
1190 		count += wq->client_count;
1191 	}
1192 	spin_unlock_irqrestore(&idxd->dev_lock, flags);
1193 
1194 	return sprintf(buf, "%d\n", count);
1195 }
1196 static DEVICE_ATTR_RO(clients);
1197 
1198 static ssize_t state_show(struct device *dev,
1199 			  struct device_attribute *attr, char *buf)
1200 {
1201 	struct idxd_device *idxd =
1202 		container_of(dev, struct idxd_device, conf_dev);
1203 
1204 	switch (idxd->state) {
1205 	case IDXD_DEV_DISABLED:
1206 	case IDXD_DEV_CONF_READY:
1207 		return sprintf(buf, "disabled\n");
1208 	case IDXD_DEV_ENABLED:
1209 		return sprintf(buf, "enabled\n");
1210 	case IDXD_DEV_HALTED:
1211 		return sprintf(buf, "halted\n");
1212 	}
1213 
1214 	return sprintf(buf, "unknown\n");
1215 }
1216 static DEVICE_ATTR_RO(state);
1217 
1218 static ssize_t errors_show(struct device *dev,
1219 			   struct device_attribute *attr, char *buf)
1220 {
1221 	struct idxd_device *idxd =
1222 		container_of(dev, struct idxd_device, conf_dev);
1223 	int i, out = 0;
1224 	unsigned long flags;
1225 
1226 	spin_lock_irqsave(&idxd->dev_lock, flags);
1227 	for (i = 0; i < 4; i++)
1228 		out += sprintf(buf + out, "%#018llx ", idxd->sw_err.bits[i]);
1229 	spin_unlock_irqrestore(&idxd->dev_lock, flags);
1230 	out--;
1231 	out += sprintf(buf + out, "\n");
1232 	return out;
1233 }
1234 static DEVICE_ATTR_RO(errors);
1235 
1236 static ssize_t max_tokens_show(struct device *dev,
1237 			       struct device_attribute *attr, char *buf)
1238 {
1239 	struct idxd_device *idxd =
1240 		container_of(dev, struct idxd_device, conf_dev);
1241 
1242 	return sprintf(buf, "%u\n", idxd->max_tokens);
1243 }
1244 static DEVICE_ATTR_RO(max_tokens);
1245 
1246 static ssize_t token_limit_show(struct device *dev,
1247 				struct device_attribute *attr, char *buf)
1248 {
1249 	struct idxd_device *idxd =
1250 		container_of(dev, struct idxd_device, conf_dev);
1251 
1252 	return sprintf(buf, "%u\n", idxd->token_limit);
1253 }
1254 
1255 static ssize_t token_limit_store(struct device *dev,
1256 				 struct device_attribute *attr,
1257 				 const char *buf, size_t count)
1258 {
1259 	struct idxd_device *idxd =
1260 		container_of(dev, struct idxd_device, conf_dev);
1261 	unsigned long val;
1262 	int rc;
1263 
1264 	rc = kstrtoul(buf, 10, &val);
1265 	if (rc < 0)
1266 		return -EINVAL;
1267 
1268 	if (idxd->state == IDXD_DEV_ENABLED)
1269 		return -EPERM;
1270 
1271 	if (!test_bit(IDXD_FLAG_CONFIGURABLE, &idxd->flags))
1272 		return -EPERM;
1273 
1274 	if (!idxd->hw.group_cap.token_limit)
1275 		return -EPERM;
1276 
1277 	if (val > idxd->hw.group_cap.total_tokens)
1278 		return -EINVAL;
1279 
1280 	idxd->token_limit = val;
1281 	return count;
1282 }
1283 static DEVICE_ATTR_RW(token_limit);
1284 
1285 static ssize_t cdev_major_show(struct device *dev,
1286 			       struct device_attribute *attr, char *buf)
1287 {
1288 	struct idxd_device *idxd =
1289 		container_of(dev, struct idxd_device, conf_dev);
1290 
1291 	return sprintf(buf, "%u\n", idxd->major);
1292 }
1293 static DEVICE_ATTR_RO(cdev_major);
1294 
1295 static struct attribute *idxd_device_attributes[] = {
1296 	&dev_attr_max_groups.attr,
1297 	&dev_attr_max_work_queues.attr,
1298 	&dev_attr_max_work_queues_size.attr,
1299 	&dev_attr_max_engines.attr,
1300 	&dev_attr_numa_node.attr,
1301 	&dev_attr_max_batch_size.attr,
1302 	&dev_attr_max_transfer_size.attr,
1303 	&dev_attr_op_cap.attr,
1304 	&dev_attr_configurable.attr,
1305 	&dev_attr_clients.attr,
1306 	&dev_attr_state.attr,
1307 	&dev_attr_errors.attr,
1308 	&dev_attr_max_tokens.attr,
1309 	&dev_attr_token_limit.attr,
1310 	&dev_attr_cdev_major.attr,
1311 	NULL,
1312 };
1313 
1314 static const struct attribute_group idxd_device_attribute_group = {
1315 	.attrs = idxd_device_attributes,
1316 };
1317 
1318 static const struct attribute_group *idxd_attribute_groups[] = {
1319 	&idxd_device_attribute_group,
1320 	NULL,
1321 };
1322 
1323 static int idxd_setup_engine_sysfs(struct idxd_device *idxd)
1324 {
1325 	struct device *dev = &idxd->pdev->dev;
1326 	int i, rc;
1327 
1328 	for (i = 0; i < idxd->max_engines; i++) {
1329 		struct idxd_engine *engine = &idxd->engines[i];
1330 
1331 		engine->conf_dev.parent = &idxd->conf_dev;
1332 		dev_set_name(&engine->conf_dev, "engine%d.%d",
1333 			     idxd->id, engine->id);
1334 		engine->conf_dev.bus = idxd_get_bus_type(idxd);
1335 		engine->conf_dev.groups = idxd_engine_attribute_groups;
1336 		engine->conf_dev.type = &idxd_engine_device_type;
1337 		dev_dbg(dev, "Engine device register: %s\n",
1338 			dev_name(&engine->conf_dev));
1339 		rc = device_register(&engine->conf_dev);
1340 		if (rc < 0) {
1341 			put_device(&engine->conf_dev);
1342 			goto cleanup;
1343 		}
1344 	}
1345 
1346 	return 0;
1347 
1348 cleanup:
1349 	while (i--) {
1350 		struct idxd_engine *engine = &idxd->engines[i];
1351 
1352 		device_unregister(&engine->conf_dev);
1353 	}
1354 	return rc;
1355 }
1356 
1357 static int idxd_setup_group_sysfs(struct idxd_device *idxd)
1358 {
1359 	struct device *dev = &idxd->pdev->dev;
1360 	int i, rc;
1361 
1362 	for (i = 0; i < idxd->max_groups; i++) {
1363 		struct idxd_group *group = &idxd->groups[i];
1364 
1365 		group->conf_dev.parent = &idxd->conf_dev;
1366 		dev_set_name(&group->conf_dev, "group%d.%d",
1367 			     idxd->id, group->id);
1368 		group->conf_dev.bus = idxd_get_bus_type(idxd);
1369 		group->conf_dev.groups = idxd_group_attribute_groups;
1370 		group->conf_dev.type = &idxd_group_device_type;
1371 		dev_dbg(dev, "Group device register: %s\n",
1372 			dev_name(&group->conf_dev));
1373 		rc = device_register(&group->conf_dev);
1374 		if (rc < 0) {
1375 			put_device(&group->conf_dev);
1376 			goto cleanup;
1377 		}
1378 	}
1379 
1380 	return 0;
1381 
1382 cleanup:
1383 	while (i--) {
1384 		struct idxd_group *group = &idxd->groups[i];
1385 
1386 		device_unregister(&group->conf_dev);
1387 	}
1388 	return rc;
1389 }
1390 
1391 static int idxd_setup_wq_sysfs(struct idxd_device *idxd)
1392 {
1393 	struct device *dev = &idxd->pdev->dev;
1394 	int i, rc;
1395 
1396 	for (i = 0; i < idxd->max_wqs; i++) {
1397 		struct idxd_wq *wq = &idxd->wqs[i];
1398 
1399 		wq->conf_dev.parent = &idxd->conf_dev;
1400 		dev_set_name(&wq->conf_dev, "wq%d.%d", idxd->id, wq->id);
1401 		wq->conf_dev.bus = idxd_get_bus_type(idxd);
1402 		wq->conf_dev.groups = idxd_wq_attribute_groups;
1403 		wq->conf_dev.type = &idxd_wq_device_type;
1404 		dev_dbg(dev, "WQ device register: %s\n",
1405 			dev_name(&wq->conf_dev));
1406 		rc = device_register(&wq->conf_dev);
1407 		if (rc < 0) {
1408 			put_device(&wq->conf_dev);
1409 			goto cleanup;
1410 		}
1411 	}
1412 
1413 	return 0;
1414 
1415 cleanup:
1416 	while (i--) {
1417 		struct idxd_wq *wq = &idxd->wqs[i];
1418 
1419 		device_unregister(&wq->conf_dev);
1420 	}
1421 	return rc;
1422 }
1423 
1424 static int idxd_setup_device_sysfs(struct idxd_device *idxd)
1425 {
1426 	struct device *dev = &idxd->pdev->dev;
1427 	int rc;
1428 	char devname[IDXD_NAME_SIZE];
1429 
1430 	sprintf(devname, "%s%d", idxd_get_dev_name(idxd), idxd->id);
1431 	idxd->conf_dev.parent = dev;
1432 	dev_set_name(&idxd->conf_dev, "%s", devname);
1433 	idxd->conf_dev.bus = idxd_get_bus_type(idxd);
1434 	idxd->conf_dev.groups = idxd_attribute_groups;
1435 	idxd->conf_dev.type = idxd_get_device_type(idxd);
1436 
1437 	dev_dbg(dev, "IDXD device register: %s\n", dev_name(&idxd->conf_dev));
1438 	rc = device_register(&idxd->conf_dev);
1439 	if (rc < 0) {
1440 		put_device(&idxd->conf_dev);
1441 		return rc;
1442 	}
1443 
1444 	return 0;
1445 }
1446 
1447 int idxd_setup_sysfs(struct idxd_device *idxd)
1448 {
1449 	struct device *dev = &idxd->pdev->dev;
1450 	int rc;
1451 
1452 	rc = idxd_setup_device_sysfs(idxd);
1453 	if (rc < 0) {
1454 		dev_dbg(dev, "Device sysfs registering failed: %d\n", rc);
1455 		return rc;
1456 	}
1457 
1458 	rc = idxd_setup_wq_sysfs(idxd);
1459 	if (rc < 0) {
1460 		/* unregister conf dev */
1461 		dev_dbg(dev, "Work Queue sysfs registering failed: %d\n", rc);
1462 		return rc;
1463 	}
1464 
1465 	rc = idxd_setup_group_sysfs(idxd);
1466 	if (rc < 0) {
1467 		/* unregister conf dev */
1468 		dev_dbg(dev, "Group sysfs registering failed: %d\n", rc);
1469 		return rc;
1470 	}
1471 
1472 	rc = idxd_setup_engine_sysfs(idxd);
1473 	if (rc < 0) {
1474 		/* unregister conf dev */
1475 		dev_dbg(dev, "Engine sysfs registering failed: %d\n", rc);
1476 		return rc;
1477 	}
1478 
1479 	return 0;
1480 }
1481 
1482 void idxd_cleanup_sysfs(struct idxd_device *idxd)
1483 {
1484 	int i;
1485 
1486 	for (i = 0; i < idxd->max_wqs; i++) {
1487 		struct idxd_wq *wq = &idxd->wqs[i];
1488 
1489 		device_unregister(&wq->conf_dev);
1490 	}
1491 
1492 	for (i = 0; i < idxd->max_engines; i++) {
1493 		struct idxd_engine *engine = &idxd->engines[i];
1494 
1495 		device_unregister(&engine->conf_dev);
1496 	}
1497 
1498 	for (i = 0; i < idxd->max_groups; i++) {
1499 		struct idxd_group *group = &idxd->groups[i];
1500 
1501 		device_unregister(&group->conf_dev);
1502 	}
1503 
1504 	device_unregister(&idxd->conf_dev);
1505 }
1506 
1507 int idxd_register_bus_type(void)
1508 {
1509 	int i, rc;
1510 
1511 	for (i = 0; i < IDXD_TYPE_MAX; i++) {
1512 		rc = bus_register(idxd_bus_types[i]);
1513 		if (rc < 0)
1514 			goto bus_err;
1515 	}
1516 
1517 	return 0;
1518 
1519 bus_err:
1520 	for (; i > 0; i--)
1521 		bus_unregister(idxd_bus_types[i]);
1522 	return rc;
1523 }
1524 
1525 void idxd_unregister_bus_type(void)
1526 {
1527 	int i;
1528 
1529 	for (i = 0; i < IDXD_TYPE_MAX; i++)
1530 		bus_unregister(idxd_bus_types[i]);
1531 }
1532