xref: /linux/drivers/acpi/x86/utils.c (revision 90d32e92011eaae8e70a9169b4e7acf4ca8f9d3a)
1 // SPDX-License-Identifier: GPL-2.0-only
2 /*
3  * X86 ACPI Utility Functions
4  *
5  * Copyright (C) 2017 Hans de Goede <hdegoede@redhat.com>
6  *
7  * Based on various non upstream patches to support the CHT Whiskey Cove PMIC:
8  * Copyright (C) 2013-2015 Intel Corporation. All rights reserved.
9  */
10 
11 #define pr_fmt(fmt) "ACPI: " fmt
12 
13 #include <linux/acpi.h>
14 #include <linux/dmi.h>
15 #include <linux/platform_device.h>
16 #include <asm/cpu_device_id.h>
17 #include <asm/intel-family.h>
18 #include "../internal.h"
19 
20 /*
21  * Some ACPI devices are hidden (status == 0x0) in recent BIOS-es because
22  * some recent Windows drivers bind to one device but poke at multiple
23  * devices at the same time, so the others get hidden.
24  *
25  * Some BIOS-es (temporarily) hide specific APCI devices to work around Windows
26  * driver bugs. We use DMI matching to match known cases of this.
27  *
28  * Likewise sometimes some not-actually present devices are sometimes
29  * reported as present, which may cause issues.
30  *
31  * We work around this by using the below quirk list to override the status
32  * reported by the _STA method with a fixed value (ACPI_STA_DEFAULT or 0).
33  * Note this MUST only be done for devices where this is safe.
34  *
35  * This status overriding is limited to specific CPU (SoC) models both to
36  * avoid potentially causing trouble on other models and because some HIDs
37  * are re-used on different SoCs for completely different devices.
38  */
39 struct override_status_id {
40 	struct acpi_device_id hid[2];
41 	struct x86_cpu_id cpu_ids[2];
42 	struct dmi_system_id dmi_ids[2]; /* Optional */
43 	const char *uid;
44 	const char *path;
45 	unsigned long long status;
46 };
47 
48 #define ENTRY(status, hid, uid, path, cpu_model, dmi...) {		\
49 	{ { hid, }, {} },						\
50 	{ X86_MATCH_INTEL_FAM6_MODEL(cpu_model, NULL), {} },		\
51 	{ { .matches = dmi }, {} },					\
52 	uid,								\
53 	path,								\
54 	status,								\
55 }
56 
57 #define PRESENT_ENTRY_HID(hid, uid, cpu_model, dmi...) \
58 	ENTRY(ACPI_STA_DEFAULT, hid, uid, NULL, cpu_model, dmi)
59 
60 #define NOT_PRESENT_ENTRY_HID(hid, uid, cpu_model, dmi...) \
61 	ENTRY(0, hid, uid, NULL, cpu_model, dmi)
62 
63 #define PRESENT_ENTRY_PATH(path, cpu_model, dmi...) \
64 	ENTRY(ACPI_STA_DEFAULT, "", NULL, path, cpu_model, dmi)
65 
66 #define NOT_PRESENT_ENTRY_PATH(path, cpu_model, dmi...) \
67 	ENTRY(0, "", NULL, path, cpu_model, dmi)
68 
69 static const struct override_status_id override_status_ids[] = {
70 	/*
71 	 * Bay / Cherry Trail PWM directly poked by GPU driver in win10,
72 	 * but Linux uses a separate PWM driver, harmless if not used.
73 	 */
74 	PRESENT_ENTRY_HID("80860F09", "1", ATOM_SILVERMONT, {}),
75 	PRESENT_ENTRY_HID("80862288", "1", ATOM_AIRMONT, {}),
76 
77 	/* The Xiaomi Mi Pad 2 uses PWM2 for touchkeys backlight control */
78 	PRESENT_ENTRY_HID("80862289", "2", ATOM_AIRMONT, {
79 		DMI_MATCH(DMI_SYS_VENDOR, "Xiaomi Inc"),
80 		DMI_MATCH(DMI_PRODUCT_NAME, "Mipad2"),
81 	      }),
82 
83 	/*
84 	 * The INT0002 device is necessary to clear wakeup interrupt sources
85 	 * on Cherry Trail devices, without it we get nobody cared IRQ msgs.
86 	 */
87 	PRESENT_ENTRY_HID("INT0002", "1", ATOM_AIRMONT, {}),
88 	/*
89 	 * On the Dell Venue 11 Pro 7130 and 7139, the DSDT hides
90 	 * the touchscreen ACPI device until a certain time
91 	 * after _SB.PCI0.GFX0.LCD.LCD1._ON gets called has passed
92 	 * *and* _STA has been called at least 3 times since.
93 	 */
94 	PRESENT_ENTRY_HID("SYNA7500", "1", HASWELL_L, {
95 		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
96 		DMI_MATCH(DMI_PRODUCT_NAME, "Venue 11 Pro 7130"),
97 	      }),
98 	PRESENT_ENTRY_HID("SYNA7500", "1", HASWELL_L, {
99 		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
100 		DMI_MATCH(DMI_PRODUCT_NAME, "Venue 11 Pro 7139"),
101 	      }),
102 
103 	/*
104 	 * The Dell XPS 15 9550 has a SMO8110 accelerometer /
105 	 * HDD freefall sensor which is wrongly marked as not present.
106 	 */
107 	PRESENT_ENTRY_HID("SMO8810", "1", SKYLAKE, {
108 		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
109 		DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9550"),
110 	      }),
111 
112 	/*
113 	 * The GPD win BIOS dated 20170221 has disabled the accelerometer, the
114 	 * drivers sometimes cause crashes under Windows and this is how the
115 	 * manufacturer has solved this :|  The DMI match may not seem unique,
116 	 * but it is. In the 67000+ DMI decode dumps from linux-hardware.org
117 	 * only 116 have board_vendor set to "AMI Corporation" and of those 116
118 	 * only the GPD win and pocket entries' board_name is "Default string".
119 	 *
120 	 * Unfortunately the GPD pocket also uses these strings and its BIOS
121 	 * was copy-pasted from the GPD win, so it has a disabled KIOX000A
122 	 * node which we should not enable, thus we also check the BIOS date.
123 	 */
124 	PRESENT_ENTRY_HID("KIOX000A", "1", ATOM_AIRMONT, {
125 		DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
126 		DMI_MATCH(DMI_BOARD_NAME, "Default string"),
127 		DMI_MATCH(DMI_PRODUCT_NAME, "Default string"),
128 		DMI_MATCH(DMI_BIOS_DATE, "02/21/2017")
129 	      }),
130 	PRESENT_ENTRY_HID("KIOX000A", "1", ATOM_AIRMONT, {
131 		DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
132 		DMI_MATCH(DMI_BOARD_NAME, "Default string"),
133 		DMI_MATCH(DMI_PRODUCT_NAME, "Default string"),
134 		DMI_MATCH(DMI_BIOS_DATE, "03/20/2017")
135 	      }),
136 	PRESENT_ENTRY_HID("KIOX000A", "1", ATOM_AIRMONT, {
137 		DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
138 		DMI_MATCH(DMI_BOARD_NAME, "Default string"),
139 		DMI_MATCH(DMI_PRODUCT_NAME, "Default string"),
140 		DMI_MATCH(DMI_BIOS_DATE, "05/25/2017")
141 	      }),
142 
143 	/*
144 	 * The GPD win/pocket have a PCI wifi card, but its DSDT has the SDIO
145 	 * mmc controller enabled and that has a child-device which _PS3
146 	 * method sets a GPIO causing the PCI wifi card to turn off.
147 	 * See above remark about uniqueness of the DMI match.
148 	 */
149 	NOT_PRESENT_ENTRY_PATH("\\_SB_.PCI0.SDHB.BRC1", ATOM_AIRMONT, {
150 		DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
151 		DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"),
152 		DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"),
153 		DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"),
154 	      }),
155 
156 	/*
157 	 * The LSM303D on the Lenovo Yoga Tablet 2 series is present
158 	 * as both ACCL0001 and MAGN0001. As we can only ever register an
159 	 * i2c client for one of them, ignore MAGN0001.
160 	 */
161 	NOT_PRESENT_ENTRY_HID("MAGN0001", "1", ATOM_SILVERMONT, {
162 		DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
163 		DMI_MATCH(DMI_PRODUCT_FAMILY, "YOGATablet2"),
164 	      }),
165 };
166 
167 bool acpi_device_override_status(struct acpi_device *adev, unsigned long long *status)
168 {
169 	bool ret = false;
170 	unsigned int i;
171 
172 	for (i = 0; i < ARRAY_SIZE(override_status_ids); i++) {
173 		if (!x86_match_cpu(override_status_ids[i].cpu_ids))
174 			continue;
175 
176 		if (override_status_ids[i].dmi_ids[0].matches[0].slot &&
177 		    !dmi_check_system(override_status_ids[i].dmi_ids))
178 			continue;
179 
180 		if (override_status_ids[i].path) {
181 			struct acpi_buffer path = { ACPI_ALLOCATE_BUFFER, NULL };
182 			bool match;
183 
184 			if (acpi_get_name(adev->handle, ACPI_FULL_PATHNAME, &path))
185 				continue;
186 
187 			match = strcmp((char *)path.pointer, override_status_ids[i].path) == 0;
188 			kfree(path.pointer);
189 
190 			if (!match)
191 				continue;
192 		} else {
193 			if (acpi_match_device_ids(adev, override_status_ids[i].hid))
194 				continue;
195 
196 			if (!acpi_dev_uid_match(adev, override_status_ids[i].uid))
197 				continue;
198 		}
199 
200 		*status = override_status_ids[i].status;
201 		ret = true;
202 		break;
203 	}
204 
205 	return ret;
206 }
207 
208 /*
209  * AMD systems from Renoir and Lucienne *require* that the NVME controller
210  * is put into D3 over a Modern Standby / suspend-to-idle cycle.
211  *
212  * This is "typically" accomplished using the `StorageD3Enable`
213  * property in the _DSD that is checked via the `acpi_storage_d3` function
214  * but this property was introduced after many of these systems launched
215  * and most OEM systems don't have it in their BIOS.
216  *
217  * The Microsoft documentation for StorageD3Enable mentioned that Windows has
218  * a hardcoded allowlist for D3 support, which was used for these platforms.
219  *
220  * This allows quirking on Linux in a similar fashion.
221  *
222  * Cezanne systems shouldn't *normally* need this as the BIOS includes
223  * StorageD3Enable.  But for two reasons we have added it.
224  * 1) The BIOS on a number of Dell systems have ambiguity
225  *    between the same value used for _ADR on ACPI nodes GPP1.DEV0 and GPP1.NVME.
226  *    GPP1.NVME is needed to get StorageD3Enable node set properly.
227  *    https://bugzilla.kernel.org/show_bug.cgi?id=216440
228  *    https://bugzilla.kernel.org/show_bug.cgi?id=216773
229  *    https://bugzilla.kernel.org/show_bug.cgi?id=217003
230  * 2) On at least one HP system StorageD3Enable is missing on the second NVME
231       disk in the system.
232  */
233 static const struct x86_cpu_id storage_d3_cpu_ids[] = {
234 	X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 24, NULL),  /* Picasso */
235 	X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 96, NULL),	/* Renoir */
236 	X86_MATCH_VENDOR_FAM_MODEL(AMD, 23, 104, NULL),	/* Lucienne */
237 	X86_MATCH_VENDOR_FAM_MODEL(AMD, 25, 80, NULL),	/* Cezanne */
238 	{}
239 };
240 
241 bool force_storage_d3(void)
242 {
243 	return x86_match_cpu(storage_d3_cpu_ids);
244 }
245 
246 /*
247  * x86 ACPI boards which ship with only Android as their factory image usually
248  * declare a whole bunch of bogus I2C devices in their ACPI tables and sometimes
249  * there are issues with serdev devices on these boards too, e.g. the resource
250  * points to the wrong serdev_controller.
251  *
252  * Instantiating I2C / serdev devs for these bogus devs causes various issues,
253  * e.g. GPIO/IRQ resource conflicts because sometimes drivers do bind to them.
254  * The Android x86 kernel fork shipped on these devices has some special code
255  * to remove the bogus I2C clients (and AFAICT serdevs are ignored completely).
256  *
257  * The acpi_quirk_skip_*_enumeration() functions below are used by the I2C or
258  * serdev code to skip instantiating any I2C or serdev devs on broken boards.
259  *
260  * In case of I2C an exception is made for HIDs on the i2c_acpi_known_good_ids
261  * list. These are known to always be correct (and in case of the audio-codecs
262  * the drivers heavily rely on the codec being enumerated through ACPI).
263  *
264  * Note these boards typically do actually have I2C and serdev devices,
265  * just different ones then the ones described in their DSDT. The devices
266  * which are actually present are manually instantiated by the
267  * drivers/platform/x86/x86-android-tablets.c kernel module.
268  */
269 #define ACPI_QUIRK_SKIP_I2C_CLIENTS				BIT(0)
270 #define ACPI_QUIRK_UART1_SKIP					BIT(1)
271 #define ACPI_QUIRK_UART1_TTY_UART2_SKIP				BIT(2)
272 #define ACPI_QUIRK_PNP_UART1_SKIP				BIT(3)
273 #define ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY			BIT(4)
274 #define ACPI_QUIRK_USE_ACPI_AC_AND_BATTERY			BIT(5)
275 #define ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS			BIT(6)
276 
277 static const struct dmi_system_id acpi_quirk_skip_dmi_ids[] = {
278 	/*
279 	 * 1. Devices with only the skip / don't-skip AC and battery quirks,
280 	 *    sorted alphabetically.
281 	 */
282 	{
283 		/* ECS EF20EA, AXP288 PMIC but uses separate fuel-gauge */
284 		.matches = {
285 			DMI_MATCH(DMI_PRODUCT_NAME, "EF20EA"),
286 		},
287 		.driver_data = (void *)ACPI_QUIRK_USE_ACPI_AC_AND_BATTERY
288 	},
289 	{
290 		/* Lenovo Ideapad Miix 320, AXP288 PMIC, separate fuel-gauge */
291 		.matches = {
292 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
293 			DMI_MATCH(DMI_PRODUCT_NAME, "80XF"),
294 			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"),
295 		},
296 		.driver_data = (void *)ACPI_QUIRK_USE_ACPI_AC_AND_BATTERY
297 	},
298 
299 	/*
300 	 * 2. Devices which also have the skip i2c/serdev quirks and which
301 	 *    need the x86-android-tablets module to properly work.
302 	 */
303 #if IS_ENABLED(CONFIG_X86_ANDROID_TABLETS)
304 	{
305 		/* Acer Iconia One 7 B1-750 */
306 		.matches = {
307 			DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
308 			DMI_MATCH(DMI_PRODUCT_NAME, "VESPA2"),
309 		},
310 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
311 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
312 					ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
313 	},
314 	{
315 		.matches = {
316 			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
317 			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ME176C"),
318 		},
319 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
320 					ACPI_QUIRK_UART1_TTY_UART2_SKIP |
321 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
322 					ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
323 	},
324 	{
325 		/* Lenovo Yoga Book X90F/L */
326 		.matches = {
327 			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
328 			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "CHERRYVIEW D1 PLATFORM"),
329 			DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "YETI-11"),
330 		},
331 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
332 					ACPI_QUIRK_UART1_SKIP |
333 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
334 					ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
335 	},
336 	{
337 		.matches = {
338 			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
339 			DMI_MATCH(DMI_PRODUCT_NAME, "TF103C"),
340 		},
341 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
342 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
343 					ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
344 	},
345 	{
346 		/* Lenovo Yoga Tablet 2 1050F/L */
347 		.matches = {
348 			DMI_MATCH(DMI_SYS_VENDOR, "Intel Corp."),
349 			DMI_MATCH(DMI_PRODUCT_NAME, "VALLEYVIEW C0 PLATFORM"),
350 			DMI_MATCH(DMI_BOARD_NAME, "BYT-T FFD8"),
351 			/* Partial match on beginning of BIOS version */
352 			DMI_MATCH(DMI_BIOS_VERSION, "BLADE_21"),
353 		},
354 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
355 					ACPI_QUIRK_PNP_UART1_SKIP |
356 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY),
357 	},
358 	{
359 		/* Lenovo Yoga Tab 3 Pro X90F */
360 		.matches = {
361 			DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
362 			DMI_MATCH(DMI_PRODUCT_NAME, "CHERRYVIEW D1 PLATFORM"),
363 			DMI_MATCH(DMI_PRODUCT_VERSION, "Blade3-10A-001"),
364 		},
365 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
366 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY),
367 	},
368 	{
369 		/* Medion Lifetab S10346 */
370 		.matches = {
371 			DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
372 			DMI_MATCH(DMI_BOARD_NAME, "Aptio CRB"),
373 			/* Way too generic, also match on BIOS data */
374 			DMI_MATCH(DMI_BIOS_DATE, "10/22/2015"),
375 		},
376 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
377 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY),
378 	},
379 	{
380 		/* Nextbook Ares 8 (BYT version)*/
381 		.matches = {
382 			DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
383 			DMI_MATCH(DMI_PRODUCT_NAME, "M890BAP"),
384 		},
385 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
386 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY |
387 					ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS),
388 	},
389 	{
390 		/* Nextbook Ares 8A (CHT version)*/
391 		.matches = {
392 			DMI_MATCH(DMI_SYS_VENDOR, "Insyde"),
393 			DMI_MATCH(DMI_PRODUCT_NAME, "CherryTrail"),
394 			DMI_MATCH(DMI_BIOS_VERSION, "M882"),
395 		},
396 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
397 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY),
398 	},
399 	{
400 		/* Whitelabel (sold as various brands) TM800A550L */
401 		.matches = {
402 			DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),
403 			DMI_MATCH(DMI_BOARD_NAME, "Aptio CRB"),
404 			/* Above strings are too generic, also match on BIOS version */
405 			DMI_MATCH(DMI_BIOS_VERSION, "ZY-8-BI-PX4S70VTR400-X423B-005-D"),
406 		},
407 		.driver_data = (void *)(ACPI_QUIRK_SKIP_I2C_CLIENTS |
408 					ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY),
409 	},
410 #endif
411 	{}
412 };
413 
414 #if IS_ENABLED(CONFIG_X86_ANDROID_TABLETS)
415 static const struct acpi_device_id i2c_acpi_known_good_ids[] = {
416 	{ "10EC5640", 0 }, /* RealTek ALC5640 audio codec */
417 	{ "10EC5651", 0 }, /* RealTek ALC5651 audio codec */
418 	{ "INT33F4", 0 },  /* X-Powers AXP288 PMIC */
419 	{ "INT33FD", 0 },  /* Intel Crystal Cove PMIC */
420 	{ "INT34D3", 0 },  /* Intel Whiskey Cove PMIC */
421 	{ "NPCE69A", 0 },  /* Asus Transformer keyboard dock */
422 	{}
423 };
424 
425 bool acpi_quirk_skip_i2c_client_enumeration(struct acpi_device *adev)
426 {
427 	const struct dmi_system_id *dmi_id;
428 	long quirks;
429 
430 	dmi_id = dmi_first_match(acpi_quirk_skip_dmi_ids);
431 	if (!dmi_id)
432 		return false;
433 
434 	quirks = (unsigned long)dmi_id->driver_data;
435 	if (!(quirks & ACPI_QUIRK_SKIP_I2C_CLIENTS))
436 		return false;
437 
438 	return acpi_match_device_ids(adev, i2c_acpi_known_good_ids);
439 }
440 EXPORT_SYMBOL_GPL(acpi_quirk_skip_i2c_client_enumeration);
441 
442 static int acpi_dmi_skip_serdev_enumeration(struct device *controller_parent, bool *skip)
443 {
444 	struct acpi_device *adev = ACPI_COMPANION(controller_parent);
445 	const struct dmi_system_id *dmi_id;
446 	long quirks = 0;
447 	u64 uid;
448 	int ret;
449 
450 	ret = acpi_dev_uid_to_integer(adev, &uid);
451 	if (ret)
452 		return 0;
453 
454 	dmi_id = dmi_first_match(acpi_quirk_skip_dmi_ids);
455 	if (dmi_id)
456 		quirks = (unsigned long)dmi_id->driver_data;
457 
458 	if (!dev_is_platform(controller_parent)) {
459 		/* PNP enumerated UARTs */
460 		if ((quirks & ACPI_QUIRK_PNP_UART1_SKIP) && uid == 1)
461 			*skip = true;
462 
463 		return 0;
464 	}
465 
466 	if ((quirks & ACPI_QUIRK_UART1_SKIP) && uid == 1)
467 		*skip = true;
468 
469 	if (quirks & ACPI_QUIRK_UART1_TTY_UART2_SKIP) {
470 		if (uid == 1)
471 			return -ENODEV; /* Create tty cdev instead of serdev */
472 
473 		if (uid == 2)
474 			*skip = true;
475 	}
476 
477 	return 0;
478 }
479 
480 bool acpi_quirk_skip_gpio_event_handlers(void)
481 {
482 	const struct dmi_system_id *dmi_id;
483 	long quirks;
484 
485 	dmi_id = dmi_first_match(acpi_quirk_skip_dmi_ids);
486 	if (!dmi_id)
487 		return false;
488 
489 	quirks = (unsigned long)dmi_id->driver_data;
490 	return (quirks & ACPI_QUIRK_SKIP_GPIO_EVENT_HANDLERS);
491 }
492 EXPORT_SYMBOL_GPL(acpi_quirk_skip_gpio_event_handlers);
493 #else
494 static int acpi_dmi_skip_serdev_enumeration(struct device *controller_parent, bool *skip)
495 {
496 	return 0;
497 }
498 #endif
499 
500 int acpi_quirk_skip_serdev_enumeration(struct device *controller_parent, bool *skip)
501 {
502 	struct acpi_device *adev = ACPI_COMPANION(controller_parent);
503 
504 	*skip = false;
505 
506 	/*
507 	 * The DELL0501 ACPI HID represents an UART (CID is set to PNP0501) with
508 	 * a backlight-controller attached. There is no separate ACPI device with
509 	 * an UartSerialBusV2() resource to model the backlight-controller.
510 	 * Set skip to true so that the tty core creates a serdev ctrl device.
511 	 * The backlight driver will manually create the serdev client device.
512 	 */
513 	if (acpi_dev_hid_match(adev, "DELL0501")) {
514 		*skip = true;
515 		/*
516 		 * Create a platform dev for dell-uart-backlight to bind to.
517 		 * This is a static device, so no need to store the result.
518 		 */
519 		platform_device_register_simple("dell-uart-backlight", PLATFORM_DEVID_NONE,
520 						NULL, 0);
521 		return 0;
522 	}
523 
524 	return acpi_dmi_skip_serdev_enumeration(controller_parent, skip);
525 }
526 EXPORT_SYMBOL_GPL(acpi_quirk_skip_serdev_enumeration);
527 
528 /* Lists of PMIC ACPI HIDs with an (often better) native charger driver */
529 static const struct {
530 	const char *hid;
531 	int hrv;
532 } acpi_skip_ac_and_battery_pmic_ids[] = {
533 	{ "INT33F4", -1 }, /* X-Powers AXP288 PMIC */
534 	{ "INT34D3",  3 }, /* Intel Cherrytrail Whiskey Cove PMIC */
535 };
536 
537 bool acpi_quirk_skip_acpi_ac_and_battery(void)
538 {
539 	const struct dmi_system_id *dmi_id;
540 	long quirks = 0;
541 	int i;
542 
543 	dmi_id = dmi_first_match(acpi_quirk_skip_dmi_ids);
544 	if (dmi_id)
545 		quirks = (unsigned long)dmi_id->driver_data;
546 
547 	if (quirks & ACPI_QUIRK_SKIP_ACPI_AC_AND_BATTERY)
548 		return true;
549 
550 	if (quirks & ACPI_QUIRK_USE_ACPI_AC_AND_BATTERY)
551 		return false;
552 
553 	for (i = 0; i < ARRAY_SIZE(acpi_skip_ac_and_battery_pmic_ids); i++) {
554 		if (acpi_dev_present(acpi_skip_ac_and_battery_pmic_ids[i].hid, "1",
555 				     acpi_skip_ac_and_battery_pmic_ids[i].hrv)) {
556 			pr_info_once("found native %s PMIC, skipping ACPI AC and battery devices\n",
557 				     acpi_skip_ac_and_battery_pmic_ids[i].hid);
558 			return true;
559 		}
560 	}
561 
562 	return false;
563 }
564 EXPORT_SYMBOL_GPL(acpi_quirk_skip_acpi_ac_and_battery);
565 
566 /* This section provides a workaround for a specific x86 system
567  * which requires disabling of mwait to work correctly.
568  */
569 static int __init acpi_proc_quirk_set_no_mwait(const struct dmi_system_id *id)
570 {
571 	pr_notice("%s detected - disabling mwait for CPU C-states\n",
572 		  id->ident);
573 	boot_option_idle_override = IDLE_NOMWAIT;
574 	return 0;
575 }
576 
577 static const struct dmi_system_id acpi_proc_quirk_mwait_dmi_table[] __initconst = {
578 	{
579 		.callback = acpi_proc_quirk_set_no_mwait,
580 		.ident = "Extensa 5220",
581 		.matches =  {
582 			DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies LTD"),
583 			DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
584 			DMI_MATCH(DMI_PRODUCT_VERSION, "0100"),
585 			DMI_MATCH(DMI_BOARD_NAME, "Columbia"),
586 		},
587 		.driver_data = NULL,
588 	},
589 	{}
590 };
591 
592 void __init acpi_proc_quirk_mwait_check(void)
593 {
594 	/*
595 	 * Check whether the system is DMI table. If yes, OSPM
596 	 * should not use mwait for CPU-states.
597 	 */
598 	dmi_check_system(acpi_proc_quirk_mwait_dmi_table);
599 }
600